GitLab

The tap visualizer mojo app creates a fullscreen widget in the overlay
container. It draws "tap point" circles in that widget. When the
display work area changes (for example, after display rotation) the
widget needs to be resized. Add a layout manager that handles the
resize.

In theory we should do this for maximized and pinned windows as well.
However, I'm limiting it to fullscreen windows because I intend to
backport the fix to M69. (The bug is a user-visible regression that
affects recording demo videos on detachable and tablet devices.)

Bug: 869130
Test: ash_unittests, enable "Show taps" in about:flags, rotate display, tap near the bottom of the display
Change-Id: If54c65e2964f2a709c707e255c1b80d8e16666d9
Reviewed-on: https://chromium-review.googlesource.com/1165956Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581364}

R=cmasso@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I948b0310563d88cd52bc5a96b0fd67469d8edffd
Reviewed-on: https://chromium-review.googlesource.com/1166200Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581363}

There is a bug where users can keep their clamshell mode context menu
open by detaching the keyboard. This allows users to have a side shelf
in tablet mode, and they may get stuck in this state.

This CL fixes the bug by explicitly closing menus when tablet mode state
changes.

Bug: 870469
Change-Id: I72bb42733000077947219f5868d32615738ab80d
Reviewed-on: https://chromium-review.googlesource.com/1165699
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581362}

The inverted background tab design doesn't work at all with pre-Refresh tabs.

Bug: 870844
Change-Id: I598b92ed8d6e8fa8b586166fb7352df1d13c8360
Reviewed-on: https://chromium-review.googlesource.com/1163316Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581361}

Enable the .png image upload by default. Change the options drop down
menu to only have one option with hardcoded string "*.jpeg, *.jpg,
*png".

Screenshot:
https://screenshot.googleplex.com/1sd8JoBoM14.png
https://screenshot.googleplex.com/5mnsxOtRxJD.png

Bug: 864303
Change-Id: I3b041d0f4e08898fa0c6998742a8ce04065ab5ac
Reviewed-on: https://chromium-review.googlesource.com/1166027
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581360}

This reverts commit 5e61a5b7.

Reason for revert: Seems to be calling LSAN problems on linux:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29

BUG:  871986

Original change's description:
> Handle legacy camera app in consolidated icon
> 
> This CL does 2 things:
> 1. Hide legacy camera app icon
> 2. Launch legacy camera app (com.android.camera2) when
> com.google.android.GoogleCameraArc is not available.
> 
> Sometimes when devices are upgraded from version with Camera2 installed,
> GCA still has com.android.camera2 as the package name. That's why this
> CL is needed.
> 
> Bug: b:112121210
> Test: Tested on nautilus that after this CL, the legacy camera app icon
> 
> Change-Id: I16e4d29d4cb538bd2ad6607456bcf4667be1f188
> Reviewed-on: https://chromium-review.googlesource.com/1127899
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Sheng-hao Tsao <shenghao@google.com>
> Cr-Commit-Position: refs/heads/master@{#581047}

TBR=stevenjb@chromium.org,shenghao@google.com

Change-Id: Ibd24eb5f9821e23a3986fbabc45db3d3ed14c81b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:112121210
Reviewed-on: https://chromium-review.googlesource.com/1166004Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581359}

When browser is not fully running, Profile cannot be accessed.
This CL also disables the use of toast as it is very expensive when
full browser is not running.

BUG=695115

Change-Id: I7560e3684307741e0a1ba01ec8efec0ff97fdbc4
Reviewed-on: https://chromium-review.googlesource.com/1165849Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581358}

There ought to be one small layout test diff,
https://test-results.appspot.com/data/layout_results/linux_trusty_blink_rel/34136/layout-test-results/results.html

Change-Id: I3468dff4ae22a7ea9b9d38b7e3896b33f65b7666
Reviewed-on: https://chromium-review.googlesource.com/1165831Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581357}

This class adds the required infrastructure to generalize sharing across
content types.  This comes down to adding an async API to
OfflineContentProvider to request the URI (if available) to use in
generating a share intent.  This also adds the utility class to build
the intent from that set of OfflineItems and share info (URI)s.

TBR=petewil@chromium.org

BUG=850780

Change-Id: If9d5d4f01a8559bec90b7de1adb70c8aaafa9302
Reviewed-on: https://chromium-review.googlesource.com/1105125Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581356}

The macro is a no-op since
https://chromium-review.googlesource.com/c/chromium/src/+/1093015.

Bug: 589840
Change-Id: I4fe4479d5dbfe9116032933bcde8c8889be0ebd2
Reviewed-on: https://chromium-review.googlesource.com/1165644Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581355}

Adds kAutofillCreditCardEnabled and kAutofillProfileEnabled to
the extensions prefs API

Bug: 870328
Change-Id: Ic5961b3cd58c58381764f6eddf2698df72db8695
Reviewed-on: https://chromium-review.googlesource.com/1161002Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581354}

Per instructions in bugs, updated:
- Settings/reminders text.
- Mini UI padding/typography.

Bug: b:112311203, b:112312304
Change-Id: If9b0041043fb7f9a716173260cc798a52e5adac8
Reviewed-on: https://chromium-review.googlesource.com/1165950Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#581353}

TBR=bnc@chromium.org

Change-Id: Ic5f394b608925fa5bfd0343a4e69572eb0f327e0
Reviewed-on: https://chromium-review.googlesource.com/1164546Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581352}

The catalog includes test_ws as standalone service so that
ServiceManager could launch it with --enable-features=Mash and
--enable-service-binary-launcher;

Bug: 866942
Change-Id: I898aa4644b0bf4307c667afdf4959d9f9c829d2b
Reviewed-on: https://chromium-review.googlesource.com/1164079Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581351}

This is reland of https://crrev.com/c/1164570

Change summary: A header view may outlive the target widget,
which can be differet widget. Reset the reference and check
before calling target widget.

Bug: b/112240082
Test: covered by unittests
Change-Id: Ia98d44a487b6cd2077b110e4a9799780cdbc4ebe
Reviewed-on: https://chromium-review.googlesource.com/1165697
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581350}

This is the first step in supporting uploads for Background Fetch

Bug: 774054
Change-Id: I13188181573fcd8464df0729a09190a42b5bd2d0
Reviewed-on: https://chromium-review.googlesource.com/1160848Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581349}

Bug: 854675
Change-Id: Ic1366d927ef3918ff21c8656a4f90baf30768557
Reviewed-on: https://chromium-review.googlesource.com/1164384
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581348}

This is the first in a series of changes to migrate the video capture
stack over to the new Chromium shmem APIs. This change adds the use of
base::ReadOnlySharedMemoryRegion as an alternative to mojo shared_buffer
handles.

Bug: 797470,843117
Change-Id: Ifa51a4984f48376a5da4b437618d301669f1ae1e
Reviewed-on: https://chromium-review.googlesource.com/1164637Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581347}

Use default constructed (null) CompletionOnceCallbacks instead of
default constructed (null) CompletionCallbacks in tests.  Since this
compiles, that means that all APIs have already been converted to take
CompletionOnceCallbacks, and the CompletionCallbacks (alias for
CompletionRepeatingCallback) before this CL were immediately cast into
CompletionOnceCallbacks anyway, so this change really does not modify
behavior.

Bug: 807724
Change-Id: I03c3b5dc1f77e76d7780748a4334b743053d69ef
Reviewed-on: https://chromium-review.googlesource.com/1159200Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581346}

This library is needed to on-demand install dynamic feature modules.

Bug: 862681
Change-Id: I6d4f76e614c464bdbd4fb3be7c69d1a583a75f1b
Reviewed-on: https://chromium-review.googlesource.com/1151531Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581345}

This CL migrates all in-progress cache metadata to level DB.
The current implementation uses a file to store all in-progress data,
which is not very scalable.
This CL rewrites the current implemetation to use level DB.
It also migrates the existing data from that file, and destroys it on
success.
UMAs are provided to track the migration and the DownloadDB.

Bug: 870502
Change-Id: I7494b72e89ba68627f635666a62c9a29d211f46b
Reviewed-on: https://chromium-review.googlesource.com/1163996Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581344}

The default JsonPrefStore task runner is used instead of injecting one.
Remaining use cases didn't require sharing the task runner except one
(to flush), but CommitPendingWrite()'s async reply API already provides
this functionality and we use it in this CL instead of exposing the
entire task runner (which is also more readable then implicitly
depending on the impl flushing right away on its task runner).

This is another take on hanxi's https://crrev.com/c/1153632
after debugging it locally I realized RundownTaskCounter needs to
observe the notification synchronously (as the WaitableEvent prevents
observing the reply). A nested Runloop is also not suitable (ref.
https://crbug.com/318527 and in code comments).

Note: JsonPrefStore's optional constructor params were flipped since the task
runner is now the most likely optional parameter.

This CL is a precursor to:
https://crrev.com/c/1148959.

R=sky@chromium.org

Bug: 848615, 318527
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I24c03cb2e49ec667e592d7a78722cdaf0884af36
Reviewed-on: https://chromium-review.googlesource.com/1163628
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581343}

This function lives in //content/browser despite being intended to
be used by child processes. The function body is trivial and can be
inlined into every caller. This lets us remove one dependency from
app to browser.

Bug: 855193
Change-Id: Ia9558b4298275a5638500ebcd65361073be838b9
Reviewed-on: https://chromium-review.googlesource.com/1159394Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581342}

This dependency was added when crashpad fallback handler was added
to chrome.exe, but this dependency should be delay load as it's
only used when uploading a crash report.

BUG=870463

Change-Id: I180fd151f9d0c79c850fe818b87138b311066cc1
Reviewed-on: https://chromium-review.googlesource.com/1160797Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581341}

Security requires fingerprint lock out after too many attempts. So remove
try again later from the message.
See discussion in go/cros-fingerprint

Bug: 835357
Change-Id: Id3551dceb0d80d3f839172c1e321ff168c8b8c92
Reviewed-on: https://chromium-review.googlesource.com/1165951Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581340}

This reverts commit 96cfcfde.

Reason for revert: reenable Telemetry perf benchmark coverage

Original change's description:
> Temporarily disable Telemetry perf test on Mac builders
> 
> NOTRY=true  # covered by PRESUBMIT tests
> 
> Bug: 868675
> Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
> Change-Id: Ia5fb548ba314edda307b5b7d7d7d27ff9e24fb30
> Reviewed-on: https://chromium-review.googlesource.com/1164565
> Reviewed-by: David Tu <dtu@chromium.org>
> Commit-Queue: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#581082}

TBR=dtu@chromium.org,nednguyen@google.com

Change-Id: Ifaf628ca1d733df24365e5231f687b4e20eb467a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 868675
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Reviewed-on: https://chromium-review.googlesource.com/1166122Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#581339}

https://android.googlesource.com/platform/external/perfetto.git/+log/ef73f7b272a5..181422428b90


git log ef73f7b272a5..181422428b90 --date=short --no-merges --format='%ad %ae %s'
2018-08-07 primiano@google.com Merge "Introduce legacy JSON importer and "slices" vtable"
2018-08-07 hjd@google.com Merge "perfetto-ui: Remove ControllerProxy"


Created with:
  gclient setdep -r src/third_party/perfetto@181422428b90

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I905941ad24b71dc080873ea61e2758fa01e67eb6
Reviewed-on: https://chromium-review.googlesource.com/1165326Reviewed-by: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581338}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/67c8e92b..cbcf8cb1

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I62acaa6bf12836a1f83725fe55cce74f8ba42b0d
Reviewed-on: https://chromium-review.googlesource.com/1165600Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581337}

Bug: 734672
Change-Id: I97941d577b6993170b4f5a506e51a9451623dccd
Reviewed-on: https://chromium-review.googlesource.com/1162772
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581336}

OOBE now has a white background across the entire display. The status area tray
icons were not visible in this environment.

Bug: 857221
Change-Id: I025b8f0d243df6be4d1b0258628dc72730467341
Reviewed-on: https://chromium-review.googlesource.com/1162780
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581335}

The class is deprecated. Eliminate empty methods. Inline code from
remaining methods.

TBR=rcui@chromium.org

Bug: 866523
Change-Id: I6c785a5c58b4b95f2a3b543ab80b66610fc88519
Reviewed-on: https://chromium-review.googlesource.com/1164629Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581334}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3cd5de0de3a1..36668c6ef51c


Created with:
  gclient setdep -r src-internal@36668c6ef51c

The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I17d28747972146fad6119e8c029b9fa57db7702d
Reviewed-on: https://chromium-review.googlesource.com/1165627Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581333}

BUG=871784
TBR=joenotcharles@chromium.org
NOTRY=true

Change-Id: If114b2364922392b3e9a56c62a47dd45f1101b62
Reviewed-on: https://chromium-review.googlesource.com/1165832Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581332}

This crash can happen when a user turns data saver off after the InfoBar
is shown, but before the page is closed. In this case, it is fine to
ignore reporting the opt out as the user will not see the InfoBar again
until they turn data saver back on.

Bug: 871835
Change-Id: I6ab20290e64cb31179e4473d95fe892ce47e6b94
Reviewed-on: https://chromium-review.googlesource.com/1165623Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581331}

The hovered tab state was visually too close to active state
so this CL reduces the opacity. The method for calculating
interpolation range and hover radial gradient opacity is
changed to use target contrast ratios. This approach ideally
will adapt better to various themes and color schemes,
ensuring the right level of contrast by adjusting opacity
automatically.

Bug: 856893
Change-Id: I2799b722c1d84d7c323e4f587fa8f5e58106bf58
Reviewed-on: https://chromium-review.googlesource.com/1147605
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581330}

The original problem has been fixed in the latest Widevine CDM.

Bug: 847591,851027
Test: This CL enables a test
Change-Id: I3245bb98672b9ae872354d9f2ac6b419bc0b84b4
Reviewed-on: https://chromium-review.googlesource.com/1162907
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581329}

Instead of providing an object that creates fake framebuffers in tests,
create fake GbmBuffers and import them into the fake DrmDevice.

Bug: 869206
Test: ozone_unittests
Change-Id: Ib00eb4befeda0ffd9299499b1f451036fa1aa2bb
Reviewed-on: https://chromium-review.googlesource.com/1162656
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581328}

GET or HEAD, per https://fetch.spec.whatwg.org/#origin-header.

Bug: 860478
Change-Id: I1dfda7fb630fbd200c5ed635228ebf81dd003156
Reviewed-on: https://chromium-review.googlesource.com/1165163
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581327}

Caused by a DCHECK crash from a pointer pointing to deallocated memory.

Bug: 866535
Change-Id: I96d76aeaeb8c89316cd6ffb237928cd2bfcfb744
Reviewed-on: https://chromium-review.googlesource.com/1165850Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581326}

ChromeVox can be run as both compressed (minified js) and uncompressed. The latter facilitates faster development.

It appears that in some instances, with the kevin board in particular, gn evaluates the ChromeVox build file incorrectly.

The end result is we end up with both uncompressed and compressed js files in ChromeVox leading to duplicate js objects.

Bug: 868579
Test: clean build for
1. prior to this patch
2. after this patch

Before each deployment, ensure we delete the chromevox folder on-device. This should be equilvanet to a new image.

Change-Id: I64cf826bda9239edc7764ba598bfed6dd0572d56
Reviewed-on: https://chromium-review.googlesource.com/1165787Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581325}