- 30 Apr, 2018 40 commits
-
-
Patrick Noland authored
There are scenarios where we fail to bootstrap the source id from Java. This also means that we fail to setup the page for metrics reporting. If the page is not set up, calls to RecordEventMetrics will crash. Until we understand why the bootstrapping can fail and fix that, this CL will cause us to drop events without a valid source id so that we don't crash. Bug: 832712 Change-Id: I4a01c8cf7a9eaae645960dc17dada8a4b5cdd3fa Reviewed-on: https://chromium-review.googlesource.com/1033959 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#554767}
-
John Chen authored
Adjust when to retry while connecting to DevTools. The retry timeout now starts at 1 second, with exponential backoff, up to 16 seconds. Bug: 826150 Change-Id: Ia8dfdd27ab88ac6f466555a943810242188604d6 Reviewed-on: https://chromium-review.googlesource.com/1034385Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#554766}
-
https://skia.googlesource.com/skia.git/+log/58b90f7f1757..82cb619314cf $ git log 58b90f7f1..82cb61931 --date=short --no-merges --format='%ad %ae %s' 2018-04-30 borenet [infra] Calmbench: fix path to nanobench executable 2018-04-27 brianosman Add test to ensure that skcms' sRGB turns into Skia's sRGB color space Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I0e4641826f30a7fb53445297263be2ab3c5144c3 Reviewed-on: https://chromium-review.googlesource.com/1034843Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554765}
-
Jonathon Kereliuk authored
Previously we only supported the old dialect here. This CL only adds the new endpoints and keeps the old. spec: https://w3c.github.io/webdriver/#list-of-endpoints Bug: chromedriver:2406 Change-Id: Ib0c3cc1d71764e833f7c50748472a20598bbeefa Reviewed-on: https://chromium-review.googlesource.com/1034962Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#554764}
-
Fredrik Söderquist authored
Since SVGImage is handled explicitly already, and we pass kDoNotRespectImageOrientation to IntrinsicSize() in these functions, just call Image::Size() directly rather than passing through the ImageResourceContent method. Bug: 773272 Change-Id: I6b7c24f5be425f04cd2f68cbc4612054b635bc2b Reviewed-on: https://chromium-review.googlesource.com/1032745Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#554763}
-
Kevin Bailey authored
When in keyword mode, results will be from that search provider, except for a single WYT search at the bottom. It looks odd to have a different search there, when the user asked for a keyword search. This CL doesn't add the match in that case. Bug: 837395 Change-Id: I1441a6fe07f5d1e7ac5cd3dc16de408df6ad18c9 Reviewed-on: https://chromium-review.googlesource.com/1030613Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#554762}
-
David Bokan authored
Add a rAF before starting the test. My guess is that on slow bots the the gesture starts before the layers are initialized and pushed to the compositor's acive tree so the entire gesture gets ignored. Bug: 836623 Change-Id: I1c54e31b4fb064926d8ad94da4bb8d9751332067 Reviewed-on: https://chromium-review.googlesource.com/1034010Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#554761}
-
Justin Donnelly authored
This will bring the iOS suggestion UI to parity with the Android UI. Note that there is evidence that the refinement arrows next to URLs see a significant amount of usage (though not as much as the query refinement arrows). See the bug for more details. Bug: 679083 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I10aad6b630cdc7c598643a2ef35f4bd3d476ec01 Reviewed-on: https://chromium-review.googlesource.com/1033714Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#554760}
-
Emily Stark authored
Previously, we were treating all blob: URLs as nonsecure for the purposes of HTTP-Bad: namely, all blob: URLs would get a security level of HTTP_SHOW_WARNING. Instead, we now use the origin of the blob: URL to determine whether the security level should be HTTP_SHOW_WARNING (for nonsecure origins) or NONE (for secure origins). Bug: 797533 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I5400aaad91b55c3330d01c43bba5056b7351f723 Reviewed-on: https://chromium-review.googlesource.com/1031529 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#554759}
-
Quinten Yearsley authored
Change-Id: I5f4004b03dee29cd8d4bbdd03b597caf916f140d Reviewed-on: https://chromium-review.googlesource.com/1034295Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#554758}
-
Max Moroz authored
The same reason as for sanitizers that are already disabled, as the target doesn't use libc which is needed for compiler-rt instrumentations. Bug: 789981, 759794 Change-Id: I3a997bd017154ba1fc41b3b39ff74af3627637a5 Reviewed-on: https://chromium-review.googlesource.com/1034284Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#554757}
-
Eric Willigers authored
Rebase of patch by Victoria Su: https://chromium-review.googlesource.com/c/chromium/src/+/900564 Design doc: https://docs.google.com/document/d/1ZUNf4eXIABKYtOb2IWdzkHqMSC9GWgX5740McqQ5ur0/edit?usp=sharing Intent to implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/BLBHKKG90DM/MxokOGuaBwAJ :is will stay behind a flag until there is consensus on the name: https://github.com/w3c/csswg-drafts/issues/2143 Bug: 808904 Change-Id: Ic113277d0d2af3217d92a52498fb9c5fccb5ceae Reviewed-on: https://chromium-review.googlesource.com/1034032 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#554756}
-
Nico Weber authored
While here, also s/LLVM_ON_WIN32/_WIN32/ since LLVM_ON_WIN32 is going away and _WIN32 is the same thing. Bug: none Change-Id: I64f813b4d4c488fbd9ff7601416e29b4b1973a10 Reviewed-on: https://chromium-review.googlesource.com/1035103 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#554755}
-
Sahel Sharify authored
This cl disables UIResourceLostBeforeCommit.RunSingleThread_DelegatingRenderer on linux tsan. TBR=danakj@chromium.org,vmiura@chromium.org Bug: 803532 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8c74bbe6593839f5232edda101c334d771fb6d0c Reviewed-on: https://chromium-review.googlesource.com/1034844 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#554754}
-
Eric Stevenson authored
Change-Id: I638d810e7f48d5567938b19a0e28085b30d53b0b Reviewed-on: https://chromium-review.googlesource.com/1033828Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#554753}
-
Reza.Zakerinasab authored
In canvas color management code we used gamma linearity of the color space of the image to detect its color type. This is not correct and can be fixed by using the new SkImage::colorType() member function. Bug: 811303 Change-Id: I31584a6b0b5224f16d82184d1636f1349d350f3a Reviewed-on: https://chromium-review.googlesource.com/1032853 Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#554752}
-
https://webrtc.googlesource.com/src.git/+log/28899d0791c4..f22550175b96 $ git log 28899d079..f22550175 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:836790 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I26166138cbd471259278d52ced61cd964ba3075b Reviewed-on: https://chromium-review.googlesource.com/1034462Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554751}
-
Paul Jensen authored
Remove load flag duplication. This has caused problems twice. Re-enabling test. Bug: 830707 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I09cd172b4e55236a138ce8fde4f7b002e4a1bf10 Reviewed-on: https://chromium-review.googlesource.com/1034074Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#554750}
-
Christos Froussios authored
It is flaky TBR=caitkp@chromium.org Bug: 838124 Change-Id: If142522d8c3cbf996775deabfb3e03012b192908 Reviewed-on: https://chromium-review.googlesource.com/1034902Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#554749}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 50cce18b. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16549 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure TBR=lukebjerring No-Export: true Change-Id: I16eb56232d372474f53c53c9f92b0c60f1228d23 Reviewed-on: https://chromium-review.googlesource.com/1034596 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#554748}
-
csharrison authored
This is all dead code now that PlzNavigate has shipped. This CL should have no intended behavior changes. Bug: 789577 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ifcf05eee1a4486cdf89b8f658bbd2212f0b74bc5 Reviewed-on: https://chromium-review.googlesource.com/1022631 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#554747}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b77ccdf1..1c736c3e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If331770a463194d68b6aa5064f7da7a157207097 Reviewed-on: https://chromium-review.googlesource.com/1034598Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#554746}
-
Aleks Totic authored
Anonymous blocks were passing indefinite block percentage resolution size to their children. The fix is to handle anonymous blocks like we do anonymous fragments, and use ParentPercentageResolutionSize(). Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I147e92570a60b84aa0b840201542d98c0517e82e Reviewed-on: https://chromium-review.googlesource.com/1034094Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#554745}
-
Reza.Zakerinasab authored
Bug: 837963 TBR: junov@chromium.org Change-Id: Ifa500e548d67c87034829b51b230b2d5152c4c1f Reviewed-on: https://chromium-review.googlesource.com/1034463Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#554744}
-
Leonard Grey authored
This reverts commit 5e0ca406. Reason for revert: https://crbug.com/837825 Original change's description: > Don't try to update window title on non-titled browsers > > This causes two unnecessary layouts of BrowserView, each of which causes > three layouts of ToolbarView, each of which causes a whole bunch of > things to happen. > > ChromeOS is excluded since even on a tabbed browser, it relies on > the title to be updated to set the accessibility title. > > Bug: 835983 > Change-Id: I4a62579f8fae394a6c11eb7c8632da176452b00d > Reviewed-on: https://chromium-review.googlesource.com/1024828 > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554040} TBR=ellyjones@chromium.org,lgrey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 835983 Change-Id: I238505c04e1943ce45d69e46c18f633c376acc02 Reviewed-on: https://chromium-review.googlesource.com/1034762Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#554743}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Idfa47ca98804e2f2f9ac6c7a3f4e6a76bffd328d Reviewed-on: https://chromium-review.googlesource.com/1034782 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554742}
-
Peter K. Lee authored
To enable relayout of Infobar based on experiment flags, consolidation helps with wholesale changes of these layout constants. Bug: 804652 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0764fb5b8c0b85723f6a3e24169d345f6ea24497 Reviewed-on: https://chromium-review.googlesource.com/1033502Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#554741}
-
Raphael Kubo da Costa authored
[LegacyArrayClass] was removed from the spec in https://github.com/w3c/fxtf-drafts/issues/280, and was dropped from WebIDL altogether in https://github.com/heycam/webidl/pull/551. Change-Id: I1d43d3af24dd61e3ec5e8a2423ce9e492c9f5e39 Reviewed-on: https://chromium-review.googlesource.com/1034060Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#554740}
-
Greg Kraynov authored
Required in order to move Blink's scheduler/base to //base. Bug: 783309 Change-Id: I3d6b183a1639988f54b6104cba8543d27d8f410f Reviewed-on: https://chromium-review.googlesource.com/1033745Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#554739}
-
Randy Rossi authored
This is the start of porting the automation extension api found in /chrome into cast. The duplicated code will eventually be de-duped when time permits. (Please refer to 78586840 for more info on this). Some implementation methods are stubbed temporarily until more supporting classes are brought in. PS 1 is baseline for copied files. Modifications on top of that in PS >=2 Bug: 73383411 Test: None Change-Id: Id9307fa875b5f16cd337a1529713e4c795f99212 Reviewed-on: https://chromium-review.googlesource.com/1030712 Commit-Queue: Randy Rossi <rmrossi@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554738}
-
Elly Fong-Jones authored
The infobar isn't supported at all in MacViews builds. TBR=andrewhayden@chromium.org Bug: 834754 Change-Id: I476fe3e1373d26d1c013011f1a33fbfce80a9ad1 Reviewed-on: https://chromium-review.googlesource.com/1032758Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#554737}
-
Tim Schumann authored
The MockDelegate was unused and very out of date. Change-Id: Ibae0116fb2a078df4d2fa37b4c0a6e0c80e25aac Reviewed-on: https://chromium-review.googlesource.com/1034688Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#554736}
-
https://skia.googlesource.com/skia.git/+log/efb4d08dd43c..58b90f7f1757 $ git log efb4d08dd..58b90f7f1 --date=short --no-merges --format='%ad %ae %s' 2018-04-27 liyuqian Raise exceptions from child threads to the main thread Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I41ed7729e923026c60c51f98ff7104c2f61d4d3e Reviewed-on: https://chromium-review.googlesource.com/1034461 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554735}
-
Christos Froussios authored
The test fails very often, and sometimes times out. See bug. No-try: true No-presubmit: true Bug: 838120 Change-Id: Ibdc63e23418b47757b53f079bb2841f35d9cf65c Reviewed-on: https://chromium-review.googlesource.com/1034802 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#554734}
-
Justin Cohen authored
Bug: 833941 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iecd425473551185e2c0ff381480a7bddd46cb108 Reviewed-on: https://chromium-review.googlesource.com/1034219Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#554733}
-
Francois Doray authored
When a task posted to TaskScheduler waits on a WaitableEvent, the pool capacity is automatically incremented after a short delay (https://cs.chromium.org/chromium/src/base/synchronization/waitable_event_win.cc?l=72&rcl=c60b0bcd6830c32c30128867e55a53f27642df5f and https://cs.chromium.org/chromium/src/base/synchronization/waitable_event_posix.cc?l=166&rcl=c60b0bcd6830c32c30128867e55a53f27642df5f and https://cs.chromium.org/chromium/src/base/synchronization/waitable_event_mac.cc?l=115&rcl=c60b0bcd6830c32c30128867e55a53f27642df5f). This is desirable in production (if a task blocks for a long time, another thread is created and the number of tasks that are using the CPU stays constant). However, it is undesirable when a WaitableEvent is used in TaskScheduler tests, because it leads to hard to predict changes of pool capacity. This CL adds a ScopedClearBlockingObserverForTesting annotation to all WaitableEvent::Wait that happen in code that tests SchedulerWorkerPoolImpl, to avoid these hard to predict changes of pool capacity. The annotation is not needed when the WaitableEvent::Wait doesn't happen on a thread managed by SchedulerWorkerPoolImpl, because that already has no effect on pool capacity. Bug: 768436 Change-Id: Ie166ca55f914d89c5dd0fe6dad9ae1533e0f6c29 Reviewed-on: https://chromium-review.googlesource.com/1033533Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#554732}
-
Manuel Rego Casasnovas authored
This patch modifies LayoutBox::ComputeReplacedLogicalWidth|HeightUsing() so it's aware of the orthogonal flow cases. For example to compute the relative widths of replaced elements, if the element direction is perpendicular to its containing block it should use the containing block height instead of the width. BUG=837146 TEST=external/wpt/css/css-writing-modes/sizing-percentages-replaced-orthogonal-001.html Change-Id: I655c984703e2073be9a3a649ac79a63f8c136cc0 Reviewed-on: https://chromium-review.googlesource.com/1029852Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#554731}
-
Mikel Astiz authored
Instead of reading progress markers from the directory, use the UpdateHandler interface, which is supported in USS as well. Some optional but somewhat related test changes are bundled in this patch, although they are not required to pass tests. Bug: 836289 Change-Id: I5a62f27a92aa089a2aa19d4a50aa680c38387c3f Reviewed-on: https://chromium-review.googlesource.com/1033752 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#554730}
-
Christos Froussios authored
The following test crash consistently virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-cookies-redirect.any.html virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-cookies-redirect.any.worker.html virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-preflight-star.any.html virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-preflight-star.any.worker.html virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-preflight.any.html virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-preflight.any.worker.html virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-redirect-preflight.any.html virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-redirect-preflight.any.worker.html virtual/outofblink-cors/external/wpt/service-workers/service-worker/fetch-canvas-tainting-video-cache.https.html virtual/outofblink-cors/external/wpt/service-workers/service-worker/fetch-canvas-tainting-video.https.html No-try: true No-Presubmit: true Bug: 838057 Change-Id: I327e21e628b34b710f4df2f2b171bbf80363893a Reviewed-on: https://chromium-review.googlesource.com/1034689Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#554729}
-
Juan Antonio Navarro Perez authored
Depends on: https://chromium-review.googlesource.com/c/catapult/+/1032790 Bug: 831199 Change-Id: If395a0a33ba5ae7cb64db11c693a43030aad1838 Reviewed-on: https://chromium-review.googlesource.com/1032748Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#554728}
-