- 26 Jun, 2018 40 commits
-
-
Lu Chen authored
Use mojom to send metrics of anchor elements from the renderer process to the browser process. In future CLs, the features on the browser side will be aggregated. Features from both renderer and browser will be analyzed and used to take some actions accordingly. Bug: 850624 Change-Id: Iaf36b64c5668db6ccf6b61c6ff7ffe40367f436b Reviewed-on: https://chromium-review.googlesource.com/1105402Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Lu Chen <chelu@chromium.org> Cr-Commit-Position: refs/heads/master@{#570476}
-
Xiaohan Wang authored
- Update KeySystemSupportImpl to check kDisableAcceleratedVideoDecode and kMojoVideoDecoder. - Update KeySystemSupportImpl to call ContentBrowserClient to query hardware secure decryption capabilities. - Add ContentBrowserClient::GetHardwareSecureDecryptionCaps(). - Implement ChromeContentBrowserClient::GetHardwareSecureDecryptionCaps(). - Add GetWidevineHardwareCaps() to check Widevine-specific caps on Windows. - Rename kEnableHardwareSecureCodecsForTesting to kOverrideHardwareSecureCodecsForTesting to better reflect that fact that real platform hardware secure codecs check will be skipped. Bug: 848532 Test: Added unit test. Change-Id: Ia931fc945e5eb2fd406793cf87e334f3f9e00256 Reviewed-on: https://chromium-review.googlesource.com/1106960Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#570475}
-
yuqinganniesun authored
Block VrShellGl::InitializeGl until surface is set. R=cjgrant@chromium.org, mthiesse@chromium.org Change-Id: I31f18f3a8ed805174f5fd8e77ce99fc8ec539c59 Reviewed-on: https://chromium-review.googlesource.com/1099610Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Annie Sun <yuqinganniesun@chromium.org> Cr-Commit-Position: refs/heads/master@{#570474}
-
Jun Cai authored
Network Service: Recategorize VariationsHttpHeadersBrowserTest.TestStrippingHeadersFromInternalRequest This CL recategorizes VariationsHttpHeadersBrowserTest.TestStrippingHeadersFromInternalRequest to a URLFetcher related bug. Bug: 841309 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ie90d7c364358da31e5e66472c54a80a6d05ab074 Reviewed-on: https://chromium-review.googlesource.com/1113943Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#570473}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0c816cd2..afc734c9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Iad81610928bbbdca2d76dc46666a57a5f720304a Reviewed-on: https://chromium-review.googlesource.com/1115088Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570472}
-
Jonghyun Ahn authored
Bug: 856378 Change-Id: I41ec3fb062184979105c20db48fbef485e5b365f Reviewed-on: https://chromium-review.googlesource.com/1114469Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Jong Ahn <jongahn@google.com> Cr-Commit-Position: refs/heads/master@{#570471}
-
Sadrul Habib Chowdhury authored
BUG=778749 Change-Id: I35cf5c2f9c391fc019fe13f2d1d8d31b3cb948ed Reviewed-on: https://chromium-review.googlesource.com/1114466Reviewed-by:
Emily Hanley <eyaich@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#570470}
-
Garrett Beaty authored
DCHECKs are defined as do-nothing operations when the product is released, but all of the existing trybots enable DCHECKs so that violations of expectations can be surfaced early. However, if the expression used as a condition has important side effects, then disabling DCHECKs changes the meaning of the code and this won't be discovered until the product is actually released. Adding a config with DCHECKs disabled will enable creating a trybot to surface errors around side effects in DCHECK conditions earlier. Bug: 833482 Change-Id: I687d81735b070fa4ec480072b9372f4ae0f7aa9a Reviewed-on: https://chromium-review.googlesource.com/1112653 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#570469}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3b6ffda0. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20258 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I6e8a7fd60452d831febddd55ebf9dcc16d3d6c91 Reviewed-on: https://chromium-review.googlesource.com/1115087 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#570468}
-
Tiger Oakes authored
Also edited places where methods from AndroidSyncSettings are called. This blocks some other related CLs which do more clean up in other classes. Continuation of work in bug 646094. See https://chromium-review.googlesource.com/c/chromium/src/+/1082667 for the original CL that the others were split from. Bug: 846456 Change-Id: Ic0e080faccc662bee72d1cddc420a9474031b700 Reviewed-on: https://chromium-review.googlesource.com/1097474 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#570467}
-
Greg Kerr authored
Cryptohome's custom async event loop is being deprecated, so this transitions to calling the modern MigrateKeyEx. Bug: 211405 Cq-depend: CL:1108967 Change-Id: I36482b4c41cf5802c71dd39ea368e076bba4b4b7 Reviewed-on: https://chromium-review.googlesource.com/1108972Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#570466}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a75aa3b2c314..7c37ca183640 git log a75aa3b2c314..7c37ca183640 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 geofflang@chromium.org RendererGL: Limit warning output to 5 per message type. Created with: gclient setdep -r src/third_party/angle@7c37ca183640 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:768943 TBR=ynovikov@chromium.org Change-Id: If59c2a30bc13fb845937e8b1e4dffca4333793ae Reviewed-on: https://chromium-review.googlesource.com/1115198Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570465}
-
Mark Pilgrim authored
TBR=sky@chromium.org Bug: 844990 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9f2caa470570053c539da83f9cac1d93f11a0b98 Reviewed-on: https://chromium-review.googlesource.com/1101562 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#570464}
-
Mathieu Perreault authored
Bug: 850571 Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_expired --test-launcher-interactive Change-Id: Ifff7c246587ad9ac59c8dc02bafc2905d81b4758 Reviewed-on: https://chromium-review.googlesource.com/1112499Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Moe Ahmadi (OOO until July 3) <mahmadi@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#570463}
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a9969b2..41b7748 BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I4288fe6edef1d6eb7259ca7bf0039d3b4d90e42d Reviewed-on: https://chromium-review.googlesource.com/1114269Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#570462}
-
Jinsuk Kim authored
Adds a unit test for https://crrev.com/c/1102823. Verified that the test fails before, but passes after the CL. Bug: b/78251221 Change-Id: Ib68ebe7675820ecea7b09061335aa9c821c99e95 Reviewed-on: https://chromium-review.googlesource.com/1112893 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#570461}
-
Dale Curtis authored
FFmpeg won't strip any trailing audio data without end discard being specified in the container, even if the container says the duration of the last packet is smaller than what's decoded. In fact it mostly just has hard coded values for the number samples coming out of the decoding process unfortunately. This change uses the packet duration information for AAC decodes to drop the last few samples. Hopefully at some point in the future it is possible for ffmpeg to do something smarter internally. There is some risk to this approach. Media with invalid duration information may now end up losing data. We may need to restrict this workaround to just the last packet in a given stream. This doesn't fix AAC audio decoded via <audio> or <video> tags, only WebAudio's decodeAudioData(). FFmpegDemuxer (src=) and ChunkDemuxer (MSE) don't agree on how packet duration is reported when applying discard padding, so we can't use that duration to trim the packet. Which isn't really a problem since plain src= tags can't splice streams and MSE requires an explicit appendWindow for correctness. BUG=668999 TEST=updated unittest expectations. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I68d579a68ae476407b89f8398a892090d17c9edd Reviewed-on: https://chromium-review.googlesource.com/1114094 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#570460}
-
Aaron Leventhal authored
Include convenience scripts and documentation for easier use of ax_dump_* tools. Much easier to get tree and event dumps from Chrome, Chromium and Firefox. Provides guidance and error messages when it cannot initialize due to incorrect or not enough info about the desired window/process. Bug: None Change-Id: I0fb35f3e1cf5c6609ab811d87f61d7c34ccd8bfd Reviewed-on: https://chromium-review.googlesource.com/1113674Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#570459}
-
Raymond Toy authored
Bug: 855070 Change-Id: If5adab90c16f3ef4d074c1b31a5d952b9cd0a0c3 Reviewed-on: https://chromium-review.googlesource.com/1112380 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#570458}
-
David Black authored
Previously, the Assistant container was not explicitly clipping its children. This became evident with the recent enabling of a UI related flag (see bug for details). Bug: b:110714235 Change-Id: I9ecee42ccb821a93b53f4a1bf8310beb4af420a2 Reviewed-on: https://chromium-review.googlesource.com/1114241Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#570457}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f46710802ad5..c1b6066263b1 git log f46710802ad5..c1b6066263b1 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 robertphillips@google.com Fix instantiation of partially lazy proxies 2018-06-26 egdaniel@google.com Move Vulkan DebugCallback code into tools. Created with: gclient setdep -r src/third_party/skia@c1b6066263b1 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: Icdc947d8af8c0d772da97237fcfbc520f15f9c87 Reviewed-on: https://chromium-review.googlesource.com/1115058Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570456}
-
James Cook authored
Supporting ChromeVox for out-of-process views applications requires the ability to serialize ui::AXEvent over mojo. Split out of https://chromium-review.googlesource.com/1099572 because that CL is getting too big. Bug: 851578 Change-Id: Id92f9025e880f3e7d2055c0f445152330a468d9b Reviewed-on: https://chromium-review.googlesource.com/1114139Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#570455}
-
Daniel Bratell authored
The latest version of fontconfig requires uuid/uuid.h so we need to install that in install-build-deps.sh. (Only tested in Ubuntu 16.04) Bug: 856666,829890 Change-Id: I586aa703e24a1ea2c10d08948acad37ce177f70f Reviewed-on: https://chromium-review.googlesource.com/1115129 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#570454}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/11513e359cd6..a1b1806c9eea git log 11513e359cd6..a1b1806c9eea --date=short --no-merges --format='%ad %ae %s' 2018-06-26 dtu@chromium.org [pinpoint] Fix JobState._Compare() for jobs with no comparison_mode. 2018-06-26 dtu@chromium.org [pinpoint] Add gitiles_service.CommitInfo stub to test.TestCase. Created with: gclient setdep -r src/third_party/catapult@a1b1806c9eea The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ice0331aebc2811403beca1312f8124de08ae7d3c Reviewed-on: https://chromium-review.googlesource.com/1115061Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570453}
-
Darren Shen authored
Disable TabManagerTest.TabPendingFreezeAndUnfreeze TabManagerTest.TabFreezeAndUnfreeze was incorrectly disabled. TBR=fdoray@chromium.org Bug: 855874 Change-Id: If525e002423677ce9547a404d7bb44d22b5dcdbe Reviewed-on: https://chromium-review.googlesource.com/1114414 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#570452}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f7789c6e8958..fe288eb687b8 git log f7789c6e8958..fe288eb687b8 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 ssilkin@webrtc.org Don't call deprecated FFmpeg API. 2018-06-26 titovartem@webrtc.org Extract fft4g into separate build target 2018-06-26 brandtr@webrtc.org Fix potential division by zero in VP9 VideoCodecTest. 2018-06-26 terelius@webrtc.org Style fixes in event log unittest. 2018-06-26 terelius@webrtc.org Revert "Add Timestamp accessor methods to the EncodedImage class." 2018-06-26 minyue@webrtc.org Adding NetEq lifetime stats to event log visualizer. 2018-06-26 saza@webrtc.org Fix overflow in digital AGC1 2018-06-26 terelius@webrtc.org Rewrite the RtcEventLog unit test. 2018-06-26 nisse@webrtc.org Delete unused class TransformAdapter. 2018-06-26 nisse@webrtc.org Add Timestamp accessor methods to the EncodedImage class. Created with: gclient setdep -r src/third_party/webrtc@fe288eb687b8 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:855900 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I595f6469b0e05b8bc636c6a7edb5dd8bf5033ab8 Reviewed-on: https://chromium-review.googlesource.com/1115060Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570451}
-
Yiming Zhou authored
The Action Recorder Extension is a Chrome Extension that records user actions inside Chrome and serialize the recording into a JSON test recipe file. An automation framework can then execute the test recipe file as a test. One such automation framework is the Autofill Desktop Automation Framework. Action Recorder Extension Eng Design Doc: https://docs.google.com/document/d/1JUigAf309sFkeiM7cNLnVlKJhxKKAr1kmYpR-FmaaWQ/edit# The new design makes a number of improvements over the previous version of the Extension. The old version has a number of issues, among these are: 1. The extension violates Chrome Extension development best practice by using persistent background scripts. Persistent background scripts are bad for Chrome performance. 2. The extension is unnecessarily intrusive. The extension records user actions on every tab regardless whether the user targets the tab for recording, and regardless of whether the user is actively recording a recipe. In other words, the extension records user action even when it shouldn't be recording. 3. The old version has a number of bugs when generating unique XPath for HTML elements. The extension may generate an XPath that returns 0 elements, or an XPath that returns multiple elements. 4. The extension hides errors and fails silently. In addition to addressing these problems, the new extension also adds the following features: 1. The new extension records Chrome Autofill actions. 2. The new extension prompts the user to download the recipe as a file when recording ends. 3. The new extension displays a UI listing all the actions the extension has recorded in the recipe. Bug: 855284 Change-Id: I35c8f0077082162881a35afdeb305fff4f8e7f87 Reviewed-on: https://chromium-review.googlesource.com/1099734 Commit-Queue: Yiming Zhou <uwyiming@google.com> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#570450}
-
Chris Harrelson authored
The reasons to have one are: * the PaintLayer is for a stacking context, or * the PaintLayer has at least one non-stacked child. Allocate and update stacking nodes during the descendant-dependent tree walk. Related to the above, removes a bunch of calls to PaintLayerStackingNode::UpdateLayerListsIfNeeded() which should not be needed, because now the method called during the descendant-dependent flags update. Bug: 831762 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id43787f6a8c2e962ec856306edbb89a11fd4f624 Reviewed-on: https://chromium-review.googlesource.com/1106962 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#570449}
-
sangwoo.ko authored
When tabs are tiny, we shouldn't take away removed tab's width. That's because an inactive tab will become active and widen. In this case we should subtract only inactive tab's width. Bug: 850190 Change-Id: Iba35a66bb4d1b20c66c678e716599cbd0f71046d Reviewed-on: https://chromium-review.googlesource.com/1111763 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#570448}
-
Aleks Totic authored
Thanks xiaochengh for filing this bug. Bug: 855749 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib0e53b94573872baccef84eddbfa341163190646 Reviewed-on: https://chromium-review.googlesource.com/1114341Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#570447}
-
Parastoo Geranmayeh authored
Sometimes, server misidentifies countries and states, and we can handle it with rationalization. This usually happens when the form/field signature of the two are identical. See go/rationalize-repeated-fields. Tests + Refactoring. Fixes: www.coolstuffinc.com + bbc shipping/billing. Bug: 850220 Change-Id: I95cf22154d39a417a618e5d9252a3a0ff70b747a Reviewed-on: https://chromium-review.googlesource.com/1115078 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#570446}
-
Sahel Sharify authored
This is a reland of ae116dff Original change's description: > fast/events/wheel/* layout tests use gpu benchmarking. > > This cl changes the layouttests in fast/events/wheel to use gpu benchmarking > for sending events rather than event sender. > > The cl excludes the following tests for the following reasons: > > To change these tests we need to implement touchpad fling (swipe) in GPU > benchmarking: > -mainthread-touchpad-fling-latching.html > -wheel-fling-cancel.html > > These tests are skipped since they are related to wheel events only rather > than scrolling: > -wheelevent-constructor.html > -wheelevent-ctrl.html > -wheelevent-document-createevent.html > -wheelevent-handler-count.html > > This test will be changed in a different cl among with tests that need > platform specific wheel DOM event expectation. > -wheelevent-in-scrolling-div.html > > Bug: 846424 > Change-Id: I086e6a7f4f62dce61a838d616a471bd030139e93 > Reviewed-on: https://chromium-review.googlesource.com/1103149 > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569371} Bug: 846424 Change-Id: I4f73d065b8330202edb0678ca5d41ec8969a8339 Reviewed-on: https://chromium-review.googlesource.com/1115178Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#570445}
-
Fernando Serboncini authored
Currently, blink_platform_perf_tests fail due to missinitialization of threaded support on Platforms. Unifying the environment setup guarantess that this code wont drif apart in the future and fix current issues. Change-Id: Iea240c2dfab2ab0500d6b53d1617d3d1670b309e Reviewed-on: https://chromium-review.googlesource.com/1114927Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#570444}
-
Ramya Nagarajan authored
Bug: 839152 Change-Id: If93bf60fa882bd54f4f16acb84a17efe536d3dbe Reviewed-on: https://chromium-review.googlesource.com/1112648Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#570443}
-
edchin authored
Scrolling and tapping on the page control makes the scroll very erratic. This CL disables the page control when dragging the scroll. Bug: 826047 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifca03ea1936c1a90150f1ffadf301eac8ee0791d Reviewed-on: https://chromium-review.googlesource.com/1114328 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#570442}
-
Mustaq Ahmed authored
The test has past issues, and also fails with User Activation v2. Since the code being tested is deprecated, it only makes sense to disbale the test. Bug: 855655 Change-Id: I6f997e8b341c09135b021068c44191d12bd939a9 Reviewed-on: https://chromium-review.googlesource.com/1115085Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#570441}
-
John Abd-El-Malek authored
Also while updating these unittests, I realized contextual_suggestions_fetcher_impl_unittest.cc and feed_networking_host_unittest.cc can be simplified so I updated them. Bug: 844949 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2a527c2f854a29d0809ab57c81599e813a8146dc Reviewed-on: https://chromium-review.googlesource.com/1107487 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Moe Ahmadi (OOO until July 3) <mahmadi@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#570440}
-
Oscar Johansson authored
When building using Jumbo files gets merged. This results in a conflict with the namespace prefs in views/media_router/cloud_services_dialog_view.cc. This commit solves this by specifying that the global namespace should be used, by adding the "::" prefix. Bug: 773275 Change-Id: I4803ef96e32ae8a1d9f4c54b3cf95780ecedb6e5 Reviewed-on: https://chromium-review.googlesource.com/1114838 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#570439}
-
danakj authored
Currently it uses the LayerTreeHostClient to pass a bool around from RenderWidget to RenderWidgetCompositor, and constructs the cc structures in RenderWidget, when RenderWidgetCompositor is meant to be wrapping them, so it could just create them. But expose the cc::LayerTreeSettings to RenderWidget so that tests have a chance to override those, instead. They don't need to be able to replace the LayerTreeHost/AnimationHost types. NOTRY=true TBR=pdr Bug: 838693 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If7742e248b3d8799d1590dee43ce2eeb7e516146 Reviewed-on: https://chromium-review.googlesource.com/1112595 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#570438}
-
Dale Curtis authored
This reverts commit 4cd9a604. Reason for revert: Not correct. AudioBus must be zeroed by the code using it. It's intentionally left uninitialized since AudioBus objects may be quite large and frequently created only to be copied into. Zero'ing always adds unnecessary overhead. Original change's description: > Zero AudioBus internal aligned memory > > This prevents from reading uninitialized memory according to MSAN > reports. > > Change-Id: Ifccecf69e6df67ab1d2226155a20455ca5c6e293 > > BUG=856537 > > Change-Id: Ifccecf69e6df67ab1d2226155a20455ca5c6e293 > Reviewed-on: https://chromium-review.googlesource.com/1113935 > Reviewed-by: Max Morin <maxmorin@chromium.org> > Commit-Queue: Max Morin <maxmorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570367} TBR=sabbakumov@yandex-team.ru,maxmorin@chromium.org Change-Id: I87734786f9bbe2513f972572c65c9fc52a1aa114 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 856537 Reviewed-on: https://chromium-review.googlesource.com/1115298Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#570437}
-