- 09 Apr, 2020 40 commits
-
-
Austin Tankiang authored
Bug: None Change-Id: I67d1337c2b72ed23937863bdd33db52de9ac8383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143025Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#757746}
-
Alan Cutter authored
This CL updates ChromeLauncherControllerTest.WebAppPolicy* to be ShelfWebAppBrowserTest.WebAppPolicy* tests and removes the dependency on web apps being Extensions. Bug: 1068919, 1054116 Change-Id: I0a89b926d1ff2184896c03f608879a3265922a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141397Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#757745}
-
Henrique Ferreiro authored
Migrate this test out of third_party/blink/web_tests/css3/filters/ and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Additionally, rename svg-relative-urls-0001.html to svg-relative-urls-001.html, and add this test as a second test for the same use case. Bug: 1063749 Change-Id: Ifc0a6abfa45a6e6ad16f08388210ddcb0286142a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135755Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#757744}
-
Henrique Ferreiro authored
Migrate this test out of third_party/blink/web_tests/css3/filters/ and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: Ib1b0b13c1d02e80dd11ec63afaeeb34c13eb2a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134242Reviewed-by:
-
Devlin Cronin authored
Add documentation on how to use the chrome.test API, including the core functionality of the API and when to use it, different common methods, design patterns, and do's and don't's. Bug: 1049047 Change-Id: I23130140b4c9ae1247d3703452357895ec265691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133558 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#757742}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves remaining chromeOS strings from settings_strings.grdp to chromeos_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I296e0c4768f75e49176e76f9b308b26f44f5a168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142585 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#757741}
-
Samuel Huang authored
extract_unwind_tables.py calls dump_syms, and processes ~400 MB of data from ~105 M lines. Previously these data were written to a temp file, which is then opened and read line-by-line. This approach creates churn, and is prone to out-of-disk-space problem. This CL removes temp file usage by directly piping dump_syms output to _ParseCfiData(), using subprocess.Popen(bufsize=-1)'s |stdout|. Run time is unaffected. Fixed: 1068862 Change-Id: Iaa0d433dcb91a8b15fff4dd6ce0a34fcba8d6376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141220 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#757740}
-
Kuo-Hsin Yang authored
When ARC is launched, the min filelist configuration may be changed, notify the change to the memory component. BUG=1014871 TEST=check the swap configuration after ARC launch. Change-Id: Ib7d074c4183ff3e7323eb582bf0c8706ec612d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141488Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#757739}
-
Andrew Comminos authored
Updates the isInputPending implementation to use a discrete/continuous predicate options object, rather than the old list of events. Alters the scheduler tracking to accept a (stubbed out) delegate for querying event attribution information, now that we have it. Bug: 910421 Change-Id: I7aadbdca00cb7c396de1c595f75b365522c204b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130895Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#757738}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I13adf3c6501afb8ff19a5f4444e9379b260b1c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143553Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757737}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/68219bfacaa8..dcf3a9b3dce1 git log 68219bfacaa8..dcf3a9b3dce1 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader ba0c95eb406f..3cfa8e28be80 (9 commits) Created with: gclient setdep -r src/third_party/skia@dcf3a9b3dce1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I6ad6415c9d1de5c36b337938f67bab9a2623e421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143552Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for apps section page from settings_strings.grdp to chromeos_strings.grdp and os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I8411437ef5af1c445941ac3a494a92a52fa4b548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142776 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5dcf1b66..2d536d03 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ida0e8b83b986f4a997ba89dedb8e9e281b280ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142501Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757734}
-
Nicholas Verne authored
The Restore operation only happens if the Crostini container upgrade failed. Bug: 1064915 Change-Id: I5b3b0e1bce6c26d756e6fb9e70346736740b63fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141568Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#757733}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5d56a75005e3..c72a211d0090 git log 5d56a75005e3..c72a211d0090 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 carmenjackson@google.com Update the default systrace tags to the recommended Android defaults. Created with: gclient setdep -r src/third_party/catapult@c72a211d0090 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: eseckler@google.com Change-Id: Ia616f4c4fda9de3b9020d87bde64807a62f8abc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142978Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f9f8e4b0d42d..c4e55491a936 git log f9f8e4b0d42d..c4e55491a936 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@c4e55491a936 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I126dd8dad9d4335e18c346f737016ca8a16eef67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142985Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for internet page from settings_strings.grdp to chromeos_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I835813d7a5a98269aba997950326c1661735fcc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142766Reviewed-by:
-
Chris Hall authored
- Refactor and simplify next/previous unignored sibling methods on AXNode. - Add extensive documentation, both interface and implementation. - Add more extensive and finer-grained unit tests. R=aboxhall,dmazzoni,aleventhal,janewman@microsoft.com,ethavar@microsoft.com Change-Id: Idd85a35de6a0cfa314dfba7255c22bc58005f1e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102269 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Jacques Newman <janewman@microsoft.com> Reviewed-by:
Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#757729}
-
Mei Liang authored
The composing favicon logic comes from the explore_sites::ImageHelper. This CL moves the composing logic to a different class, so it can be shared with the FaviconHelper. In addition, this CL integrate the composing logic to FaviconHelper. Change-Id: I267d5611979875ae28e7df09bf0ef02c2206058e Bug: 1064153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123513 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757728}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8d8bae65e67d..15398905e2cd git log 8d8bae65e67d..15398905e2cd --date=short --first-parent --format='%ad %ae %s' 2020-04-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e20438c5..6c7769b5 (757496:757605) Created with: gclient setdep -r src/third_party/webrtc@15398905e2cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4b64fbdac67857cbb07ceddc92fee6328d1ae430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142974Reviewed-by:
-
Noel Gordon authored
This API was public: I assumed I would need for testing. Turns out no, it's not needed for testing, so make it private. Bug: 1035691, 1061388 Change-Id: I1672d1e9764de5d98ba87b29f0a7823a35dda844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143095 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#757726}
-
Bartek Nowierski authored
Change-Id: Iff85302bb633d9166139bde65a9b627eec13c4d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139951Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#757725}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ac910b82. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 239eeaa8 "[css-filters] Migrate effect-reference-image.html to WPT" 29baa8ce "[css-filters] Migrate effect-reference-image-hw.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I007c5df260af10c9f37fe7b787568ac19e935176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142499Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757724}
-
Yu Han authored
Previous to this CL, during manual slot assignment, if an exception is thrown, the state of the HTMLSlotElement is indeterminate. HTMLSlotElement should be restored to the previous state where previous assigned nodes are preserved. This CL implements this behavior by doing the exception check of assigned nodes before the actual assignment. Thus, if an exception is encountered, the assign() function could just return, preserving the previous state. However, this way of doing slot assignment adds an extra loop for assigned nodes. I had tried to do it in one loop. But that required saving the previous state of the Slot and restoring it if exception is detected. I think the added complexity isn't worth it for the little performance benefit. In addition, I made sure that the state of the candidate_assigned_slot_map_ is accurate after each slot assignment recalc. The previous implementation could leave removed nodes still in the map. Because in SlotAssignment:RecalcAssignment(), the children traversal, NodeTraversal::ChildrenOf(owner_->host(), wouldn't encounter removed nodes. Bug: 869308 Change-Id: I3c8938f1c4360d664497b6d16a7753c545729e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124293 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#757723}
-
Kent Tamura authored
This CL has no user-visible behavior changes Bug: 1067527 Change-Id: Ied6beefbdefb438be69f18132930bafed6b6581a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139178 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#757722}
-
Mei Liang authored
Change-Id: Ic59bacb6dce73f6f0431422833cded8be3fb2987 Bug: 1068820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141451 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
RtcVideoEncoder doesn't pass ScalingSettings by webrtc::VideoEncoder::GetEncoderInfo() due to crbug.com/1034686. I misunderstood the qp value of ScalingSettings at that time. This is the first step to fix the issue and pass webrtc media::ScalingSettings given by VEA::GetEncoderInfo(); This makes media::ScalingSettings in media::VideoEncoderInfo be base::Optional so that RtcVideoEncoder can set webrtc::ScalingSettings only if VEA provides non nullopt media::ScalingSettings. Bug: 1067522 Test: webrtc.* on eve Change-Id: I585452bf22216ef8d574864bf25375b3536add6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133995 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#757720}
-
rbpotter authored
The aria-label should be on the <select>, rather than on the <print-preview-settings-select> custom element, for Chrome Vox to verbalize the controls correctly. The same issue occurs with NVDA, but currently cannot verify, so this is a speculative fix for the NVDA issue. Bug: 1035569 Change-Id: I3ceb0c75e64e66637a8a4c4a4600ecdf0eb82f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142761 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#757719}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1cba0a9c3a8a..3cfa8e28be80 git log 1cba0a9c3a8a..3cfa8e28be80 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 sugoi@google.com Remove debug only code limiting the number of primitives Created with: gclient setdep -r src/third_party/swiftshader@3cfa8e28be80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I57535e14a5eb388514359778310680a1f5dfb5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142979Reviewed-by:
-
Keith Lee authored
Change-Id: I69cee3613a253fc0303b11c53f6e04650d1db6d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143054Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Auto-Submit: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#757717}
-
Koji Ishii authored
|NGSimplifiedLayoutAlgorithm| was once disabled for FragmentItem to focus on working on the correctness. This patch re-enables it for the performance. Bug: 982194 Change-Id: I1bf2d7dc1734c2163a525732a181aa4bdfbbcd0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134185Reviewed-by:
-
Devlin Cronin authored
Remove ExtensionBrowserTest::InstallBookmarkApp() and browsertest_util::InstallBookmarkApp(). Neither were used. Bug: None Change-Id: Ie6164c30430f4ac8ecef9d4645c01c3c72736e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141626Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#757715}
-
Ravi Chandra Sadineni authored
Currently we only have one dropdown that reflects both AC and battery idle delay timeouts and idle action. This is limiting from the user perspective as AC idle option cannot be configured differently from battery idle action. Also when the idle actions are different, the current selection might not reflect the underlying behavior. Thus add an additional drop down (one for AC and other for battery idle behavior) thus addressing the above issues. Screen shot before: https://screenshot.googleplex.com/OaBgcgZLwHW.png Screen shot after: https://screenshot.googleplex.com/7co27K1UR8d.png CQ-DEPEND=CL:2044412 Bug: b:148105990 Test: Run browser_tests and manual tests. Change-Id: I8eac3a5408a5808936277ca623e28b5b2ce9bb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135368Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2f3157ba..5dcf1b66 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I60f0ab88e67d5ba54de0ca56503648859073d217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143211Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/237b8541c13f..f9f8e4b0d42d git log 237b8541c13f..f9f8e4b0d42d --date=short --first-parent --format='%ad %ae %s' 2020-04-08 jalyn@microsoft.com Register all actions in ActionRegistry 2020-04-08 jalyn@microsoft.com Ready module.jsons for multi-keypress shortcuts Created with: gclient setdep -r src/third_party/devtools-frontend/src@f9f8e4b0d42d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0ce1877d7b180a0d52fd413b7cd1c1ad32154932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142981Reviewed-by:
-
John Z Wu authored
Change-Id: I568b219b5567442e8b173606ff8985212307d839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140922Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#757711}
-
Noel Gordon authored
Add getToolTipButtons() service that returns every breadcrumb <button> that has attribute [has-tooltip]. Bug: 1035691 Change-Id: I719b7ea301f127ba14efc92e5e7a7b34174c04b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141559 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#757710}
-
Victor Fei authored
CL:1803983 Improved UIA ExpandCollapseProvider ::get_ExpandCollapseState behavior on menu buttons (i.e. a button contains aria-haspopup attribute) by limiting menu buttons to only support ExpandCollapseState_Expanded/Collapsed and not support ExpandCollapseState_LeafNode. That change was intended to improve UIA behavior for Views toolbar buttons. However, that change introduced an issue where any element, not just menu buttons, that has aria-haspopup="true/menu" would not support ExpandCollapseState_LeafNode Consider the following example: <div aria-haspopup="true"></div> Current behavior: ExpandCollapseState_Collapsed Expected behavior: ExpandCollapseState_LeafNode This change fixes this by limiting only menu buttons to exclude ExpandCollapseState_LeafNode, while all other elements that support IExpandCollapseProvider would support ExpandCollapseState_LeafNode. New behavior: Menu buttons supported state: Expanded, Collapsed All other elements supported state: Expanded, Collapsed, LeafNode Bug:847971 Change-Id: I9756d1d02d27c1e747f4d77fcecae21468a9022e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112757Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
David Van Cleve authored
This is part of a sequence of CLs implementing data removal logic for Trust Tokens [*], a prototype feature that enables annotating requests with some lightweight cryptographic state. The internal storage stores the results of these cryptographic operations, including some state necessary for maintaining privacy invariants. The CL, the first in the series, expands the Trust Tokens storage system to satisfy deletion requests parameterized by a network::mojom::ClearDataFilter. (This is the same way other non-cookie NetworkContext-scoped data, like reporting and the host cache, is cleared.) A follow-up CL will add the removal interface and call it from NetworkContext. [*] https://docs.google.com/document/u/1/d/1TNnya6B8pyomDK2F1R9CL3dY10OAmqWlnCxsWyOBDVQ/edit R=csharrison Bug: 1064747 Change-Id: Id0172932916580bbfff5b41f616e61e8feb99305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134700 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#757708}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I88b4b7b9431da51025606e15f5804cd2363cb823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143117Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757707}
-
