- 04 Jul, 2018 29 commits
-
-
Chris Harrelson authored
For such PaintLayers, the CompositingContainer is the parent, not the containing stacking context. This is because such stacking contexts paint during the normal-flow of the ancestor layout object. This also allows us to enable subsequence caching; the previous attempt last week was still suffering from the under-invalidation reported in issue 859520. The testcases that crash on ASAN from the referenced bugs are fixed; one such example is included in this CL. Bug:859294,719835,723076,859520 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6ab5271d70bd834482c22b89f09b93907788ed0c Reviewed-on: https://chromium-review.googlesource.com/1125269 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572428}
-
Kyle Horimoto authored
Original CL (uploaded as patchset 1): https://chromium-review.googlesource.com/c/chromium/src/+/1119466 Reverted CL: https://chromium-review.googlesource.com/c/chromium/src/+/1125479 The CL failed on some bots due to trying to set an invalid response code for a proto (the test was trying to test an invalid response code). I've removed that test in patchset 2. Original CL description below: This class represents an operation for completing the verification step for the current host device. A HostVerifierOperation instance is meant to be used for a single verification attempt; if verification needs to be retried, a new instance should be created for the next attempt. This class completes the following steps to verify a device: (1) Call FindEligibleDevices(). This step sends a message to the host device, which in turn enables background advertising. (2) Creates a connection to the device using the BLE listener role. (3) Sends an EnableBetterTogetherRequest message to the host device. (4) Waits for an EnableBetterTogetherResponse messages to be returned by the host device. Bug: 824568 Change-Id: Iee9084763e0f3163baed06f36cc2e357e6313f64 Reviewed-on: https://chromium-review.googlesource.com/1125500Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#572427}
-
Sergey Ulanov authored
Previously ScopedServiceBinding was using fidl::Binding instead of BindingSet, which didn't allow multiple bindings. Also added some new unittests for ServiceDirectory to validate cases that were not handled previously. That required an update in ComponentContext class: it now can handle the case when the target directory is gone. Change-Id: I7975275bebfba716d97c3f41d13046172385aff7 Reviewed-on: https://chromium-review.googlesource.com/1125308Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572426}
-
Aleks Totic authored
Bug: 726520 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic57d3c897a711b58572303f1dca1ba1f4ca31fc2 Reviewed-on: https://chromium-review.googlesource.com/1125401 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#572425}
-
Owen Rodley authored
We currently need to work around ninja writing to stdout in the codesearch builders by using a wrapper script. If we're to use this script instead, we may as well bake this in here and remove the need for a wrapper. Bug: 396230 Change-Id: If161310d2b93c4fed2ee2de1c4b3fba8b9aa2313 Reviewed-on: https://chromium-review.googlesource.com/1124124 Commit-Queue: Owen Rodley <orodley@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#572424}
-
Andrew Grieve authored
* Use assert statements * Reduce visibility of methods where possible * Create singleton during class initialization Change-Id: I60c2da7d8cdb1065eba47c45a3369b8ba0e34780 Reviewed-on: https://chromium-review.googlesource.com/1116281Reviewed-by:
David Turner <digit@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#572423}
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I5d70f28869551ffae4a16431dec01cc5101820be Reviewed-on: https://chromium-review.googlesource.com/1125339Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#572422}
-
Makoto Shimazu authored
crrev.com/c/1124729 marks a few tests as flaky on Mac, but this replaces it to Mac10.10, which is more restrictive. TBR=pdr@chromium.org NOTRY=true Bug: 857501 Change-Id: Ibca47cd41a2ec17b95372ea115081f08312217ba Reviewed-on: https://chromium-review.googlesource.com/1124731Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572421}
-
Christopher Cameron authored
Bookmark folders using Views are very janky (~5 fps, with the CPU at 100%). Calls to RenderTextHarfBuzz::ShapeRunWithFont account for almost all of this time. Many of the calls to ShapeRunWithFont are done with the same arguments every frame. To alleviate some of this jank, add a cache the results of this function call. Refactor RenderTextHarfBuzz::ShapeRunWithFont to be stateless, and add structures ShapeRunWithFontInput and ShapeRunWithFontOutput for the arguments and output of the function. Use ShapeRunWithFontInput as a cache key. Bug: 826265 Change-Id: Ic6726c1152c44dc5cb0eccddf1ff3adcd060d8e7 Reviewed-on: https://chromium-review.googlesource.com/1123456 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#572420}
-
Philip Rogers authored
This was generated using: https://chromium-coverage.appspot.com/reports/572002/linux/chromium/src/third_party/blink/renderer/core/frame/local_frame_view.cc.html BUG=823365 Change-Id: I136ba88950e2d042fd330cedb88614562af2e264 Reviewed-on: https://chromium-review.googlesource.com/1125309Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#572419}
-
Xianzhu Wang authored
Previously we always sequentially matched old and new display items. The algorithm was efficient for sequential matching, but was O(n^2) in the worst case that the new chunk reversed the order of display items of the old chunk. Now add an index for matching out-of-order old display items. Sequential match is done only in a single pass. It's the same method that we are using in PaintController. When display item raster invalidation was in PaintController, we also used the same index for raster invalidation. Bug: 859940 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I86ee7f4a324f710daaad03f29d00b17db0f11cb7 Reviewed-on: https://chromium-review.googlesource.com/1125300Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572418}
-
Ahmed Fakhry authored
Rather than toggling Night Light on or off, clicking the label should take the user to the display settings page where Night Light can be adjusted. BUG=859848 TEST=Manually Change-Id: Ic1f15c6c953bfc8a38f94a7015dc7a3b877c404b Reviewed-on: https://chromium-review.googlesource.com/1125338 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#572417}
-
Sara Kato authored
Currently, when ctrl+search+m is used to toggle the magnifier, this is not reflected in chrome://settings. However, the other accelerators (docked magnifier and high contrast) are reflected in settings. Bug: 853104 Test: Manual Change-Id: Ia70b868eb89598ba90b79e2e5da482bd0bb6a916 Reviewed-on: https://chromium-review.googlesource.com/1114524 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#572416}
-
Tarun Bansal authored
Change-Id: I34426ea80d26a23bbb3252b91cb24ad9b3e79ca5 Bug: 827256 Reviewed-on: https://chromium-review.googlesource.com/1125306 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#572415}
-
Mike Wasserman authored
Attempting to use this example crashes otherwise: [233814:233814:0703/151833.248652:FATAL:native_widget_aura.cc(151)] Check failed: params.parent || params.context. #0 0x7f45424a2f7c base::debug::StackTrace::StackTrace() #1 0x7f45423f23bb logging::LogMessage::~LogMessage() #2 0x7f453db8604b views::NativeWidgetAura::InitNativeWidget() #3 0x7f453db68157 views::Widget::Init() #4 0x0000004e76bd ash::TestChildModalParent::TestChildModalParent() #5 0x0000004e74ee ash::TestChildModalParent::Create() #6 0x7f453daefbed views::Button::OnMouseReleased() Bug: NONE Test: No ash_shell_with_content crash showing child modal window. Change-Id: Ic6a2382676d54ea47fd1a6a70b0209c26fd3d87f Reviewed-on: https://chromium-review.googlesource.com/1125294Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#572414}
-
Owen Rodley authored
This is required if this is to replace the codesearch generate_compilation_database method, as mentioned in https://crrev.com/c/1114413. Bug: 396230 Change-Id: I61122bae15bed27463e5b770623fdf8106836aac Reviewed-on: https://chromium-review.googlesource.com/1124077 Commit-Queue: Owen Rodley <orodley@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#572413}
-
spqchan authored
Disabling: http/tests/devtools/tracing/timeline-js/timeline-script-tag-1.js TBR=dgozman@chromium.org Bug: 859629 Change-Id: I8e5bb8aef555d24f38fa7e386d315d05d147df7e Reviewed-on: https://chromium-review.googlesource.com/1125358 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#572412}
-
Makoto Shimazu authored
These were enabled at crrev.com/c/1121786 but still a few tests are failing on Mac10.10 Tests bot. TBR=pdr@chromium.org NOTRY=true Bug: 857501 Change-Id: I20542f3c38550de579db0304c9d27be8e67e5cc8 Reviewed-on: https://chromium-review.googlesource.com/1124729Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572411}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a1689df8745a..7c8e16a9e9d6 git log a1689df8745a..7c8e16a9e9d6 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@7c8e16a9e9d6 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I309db9eb6c08675ec47b1deeb33754e633a6ab9f Reviewed-on: https://chromium-review.googlesource.com/1124621Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572410}
-
Xi Cheng authored
Bug: 851163 Change-Id: Ie75fcbb029979f41a22cd5db789f5eb04decea1e Reviewed-on: https://chromium-review.googlesource.com/1125334Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#572409}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/58a1605d2b9b..502c3ffce8eb git log 58a1605d2b9b..502c3ffce8eb --date=short --no-merges --format='%ad %ae %s' 2018-07-03 fmalita@chromium.org [skottie] Do not discard SkPath's FillType when interpolating 2018-07-03 weiliangc@chromium.org Use TextureProxy size directly in GrYUVToRGBEffect FragmentProcessor 2018-07-03 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms f447e42de725..8342d776db5a (2 commits) 2018-07-03 ruiqimao@google.com Revert "added skeletal animation support to GPU backend" 2018-07-03 robertphillips@google.com Disable NVPR path renderer in DDL mode 2018-07-03 mtklein@chromium.org remove unit tests baked into SkAAClip 2018-07-03 egdaniel@google.com Reland "Remove setting/use of GrPixelConfig in GrBackendTex/RT ctors." Created with: gclient setdep -r src/third_party/skia@502c3ffce8eb The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Ia6cf750dd67e1c675c25a594e80bb6798a9a9a0e Reviewed-on: https://chromium-review.googlesource.com/1124620Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572408}
-
Makoto Shimazu authored
This reverts commit a69a2eb1. Reason for revert: MultiDeviceSetupHostVerifierOperationImplTest.ReceivedInvalidResponse_InvalidResultCode keeps failing on linux-chromeos-dbg bot. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/6639 Original change's description: > [CrOS MultiDevice] Add HostVerifierOperation. > > This class represents an operation for completing the verification step > for the current host device. A HostVerifierOperation instance is meant > to be used for a single verification attempt; if verification needs to > be retried, a new instance should be created for the next attempt. > > This class completes the following steps to verify a device: > (1) Call FindEligibleDevices(). This step sends a message to the host > device, which in turn enables background advertising. > (2) Creates a connection to the device using the BLE listener role. > (3) Sends an EnableBetterTogetherRequest message to the host device. > (4) Waits for an EnableBetterTogetherResponse messages to be returned by > the host device. > > Bug: 824568 > Change-Id: I520ff9388334467831342af4d0e270cb4e351eeb > Reviewed-on: https://chromium-review.googlesource.com/1119466 > Reviewed-by: Ryan Hansberry <hansberry@chromium.org> > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572339} TBR=khorimoto@chromium.org,hansberry@chromium.org Change-Id: I3f74224c953fbca3932ce178367824342ddf06e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824568 Reviewed-on: https://chromium-review.googlesource.com/1125479Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572407}
-
Owen Rodley authored
As mentioned in https://crrev.com/c/1114413. Bug: 396230 Change-Id: I2bd1d0b6123bf01f78ea0f88ebf45fc85cbe0f38 Reviewed-on: https://chromium-review.googlesource.com/1124067Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Owen Rodley <orodley@chromium.org> Cr-Commit-Position: refs/heads/master@{#572406}
-
Takuto Ikuta authored
This reverts commit 18ba607a. Reason for revert: Speculative revert for consistent failure on linux-chromeos-rel CQ builder. Original change's description: > CC: Make LayerTreeHostImpl::OnMemoryPressure work for the desktop as well > > LayerTreeHostImpl::OnMemoryPressure has only worked for low-end devices. > But it would be good if it works for all devices. > > Bug: 839687 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I9f670ab08587ad4c5f626eb74fe5d7c9db256150 > Reviewed-on: https://chromium-review.googlesource.com/1107025 > Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572216} TBR=ericrk@chromium.org,gyuyoung.kim@lge.com Change-Id: I5e8d81f540311373a3d79854310ec59896494cae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839687, 860090 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1125459Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#572405}
-
Xi Cheng authored
Bug: 851163 Change-Id: I2b89682bcec7c24319160fab2cb69d08603d2f60 Reviewed-on: https://chromium-review.googlesource.com/1125322Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#572404}
-
Jared Saul authored
Change-Id: Ida242dcd6a780c207c43262ac05e3955fccf1ce9 Reviewed-on: https://chromium-review.googlesource.com/1125325 Commit-Queue: Jared Saul <jsaul@google.com> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#572403}
-
Jennifer Apacible authored
On Windows, hovering over the media controls triggers an ET_MOUSE_EXIT MouseEvent. This is intended to only be caught when the mouse is not within the video window bounds. On non-Windows, this is a noop. Bug: 852131 Change-Id: I988d4483510c4eaafc9969edb26de407d77b0149 Reviewed-on: https://chromium-review.googlesource.com/1125139Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#572402}
-
Orin Jaworski authored
The wording on the message descriptions was incorrect, suggesting the text is "readable" when it should have indicated that the text will be read by a screenreader. Change-Id: Ide5ae94e938d1690f4adec639484815aaeeddf5e Reviewed-on: https://chromium-review.googlesource.com/1124800 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#572401}
-
Victor Costan authored
cookiechange events have been dispatched to ServiceWorkerGlobalScope since https://crrev.com/c/979334 landed, and can be observed using addEventListener, as shown by the WPT test at cookie-store/serviceworker_cookieStore_subscriptions_basic.tentative.https.html This CL adds the oncookiechange attribute to ServiceWorkerGlobalScope, allowing the event to be handled by a DOM0-style event handler. Bug: 729800 Change-Id: Ic27979d94934abf833c116787cdad5243422324b Reviewed-on: https://chromium-review.googlesource.com/1123766 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#572400}
-
- 03 Jul, 2018 11 commits
-
-
Robbie McElrath authored
When the network service is enabled, we wouldn't download responses that had a plugin associated with their mime type. This makes the PluginResponseInterceptorUrlLoaderThrottle check if the response is meant to be a download before intercepting it. Bug: 855539 Change-Id: I8b70abb2a7e24c27b5a6866a0f09c24f59c12e05 Reviewed-on: https://chromium-review.googlesource.com/1119581 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#572399}
-
Xiaocheng Hu authored
This patch takes scrolled offset into account when hit testing the children of a scroll container, so that scrolled contents can be hit tested correctly. Bug: 855279 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic84b40c06302c457cf32cacaa5e79f419dcc3a2b Reviewed-on: https://chromium-review.googlesource.com/1125312Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#572398}
-
Manu Cornet authored
* Add flag for the shelf new UI * When it's on, center some shelf items (apps, pinned apps) * Minor dimension and opacity tweaks when the flag is on * Fix some minor typos here and there Change-Id: I87b7fa819bac0fff77f5007c4a0cee760a630239 Bug: 805612 Reviewed-on: https://chromium-review.googlesource.com/1116540Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#572397}
-
Trent Apted authored
When a real IME window is up, AppKit spins a nested runloop that interacts with the IME window over XPC while we're trying to invalidate our NSTextInputClient (e.g. because the window has been deleted). However, this may also cause AppKit to *use* the very NSTextInputClient that we're trying to invalidate. Specifically, this seems to happen with phonetic languages such as Korean and Vietnamese. These use rule-based transforms that do not commonly pop-up a candidate window. In such cases, a key such as Enter may simultaneously commit a composition _and_ trigger the omnibox action, which moves focus away from the omnibox thereby invalidating the textInputClient_. -BridgedContentView insertText: was the last hold-out that didn't have a null check. AttributedSubstringForRangeHelper() and GetFirstRectForRangeHelper() handle a null client already. SystemPreferences -> Keyboard -> Input Sources, then interact with the omnibox. Test: On Mac, add/enable the "2-Set Korean" input method under Bug: 817097 Change-Id: Ia7d1ebb796b9c98437b563ea405cad785e92ea30 Reviewed-on: https://chromium-review.googlesource.com/1124073Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#572396}
-
Joel Einbinder authored
If the targetId is not specified, the info for the target of the current session is returned. DevTools receives a connection to a target, but does not know the targetId. Certain commands, particularly Target.attachToTarget, take a targetId. Using Target.attachToTarget will allow DevTools to create parallel connections to the page for a better Lighthouse experience. Change-Id: I777350d6fb486c4e5ed6256ebc0bcc1d738d0ab2 Reviewed-on: https://chromium-review.googlesource.com/1096434 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#572395}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=derat@google.com Change-Id: I2fdb769ada863ff26315c8e6c9b0c750e9cc1bda Reviewed-on: https://chromium-review.googlesource.com/1125170 Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#572394}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/95b0293a29b2..94f7b75b4d5d git log 95b0293a29b2..94f7b75b4d5d --date=short --no-merges --format='%ad %ae %s' 2018-07-03 tsepez@chromium.org Use unowned ptr to Node from outside XFA node tree. 2018-07-03 tsepez@chromium.org Use UnownedPtr<> in cxfa_nodeiteratortemplate.h 2018-07-03 tsepez@chromium.org Use std::vector<float> in CPDF_Function. 2018-07-03 thestig@chromium.org Remove a parameter from CPDF_SyntaxParser::FindTag(). 2018-07-03 art-snake@yandex-team.ru Avoid duplicate data buffering in CPDF_SyntaxParser::ReadStream(). Created with: gclient setdep -r src/third_party/pdfium@94f7b75b4d5d The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1ed1373e43dfaad55199a4fcfe0ca8027c0e6e63 Reviewed-on: https://chromium-review.googlesource.com/1125049Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572393}
-
Rintaro Kuroiwa authored
- Handle subsamples. - Use ID3D11VideoContext1 for SubmitDecoderBuffers1. - Pass a decryption context to DecoderBeginFrame(). - Change GetAddressOf in D3D11VideoDecoderImpl::Initialize to ReleaseAndGetAddressOf so that it doesn't leak when initialized multiple times. Bug: 799310 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I802f3afff630811f3f2a497557ad7af566ff3f4a Reviewed-on: https://chromium-review.googlesource.com/1123694 Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#572392}
-
Eric Karl authored
This avoids clearing some longer-lived Skia caches, hopefully avoiding an UMA latency regression we experienced when the idle clearing was initially added. This re-land uses a more direct Skia API, hopefully avoiding the flakiness seen in issue 805575. Note for sheriffs: We expect a small regression in measured memory. This is intentional, and comes with an improvement to input latency. This regression shouldn't have a large impact on real-world scenarios, as we are preventing the clearing of a cache that will be immediately re-created on any page raster. TBR=brettw@chromium.org for test-only DEPS change (already ran by bsalomon@ in previous patch, this is re-land+updates) Bug: 664181, 805575 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Id4c9a091a543c31f928e0214558695de81a30e9d Reviewed-on: https://chromium-review.googlesource.com/1123169 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#572391}
-
Klaus Weidner authored
https://crrev.com/c/1120677 "Don't create a Surface for WebXR SharedBuffer mode" had a logic error that led to the GPU process connection being recreated unconditionally on re-entering VR, resulting in an inconsistent state where it tried to reuse mailbox names belonging to the previous connection. Change-Id: Ic005c7884a46b3d1b3da986a55e9d733f09d68d3 Reviewed-on: https://chromium-review.googlesource.com/1125273Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#572390}
-
Quan Nguyen authored
Bug: 845037 Change-Id: I60574af1513793a0872c4d02c20c829f0adda9df Reviewed-on: https://chromium-review.googlesource.com/1117769 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#572389}
-