- 13 Nov, 2018 40 commits
-
-
Greg Thompson authored
Previously, downgrades were only possible via master_preferences (for use by the enterprise wrapper). This change makes downgrades possible via the command line. BUG=607592 R=zmin@chromium.org Change-Id: I5885fe9eb1b2f2ba477958a9d06797da6e9d4acc Reviewed-on: https://chromium-review.googlesource.com/c/1333811Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#607600}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f1ff631c9f6c..c59d48ec1594 git log f1ff631c9f6c..c59d48ec1594 --date=short --no-merges --format='%ad %ae %s' 2018-11-13 dgarrett@google.com manifest_version: Add resolution helpers for buildspecs. Created with: gclient setdep -r src/third_party/chromite@c59d48ec1594 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ibc7c3cccd04799b23d4a10ec7b89153778e6b5f9 Reviewed-on: https://chromium-review.googlesource.com/c/1333850Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607599}
-
Francois Doray authored
Change-Id: Ic6f6d7b29443395105c8a3619b74bac9f464666e Reviewed-on: https://chromium-review.googlesource.com/c/1330062Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#607598}
-
Yi Gu authored
Currently there is a call to rAF inside step_func_done which means the test will actually complete before the rAF fires and so the assert_true will never run. Bug: 887659 Change-Id: Ic3d017cb106994507cba995ccf41133902c0d101 Reviewed-on: https://chromium-review.googlesource.com/c/1333887 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#607597}
-
Raphael Kubo da Costa authored
https://gn-review.googlesource.com/c/gn/+/3200 removed the --no-sysroot option from gen.py and moved to only use a sysroot in the GN bots, so the options here no longer have any effect. Bug: 904350 Change-Id: Ieddc71a4f8f802c2d050de1c69ca3a9ec788ee88 Reviewed-on: https://chromium-review.googlesource.com/c/1333391Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#607596}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4c6f6e21. With Chromium commits locally applied on WPT: 9ff65400 "Add redirected cases to CSP/import tests in wpt/worklets" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I89e3faebc7872e892ad5ec43b0b3bcd8fd514021 Reviewed-on: https://chromium-review.googlesource.com/c/1333728 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607595}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f343a1576406..2b1f6b373ca9 git log f343a1576406..2b1f6b373ca9 --date=short --no-merges --format='%ad %ae %s' 2018-11-13 sheredom@gmail.com Validate that VertexId and InstanceId are not allowed in Vulkan. (#2036) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@2b1f6b373ca9 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibf1eb4d5be24102a7c77f0ecf9e92f735ee0cb16 Reviewed-on: https://chromium-review.googlesource.com/c/1333848Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607594}
-
Egor Pasko authored
Because of expecting '.' in every orderfile entry the current compare_orderiles.py observes zero symbols in recent orderfiles. Add a separate (simpler) path to parse the new orderfiles (with symbols only). Also add an option to keep the downloaded orderfiles in /tmp for further inspection. Tested with orderfile commits: new: 03cc43767b83b9b3460461dc5636be1ce1e74e51 old: a4b93acc41d5e19e4cbfb86d802f442dce10e38f One new worry is that for newer orderfiles the 'average fractional distance' is usually about 4.50% while for the old orderfiles it used to be less than 0.5%. There are 1.4x more symbols now than there were back then. Bug: 893981 Change-Id: I1c812d4d67f68e0ee0fc31273104a2145fbebaa9 Reviewed-on: https://chromium-review.googlesource.com/c/1333648Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#607593}
-
Jean-denis Muys authored
The new story is named cct:no_warmup:bbc Bug: 760498 Change-Id: I11a1d2e0b9b4a9dbfb4c4f31f039c4ca3bbe75c6 Reviewed-on: https://chromium-review.googlesource.com/c/1301914 Commit-Queue: Jean-Denis Muys <jdmuys@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#607592}
-
David Bokan authored
https://codereview.chromium.org/2860663006/ forgot to update the kTypeLast. Change-Id: Ieae9b0711c841a00357dfd3190c6ed9e1c5c86a6 Reviewed-on: https://chromium-review.googlesource.com/c/1331045Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#607591}
-
Clemens Arbesser authored
Changed finch study name to account for changes in the recently reviewed and submitted revised Autofill Aisstant finch experiment (http://cr/221236914). Previously, the overlay experiment was designed as a standalone finch experiment. Now, overlay_color is a parameter of the existing AutofillAssistant finch experiment. Bug: 806868 Change-Id: I0ed398900f30480112c81a892655e0a08a81a034 Reviewed-on: https://chromium-review.googlesource.com/c/1333448 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#607590}
-
gogerald authored
Bug: 806868 Change-Id: Idba43630fae018d6791e4f089e7b05e35f628693 Reviewed-on: https://chromium-review.googlesource.com/c/1332627Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#607589}
-
Maxim Kolosovskiy authored
Change-Id: I81941775176835e2dd93f31965183dc4f3e43ab3 Reviewed-on: https://chromium-review.googlesource.com/c/1333747Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#607588}
-
barkerd authored
This uses a PostMessageHandler internally to communicate with the web contents. The PostMessageHandler is initialised once the dynamic module has been loaded and is reset each time the web contents change. A new class, ActivityDelegatePostMessageBackend, replaces the service backend usually used by PostMessageHandler and forwards all events along to the dynamic module if it's present. Bug: 898840 Change-Id: Ia308c84cd771d2fdb96fc076472488fc48946162 Reviewed-on: https://chromium-review.googlesource.com/c/1323669 Commit-Queue: David Barker <barkerd@google.com> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#607587}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/29ce020e1568..7d6eeae28d72 Created with: gclient setdep -r src-internal@7d6eeae28d72 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6ac8cc23fe08ef903dcc49ea4077c0b928cada6c Reviewed-on: https://chromium-review.googlesource.com/c/1333529Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607586}
-
Gabriel Charette authored
As requested on the bug. R=fdoray@chromium.org Bug: 736531 Change-Id: I8f1fda7cc7e5973c72b2c9ff970c8a88620e0ca5 Reviewed-on: https://chromium-review.googlesource.com/c/1332768 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#607585}
-
Jeremy Roman authored
The relevant header is renamed to not imply that it's part of the generator only, and added as a source of both the generator and of the platform component. Some mild renaming included, but optional. This resolves a gn check failure in //third_party/blink/renderer/platform. Change-Id: Ic7b3f7c7e70307cea99fa7cbdd9787484f9a0122 Reviewed-on: https://chromium-review.googlesource.com/c/1329841Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607584}
-
David Jean authored
Includes translator from autofill::CreditCard. Will be used in manual_fill in a follow up cl. Bug: 845472 Change-Id: I1f70757e5de4ace6f12a3dfebbcf263c960a7d57 Reviewed-on: https://chromium-review.googlesource.com/c/1331391Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#607583}
-
Stepan Khapugin authored
- Fixes a bug when there are fewer most visited tiles than 4. - Properly updates the most visited tiles and suppresses updates when the tiles are visible. Change-Id: Ide1a6307b643cce3a1bf73a4a98082e06b1e8a9c Reviewed-on: https://chromium-review.googlesource.com/c/1296590 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#607582}
-
Ned Nguyen authored
With this CL, perf FYI builders sharding data can be generated by running: $ ./tools/perf/generate_perf_sharding update -w perf-fyi -r This CL also remove 'One Buildbot Step Test Builder' in perf.fyi.json since the corresponding builder has been removed. BUG:chromium:898832 Change-Id: I7caf239d55259b95418750bdecf3ccb4d6e94398 Reviewed-on: https://chromium-review.googlesource.com/c/1318682Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#607581}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/01a7fc207e58..4afdd6426477 git log 01a7fc207e58..4afdd6426477 --date=short --no-merges --format='%ad %ae %s' 2018-11-13 fmayer@google.com profiling: Write bookkeeping to trace Created with: gclient setdep -r src/third_party/perfetto@4afdd6426477 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I33f5ddb70d5baa60642b5889effac5355af95c4f Reviewed-on: https://chromium-review.googlesource.com/c/1333528Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607580}
-
Koji Ishii authored
NGInlineItemsBuilder::ToString() removes trailing spaces at the end of the block. This is unintuitive from the function name, and caused CL:1322184 to be reverted. This patch moves this to ExitBlock(), and make ToString() clean, without side effects. Ran webkit_unit_tests locally with DCHECK disabled. Bug: 636993 Change-Id: I03f814afc272b9be0c274391cde076aecb6dbc91 Reviewed-on: https://chromium-review.googlesource.com/c/1329804 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#607579}
-
Takuto Ikuta authored
This is mainly to take https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/1314232 Bug: 894045 Change-Id: I1d44c36232d2771ea881c8fd1ca04fdfbf596ef4 Reviewed-on: https://chromium-review.googlesource.com/c/1333093Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#607578}
-
Marc Treib authored
SyncUserSettings is a new class that encapsulates all the user-configurable knobs for Sync. It replaces a bunch of setters and getters directly on the SyncService. Bug: 884159 Change-Id: I219dc4d37ecd4a9eac1a7fb40f50b6b0bc2cb88d Reviewed-on: https://chromium-review.googlesource.com/c/1331402Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#607577}
-
Morten Stenshorne authored
It was disabled, because it used to fail. Now it passes. Don't remember the details. Bug: 889449 Change-Id: I0cd4b0f6fa5bb37494e814818740b3e35afc6fbe Reviewed-on: https://chromium-review.googlesource.com/c/1333374Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#607576}
-
Clemens Arbesser authored
The previous message contained the duration, which was confusing because the message was static and did not change while the timer was running. However, implementing a changing countdown message is somewhat tricky and not directly supported by snackbars. This change is a UI workaround to avoid this confusion. Bug: 806868 Change-Id: I6d7a0c98545741341df2f8200acc49c4ebf776dd Reviewed-on: https://chromium-review.googlesource.com/c/1331393Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#607575}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9e77655d..2fc18984 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I366c17cb100d429d34383d5f7e837ce862c11129 Reviewed-on: https://chromium-review.googlesource.com/c/1333467Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607574}
-
Tien Mai authored
- Added a new reason for the signin that requests only the login process to be executed and then takes the result from gaia and sends them through a new message added to the inline_login.js. This code path avoids all cals that try to perform operations on profiles - This new mode is used by GCPW to gather the necessary login information Bug: 887444 Change-Id: I84c62408b16c46a40360d7fc703b482d399cd76b Reviewed-on: https://chromium-review.googlesource.com/c/1286755 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#607573}
-
Antonio Gomes authored
[s13n] Add IdentityTestEnvironment{Profile,BrowserState}Adaptor::CreateXXX variant that takes a Builder In follow ups, users of the existing APIs can be converted. BUG=904419 Change-Id: I6691fb32ec79d5de5c97c09bb886bf3d6bc2c047 Reviewed-on: https://chromium-review.googlesource.com/c/1332749Reviewed-by:Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#607572}
-
Antonio Gomes authored
BUG=903749 Change-Id: I1c904832eb6dcd8de0e670af8ff4e9221d487d69 Reviewed-on: https://chromium-review.googlesource.com/c/1329081Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#607571}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bab19ca5. With Chromium commits locally applied on WPT: 9ff65400 "Add redirected cases to CSP/import tests in wpt/worklets" 395cf32d "Preparation of moving LayoutTests to web_tests." 5918bde3 "[css-flexbox] ChildIntrinsicLogicalWidth should use fit-content, not max-content" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I12bb05015608d836061d9e175d31f9a94c763cf1 Reviewed-on: https://chromium-review.googlesource.com/c/1333250 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607570}
-
Sami Kyostila authored
This perf test should depend on //testing:run_perf_test in order to have the correct wrapper scripts present in the isolate. TBR=fdoray@chromium.org Bug: 897751 Change-Id: I77d454984f6e8c6550961a6ecb240d201d289476 Reviewed-on: https://chromium-review.googlesource.com/c/1333449Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#607569}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b7f221ffce4..29ce020e1568 Created with: gclient setdep -r src-internal@29ce020e1568 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If40e2a3c8ca543dfbc1f4b53a19fd2fcbf555c2b Reviewed-on: https://chromium-review.googlesource.com/c/1333063Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607568}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/12378af8eb5f..01a7fc207e58 git log 12378af8eb5f..01a7fc207e58 --date=short --no-merges --format='%ad %ae %s' 2018-11-13 hjd@google.com Merge "trace_to_text: Remove summary and short_summary" Created with: gclient setdep -r src/third_party/perfetto@01a7fc207e58 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I9bdb119406f412440b8f94c74d4bd699ec26a252 Reviewed-on: https://chromium-review.googlesource.com/c/1333062Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607567}
-
Corentin Wallez authored
make_core_generated_css_longhand_property_classes was missing text_decoration_skip_ink.h as an output. BUG=chromium:904788 TBR=tkent@chromium.org Change-Id: I4144bb975f647dd01ea2277b02cef4528f2c9c23 Reviewed-on: https://chromium-review.googlesource.com/c/1333389Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#607566}
-
Alexander Hendrich authored
Add more detailed reason "invalid JSON" why the parsing failed. Bug: 834245 Change-Id: I9a81f425a2d877fecab7a9da1176e043e154d3f6 Reviewed-on: https://chromium-review.googlesource.com/c/1329977Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#607565}
-
Javier Ernesto Flores Robles authored
Modifies the pipeline so suggestions_controller responds with a model for suggestions instead of a customized UIView. This gives the accessory bar the responsibility (and the power) of creating the view. This is the first step to allow better animations, by not having to completely replace those views every time new suggestions arrive. As well as having an easy way to track the number of suggestions when a manual fallback icon is tapped. Bug: 8445472 Change-Id: I0a58868de27e37af98a15d913782ddbc7967bbae Reviewed-on: https://chromium-review.googlesource.com/c/1327162Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#607564}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1e1ba0e0176f..9e3109c99ea5 git log 1e1ba0e0176f..9e3109c99ea5 --date=short --no-merges --format='%ad %ae %s' 2018-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 298436280db3..cd47a379f960 (1 commits) Created with: gclient setdep -r src/third_party/skia@9e3109c99ea5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I3f80a2551ad90add64e73ad0a30d9b058b4491a7 Reviewed-on: https://chromium-review.googlesource.com/c/1333059Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607563}
-
Lalit Chandivade authored
1. Function defined noreturn 2. Fix following compilation error for aarch64 on win - error: Unsupported architecture 'aarch64' for MS-style inline assembly IMMEDIATE_CRASH(); ^ ./base/logging.h(595,6): note: expanded from macro 'IMMEDIATE_CRASH' {__asm int 3 __asm ud2 __asm push __COUNTER__}; \ Bug: 893460 Change-Id: I5ed953c3e29480d469d694cf15f5a292e6920cd7 Reviewed-on: https://chromium-review.googlesource.com/c/1298091 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:danakj <danakj@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#607562}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4fe505da..9e77655d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I93ffe315a45fb7edd76d8eb4901d1a57d0cd01e8 Reviewed-on: https://chromium-review.googlesource.com/c/1333249Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607561}
-