- 30 Nov, 2018 6 commits
-
-
Jun Mukai authored
Bug: 854346 Test: the new test case Change-Id: I5a78d4037ffcf2daf995c2fc04ef44459abbd21c Reviewed-on: https://chromium-review.googlesource.com/c/1338187 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#612451}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9dbf638d6f75..a8224556fcd5 Created with: gclient setdep -r src-internal@a8224556fcd5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8e28d640de4f002191ab2e1f70a8ec65e935b15e Reviewed-on: https://chromium-review.googlesource.com/c/1356003Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612450}
-
Aleksey Kozyatinskiy authored
This reverts commit 99590e1f. Reason for revert: <INSERT REASONING HERE> Original change's description: > DevTools: fixed scheduleStepInto for Node 8.x > > Node 8.x does not support breakOnAsyncCall param of > Debugger.stepInto method. > > R=dgozman@chromium.org > > Bug: none > Change-Id: I0e59e0a3742b85a2fd466ac1bac5f7b75aa7f841 > Reviewed-on: https://chromium-review.googlesource.com/c/1352533 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612075} TBR=dgozman@chromium.org,kozyatinskiy@chromium.org Change-Id: Id375af68281dd1316f907f2ea0ee9cfd07b3390e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/1356126Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#612449}
-
Yue Li authored
Bug: b/117793081 Test: Manual Test Change-Id: If747d3317cb163715ff907839203e0c0eee57a1c Reviewed-on: https://chromium-review.googlesource.com/c/1352341 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#612448}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I9d8c29ddf02aee41b2c2f706dca49b60763ea0a2 Reviewed-on: https://chromium-review.googlesource.com/c/1353883Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#612447}
-
Emil A Eklund authored
Remove the in-cell text from the sub-pixel-border-2.html reference test to avoid rounding and subpixel alignment issues for the text content. Bug: 591099 Change-Id: I5c3f7b7c42f13931d44a36f87b7ebc651169769c Tbr: mstensho@chromuim.org Reviewed-on: https://chromium-review.googlesource.com/c/1355991Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#612446}
-
- 29 Nov, 2018 34 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8ce3dbabb8b5..2cd040b0d342 git log 8ce3dbabb8b5..2cd040b0d342 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 zoddicus@users.noreply.github.com Merging two ValidateMemoryScope implementations (#2132) 2018-11-29 stevenperron@google.com Don't inline recursive functions. (#2130) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@2cd040b0d342 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I636d055fc33387f9497bfd03e21b5bfd9e22d553 Reviewed-on: https://chromium-review.googlesource.com/c/1355847Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612445}
-
Liquan(Max) Gu authored
In the current implementation, it's possible to create inconsistency while a node waiting to be assigned with a swap time is removed. When this happens, the detector still creates a record of the removed text, but it shouldn't, as the created record could become the candidate metric result. The cause is that when a record is assigned with a swap time, there is no check of whether the node has been removed. To fix this issue, we should mark the node as deleted when the node is removed from the dom tree, and add the checking of validity when we assign the swap time to the record. The CL implements this fix. Bug: 869924 Change-Id: Ie331d40fbad585cf32828c1b99136056d429c5b0 Reviewed-on: https://chromium-review.googlesource.com/c/1354130Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#612444}
-
Per Åhgren authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/eb9630f2312f..908e07846946 $ git log eb9630f23..908e07846 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 aoldemeier login: Add DBus call to SessionManager to clear check_enrollment flag. 2018-11-26 xiaochu imageloader/system_api/dlcservice: move constants to system_api 2018-11-22 peah system_api: Add group ID for system AEC 2018-11-08 itspeter runtime_probe: the skeleton Created with: roll-dep src/third_party/cros_system_api R=derat@chromium.org Change-Id: I4cd0cb0d357330d69a4a870bcbd45b26c8f03aad Reviewed-on: https://chromium-review.googlesource.com/c/1355943Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Per Åhgren <peah@chromium.org> Cr-Commit-Position: refs/heads/master@{#612443}
-
Andreas Butler authored
Adds a UMA use counter to IDBFactory.databases(). Bug: 909000 Change-Id: I3a45c7cccec208fa8d9227bcfb2cc24a4a688324 Reviewed-on: https://chromium-review.googlesource.com/c/1352484Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Andreas Butler <andreasbutler@google.com> Cr-Commit-Position: refs/heads/master@{#612442}
-
Carlos Caballero authored
Use ScopedTaskEnvironment instead of MessageLoop in favicon_service_impl_unittest.cc MessageLoop will go away, eventually. BUG=891670 Change-Id: I05f9b446058cdfe5e649e821fc8d87ac3e6ec764 Reviewed-on: https://chromium-review.googlesource.com/c/1352365Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#612441}
-
Tom Anderson authored
Changelog https://chromium.googlesource.com/external/github.com/cisco/openh264/+log/3b51f16a4a41df729f8d647f03e48c5f272911ff..6f26bce0b1c4e8ce0e13332f7c0083788def5fdf BUG=893594 TBR=mflodman,hbos Change-Id: I15409f2d1671f23fb785d63f1d3b2f1b0d4b5316 Reviewed-on: https://chromium-review.googlesource.com/c/1355253Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#612440}
-
Sam Maier authored
Bug: 908988 Change-Id: Iaaee8124c56945a8769e6d4ff2a0859ef39c1aea Reviewed-on: https://chromium-review.googlesource.com/c/1355424Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#612439}
-
Alexei Filippov authored
Do not assign zero distance to all GC root objects. Instead assign zero to the global root and follow strong roots only from there. BUG=906847 Change-Id: Iee22162ac11a6700e019276daee1357ef33e61b9 Reviewed-on: https://chromium-review.googlesource.com/c/1353995 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#612438}
-
Nigel Tao authored
Change-Id: I6972a8214f1402f21efe8f7afa35c8f135c996d0 Reviewed-on: https://chromium-review.googlesource.com/c/1351976Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#612437}
-
mrefaat authored
With voice search bar removal and the tab cleanup this method is not used anymore deleted it and updated unittests. Bug: 778416 Change-Id: Ia6a130f50eafb01b0eef265e98ca412071ba7b95 Reviewed-on: https://chromium-review.googlesource.com/c/1355765Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#612436}
-
Tom Sepez authored
Otherwise setting pdf_enable_v8=false breaks chrome build. Change-Id: I86c3d369b4142ad05a986363839cbc6961772bc9 Reviewed-on: https://chromium-review.googlesource.com/c/1356010 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#612435}
-
Troy Hildebrandt authored
Adds the ability to check for corruption via an IsCorrupt() function that's pure virtual on the ProtoDatabase. IsCorrupt() is also introduced in the ProtoLevelDBWrapper, and the corruption flag gets set on the Init callback after checking status. Unit tests changed slightly because the init callback needed to be put into ProtoLevelDBWrapper instead of outside so it could modify is_corrupt_, and the new use of the WeakPtr caused a race condition that meant the test always failed to trigger the callback if we don't wait for init to complete. Bug: 870813 Change-Id: Ib00435dae8cdac490053fbfc6befb95094b1edec Reviewed-on: https://chromium-review.googlesource.com/c/1355521 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#612434}
-
Gary Kacmarcik authored
Change-Id: Icd07e1501d11914209048081496ca414d58a1f71 Reviewed-on: https://chromium-review.googlesource.com/c/1356023Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#612433}
-
Renjie authored
Add total_length() and NumSlices() methods to QuicMemSliceSpan so that length of HTTP/3 data frame can be computed in QuicSpdyStream::WriteBodySlices(). no behavior change. Merge internal change: 222285071 Change-Id: Ie3e2a120fc072a9d8329e33fe5cef778aa454c39 Reviewed-on: https://chromium-review.googlesource.com/c/1351584Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#612432}
-
Charlie Andrews authored
Change-Id: I84983d2fe371ffbf0d6bdbbbf116de532fa741c7 Reviewed-on: https://chromium-review.googlesource.com/c/1340599 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#612431}
-
Jazz Xu authored
Change-Id: I390ffca8cb3273fc6e475695a3eeceb6324f741d Reviewed-on: https://chromium-review.googlesource.com/c/1354649 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612430}
-
Mitsuru Oshima authored
This also increased the timeout for test because it can take longer on asan. TBR=hiroshige@chromium.org, xiyuan@chromium.org Bug: 910303, 910105 Test: OcclustionTest is skipped in single process mash Change-Id: I669d7343255980dd540c98aa645e5f14c641c371 Reviewed-on: https://chromium-review.googlesource.com/c/1355883Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#612429}
-
Scott Violet authored
This moves the majority of the MultiUserWindowManagerDelegate functions into the mojom. For classic mode, a mojo::Binding is created so that notification happens async (just as it will in multi-process mdoe). MultiUserWindowManagerWindowDelegate has been removed. MultiUserWindowManagerDelegate has been removed. Adds MultiUserWindowManagerDelegateClassic. Here's the comment for it: // Delegate used in classic and single-process mash mode. This delegate is // notified when the state of a window changes. In classic mode, this delegate // is called for all windows, in single-process mash mode, this delegate is // called for Windows created in ash's window hierarchy (more specifically, // Windows whose aura::Env has a mode of aura::Mode::LOCAL). For example, Arc // creates Windows that are parented directly to Ash's window hierarchy, changes // to such windows are called through this delegate. Ideally MultiUserWindowManagerDelegateClassic wouldn't be necessary, but that would require assigning unique ids for local windows, which would be rather error prone. The biggest change here is that MultiUserWindowManagerChromeOS is now notified async of the functions that were in MultiUserWindowManagerDelegate, even in classic. BUG=875111 TEST=covered by tests Change-Id: I51e8a89ae3c4e6096d0cf04dc91133781b8cb4cf Reviewed-on: https://chromium-review.googlesource.com/c/1354558 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#612428}
-
Per Åhgren authored
Bug: webrtc:8671 Change-Id: Ie1d02c21a5c9d1e53b17f929750bd0ed43785dfa Reviewed-on: https://chromium-review.googlesource.com/c/1355166Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Per Åhgren <peah@chromium.org> Cr-Commit-Position: refs/heads/master@{#612427}
-
Luciano Pacheco authored
MyFiles is being changed to allow users to create files/folders, this CL changes Wallpaper to be able to scan images in MyFiles instead of Downloads. The function |MyFilesFolderForProfile| takes care of returning Downloads path if the flag MyFilesVolume is disabled. Tested manually by loading in a device with MyFilesVolume flag enabled. Bug: 873539 Change-Id: If0e40cd1d2961ec5ca380a799c5a272823c0cede Reviewed-on: https://chromium-review.googlesource.com/c/1353031Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#612426}
-
Harley Li authored
The original palce of that link is in service worker cache table, but it makes more sense to have that link in the 'clear cache' view, since the user is probably looking at the latter when they got an exception about cache quota exceeding, which is probably caused by caching an opaque response (UI meeting 11/07). Bug: 847462 Change-Id: I99b039fc5b9617c1d0f4493dc3accce32d0385b3 Reviewed-on: https://chromium-review.googlesource.com/c/1325083Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#612425}
-
Olga Sharonova authored
(Could not use crash_reporter due to deps restrictions) Bug: 866830 Change-Id: Ia3cc17720d0d375c4a8536412df2cafb426167b1 Reviewed-on: https://chromium-review.googlesource.com/c/1355099 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#612424}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/97b903782cf5..74c126845dcd git log 97b903782cf5..74c126845dcd --date=short --no-merges --format='%ad %ae %s' 2018-11-29 dgarrett@google.com chromeos_config: Readd smaug firmware branch. 2018-11-29 achuith@chromium.org cros_vm: Wait for SSH port to free upon exit. Created with: gclient setdep -r src/third_party/chromite@74c126845dcd The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6572d22e178928abaf80556d9f6ee22ea92499b4 Reviewed-on: https://chromium-review.googlesource.com/c/1355746Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612423}
-
danakj authored
It doesn't override to arbitrary things, so let the RenderViewImpl have a better idea what is going on by only asking for a bool to use kPrerender visibility instead of shown/hidden. This will help us allow the RenderViewImpl to control the visibility of the RenderWidgets. R=dcheng@chromium.org Change-Id: I8b4bc4a8fd969c1c2e6a4c90f1269a5d41b41ba6 Bug: 908582 Reviewed-on: https://chromium-review.googlesource.com/c/1355773 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612422}
-
Henrique Nakashima authored
This removes the dependency ChromeDataUseMeasurement has on g_browser_process (when kNetworkService is enabled) and fixes a crash when starting in service-manager-only mode. Bug: 902791 Change-Id: I0ed11f4735f4494247a7c17767b53aab695d0f14 Reviewed-on: https://chromium-review.googlesource.com/c/1334334Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#612421}
-
Quinten Yearsley authored
Change-Id: I0959c592ba6e9ec9021b665bac221625021d7df1 Reviewed-on: https://chromium-review.googlesource.com/c/1355132 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#612420}
-
danakj authored
ChromeVoxLiveRegionsUnitTest.RevealAlertLiveRegion ChromeVoxLiveRegionsUnitTest.ProgressBarLiveRegionEvents R=dmazzoni@chromium.org TBR=dmazzoni NOTRY=true Change-Id: If0e8d93719f448f8b014a7d9de33d3d764734954 Bug: 498881 Reviewed-on: https://chromium-review.googlesource.com/c/1355990 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#612419}
-
Peter Boström authored
Bug: chromium:909818 Change-Id: I0c0df3d6aa2e01a3107f6ed0e4920437d38a6f95 Reviewed-on: https://chromium-review.googlesource.com/c/1355611Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#612418}
-
Akihiro Ota authored
TalkBack does not explain how to open a new tab in Chrome when focusing the tabs button in the toolbar. Updated the content description for this button to communicate how to open new tabs Bug: 851175 Change-Id: I6dc16d09fe0a2a2902401e9e3060eaef91913e35 Reviewed-on: https://chromium-review.googlesource.com/c/1330759 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#612417}
-
Greg Kerr authored
This removes all of the obsolete unit testing code from the V1 sandbox. Bug: 902597 Change-Id: I426e3b815e0bf23036815750aab350adbb22e068 Reviewed-on: https://chromium-review.googlesource.com/c/1327527 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#612416}
-
Sebastien Seguin-Gagnon authored
This reverts commit 81b9c8b4. Reason for revert: Owner landed a fix at the same time. Original change's description: > [Sheriff] Update expecations for worklet-animation-currentTime.html > > Tbr: yigu@chromium.org > Bug: 910295 > Change-Id: If17745e818bad3224122ab99c6c63e2a1c084290 > Reviewed-on: https://chromium-review.googlesource.com/c/1355255 > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612406} TBR=sebsg@chromium.org Change-Id: I003b62c838453c6ce1a7df9787ace6bc372f1988 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910295 Reviewed-on: https://chromium-review.googlesource.com/c/1355987Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#612415}
-
Zhongyi Shi authored
- Net.QuicStreamFactory.AttemptMigrationBeforeHandshake.FailedConnectionType tracks the connection type of the default network when the original connection fails with handshake not confirmed. - Net.QuicStreamFactory.MigrationBeforeHandshake.NewConnectionType tracks the connection type of the altenate network when the original connection fails with handshake not confirmed and a new connection is about to be retried on the alternate network. These histograms may give us hints why the altenate network is not availabe when the connection on the default network fails. Current theory is that the default network is on Cellular, and there is no alternate network. Bug: 790547 Change-Id: Ibfd63efed9a1b72b7d6de95453af55feacd9cef6 Reviewed-on: https://chromium-review.googlesource.com/c/1354320Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612414}
-
Dave Tapuska authored
BUG=879657 Change-Id: Ifc3ba15e517c79286158e77a8bb83c3c30ea1a75 Reviewed-on: https://chromium-review.googlesource.com/c/1355881Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#612413}
-
Andrew Comminos authored
Verfies that the UA measures the time before the end of header parsing in responseStart by simulating a delay after writing the status line and flushing to the client. Chrome fails this test for now, but Firefox passes. Bug: 568024 Change-Id: I61569c6a5b0d8ea2f3a06cb37a3d1ed36c06d40f Reviewed-on: https://chromium-review.googlesource.com/c/1354645 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#612412}
-