GitLab

Review-Url: https://codereview.chromium.org/2042213002
Cr-Commit-Position: refs/heads/master@{#398261}

Disallow cross-origin wrapper creation from them

BUG=616225
R=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2042743002
Cr-Commit-Position: refs/heads/master@{#398260}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/80d06aa4..412fea1c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2047643002
Cr-Commit-Position: refs/heads/master@{#398259}

Fixed by a revert in V8:
https://chromium.googlesource.com/v8/v8/+/9b606523b5e210f60c4260ee5f50a54e8f07adbd

BUG=617137
TBR=jbroman
NOTRY=true

Review-Url: https://codereview.chromium.org/2040153002
Cr-Commit-Position: refs/heads/master@{#398258}

Revert of Flip more Win bots to GN. (patchset #1 id:1 of https://codereview.chromium.org/2030823002/ )

Reason for revert:
Suspected to break Chrome Win builder. (Will revert this revert if it was a false alarm)

Error log:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/7879/steps/compile/logs/stdio

C:\b\build\scripts\slave\.recipe_deps\depot_tools\ninja.exe -w dupbuild=err -C C:\b\build\slave\google-chrome-rel-win\build\src\out\Release chrome chrome_official_builder_no_unittests -j200
ninja: Entering directory `C:\b\build\slave\google-chrome-rel-win\build\src\out\Release'
ninja: error: unknown target 'chrome_official_builder_no_unittests'

Original issue's description:
> Flip more Win bots to GN.
>
> This flips the remaining Win builders on the chromium, chromium.chrome,
> and chromium.perf waterfalls, as well as the matching trybots. The
> remaining GYP win builders are FYI bots, memory bots, and the official
> builders; the latter should be flipped ASAP after this lands to avoid
> any skew.
>
> R=brucedawson@chromium.org
> BUG=605319
>
> Committed: https://crrev.com/85eb563218e8b7af05360745aae05a2c79f80824
> Cr-Commit-Position: refs/heads/master@{#398033}

TBR=brucedawson@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605319

Review-Url: https://codereview.chromium.org/2046913002
Cr-Commit-Position: refs/heads/master@{#398257}

Review-Url: https://codereview.chromium.org/2046493003
Cr-Commit-Position: refs/heads/master@{#398256}

These friend declarations were added because MSVC had a bug around the
visibility of nested classes. They are no longer necessary.

BUG=617504

Review-Url: https://codereview.chromium.org/2041273002
Cr-Commit-Position: refs/heads/master@{#398255}

WorkerGlobalScope::m_thread was intentionally not cleared due to destruction ordering issues in Oilpan (*),
but I think the issue had existed only in the transition period.
This CL adds code to clear WorkerGlobalScope::m_thread in WorkerGlobalScope::dispose().

(*) https://chromium.googlesource.com/chromium/src/+/58f0cf11c7e11bc0dcdd09c08912625b89ba97bb

BUG=

Review-Url: https://codereview.chromium.org/2024033002
Cr-Commit-Position: refs/heads/master@{#398254}

BUG=none
R=pfeldman

Review-Url: https://codereview.chromium.org/2019143002
Cr-Commit-Position: refs/heads/master@{#398253}

This CL implements a simple search that matches the functionality of the
original history page.

This CL also fixes a bug related to window separators in the synced view
that could cause excess window separators to appear.

BUG=610934
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2022003002
Cr-Commit-Position: refs/heads/master@{#398252}

ArrayTraits<T>::Resize should return false and thus fail deserialization
if the array cannot be resized.

BUG=611802
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2045723002
Cr-Commit-Position: refs/heads/master@{#398251}

This is a simple refactoring CL, and does not involve any
functionality change.

BUG=616302

Review-Url: https://codereview.chromium.org/2024813003
Cr-Commit-Position: refs/heads/master@{#398250}

If the object is not window, info.This() == info.Holder(). Hence, we can just replace
info.This() with info.Holder().

If the object is window, info.Holder() is the inner window and info.This() is the outer window.
However, all accesses to the outer window are redirected to the inner window.
Hence, the replacement doesn't change any behavior.

BUG=

Review-Url: https://codereview.chromium.org/2042943002
Cr-Commit-Position: refs/heads/master@{#398249}

This matches the most recent update of the spec:
https://drafts.css-houdini.org/css-typed-om/#stylevalue-objects

BUG=545318

Review-Url: https://codereview.chromium.org/2036893003
Cr-Commit-Position: refs/heads/master@{#398248}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a4540654..80d06aa4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2046893002
Cr-Commit-Position: refs/heads/master@{#398247}

DrawArrays or drawElements should generate invalid operation error if no
buffer is bound to enabled attribution. Refer WebGL 1.0 spec for details
in section 6.5 "Enabled Vertex Attributes and Range Checking".

BUG=295792
TEST=conformance2/vertex_arrays/vertex-array-object.html
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2019513004
Cr-Commit-Position: refs/heads/master@{#398246}

On MacOS, GrabViewSnapshot() call would block for the duration of
display/GPU sleep which leads to protocol client to wait and tests
to time out when power saving is engaged. This prevents power saving
while there are pending screenshot requests.

BUG=599776

Review-Url: https://codereview.chromium.org/2044783002
Cr-Commit-Position: refs/heads/master@{#398245}

A mutation callback can be called after MutationObserver is disconnected
because MutationRecords are queued.

BUG=617578

Review-Url: https://codereview.chromium.org/2040123002
Cr-Commit-Position: refs/heads/master@{#398244}

This patch adds callbacks and observedAttributes to
ScriptCustomElementDefinition, as defined in the Element Definition
spec[1].

[1] https://html.spec.whatwg.org/multipage/scripting.html#element-definition

BUG=594918
TEST=imported/wpt/custom-elements/custom-elements-registry/define.html

Review-Url: https://codereview.chromium.org/2024073002
Cr-Commit-Position: refs/heads/master@{#398243}

BUG=none

Review-Url: https://codereview.chromium.org/2027093002
Cr-Commit-Position: refs/heads/master@{#398242}

The following two tests are causing graphical corruption and other
strange behaviors:

  WebglConformance.conformance2_textures_misc_copy_texture_image
  WebglConformance.deqp_functional_gles3_texturespecification_teximage3d_depth_pbo

BUG=617449
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org, zmo@chromium.org

Review-Url: https://codereview.chromium.org/2048453003
Cr-Commit-Position: refs/heads/master@{#398241}

For returning Size params, we don't have to create a Rect
object. Instead returning Size value directly.

BUG=

Review-Url: https://codereview.chromium.org/2045443002
Cr-Commit-Position: refs/heads/master@{#398240}

Reason for revert:
This breaks the Windows build on the waterfall.
The error log is:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/202064/steps/compile%20%28with%20patch%29/logs/stdio

FAILED: obj/ash/mus/lib/shelf_layout_impl.obj
ninja -t msvc -e environment.x86 -- E:\b\build\slave\cache\cipd\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/ash/mus/lib/shelf_layout_impl.obj.rsp /c ../../ash/mus/shelf_layout_impl.cc /Foobj/ash/mus/lib/shelf_layout_impl.obj /Fd"obj/ash/mus/lib_cc.pdb"
e:\b\build\slave\win\build\src\base\template_util.h(65): error C2718: 'ui::LatencyInfo': actual parameter with requested alignment of 8 won't be aligned
e:\b\build\slave\win\build\src\base\template_util.h(86): note: see reference to class template instantiation 'base::internal::IsAssignableImpl<Lvalue,Rvalue,false>' being compiled
        with
        [
            Lvalue=ui::LatencyInfo &,
            Rvalue=ui::LatencyInfo &&
        ]
e:\b\build\slave\win\build\src\base\template_util.h(103): note: see reference to class template instantiation 'base::is_assignable<ui::LatencyInfo &,ui::LatencyInfo &&>' being compiled
e:\b\build\slave\win\build\src\mojo\public\cpp\bindings\lib\template_util.h(58): note: see reference to class template instantiation 'base::is_move_assignable<T>' being compiled
        with
        [
            T=ui::LatencyInfo
        ]
e:\b\build\slave\win\build\src\mojo\public\cpp\bindings\array.h(34): note: see reference to class template instantiation 'mojo::internal::IsMoveOnlyType<MojomType>' being compiled
        with
        [
            MojomType=ui::LatencyInfo
        ]
e:\b\build\slave\win\build\src\out\debug\gen\cc\ipc\compositor_frame_metadata.mojom.h(121): note: see reference to class template instantiation 'mojo::Array<ui::LatencyInfo>' being compiled

Original issue's description:
> Remove base/move.h
>
> It's the same thing as DISALLOW_COPY_AND_ASSIGN now anyway.
>
> BUG=566182
>
> Committed: https://crrev.com/bb5161ab7ad524a9bced788f8099e786946f3a44
> Cr-Commit-Position: refs/heads/master@{#398237}

TBR=thakis@chromium.org,yzshen@chromium.org,jam@chromium.org,dcheng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=566182

Review-Url: https://codereview.chromium.org/2047633002
Cr-Commit-Position: refs/heads/master@{#398239}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5ede943f9a5e..c59289db852f

$ git log 5ede943f9..c59289db8 --date=short --no-merges --format='%ad %ae %s'

BUG=617838

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2042953002
Cr-Commit-Position: refs/heads/master@{#398238}

It's the same thing as DISALLOW_COPY_AND_ASSIGN now anyway.

BUG=566182

Review-Url: https://codereview.chromium.org/2038273002
Cr-Commit-Position: refs/heads/master@{#398237}

BUG=616700

Review-Url: https://codereview.chromium.org/2038873002
Cr-Commit-Position: refs/heads/master@{#398236}

Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
CSSValue* instead of a regular CSSValue*. This required changing
CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
CSSValue* as well, and marking CSSValueList::copy() as a const method
(which it already was, it was just missing the const modifier). This is
pre-work for making CSSValueList store const CSSValues.

This patch is mostly mechanical changes, but does contain one logic
change: the static method mergeTextDecorationValues in EditingStyle
needs to be changed since it modifies a CSSValueList that points inside
the mutable style. Instead, the function is changed to take two
CSSValueLists and return a new one, and the callsite is changed to
replace the old CSSValueList with the new one in the style rather than
modifying the old CSSValueList in-place.

Original patch is here:
https://codereview.chromium.org/2034013002

BUG=526586

Review-Url: https://codereview.chromium.org/2046463003
Cr-Commit-Position: refs/heads/master@{#398235}

This test was passing when the entire 'pacman' image area was filled
with the 'interior' color.  This change ensures that we test pixels on
the exterior and interior of the paths, within the pacman's bounds.

R=kbr@chromium.org
BUG=617805
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2042143002
Cr-Commit-Position: refs/heads/master@{#398234}

This CL reduces number of page_set iterations in PCv2,
to make the test run fit <60min in slow bots such as "Nexus 5 Perf".

Before this CL, PCv2 ran a URL 6 times, where as PCv1 ran a URL 3 times.
Which made a single page_cycler_v2.typical25 run take >60min, which caused
timeout on the perf bots.

BUG=617004
TBR=nednguyen@google.com

Review-Url: https://codereview.chromium.org/2041253002
Cr-Commit-Position: refs/heads/master@{#398233}

We are soon moving android-data directory from the current
fixed path (/home/chronos/user/android-data) to a path inside
mounted cryptohome (/home/root/<CryptohomeID>/android-data).
To prepare for that change, we start sending cryptohome ID in
StartArcInstance() D-Bus method.

Since we do not use |socket_path| parameter at all in
session_manager today, we will reuse it to pass the cryptohome ID.

BUG=b:26700652
TEST=trybot
TEST=ARC boots

Review-Url: https://codereview.chromium.org/2023803003
Cr-Commit-Position: refs/heads/master@{#398232}

Large mechanical rename change; should be ignored in git hyper-blame.

BUG=none

Review-Url: https://codereview.chromium.org/2015123002
Cr-Commit-Position: refs/heads/master@{#398231}

This is because we use copyTexImage to do the GPU to GPU copying, but in ES3
it is limited that source/destination color format component sizes have to match.

We can lift this limitation once we implement a different path where shaders are
used to do the copying instead of copyTexImage.

BUG=429053
TEST=gpu_bots
R=kbr@chromium.org,cwallez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2040773002
Cr-Commit-Position: refs/heads/master@{#398230}

We must check isSecureContext when creating the network provider to
adhere to https://w3c.github.io/webappsec/specs/powerfulfeatures/#settings-privileged.

We already did this for getRegistration(), register(), unregister() but must
also do this when deciding whether to control an in-scope document.

BUG=607543
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2009453002
Cr-Commit-Position: refs/heads/master@{#398229}

The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()

BUG=581865

Review-Url: https://codereview.chromium.org/2037833003
Cr-Commit-Position: refs/heads/master@{#398228}

BUG=591832

Review URL: https://codereview.chromium.org/2048573002 .

Cr-Commit-Position: refs/heads/master@{#398227}

When we detect a segment boundary we reinitialize the decoder. Currently
on Windows that results in tearing down the decoder instance the
D3D9/D3D11 device objects, the output picture buffers etc.

We don't need to tear down the output picture buffers and the d3d device
objects. This fixes the black frame which shows up due to the picture
buffers getting destroyed and new ones getting created.

In any case if the resolution changes we do request new output buffers
anyways.

I tested the test case in bug 594266 which was the reason for the config
change code in the first place. That still works in D3d9 and D3D11.

BUG=616349

Review-Url: https://codereview.chromium.org/2040093002
Cr-Commit-Position: refs/heads/master@{#398226}

The assert is no longer hit in WebGL conformance tests.
It seems that the bug is already fixed.

BUG=537922

Review-Url: https://codereview.chromium.org/2024013002
Cr-Commit-Position: refs/heads/master@{#398225}

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2034663003
Cr-Commit-Position: refs/heads/master@{#398224}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/619acd2c51c4..5ede943f9a5e

$ git log 619acd2c5..5ede943f9 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2046873002
Cr-Commit-Position: refs/heads/master@{#398223}

This CL replaces the simple mus CompositorFrameMetadata struct with a
full fidelity struct along with StructTraits. w00t! Soon full fidelity
CompositorFrames in Mus without extra copies!

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2042643002
Cr-Commit-Position: refs/heads/master@{#398222}