- 15 May, 2019 40 commits
-
-
Jan Krcal authored
This CL makes sure that user events recorded in sync-paused state are dropped and not uploaded once the user signs back in. Bug: 963429 Change-Id: I2eb5c0074d89c4fae17139d30270722d9b5cb30c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611688 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#659968}
-
Charlie Harrison authored
What: Unify logic for deciding what higher level protocol the top frame resource loaded with. Why: DRY, and also ensure a unified place to update QUIC versions, without needing a page_load_metrics reviewer. This change is purely a refactoring and shouldn't change any behavior. Bug: None Change-Id: I4dd8989d95c38128a0cb3c05d23569d0016344ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610086Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#659967}
-
Sébastien Séguin-Gagnon authored
Adds a new "Send to your devices" activity in the iOS Activity Sheet. Sends the current tab to the other user's devices when it's used. Bug: 944596 Change-Id: Idef4bdedb8955dc89bcea6d4baae0152e257a756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596356Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#659966}
-
Sadrul Habib Chowdhury authored
In some cases, the swap-ack happens *after* the frame has already been presented. In such cases, the 'wait-for-ack' step for the DrawAndSwap async trace-event ends later than the 'wait-for-present' step. This confuses the trace-viewer, resulting in some never-ending DrawAndSwap trace-events. This can also be confusing in general. So remove the intermediate 'wait-for-ack' step, since all frames now get a presentation-timestamp. BUG=944101 Change-Id: Ifd29adc0d54a662a314f7e624d17cc6f30d10de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612379Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#659965}
-
Dan Erat authored
This reverts commit 58d0fc5b. Reason for revert: Breaks SyncChrome stage on Chrome OS builders. See https://crbug.com/963259. Original change's description: > Enable openscreen compilation in Chromium > > This change enables third_party/openscreen to be built as part of gn_all > so we can get coverage on linux bots which will help to ensure we aren't > breaking our Chromium compatibility while we are still pre-integration. > This doesn't cause anything to be linked into any shipping binaries. > > Bug: 951615 > Change-Id: I65a67054d9545865a51c5dc3cf8d1bb206fc8391 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562751 > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Brandon Tolsch <btolsch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659696} TBR=thakis@chromium.org,dpranke@chromium.org,mbonadei@chromium.org,btolsch@chromium.org Change-Id: Id26267e90640af73018933c2bc1d708f398ed36a No-Presubmit: true Bug: 951615, 963259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612370Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#659964}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4d4a190ba1f5..10186cb85fd6 git log 4d4a190ba1f5..10186cb85fd6 --date=short --no-merges --format='%ad %ae %s' 2019-05-15 chrisforbes@google.com Override imageview swizzles for channel replacement edge cases Created with: gclient setdep -r src/third_party/swiftshader@10186cb85fd6 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/119620767 TBR=swiftshader-team+autoroll@google.com Change-Id: Ibadfce499e7bbb1b07825537de23af8783cf53a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613236Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659963}
-
Javier Ernesto Flores Robles authored
Updates the constraints related to dynamic type when the content size category changes. Sets all labels and text fields to automatically adjust fot the content size category. Bug: 959764, 951300 Change-Id: Ib072e40ef1821e20941740e07f194e5a17ccecdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611604 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#659962}
-
Kush Sinha authored
After Chrome OS Account Manager becomes the source of truth for Google Accounts in Chrome OS, we need to route all Google Account management Intents from Android to Chrome OS Account Manager. Add IPC methods in auth.mojom to handle these requests. Bug: 871690 Change-Id: I6b0a0279f8a78412c24e21186f34e04a41c346a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588640Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#659961}
-
Daniel Cheng authored
Looks like this was used for mus at one point, but is no longer needed: https://chromium-review.googlesource.com/c/chromium/src/+/673066/ Change-Id: I7a48df40b4b424fdd2dc823176be01204885ada7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612844 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#659960}
-
Andrew Grieve authored
It conflicts with TrichromeWebview's BuildConfig class. Fixes locale pak issues when running with is_java_debug=false Change-Id: I75a53119b1148c1c264554bbe5df49f912cb342f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613361 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#659959}
-
Robert Sesek authored
This adds a new buildflag controlled by the GN arg new_mac_bundle_structure. When this flag is set to true, the layout of the inner app bundle will change. Today, the Framework that contains all the code and resources for the product lives at the following path (or its branded equivalent): Chromium.app/Contents/Versions/VV.0.VVVV.V/Chromium Framework.framework/Versions/A With the flag set to true, the framework will move to: Chromium.app/Contents/Frameworks/Chromium Framework.framework/Versions/VV.0.VVVV.V This change will let Google Chrome be notarized. Under the existing bundle structure (i.e. when the flag is set to false), the Versions directory requires the use of the obsolete --resource-rules code signing flag so that the Keystone updater can stage new versions in the Versions directory, without invalidating the signature of the app. But --resource-rules are incompatible with notarization. To work around this, the change leverages the use of "nested code" in frameworks. Because a framework bundle can contain multiple versions, each version is signed in its entirety, but the outer framework containing those versions is not signed directly. When the framework (and its version) are embedded within an .app bundle, the signature of the framework is recorded along with the signing "Team ID". The code signing system allows a new version of the framework to be staged inside the framework's Versions directory so long as it is signed by the same "Team ID". Bug: 958976 Change-Id: Iacf78fa7d96e3a95a20d6248771e5da7e04bd81c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592230Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#659958}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/226668a14690..1f09898e9a8a git log 226668a14690..1f09898e9a8a --date=short --no-merges --format='%ad %ae %s' 2019-05-15 robertphillips@google.com Add GrVkFormatIsCompressed and GrVkFormatCompressedDataSize to rm uses of GrPixelConfig 2019-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 853f66269c16..1578d6b6f5dd (1 commits) 2019-05-15 brianosman@google.com Interpreter: Remove vectorized branches 2019-05-15 bungeman@google.com Move SkTSearch.h into src. 2019-05-15 robertphillips@google.com GrVkCaps: add isFormatRenderable and rename some isConfig* methods to isFormat* 2019-05-15 bungeman@google.com Remove tools/clang from .gitignore Created with: gclient setdep -r src/third_party/skia@1f09898e9a8a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I815194fb653a8ea54f4ebaf6dd00243942a89868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613318Reviewed-by:
-
Raphael Kubo da Costa authored
IWYU after commit 153dd1a6 ("sqlite: Rewrite custom recovery code"), which also fixes the libstdc++ build: ../../sql/recover_module/integers.h:67:6: error: no template named 'pair' in namespace 'std' std::pair<int64_t, const uint8_t*> ParseVarint(const uint8_t* buffer, ~~~~~^ Bug: 957519 Change-Id: Iee9ae4cfb1c3531b6fcd2080f5b9a3bcfc25f5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611690 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#659956}
-
Igor authored
If the policy dictates to lock the device to single user, the failure to do so generates the user to be logged out. Here we add UMA stats to have metrics on how often this happens. BUG=b:77799573 TEST=None Change-Id: I5eea6616628c2130f25c746b3ce9cabd63d139a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595868 Commit-Queue: Igor <igorcov@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#659955}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/69250bb90295..023ca2db25ad git log 69250bb90295..023ca2db25ad --date=short --no-merges --format='%ad %ae %s' 2019-05-15 akahuang@google.com chromeos_config: Mark some CQs experimental. Created with: gclient setdep -r src/third_party/chromite@023ca2db25ad The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I49a9068647647d434947d3d589eee151c8551491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613377Reviewed-by:
-
Michael Lippautz authored
All uses must go through MakeGarbageCollected. Bug: 945806 Change-Id: I825ac265bb6a18cbaf0b5393e70bec671cf15ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613298 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#659953}
-
Sebastien Lalancette authored
The feature has been successfully rolled-out to 100% Stable. Now cleaning up flag in the client and the dead code. Bug: 920214 Change-Id: I55675ecc742ca36c17718bcc56e5107f9291f702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610217Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#659952}
-
Shimi Zhang authored
To make it a little easier to read ShowContextMenu(), should have no logic change. Test: Current tests should pass. Bug: None Change-Id: I807f770f331673d5d003be63d2b606b0c60b004f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612216 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#659951}
-
Allen Bauer authored
Views cleanup: Changed to use GetVisible() and GetEnabled() instead of visible() and enabled(), respectively. NOTE: View::visible() and View::enabled() are still present for now. They'll be removed in a subsequent CL due to the sheer size of this CL. TBR=sky@chromium.org TBR=tapted@chromium.org TBR=pkasting@chromium.org TBR=oshima@chromium.org TBR=estade@chromium.org TBR=yhanada@chromium.org Change-Id: I8908242f1a8f1f4767c05c6f5ef8d8009c4ec585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610082Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#659950}
-
Yue Zhang authored
This CL enables dragging to reorganize tabs in TabGridDialog and TabGridSheet. It is now behind the flag TabGroupsAndroidUiImprovements. Bug: 961433 Change-Id: Ib12025fdd1635962cb785399b7f7558d11ce6e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611305 Commit-Queue: Yue Zhang <yuezhanggg@google.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#659949}
-
Lan Wei authored
It seems that after the layout changes, LocalFrameView:: PerformPostLayoutTasks is always called, so we do not need to update the hover in Document::UpdateStyleAndLayoutTree. Bug: 877132 Change-Id: I542ced9577839b6fb5539e82bda5effe48ef1700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568305Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#659948}
-
Yuke Liao authored
The coverage merge script test is broken and this CL fixes it. This CL also adds a new test case for the recently newly added logic to correctly handle test targets that don't generate any profraw files. TBR=robertocn@chromium.org Change-Id: I7ce1faf8c1479cfe0586470ae17ccd567faa765b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604402 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#659947}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ca7d526d..9d8a97f7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia3226d1eec277d5b21faab65e41c1439b3629069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613230Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659946}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d0a84f04275f..ed36a5728bd9 Created with: gclient setdep -r src-internal@ed36a5728bd9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fergal@google.com,avi@google.com,btolsch@google.com,andypaicu@google.com Change-Id: I69ac488f2a57e82a58db2374b584f71a0c46d3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613232Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659945}
-
James Lissiak authored
devtools:// scheme This change replaces the chrome-devtools:// URL scheme, with a more browser-agnostic equivalent. Naturally, many files had to be touched, but it's mostly a straightforward find/replace. A related change is out against the catapult repo here: https://chromium-review.googlesource.com/c/catapult/+/1606268, which removes a test file containing the old scheme. Once it goes in, the root DEPS file in the chromium repo needs to be updated as well. Note: This is a continuation of patch 1552143, but since Fabio is out on leave and I don't have permissions to upload to his patch, I needed to start a new one. Bug: 960409 Change-Id: I3ede7f8d1dcbca457167eb3641ae60e9685d8d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582881 Commit-Queue: James Lissiak <jalissia@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#659944}
-
Lan Wei authored
In order to run the web-platform-tests automatically, we will use testdriver Action API in all the wpt to simulate inputs. Here we are changing some pointerevent input tests which have touch, mouse and pen inputs and complex actions. This is the sixth CL that changes part of the pointerevent input tests. Bug: 606367 Change-Id: I1e4a273fed440ba23f851a11f6e8c3eac8d18c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603786Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#659943}
-
Max Morin authored
An earlier CL added the function to filter studies by OS version, but didn't actually call it. This CL calls the function and was manually verified to work (with a local instance of the variations server). Bug: 956059 Change-Id: I7f5af7a0f846ebe5c1cc5734922b5391725d9255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609853 Commit-Queue: Max Morin <maxmorin@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Max Morin <maxmorin@chromium.org> Reviewed-by:
-
Benoît Lizé authored
This small CL unifies |PurgeMemory()| in PartitionRootBase. Besides making the decommit code more regular, this will make a common periodic decommit in base/allocator clearer. Bug: 942512 Change-Id: I9cab9d9012e87622a09bf22e055278cf16b4f8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609701Reviewed-by:
-
sczs authored
Adds an InfobarType parameter to InfobarCoordinator designated initializer. Bug: 892376 Change-Id: Ic72d8d8c5c42e249d67bc2ff5ff788b6800b68a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612223Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Missed in the mass rename because there was a typo in their name. R=fdoray@chromium.org Bug: 951388 Change-Id: I5a00d98964a857de59ecb909b08952bf5249a799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612215 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#659939}
-
Max Moroz authored
Otherwise, the readers might get an idea to use max_len in there, which is deprecated and discouraged now. Bug: 539572 Change-Id: I6a2d14ca59326fb4e037caec30e05d731f608520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611872 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Auto-Submit: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#659938}
-
Lukasz Anforowicz authored
This CL excludes Sec-Fetch-... request headers from the Request object passes to the service worker's `fetch` event. This CL also adds WPT tests that verify that these request headers will be re-added when the service worker forwards the request back into the network (via implicit fallback, or via an explicit responseWith+fetch). Bug: 949997 Change-Id: I04422a1630f62b497961ca1789007f2402148e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611314 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#659937}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/348880c3f67f..226668a14690 git log 348880c3f67f..226668a14690 --date=short --no-merges --format='%ad %ae %s' 2019-05-15 brianosman@google.com Add support for calling functions within the interpreter Created with: gclient setdep -r src/third_party/skia@226668a14690 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I6b5ee13063a04558dcdd0c7f1850cbf4486fe527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613228Reviewed-by:
-
Gyuyoung Kim authored
As the first step to deprecate WTF::CString, the bug has suggested replacing EXPECT_STREQ with EXPECT_EQ. This CL replaces EXPECTED_STREQ with EXPECT_EQ in the cases of both converting WTF::String to const char* to use EXPECTE_STREQ and the expected string is ASCII. Bug: 950077 Change-Id: I6db21bbbb15d856a1e790f590a2b375136a9bd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609723 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#659935}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f815e6fe51af..84503583c6f0 git log f815e6fe51af..84503583c6f0 --date=short --no-merges --format='%ad %ae %s' 2019-05-15 stevenperron@google.com Handle id overflow in sroa better. (#2582) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@84503583c6f0 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: Ia382ce0bfdd671090c7b49ec6bafeef570cf8d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613227Reviewed-by:
-
Jeremy Roman authored
For the pointer arithmetic to produce aligned results, the struct itself must have a size which has alignment at least as strong as the types that are to be stapled to the end. This is presently not guaranteed, since ImmutableCSSPropertyValueSet actually happens to have no pointer members (or anything else that would force 8-byte alignment on 64-bit). Change-Id: Ie7536949abe5919e1ccc374a206321c26da6474c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613231Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#659933}
-
Samuel Huang authored
Updating stale info while trying to prototype devtools DFM. Recent changes that led to changes include: * module_names_to_package_ids.gni deletion: https://chromium-review.googlesource.com/1601535 * monochrome_public_bundle_tmpl target rename: https://chromium-review.googlesource.com/1553913 Bug: 927131 Change-Id: I59d13574469603c8400b4ba4db5c45de3944ba33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610979Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#659932}
-
Allen Bauer authored
TBR=sadrul@chromium.org TBR=jamescook@chromium.org Bug: 938501 Change-Id: Ida379ba48c0ed14bbed27a7799cbda7b8e80572e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602653 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#659931}
-
Aaron Colwell authored
Removing reference cycle between BrowsingInstance and default SiteInstance that was accidentally introduced in http://crrev.com/c/1452714 Bug: 958683 Change-Id: I73e2a3ec5c0ece04e341a9206009aaf48528edbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610991 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
-
danakj authored
BrowserMain() is the general entry point for running the main loop in the Browser process, which is run by ContentMain(). ContentMain() will choose an appropriate methods based on the process type. The ContentMainDelegate is given a chance to pre-empt ContentMain() by returning a value >= 0 from RunProcess(). If it returns < 0, then ContentMain() will choose a function such as BrowserMain() based on the process to run. If it returns >= 0, ContentMain() will do nothing more. In ContentShell (and content/components browser tests), the ShellMainDelegate does replace the BrowserMain() call always. For Web Tests, it does so with WebTestBrowserMain(), and otherwise it does so with ShellBrowserMain(). However, then Android comes into play. On Android ShellBrowserMain() only initializes the BrowserMainRunner and does not run it, nor shut it down, and the BrowserMainRunner's lifetime is adjusted to match the ShellMainDelegate, which is leaked, making the BrowserMainRunner leak as well. Rather than having ShellMainDelegate override the BrowserMain() behaviour in all cases, we can return -1 when not running Web Tests and have ContentMain() do the right thing already. Then, on Android, we can initialize a BrowserMainRunner, leak it, and return, rather than delegating to ShellBrowserMain. At that point the function is dead and can be removed. We then also simplify return/exit codes throughout this code. For Web Tests there is never a return value other than 0, so change functions to void and move the return 0 statement up the stack. For Android content shell/browser tests, the caller has to know to not run BrowserMain() even though the return value is < 0. Instead for ShellMainDelegate we have it return 0, and we DCHECK that for BrowserTestBase. The ChromeMainDelegateAndroid still returns -1, so we can not change ContentMain() to not know Android magic, yet. We will do so in another CL. R=avi@chromium.org Bug: 961849 Change-Id: Iddd611afaff039e0b55a3917f00a6816c5939ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609676 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
