- 23 Aug, 2018 40 commits
-
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ee0c9aa66269..ce6a1cc587a7 git log ee0c9aa66269..ce6a1cc587a7 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 hnakashima@chromium.org Reorder RenderResult and RenderDeviceResult in CBC_TwoDimWriter. 2018-08-23 tsepez@chromium.org Remove bool bPromptCJK argument (several places) 2018-08-23 hnakashima@chromium.org Remove m_bTruncated flag from CBC_PDF417Writer. 2018-08-23 tsepez@chromium.org Fold CPDF_Document::LoadDocInternal() into caller. 2018-08-23 tsepez@chromium.org BUILD.gn - put cfx_windowsrenderdevice.h in win-specific section. Created with: gclient setdep -r src/third_party/pdfium@ce6a1cc587a7 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I06a60b719cbd6372e0d7eab4e7740b94205292db Reviewed-on: https://chromium-review.googlesource.com/1187282Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585602}
-
Andrew Xu authored
Apply the same logic of tab refreshing in original code to each selected tab. Before modification, Only one tab was refreshed after pressing Ctrl-R regardless of how many tabs you selected. But pressing Ctrl-W was able to close several tabs. R=afakhry@chromium.org Bug: 862102 Test: browser tests Change-Id: I8f038c0bffccde3b57f071046fbca99f5e9d7ed4 Reviewed-on: https://chromium-review.googlesource.com/1180516 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#585601}
-
Stephen Martinis authored
This is a reland of 2db41802 This CL will not schedule builds on the bots initially. This will let me test what's going wrong without breaking the waterfall and confusing sheriffs. Original change's description: > Add debug chromium bots > > These are mirrors of the existing release bots > > Bug: 867725 > Change-Id: I6f59d04a82103572e801273e294534e822d3e03d > Reviewed-on: https://chromium-review.googlesource.com/1159172 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Nodir Turakulov <nodir@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582390} Bug: 867725 Change-Id: Ic401e310241bb986f3fbba4666e2e9bfa191be5a Reviewed-on: https://chromium-review.googlesource.com/1184120 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#585600}
-
Aldo Culquicondor authored
VrShellGl no longer inherits from RenderLoop, instead it's owned by it. VrShellGl implements both SchedulerDelegate and CompositorDelegate. All communication to the delegates from VrShell go through the RenderLoop. Bug: 875291 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifb9def1ea748648e3eea2dac1c80b48d7da07e5c Reviewed-on: https://chromium-review.googlesource.com/1185380 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#585599}
-
Robert Ogden authored
Prevents navigations to media URLs (like an mp4 or jpg) from triggering HTTPS Server Previews. This blacklist is a comma separated string that is controlled via field trial. Bug: 864637 Change-Id: Iff545d975c8c17aa433a95f57d8a01d86cf73279 Reviewed-on: https://chromium-review.googlesource.com/1187200Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#585598}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I73274f6ea1965347f555af835fcb079331e178f9 Reviewed-on: https://chromium-review.googlesource.com/1187325Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585597}
-
Douglas Creager authored
This lets non-browser native apps preconfigure a list of domain names under their control, and allow Reporting and NEL to collect reports about those domains before receiving configuration headers from actual responses. (Note that once a policy header is received in an actual response, that will take precedence over any preconfigured headers.) Bug: 811472 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5e64020e5f75485c676dd0751f1dc444fb07e472 Reviewed-on: https://chromium-review.googlesource.com/1171112Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Douglas Creager <dcreager@chromium.org> Cr-Commit-Position: refs/heads/master@{#585596}
-
Zhongyi Shi authored
Changes to make quic::simulator usable in Quartc tests: - Make //third_party/quic/test_tools/simulator visible to //media/webrtc/quartc - Make the QuicClock* passed to QuartcFactory const Quartc has its own transport simulators, but these run in real-time, making them less useful for writing consistent unit tests. In particular, it's much easier to test deadlines and execution of alarm-based async code using a controlled environment with a fake clock. The QUIC simulator provides this. Merge internal change: 208743968 https://chromium-review.googlesource.com/c/chromium/src/+/1186095 Switch QuartcSessionTest to use QUIC's simulator components rather than its own. QuartcSessionTest contains a rudimentary implementation of network link simulation. This is basically the same thing that QUIC's Simulator provides. Now that we've implemented a Simulator-compatible QuartcPacketTransport, we can use the Simulator and its utilities rather than rolling our own. The only requirements to do this are: 1. Implement a packet filter to drop packets (to test cancel-on-loss) 2. Intercept packet numbers in the simulated transport (to test our packet-number hack) The former is far simpler than implementing all our own test facilities. The latter should be temporary (until we can move this test somewhere else or QUIC provides packet numbers through the writer interface). Merge internal change: 208705925 https://chromium-review.googlesource.com/c/chromium/src/+/1186090 Create a QuartcPacketTransport implementation that uses QUIC's test simulator. This implementation uses the simulator interfaces in quic/test_tools/simulator to send and receive packets. The QUIC network simulator uses a fake clock to schedule all network events. It should make it possible to write deterministic component tests for quic/quartc code. The simulated transport is a quic::simulator::Endpoint which can be connected to other endpoints through a fabric of quic::simulator:: links and switches. It implements the UnconstrainedPortInterface to receive packets. Received packets are passed to the Delegate. The transport keeps a queue for outgoing packets (to simulate an OS or NIC queue before the local link). When this queue is full, it rejects calls to Write(). It implements Queue::ListenerInterface to observe dequeue events and calls Delegate::OnTransportCanWrite() to unblock the caller whenever room is available for more packets. Finally, Quartc packet writers will not start writing until they observe an initial OnTransportCanWrite() signal. The packet transport schedules a call to this method as soon as the delegate is set. This is similar to the behavior of real Quartc transport implementations such as ICE, which makes an initial call to OnTransportReadyToSend() after ICE establishes a connection. Merge internal change: 208570696 https://chromium-review.googlesource.com/c/chromium/src/+/1186079 Change-Id: I19a8a62838c7080fc4e644c039c389253df61cac Reviewed-on: https://chromium-review.googlesource.com/1186096Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#585595}
-
Kurt Horimoto authored
This CL updates CRWWebViewContentView to utilize the normal UIView layout flow to resize the WKWebView rather than explicitly calling |-updateWebViewFrame|. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8e4a3c464483818c9799424c097f5ed7711d6d8e Reviewed-on: https://chromium-review.googlesource.com/1186099Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#585594}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0c6dfe3a70c996789a01500b4186a9574613f938 Reviewed-on: https://chromium-review.googlesource.com/1187369Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#585593}
-
Cole Winstanley authored
This reverts commit 7464a454. Reason for revert: Causing waterfall failures. Going to rethink test structure. Original change's description: > [ChromeDriver] Reland with fix: add replay tests to run_all_tests.py > > Bug: chromedriver:2553 > Change-Id: I4c8d50c819f128ced652bc397bb294de3984ed2e > Reviewed-on: https://chromium-review.googlesource.com/1185783 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Cole Winstanley <cwinstanley@google.com> > Cr-Commit-Position: refs/heads/master@{#585267} TBR=johnchen@chromium.org,cwinstanley@google.com Change-Id: I544dbfa8e5fc68d0c60a70a15b328c805300daec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromedriver:2557 Reviewed-on: https://chromium-review.googlesource.com/1187087Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Cole Winstanley <cwinstanley@google.com> Cr-Commit-Position: refs/heads/master@{#585592}
-
Eugene But authored
Do not create radial progress path until the view is added to the hierarchy. Bug: 875932 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic4bfab416cdc6dd4cf3e7a1b4c1f4624b7cab0bf Reviewed-on: https://chromium-review.googlesource.com/1182867Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#585591}
-
Nico Weber authored
https://chromium-review.googlesource.com/706280 resolved it. Bug: none Change-Id: Ifedb80be1c3a8ad2af17552e024d7b6e0228ff03 Reviewed-on: https://chromium-review.googlesource.com/1187198Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#585590}
-
Wez authored
Delete the AsyncLayerTreeFrameSink from the |bg_thread|, on which the test actually uses it. Bug: 729716 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id1fd667d44bb2a8e1b6cbd973f1ec0708f47ee99 Reviewed-on: https://chromium-review.googlesource.com/1186186Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#585589}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/81db1d50324a..d06cc78ec8cc git log 81db1d50324a..d06cc78ec8cc --date=short --no-merges --format='%ad %ae %s' 2018-08-23 tandrii@chromium.org git cl: use project~number on Gerrit in more RPCs. Created with: gclient setdep -r src/third_party/depot_tools@d06cc78ec8cc The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:876910 TBR=agable@chromium.org Change-Id: Id8cdcbed896cfc23f316a78e1dbccbd6699e2503 Reviewed-on: https://chromium-review.googlesource.com/1187201Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585588}
-
W. James MacLean authored
Adds logging to SitePerProcessEmulatedTouchBrowserTest.EmulatedTouchShowPressHasTouchID to verify the gesture stream when the test times out. Bug: 833380 Change-Id: I8cf2e92a6f13aa38e3294f4511d53ce658cd62a5 Reviewed-on: https://chromium-review.googlesource.com/1187280Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#585587}
-
Drew Davenport authored
Some use cases, such as some implementations of realpath(), require calling stat() on all intermediate dirs of a path, but otherwise do not need to open or read those directories. Bug=b:112486795 Test=sandbox_linux_unittests passed Change-Id: Iea0bad8be9e238a854de383ac6dc5124f462ead3 Reviewed-on: https://chromium-review.googlesource.com/1185376Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Drew Davenport <ddavenport@chromium.org> Cr-Commit-Position: refs/heads/master@{#585586}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/132145aa..6d5c73cf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6825e1d5079de8edf509d1cbf5234d2263135f6d Reviewed-on: https://chromium-review.googlesource.com/1187184Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585585}
-
Becky Zhou authored
Bug: 851981 Change-Id: I2e97155353f2119661df92cdd023e2e086328d18 Reviewed-on: https://chromium-review.googlesource.com/1157441 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#585584}
-
James Cook authored
Now that ash and the ui service are in the same process we don't need to use PointerWatcher in ash anymore. This is a partial manual revert of: https://codereview.chromium.org/1934123004/ Bug: 595851, 872450 Test: ash_unittests Change-Id: Ifbbb407210d0b3ec8d20993bff7a0f2cf44ba38e Reviewed-on: https://chromium-review.googlesource.com/1186032 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#585583}
-
Miguel Casas authored
This CL folds VaapiJpegDecoder, a class with only one static method, into its only caller VaapiJpegDecodeAccelerator. The static method, VaapiJpegDecoder::Decode(), is renamed to DoDecode(). This method and the bunch of file-static ones are moved verbatim -- untouched. It also takes the chance to clean up: removes unused includes and member variables, and forward declares as much as possible (otherwise va/va.h, a pretty large file was transitively included, ugh). All in all, less lines ! Test: jpeg_decode_accelerator_unittests passing as before. Bug: 876810 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1f37f378121840d6d1eb83018c5122bb0ed6b01c Reviewed-on: https://chromium-review.googlesource.com/1185218Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#585582}
-
Jinho Bang authored
Related spec change: https://github.com/w3c/payment-request/pull/721 Tests: chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc components/payments/content/payment_request_spec_unittest.cc components/payments/content/payment_request_state_unittest.cc Manual tests: wpt/payment-request/payment-response/retry-method-manual.https.html wpt/payment-request/PaymentValidationErrors/retry-shows-shippingAddress-member-manual.https.html wpt/payment-request/PaymentValidationErrors/retry-shows-payer-member-manual.https.html Demo: https://youtu.be/_mbcGkbwfw8 Bug: 861704 Change-Id: I12c2d74f7b170626d2c9a41ecfc9116bfe75c2b7 Reviewed-on: https://chromium-review.googlesource.com/1144587 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#585581}
-
John Z Wu authored
Currently all CSP errors are reported wrongly as INITIALIZATION_ERROR, this change will report it as BAD_ORIGIN. Change-Id: I2cc09d9dcd722ab0657605e540acac69e142eb6c Bug: 686364 Reviewed-on: https://chromium-review.googlesource.com/1141047 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#585580}
-
Sujie Zhu authored
In this CL, we finish the basic two round pop-up window workflow. We add LoadRiskData at the same time the first prompt pops up when the legal docs are successfully fetched. The callback of the first prompt(ShowLocalCardMigrationPrompt) is OnUserAcceptedIntermediateMigrationDialog() which will trigger the second prompt. We will send the Migration request only when both the risk data is prepared and user accepted on the main prompt. Send Migration Request will included in the following CL. Use the intermediate bubble as the main prompt for now. Need to wait for Siyu's Main Prompt skeleton check-in to replace the main prompt call. TBR=rogerm@chromium.org Bug: 852904 Change-Id: Ic881a64b7da93316ff8a8a0e84bc0c20a39a030d Reviewed-on: https://chromium-review.googlesource.com/1149151 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#585579}
-
Nico Weber authored
Since we didn't do them yet, they probably weren't important. Bug: none Change-Id: Ifbb2da04f2f6b0f3b125a7dbaa8ab732bd77fc6b Reviewed-on: https://chromium-review.googlesource.com/1187013Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#585578}
-
Christian Biesinger authored
The test failed with a NO_RESOURCE error; try to match the bot config of the other testsuite exactly. https://ci.chromium.org/buildbot/chromium.perf.fyi/Mojo%20Linux%20Perf/6935 R=nednguyen@google.com No-Try: True Change-Id: I30a90a5991030f26ff70bbedc26fd5c8785fcd33 Reviewed-on: https://chromium-review.googlesource.com/1187074Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#585577}
-
John Delaney authored
This is a reland of 66ce35f8 Reverted in : https://chromium-review.googlesource.com/c/chromium/src/+/1184062 See : https://crbug.com/876463 Build #2592 succeeded without reversion and test seems flaky in more recent builds (#2608). Not believed to be the cause of the failing test. TBR=kinuko@chromium.org Original change's description: > Remove data use updates from page load metrics > > Now that per-resource updates are sent to page load metrics, we no > longer need to send totals from the renderer process. Remove all > piping/callbacks and convert existing consumers to > OnResourceDataUseObserved. > > Per-resource updates: > https://chromium-review.googlesource.com/c/chromium/src/+/1164222 > > Change-Id: I1cb03df5e6579fc0ff767900336308a6bbad244a > Reviewed-on: https://chromium-review.googlesource.com/1178324 > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: John Delaney <johnidel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584744} Change-Id: Ifdc90e57677eb214e404616a41242d5fc1fa64a0 Bug: 876463 Reviewed-on: https://chromium-review.googlesource.com/1185101 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#585576}
-
Martin Kreichgauer authored
1) Change FidoRequestHandler to not terminate a WebAuthn request when a request handler replies with the CTAP2_ERR_INVALID_CREDENTIAL or CTAP2_ERR_CREDENTIAL_NOT_VALID CTAP2 error codes. These error codes do not indicate that the user has interacted with the authenticator and we therefore must not resolve the WebAuthN request promise upon receiving such an error. 2) Remove kCtap2ErrCredentialNotValid since CTAP2_ERR_CREDENTIAL_NOT_VALID has recently been dropped from the CTAP2 spec. 3) Change references to kCtap2ErrCredentialNotValid in U2F code to kCtap2ErrNoCredentials in order to not change behavior of that code with regards to request canceling. Change-Id: Ied8dd2c8b4af939d6b922c0007520b90d3a92388 Reviewed-on: https://chromium-review.googlesource.com/1185220 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#585575}
-
rajendrant authored
This rename enables adding a DeferImageLoad for css background images Bug: 846170 Change-Id: I5c243e3560ae222742c08a6ac18ebb6cb859b37f Reviewed-on: https://chromium-review.googlesource.com/1178686 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#585574}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I16cea32fc83ea6ce616efd941daf587786b6e7dd Reviewed-on: https://chromium-review.googlesource.com/1187067 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#585573}
-
Jordy Greenblatt authored
With Settings adding a test for Polymer 2 for CQ submission, two browser tests, multidevice_feature_toggle_tests and multidevice_feature_item_tests started failing. Because they were blocking dogfood and the failures were with the tests rather than than the prod code, we decided to remove the tests as a temporary measure. This CL adds them back and changes them to deal with a problem caused by the Polymer 2 migration: In Polymer 1, the shadow tree of an element is build upon creation while in Polymer 2, it is not built until the element is appended to document.body. As a result, some paths that were safe to reference before appending in Polymer 1 can now only be referenced after. Change-Id: I78945bfad0675602ebf9a73ae08e21ffa2292e13 Reviewed-on: https://chromium-review.googlesource.com/1184315Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#585572}
-
John Abd-El-Malek authored
Bug: 848073 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I60408ab991595b0057d017e53a4746794343c0b8 Reviewed-on: https://chromium-review.googlesource.com/1182949Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#585571}
-
Daniel Zhang authored
Change padding of title label in AppListItemView from 0px to 8px to match specifications: https://screenshot.googleplex.com/bmrE2eaixE0 Bug: 876503 Change-Id: Id12b3ddfe4bc95372d236b81468e25db5db576b5 Reviewed-on: https://chromium-review.googlesource.com/1186098Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Daniel Zhang <oxyflush@google.com> Cr-Commit-Position: refs/heads/master@{#585570}
-
Jun Choi authored
This is a reland of 42e740f0 Original change's description: > Move call to GetInfo command after AuthenticatorAdded() > > In order to prevent system UI dialogs for BLE/Touch ID from appearing > prior to WebAuthN UI, we hold off on dispatching request to > authenticators until user consents on using the specified transport > type. However, in current implementation, we send GetInfo command to > external BLE authenticators as soon as we discover the device. This > would trigger OS UI dialog on Mac for unpaired devices and potentially > cause BLE connection failures on other platforms. As so, move call to > GetInfo command after FidoRequestHandlerBase::AuthenticatorAdded(). > > Bug: 847985 > Change-Id: I37b7cd8118c3edb799fa29c36700febbb2b3d08e > Reviewed-on: https://chromium-review.googlesource.com/1182946 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Jun Choi <hongjunchoi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585130} Bug: 847985 Change-Id: I457228768db9abc25a57f167928e55f342c1f15e Reviewed-on: https://chromium-review.googlesource.com/1187082 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#585569}
-
Min Chen authored
Because of this cl https://chromium-review.googlesource.com/c/chromium/src/+/1173158 The new selector item will be scaled up when we start drag a window from top. But actually we just want to get the bounds of the scaled up new selector item, we don't actually want to scaled it up in this case. Bug: 872528 Change-Id: I4d132680ed35440eb5873620412fba1931db1857 Reviewed-on: https://chromium-review.googlesource.com/1182799Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#585568}
-
Scott Violet authored
The mojoms TouchDeviceServer, NativeDisplayDelegate and AccessibilityManager are all not needed. Additionally TouchTransformSetterMus is not used. BUG=none TEST=none Change-Id: I8d42aac5d548e5a109289133baeb3dd7fa3dd26b Reviewed-on: https://chromium-review.googlesource.com/1185969Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#585567}
-
Chris Blume authored
Right now, ContextCreationAttributes are initialized differently in OOP-D [1] and on non-OOP-D Android [2]. Update OOP-D's initialization to match what Android needs. [1] https://cs.chromium.org/chromium/src/components/viz/service/display_embedder/viz_process_context_provider.cc?l=42&rcl=696fb33bfb93ed9b759fa06aea81d26beedb4872 [2] https://cs.chromium.org/chromium/src/content/browser/renderer_host/compositor_impl_android.cc?l=291&rcl=696fb33bfb93ed9b759fa06aea81d26beedb4872 BUG=867453 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I2e7abe55d3a7df84686e233ebd71cfbd51a77afd Reviewed-on: https://chromium-review.googlesource.com/1155841 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#585566}
-
Clark DuVall authored
This is a reland of e00fddec Needed to initialize variables in ChromeBrowserMainBrowserTest for asan/msan. Verified this works with msan build. Original change's description: > Reland "Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker" > > This is a reland of a9ed46b7 > > ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange > was flaky in the original change. Added logic in the test to wait for the > connection type change. > > Only diffs from original are in chrome/browser/chrome_browser_main_browsertest.cc > > Original change's description: > > Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker > > > > A getter is used for NetworkConnectionTracker because some services that > > use ResourceRequestAllowedNotifier are initialized early in browser > > startup (e.g. VariationsService), and only perform the initialization > > of ResourceRequestAllowedNotifier later on the UI thread. The getter > > allows us to run get the connection tracker at that point so we don't get > > DCHECKs about being on the UI thread when running > > content::GetNetworkConnectionTracker(). > > > > This also moves the NetworkConnectionTracker in ios/ from BrowserState to > > ApplicationContext, which is available everywhere. It also matches non-IOS > > usage more closely, since we have it as a global there. > > > > Bug: 868021 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > > Change-Id: I130c6b47feb90f0f7f0776ccc65666414a1ae802 > > Reviewed-on: https://chromium-review.googlesource.com/1180360 > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> > > Commit-Queue: Clark DuVall <cduvall@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#584849} > > TBR=eugenebut@chromium.org,rsesek@chromium.org,rmcelrath@chromium.org,jam@chromium.org > > Bug: 868021 > Change-Id: I5941b72474657159f0d4a1e6667fd77a3c475887 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Reviewed-on: https://chromium-review.googlesource.com/1185602 > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585387} TBR=eugenebut@chromium.org,rsesek@chromium.org,rmcelrath@chromium.org,jam@chromium.org Bug: 868021, 876861 Change-Id: I46fccf072d0b3080603e97c73ff055ac7c45e723 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1187081 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#585565}
-
Jordy Greenblatt authored
As MultiDevice is consolidating its release blockers, I want to clean out my todo list to make it as easy as possible to line up and burn down bugs. For context, multidevice_subpage.js: khorimoto multidevice_subpage is now taking care of building the 'forget device' dialog multidevice_setup_dialog.cc: I already added the strings Change-Id: Ic8aa834f247df5064240dbc6f2b910acd2cb10b3 Reviewed-on: https://chromium-review.googlesource.com/1186030Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#585564}
-
Lei Zhang authored
Change-Id: Ie1299b65bfb6a6b05e91cd2f8fed55f73f208734 Reviewed-on: https://chromium-review.googlesource.com/1186269Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585563}
-