- 01 Feb, 2019 40 commits
-
-
Oleg Davydov authored
Change-Id: Icf0e005780283a07dd76f52972811dce4ebfaed8 Reviewed-on: https://chromium-review.googlesource.com/c/1448184Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#628304}
-
Henrique Ferreiro authored
IdentityTestEnvironmentChromeBrowserStateAdaptor is the only user of the method. This CL is a precursor to a follow-up refactoring. Bug: 926907 Change-Id: If53c761f0f28db48e61a486ddaa1efb3e37d9293 Reviewed-on: https://chromium-review.googlesource.com/c/1448214 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#628303}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4569cd332d83..6808c22d9e24 Created with: gclient setdep -r src-internal@6808c22d9e24 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0b4481fd60db79f3ffad5540db2bf79a86892612 Reviewed-on: https://chromium-review.googlesource.com/c/1449518Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628302}
-
Henrik Grunell authored
* Fail with NotAllowedError, this consolidates with audio capture error. * Trigger system dialog explicitly when authorization is not determined. This is needed so that the system gives the correct information when checking the authorization state later. Otherwise it incorrectly keeps returning "not determined" until browser restart. Bug: 885184 Change-Id: I5c984e24877942f5924b172584d88974e5b9dd50 Reviewed-on: https://chromium-review.googlesource.com/c/1447732 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#628301}
-
David 'Digit' Turner authored
Add a missing entry to this .gitignore file to avoid 'git status' displaying that directory as untracked, which is super annoying. BUG=NONE R=digit@chromium.org TBR=thakis@chromium.org Change-Id: I1e221e6bb5e3fb76bd1c0fef9510f88c00414c46 Reviewed-on: https://chromium-review.googlesource.com/c/1449654Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Auto-Submit: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#628300}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4a2911fc50eb..f1d1061e51ca git log 4a2911fc50eb..f1d1061e51ca --date=short --no-merges --format='%ad %ae %s' 2019-02-01 oprypin@webrtc.org mb: Fix iOS config after the earlier CL Created with: gclient setdep -r src/third_party/webrtc@f1d1061e51ca The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic79e9fec0f42840f67fd8a1b1ab418ac73111e78 Reviewed-on: https://chromium-review.googlesource.com/c/1449517Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628299}
-
Mohamed Amir Yosef authored
This CL adds a browser test that the progress marker is properly persisted across restarts. Bug: 902349 Change-Id: I6a116a132ac066fa388bd4f08eb7fe93540c0e2b Reviewed-on: https://chromium-review.googlesource.com/c/1448330 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#628298}
-
Guido Urdaneta authored
Bug: 921006 Change-Id: I3e9680104b62a3f2647d6bf83f09d73c69b12fc9 Reviewed-on: https://chromium-review.googlesource.com/c/1449592Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#628297}
-
Pedro Amaral authored
This CL undoes some of the changes that could impact CCT that was introduced in the MenuButton refactor CL: https://chromium-review.googlesource.com/c/chromium/src/+/1419203 Bug: 925271 Change-Id: Ifb9575f8cf52934981c12b1a6c5114993997cc5e Reviewed-on: https://chromium-review.googlesource.com/c/1447834Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#628296}
-
Julie Jeongeun Kim authored
This CL implements CancelAllLoginRequests with exposing it through identity_test_utils.h. Bug: 926869 Change-Id: Iee7ef6fafbd60d4f04da2d8469b60c3d29b0f538 Reviewed-on: https://chromium-review.googlesource.com/c/1448077 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
-
Matt Falkenhagen authored
It's not used in production code. The unit tests still make use of it though so it can't be removed completely. Bug: 927651 Change-Id: Iad597caf1dc637c0a2c0fa5c4c37746eef7ba13b Reviewed-on: https://chromium-review.googlesource.com/c/1449477 Auto-Submit: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#628294}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/50870b52cc76..4569cd332d83 Created with: gclient setdep -r src-internal@4569cd332d83 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6f82876491f29aa21b4688d15457880779ae2de4 Reviewed-on: https://chromium-review.googlesource.com/c/1449515Reviewed-by:
-
Henrique Ferreiro authored
Remove uses of ProfileOAuth2TokenService and SigninManager by using the IdentityManager API. Bug: 911676 Change-Id: I097d023bb8d0a8f1cf62d0f9ab270100c8f2111e Reviewed-on: https://chromium-review.googlesource.com/c/1439078 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3d5023b90cd0..da7318dd0eeb git log 3d5023b90cd0..da7318dd0eeb --date=short --no-merges --format='%ad %ae %s' 2019-02-01 eseckler@chromium.org Output some debug info when getTraceCategories fails Created with: gclient setdep -r src/third_party/catapult@da7318dd0eeb The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:919187 TBR=sullivan@chromium.org Change-Id: I1612d0bf856d3cf0654ffddf6b8ec6570e419a07 Reviewed-on: https://chromium-review.googlesource.com/c/1449512Reviewed-by:
-
Hirokazu Honda authored
Originally, H264 HW Video encoder always generates IDR frame with an updated SPS when framerate or bitrate are changed. In webrtc usecase, webrtc request bitrate change if network estimation is changed. This can be several times per second. Several IDR frames in a narrow range may cause issues in both encoders and decoders. To resolve this issue, we don't generate IDR frame and don't send SPS frame either if only framerate or bitrate parameters are changed. This optimization is based on the following fact. Clause 7.4.1.1 in ITU-T Rec. H264 (04/2017) states, "Any sequence parameter set NAL unit containing the value of seq_parameter_set_id for the active sequence parameter set RBSP for a coded video sequence shall have the same content as that of the active sequence parameter set RBSP for the coded video sequence unless it follows the last access unit of the coded video sequence and precedes the first VCL NAL unit and the first SEI NAL unit containing a buffering period SEI message (when present) of another coded video sequence." From this, if SPS content is changed, we need to start a new video sequence. A new video sequence must be started with IDR frame. Therefore, it sounds we need to generate IDR frame with the updated SPS on framerate or bitrate change. However, framerate and bitrate parameter are in VUI parameters. It is an optional and thus will not affect decoder processing. We can regard the updated SPS content is unchanged when only framerate or bitrate parameters are changed. Hence, we don't pass the updated SPS and don't generate IDR frame. Bug: 833760 Test: VEA unittest on eve Test: No IDR frame in the middle in VEA unittest/MidStreamParamSwitchBitrate Test: Record H264 video and Plays/Seeks the video on eve Test: appr.tc/?debug=loopback&vsc=H264&vrc=H264 Change-Id: I066263e594f37c6f5047f9601591098d5ff8dfc7 Reviewed-on: https://chromium-review.googlesource.com/c/1449471 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#628290}
-
Natalie Chouinard authored
Implement the remainder of the UsageStatsDatabase functions on WebsiteEvents. Bug: 902572 Change-Id: Ic4420acd9c19adb383af556aa89c3621e89a4e39 Reviewed-on: https://chromium-review.googlesource.com/c/1437556 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#628289}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ae64f52786b3..72a0e3347cdf git log ae64f52786b3..72a0e3347cdf --date=short --no-merges --format='%ad %ae %s' 2019-02-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 258398020826..cf9383ed325c (3 commits) 2019-02-01 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@72a0e3347cdf The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I8e36872caad3b15124a512f84eb54db88d164328 Reviewed-on: https://chromium-review.googlesource.com/c/1449511Reviewed-by:
-
Lowell Manners authored
FakeGaiaCookieManagerService is being eliminated in favor of setting expectations using TestURLLoaderFactory. This is part of step 5 of the plan to eliminate FakeGCMS entirely: https://docs.google.com/document/d/1t0ZtuV7h-znzdItFgBW0aKPscAwWXIBuNZnNlEGgi7g/edit TBR=thakis@chromium.org Bug: 907782 Change-Id: I3106099e89ec7ae7d6120514e16ea68d891b0152 Reviewed-on: https://chromium-review.googlesource.com/c/1446355 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#628287}
-
Maksim Moskvitin authored
The READING_LIST type is registered only on iOS, while the APPS type is never registered on iOS. This means that storing READING_LIST in the APPS prefs group does nothing. Bug: 906611 Change-Id: I423b87f466605b39b7893cfe0549ee2fe01f42ba Reviewed-on: https://chromium-review.googlesource.com/c/1448168Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#628286}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ibc6b7c034df895e8dffb6c485967148f164ffe14 Reviewed-on: https://chromium-review.googlesource.com/c/1449030Reviewed-by:
-
Mario Sanchez Prada authored
Use IdentityManager and AccountsMutator instead to remove the dependency. Bug: 912150 Change-Id: Ia0b678feceeaf9d39898a5a82a2c997bfb63b9cf Reviewed-on: https://chromium-review.googlesource.com/c/1415410Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I95cc236ef92cf63a30b94d899bc8d04b661d41d8 Reviewed-on: https://chromium-review.googlesource.com/c/1449514Reviewed-by:
-
Clemens Hammacher authored
Error messages will change with this V8 change: https://crrev.com/c/1445897 Hence disable the tests for now until that change rolled into chromium. R=ulan@chromium.org Bug: chromium:926311 Change-Id: I7bf2ff4b1897f8736d3f471b3ebcead1c8062b44 Reviewed-on: https://chromium-review.googlesource.com/c/1448327 Auto-Submit: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#628282}
-
Abhijeet Kandalkar authored
As a step to make to use IdentityManager, this CL replace use of ATS with IdentityManager in user_session_manager.cc Bug: 922748 Change-Id: I1ce8988502ed32345d7f9c70478c5a48a1fd3a70 Reviewed-on: https://chromium-review.googlesource.com/c/1438977 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#628281}
-
Rakina Zata Amni authored
This CL makes FindBuffer able to filter out non-whole-word find results if needed. So on the text "foo foobar", there is only 1 match for "foo" and 0 match for "bar". Bug: 868227 Change-Id: Iaf31fb71c4b345a71061e6957ecd60f302de930e Reviewed-on: https://chromium-review.googlesource.com/c/1445354 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#628280}
-
Daniel Bratell authored
Compiling the safe_browsing code is currently about 1% of the total build effort in a jumbo build, and most of that effort can be eliminated by adding support for jumbo in the safe_browsing code. The gain would be a little bit bigger if the code hadn't been split into a lot of 1-2 file targets. Those are not made jumbo since the gain from merging just 2 files is limited, and merging just one file makes no sense. Bug: 927338 Change-Id: I0e8f57bdb1b39fc2f85a8adb4b00b3790d59d987 Reviewed-on: https://chromium-review.googlesource.com/c/1448455Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#628279}
-
Fredrik Söderquist authored
Folds the "border-image version" of GraphicsContext::DrawTiledImage into NinePieceImagePainter. This should hopefully allow for better control of tiling computations, and also seems like a better place from a layering perspective. The computation of <scale, phase, spacing> is refactored into a new function ComputeTileParameters. Switch from using Image::TileRule to using ENinePieceImageRule (the style type), and remove the former since it is no longer used. Bug: 614125 Change-Id: Ia7433f871bb0bc6f7f963a14ae49b898559860d2 Reviewed-on: https://chromium-review.googlesource.com/c/1448612 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#628278}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2012b3540bcf..50870b52cc76 Created with: gclient setdep -r src-internal@50870b52cc76 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie56161073fce119749fb4a8d9f8ca15da7d117a1 Reviewed-on: https://chromium-review.googlesource.com/c/1449029Reviewed-by:
-
Hirokazu Honda authored
GbmWrapper creates one file descriptor for each plane (crrev.com/c/1437036). Therefore, GbmBuffer::GetFdCount() is unnecessary as GbmBuffer::GetNumPlanes() can be used alternatively. Furthermore, NativePixmap::GetDmaBufFdCount() is only for NativePixmap whose backend is GbmBuffer (i.e. GbmPixmap). NativePixmap::GetDmaBuFdCount() is no longer nececessary either. Bug: 911370 Test: VDA unittest and VEA unittest on eve, hana and kevin Test: Play video on eve w/o HW aceleration on eve, hana and kevin Test: gfx_unittests Change-Id: I1010d427833377f19dc7e98ce59809a5cf5206ff Reviewed-on: https://chromium-review.googlesource.com/c/1445352 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#628276}
-
Matt Falkenhagen authored
Part of an effort to simplify service_worker_context_client.cc. Bug: 927149 Change-Id: Icf60ce930465cd222c33c55e9ff02b267113fc2d Reviewed-on: https://chromium-review.googlesource.com/c/1449474 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#628275}
-
Keishi Hattori authored
This reverts commit 4047b618. Reason for revert: CFI errors crbug.com/927659 Original change's description: > Add StreamStartAlgorithm type > > StartAlgorithms are different from other promise-returning algorithms in > the streams standard in that they can throw an exception. Add a new > StreamStartAlgorithm base class to represent them, and a > CreateStartAlgorithm() function to create ones from JavaScript. > > Design doc: > https://docs.google.com/document/d/1n0IIRmJb0R-DFc2IhhJfS2-LUwl6iKSBNaR0klr3o40/edit > > BUG=902633 > > Change-Id: I0995aa21bbec51ab206a4affc54d861b2c325db4 > Reviewed-on: https://chromium-review.googlesource.com/c/1445342 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Adam Rice <ricea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#627877} TBR=ricea@chromium.org,yhirano@chromium.org Change-Id: I1a9882e1d33236c95ac953a1a1021b9431c4ddca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902633 Reviewed-on: https://chromium-review.googlesource.com/c/1449478Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#628274}
-
David Jean authored
Add an url_loading_service (and factory) that will handle all url loading and will pass on UI actions to a delegate (here implemented in BrowserCoordinator, which in turn passes it on to BVC) This will make chipping at URLLoader much easier. The delegate api will change drastically in upcoming CL, as for now, it just reflects the current url load data structure and existing methods. Bug: 907527 Change-Id: I6c72ad307d9e80249cac909149129dc593f9cbd1 Reviewed-on: https://chromium-review.googlesource.com/c/1442715 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#628273}
-
Antonio Gomes authored
... into the components/signin/core/browser:browser target. Additionally, the CL also removes needless includes to signin_internals_util.h from signin_manager* and identity_manager.h BUG=927308 Change-Id: I39d34969a565f6d357903cfe88cde634c4600380 Reviewed-on: https://chromium-review.googlesource.com/c/1448493Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/925f6ab9b18a..ae64f52786b3 git log 925f6ab9b18a..ae64f52786b3 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 5d360ebe..10b73e92 (473 commits) 2019-02-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader ebe5f7fad064..debaacab10b5 (1 commits) Created with: gclient setdep -r src/third_party/skia@ae64f52786b3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I3889531c183c7d7a44ee9f4e639431636bf17842 Reviewed-on: https://chromium-review.googlesource.com/c/1449027Reviewed-by:
-
Keishi Hattori authored
This reverts commit 7cf254c3. Reason for revert: Suspected cause of test failure crbug.com/927647 Original change's description: > Do not call 'navigation committed' callback if there was no pending item to commit. > > GetPendingItem can return null inside webView:didCommitNavigation: > This is due to crbug.com/925304, which allows to discard pending items > by another navigations prematurely. > > If pending item is null, it means that Navigation Manager will not commit > that item and WebStateObservers can crash because they expect to have at > least one committed item. > > This CL leaves navigation as "uncommitted" if there was no pending item > inside webView:didCommitNavigation: > > Bug: 925304 > Change-Id: If9bedd0f74a428946a9026d142da7fc360fd7138 > Reviewed-on: https://chromium-review.googlesource.com/c/1448683 > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Auto-Submit: Eugene But <eugenebut@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628224} TBR=justincohen@chromium.org,eugenebut@chromium.org Change-Id: I44d5b313616a6deb05a9ad254314181df11a059e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 925304 Reviewed-on: https://chromium-review.googlesource.com/c/1449438Reviewed-by:
-
Mario Sanchez Prada authored
This dependency is not really used and can be simply removed. Bug: 927259 Change-Id: I5ed3062476071f8c94f8952a90c5c1832b0ea8cf Reviewed-on: https://chromium-review.googlesource.com/c/1448211Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#628269}
-
Sylvain Defresne authored
The plan is to have client code keep instance of CoreAccountInfo instead of keeping only one of the three components (account_id, gaia or email) and then querying the IdentityManager for the other. As is_under_advanced_protection is not a valid key for an account, it does not fit in CoreAccountInfo, so move it back to AccountInfo. The few locations that need it during the initialization will have to fetch the extended account information from IdentityManager. Bug: 926204 Change-Id: I4a36e2464098ef18760507acc5d5cf3ce51c2fc6 Reviewed-on: https://chromium-review.googlesource.com/c/1448321 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
This are no longer used and can be safely removed. Bug: 927328 Change-Id: I2716aa665cc0d4179bd3ff8b78393b72ded634a6 Reviewed-on: https://chromium-review.googlesource.com/c/1448414Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#628267}
-
Adam Rice authored
In some cases |headers_text| in WebSocketHandshakeResponse would not match |headers|. Ensure that they always match. BUG=924972 Change-Id: I4ad2f45dd4aed4f6dc0cceb656f736e663046827 Reviewed-on: https://chromium-review.googlesource.com/c/1442350Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#628266}
-
Maksim Sisov authored
If a previous browsing session is empty, WindowSizer calculates default window bounds by calling GetDisplayMatching with empty bounds. Previously, WaylandScreen returned an invalid display, which resulted in extremely small windows. Now, instead of returning an invalid display, the nearest display to the match rect is returned. Also, if the match rect does not intersect with any of the displays, a primary display is returned. We are doing the same as ScreenBase::GetDisplayMatching now. Bug: 927274, 875161 Change-Id: I567cba549fb90b9d5db58b3af3bed04598848cdb Reviewed-on: https://chromium-review.googlesource.com/c/1448172Reviewed-by:
-
