- 03 Sep, 2020 40 commits
-
-
My Nguyen authored
Added based on Finch's action in http://cl/329846664 Bug: b/166523259 Change-Id: I8f3bcba929cf5783b453722e572ddac9e132f26a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391037 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#804445}
-
Brandon Wylie authored
Replacing a workaround with a less hacky solution. Bug: 1122212,1012436,1121577 Change-Id: I7d3cb641a695d4c8f4a70b982316f38957941cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386344Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#804444}
-
Xing Liu authored
Currently if the user doesn't dismiss the infobar for scheduled download, and scheduled another download in another tab, the new infobar will show in the previous tab. Also, if the user switches to another tab and come back the tab that has shown the infobar, clicking on the "Change" button will show an error page. This CL fixed these 2 issues. If there is more than one scheduled downloads across multiple tabs during the lifetime of the infobar, "X downloads scheduled" should be shown as the infobar text. Bug: 1123924 Change-Id: Ib952c84ba5d6ad358c2d0b3d55238dc85e9ea313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391585Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#804443}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/75690ce7ef4a..2c5b4455854d 2020-09-03 caramelli.devel@gmail.com Minor change in detachImage() for Xcb, Xlib, Wayland WSIs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic809eae44afe3d92f1370571a755fef5a7d1d0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393044Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804442}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/00b2fdbc3c6f..6763a713f957 2020-09-03 brianosman@google.com Limit morphology radius to 100 pixels 2020-09-03 robertphillips@google.com Create cpu-side blurred RRect mask when recording DDLs (take 2) 2020-09-03 bsalomon@google.com Reland "Add idea of DataType to SkYUVAPixmapInfo." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408,chromium:1123035 Tbr: michaelludwig@google.com Change-Id: I9c3602bd3625c06f45f1d1187daa78c7b11129c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804441}
-
Scott Violet authored
As of https://chromium-review.googlesource.com/c/chromium/src/+/2386320 no longer calls onDialogVisibilityChanged() if there were no dialogs. This means the conditional checking for mTab can now be removed. BUG=1121388 TEST=covered by test Change-Id: I1e82d17360f3623200ecf67686a65288b4305020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392744Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#804440}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5383c636752f..f39c62ab1284 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If4b0183a057b4a95feb03cd062af33facbf829ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392626Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804439}
-
Josip Sokcevic authored
code.google.com redirects no longer work. This CL replaces links in /extensions/common/api/networking_private.idl to source.chromium.org equivalent. This CL was uploaded by git cl split. R=karandeepb@chromium.org Change-Id: I9aef715b8de938baeab22c92480cffb3984490fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392749 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#804438}
-
Bruce Dawson authored
This ports the abseil .def file generation to Windows, using dumpbin to get the lists of symbols. It also fixes some glitches such as the Chromium-repo detection, and file-endings on export. It works around one dumpbin bug that will be fixed in some future VS release. The results are not identical to those on Linux but this is a solid step in that direction. Bug: 1046390 Change-Id: I37e7055b9b774e4d923e5572dd00268b0d563c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264493Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#804437}
-
Lei Zhang authored
It is apparently reachable, since ConvertEventTypes() in content/renderer/pepper/event_conversion.cc can create input events of type `PP_INPUTEVENT_TYPE_UNDEFINED` for a variety of reasons, and PPAPI does not always send `PP_INPUTEVENT_TYPE_CONTEXTMENU` events through correctly. Bug: 1124478 Change-Id: Id376f948a78ca9d33ee40e825d7f131a11f61ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392376Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#804436}
-
Devlin Cronin authored
This file was leftover from a time when there were separate implementations for Mac-Views vs other-platforms-views, which is no longer the case. Move the methods from this file into the main .cc file. Note: Technically, we could also move the header and implementation from c/b/ui/extensions/extension_message_bubble_browsertest.* and collapse everything into c/b/ui/views/extension_message_bubble_view_browsertest; this separation pre-dates Mac-Views, and was designed to share code between c/b/ui/views and c/b/ui/cocoa implementations. However, that's a lot more code churn. Start here. Bug: None Change-Id: I98eca6c92ccfa03a50090558c30ecc84e2652828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392697Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804435}
-
Matt Wolenetz authored
Adds a supplemental interface in modules to extend the core MediaSourceAttachment, so common methods in specialized attachments can be defined without requiring them known by core. This reduces complexity of the core side of the attachment interface. Specifically, adds MediaSourceAttachmentSupplement, with a new method (implemented in concrete SameThreadMediaSourceAttachment) to notify the attached element that the duration of the resource has changed. Later specialization in a cross-thread version of the attachment will need to perform this notification asynchronously. Lifts the Unregister() method and the persistent MediaSource OilPan reference member from the concrete implementation into this common modules attachment supplement's implementation, since these are expected to remain the same across all concrete attachment implementations. Updates SameThreadMediaSourceAttachment to give the MediaSource a thread-safe refcounted scoped_refptr for the attachment during StartAttachingToMediaElement(). MediaSource, like HTMLMediaElement does already, is updated to know both the attachment and the MediaSourceTracer while the attachment is active. Starts using NotifyDurationChanged from the MediaSource object via the attachment instead of directly talking to the attached media element from the MediaSource. Further extensions of this attachment interface will come in later changes for similar scenarios, eventually enabling the dropping of the |attached_element_| member from the MediaSource class, with all interactions on the element eventually done via the attachment. BUG=878133 Change-Id: I86206f740b62f9ba6dc6a1b9fd16a44aff21f49a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387121Reviewed-by:
Will Cassella <cassew@google.com> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#804434}
-
Devlin Cronin authored
Currently, there there exist chrome.test.runNextTest() and chrome.test.assertBool(). However, these are implementation details of the chrome.test API, and should not be used directly. Instead of exposing them on the API (which is unnecessary), just have them be normal functions in the custom bindings. Bug: None Change-Id: Ia5fc47fe5b357ac9507aed52c76b132ea582a0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391925Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804433}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c94650d88fd7..d46db9f1523a 2020-09-03 landrey@webrtc.org Remove unused pc level test MediaHelper constructor 2020-09-03 titovartem@webrtc.org pki.google.com has been deprecated in favor of pki.goog 2020-09-03 landrey@webrtc.org Support simulated time in MediaHelper for pc tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If71f229af736adb817752973d6aa04f3126d5f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393035 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804432}
-
Owen Min authored
Those prefs values are set by policies only. |kCloudReportingEnabled| was moved to local_state a while ago while the other policies are never launched. Bug: 1107440 Change-Id: Ie0c9ff83ac4ef5e9f950a4d446c16f687fbffac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360570Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804431}
-
Robert Ogden authored
Adds a configurable delay as well, but by default is zero so that the spare renderer request happens in the next message loop. Bug: 1115259 Change-Id: I787cd9cf60c517ea9ac83d28d0484928355007e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392766Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#804430}
-
Nate Fischer authored
No change to logic, only docs. This upstreams the web page layout guide, mostly autogenerated from the google sites page (tables were converted by hand). I made some minor edits to the text for readability, but the content is mostly unchanged. This omits the "experimental data" section on the original doc because (1) this isn't very relevant anymore since the behavior has shipped and we don't intend to reevaluate and (2) the data was internal-only. Fixed: 1083508 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ic1ece33a5565986235af1dbb735d35966253fe5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393006Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#804429}
-
Avi Drissman authored
CFNumberCreate creates with a reference, so existing code leaks. Switch to non-leaking code. Bug: none Change-Id: I14c112cfba220911754110009cf6a080d067743c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392696 Commit-Queue: Miguel Casas <mcasas@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#804428}
-
Thomas Lukaszewicz authored
This CL updates the non client frame view to invalidate its layout in fullscreen only if the frame is meant to be shown. This eliminates unexpected behavior incurred when laying out the frame view when it should not be shown. Bug: 1119652 Change-Id: I702f4c4ab913e654b03b4327e60d26ef60831446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393002Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#804427}
-
Mariam Ali authored
This CL updates close button strings in both incognito and guest menu to align with the new menu design, as well as removing Other People section in guest mode. Design Deck: go/alignmenus Screenshots: https://screenshot.googleplex.com/6Vu7adRHK62CgxG.png Bug: 1105763 Change-Id: Ib81fdcfe5816c08978c28b86ce22656b5e5f5d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391069 Commit-Queue: Mariam Ali <alimariam@google.com> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#804426}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fb45a94639ca..5383c636752f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I97e0b09ab0e7f0d0a4335eeb3e70c3d81b323e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804425}
-
Lijin Shen authored
Introduce a Dep as a manager of external states for easy testing. Bug: 1109255 Change-Id: I74cf6cac126a6f8ed4c6f9144131443e1ba57722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385982Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#804424}
-
Gavin Williams authored
Printer status icons will be showed on Print Preview Destination Dialog on CrOS so need to move some of the common functionality out of destination_select_cros to reduce duplication. Moving the |printerStatusMap| to destination_settings allows the dropdown and dialog to share the same printer status cache. Bug: 1123754 Change-Id: I367c875bd673ac9bab5297cc52de1f0f24fbe71e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387138 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#804423}
-
Maggie Chen authored
aggregated_frame.cc/h are used only in the viz/service/display folder except for a test. In order to support overlays in the aggregated frame. Move these two files to viz/service/display where the overlay files are located. Bug: 1117235 Change-Id: I28782b6d431a47fcdc83198bb27123017bb78718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392998Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#804422}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/436d8ac8c54e..d86bb475521a 2020-09-03 Rob.Paveza@microsoft.com We received feedback that "Learn more" was insufficiently descriptive If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id2a95146404ea234434fab72fa82335def52c25a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393039Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804421}
-
Joe DeBlasio authored
See go/mix-dl-blog-post. Bug: 960819 Change-Id: I36754c5c88b40a707e419af4daa360a06c16540c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392753 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#804420}
-
Brandon Wylie authored
ChromeActivity is used in AutocompleteMediator to provide the current TabModelSelector. This dependency should instead be acquired through direct constructor injection. Bug: 1123209,1097292,1113364 Change-Id: I95c8a58f06f250b6397ec7926b2262b5b2b4298b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382958Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#804419}
-
Alexander Cooper authored
Running the OpenXR mock failed with the sandbox disabled because the number of requested extensions did not match the number of supported extensions. This isn't a strict requirement of the runtime, and really, we should only care that all enabled extensions are actually supported, which is validated by the next check. Change-Id: I96b3961c886ff16642c3c3f2005e28e5a60b7b30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391216 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#804418}
-
dpapad authored
Fixed: 1107917 Change-Id: Ia07198fc4301bf8903586ea16a9f25f5257a1a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392978 Commit-Queue: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#804417}
-
Andrew Grieve authored
Change-Id: I532b9e054a047bffa34fddaee6e69c2b0795b204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391215 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#804416}
-
Clark DuVall authored
We can just use org.chromium.base.onResourcesLoaded to get the same behavior. Bug: 1105096 Change-Id: I7303f1ba1e6ea741f0b42bb0aa56a4afb0ee663a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393005 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#804415}
-
Robbie McElrath authored
@CallSuper was added to FragmentActivity.onRequestPermissionsResult in r.android.com/1233518, which is present in the AndroidX fragment library v1.2. This change will prevent a compilation error when upgrading to that version of the library. Bug: 1123216 Change-Id: Icef9c868cc5cf2de38b6c40cacdc91f48e1edfbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386277 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804414}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I9bd3478a68b1dfe7794bd96390e6dc45ad5fe7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390805Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#804413}
-
Mustafa Emre Acer authored
This CL adds a lookalike navigation browser test for signed exchanges. The current lookalikes code blocks signed exchanges in both of the following cases: - The target URL of the SGX package is a lookalike - The URL that serves the SGX is a lookalike For the first case, the test navigates to a signed exchange URL that serves a SGX for google-com.example.org and checks that the URL is blocked by the target embedding heuristic. The second case serves the SGX from google-com.example.org and checks that it's blocked. There is an argument to be made for the latter case to not be blocked since the URL that serves the SGX is never seen by the user during normal browsing such as clicking links. However, there is still a chance that such a URL is shared from outside Chrome (e.g. coming in an email). We still want to block those cases. Additionally, detecting that a navigation will end up as a SGX isn't trivial as the SGX package needs to be fully validated before its contents can be displayed. It might be too late to block the original navigation by the time the SGX is validated. This needs to be confirmed and might be changed in follow up CLs. Bug: 1110151 Change-Id: I2b2e4841eb142b3f2d1c1cedf82138f578e770a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386429 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#804412}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6d46b6f1..53c397b6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I52af013cac907fd8b32d8721eaea4ea58e7efaeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392579Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804411}
-
Henrique Nakashima authored
This makes it easier to audit dependencies. Change-Id: I1ea9db294f947f261b050dc61399ff93ef89dc69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391655 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#804410}
-
Vicky Min authored
Since the Bluetooth serial interface is designed to work on Mac OS only as of now, change the Bluetooth SPP flag so it can only be enabled on Mac OS. Bug: 1043300 Change-Id: I35531d8388eefe1228ee970d1e6f8e56ac8a1a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391922Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Vicky Min <vickymin@google.com> Cr-Commit-Position: refs/heads/master@{#804409}
-
Patrick Noland authored
Most method calls are translated 1:1 by forwarding the call to the equivalent MenuButton or View method. A notable exception is handling of the tab switcher animation, which currently requires a view in order to perform canvas translation before drawing the button in its animated state. In this case, we provide a direct accessor for the view. Reland note: the NPE was due to the MenuButtonCoordinator not being set until right after inflation finishes, which is when ToolbarTablet was trying to use it. Bug: 1086676 Change-Id: I60819a54bc4ad6d84fcb5b932d04798ba6561bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391643Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#804408}
-
Alexander Surkov authored
Bug: 1124366 Change-Id: I79ba5caecabbdd825283d21f37b029bdc55d734f AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390898 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#804407}
-
Liquan (Max) Gu authored
This reverts commit 72c29544. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2388561 Reason for revert: This was landed after we reverted its dependent CL, causing assert failure: https://luci-logdog.appspot.com/logs/chromium/android/swarming/logcats/4e6e16a4bd138411/+/logcat_logcat_6189963507448870930_20200903T185337-UTC_0cbc662c032fd958 Bug: 1107039 No-Try: true Change-Id: I8485665142c4ea446406cd9261756b1dd51f49de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393061Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#804406}
-