- 12 Nov, 2019 40 commits
-
-
Noel Gordon authored
Add files20 (20px files-ng) <iron-icon> set. Add external-link icon, and eject icon, as initial members. Bug: 992819 Change-Id: I12f9e228f404bc68cfa8d998feae249a6bfe40cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906459Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#714372}
-
Lambros Lambrou authored
This allows an optional callback to be notified whenever the user completes or cancels the wizard. Bug: 1015201 Change-Id: I93cfa973518b40a840dc20068de5e44636b3806a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907769 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#714371}
-
Lan Wei authored
In Webdriver spec, it has an example: https://www.w3.org/TR/webdriver/#example-11 that the source has a pause action, which means that the source does not have any action at this tick. Currently we only have a pause action for none source type, we should have the pause action for the key and pointer types as well as per web driver spec: https://www.w3.org/TR/webdriver/#dfn-pause For example: let actions = new test_driver.Actions() .addPointer("touchPointer1", "touch") .addPointer("touchPointer2", "touch") .pointerMove(10, 0, {origin: test1, sourceName: "touchPointer2"}) .pointerMove(0, 0, {origin: test1, sourceName: "touchPointer1"}) .pointerDown({sourceName: "touchPointer1"}) .pointerDown({sourceName: "touchPointer2"}) .pause(0, "pointer", {sourceName: "touchPointer1"}) .pointerMove(0, 10, {origin: test1, sourceName: "touchPointer2"}) .pointerUp({sourceName: "touchPointer1"}) .pointerUp({sourceName: "touchPointer2"}); Bug: 1020674 Change-Id: Iacd2811a91bc26d273cd9589a96e0a377941d79c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900650Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#714370}
-
Xiaohan Wang authored
Currently we have PipelineImplTest.NoMessageDuringTearDownFromError test which is supposed to test the case where after OnError(), new calls to PipelineImpl won't post tasks to the media thread. However, in the implementation an error during pending seek won't call OnError(), so the action that does this check isn't triggered at all. This has been indicated by test coverage bot and pointed out by liberato@ during code review (Thanks!). The fact that we use On_CALL instead of EXPECT_CALL hides this problem. After fixing the test by actually triggering this check after Stop() caused by the seek error, the test is still failing, because we actually didn't prevent posting tasks to the media thread in SetPlaybackRate() and SeVolume(), which is the expected behavior after discussion. We could try to call Seek() again and check that it doesn't post a task, but that's partially covered by the existing SeekAfterError test. Also, we probably shouldn't test whether a task is posted or not, which is purely implementation detail. With that, this CL removes the NoMessageDuringTearDownFromError test. It also updates other related tests to make sure SetPlaybackRate() and SetVolume() are allowed to be called before Start(). Bug: 1018372 Test: Fix and remove existing tests. Change-Id: I6e42cc8f7e3a187c31713423adb9b5a2501214a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906755Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#714369}
-
rbpotter authored
Change the bookmarks Web UI to use a browser proxy for communication with C++. Also update tests to use a test version of the proxy instead of registering test message handlers in C++. Bug: 1022213 Change-Id: I7a824d51e1fdaa02e57baa44c555c634f8e230b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906959 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#714368}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I6136929a4d056884650ded2e715d2109314ca97c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903621 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#714367}
-
Aleks Totic authored
Legacy table algorithm looks at the surrounding table. It assumed surrounding table was legacy too, which does not hold in TablesNG. It is only called by Legacy code, and will not be used once TablesNG is done. Because of this, instead of implementing IsLogicalWidthAuto on TableInterface, I just inlined it at call site. LayoutTable: :IsLogicalWidthAuto method belonged to LayoutTable. Change-Id: Ie4e174aeb01e8b6c51587dc8b77819fee4eb981c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906124 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#714366}
-
meacer authored
A previous CL disallowed these characters when surrounded by non-CJK characters on both sides (crrev.com/1659678). This CL prevents more spoofs by not allowing these characters to mix with non-CJK. Change-Id: I126bf57d797593013b2bf421032c5642e42f2c2f Bug: 990428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910762Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714365}
-
Keishi Hattori authored
This reverts commit 76367552. Reason for revert: Suspecting HeapGraphWalkerTest.AllGraphs failure crbug.com/1023685 Original change's description: > Roll src/third_party/perfetto 7980e5ea3e34..51516f076308 (4 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/7980e5ea3e34..51516f076308 > > git log 7980e5ea3e34..51516f076308 --date=short --no-merges --format='%ad %ae %s' > 2019-11-11 fmayer@google.com Merge "Do not count roots as unique_retained." > 2019-11-11 rsavitski@google.com Merge "compact_sched: remove "unstable" notices" > 2019-11-11 rsavitski@google.com Merge "compact sched_waking: event decoding in trace_processor" > 2019-11-11 rsavitski@google.com Merge "compact sched_waking: writer (traced_probes)" > > Created with: > gclient setdep -r src/third_party/perfetto@51516f076308 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > TBR=perfetto-bugs@google.com > > Bug: None > Change-Id: I85e20b4475481af1fd2c2c1eaca3b224e6cbba8e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910168 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#714258} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: Idd397943cbe6966334287367966081845b1ba2b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910980Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#714364}
-
George Burgess IV authored
This CL hooks up Tricium to our clang-tidy Tricium bot. This is intended to be a nop for ~everything, since our current clang-tidy recipe does nothing if `author != gbiv || !is_special_commit_message()`. Bug: 633856 Change-Id: I0f3e782c50e5284cbfc2b02bb226e58153c192d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896035Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#714363}
-
Kent Tamura authored
wpt-importer doesn't work well now. TBR=rakina@chromium.org Bug: 985637 Change-Id: I4aeedb0fcb5c144e8dc4fb1b8856af1fe9a7d942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910979 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#714362}
-
Koji Ishii authored
Following bot results are included. 234 235 236 237 238 243 248 249 251 8 lines were removed and 3 lines were deflaked by consecutive results since 225. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Id5c91e469f2e4491ac83ac22ea569ab7cb536cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909047Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#714361}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f18ff947360d..e33c1582b4bc git log f18ff947360d..e33c1582b4bc --date=short --no-merges --format='%ad %ae %s' 2019-11-11 shrekshao@google.com Fix EXT_texture_norm16 2019-11-11 jmadill@chromium.org Windows: Use Job handle in LaunchProcess. Created with: gclient setdep -r src/third_party/angle@e33c1582b4bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: chromium:1000354 Change-Id: Ic112129a3b66a3bd14f1b70e5cd318f1aed1a085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909811Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714360}
-
Andrew Luo authored
Bug: 1021665 Change-Id: I6de2e17733078cb0f433ecc20b42f11c0e2cb521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902768Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#714359}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3c086a0c2e1d..cfc9c6e322f4 git log 3c086a0c2e1d..cfc9c6e322f4 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 enga@chromium.org Make perf test tracing thread-safe 2019-11-11 yunchao.he@intel.com Implement readonly storage buffer - validation at shader side 2019-11-11 yunchao.he@intel.com Tiny fixes for BindGroup/BindGroupLayout tests 2019-11-11 rharrison@chromium.org Another spvc API migration Created with: gclient setdep -r src/third_party/dawn@cfc9c6e322f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I819bf88462f4408c6246beb3540f150a54f6361b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909817Reviewed-by:
-
Martin Barbella authored
Bounds was previously disabled due to an UBSan bug that caused problems in yasm, but this no longer reproduces. Change-Id: I3e06cea5ce51ff44ecc2171c05ceea29a40ec83b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906905 Commit-Queue: Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#714357}
-
Matt Menke authored
Make MojoHostResolverImpl take a NetworkIsolationKey and pass it on to the HostResolver. This doesn't yet have any effect in production, as MojoHostResolverImpls are always passed empty NetworkIsolationKeys. Bug: 1021661 Change-Id: If25447e1bb86a1a478badeb89018cc475250c313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904346Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#714356}
-
Donn Denman authored
Touch highlight had some bugs in the new layout when not drawing full width and in RTL. This CL reworks the highlight calculations to fix the problems and make the code easier to understand. BUG=1016976 Change-Id: I911991b991a16296edce7b5d0c5061034497a304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906341Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#714355}
-
Klaus Weidner authored
xr_frame_provider had some almost-but-not-quite-identical logic for XR input processing that was copied for immersive and inline sessions. Move this logic to xr_session to reduce duplication. Change-Id: I04955a4c579e096476b3c898f5b0069495afb9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907416 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#714354}
-
Theodore Dubois authored
This allows for making atomic updates that both add and remove dynamic rules. BUG=1023501 Change-Id: I69504492463b57efe5e2118ec48626d90eeff42f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898393Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Theodore Dubois <tbodt@google.com> Cr-Commit-Position: refs/heads/master@{#714353}
-
W. James MacLean authored
This CL re-implements the named test so it doesn't require BrowserPlugin. Bug: 1019363 Change-Id: I69d6b6b036ce01bd2256e4aff24ee676da4af959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902524Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#714352}
-
Evan Stade authored
logging_utils.h includes console_message.mojom-forward.h, so the cc should include console_message.mojom.h This prevents errors like https://pastebin.com/raw/JguWQAEZ Bug: 1001360 Change-Id: Iee37dc1c8957fdb289c79023c266c4f3f0d9f8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909643Reviewed-by:
-
Ryan Hansberry authored
The CL crrev.com/c/1788552 introduced logic which immediateyl cleared Smart Lock devices from user prefs when the feature became disabled. Unfortunately, that change did not anticipate the face that Smart Lock goes through an intermediate step during Chrome startup in which the feature is marked as disabled, inadvertently removing the devices even when the feature is enabled. This CL reverts that faulty logic. Bug: 1022651 Change-Id: I39068f5bc92f39f4109aa34dda3f2c0f35adcfcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906324 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#714350}
-
byoungkwon ko authored
We have both deleting url function in HistoryService. And DeleteURL can be replaced as DeleteURLs. So we will remove DeleteURL, and use DeleteURLs. Bug: 1008292 Change-Id: I28463eb9c347145331bfda802abca10b54c01d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892977Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#714349}
-
Natalie Chouinard authored
Move ContentSettings-related methods from PrefServiceBridge to WebsitePreferenceBridge. This is part of a larger change to limit PrefServiceBridge to only feature-agnostic logic related to the native PrefService. Bug: 1016957 Change-Id: Id0f8dbca0444a3deaeb66ef64229066032b0d29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902258 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#714348}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5a2bf4dc..52f8e51c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifbf4f72e57566ae81106ac28b54827dc7730d8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908921Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714347}
-
rbpotter authored
Update Print Preview to use Polymer 3. This removes its usage of HTML imports. Also update pdf_scripting_api.js to be a module, since Print Preview can now import it. Reduces the size of Print Preview's resources in optimized builds by around 34k (7.7%): Before (P2): crisper.js 311k, vulcanized.html 132k = 443k total After (P3): print_preview.js 407k, vulcanized.html < 2k = 409k total Fixed: 1012574 Change-Id: Ic0cd4706ae9b1e395032d2b3758f4d9976ec52a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900688 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d3b6135c44d..2d0a87cb7e91 Created with: gclient setdep -r src-internal@2d0a87cb7e91 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1018879 Change-Id: If67d6fe3117f7fe9a45de73101313dabcdb1d41b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910310Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714345}
-
dalyk authored
This error code will be used when a DoH server hostname cannot be resolved due to a DNS issue. Bug: 1016325 Change-Id: Icfe5ecd2d80c3182a540340adb7858b8a0c6f88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906904Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#714344}
-
Julian Watson authored
Bug: 1017511 Change-Id: I5a7773cf33fbd69c0d400dbbf2fdf99cd4dfed48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904559 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#714343}
-
Simon Que authored
Previously reverted as possible culprit in long build times on Oct 29-30, but turned out not to be. Revert CL: crrev.com/c/1890997 No new changes in reland CL except for rebasing. ========================================== CI builders: - Android ASAN (dbg) - Android arm Builder (dbg) - Android arm64 Builder (dbg) Try builders: - android_clang_dbg_recipe - android_compile_dbg - android_n5x_swarming_dbg - android_arm64_dbg_recipe - android-oreo-arm64-dbg - android-pie-arm64-dbg Schedule of migration: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413 Change-Id: Ib1ddb51218ab9cacb4a83ee98560ba8a3b23b4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909948Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#714342}
-
Yoshifumi Inoue authored
This patch makes |LayoutInline::ReferenceBoxForClipPath()| to utilize |NGInlineCursor| for prepration of migrating to |NGFragmentItem|. Bug: 982194 Change-Id: Idb4ed39dc2185033b3a0607398649e099f543506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909066 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3c4707d608f2..503d196f2b70 git log 3c4707d608f2..503d196f2b70 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 chrisforbes@google.com Allow depth/stencil attachment to be VK_ATTACHMENT_UNUSED in clear Created with: gclient setdep -r src/third_party/swiftshader@503d196f2b70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/144280552 Change-Id: I059654d87b94210995569952d3114fc658e7fceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910501Reviewed-by:
-
Varun Khaneja authored
The current implementation of checking high confidence allowlist returns NO_MATCH if any of the following apply: 1. The DB isn't enabled yet. 2. If the URL scheme can't be checked. 3. If the list hasn't been loaded from the disk yet. Since Chrome now falls back to hash based checks in the case of an allowlist match, it's safe to return MATCH if any of the above conditions happen. Bug: 963165 Change-Id: I3b311ed6124865c5e3236bd83dec62a640b6d881 Fixed: 1022628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906645 Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#714339}
-
Asanka Herath authored
R=mmenke@chromium.org Bug: 927182 Change-Id: I610973df09e2fe1e370a4ca2b2c3ecc90af790c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907150 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#714338}
-
Xianzhu Wang authored
This is the first step to make scroll independent of cc::Layer. TBR for trivial change under ui/compositor R=bokan@chromium.org TBR=flakr@chromium.org Bug: 1015625 Change-Id: I38234b39f525e54076b0a209b56fcffd0478b359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904875 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714337}
-
Ben Kelly authored
This is important since we do not want to expose the existence of the x-CacheStorageCodeCacheHint header for an opaque response by accident. Bug: 1007272 Change-Id: Ide6f863e732a7b145a244e5ad0f5670bf740a7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906808 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#714336}
-
Maggie Cai authored
This CL fixes the issue where the new function in intent_helper.mojom didn't increase MinVersion number. BUG=853604 Change-Id: I4f40724a1c0e4d66d4333d90e9c3dd2d926837ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909050Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#714335}
-
Xianzhu Wang authored
We should always accumulate the update rect and never set it directly. This change can prevent errors, and avoid duplicated union code and the comments above them explaining the reason of union. Change-Id: I53fbfe9d8b67bdab841b66a8123ad4b6b4cf6f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910520 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714334}
-
Eric Orth authored
Makes it so requesting cancellation and shutdown behavior can be consistent with all other HostResolver requests, including cancellation of requests on ContextHostResolver destruction. For now, just interacts with the previously created DnsClient (but now private) ::SetRequestContextForProbes() and ::CancelProbesForContext(). In a subsequent CL, will move all the logic for actually starting probes outside DnsClient so that this Request object will actually start and cancel the probes more directly. Bug: 1013350 Change-Id: I60554a0a3406383e90563b1d08f2a830f595b398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838300 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
-
