- 27 Jun, 2019 34 commits
-
-
Kristi Park authored
The @private annotations don't really serve a purpose. Also, clean up some const ordering, missing JSDoc, and spelling errors. Change-Id: Ib074aef2a51d226b84d1a00da6482eb607bb285f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679438 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#672757}
-
Alice Boxhall authored
Bug: 692360 Change-Id: I13b613be9417210e4ca213664fa227f1cb655b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678764Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#672756}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4d6951669cd8..bca1485a7acb git log 4d6951669cd8..bca1485a7acb --date=short --no-merges --format='%ad %ae %s' 2019-06-26 qingsi@webrtc.org Enable setting surface_ice_candidates_on_ice_transport_type_changed on the fly. 2019-06-26 jakobi@webrtc.org Reland "Change buffer level filter to store current level in number of samples." Created with: gclient setdep -r src/third_party/webrtc@bca1485a7acb The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If0ea84013ce242b15b712bbdc26ca1e6b2253409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678705Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672755}
-
Maksim Ivanov authored
Create the CryptohomeKeyDelegate service that is run by Chrome. Implement the ChallengeKey method that handles the challenge request from cryptohomed by sending it to a certificate provider. This is part of the "smart card based user sign-in" feature. When using this feature, the users will authenticate not via manually entered passwords, but instead based on the challenge-response protocol: the actual encryption secret is handled only by cryptohomed and the TPM chip, meanwhile Chrome only receives one-time challenges and returns back their signatures generated by the smart card. Bug: 826417 Change-Id: I8d52256377f29172ea631c880576bbded84bf120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674096 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#672754}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/cff2a5619b04..48e07b5f07a4 git log cff2a5619b04..48e07b5f07a4 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 zoddicus@users.noreply.github.com Rolling 4 dependencies and update known_failures (#745) Created with: gclient setdep -r src/third_party/shaderc/src@48e07b5f07a4 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: I327e77e116ca4d3c44c5d37bf61da0be915c9794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679558Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672753}
-
Devlin Cronin authored
Mark the following histograms as never expiring, since they are useful indefinitely: - Extensions.BackgroundPageType Mark the following histograms as expiring in M90, since they are currently useful but should be re-evaluated in the future: - Extensions.BackgroundPageLoadTime2 - Extensions.DidCreateScriptContext_* - Extensions.EventPageIdleTime - Extensions.Messaging.MessageSize - Extensions.ProcessManagerStartupHostsTime - Extensions.ResetPermissionsIncrease - Extensions.UninstallDialogAction - Toolbar.ActionsModel.ToolbarActionsVisible Bug: 976040,975841,975459,975413,975300,975230,975042,975018 Change-Id: I0f0b1300bf84629c0b4027fff72363d66183f7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674476 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#672752}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a578ea33e5c8..b5133207dd2a Created with: gclient setdep -r src-internal@b5133207dd2a The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:962533 TBR=reillyg@google.com,yhirano@google.com,futhark@google.com Change-Id: I9fb9985652282b708dab58ee547819c0a3e84e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679554Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672751}
-
John Budorick authored
Bug: 790202 Change-Id: Icc71bbb03f782e346356c8b8f6eb2124b94fc493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678762 Auto-Submit: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#672750}
-
Timothy Loh authored
This CL tidies CrostiniManager a bit: - Updates outdated comments referring to vm_name/container_name now that we have the ContainerId type - Removes some typedefs of callbacks that only add indirection making it harder to follow - Remove redundant comments like '// Notify observers' - Explicitly number CrostiniResult enum values as they are displayed to the user in some cases Change-Id: I1bd300c338e4d7080b25062babeff9e656522158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679066Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#672749}
-
Xianzhu Wang authored
Previously we implemented z-ordering of composited overlay scrollbars in GraphicsLayerTreeBuilder which reparents overlay scrollbar GraphicsLayers of scrollers with higher z-order scrollable contents. The overlay scrollbar GraphicsLayers are inserted into the GraphicsLayer of the stacking context above all scrolling contents GraphicsLayers, to ensure the overlay scrollbars to be above any scrolling contents. However, the logic doesn't work for all overlay scrollbars in CompositeAfterPaint and non-composited scrollbars in pre-CompositedAfterPaint because these scrollbars are not controlled by GraphicsLayerTreeBuilder. This CL let PaintLayerStackingNode also manage z-order of overlay scrollbars. If any scroller with overlay scrollbars has any stacked contents that have higher z-order than the scroller, the overlay scrollbars will be inserted after the highest z-order scrolling contents in the z-order list. Also add a paint phase for overlay scrollbars. This is not strictly necessary for now because all scrollers with overlay scrollbars are self-painting. However, this allows us in the future to let scrollers not self-painting to achieve perfect painting order. Bug: 918155 Change-Id: Iccae1cbcde8de46158267e45bab2a13a027db3ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1461536 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#672748}
-
Daniel Murphy authored
The key format for scopes task keys needs a fixed-size big endian number, and the current code didn't do that. This change also cleans up an unused function. R=cmp@chromium.org Bug: 978545 Change-Id: Ic7cd3bde8915632280085e2ad0dc90296fa4a02e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677015 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#672747}
-
Antoine Labour authored
Some GLSurface calls that touch the back buffer may need to change the underlying surface, making the current again. That may fail, in which case no context would be current at that point. Calling code needs to be aware of this and handle it appropriately (e.g. losing context). Bug: 978639 Change-Id: I877bcb6144cd2535bb5e00e8b922ab122cce38d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679165 Commit-Queue: Antoine Labour <piman@chromium.org> Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#672746}
-
Nicholas Hollingum authored
This cl refactors the sequence generator so that we can also create manual sequences. First we change the SequenceContext into a SequenceBuilder, which provides conveniences for building. We then define a method which generates manual sequences and call it when building the automatic sequences. This cl partially builds a (non-working) sequence for configuring a popup location. But its more complicated than i hoped so i'm leaving it non-working, but commiting the CL since i want to work on a different sequence for copy pasting. The non working popup sequence is still useful for fuzzing. Bug: 961564 Change-Id: Ib6a7bf367e27f60223968d18f8ee25b828092b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677808Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#672745}
-
Mohsen Izadi authored
This new type of layer can be used to mirror contents of another layer. When a mirror layer is set to mirror another layer, the latter is forced to create a render pass so that the former can add a RenderPassDrawQuad referring to that render pass, mirroring its contents. Note that this CL does not add damage rect handling for the mirror layer. That would be done in a follow-up CL. The first use case for the mirror layer would be creating docked magnifier on CrOS. The current implementation of docked magnifier does not work with OOP-D. BUG=947565 Change-Id: I1609edf53eb8c1ae8faff5345ee41dc547a916a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652202Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#672744}
-
Matt Falkenhagen authored
Bug: 975826, 975658, 975306, 975163, 976016, 974930 Change-Id: I65ac36035bd712c071a1d12133099af476969f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677390Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#672743}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/54e38e370156..2e2b6f29ff60 git log 54e38e370156..2e2b6f29ff60 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 ahassani@chromium.org paygen: Make PaygenPayload arguments optional. 2019-06-26 ahassani@chromium.org paygen: Allow DLC local payload generation Created with: gclient setdep -r src/third_party/chromite@2e2b6f29ff60 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I5ee1cc1b99f62c44c019036b1f616776d899b047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678953Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672742}
-
Kenichi Ishibashi authored
The previous CL was reverted because it missed some test expectations. Added missing expectations. Original description: > On-the-main-thread script fetch is disabled by default. Add virtual > tests for on-the-main-thread script fetch to have better test > coverage until we ship off-the-main-thread script fetch. Change-Id: I03d9dd44957f3e58d984a76200ff12a41ae28d6f Bug: 967272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675645 Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#672741}
-
Sophie Chang authored
Bug: 969558 Change-Id: I7b68c78bcfe08076d939cf6814f2b5e6cb08eff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679228Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#672740}
-
Antonio Gomes authored
This CL is a preparation step to Onion soup webrtc_audio_renderer.cc|h. It adds to blink::Platform two methods that expose the AudioDeviceFactory functionality needed by WebRtcAudioRenderer. It is part of the phase 3.3.10 in the design doc [1] [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/ BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: If9e4c03f583fee43bfe5cb182f852c16266c6acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678297 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#672739}
-
Eric Karl authored
This path refactors Android's StreamTexture* based video path to use SharedImages. This consists of two main parts: 1. Remove all GL code from StreamTextureFactory/StreamTextureWrapper, allowing the client code to be independent of graphics API. As part of this the logic around StreamTextures was moved to GpuChannelHost, and no longer requires a GLES2 command buffer. 2. Allocate a new SharedImage each time the video size changes, allowing the SharedImages to have an immutable size. Also refactors the SharedImage creation code to have better synchronization logic. Bug: 938149 Change-Id: Ib9ccc102f348b0c8ea9303875f67caaf0702e421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616526 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#672738}
-
Matthew Mourgos authored
Bug: 914094 Change-Id: Ifa8cff6cc777838a36c8774d1e04755396b3c68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677596 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#672737}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1ff9ce92d17a..788d9e0de813 git log 1ff9ce92d17a..788d9e0de813 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@788d9e0de813 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I27734274a4cec14209f2dfa47c3b386a607da27c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678232Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672736}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bdbc2153..fcb4e0c5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2279972439ef822d58f6309da50938db250b4dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679002Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672735}
-
Nicolas Norvez authored
Those metrics are still valid, update the expiration date to M85 that is about 1 year from now. Bug: 978939 Change-Id: Ib9033af15fc3df302ae572fbcb977d9616460bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678844Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Nicolas Norvez <norvez@chromium.org> Cr-Commit-Position: refs/heads/master@{#672734}
-
Ian Kilpatrick authored
I've been trying to produce a simplified repro with this but to no avail so far. Basically legacy can get into a state where a layout_layout's LayoutBlock::PositionedObjects map contains a positioned-object, however that postiioned-object's containing-block is a node further up the tree. Somewhere (during a style change, inline-splitting, etc) we are missing a call to RemovePositionedObject(s). I've added a NOTREACHED() on the branch so that clusterfuzz can pick up the issue with a simpler test-case. Bug: 977930 Change-Id: I60d5c25f4565d92bff24c10ef46211c23babee28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678841Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#672733}
-
Mason Freed authored
For backdrop-filter, the spec [1] states: If the filter functions list includes a blur() filter, the filter will be applied with edgeMode="duplicate", with the edge defined by the clipped, transformed border box of the element. This tests that condition. TBR=robertma@chromium.org [1] https://drafts.fxtf.org/filter-effects-2/#backdrop-filter-operation Bug: 978031 Change-Id: I6cf3477bedb4c691d2970113f5aecd350d2d475e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676444Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#672732}
-
Tim Song authored
A following CL will integrate this new view with the existing tray UI behind a flag. Old UI: https://screenshot.googleplex.com/piFt6475aT4 New UI: https://screenshot.googleplex.com/80T0oZeapqJ TEST=unit test + verified manually BUG=921267 Change-Id: Ie82e3e0144bfa1465088af06564aab3588a9e8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669441 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#672731}
-
Jeffrey Cohen authored
This CL fleshes out the TVC to both display properly and to enumerate the possible target devices that a user can send a tab. screenshot of current state: https://drive.google.com/file/d/1iF1unVcXoKFk-l3bFh1GrQTe6ve5KZtB/view Bug: 970284 Change-Id: I64b5afbbf56b9deaca63ce416f835051cc57b56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664994Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#672730}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b46998c50dd4..a578ea33e5c8 Created with: gclient setdep -r src-internal@a578ea33e5c8 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=reillyg@google.com,yhirano@google.com,futhark@google.com Change-Id: I8345db05ccbd32a836c2ec70d7fbc228a39b1a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679386Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672729}
-
Varun Khaneja authored
Remove some metrics that are not very useful and not monitored. R=drubery Bug: 975066,974981,972786,969971,969968,969923,833706 Change-Id: I6b30628363cf21080818a9b5345da1acc09fcabd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677225 Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#672728}
-
Peter Boström authored
Changes highlighting to trigger over all of the container, not just additional items. This required adding code for checking to make sure that at least two children were visible to avoid drawing the container stroke when there's only one item inside. Code's also added to detect when the number of children change as this can update the number of visible children. Bug: chromium:932818, chromium:943702 Change-Id: I6faec57c87ec06df80ad16918a66d0afafe57c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677231Reviewed-by:
Siyu An <siyua@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#672727}
-
David Black authored
Fixes DCHECK. Bug: b:136113743 Change-Id: I10cb6587b1017d8c734e91399b8792ab7dbd9fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679063Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#672726}
-
Evan Stade authored
These were both only used by tests, and can be replaced by observing view focus changes. Bug: 268984 Change-Id: I7472bc3f3eb5b9f807851e0c30af9386b9920d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673082 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#672725}
-
Piotr Bialecki authored
Currently, the pattern to obtain XRPoses in WebXR is to invoke `XRFrame.getPose(space_to, space_from)` method - XRPlanes were not following the pattern and returning XRPoses directly from `XRPlane.getPose(space)`. This CL fixes that inconsistency - planes will now return instances of XRSpace that can be used to obtain the poses from a frame. Change-Id: Ie656bcca50fe7118d5e2ffeb94e86e101b6e7f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678440Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#672724}
-
- 26 Jun, 2019 6 commits
-
-
Dale Curtis authored
Code and comments say opposite things about which color space info to prefer. Unify on the config only after checking with hubbe@ and confirming that webm vp9.2 encodes do need to use the config color space instead of bitstream. BUG=none TEST=hubbe@ && vp9.2 playback. Change-Id: If990c79481eab3e6925c39b1457d182a7d1cbdbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670122 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#672723}
-
Xida Chen authored
Right now when we initialize the paint canvas for paint worklet with a scale factor or browser zoom, we do not record the zoom factor in the canvas transform. As a result, when computing the clip bound we will apply the wrong transformation matrix and thus sometimes the contents can be completely clipped out while it should not. This CL fixes the problem and adds a layout test. Bug: 970783 Change-Id: Ie3709ea5845ca2b405245d4b36f9fe8f99052bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678287Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#672722}
-
Kristyn Hamasaki authored
Bug: 972150 Change-Id: Iaceb58f88fa48baedda753c0520a552edeaff556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649306Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Cr-Commit-Position: refs/heads/master@{#672721}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cc82c3f0f1e0..d43eee649664 git log cc82c3f0f1e0..d43eee649664 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 jmadill@chromium.org Vulkan: Increase size of driver uniforms buffer. 2019-06-26 syoussefi@chromium.org Allow wildcards freely in deqp expectations files 2019-06-26 jmadill@chromium.org Vulkan: Recycle dynamic buffer storage. Created with: gclient setdep -r src/third_party/angle@d43eee649664 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: Ic7f33291f88d79e84d919386ed644bd90775026c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678951Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672720}
-
Joey Scarr authored
Bug: 977838 Change-Id: I39144a5ab8855231dd14aa3c6bc661c24ba6a866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677845Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Joey Scarr <jsca@chromium.org> Cr-Commit-Position: refs/heads/master@{#672719}
-
Oriol Brufau authored
Previously this only happened if the old display was custom layout, but not when changing from a standard display to a custom one. This was a typo, the same condition was checked twice for old_style, but the second occurrence should check new_style instead. The change matters when there are inline children that should be blockified by the custom layout, without the patch they would remain inline. BUG=978990 TEST=external/wpt/css/css-layout-api/layout-child-inlines-dynamic.https.html Change-Id: I73bcf679209dd4bc4a0d7a49f4345ee699bbf37e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678484Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#672718}
-