- 05 Feb, 2015 34 commits
-
-
danakj authored
This will help in tracking down window resize bugs. R=enne, vmpstr BUG=454333 Review URL: https://codereview.chromium.org/864713004 Cr-Commit-Position: refs/heads/master@{#314715}
-
heejin.r.chung authored
To match the recent change in MathUtil::AddToTracedValue, pass name as parameter and Begin/End internally. R=danakj Review URL: https://codereview.chromium.org/898663003 Cr-Commit-Position: refs/heads/master@{#314714}
-
michaeln authored
[DOMStorage] (recommitting) Offset the session storage namespace ids generated by different contexts to help identify when an id from one is mistakenly used in another. >> Committed: https://crrev.com/36dcef3da5317365ab95e50a5f6b7fa98ada1d5e >> Cr-Commit-Position: refs/heads/master@{#314256} > > Reverted: https://crrev.com/7bdc4a49e605261b60ee1339f93e835d853bf645 > Cr-Commit-Position: refs/heads/master@{#314274} Review URL: https://codereview.chromium.org/881253004 Cr-Commit-Position: refs/heads/master@{#314713}
-
joedow authored
Initial checkin for the app remoting test driver tool. The external pieces of the test driver will consist of a common library which will build the dependencies and core helper classes and a minimal version of the tool which will include a minimal number of tests. An internal version of the tool will include the common library and pull in additional tests from src-internal. The tool uses the GTest framework and this CL is to set up the foundation so I can start adding functionality. I am not hooking it into the public gyp files yet, that will come in a future change as more changes to the remoting GYP files are expected. BUG= Review URL: https://codereview.chromium.org/900973002 Cr-Commit-Position: refs/heads/master@{#314712}
-
tapted authored
Currently keystrokes while a menu is open are sent to the window hosting the menu, since it remains `key`. Menus are a different window, so this causes all the Menu* interactive_ui_tests to fail since they simulate pressing ESC to dismiss the menu in the tests. Other platforms insert an event dispatcher into the message pump for the nested run loop that shows a menu, and redirect KeyDown events to the MenuController. On Mac, events need to be mapped to "Action" messages by an NSResponder to obey platform behaviour and user customizations (e.g. a "Home" keypress should be interpreted as beginning of document, not beginning of line). The approach in this CL is to check in BridgedContentView, an NSResponder, for an active menu that should be receiving events instead. Action messages are mapped to the KeyCode that toolkit-views expects for that action, and the MenuController is given an opportunity to swallow the event or have it sent on to the key window. Gets the following interactive_ui_tests passing: MenuControllerMnemonicTest*{NoMatch,TitleMatch,MnemonicMatch} MenuItemViewTestRemoveWithSubmenu{0,1}* (and all Menu interactive UI tests pass after this). BUG=403679 Review URL: https://codereview.chromium.org/866983006 Cr-Commit-Position: refs/heads/master@{#314711}
-
pstew authored
BUG=450601 R=kalman@chromium.org Review URL: https://codereview.chromium.org/901583003 Cr-Commit-Position: refs/heads/master@{#314710}
-
jam authored
BUG=454834 TBR=ppi@chromium.org Review URL: https://codereview.chromium.org/897173002 Cr-Commit-Position: refs/heads/master@{#314709}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/d2a6f4e..12753cc CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=stephana@google.com Review URL: https://codereview.chromium.org/903503003 Cr-Commit-Position: refs/heads/master@{#314708}
-
kkimlabs authored
There are some UMA strings, enum constants in iOS repository that can be shared with Android, so moved to components. BUG=452254 Review URL: https://codereview.chromium.org/891493003 Cr-Commit-Position: refs/heads/master@{#314707}
-
jam authored
It looks like the GetFontData patch for PDFium is only used on XP/Vista now. Previously PDFium was in a separate binary so we were just calling the real GetFontData from chrome_child.dll. That doesn't work anymore, so use the original function pointer. BUG=455399 Review URL: https://codereview.chromium.org/903583002 Cr-Commit-Position: refs/heads/master@{#314706}
-
boliu authored
Use TexSubImage2D instead of TexImage2D to avoid orphaning EGLImage Create the renderer compositor context on the gpu thread. BUG=448168, 259924 Committed: https://crrev.com/a4baed454be2bb165cb12eb7df432e9138e746e6 Cr-Commit-Position: refs/heads/master@{#313846} Review URL: https://codereview.chromium.org/769703005 Cr-Commit-Position: refs/heads/master@{#314705}
-
oysteine authored
The threaded data receiver will now receive notifications about received data packets on the main thread (needed for the progress indicator to work properly), and can optionally specify that it wants to receive a full copy of the data (needed when the Inspector is attached). If a threaded data receiver is attached to a resource request, we also now make sure the resource completed message is bounced via the background thread, to make sure all data is received on the main thread first. Blink side patch: https://codereview.chromium.org/690793003 BUG=398076 Review URL: https://codereview.chromium.org/689713004 Cr-Commit-Position: refs/heads/master@{#314704}
-
mgiuca authored
Previously, this class would fail gracefully if given a nullptr. Now it has undefined behaviour. Dealing with null isn't necessary as no caller passes nullptr here, and in general, pass-by-result style functions do not expect null pointers. Dealing with nullptr makes my follow-up work messy, so I am just removing it. Also, moved constructor implementation to .cc file, and properly documented the lifetime constraints on |json_string|. BUG=455068 Review URL: https://codereview.chromium.org/889303004 Cr-Commit-Position: refs/heads/master@{#314703}
-
xdai authored
Add UMA stats to record the memory pressure level periodically (once per second) in ChromeOS. This is used to show the relative frequency of the system being in a critical vs relaxed memory pressure state BUG=442829 Review URL: https://codereview.chromium.org/874483008 Cr-Commit-Position: refs/heads/master@{#314702}
-
bauerb authored
Before this CL, component installers were leaked in almost all cases. If we allow uninstalling components (see https://codereview.chromium.org/879993005/), we need to fix those leaks. BUG=436459 Review URL: https://codereview.chromium.org/897873002 Cr-Commit-Position: refs/heads/master@{#314701}
-
mseaborn authored
This pulls in the following Native Client changes: ab93269: (phosek@chromium.org) Removes the now-unused kernel service from the service runtime 9e3dac8: (sbc@chromium.org) Implement pthread_rwlock functions for NaCl newlib. BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build Review URL: https://codereview.chromium.org/896533005 Cr-Commit-Position: refs/heads/master@{#314700}
-
qinmin authored
This change allows MediaSourcePlayer to skip browser seek if a key frame is found in cache. Key frames can be identified by an empty data buffer, a config change or is_key_frame field. BUG=304234 Review URL: https://codereview.chromium.org/898843002 Cr-Commit-Position: refs/heads/master@{#314699}
-
brucedawson authored
The ipc_perftests and mojo_message_pipe_perftests results appeared designed to be compared against each other, and the ipc_perftests appear to be designed to take about a second each. Therefore it is presumably a bug that the final ipc_perftests test executes only 100 times (versus 1,000 times for mojo_message_pipe_perftests) and that it executes in ~50 ms. This change increases the iteration count from 100 to 1,000. Review URL: https://codereview.chromium.org/903513002 Cr-Commit-Position: refs/heads/master@{#314698}
-
mlamouri authored
It is sending the request from the render process to the browser process which then opens the URL using ContentBrowserClient::OpenURL(). This is going to be used by sw.client.openWindow(), see Blink CL: https://codereview.chromium.org/850413002 BUG=437151 Review URL: https://codereview.chromium.org/843583005 Cr-Commit-Position: refs/heads/master@{#314697}
-
bbudge authored
BUG=455409 Review URL: https://codereview.chromium.org/901733002 Cr-Commit-Position: refs/heads/master@{#314696}
-
jianli authored
This is not longer needed after we have a generic gcm channel state. BUG=447016 TEST=none TBR=kalman@chromium.org Review URL: https://codereview.chromium.org/897793002 Cr-Commit-Position: refs/heads/master@{#314695}
-
mdempsky authored
BUG=449357 Review URL: https://codereview.chromium.org/888093005 Cr-Commit-Position: refs/heads/master@{#314694}
-
alexandrec authored
Review URL: https://codereview.chromium.org/896463005 Cr-Commit-Position: refs/heads/master@{#314693}
-
jonross authored
This reverts commit cc6a8bfe. From review: https://codereview.chromium.org/899973002/ Original issue's description: > Device Orientation API on Chrome OS > > Implement DataFetcherSharedMemory on Chrome OS to provide Device Orientation support. Create SensorManagerChromeOS to observe accelerometer events, and to generate updates to the Device Orientation API. > > This is a follow up to: https://codereview.chromium.org/680383007/ > > With the accelerometer on Chrome OS now exposed to content/ from chromeos/accelerometer, no ash/ implementation is required. No public api in content/public/browser is needed either. > > TEST=SensorManagerTest.OrientationBuffer, SensorManagerTest.NeutralOrientation, SensorManagerTest.UpsideDown, SensorManagerTest.BeforeUpsideDownBoundary, SensorManagerTest.LeftEdge, SensorManagerTest.RightEdge, SensorManagerTest.BeforeRightEdgeBoundary > BUG=342908 TBR=timvolodine@chromium.org,jam@chromium.org BUG=342908 Review URL: https://codereview.chromium.org/880083005 Cr-Commit-Position: refs/heads/master@{#314692}
-
afakhry authored
Instead of parsing the whole proc stats just to extract two values, we skim through it just to extract the two values we're interested in. BUG=453871 TEST=base_unittests --gtest_filter=ProcessMetricsTest.* Review URL: https://codereview.chromium.org/888193002 Cr-Commit-Position: refs/heads/master@{#314691}
-
mitchelljones authored
There is a bug where the "Close Window" shortcut for hosted/packaged apps would disappear after focusing the File menu in a Chrome browser. This is because the shortcuts had the same key equivalent, and OS X was choosing to only display one of them. This CL fixes this by keeping a reference to the conflicting menu items and enabling/disabling the shortcuts on focus. BUG=455067 Review URL: https://codereview.chromium.org/898543008 Cr-Commit-Position: refs/heads/master@{#314690}
-
zhenw authored
testGetUpdatedInspectableContexts should only run when tab control is supported. BUG=452277 Review URL: https://codereview.chromium.org/893233003 Cr-Commit-Position: refs/heads/master@{#314689}
-
dtseng authored
- ! allowed by a tts property will annotate the output with that property - $descendants(args...) where args... is a comma delimited list of roles, will compute output for the node's descendants that are in the set of roles. - apply these two new functions to compute utterances for alerts. TEST=navigate to a page with an alert like html5demos.com/geo. BUG=382650 Review URL: https://codereview.chromium.org/816093002 Cr-Commit-Position: refs/heads/master@{#314688}
-
rvargas authored
This removes the need to compare a raw handle against a predefined value from the caller's code. BUG=none TEST=base_unittests Review URL: https://codereview.chromium.org/868143004 Cr-Commit-Position: refs/heads/master@{#314687}
-
aurimas authored
- Switch to using expand and collapse icons from internal repo - Start using TintedDrawable for WebsitePreferences. BUG=454859 Review URL: https://codereview.chromium.org/900743003 Cr-Commit-Position: refs/heads/master@{#314686}
-
orenb authored
Add a basic settings page with a Polymer paper element which loads at chrome://md-settings (if the enable-md-settings flag is enabled). BUG=454961 Review URL: https://codereview.chromium.org/893323002 Cr-Commit-Position: refs/heads/master@{#314685}
-
danakj authored
Long live cc. R=enne, vmpstr Review URL: https://codereview.chromium.org/897873005 Cr-Commit-Position: refs/heads/master@{#314684}
-
sievers authored
BrowserGpuChannelHostFactory::GetGpuChannel() can return NULL. In particular it already checks IsLost() and returns NULL if that is the case. BUG=445945 Review URL: https://codereview.chromium.org/867093004 Cr-Commit-Position: refs/heads/master@{#314683}
-
sandersd authored
- Fail if VideoToolbox returns a null pointer, instead of crashing. - Stop processing as soon as an error occurs. BUG=453050 Review URL: https://codereview.chromium.org/900053002 Cr-Commit-Position: refs/heads/master@{#314682}
-
- 04 Feb, 2015 6 commits
-
-
rickyz authored
Review URL: https://codereview.chromium.org/873923004 Cr-Commit-Position: refs/heads/master@{#314681}
-
miu authored
Replaces the use of MultiChannelResampler with AudioConverter in FakeMediaSource to allow the cast_sender_app and cast_simulator to re-mix any-number-of-channels audio into the 2-channel audio for Cast sending. Review URL: https://codereview.chromium.org/900913004 Cr-Commit-Position: refs/heads/master@{#314680}
-
sullivan authored
BUG=455349 Review URL: https://codereview.chromium.org/866913006 Cr-Commit-Position: refs/heads/master@{#314679}
-
boliu authored
On android versions before 5.0, EGL sync objects are incorrectly destroyed when the associated EGL context is destroyed. The EGL sync objects error handling is tight to prevent driver regressions from known issues. This combined with this triggers DCHECk failures and crashes. So add another workaround to ignore errors from EGL sync object calls. BUG=453857 Review URL: https://codereview.chromium.org/892323002 Cr-Commit-Position: refs/heads/master@{#314678}
-
dcheng authored
The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=caitkp@chromium.org Review URL: https://codereview.chromium.org/893303003 Cr-Commit-Position: refs/heads/master@{#314677}
-
Christopher Cameron authored
CaptivePortalBrowserTest.InterstitialTimerNavigateAwayWhileLoading was disabled a few days ago, this one has the same issue. BUG=453875 TBR=thestig@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/902583005 Cr-Commit-Position: refs/heads/master@{#314676}
-