GitLab

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyFontVariationSettings from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIFontVariationSettings.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIFontVariationSettings.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIFontVariationSettings.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2613723003
Cr-Commit-Position: refs/heads/master@{#442838}

This patch converts following tests to utilize
w3c test harness with |assert_selection()| to ease of maintenance for improving
code health('=>' means move/renaming):
LayoutTests/editing/selection/4947387.html =>
  LayoutTests/editing/selection/modify_move/move-by-paragraph.html

LayoutTests/editing/selection/after-line-wrap.html =>
  LayoutTests/editing/selection/modify_move/move-forward-after-line-break.html

LayoutTests/editing/selection/click-left-of-rtl-wrapping-text.html =>
 LayoutTests/editing/selection/mouse/click-left-of-rtl-wrapping-text.html

This is preparation to remove default styles on contenteditable containers.
See crbug.com/427135.

BUG=427135,679977

Review-Url: https://codereview.chromium.org/2525273002
Cr-Commit-Position: refs/heads/master@{#442837}

This CL copies from |VisibleSelection::showTreeForThis()| and renames
 following "base" and "extend".

TEST=No change in behavior

Review-Url: https://codereview.chromium.org/2533693002
Cr-Commit-Position: refs/heads/master@{#442836}

In VideoDecodeAcceleratorParamTest.TestSimpleDecode there are many ASSERT_xx
while testing, which aborts test and doesn't delete GLRenderingVDAClient in
GetRenderingTaskRunner.

1. For thumbnail test, in fact it doesn't need ASSERT for MD5 missing, wrong
format, or comparison failure since it won't break any other things. Change to
EXPECT_xx and LOG(ERROR).

2. Delete GLRenderingVDAClient in VideoDecodeAcceleratorParamTest::TearDown().
When ASSERT happens it aborts test immediately and call TearDown(), so we can
make sure GLRenderingVDAClient is deleted.

BUG=654677
TEST=test debug version of video_decode_accelerator_unittest on Elm
1. For thumbnail test, try to not push md5 file and the test will fail and end
gracefully. Add an invalid entry in md5 and the test will pass with error
messages.
2. Try to make assertion in any place inside TEST_P. Test will fail and end
gracefully.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2596193005
Cr-Commit-Position: refs/heads/master@{#442835}

BUG=680050
TBR=pfeldman@chromium.org

Review-Url: https://codereview.chromium.org/2625083002 .
Cr-Commit-Position: refs/heads/master@{#442834}

BUG=680043
TBR=mikhail.pozdnyakov@intel.com

Review-Url: https://codereview.chromium.org/2622183003 .
Cr-Commit-Position: refs/heads/master@{#442833}

Something in this range broke the Mac builder:
https://chromium.googlesource.com/chromium/src/+log/c6e4c6f1f9865b5a77d2cc4eb8c7104b632624f1%5E..1a7740c44a6c4d03423c4b5ff7d746e1a1b7363e?pretty=fuller

r442828 is the most obvious candidate which may have affected builds.

BUG=679607
TBR=kbr@chromium.org

Review-Url: https://codereview.chromium.org/2626993002 .
Cr-Commit-Position: refs/heads/master@{#442832}

https://skia.googlesource.com/skia.git/+log/fb00390b46b3..db52cf3b040d

$ git log fb00390b4..db52cf3b0 --date=short --no-merges --format='%ad %ae %s'
2017-01-10 reed move SkDraw.h to core

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2620283003
Cr-Commit-Position: refs/heads/master@{#442831}

The caret height should be calculated by using the FontMetrics
instead of the selection height.

BUG=588060
TEST=editing/caret/caret-height-multi-line.html

Review-Url: https://codereview.chromium.org/2517383002
Cr-Commit-Position: refs/heads/master@{#442830}

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Ou_Dwfp8Ons/mCaMNPPdFAAJ

BUG=678547

Review-Url: https://codereview.chromium.org/2619823003
Cr-Commit-Position: refs/heads/master@{#442829}

BUG=679607, 663188
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2627553002
Cr-Commit-Position: refs/heads/master@{#442828}

https://pdfium.googlesource.com/pdfium.git/+log/29a9f87a8bcd..44bc1f818dd7

$ git log 29a9f87a8..44bc1f818 --date=short --no-merges --format='%ad %ae %s'
2017-01-10 npm Fix m_nb_mct_records calculation in opj_j2k_read_mct
2017-01-10 dsinclair Strip out custom allocator code
2017-01-10 dsinclair Split xfa_textlayout apart.
2017-01-10 dsinclair Remove custom allocator from CFDE_TxtEdtBuf.
2017-01-10 tsepez Remove CFX_ArrayTemplate in cfx_psrender.

BUG=678461

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2628783002
Cr-Commit-Position: refs/heads/master@{#442827}

BUG=577816

Review-Url: https://codereview.chromium.org/2621713004
Cr-Commit-Position: refs/heads/master@{#442826}

https://chromium.googlesource.com/chromium/src/+/b554c05ac115a

BUG=673754
TBR=tkent@chromium.org

Review-Url: https://codereview.chromium.org/2627823002 .
Cr-Commit-Position: refs/heads/master@{#442825}

TabbedLocations used to materialize tab contents on tabSelected. Now,
they materialize only if the tab is selected while the TabbedPane is showing, or
when the TabbedPane is being shown.

BUG=none

Review-Url: https://codereview.chromium.org/2617293002
Cr-Commit-Position: refs/heads/master@{#442824}

BUG=673210
TEST=open camera app and see the vid/pid is converted to lower case in
log

Review-Url: https://codereview.chromium.org/2621693003
Cr-Commit-Position: refs/heads/master@{#442823}

Using switch is the best option here to get compile time verification, and
we can catch it if WebServiceWorkerEventResult gains a new type later.

Here also replace some if-return with DCHECK.

BUG=None

Review-Url: https://codereview.chromium.org/2606303002
Cr-Commit-Position: refs/heads/master@{#442822}

Value of the EffectiveConnectionType enum is provided by the
NetworkMetricsProvider.

A new class EffectiveConnectionTypeObserver has been added which listens
to the changes in the EffectiveConnectionType, and lives on the same
thread as the NetworkQualityEstimator.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=677158

Review-Url: https://codereview.chromium.org/2605553002
Cr-Commit-Position: refs/heads/master@{#442821}

This patch converts editing/pasteboard/5075944.html with assert_selection
to promote the use of w3c testharness and improve code health.

It is also a preparation for https://codereview.chromium.org/2626933002

BUG=679616, 679977

Review-Url: https://codereview.chromium.org/2621213002
Cr-Commit-Position: refs/heads/master@{#442820}

This fix regression compared M55 build.

TEST=Manually, close LSO page and observe that Play Store checkbox
     in settings turns off.
BUG=b/34199954

Review-Url: https://codereview.chromium.org/2625833002
Cr-Commit-Position: refs/heads/master@{#442819}

We force a style recalc at the start, and wait for compositor
at the end.

BUG=248938

Review-Url: https://codereview.chromium.org/2619933002
Cr-Commit-Position: refs/heads/master@{#442818}

And makes mash use RootWindowController directly. My next step is to
fold WmRootWindowController back into RootWindowController.

BUG=671246
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2620913003
Cr-Commit-Position: refs/heads/master@{#442817}

Makes the thumb highlighted when the slider control is focused helping
when controlling volume or brightness with a keyboard.

BUG=658783

Review-Url: https://codereview.chromium.org/2619953002
Cr-Commit-Position: refs/heads/master@{#442816}

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyFlexBasis from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIFlexBasis.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIFlexBasis.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIFlexBasis.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2613843002
Cr-Commit-Position: refs/heads/master@{#442815}

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyFontSizeAdjust from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIFontSizeAdjust.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIFontSizeAdjust.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIFontSizeAdjust.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2617443005
Cr-Commit-Position: refs/heads/master@{#442814}

Currently we use WebServiceWorkerResponse to pass the navigation preload
response from ServiceWorkerContextClient::NavigationPreloadRequest to FetchEvent.

But to show the network timing information in DevTool's network tab, we need
the timing information in ResourceResponseInfo in blnik side. So this cl change
the code to use WebURLResponse which contains the timing information.

BUG=649558

Review-Url: https://codereview.chromium.org/2618313003
Cr-Commit-Position: refs/heads/master@{#442813}

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyColumnGap from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIColumnGap.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIColumnGap.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIColumnGap.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2609933004
Cr-Commit-Position: refs/heads/master@{#442812}

Move LocalDomWindow unusedPreloadsTimer to TaskRunnerTimer, which
associates it wuith the frame's timer task queue.

BUG=624694

Review-Url: https://codereview.chromium.org/2625953002
Cr-Commit-Position: refs/heads/master@{#442811}

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyClip from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIClip.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIClip.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIClip.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2614783003
Cr-Commit-Position: refs/heads/master@{#442810}

We avoid timing dependence by rAF looping until the animation is in
progress.

BUG=248938

Review-Url: https://codereview.chromium.org/2621603002
Cr-Commit-Position: refs/heads/master@{#442809}

Made -webkit-rtl-ordering property independent. Also updated
independent-inheritance-fast-path.html to include webkitRtlOrdering.

Tested using independent-inheritance-fast-path.html.

BUG=628043

Review-Url: https://codereview.chromium.org/2626893002
Cr-Commit-Position: refs/heads/master@{#442808}

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyCaretColor from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPICaretColor.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPICaretColor.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPICaretColor.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2618613002
Cr-Commit-Position: refs/heads/master@{#442807}

R=tsergeant@chromium.org
BUG=679973

Review-Url: https://codereview.chromium.org/2624873003
Cr-Commit-Position: refs/heads/master@{#442806}

The size of the Safe Browsing client class was getting to be too large
to be contained entirely within PermissionContextBase, so it has been
moved to its own header and implementation.

Test coverage is supplied in permission_context_base_unitttest.cc, but
there will be follow up unit tests for this class.

BUG=561867

Review-Url: https://codereview.chromium.org/2626853002
Cr-Commit-Position: refs/heads/master@{#442805}

Since we don't know know whether the drag image is going to have an
opaque backdrop, disable LCD text conservatively.

This was previously handled by SkPictureImageGenerator, internally, but
broke in http://crrev.com/2619573002.

BUG=679307
R=reed@google.com

Review-Url: https://codereview.chromium.org/2625803002
Cr-Commit-Position: refs/heads/master@{#442804}

This is a temporary fix to enforce linear filter for texture object
in OffscreenCanvasRenderingContext2D in commit(). An ideal solution, which is
not urgent for OffscreenCanvas launch, is to adapt the filter to respect
image-rendering CSS property, as indicated in crbug.com/645590.

BUG=676666
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2607373002
Cr-Commit-Position: refs/heads/master@{#442803}

BUG=679660

Review-Url: https://codereview.chromium.org/2624973002
Cr-Commit-Position: refs/heads/master@{#442802}

The majority of the data and logic in the Interpolation base class is only
required for the LegacyStyleInterpolation subclass, and is ignored or
overwritten for InvalidatableInterpolation. This patch moves this data and logic
down the hierarchy into LegacyStyleInterpolation.

As additional consequences:
- SampleInterpolation classes defined in tests inherit from
  LegacyStyleInterpolation instead of the Interpolation base class
- getCachedValueForTesting is made pure virtual, requiring a placeholder
  implementation to be added to InvalidatableInterpolation, although this is not
  called anywhere

BUG=678875

Review-Url: https://codereview.chromium.org/2619173002
Cr-Commit-Position: refs/heads/master@{#442801}

SubresourceIntegrity::CheckSubresourceIntegrity expects a non-null Document
which doesn't exist in workers. This CL replaces Document with
ExecutionContext.

BUG=678515
R=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2614813004
Cr-Commit-Position: refs/heads/master@{#442800}

A LayoutThemeDefault instance can be associated to a real
WebThemeEngine or a mock WebThemeEngine, which have different
metrics. We need to invalidate a cached value when a WebThemeEngine is
switched.

The bug affects only layout tests.

BUG=673754

Review-Url: https://codereview.chromium.org/2627773002
Cr-Commit-Position: refs/heads/master@{#442799}