- 19 Oct, 2017 40 commits
-
-
Alexander Alekseev authored
This CL adds NULL checks to BootTimesRecorder so that it won't crash on renderer crash. Bug: 768446 Change-Id: Ia5c6ef4d2963f6dbf71227a39486a9a5d4a0b1f6 Reviewed-on: https://chromium-review.googlesource.com/727192Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#510150}
-
Aleks Totic authored
Add LayoutNGBlockFlow::CachedLayoutResultForTesting method to enable fragment access from unit tests. # Reason for patch: Legacy has a fast layout code path that does not call LayoutNGBlockFlow::UpdateBlockLayout. This path updates overflow, and position of OOF descendants. Because of this, Legacy containers must know about all OOF descendants. Existing code did not let Legacy containers know about NG OOF descendants. This CL fixes this. # Unit tests problems. This patch will affect future webkit_unit_tests. NGBlockNode::Layout will DCHECK if done outside of the performLayout cycle if NGBlockNode has OOF descendants. The core cause is this: NGBlockNode::CopyFragmentToLegacyLayout calls LayoutBox::LayoutPositionedObjects. LayoutPositionedObjects asserts that View()->IsInPerformLayout() This patch fixes four existing failing tests. 1) NGBlockLayoutAlgorithmTest.CollapsingMarginsEmptyBlockWithClearance Fixed by inspecting LayoutObjects instead of fragments. 2) NGOutOfFlowLayoutPartTest.FixedInsideAbs Fixed by 3) NGOutOfFlowLayoutPartTest.OrthogonalWritingMode1 4) NGOutOfFlowLayoutPartTest.OrthogonalWritingMode2 Removed, code already covered by existing LayoutTests. Bug: 740993 Change-Id: I3a87ef5cdac883517bc3db33e0569668161ff806 Reviewed-on: https://chromium-review.googlesource.com/722760 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#510149}
-
Rob Buis authored
Seems this is not used (anymore). Change-Id: I3ac38799038231537d4fbc16428d1b523c7528b1 Reviewed-on: https://chromium-review.googlesource.com/728319Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#510148}
-
rnephew authored
Requires https://codereview.chromium.org/3008203003/ Bug: 723636 Change-Id: I3bda0037af48c78fd7b80912f4a84d0542a782e8 Reviewed-on: https://chromium-review.googlesource.com/655361 Commit-Queue: rnephew <rnephew@chromium.org> Reviewed-by:
rnephew <rnephew@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#510147}
-
wutao authored
The observers in scoped_layer_animation_settings, CacheRenderSurfaceObserver, DeferredPaintObserver, and TrilinearFilteringObserver, share the very similar pattern. This cl abstracts the observers and reduces the duplication of the code. Bug: 774332 Test: local builds works with caching and trilinear filtering. Change-Id: Idc4119d6ec680145c05161b504a7baf45080058b Reviewed-on: https://chromium-review.googlesource.com/724362Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#510146}
-
tzik authored
This CL contains: - Moves WTF::GetPtr overload for RefPtr to wtf/GetPtr.h, - Moves RefPtrValuePeeker to wtf/HashFunctions.h - Merges WTF::AdoptRef and base::AdoptRef. as a preparation of RefPtr.h removal. Bug: 763844 Change-Id: Iac2cfe6af0304ed4ea180f6ed50a08e9065672b9 Reviewed-on: https://chromium-review.googlesource.com/727683Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#510145}
-
Ian Vollick authored
Previously, we'd sorted along world-space z which provided a stable ordering given that the elements did not move in world space in a way that would upset the element ordering. However, with viewport-aware elements, this has now changed. With this change, we instead order the elements semantically. When we add effects which require sorting by depth (i.e., where elements dynamically change their ordering), we can augment UiRenderer::GetElementsInDrawOrder to account for the view vector. Currently, however, this is not required. Bug: 765460 Change-Id: If17a9b19b35ff6c1e998694f2677cb5c19170d96 Reviewed-on: https://chromium-review.googlesource.com/727342Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#510144}
-
Stephen Lanham authored
This test is flaking on the CQ. Disable it on desktop until we can assess the root cause. BUG= b/67975693 Bug: 67975693 Test: CQ Change-Id: I76ad684140460b10b819c45f77a75bff5a7fb935 Reviewed-on: https://chromium-review.googlesource.com/727076 Commit-Queue: Stephen Lanham <slan@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#510143}
-
Hidehiko Abe authored
This has two changes. - Remove gmock from document_scan_interface_chromeos_unittest. - Remove friend from the testee class. Instead, pass LorgnetteManagerClient via ctor. BUG=None TEST=Ran bots. Change-Id: I8bb910efb045ba6124fc0a42b70cd729e80c16bf Reviewed-on: https://chromium-review.googlesource.com/727504Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#510142}
-
Khushal authored
At the end of the catch up loop, we notify observers that the image is dirty and schedule a task for the next frame. The latter is unnecessary since when the image is repainted, it will call StartAnimation to tick itself at the end of the draw call. The original intent of the code was to catch up to the desired frame and synchronously draw it (see [1]). The assumption at the time was that since this draw will happen synchronously, there will be no StartAnimation call to schedule the next frame and it needed to be done immediately after the catch up loop. This is no longer true. We notify observers async after catching up and when they draw, we will get a StartAnimation call to tick the animation. So this additional bit of code is unnecessary complexity. [1]: https://bugs.webkit.org/show_bug.cgi?id=19663#c6 R=pdr@chromium.org Change-Id: If9684b9aa92dd69b5e3b87cadea5fc7582e4e7a4 Reviewed-on: https://chromium-review.googlesource.com/727198Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#510141}
-
Xiaocheng Hu authored
Bug: 699017 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I0ad635a08ffed1fdca4e370a320e12854e2ef227 Reviewed-on: https://chromium-review.googlesource.com/727406 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#510140}
-
tzik authored
scoped_refptr is allowed in Blink now, and WTF::RefPtr is an alias of scoped_refptr for migration. This CL inlines the alias to the RefPtr users in core/frame to remove RefPtr. Bug: 763844 Change-Id: I4cd5877a45c20aba61018c532b09336aa24050f7 Reviewed-on: https://chromium-review.googlesource.com/727447Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#510139}
-
Jinsong Fan authored
Bug: Change-Id: I39ab598aae721bdd8f88c0dd9b1668c45d7e0559 Reviewed-on: https://chromium-review.googlesource.com/727599Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#510138}
-
Becca Hughes authored
Creation of <div>'s is a repeated part of the media controls so this refactors it into a single function (there are more uses of the function coming). BUG=761305 Change-Id: If3530a416fd6f169100072899fbe3fcfb159155a Reviewed-on: https://chromium-review.googlesource.com/727897Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#510137}
-
Ben Chan authored
Bug: 776236 Change-Id: I41f84b07f6ebd28434897bb77edcc9254987ec1b Reviewed-on: https://chromium-review.googlesource.com/727024Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#510136}
-
Frank Henigman authored
https://chromium.googlesource.com/angle/angle.git/+log/d042fba..cbcb96f BUG=765919 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ie29f5ce96fd63f1c1f9c51a5646cfa5da12d17f6 Reviewed-on: https://chromium-review.googlesource.com/726756Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Frank Henigman <fjhenigman@chromium.org> Cr-Commit-Position: refs/heads/master@{#510135}
-
Changwan Ryu authored
This extends what we did for ChromeHome at https://chromium-review.googlesource.com/520712: when moving focus from an EditText to non-editable placeholder does not automatically hide keyboard, but restart input with TYPE_NULL, which results in a visual glitch such as flickering of number panel on keyboard app. This can be prevented by hiding soft input ourselves. BUG=708259 Change-Id: I05d3714202381e42af04b3fa4ed1bf4452908beb Reviewed-on: https://chromium-review.googlesource.com/728389Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#510134}
-
Raymond Toy authored
For low frequencies, use a 3-point or 5-point Lagrange interpolation scheme to improve the accuracy of the oscillator instead of using simple linear interpolation. For a typical context, the linear interpolator is used if the frequency >= 3.2 Hz; the 3-point, for 3.2 > frequency > 1.7 Hz; and the 5-point for all other cases. Thus, typical use-cases are not impaired by this change. Some benchmark results from running an oscillator for 1000 seconds in an offline context. This is the time measured from startRendering() until the promise is delivered. The SNR is the measured SNR between the test signal and a reference 440 Hz signal. The linear time was the same before and after this CL. linear: time: 1844.6 ms, stddev: 154.4 SNR: 27.7 dB 3-point: time: 2426.5 ms, stddev: 265.0 SNR: 37.2 dB 5-point: time: 2752.6 ms, stddev: 215.1 SNR: 59.3 dB 7-point (for reference, not used now): time: 3239.4 ms, stddev: 263.8 SNR: 82.5 dB Bug: 773507 Test: Oscillator/osc-440hz.html Change-Id: Ib49fab4fb27738f4f02bd41f8adcc2e3b2dd2137 Reviewed-on: https://chromium-review.googlesource.com/713576 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#510133}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/2713d6d5f30d..22e74ebb13a5 $ git log 2713d6d5f..22e74ebb1 --date=short --no-merges --format='%ad %ae %s' 2017-10-19 perezju [devil] Fix forwarder.py to work on newer psutil versions Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I051f3d3dd2a4fa73b0020b3d4f742492d5beba06 Reviewed-on: https://chromium-review.googlesource.com/727662 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#510132}
-
David Tseng authored
TBR=dtseng@chromium.org Bug: 773866 Original change Reviewed-on: https://chromium-review.googlesource.com/723606 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509911} Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1a1be30f3e430f2417ab3ff4b9733de1b8004077 Reviewed-on: https://chromium-review.googlesource.com/728302Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#510131}
-
Xiaocheng Hu authored
This patch adds LayoutNG alternatives of LayoutText::ContainsCaretOffset for both "common" LayoutText and ::first-letter LayoutTextFragments, with an extensive set of unit tests. Bug: 771398 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I59b17046c271bf8c5c1fb4fdf7421b37a3183073 Reviewed-on: https://chromium-review.googlesource.com/724262Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#510130}
-
Min Qin authored
Without network service, pausing a download is handled by DownloadRequestCore. It defers reading the response until download is resumed. With network service enabled, we can pause download by stopping reading from the data pipe. BUG=715630 Change-Id: I231d273828a82a401a9cd3d2773fd75a3166cfbd Reviewed-on: https://chromium-review.googlesource.com/726302 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#510129}
-
Weidong Guo authored
Changes: Change the role of app list folder to GENERIC_CONTAINER from BUTTON. BUG=776238 Change-Id: I3c0395678478c873e7328d1cb26bfe1d78043286 Reviewed-on: https://chromium-review.googlesource.com/727562Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#510128}
-
Will Chen authored
This fixes TestRunner.navigate(...) which is used by a handful of tests currently and will be needed by more because of the new test structure. This migrates debug-inlined-scripts-fragment-id.js to verify that this method works. Bug: 667560 Change-Id: I658736139aed90e20836cebea016f20ddfa8d9fb Reviewed-on: https://chromium-review.googlesource.com/727471Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#510127}
-
xdai authored
Otherwise |screen_orientation_| might not have the correct screen orientation. For example: - In landscape mode, enter overview mode, drag a window around but do not snap it. The phantom window should show on left/right side of the screen. - Rotate the device to portrait mode - Drag the window around again. The phantom window should show on the top/bottom side of the screen. But instead it still shows on left/right side of the screen. Bug: 725683 Change-Id: I3f4710648c5c8f988b8561af3fd6f46d62c6e429 Reviewed-on: https://chromium-review.googlesource.com/726273Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#510126}
-
Changwan Ryu authored
BUG=717658 Change-Id: Idcd6aa2367b82c132f50b41a69a67406ee367a5f Reviewed-on: https://chromium-review.googlesource.com/724861Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#510125}
-
Ria Jiang authored
Before this CL we were checking if the primary surface info is set for window->layer() to see if that window is a child surface. However, we were checking at the wrong layer and there's no clean way to get the layer that we actually set the primary surface info on. local_surface_id should be set only for child surfaces so checking if that is valid should be sufficient to determine whether a window is a child surface or not and get the value if necessary. Bug: 732395 Test: aura_unittests Change-Id: I29ba755392f294dbada7378ebb862e8ac844dfd7 Reviewed-on: https://chromium-review.googlesource.com/726843 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#510124}
-
Adithya Srinivasan authored
Inlines the cache check and value retrieval in LocalNameUpper. This appears to improve Node::nodeName by 6% in RuntimeCallStats. Bug: Change-Id: I0b96d6989365ed731f92750ed238d1d3adc9420d Reviewed-on: https://chromium-review.googlesource.com/721466 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#510123}
-
Xi Han authored
If |loggedIntentUrlParam| is in the AndroidManifest, we want to rewrite the URL to |start_url| appended with the original URL as a query parameter defined in |loggedIntentUrlParam|. The site for the WebAPK will know that the request is comming from a WebAPK, and doesn't redirect the url to a url which is out of the scope of the requested WebAPK. Otherwise, the url will be loaded in a CCT on top of the WebApkActivity. Bug: 775605 Change-Id: I6f24ea2c13c239812d2ba1d51d4898c1cd191856 Reviewed-on: https://chromium-review.googlesource.com/723846 Commit-Queue: Xi Han <hanxi@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#510122}
-
bsheedy authored
This adds TestVrShellDelegate, which extends VrShellDelegate and does two things: 1. Removes the need for @VisibleForTesting annotations in VrShellDelegate. 2. Allows us to have test-only code for VrShellDelegate without affecting production code if necessary. Bug: 775259 Change-Id: I1bb4beed2d88ba774a3fe28fa6799e0b8bee1113 Reviewed-on: https://chromium-review.googlesource.com/723769Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#510121}
-
Will Chen authored
This eliminates a lot of the code duplication between the new and legacy integration test frameworks by making cache-storage-test.js a small wrapper to load the new application_test_runner modules. This also ports a couple changes that were made in cache-storage.js and didn't get copied over. Bug: 667560 Change-Id: Idf2d025de175f51ab6aafb9b24bd730990cab95a Reviewed-on: https://chromium-review.googlesource.com/726890Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#510120}
-
Robert Sesek authored
The BTree leaf structure contains a length and embedded string. Check that the length of the embedded string is not larger than node containing the leaf. Bug: 776307 Test: Covered by fuzzer. Change-Id: I2c39c55b42da34bcc8cb26c481e269b66b19811d Reviewed-on: https://chromium-review.googlesource.com/728084Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#510119}
-
Ilya Nikolaevskiy authored
Metric reporting is in WebRTC in this CL: https://webrtc-review.googlesource.com/c/src/+/12260 Bug: webrtc:8355 Change-Id: I8e053a456f758940f76b1660e9c515ada909719c Reviewed-on: https://chromium-review.googlesource.com/727883Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#510118}
-
Helen Li authored
This CL adds an interface to allow consumers to subscribe/unsubscribe to network change events. - mojom::NetworkChangeManager Listens to net::NetworkChangeNotifier and propagate notifications to mojom::NetworkChangeManagerClient. NetworkService will have a pointer to the impl of this interface. - mojom::NetworkChangeManagerClient The implementation of this interface(content::NetworkConnectionTracker) receives notifications from mojom::NetworkChangeManager, and then sends those down to its observers. Design doc: https://docs.google.com/document/d/1kBp_vTIH-1Jx4M9DN7mnqRRyUmeHe3BZ1NqTbsJ4_S8/edit Bug: 754709 Change-Id: Ia98dc41da9bb618fd00adfd6412d70d839cd13bb Reviewed-on: https://chromium-review.googlesource.com/644352 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#510117}
-
Sergey Ulanov authored
The new backend reuses most of ALSA backend. There are two parts that are different: - Added new AudioOutputStreamFuchsia to be used instead of AudioOutputStreamAlsa. - Added stub for SystemVolumeControl. Bug: 772488 Change-Id: Icacb070323f30c3d7e6a50bd1f5cf5a58c4251f9 Reviewed-on: https://chromium-review.googlesource.com/722323 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
James Robinson <jamesr@chromium.org> Cr-Commit-Position: refs/heads/master@{#510116}
-
Scott Graham authored
Step 1 of ye ol' 7 step plan: https://chromium-review.googlesource.com/c/chromium/src/+/726314#message-4899c168cc8c4d3ec18d1442a7697fe9645ee185 Bug: 758256 Change-Id: I1002527dae80f0af3ac670914bf0c8b4d1dab6d9 Reviewed-on: https://chromium-review.googlesource.com/727140Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#510115}
-
Yuqian Li authored
Change-Id: Ic70101aa4d68e82dd77aaaa85a20dae95be39a08 Reviewed-on: https://chromium-review.googlesource.com/725820Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#510114}
-
James Cook authored
We get utility process crashes on Windows (via Crashpad) but we don't get them on Linux or Chrome OS (via Breakpad). Enable breakpad for utility processes as well. utility process, see crash uploader logging its upload attempt Bug: 776022 Test: run chrome --enable-crash-reporting-for-testing and crash the Change-Id: Iaaec05ab856bb1c2515e0798a7c2caf6adacc5d3 Reviewed-on: https://chromium-review.googlesource.com/726852Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#510113}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/17c3128d..ae262c24 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Iee0a4358765c7ec483cb0262bf82c1cf1b631ac8 Reviewed-on: https://chromium-review.googlesource.com/728179Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#510112}
-
Andrey Pronin authored
If owning a tpm was interrupted after TpmCanAttemptOwnership was issued but before the tpm was owned, the tpm could forever remain uninitialized. Re-issue the command on each boot if cryptohomed does not report that the tpm is ready to make sure the signal is not missed. The command is relatively cheap in any case - it launches an async thread that checks if all initializations are done, and performs only the missing stages. R=alemate@chromium.org Bug: b/66923649 Change-Id: I3be0c4c8ee8fd2c21ddab930346c1a1deb069135 Reviewed-on: https://chromium-review.googlesource.com/688763Reviewed-by:
Darren Krahn <dkrahn@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrey Pronin <apronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#510111}
-