- 08 Jun, 2018 40 commits
-
-
Max Moroz authored
https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/fda403cf93ec..873dc11d9a52 $ git log fda403cf9..873dc11d9 --date=short --no-merges --format='%ad %ae %s' 2018-06-07 kcc [libFuzzer] When printing NEW_FUNC, use 1-base indexing. 2018-06-07 phosek [Fuzzer] Update the header path for fdio/spawn.h on Fuchsia 2018-06-07 kcc [libFuzzer] make the corpus elements aware of their data flow traces 2018-06-06 kcc [libFuzzer] remove an experimental flag -use_feature_frequency 2018-06-06 phosek [Fuzzer] Use private libc++ even for Fuchsia 2018-06-06 phosek [CMake] Passthrough additional flags to custom libcxx CMake build 2018-06-06 ibiryukov Fix compile error with libstdc++. 2018-06-06 kcc [libFuzzer] initial implementation of -data_flow_trace. It parses the data flow trace and prints the summary, but doesn't use the information in any other way yet 2018-06-02 phosek [Fuzzer] Migrate Fuchsia port from launchpad to fdio_spawn 2018-05-31 kcc [libFuzzer] add collect_data_flow.py that allows to run the data-flow tracer several times on subsets of inputs bytes, to overcome DFSan out-of-label failures 2018-05-26 phosek [Fuzzer] Update _zx_port_wait function use in Fuchsia port 2018-05-24 george.karpenkov [libFuzzer] Run libFuzzer unit tests only on host architecture. 2018-05-24 kcc [libFuzzer] DataFlow tracer now tags a subset of the input. A separate script merges traces from the subsets 2018-05-23 kcc [libFuzzer] fix two off-by-ones (!!) in the data flow tracer 2018-05-23 kcc [libFuzzer] change the output format for the DataFlow tracer 2018-05-23 dor1s [libFuzzer] Don't complain about lack of interesting inputs when -runs=0. 2018-05-23 kcc [libFuzzer] modify -print_corpus_stats to print whether the input reaches the focus function 2018-05-21 kcc [libFuzzer] reinstate -dump_coverage, which is still in use (reverts r332036) 2018-05-16 kcc [libFuzzer] add an experimental flag -focus_function: libFuzzer will try to focus on inputs that trigger that function 2018-05-15 kcc [libFuzzer] deprecate equivalence_server 2018-05-11 kcc [libFuzzer] refactor the implementation of -print_coverage 2018-05-10 kcc [libFuzzer] remove the dump_coverage flag, it hasn't been working with the inline sanitizer coverage anyway 2018-05-10 kcc [libFuzzer] remove the experimental support for clang coverage instrumentation. This mode has not been used and our experiments with https://github.com/google/fuzzer-test-suite show that this signal is weaker than the SanitizerCoverage 2018-05-10 kcc [libFuzzer] Experimental data flow tracer for fuzz targets. 2018-05-10 kamil wrong usages of sem_open in the libFuzzer 2018-05-08 morehouse [libFuzzer] Guard symbolization with try-lock. 2018-05-02 morehouse [libFuzzer] Don't short-circuit from CrashCallback. 2018-05-01 morehouse [libFuzzer] Report at most one crash per input. 2018-04-24 delcypher [LibFuzzer] Tweak `MutationDispatcher::Mutate_CopyPart` mutation. Created with: roll-dep src/third_party/libFuzzer/src R=metzman@chromium.org Bug: 850742 Change-Id: I5f438e8d92f2021d61cdaab87de05d1a3784c22e Reviewed-on: https://chromium-review.googlesource.com/1092876Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#565754}
-
Mark Pearson authored
Don't run virtual/threaded/external/wpt/feature-policy/experimental-features/vertical-scroll-touch-block-manual.tentative.html on Windows. TBR=ekaramad NOTRY=true Bug: 850964 Change-Id: I613ec9919482aec151738b0350c951ece4b9531d Reviewed-on: https://chromium-review.googlesource.com/1093834 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#565753}
-
Shakti Sahu authored
The talkback doesn't announce the subsequent text updates to the infobar with the default infobar implementation. With this CL we are trying to fix that. Bug: 848135 Change-Id: I49c671fee841026129ed244df420e5e1fc25e75b Reviewed-on: https://chromium-review.googlesource.com/1087759Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#565752}
-
Quinten Yearsley authored
When update_expectations.py is run, it outputs a suggested CL description, including bug numbers. This CL changes the output to stop repeating bug numbers. Change-Id: Iabe10680f07b28832e7336ceb2105a1db03eaa80 Reviewed-on: https://chromium-review.googlesource.com/1089293 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#565751}
-
Rayan Kanso authored
Bug: 826257 Change-Id: I8e4cc29d2c2bda04093820b1054a999e46738b9d Reviewed-on: https://chromium-review.googlesource.com/1092733 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#565750}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I128d5e197dc1a70c03f8831d1ffea01e5c86580c Reviewed-on: https://chromium-review.googlesource.com/1093462 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565749}
-
Samuel Huang authored
This reverts commit d3362371. Reason for revert: net_unittests fixed itself. Original change's description: > Revert "Fix //ios/web_view/tools/build.py to reflect new build flags." > > This reverts commit a717720f. > > Reason for revert: Speculative revert to fix net_unittests failure for Mac bots. > > Original change's description: > > Fix //ios/web_view/tools/build.py to reflect new build flags. > > > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > > Change-Id: I79b509fc63a011a8dcdfcf040ef694fc4a2170f8 > > Reviewed-on: https://chromium-review.googlesource.com/1092074 > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Commit-Queue: John Wu <jzw@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#565691} > > TBR=eugenebut@chromium.org,jzw@chromium.org > > Change-Id: Ia5257e274d77be6f3582d972f0d56cd034a6f83b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Reviewed-on: https://chromium-review.googlesource.com/1093479 > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565734} TBR=huangs@chromium.org,eugenebut@chromium.org,jzw@chromium.org Change-Id: I75fcf95c3a7393d57d7fe747f01c2237111c1ec4 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1093794Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#565748}
-
Sky Malice authored
Bug: 831648 Change-Id: Ica8042c3d6fe629aabc24613e207ebbbf0a006f7 Reviewed-on: https://chromium-review.googlesource.com/1091698 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#565747}
-
Vaclav Brozek authored
base/logging.h is a project file, not system file, so should get parentheses around, not angle brackets. This CL fixes that. TBR=dvadym@chromium.org Bug: 831123 Change-Id: I8ccb4d8a91b15f5f74db9b968c543b4904066c1b Reviewed-on: https://chromium-review.googlesource.com/1093320Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565746}
-
Jun Choi authored
Remove U2fSign and U2fRequest and migrate all U2F sign request logic to U2fSignOperation within GetAssertionTask. With this migration, all error handling for incorrect parameters, invalid credentials, and unsupported algorithms are now handled by GetAssertionTask and removed from AuthenticatorImpl. Also content feature flag features::kWebAuthCtap2 is removed and feature flag device::kNewCtap2Device under device/base is used to gate U2F/CTAP logic. Bug: 798573 Change-Id: I009e6e34b251308f1f5eb3a99d8c5b7b7001bae9 Reviewed-on: https://chromium-review.googlesource.com/1070707 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#565745}
-
Troy Hildebrandt authored
Brings back the original select all focus behaviour on omnibox focus when displaying search terms. Bug:851087 Change-Id: Ieddc96747e30b7002b150791bbcff54c70228c30 Reviewed-on: https://chromium-review.googlesource.com/1093421 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#565744}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id52bdcbaaa68d970fd04824df181d47efcee5168 Reviewed-on: https://chromium-review.googlesource.com/1093153 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#565743}
-
Jun Choi authored
As DeviceOperation is templated with request and request, we can subsume all logic in CtapRegisterOperation and same corresponding logic for CtapGetAssertion to DeviceOperation. Remove CtapRegisterOperation and add logic for dispatching request/ receiving response in DeviceOperation interface. Bug: 798573 Change-Id: I38a36ce53149a473736c0c1dbc0a4c7b65ea130b Reviewed-on: https://chromium-review.googlesource.com/1034387 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#565742}
-
Jun Choi authored
Replace all old expectation function calls for tests in u2f_register_operation_unittests.cc file. Note: As legacy old in u2f_sign_unittest.cc still uses the old API, we keep the old API and remove it once U2F sign logic is migrated to GetAssertionTask. Bug: 843788 Change-Id: I60ba3a47361a95f82fe173fdbab9d9bb4d29e3e4 Reviewed-on: https://chromium-review.googlesource.com/1069784 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#565741}
-
Hajime Hoshi authored
This CL also move some implementations to WorkerThreadScheduler. Change-Id: I7825666c54bc04737f8b907ed0da6913a7148447 Reviewed-on: https://chromium-review.googlesource.com/1092625 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565740}
-
kylechar authored
Use base::TimeTicks instead of base::Time for calculating the time difference between crashes. base::Time can produce a negative delta, which could make the crash count bigger instead of smaller. Forgive crashes quicker for when the GPU process running only the display compositor. The consequences of hitting kGpuMaxCrashCount is more severe for this case since it crashes the browser process. I think users would rather occasional flicker from GPU crashes to browser crashes. Try forgiving one GPU process crash every 10 minutes in this case. For hardware accelerated or SwiftShader GPU process crashes leave the forgiveness time unchanged at 60 minutes. Bug: 849639 Change-Id: Idc2f4d7c7b0c31d4090a36d3bd11a8f005baa5d1 Reviewed-on: https://chromium-review.googlesource.com/1093013Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#565739}
-
Mark Pearson authored
Disables virtual/reporting-api/external/wpt/content-security-policy/reporting-api/reporting-api-doesnt-send-reports-without-violation.https.sub.html TBR=andypaicu NOTRY=true Bug: 850170 Change-Id: I3b2c5d73152ef72a13fd6e3e2efb2337f2b66d5a Reviewed-on: https://chromium-review.googlesource.com/1093654 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#565738}
-
Jun Choi authored
Make CTAP MakeCredential request be backwards compatible with U2F devices. Remove u2f_register.h file and migrate all U2F register logic to DeviceRegisterOperation under MakeCredential{Handler, Task} infrastructure. With this change, all input and output validation for MakeCredential and U2F Register request are moved from AuthenticatorImpl to MakeCredentialTask. Bug: 798573 Change-Id: I896a2cd0d119f9f63aaf4ab9eed16792d9c1f1bf Reviewed-on: https://chromium-review.googlesource.com/1027202 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#565737}
-
Mark Pearson authored
TBR=chcunningham NOTRY=true Bug: 849979 Change-Id: Idcce1c5a044fb48001909ad48860ba1777bf8975 Reviewed-on: https://chromium-review.googlesource.com/1093469 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#565736}
-
Erik Chen authored
The mapping was added in https://codereview.chromium.org/3011002. There was no reason for it to use a character rather than a virtual keycode. After a recent refactor, this logic caused cmd + c to trigger IDC_DEV_TOOLS_INSPECT, since the shift key is ignored for character comparisons. Bug: 846893, 850895 Change-Id: Ic74e418bd9fa55eda90dd3bd55b10a456abce581 Reviewed-on: https://chromium-review.googlesource.com/1093301 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#565735}
-
Samuel Huang authored
This reverts commit a717720f. Reason for revert: Speculative revert to fix net_unittests failure for Mac bots. Original change's description: > Fix //ios/web_view/tools/build.py to reflect new build flags. > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I79b509fc63a011a8dcdfcf040ef694fc4a2170f8 > Reviewed-on: https://chromium-review.googlesource.com/1092074 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: John Wu <jzw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565691} TBR=eugenebut@chromium.org,jzw@chromium.org Change-Id: Ia5257e274d77be6f3582d972f0d56cd034a6f83b No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1093479Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#565734}
-
Mark Pearson authored
Mark four tests as disabled: virtual/threaded/http/tests/devtools/tracing/timeline-time/timeline-usertiming.js virtual/threaded/http/tests/devtools/tracing/timeline-paint/timeline-paint-and-multiple-style-invalidations.js http/tests/devtools/tracing/timeline-js/timeline-script-id.js due to flake here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/69598 virtual/threaded/http/tests/devtools/tracing/timeline-misc/ imeline-event-causes.js due to flake here: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/16773 NOTRY=true TBR=kozyatinskiy@chromium.org Bug: 850892 Change-Id: I6918161001cd3c4fd537476406d0ff66183096f4 Reviewed-on: https://chromium-review.googlesource.com/1093456 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#565733}
-
Mark Pearson authored
Disables SingleClientDirectorySyncTest.DeleteDirectoryWhenCorrupted due to repeated flakes on Mac. TBR=treib Bug: 850980 Change-Id: I0906849dd03a2ce0a6fa007de10036519b502958 Reviewed-on: https://chromium-review.googlesource.com/1093548Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#565732}
-
Dave Tapuska authored
Microsoft has confirmed there are some issues with InputPane on earlier versions before RS4. BUG=817501 Change-Id: Ifa4557ecf479e10d619a6353e28c4f8eb3684867 Reviewed-on: https://chromium-review.googlesource.com/1093266Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#565731}
-
Kevin Marshall authored
Component manifests (*.cmx) are a new type of package metadata that will eventually consolidate most existing package metadata sources into one JSON file. Sandbox policies are now parsed by the cmx manifest parser. This CL migrates our sandbox policies from standalone files to inline CMX content. Change-Id: I4ac57a979811000d09eb90229ba5e97a03cb15be Reviewed-on: https://chromium-review.googlesource.com/1093396Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#565730}
-
Devlin Cronin authored
Remove the per-file histogram_tester OWNERS rules from //base/test/OWNERS, since histogram_tester* now lives in //base/test/metrics (which has a dedicated OWNERS file). Bug: 846421 Change-Id: I0d9a44379e48b8b5a50c242f13bba56b429d3020 Reviewed-on: https://chromium-review.googlesource.com/1091597 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#565729}
-
Xiaoqian Dai authored
In tablet mode, when a window is newly created, TabletModeWindowState will try to maximize it upon its creation. We should not do it for a window that's currently in tab-dragging process. The window will be maximized or snapped later by SplitViewController when the drag ends. See before: https://drive.google.com/open?id=1AcD3VG6C7aFXwdi1Cq3-RGvkg4U3K5ME and after: https://drive.google.com/open?id=1UoTIkeG50Bv0w0NQKWtEhbD3frfp7Vd8 Bug: 823769 Change-Id: I393fc57ef8cfe2c767512a5ad7a8f181bc36c835 Reviewed-on: https://chromium-review.googlesource.com/1089729 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#565728}
-
Samuel Huang authored
TBR=thestig@chromium.org NOTRY=true Bug: 851090 Change-Id: Ic7af45ee47f5beb60f2e919034619b11433822e5 Reviewed-on: https://chromium-review.googlesource.com/1093655 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#565727}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c971895..eca23c3 git log c971895..eca23c3 --date=short --no-merges --format='%ad %ae %s' 2018-06-08 benjhayden@chromium.org Allow controlling dev dashboard version with environ variable. 2018-06-08 perezju@chromium.org [soundwave] Ensure API and DB are always initialized 2018-06-08 nednguyen@google.com Revert "Add deprecation message for grouping_keys" Created with: gclient setdep -r src/third_party/catapult@eca23c3 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849363 TBR=sullivan@chromium.org Change-Id: Id60e3bb0d986359efdd4252cce4f5ff9e583d839 Reviewed-on: https://chromium-review.googlesource.com/1093454Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565726}
-
Ryan Sturm authored
PLM tracks pages as new page main frame navigations, the page load capping infobar should match this behavior exactly to keep consistency between the two approaches. This may allow better understanding of what a page load actually is when the infobar is showing. Bug: 850988 Change-Id: I339f9000088731d807b4db973220c805cf4d3e3b Reviewed-on: https://chromium-review.googlesource.com/1093191 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#565725}
-
dpapad authored
These pages do not seem to be using that dependency, so it's unnecassary. This is in preparation of disallowing eval/Function for all WebUI pages that don't need it (and jstemplate_compiled.js implies that Function is needed). Pages affected: chrome://devices chrome://dom-distiller chrome://predictors chrome://webrtc-logs Also removing such dependency from the "Feedback" component extension. Bug: 525224 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I31728d2b3323f860c6b65455b0c72873981c4805 Reviewed-on: https://chromium-review.googlesource.com/1088157Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#565724}
-
Tommy C. Li authored
Previously they were 24x24. But in the new Material Refresh spec, they take up 32x24. Bug: 849779, 823535 Change-Id: Ie1f5dfe9e9f2ae88bcf07643fb6b33f6472bdcdf Reviewed-on: https://chromium-review.googlesource.com/1090073Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#565723}
-
Nico Weber authored
These bots used to be on FYI, but they're on the clang waterfall now (and also listed for that waterfall in waterfalls.pyl) Bug: 843511 Change-Id: I5ee01813e2701e1346edb05bbb5d3bae723b9b96 Reviewed-on: https://chromium-review.googlesource.com/1093555 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565722}
-
Jiaquan He authored
This commit: - removes some TODOs; - uses kGridIconDimension in ash/public/cpp/app_list/app_list_constants.h; - passes a trimmed query string over mojom for searching, since it's smaller and the raw query string in Chrome was only needed by search history, which has been removed. Bug: 733662 Change-Id: I2f8e7f5294079b4a9ac0141384502cc7dda1a806 Reviewed-on: https://chromium-review.googlesource.com/1093388 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#565721}
-
jdoerrie authored
This change partially reverts r550197 which introduced CHECKs to base::Optional's operator*, operator-> and value(). This is done to reduce binary size and to be more standard's compliant, as std::optional also doesn't perform checks for operator* and operator->. Lastly, the CHECKs in value() are kept, as here CHECKing is desired, and also matches std::optional's behaviour. Bug: 832678 Change-Id: I467c7d7623c2880ee761b8a58a74738c09e0ba2a Reviewed-on: https://chromium-review.googlesource.com/1093314Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#565720}
-
Sorin Jianu authored
This change introduces new error codes for these responses. Bug: 850720 Change-Id: I85462e964a573bf310b7b0ae5e9180e2e87eafdc Reviewed-on: https://chromium-review.googlesource.com/1091876Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565719}
-
Lei Tian authored
This CL fixes Browser Actions bugs includes: 1. Change download menu text to "Download link". 2. Fix flaky test. Bug: 773073, 831306 Change-Id: I4f2bc4d9288c2d96b7d878eb80ac0802e8065fe3 Reviewed-on: https://chromium-review.googlesource.com/1091875Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Lei Tian <ltian@chromium.org> Cr-Commit-Position: refs/heads/master@{#565718}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e4d73cb..7a01ce9 git log e4d73cb..7a01ce9 --date=short --no-merges --format='%ad %ae %s' 2018-06-08 tsepez@chromium.org Update fxjs/README now that context data slots are gone 2018-06-08 thestig@chromium.org Use FPDFText_GetBoundedText() to get the visible text in a test. 2018-06-08 thestig@chromium.org Consolidate repeated constants in FPDFTextEmbeddertest. Created with: gclient setdep -r src/third_party/pdfium@7a01ce9 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0a02663ad82b0e535c211aa2b792110edcf16b9a Reviewed-on: https://chromium-review.googlesource.com/1093274Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565717}
-
Xiaohan Wang authored
This allows KeySystemConfigSelectorTest to fully depend on the FakeKeySystems. Previously KeySystemConfigSelector calls CanUseAesDecryptor() which calls into KeySystemsImpl which makes the test really confusing. Bug: 727948 Change-Id: Id5536a142285034f1ec589758a171c70d3a77153 Reviewed-on: https://chromium-review.googlesource.com/1092412Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#565716}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8e6f58c..e05f18d git log 8e6f58c..e05f18d --date=short --no-merges --format='%ad %ae %s' 2018-06-08 ehmaldonado@chromium.org Reland "Reland "Expand variables in gclient flattened output."" Created with: gclient setdep -r src/third_party/depot_tools@e05f18d The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:848990 TBR=agable@chromium.org Change-Id: I348ead5c56b9fc1a54cc4b082d318d1d35bc7b21 Reviewed-on: https://chromium-review.googlesource.com/1093275Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565715}
-