- 04 Feb, 2020 38 commits
-
-
Xianzhu Wang authored
Previously multiple consecutive self-painting layers with the same property tree state were in the same paint chunk causing the layers to be "merged" too early. Now force paint chunk for self-paint layers so that PaintArtifactCompositor can see them and do proper overlap testing and merge for them. compositing/layer-creation/overlap-transformed-3d.html is an example that previous lacking of separate paint chunks caused unnecessary extra composited layers. Change-Id: I080fe36528c3d05c47158931560e028a1bab617b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029127Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738032}
-
Toni Barzic authored
When shutting down overview session, make sure the OverviewModeFocusedWidget is hidden (and deactivated), to prevent it from handling key pressed events (when the overview session is active, key press events are handled by OverviewSession before they get dispatched to the active window). Without this, the OverviewModeFocusedWidget might end up handling tab key event, and cause a crash when the focus manager attempts to find the next focusable view within an childless widget. BUG=1033972 Change-Id: I0b817cb5784b6ffd79d5a4b011a233cd410863c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036258Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#738031}
-
Dale Curtis authored
In the event a ended event occurs before a timeupdate event, the next timeupdate event would retrigger the seek step. So cleanup all test advancement listeners during calls to SeekTestStep(). Also, enable console logs on Android by toggling the necessary base::Feature to help debugging these flakes in the field. Also, fix "undefined undefined" from showing up in console logs when the video size information shows up. As a result of this the way size tests are completed has been reimplemented to avoid an extraneous title step. R=jrummell Change-Id: Ia3799eb4b16583ad3a8751f67e6e33cf0c5d5d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036365 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#738030}
-
Julian Watson authored
If the policy is disabled, the user still needs a way to cleanup the vm from their disk. This change allows them access to the plugin vm subpage as long as either the policy is enabled, or there is a vm on disk. Note: It is not enough to simply delete the vm for the user, as the policy change could be accidental or temporary. Bug: 1023256 Change-Id: Id1cfae86061c8f7e1a0b771165833e412009edbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026511 Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#738029}
-
Sophie Chang authored
Change-Id: I1e8ea40a585589bf0ec3781897b498dd94a28d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028260Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#738028}
-
Trent Begin authored
Add plumbing to request timezone information from cros healthd and add it to the DeviceStatusCollector. Bug: chromium:1030361 Test: ./out/Default/browser_tests --gtest_filter=DeviceStatus* Change-Id: Ibdf44881d9cd02f8d9ed3bf56fc5f22231af674f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026192 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#738027}
-
David Black authored
In standalone UI, stylus was both an entry point as well as an input modality. In embedded UI, stylus is only an entry point. Removing the now unused input modality. Bug: b:148080975 Change-Id: I4a86a63a221dc4d5648215c720c17fa547f6fc76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036435Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#738026}
-
Tanya Gupta authored
Bug: 1046574 Change-Id: I083378139b51485ed632b5e911bd8487db962e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026254Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tanya Gupta <tgupta@google.com> Cr-Commit-Position: refs/heads/master@{#738025}
-
Peter Boström authored
This aligns views' platform style on ChromeOS with WebUI and Material. Bug: chromium:849549 Change-Id: If63603310e5ee7219cb76fa8d82c27ef9f853cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036890 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#738024}
-
Sorin Jianu authored
chromium-review.googlesource.com/c/chromium/src/+/2018150 introduced a unit test dependency on chrome/common, which breaks gn check: c:\src\chromium\src>gn check out\Default chrome/updater/* ERROR at //chrome/updater/run_all_unittests.cc:8:11: Can't include this header from here. #include "chrome/common/chrome_paths.h" ^--------------------------- The target: //chrome/updater:updater_tests is including a file from the target: //chrome/common:constants Bug: 1031552 Change-Id: I03c62163df096a5a6ab89acc290b61238844b299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036370 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#738023}
-
Daniel Rubery authored
One of the considerations for whether to send download pings for a given file type is how often that file type is downloaded, as recorded by SBClientDownload.DownloadExtensions. But we also send download pings for archives containing dangerous file types, so we should record how often that is occurring as well. This CL adds a metric to do that. Bug: 1048215 Change-Id: If897244cf5954844ac51e0ce86bafb89a17a26e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036210Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#738022}
-
Raymond Toy authored
Make sure all users of an input bus increment the ref count by using scoped_refptr instead of a raw pointer to the bus so that lifetime is managed correctly. We only handle the input bus in this CL. Bug: 1040246 Change-Id: Ib93299da51e6eafbf9a7d0e433e1beea8fe9c266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958616 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738021}
-
Peter Boström authored
This helps contrast and it's important for these labels to be easily readable and understandable. Bug: chromium:943702 Change-Id: I6aabfc008b0045c5a033273ac33098e344827eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036894 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#738020}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2181228624d1..3fa2b80e14fa git log 2181228624d1..3fa2b80e14fa --date=short --first-parent --format='%ad %ae %s' 2020-02-03 steveanton@webrtc.org AsyncTCPSocket: try sending outgoing data until EWOULDBLOCK Created with: gclient setdep -r src/third_party/webrtc@3fa2b80e14fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9f7ed0af06dbb7612b7c42e0bdc827da6cb667a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738019}
-
Lei Zhang authored
Headers do not needed to be repeated in the public and sources sections. Change-Id: Id308f418cf1a9e74f7e57c59bc4ef9898d440b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036260Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#738018}
-
Demetrios Papadopoulos authored
Specifically removing: - cr.define wrapper - registerDialogTests - registerSearchEngineEntryTests, - registerOmniboxExtensionEntryTests, - registerPageTests In preparation of migrating to Polymer 3. Bug: 1026426 Change-Id: Ida9a6a4201f970d20475a0a5861702c6e5531eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036637 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#738017}
-
Klaus Weidner authored
https://github.com/immersive-web/dom-overlays/issues/12 Bug: 991747 Change-Id: Iab360d76c947048bc6650674587f3bcc95a8d4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036514Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#738016}
-
David Black authored
Bug: b:148080975 Change-Id: I5553e75f42bc8d4d08cba33cc8dce9f164306f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036395Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/69bb8bef75ff..e4d329cc0082 git log 69bb8bef75ff..e4d329cc0082 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 ehmaldonado@google.com presubmit_support: Add support for setting the change description. Created with: gclient setdep -r src/third_party/depot_tools@e4d329cc0082 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042324 Tbr: agable@chromium.org Change-Id: I0e06f545262de52a608ec94f675373170b5c9a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036780Reviewed-by:
-
Becca Hughes authored
Merge media engagement fields into origin table since it will be faster. BUG=1024359 Change-Id: Icdb8cb9e9f7ea2965565c9157f4826110da60c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036779Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#738013}
-
Lucas Furukawa Gadani authored
Bug: 1045567 Change-Id: Ie8e18e211552a3b1a7259a689136e8fd2e1e8732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028295Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#738012}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7a968e640c5c..aae8a22141d0 Created with: gclient setdep -r src-internal@aae8a22141d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:1026060,chromium:1047530 Tbr: jbudorick@google.com Change-Id: I6aa774e7541012c1a8f00a88bd2627ef99579333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036783Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738011}
-
Sammie Quon authored
Inkdrop highlights are normal created by painting a texture using a layer delegate into a certain shape. In most cases, this shape matches the shape provided by the ink drop mask/clip, so a solid color layer would achieve the same results, and is cheaper. Test: manual Bug: 1042303 Change-Id: I1919a0a4ab651581fa4001e9b6086f9be13c2ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036112 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#738010}
-
Ben Pastene authored
Most bots' xcode were upgraded to 11c29 in crrev.com/c/2028249. However, we tell swarming to persist only the xcode located in 11a1027, so the new xcode located in 11c29 isn't getting persisted. Consequently every build does a fresh download of xcode, which leads to a 20+ min download time: https://luci-milo.appspot.com/p/chromium/builders/try/ios-simulator/473405 This should fix that. Bug: 1048301, 1041618 Change-Id: Ie610497b6c40edb66021fa7fe55676cbf96fb8f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036443 Auto-Submit: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#738009}
-
Lukasz Anforowicz authored
This CL removes 1) ChromeExtensionsRendererClient::ShouldFork (and as a consequence the ContentRendererClient::ShouldFork) as well as 2) the file-based ShouldFork considerations from RenderFrameImpl::BeginNavigation. Looking at git history, this CL is a combination of: - a reland of r700364+r705362 (~revert of the revert from r719751) - a partial reland of r705329 (~revert of the revert from r731108) The reland should be okay now, given that https://crbug.com/1027719 and https://crbug.com/1042271 have been addressed. Bug: 883549 Tbr: Egor Pasko <pasko@chromium.org> Tbr: Tarun Bansal <tbansal@chromium.org> Tbr: Devlin <rdevlin.cronin@chromium.org> Tbr: Alex Moshchuk <alexmos@chromium.org> Change-Id: Ib0bb7175eae2cb4d95c073264155f1f7d154769b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949448 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#738008}
-
James Cook authored
SplitSettingsSync will allow the user to opt-out of browser sync. However, IdentityAccessor::GetPrimaryAccountInfo() assumes the user has consented to browser sync. Multidevice features aren't tied to browser sync consent. Switch to using the "unconsented" primary account. On Chrome OS this account always exists for the logged-in user account, whether or not the user consented to browser sync. See go/cros-sync-mock and go/cros-primary-account for details. no errors in chrome://proximity-auth SplitSettingsSync, no errors in chrome://proximity-auth Bug: 1042400 Test: Multidevice setup works for new account with SplitSettingsSync, Test: Multidevice settings work for existing account with Test: updated chromeos_unittests Change-Id: I53171f3ba6a308c1af0da7a1092254e06f679bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036786Reviewed-by:
-
Becca Hughes authored
Fix crash in WebUI caused by mojo. Fixes: 1048314 Change-Id: I642dfd7a427ff32f09c889540fdd3cea62100ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036653Reviewed-by:
-
Matt Mueller authored
Bug: 1040681 Change-Id: Iaadc7d1b99668c8287eab5a181838f744f767e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036271 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#738005}
-
Gyuyoung Kim authored
This CL migrate the legacy ResetDone IPC message to the new Mojo in BlinkTestClient interface. This CL adds a |is_secondary_window_| flag to WebTestRenderFrameObserver to avoid calling ResetDone twice when a secondary window exists. Then, it's passed to BlinkTestRunner::DidCommitNavigationInMainFrame to avoid calling ResetDone twice. Because twice calls of ResetDone can cause a crash during the web test. Bug: 1039247 Change-Id: Ia992616449ec54d1e28d2a6804f907cfac404cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009595Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#738004}
-
Jamie Walch authored
The DesktopCapturer implementation used by ClientSession on Windows uses read-only shared memory, and so the mouse cursor composition needs to be done by the DesktopSessionAgent instead. This CL refactors that logic so that it can be used in both places, cleans up some raw pointer ugliness, and adds support for compositing the mouse cursor on Windows when pointer lock is active. Bug: 1047908 Change-Id: Ic21a750379a8f144227d662cce200cdc95ce3967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034104 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#738003}
-
Stephen McGruer authored
Test was updated upstream, and Chrome should now pass. Bug: None Change-Id: I298a452a93bb6e8280edcc570058478e719a93de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035300 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#738002}
-
Fritz Koenig authored
This reverts commit 4efc495c. Reason for revert: Driver was fixed so this is no longer an issue. Original change's description: > webgl: gpu workaround to turn off MSAA > > PowerVR.*GX6250 gpu is producing artifacts when > rendering with a context that has antialias set true. > > Bug: 1038671, b:148280161 > Change-Id: I79081f342bac2531e9d6d43a57939e3c5f8fc0e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019939 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Kentaro Hara <haraken@chromium.org> > Auto-Submit: Fritz Koenig <frkoenig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735217} TBR=frkoenig@chromium.org,kbr@chromium.org,haraken@chromium.org Bug: 1038671, b:148280161 Change-Id: I2e3ace6578fc90b26b5f180f388a6c80f56a0f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036400 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#738001}
-
Patrick Monette authored
The PerformanceManagerTabHelper reflects WebContents and their frame trees into the PerformanceManager graph. This CL gives the graph visibility for the WebContents created by ChromeWebDialogView. Bug: 1046881 Change-Id: I0b60996a1883a3be5f85f505576e1618ad347061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036479Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#738000}
-
Mingjing Zhang authored
This CL breaks CompositorLatency.*.StartDrawToSwapEnd into CompositorLatency.*.StartDrawToSwapStart and CompositorLatency.*. SwapStartToSwapEnd for better consumption of the metrics. Bug: 1027014 Change-Id: Id0428933ea76910d6dfc7e37150c878bfd678dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020524Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#737999}
-
Kenichi Ishibashi authored
Before this CL, WriteToDiskCacheAsync() synchronously returned ServiceWorkerDatabase::ResourceRecord even its internal operations were asynchornously done. This behavior is undesirable because we want to make resource ID assignment async but creating ResourceRecord requires a new ID. This CL make WriteToDiskCacheAsync() return ResourceRecord asynchornously. A subsequent CL will remove |resource_id| argument from the function and assign an ID inside the function. Bug: 1046335 Change-Id: Id44e39db0b5912235c19d31198763036e922cbf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029561 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737998}
-
James Cook authored
A change for supervised users added a JS-to-C++ validation step when closing the dialog, but the tests were not always waiting for the appropriate browser proxy calls. Bug: 1043598 Change-Id: I1f6ec812526a4e8f08427ce1b5605ea5c4340ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036358Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#737997}
-
Darwin Huang authored
Remove ClipboardPromise::system_clipboard(), which was added in https://crrev.com/c/1877532, but doesn't seem to be called at all. Refactoring change, with no functional changes intended. Change-Id: Ie63574cb279e3df1c05b3446202085b72e1a455f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033976 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#737996}
-
Avi Drissman authored
Bug: 1022821 Change-Id: Id8871a38ea429db3efb1a1f7305eb9e3072f9efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036357 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#737995}
-
- 03 Feb, 2020 2 commits
-
-
Noel Gordon authored
The <dialog> element added in CL:2033012 is too dark. We should restyle its CSS ::backdrop property in quick-view.css to lighten it up dialog#delete-confirm-dialog::backdrop { ... } Add TODO item for that task. Tbr: alex Bug: 803259 Change-Id: Id8f2408f6d9d6cc02f612e1794a52e54dcd2351d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035493 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737994}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/664c5603593f..5bbc191e0e57 git log 664c5603593f..5bbc191e0e57 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 janscheffler@chromium.org Add reset columns to DataGrid Created with: gclient setdep -r src/third_party/devtools-frontend/src@5bbc191e0e57 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1043803 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I217aba7a35c040a59c8e0af1ae8ec30d3f5540df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036770Reviewed-by:
-
