- 25 Sep, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c712e962b647..1585d7e108ef git log c712e962b647..1585d7e108ef --date=short --no-merges --format='%ad %ae %s' 2019-09-25 mtklein@google.com opt skottie_tool into thread-local strike caches 2019-09-25 robertphillips@google.com Split out check_base_readbacks sub-test in BackendAllocation tests 2019-09-25 mtklein@google.com dump frame time stats in skottie_tool 2019-09-25 brianosman@google.com Particles: Added particle flags for tracking state (one-time triggers, etc) Created with: gclient setdep -r src/third_party/skia@1585d7e108ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: I20a9e0a794b78a88a2f2c898b067717d4c689c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825682Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699920}
-
James Cook authored
It needs to be wide enough to show the magnifying glass, since the horizontal scroll bar doesn't affect the header. Bump from 200px to 300px. I missed this in: https://chromium-review.googlesource.com/c/chromium/src/+/1815905 TBR=ortuno@chromium.org Bug: 1001466 Change-Id: I12e63b8e86cc72241a9d6b51d0f4933d94e6bbba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825470Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#699919}
-
James Cook authored
Show the temperature and schedule controls after the user toggles the feature on. Off state: http://screen/NK2AKv3TTBJ On state: http://screen/e1cehFw9nV3 Add a little bit of padding at the bottom of the sub-page when Night Light is disabled such that when the user enables Night Light they can see that there are more controls below. Bug: 1000683 Test: added to browser_tests Change-Id: I31a68362f8452178fda96a8fac783c7c6e600495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825659 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#699918}
-
Sven Zheng authored
When testing against external servers with prod gaia account, we need to make sure the account is in clean status. To do this, we clean the test account by sending a CLEAR_SERVER_DATA message before running test case code. TEST: sync_integration_tests.exe --gtest_filter=TwoClientTypedUrlsSyncTest.SyncTypedRedirects_E2ETest --sync-url=https://clients4.google.com/chrome-sync/dev --sync-url-clear-server-data=https://clients4.google.com/chrome-sync/dev --sync-user-for-test=<test account email> --sync-password-for-test=<password> --enable-pixel-output-in-tests --gtest_repeat=2 With this change, the test will pass. Without this change, the test will pass and then fail on second time. It's because the account is 'dirty' when running second time. The above command can only be run for googlers, and please ask me for user/password if you need. Bug: 992143 Change-Id: I0339e905c0b34be8eb6d109671590ba26bd0b5f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814687 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#699917}
-
John Chen authored
Disable the following flaky tests on Linux and Mac perf bots: * system_health.common_desktop/multitab:misc:typical24 * system_health.common_desktop/multitab:misc:typical24:2018 * system_health.memory_desktop/multitab:misc:typical24:2018 * tab_switching.typical_25/multitab:misc:typical24 TBR=crouleau@chromium.org NOTRY=true Bug: 1008093 Change-Id: I7e88ae7325d8858fe6e9c3d376ce2c295af11dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825161Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#699916}
-
Nicolò Mazzucato authored
The tracing categories have been added to the DataSourceDescriptor, so that is possible to retrieve them through the ConsumerPort. Change-Id: I779c8ebcb20028e2707ff9a29a14a5749ab07896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814357 Commit-Queue: Nicolò Mazzucato <nicomazz@google.com> Auto-Submit: Nicolò Mazzucato <nicomazz@google.com> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#699915}
-
Chris Lu authored
There is no need for ViewportAdjustmentExperiment since the only experiment remaining is just the kSmoothScrollingDefault feature flag. GetActiveViewportExperiment() can just be a function that returns whether or not smooth scrolling is turned on. ViewportAdjustmentExperiment is still needed for downstream compatibility, and will be removed in a subsequent CL. Unused features and experiments are removed from code as well to preface their official removal in FullscreenFeatures. Bug: 914042 Change-Id: Ib86fd4f9a53c9aed3509214f8dc232f624d9b004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815497Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#699914}
-
Chandani Shrestha authored
This change runs axe test in 3 scenarios: 1. Pattern form opened 2. Pattern added in the list 3. Error message validation Bug: 963183 Change-Id: I2a0face5eba7a7631261d619126131b631ceab34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652050Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Chandani Shrestha <chshrest@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699913}
-
Andrew Grieve authored
More hardening against verification failures caused by inlining. Also removes some unnecessary passing around of Application context. TBR=agrieve # Trivial change to ui/android Bug: 1006812 Change-Id: Icde0541166a7cac69edaf1a7638c41827c2711ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819354 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#699912}
-
Thanh Nguyen authored
This CL doesn't change any logic. It moves SearchRankingEventLogger to search_result_ranker, which is a more suitable place. The proto is deleted because it's not currently being used. This CL will be followed by several CLs that refactors the class. Bug: 1006133 Change-Id: I1b9180a6b9613d0627a1a00ca8cf55204c4987b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816058Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#699911}
-
Wez authored
Switch the tests that expect a call ot GetRouteTable() to explicitly wait for that to happen, rather than attempting to flush all pending events from both Thread and main loop. Bug: 973242 Change-Id: I0e19bb46aa7bf119fa8d6721e6f2f2a42e93a49b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820205 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#699910}
-
Shimi Zhang authored
Bug: 997362 Change-Id: Iebe27e720c942c1014981926b83fb1fafd57c938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824278 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#699909}
-
Nikita Podguzov authored
Bug: 992889 Change-Id: I27f4d213b84a3c7f41ec94759d397bfb694374de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798606 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#699908}
-
Nate Fischer authored
The record_netlog.py previously had a false positive when the package of interest was a substring of a running process (ex. "com.foo" and there's a process named "com.foo.persistent"). Substring matching was not intended, so switch to GetApplicationPids() which does not perform substring matches. Searching for exact package names usually suffices (and this is just a best effort attempt to detect if the app is running), so we should just minimize the false positive rate. Test: Try with "com.google.android.gm" when "com.google.android.gm.persistent" is running Change-Id: I3204131aaaf53df9d7972f8bce37602dfd8324d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820091Reviewed-by:
-
Bailey Berro authored
This fixes a bug where rotation was not persisted properly for displays set to a non-native resolution. ManagedDisplayInfo::native_ represents whether the object comes from DisplayChangeObserver [1]. ManagedDisplayMode::native_ represents whether the display is using a native resolution [2]. Previously, these values were incorrectly used interchangeably in DisplayChangeObserver::CreateManagedDisplayInfo(). This CL introduces ManagedDisplayInfo::from_native_platform_ to track whether the object comes from DisplayChangeObserver. ManagedDisplayInfo::native_ will now be used to track whether the display is using the native resolution. 1- https://cs.chromium.org/chromium/src/ui/display/manager/managed_display_info.h?rcl=661dcc6c712db426e252a8bccecfad50baecdce7&l=334 2- https://cs.chromium.org/chromium/src/ui/display/manager/managed_display_info.h?rcl=189281e03cf1b236600cd5fb6e6bbc049bdb4f60&l=65 Bug: 968224 Change-Id: I0eb4da445682481ced2b55a23e3a0ace6995a8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793745 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#699906}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09aa96cf69bd..370924be227a Created with: gclient setdep -r src-internal@370924be227a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9851cb3a54a7b532cfebb3c40f2a1405f139f833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825738Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699905}
-
Nate Fischer authored
No change to logic. This reorders Java modifiers to conform to the JLS style guide, which is enforced by a new presubmit check (https://crrev.com/c/1803140). This also adds curly braces to for loops, as this is also a presubmit requirement. Bug: 1003711 Test: git cl presubmit --upload Change-Id: Ice355c6453b4e88c28dacc07d91ade61a1e2d09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823813 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
Vikas Soni authored
A DCHECK became invalid after a recent refactoring. Move the DCHECK to more appropriate place. BeginReadAccess() could be called multiple times on a single shared image in which case this DCHECK is valid only for the first call. once |promise_texture_| is created and cached, this DCHECK becomes invalid. Change-Id: Ia77759ca7797675adbcf41a78c1086e3aebba2a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822318Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#699903}
-
John Budorick authored
Requires crrev.com/c/1809653 Bug: 922145 Change-Id: I3f2f134cd91f4c1ca50cb08348860c058d8dd1ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797004 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#699902}
-
Rohit Agarwal authored
Bug: 1004101 Change-Id: I8c8d12cc4faa60b6ead3abf2ed7ca8572fbca6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803921Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Florian Uunk <feuunk@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#699901}
-
Sergey Ulanov authored
Previously SysmemBufferPool wasn't calling Close(), which means that sysmem would fail the collection after SysmemBufferPool is destroyed, which prevent other clients from using that collection. Now the destructor calls Close() to avoid this issue. Change-Id: I0edd5cf9c79d9c0a14048211cebab215d76c953c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820102 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#699900}
-
Tao Bai authored
This patch added content-capture trace event category, also traced scheduling task and task running event. Bug: 1006418 Change-Id: I2dbe38bbf3e09645abb6185e8efa15587ffb00ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817282Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Kyle Milka authored
If the peek state for a BottomSheet is disabled pressing the back button should return the sheet to the hidden state rather than the peek state. Bug: 1007186 Change-Id: I1d8c3643fffd9eaf34f7b77d4c58470b7a865e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821981 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#699898}
-
Xianzhu Wang authored
This makes std::iterator_traits work for IteratorAdapter, which may be required by some std algorithms. Change-Id: Ib7bf7d8c7f97e6287006314e3b8958ed53bd6b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825467Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#699897}
-
jonross authored
There were several redundant test suites being ran on the GPU FYI SkiaRenderer bots. They were originally added to make cross-referencing failures easy. However the SkiaRenderer feature is much more stable now, so these are redundant with coverage on other bots, such as "Linux FYI Release (Intel HD 630)" This change removes all gtests not explicitly about SkiaRenderer + Vulkan from the bots. Bug: 1007087 Change-Id: Id536217e13f2d71c192c5a88adad4366667a4668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824121Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#699896}
-
jonross authored
We have begun field trials of SkiaRenderer on Linux. As such the browser_tests on the CQ are now running with SkiaRenderer enabled. This leaves us without any test configuration for the off state. Here I replace skia_renderer_browser_tests on the FYI bot Linux Viz with non_skia_renderer_browser_tests to ensure we have coverage during the field trials. Also deleting skia_renderer.browser_tests.filter as the final flakes are not SkiaRenderer specific, and are being addressed by those teams. We do not need it for the non_skia_renderer_browser_tests Bug: 967716 Change-Id: I6065d88539829aad49e7a941f2f7fa65977a76ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825098Reviewed-by:
-
Sinan Sahin authored
Bug: 989148 Change-Id: I889d7c52f4aa241d276e3665475362fa6178b091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809813Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Reid Kleckner authored
R=thakis@chromium.org Bug: 962988 Change-Id: I8f52fb88cf10d292e414bb2bd5bf4bbf3f7cd392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825119 Commit-Queue: Reid Kleckner <rnk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#699893}
-
Michael Thiessen authored
No functional changes intended, please revert if things break. This function is a large, and hard to follow. I'm hoping to break out a bunch of functions that are clearer about what they're doing and make ordering clearer. Bug: 1006927 Change-Id: I5c0efdb274222b1af861acf7cd31dade9a3ab2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822509 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#699892}
-
Allen Bauer authored
Bug: 1005568 Change-Id: If12927896ad1daa745517c03a6951ff65b3de2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823257 Auto-Submit: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#699891}
-
John Chen authored
ChromeDriver was passing --ignore-certificate-errors switch to Chrome, regardless of whether user wants to ignore certificate errors or not. Fixing by stop passing this flag to Chrome, and relying on using Security.setIgnoreCertificateErrors command when user wants to ignore certificate errors. Bug: chromedriver:3148 Change-Id: I5e8493f4cca48ebaeb211c95cd7fd645891c8659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824005Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#699890}
-
Lei Zhang authored
Add bool ReadAndCheck() as a wrapper around int Read() that returns true if and only if the specified amount of data got read. Similarly, add wrappers for ReadAtCurrentPos(), Write(), and WriteAtCurrentPos(). Make use of these wrapper methods in a few places to show how they can make code more robust or more foolproof. Fix nits and lint errors along the way. Change-Id: I956550708eeecee543b2e9b0948ea20de5308b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775233Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#699889}
-
Mark Pearson authored
Correct mis-rendered links and clean up the grammar slightly. Change-Id: I5bbb8af18f40713957625805ae4757a657469d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823800 Auto-Submit: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#699888}
-
Daniel Clark authored
Per https://w3c.github.io/html-aam/#el-mark, update the LocalizedControlType of <mark> from "text" to "highlight". Bug: 996459 Change-Id: I5f435988e16663df295cd195f3de6d97aab0dd70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762581 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699887}
-
Kurt Horimoto authored
This eliminates the boilerplate code of UIViewController setup in the coordinator, as well as the delegate and datasource capabilities provided to the mediator. Moving to use AlertOverlayCoordinator also converts JS dialogs to use child UIViewControllers, fixing some other issues resulting from the asynchronous nature of UIViewController presentation. Bug: 990070, 979030, 999960, 999962 Change-Id: I6c2465e5bc501540d9b16b60add61045e96ed963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809061 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#699886}
-
Christopher Cameron authored
Make ExtensionAppShimHandler be an AvatarMenuObserver (making it very similar to the existing ProfileMenuControllerInternal::Observer). Package up the profile list into mojo, and send it to AppShimController, where it is un-packed and displayed. Add a mojo method to communicate menu item selection back to the AppShimHost in the browser process. Note that this implementation is not complete yet. - The UI design is that profiles for which the app is not installed should not be included in the menu (left as a TODO) - Selection reaches ExtensionAppShimHandler::OnShimSelectedProfile, which just opens a new app instance -- it will need to load profiles or focus existing windows (and will need tests) - The app shim will need a dock context menu as well Bug: 982024 Change-Id: Ia72bc46b42b4ee3fa2866235c2e681aa690013a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819853 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#699885}
-
Elly Fong-Jones authored
10.15 introduced three new keyboard layouts that this test didn't handle: * Dhivehi-QWERTY, which behaves like DVORAK-QWERTYCMD but with a different base layout * Kyrgyz-Cyrillic, which generates cyrillic characters only and doesn't match any key equivalents * Mongolian-Cyrillic, which is similar This change: 1) Generalizes the DVORAK-QWERTYCMD logic to also handle the new Dhivehi-QWERTY layout (and others if needed later); 2) Skips this test on the two new Cyrillic layouts Bug: 998755 Change-Id: I1527974222b9e962379c70f8a57da5bc9cdba8e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825140 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#699884}
-
Adithya Srinivasan authored
This is a reland of a42225db. I've disabled the test on ChromeOS as it fails due to a known bug. We should still run this on other platforms. Original change's description: > Portals: Add chrome/ browser test for activation > > Bug: 927056 > Change-Id: Ief5a22cf86cd6bdeeae4361e616f66487f589c9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809115 > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698129} Bug: 927056 Change-Id: I9a05b6086f6d5341a4df30eb2bddf4ea2d07574e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817765Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#699883}
-
Alex Moshchuk authored
This CL will force all future tests that rely on content::NavigateToURL() to check its return value and ensure that the navigation behaves as intended. All existing tests have already been converted to validate the return value. Bug: 425335 Change-Id: I8c7c47a19b9b7beed5546dbe6f38b2dde1aed437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820319Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#699882}
-
Vasilii Sukhanov authored
Bug: 936011 Change-Id: I57095b23d0b5540425cac35f929ced8d7a5c5549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824889 Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
-
