GitLab

Errorprone is currently causing javac to crash when warnings
are hit.

TBR=agrieve  # Fixing build

Bug: 1027541
Change-Id: I7b95fa3dadd8947d66234c1f6c2490148d7e5d18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931742Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718381}

Have embedder pass in a profile name rather than a path.

* Add USER_DATA_DIR to PathService, and implement it correctly
  on all platforms.
* Add kUserDataDir switch to weblayer, to override the default
  USER_DATA_DIR location.
* Update everything to pass profile "name" rather than "path".
* Update ProfileImpl to compute the path as
  USER_DATA_DIR/profile/path
* Need to add to thread restriction since creating the path
  currently happen on the UI thread.

Bug: 1027627
Change-Id: I00119a9874cad055e7ab685fe714b92df95999fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929106Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718380}

Originally, the TabListSceneLayer that shows during tab-to-grid
transition puts the tab switcher bitmap right below the top toolbar.
This looks correct for normal layout but is no longer true for
StartSurface, because for StartSurface there are components that locate
above tab switcher. This CL adds a top offset so that we can adjust the
position of the tab switcher bitmap based on the real position of
tab switcher within the layout.

Bug: 995423
Change-Id: I23bf25d3c01a20410a921dcef9a9de947d554c29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921704
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718379}

https://chromium.googlesource.com/catapult.git/+log/8412598cca10..5459c3891e2c

git log 8412598cca10..5459c3891e2c --date=short --no-merges --format='%ad %ae %s'
2019-11-22 crouleau@chromium.org [Telemetry] Exit code 111 indicates no stories were run.

Created with:
  gclient setdep -r src/third_party/catapult@5459c3891e2c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1019139
Tbr: oysteine@google.com
Change-Id: I0fe5a9dc3d3a112eb348dcdee256324a182678de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931640Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718378}

This is just a followup to [1]. It handles the out-and-back routing focus bug
for the MultiDevice page and the 'Known Networks' route from the internet
subpage.

Note that there are a couple minor cleanups from [1] as well.

See behavior with CL here:
https://drive.google.com/a/google.com/file/d/106hO30ty9-ZmjY5vgrvB-k122EYsIGMg/view?usp=sharing

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1919327

Bug: 1003992
Change-Id: I4e5a5dc5807cec2c6e123ab6bc31ff98e85cb58a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930540Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718377}

Change-Id: I61c0c7b68ceb56313326f96a488f7fa095f3e067
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931836Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Auto-Submit: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718376}

This CL blocks the following characters when used next to a non-CJK
character:

U+4E00 (一), U+3127 (ㄧ), U+4E28 (丨), U+4E5B (乛), U+4E03 (七),
U+4E05 (丅), U+5341 (十), U+3007 (〇), U+3112 (ㄒ), U+311A (ㄚ),
U+311F (ㄟ), U+3128 (ㄨ), U+3129 (ㄩ), U+3108 (ㄈ), U+31BA (ㆺ),
U+31B3 (ㆳ), U+5DE5 (工), U+31B2 (ㆲ), U+8BA0 (讠), U+4E01 (丁)

According to usage logs, this change affects a small number of domains (<10)
with a small number of users (<300 over 28 days).

It does not block U+30A8 (エ) as this converts more domains to punycode  (~20).

Bug: 990428
Change-Id: Ie8cad20f52446361439ea9e3e0a69b276f8115fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927692
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718375}

Includes one line fix in audio_device_listener_win.cc to use the
DCHECK_CALLED_ON_VALID_THREAD() macro.

----- [ Original Description ] -----

This fixes a TODO in AudioDeviceListenerWin on listening for
property value changes... by listening for them in a completely
different way.

Unfortunately forcing mono audio for accessibility doesn't
generate IMMNotificationClient events, so we need to instead
use the IAudioSessionEvents interface, but that can only be
hung off a fully initialized IAudioClient... which is only
done during WASAPI audio output setup.

So the original TODO is fixed by adding a 1-to-1 path for device
changes (in addition to the 1-to-many path). We still need both
paths since just switching your default device won't generate an
IAudioSessionEvent notification, only an IMMNotificationClient
event. Additionally fake and WaveOut based devices don't have a
IAudioSessionEvents interface, so still need the old path.

Misc other cleanups:
- Expands the AudioDeviceListenerWin unit tests.
- Fixes broken --force-wave-audio switch in AudioManagerWin.

BUG=1020006
TEST=property changes, mono audio changes, default changes work.
TBR=henrika, tguilbert

Change-Id: I95f5f439982a68d2b509db10978a570fb98081b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931408Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718374}

No change to production behavior.

This adds a "reset all to default" button for the flags UI. This button
updates the visual appearance of the Spinners and sends the new (empty)
flag override state to the service (which then stops itself).

Fixed: 1026381
Test: Manual - verify the button resets spinners and the services stops
Change-Id: Ia3324653471a43d24ed1cd269ddf717af0a89c57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925596
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718373}

This addresses concerns that came up in
https://chromium-review.googlesource.com/c/chromium/src/+/1913287/3#message-a8c363497a19a03f9c10079fa5fca6ed67263935

R=abennetts@google.com, perezju@chromium.org

Bug: 949246
Change-Id: I2686272fcfafaafb71b20a5024ec99f2e30e9885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925592
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718372}

Bug: 1001194
Change-Id: I1ea4fa11ba5560ac893cef456c00e104d5748317
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931143Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718371}

Change-Id: Ie7a38b77cfcc9a2c0ae6a7a5d5b64181e1614c9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919853
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Darin Fisher <darin@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718370}

Disables various Omnibox tests on versions of Android where they are
flaky.

Some tests are now restricted to KitKat only.
Other tests are no longer run on Pie+.

BUG=1027549
TBR=cmumford@chromium.org

Change-Id: I13c1b1339aba95c66ddfad32d7dd7c2f794f5870
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931856Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718369}

This reverts commit abba56a7.

Reason for revert: Break local CrOS all-targets build.

Original change's description:
> Reland https://chromium-review.googlesource.com/c/chromium/src/+/1900520
> 
> This was reverted because grit ran out of ID space and builds started failing.
> 
> Creates a WebUI-based Crostini Upgrader
> 
> The UI is behind the new crostini-webui-upgrader flag
> (currently disabled by default)
> 
> The main areas for review are
> 
> calamity@:
> html/js  - chrome/browser/chromeos/crostini_upgrader/
> mojo and webui glue classes - chrome/browser/ui/webui/crostini_upgrader/
> 
> davidmunro@
> crostini business logic - chrome/browser/chromeos/crostini/
> 
> In this CL, the optional container backup stage is stubbed, and will be
> in a subsequent CL.
> 
> A suite of unit/browser tests are also currently lacking. I intend them for
> follow-up CLs.
> 
> 
> Bug: 930901
> Change-Id: I6d3a63ffb319c762839a830ee76f4dfcc56445bf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928383
> Auto-Submit: Nicholas Verne <nverne@chromium.org>
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Reviewed-by: calamity <calamity@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Commit-Queue: Nicholas Verne <nverne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#718358}

TBR=calamity@chromium.org,rockot@google.com,sammc@chromium.org,nverne@chromium.org

Change-Id: Id85a83d61155f8fae7fcdd54c92c60b6bd29661a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 930901
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931797Reviewed-by: James Hawkins <jhawkins@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718368}

This header provides a bunch of helper functions for Content processes
modeled as Service Manager services. Since those are no longer a thing,
this no longer needs to be a thing.

Bug: 977637
Change-Id: Ia1ae177b4a9665b727618b12a35be905d5605ce9
Tbr: jam@chromium.org
Tbr: erikchen@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929396
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#718367}

Bug: 1007664
Change-Id: I975e8b03330961acc2b7f9dd6b96406e6bdd0ec5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922734
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718366}

This CL fixes net unittests so that they work if append frame origin
is enabled by default.

Bug: 1026388
Change-Id: Ia307269236e7e58184f4394502eed4e29c0e2246
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930945
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718365}

The notion of a simple "size" for Stage Parameters/bounded was a WebVr
concept that did not carry over to WebXr.  To simplify the mojom, move
the "conversion" of square stages (for those runtimes that only support
giving size x/z) down into a utility function in the device process.

Bug: 1017843
Change-Id: Ib050a7ea3655a3816f6008e82434435ecb2c4426
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918037
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718364}

https://quiche.googlesource.com/quiche.git/+log/b5f2d72f536f..a89eee387569

$ git log b5f2d72f5..a89eee387 --date=short --no-merges --format='%ad %ae %s'
2019-11-22 wub gfe-relnote: (n/a) In quic::test::TestQuicSpdyServerSession, do not call Initialize() in constructor. Test only, not protected.
2019-11-21 bnc Move NoopQpackStreamSenderDelegate to qpack_test_utils.h.
2019-11-21 renjietang Change window_update frame's byte_offset to max_data to incorporate IETF spec.
2019-11-21 wub gfe-relnote: (n/a) Only enable QUIC MTU discovery in the server->client direction. No behavior change in GFE, not protected.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: Ib3df7f9ef286727cb0f33938db2bd49ac785ebc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931496
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718363}

This reverts commit aa147bcb.

Reason for revert: Fix compile on Android x64

Original change's description:
> Revert "Fill in the first pass of the parser to analyze hprof files."
>
> This reverts commit b30f46fd.
>
> Reason for revert: Compile error in hprof_buffer_android_unittest.cc on x64 bot.
> https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8896255126674550192/+/steps/compile/0/stdout
>
> Original change's description:
> > Fill in the first pass of the parser to analyze hprof files.
> >
> > The main purpose of the java heap profiler is to obtain a heap dump in
> > the form of an hprof file and then parse the hprof file. Currently,
> > there exists an empty parser that skips over everything in the hprof
> > file.
> >
> > With CL, we first parse each instance for given fields (object_id,
> > names, etc..) and then store these values in different instance
> > objects. We will be using these instance objects in the next CL which
> > is the second pass over.
> >
> > Bug: 1012072
> > Change-Id: Ibe249056c180dd07b907ada129898248c91cbaec
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898481
> > Commit-Queue: ssid <ssid@chromium.org>
> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> > Reviewed-by: ssid <ssid@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#716986}
>
> TBR=nyquist@chromium.org,ssid@chromium.org,zhanggeorge@google.com
>
> Change-Id: Ic1a61810ab7d669b2f2fbae5786e30c17eff1970
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1012072
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926535
> Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#717040}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1012072
Change-Id: I1064dd7e7d33002ae870ad632224fccc7547b09b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931264Reviewed-by: ssid <ssid@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718362}

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=jsbell@chromium.org

Bug: 1023677
Change-Id: I5a1ecdffd989113476f8e29b6625c2a0894446ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927020
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#718361}

https://chromium.googlesource.com/angle/angle.git/+log/4c7db77e0185..f3d35f8f9c6f

git log 4c7db77e0185..f3d35f8f9c6f --date=short --no-merges --format='%ad %ae %s'
2019-11-22 courtneygo@google.com Suppress flaky failure with Win7/NVIDIA/D3D11

Created with:
  gclient setdep -r src/third_party/angle@f3d35f8f9c6f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: courtneygo@google.com
Change-Id: I81b40b357b550a851682e5ab86173e853b1cf91d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931172Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718360}

This change creates a modified copy of CertNetFetcherImpl (renamed
to CertNetFetcherURLRequest) that uses URLLoader's (implemented by
the Network service) instead. This new version is called
CertNetFetcherURLLoader. It will be used by default in the
CertVerifyProc's created by the network service.

Bug: 1015164
Change-Id: I5dde69e3dba8b1abd7133c83c91f0601bb6e9074
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866194
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718359}

This was reverted because grit ran out of ID space and builds started failing.

Creates a WebUI-based Crostini Upgrader

The UI is behind the new crostini-webui-upgrader flag
(currently disabled by default)

The main areas for review are

calamity@:
html/js  - chrome/browser/chromeos/crostini_upgrader/
mojo and webui glue classes - chrome/browser/ui/webui/crostini_upgrader/

davidmunro@
crostini business logic - chrome/browser/chromeos/crostini/

In this CL, the optional container backup stage is stubbed, and will be
in a subsequent CL.

A suite of unit/browser tests are also currently lacking. I intend them for
follow-up CLs.


Bug: 930901
Change-Id: I6d3a63ffb319c762839a830ee76f4dfcc56445bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928383
Auto-Submit: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718358}

This reverts commit 3fb77161.

Reason for revert: trace collection timeout was increased to fix the
failures.

Original change's description:
> Reland "Disable failing tests on android-go_webview-perf"
> 
> This reverts commit 5d686312.
> 
> Reason for revert: turns out this was caused by a different patch afterall. 
> 
> Original change's description:
> > Revert "Disable failing tests on android-go_webview-perf"
> > 
> > This reverts commit 7a502f46.
> > 
> > Reason for revert: patch that caused the failures was reverted
> > 
> > Original change's description:
> > > Disable failing tests on android-go_webview-perf
> > > 
> > > Disabling the following tests on android-go_webview-perf:
> > > * system_health.common_mobile/browse:media:youtube:2019
> > > * system_health.common_mobile/browse:news:nytimes:2019
> > > * system_health.common_mobile/browse:news:cnn:2018
> > > 
> > > TBR=crouleau@chromium.org
> > > NOTRY=true
> > > 
> > > Bug: 1026822
> > > Change-Id: I2581e3c21158edff2563de628bfa41de7349271d
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927216
> > > Reviewed-by: John Chen <johnchen@chromium.org>
> > > Commit-Queue: John Chen <johnchen@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#717272}
> > 
> > TBR=crouleau@chromium.org,johnchen@chromium.org
> > 
> > Change-Id: I0cf407e4ec8f3a44afa229c9fae82c064d9bb9a0
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1026822
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928322
> > Reviewed-by: Eric Seckler <eseckler@chromium.org>
> > Commit-Queue: Eric Seckler <eseckler@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#717618}
> 
> TBR=crouleau@chromium.org,eseckler@chromium.org,johnchen@chromium.org
> 
> Change-Id: I0c6f3f761c335df3463564ba84946735b552c713
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1026822
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928557
> Reviewed-by: Eric Seckler <eseckler@chromium.org>
> Commit-Queue: Eric Seckler <eseckler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#717662}

TBR=crouleau@chromium.org,eseckler@chromium.org,johnchen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1026822
Change-Id: Ia60707051f4f341bfa35dafd13338f49f2d046c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931151Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718357}

When making query to swarming for bots with dimension values, it is
possible that no bot is returned. Normally, the return JSON looks
like this:
{
  "death_timeout": "xxx",
  "items": ["list","of","bots"]
  "now": "xxx"
}
When there's no bot, the "items" key is gone:
{
  "death_timeout": "xxx",
  "now": "xxx"
}
In this case, we will see a KeyError in pre_run stage because we try to
read values using "items" key in perf_device_trigger.py:
  for bot in query_result['items']:
    ...

KeyError doesn't tell what is actually happening. To fix, we check this
key before using it. Then when no bot exists, we will see a message saying
there's not enough machines.


Bug: chromium:1027147
Change-Id: I38fe0e1a015e29d9b223515f49c527641bcebf60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929871Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718356}

Previously we disabled some vulkan_native_blink_web_tests due to them timing out on Linux+Intel

The root cause has since been fixed. So let's remove the Slow tag from them.

TBR=penghuang@chromium.org
TEST=vulkan_native_blink_web_tests
Bug: 1021575

Change-Id: Ibfed5fba8766d3b5fbc9867aa8c681125926d5d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930218Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718355}

The internal configuration name was changed. Update fieldtrial
configuration to match.

Bug: 333943
Change-Id: I70eb78ec4829788d78ef9c925ae2866cd54575d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929845Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718354}

This CL addresses two issues.

1: It corrects the problem outlined in https://crbug.com/546640 by
having the TestingProfile reside in a directory that outlives the task
environment.
2: It changes the creation of KeyedServices from explicit constructor
calls or deprecated functions to the preferred builder based approach.
(Recommended in the code at testing_profile.h:226)

This is done to prepare HistoryServiceUsesTaskScheduler activation.
This finch trial will soon become default and the changes it introduces
exposed the brittleness of this test.

Bug:661143

Change-Id: If9d1403a5486d0050ea218cfb0d28fc261a472f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926676
Commit-Queue: David Trainor <dtrainor@chromium.org>
Auto-Submit: Oliver Li <olivierli@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718353}

This migrates Utility processes to direct ChildProcess API usage instead
of bootstrapping IPC through the Service Manager.

As this is the last remaining use of Service Manager IPC to bootstrap
Content child processes, this also rips out a bunch of infrastructure
that existed only to support that.

Bug: 977637
Change-Id: I08e542f1d9f294bc1c387ea5845e8ba0d5a7d2b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919719
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718352}

DO NOT LAND: This is a silly change.

TBR=tbansal@chromium.org

Change-Id: Iad6a0f30a8bb82b7c008505ffcb899c2dd0b857f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931545Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718351}

Currently if there is more than one Chrome window, activating Chrome
from launcher does nothing.

The bug is less obvious in clamshell mode where the app list closes
immediately after Chrome icon activation. If the most recent active
app was Chrome (which is often the case), it looks like everything
worked correctly. However, if another window was active prior to
the app list opening, it will stay open after Chrome icon is activated.

It tablet mode the app list stays active and the bug is very obvious.

This is a regression introduced by http://crrev.com/c/1449104 which
did not take into account the fact that
BrowserShortcutLauncherItemController::ItemSelected is called both
when activating Chrome from shelf and from app list. This method should
be no-op only if called with multiple windows from shelf (but not other
sources).

Bug: 1026639
Test: manual, new browser test
Change-Id: I5c24339e97724018f65d919e2c95f143465ce505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931146
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718350}

This reverts commit 3d8fa26a.

Reason for revert: Sorry, looks like this is causing compile failures on the waterfall (https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/7869)

I don't know why the archive builders aren't on the CQ...

Original change's description:
> Support audio channel count and sample rate changes on Windows.
> 
> This fixes a TODO in AudioDeviceListenerWin on listening for
> property value changes... by listening for them in a completely
> different way.
> 
> Unfortunately forcing mono audio for accessibility doesn't
> generate IMMNotificationClient events, so we need to instead
> use the IAudioSessionEvents interface, but that can only be
> hung off a fully initialized IAudioClient... which is only
> done during WASAPI audio output setup.
> 
> So the original TODO is fixed by adding a 1-to-1 path for device
> changes (in addition to the 1-to-many path). We still need both
> paths since just switching your default device won't generate an
> IAudioSessionEvent notification, only an IMMNotificationClient
> event. Additionally fake and WaveOut based devices don't have a
> IAudioSessionEvents interface, so still need the old path.
> 
> Misc other cleanups:
> - Expands the AudioDeviceListenerWin unit tests.
> - Fixes broken --force-wave-audio switch in AudioManagerWin.
> 
> Fixed: 1020006
> TEST=property changes, mono audio changes, default changes work.
> 
> Change-Id: I257219a32cbcb22c1590aa07f82c6e5d4c7948e4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917091
> Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
> Reviewed-by: Henrik Andreasson <henrika@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#718342}

TBR=dalecurtis@chromium.org,tguilbert@chromium.org,henrika@chromium.org

Change-Id: I8d94920dde4716570db6148202a54d0ca11606c1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930189Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#718349}

This reverts commit e38327e1.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 718338 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2UzODMyN2UxZDQ5MDE5N2M5ZDdhMDk3Mjg5ZmVlN2FmMzhiMWZhN2UM

Sample Failed Build: https://ci.chromium.org/b/8896048495893501824

Sample Failed Step: compile

Original change's description:
> Spellcheck cleanups
> 
> Introduce a build flag for the remote spelling service, and stop
> compiling/instantiating SpellingServiceClient on platforms that
> don't use it (Android). Also try to reduce the number of platform
> ifdefs in spellcheck code, in favor of buildflag usage. Reduce
> the amount of code that's compiled but never used by removing
> several SpellCheckHostImpl methods on mac/win.
> 
> Also remove a couple of obsolete includes.
> 
> Change-Id: I5697a5d3f891f69159d5bba855ee72e11a3ca8be
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927412
> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Commit-Queue: Bo <boliu@chromium.org>
> Auto-Submit: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#718338}


Change-Id: Ia990162d2d72055c99af51fc165c52c4aa3fe1c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929466
Cr-Commit-Position: refs/heads/master@{#718348}

BUG=1027769

Change-Id: I3cd13fb208b1118e49ce5f4e6576d94c9442abec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928235
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718347}

This reverts commit af8f7390.

Reason for revert: FakeChromeIdentity is now a subclass of ChromeIdentity. So ChromeIdentity has to be compiled in test side when FakeChromeIdentity is used.

Original change's description:
> [iOS] Ensure no ChromeIdentity class is compiled in EG2 tests.
> 
> This will prevent unnecessary dependencies from being pulled to EG2
> tests.
> 
> Bug: 1015907
> 
> Change-Id: I45c5ec755761f1903b405542967c8a7321500ab5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929761
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#718290}

TBR=rohitrao@chromium.org,zhaoyangli@chromium.org

Change-Id: Id95e387ee91738ec277a2321133ba899b24a9902
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1015907
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931536Reviewed-by: Yun Liu <yliuyliu@google.com>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#718346}

https://skia.googlesource.com/skia.git/+log/db80f6936cbc..3bc4235baa96

git log db80f6936cbc..3bc4235baa96 --date=short --no-merges --format='%ad %ae %s'
2019-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader f2c9ce1e08ed..c8d4d4254ca1 (15 commits)
2019-11-22 jvanverth@google.com Add checks for TextureSampler count in text GeoProcs.

Created with:
  gclient setdep -r src/third_party/skia@3bc4235baa96

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:None,chromium:1027314
Tbr: robertphillips@google.com
Change-Id: I8b4f577e9fbb2375f99534cb7e22ec8156ebd481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930209Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718345}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c50b0963e3f2..9dabaedfa33c

git log c50b0963e3f2..9dabaedfa33c --date=short --no-merges --format='%ad %ae %s'
2019-11-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@9dabaedfa33c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: Icb3e8ab821d86eb5cfd1970909ae71589a74f342
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930210Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718344}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e75a355406dc..9e32eb6fc6fc


Created with:
  gclient setdep -r src-internal@9e32eb6fc6fc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:None,chromium:None,chromium:None,chromium:None
Tbr: jbudorick@google.com
Change-Id: I976631707e0e77097a96c8deae0502ffd99e7613
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931476Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718343}

This fixes a TODO in AudioDeviceListenerWin on listening for
property value changes... by listening for them in a completely
different way.

Unfortunately forcing mono audio for accessibility doesn't
generate IMMNotificationClient events, so we need to instead
use the IAudioSessionEvents interface, but that can only be
hung off a fully initialized IAudioClient... which is only
done during WASAPI audio output setup.

So the original TODO is fixed by adding a 1-to-1 path for device
changes (in addition to the 1-to-many path). We still need both
paths since just switching your default device won't generate an
IAudioSessionEvent notification, only an IMMNotificationClient
event. Additionally fake and WaveOut based devices don't have a
IAudioSessionEvents interface, so still need the old path.

Misc other cleanups:
- Expands the AudioDeviceListenerWin unit tests.
- Fixes broken --force-wave-audio switch in AudioManagerWin.

Fixed: 1020006
TEST=property changes, mono audio changes, default changes work.

Change-Id: I257219a32cbcb22c1590aa07f82c6e5d4c7948e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917091
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718342}