- 26 Oct, 2020 37 commits
-
-
Yuki Shiino authored
Improves global listing tests to show IDL namespaces. Change-Id: Idaf760eba8dc40728427e7865c7d075cadc87fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494449Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#820681}
-
Wei Lee authored
Per discussion with Files team, we agree that Camera folder should still be modifiable. Bug: 1127587 Test: Manually Change-Id: I22a9e3eca0b7fb71bd883c37bb0e6a30509e8b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477707Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#820680}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/153af9451acd..f6b755916fcf 2020-10-26 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll MarkupSafe from f2fb0f21ef1e to 0944e71f4b2c (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ic6937e428ac6f14d9e6ee5bc048476a1da76d126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497566Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820679}
-
Tal Pressman authored
Change-Id: Iba8ef12b515c1d85fde0454f8b164111642bb9e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497783 Commit-Queue: Tal Pressman <talp@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Tal Pressman <talp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#820678}
-
chrome://media-appDavid Lei authored
It looks like like was missed in the conversion from mainifest.json to web_app_info. The IDR_MEDIA_APP_GALLERY_ICON_96_PNG is already plumbed through chrome://media-app https://source.chromium.org/search?q=IDR_MEDIA_APP_GALLERY_ICON_96_PNG so I suspect this change just provides the 96px icon for web things that use the manifest (e.g. pinning on the shelf). Bug: b/161203411 Change-Id: I63d396434070938b6d462912336b9b3e9daf2d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497721Reviewed-by:
Patti <patricialor@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#820677}
-
Yuki Shiino authored
Makes a clear separation between Direct Socket and Serial. It's just a coincidence that both features are disabled on the same platform. Change-Id: Iee2a691fcfabfe00651535fecaab6595c14a300d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494610Reviewed-by:
-
Harvey Yang authored
As some clients, such as generic sensor, may connect to the same SensorDevice multiple times, this commit refactors chromeos::sensors::FakeSensorDevice to support that. BUG=chromium:1006141 TEST=builds and unit tests of generic sensor Change-Id: Ie792ab60daae8d9941d00fce6c7d3a248f9b8c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491767 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#820675}
-
Satoshi Niwa authored
Bug: 1126742 Test: atest DocumentsTest#testGetContentWithQuery_matchingFileShowing Change-Id: I4f19e235521056e6a6745f2d2974883fc746e691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491840 Auto-Submit: Satoshi Niwa <niwa@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
-
Daniel authored
Fixes were added to the Plugin VM installer, which the Borealis installer is based on. The issue it faced (installation wasn't being cancelled when the installer window was being closed by the 'X') also affects the Borealis installer. I've added a fix for it and also fixed up a problem where cancelling the dialog and repopening it would break the installation process. Plugin VM fixes: CL:2462897 Tests: Wrote test and ran other unit tests Bug: b/171672034 Change-Id: If8f17fd157a96d32cb1bc014ec937149a900ebed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467306 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#820673}
-
Yu-Hsuan Hsu authored
Review and update expiry of Cras.* to 2021-12-01. BUG=chromium:1140028, chromium:1140027, chromium:1140026, chromium:1140025, chromium:1140024 Change-Id: I52a45d9e84010a0fc2303d7a7ec90ab6fbc9abc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494520Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#820672}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1603613972-3db8d0e06abb7812d76b308af9c886af81f88ed1.profdata to chrome-win64-master-1603659384-78fe2392c0cc8d75dc2caf4c010bfa3581cbc33b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibaffbad6aa8d8a127d928029fba4046e03160b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497640Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/258f17d68700..29ca7186a688 2020-10-26 cnorthrop@google.com Tests: Add Dragon Ball Legends trace If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Test: Test: angle_perftests --gtest_filter="*dragon_ball_legends*" Change-Id: I1cb3be0b2900254b2e52586bd50fd8871d6c858f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497768Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0ae6879b52fc..607cb31e3a38 2020-10-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0e0dd9313574b7d6be30b2742d485451031206c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497769Reviewed-by:
-
Kent Tamura authored
This makes it possible to use class declarations and to avoid including frame_request_callback_collection.h and scripted_idle_task_controller.h. This CL has no behavior changes. Bug: 242216 Change-Id: If600c2f9c4bca8c6f2a8b1fdcf6517e786fb1076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497731Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#820668}
-
Minoru Chikamune authored
Context: Previously, AgentGroupScheduler was tentatively created per thread. But AgentGroupScheduler has to be integrated with AgentSchedulingGroup. What this CL does: - Instantiate AgentGroupScheduler per AgentSchedulingGroup for the most of the ordinary pages. Previously, AgentGroupScheduler was created per MainThreadScheduler. Unfortunately, there are some edge cases where ordinary pages are temporarily created (e.g. ScopedWebFrame, WebViewPlugin). In that case, AgentGroupScheduler will be created on a case by case basis. For the non-ordinary pages, this CL creates AgentGroupScheduler per page. - Plumb AgentGroupScheduler from AgentSchedulingGroup to PageScheduler. Because AgentGroupScheduler has to be associated with PageScheduler. - Migrate some per-thread task runners to use per-ASG task runners. (e.g. WebFrameWidgetBase) Bug: 1105403, 1113102, 1135020 Change-Id: Iad25da50bc978876b6e211f675ea8504791d4541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434414 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#820667}
-
Glen Robertson authored
Bug: 1139795 Change-Id: I47f90b0949cfdde8b11f7ed8bc22091fd8b16168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494188 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#820666}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9202244553e7..e8c4c1f19d4e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yhirano@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yhirano@google.com Change-Id: I86ce5c219872dd2e07d58e606cb38126e496010a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497403Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820665}
-
Fergal Daly authored
Analysis of 50/50 experiment is in https://crbug.com/1102233. Fix 2 tests. This reenables CrossOriginOpenerPolicyBrowserTest.CoopPageCrashIntoNonCoop. This won't be submitted until it's clear that https://crbug.com/1139104 is caused by early commit. Bug: 1102233,936696,1066376 Change-Id: Id1f96e53f163d50d873819bbf2bd0fd826b7332e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483730Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
Xida Chen authored
This CL creates classes to build the infra of native paint worklet. Specifically, we create a NativePaintWorklet class, and when we paint the background color, we ask the NativePaintWorklet to do the paint. Because NativePaintWorklet lives under the modules/ and paint part is in core/, we need some other classes to be there so that the paint can call NativePaintWorklet APIs. Design doc here: https://docs.google.com/document/d/1usCnwWs8HsH5FU_185q6MsrZehFmpl5QgbbB4pvHIjI/edit Bug: 1138997 Change-Id: Ifdabf3ce5226ee4cacac03eec46029e74c3fa9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464428Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#820663}
-
Eugene But authored
This method is no longer called downstream Bug: 1138523 Change-Id: I8c5284f1accba661c2542a5090095d0ea0e20e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493426Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#820662}
-
John Chen authored
This reverts commit d8db7fef. Reason for revert: Causing large number of Chrome crashes on mac-10_12_laptop_low_end-perf (crbug.com/1142285) Original change's description: > Reenable MacV2GPUSandbox crash-on-unknown-denials. > > Also crash on sysctl-read failures. > > Bug: 1126350 > Change-Id: I9d69c69979ab076e257ca079f6e5f09aed5c28be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493440 > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Auto-Submit: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820468} TBR=kerrnel@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1126350, 1142285, 1142288 Change-Id: I3d1240943f2af5c63d3a7cb101381be85fdc6772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497428Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#820661}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I5a4ad404174e5f76b493c2744377481477d0c4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497469Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820660}
-
Kenichi Ishibashi authored
We replaced net::HttpResponseInfo with URLResponseHead in service worker code base. Rename the error code to fit the current implementation. Bug: N/A Change-Id: Iff9a2bbed81ada4f1fc73dbca5ebd0e56c34cba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497343Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#820659}
-
Olivier Yiptong authored
This creates the initial API to initiate a font chooser, behind a flag. It is different from enumeration at this point for now because the use-cases they are trying to solve are different. Both could be unified in the future. Change-Id: I55d2ac5079f325d86e62e2a348380507b53ea681 Bug: 1138621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488602Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Add module for: - list_selection_model_test_util.js - list_selection_model_test.js - list_single_selection_model_test.js - menu_test.js - menu_button_test.js - position_util_test.js - splitter_test.js Bug: 1133198 Change-Id: Ib03957cc8c1ec686e7d61848b9cfd42a80788774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491761Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#820657}
-
My Nguyen authored
In AssistiveWindowController, the method is no longer used because emoji suggester uses SetAssistiveWindowProperties. Bug: 1102219 Change-Id: I7286bf0e297662bd26e1e7a87116b20f723ae094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473778Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#820656}
-
chrome://media-appDavid Lei authored
This makes chrome://media-app show up with a favicon in the task manager. Follow up work needed to get the icon to show for the subframe (crbug/1141242). Note: We only need one of these icon sizes to get it to show but I don't think there is any harm in adding all of them. https://en.wikipedia.org/wiki/Favicon#HTML5_recommendation_for_icons_in_multiple_sizes Bug: b/171350349 Change-Id: I908ab710fe71c037b427caa368a36b14e13890f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491560 Commit-Queue: David Lei <dlei@google.com> Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9e3eec5464d6..258f17d68700 2020-10-26 cnorthrop@google.com Tests: Add World of Tanks Blitz trace If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Test: Test: angle_perftests --gtest_filter="*world_of_tanks_blitz*" Change-Id: I4d8f26686b2aa153a6a3e61b1212b19a34b8e8ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497642Reviewed-by:
-
Maggie Cai authored
This CL updates the naming MacNative to MacOs for app service app type to make the language inclusive. TBR=xiyuan@chromium.org, sky@chromium.org Bug: 1097644 Change-Id: I17cf90fb81c4451a6d05f997db205c718f2afabd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494403Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603646058-2e9f14b5d7fb706e5b9950a1952473f3aa55ccc4.profdata to chrome-linux-master-1603670235-a1304ada6cf45faf2e892b281617fe268ee6e0f9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I90a5f850a223e77d4c16079fcb2ec0a48a437dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497541Reviewed-by:
-
Jason Lin authored
noAutoSync replaces the special casing code in <app-management-permission-item> and makes things explicit. syncPermission() is to be used in a follow up cl. Bug: b/167491603 Change-Id: I1654fa6ffb7f7d9a4b868896f0618f9926cd12ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485996Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Daniel Ng <danielng@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#820651}
-
Josh Simmons authored
This reverts commit cd15c4b9. Reason for revert: The updated icon will be shipped in a later release. Original change's description: > Update Files.app iconography to new style > > Replaced the existing icons with new icons that have a different style. > > Test: Looked at Files.app icon in launcher, shelf and switcher > Bug: 1128673 > Change-Id: I55e3a586dd6ea9ab7f03134d4992eb6e7e2ae92d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430564 > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Alex Danilo <adanilo@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Josh Simmons <simmonsjosh@google.com> > Cr-Commit-Position: refs/heads/master@{#810521} TBR=noel@chromium.org,lucmult@chromium.org,adanilo@chromium.org,simmonsjosh@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1128673 Change-Id: I6a2f87b79d4c2c340fa8730716d653afb36e41df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494214Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#820650}
-
Darren Shen authored
Add Mojo and protobuf messages for Chrome to send text input field info to the IME service, including the type of the input field, whether autocorrect is enabled and whether the input field is privacy-sensitive. Bug: 1019541 Change-Id: I06858902697aba891109cdd7934b15862ca0add1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483729 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#820649}
-
Daniel authored
Integrating the launch watcher into the context manager so that the startup process can await on borealis starting. Tests: Built and ran tests, tested on DUT. Bug: b/171662734 Change-Id: I917440d9c190242bc7d4e28120e716702496f60c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497344 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/16b096af4c82..9202244553e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yhirano@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yhirano@google.com Change-Id: I62432435595d85304fefd5614901c95cf0d1a587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497660Reviewed-by:
-
David Bienvenu authored
Some command line handling only needs to be done once, instead of once per profile. This CL moves handling of kNotificationLaunchId and kGcpwSigninSwitch from StartupBrowserCreatorImpl::Launch to StartupBrowserCreator::ProcessCmdLineImpl. Bug: 1132578 Change-Id: Ia7d0dbbb7ca3fe8c9a1ce04720c0e2205aff7678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491983 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#820646}
-
chrome://media-appTrent Apted authored
More accurately, this just hides the codepath that would redirect files sniffed as "image/tiff" back to the old gallery app if the file had an extension matching a known RAW image format. (chrome://media-app was already a handler for "image/*", so logic was needed to exclude RAW). However, it also adds explicit extension-match file handlers to the web app manifest to handle cases where sniffing is not done. Initially tried sharing the logic that drives `IsRawFile()` in the files app's file_tasks but that's not really compatible with the web app manifest, and `IsRawFile` can just be deleted soon. Encapsulate IsRawFile() to make that removal easier: nothing outside file_tasks.cc uses it since r777758. The logic is put behind a base::Feature, but not a chrome://flag: usage of this is low and the change is low-risk. And flipping chrome://flags#media-app also works to use the old gallery for these file types. Bug: 1030935, b/154062029 Change-Id: I4779f76fa81800ffef316748cb94e12534b38775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494404Reviewed-by:
-
- 25 Oct, 2020 3 commits
-
-
Jinsuk Kim authored
This reverts commit e1fcf7ac. Reason for revert: identified as culprit for crbug.com/1141360 Original change's description: > Toolbar: Remove dependencies on NewTabPage > > With this CL, toolbar/ classes are free of dependencies on > chrome/browser/ntp. A new interface NewTabPageDelegate plus its > implementation in ToolbarManager replaces the references to > NewTabPage. Dependencies on static URL util methods in NewTabPage, > NativePageFactory were addressed by moving the methods to > modularized targets - components/embedder_support/android:util_java > and chrome/browser/ui/native_page, respectively. > > Bug: 1127732 > Change-Id: I8619db6454b1aa274328a3a243b977cbd87aac02 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467578 > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819204} TBR=fgorski@chromium.org,tedchoc@chromium.org,mdjones@chromium.org,jinsukkim@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1127732, 1141360, 1141362 Change-Id: Ib77ad0c85d2b7313954729110f3510f096fd4d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495501Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#820644}
-
mlcui authored
Most shortcuts in the shortcut viewer use one of four strings, representing a single key with 0-3 modifiers. This is currently hard-coded with the shortcuts. This CL refactors that to automatically determine the correct string based on the number of modifiers, eliminating the need to specify the shortcut string for most shortcuts. This refactor is intended to make way for having a runtime-determined number of modifiers for a given shortcut, as #new-shortcut-mapping changes shortcuts involving Shift - for those shortcuts, we need to display the shifted key instead of Shift + unshifted key. Bug: 1139080 Change-Id: I8bb2c71a31fb1eb546aee88d6690990afd6c2f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494205 Commit-Queue: Michael Cui <mlcui@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#820643}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Idf6f275f69fafa8099690427e0d794b6f1357ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497535Reviewed-by:
-
