GitLab

Update WebContentsViewMac to always report the view as visible when
it is hosted in a remote process.

Fix an a11y crash crash in BridgedContentView's
accessibilityAttributeValue function.

Make the doppelganger NativeWidgetMacNSWindow in the browser process
be transparent and have no controls (closing that window causes
complicated lifetime issues).

Make NativeWidgetMacNSWindow directly store a pointer to its
BridgedNativeWidgetImpl, instead of looking it up by id.
- This was causing problems where the doppelganger window in the
  browser process was fighting with the true NativeWidgetMacNSWindow
  in the app shim.
- When the gfx::NativeWindow handle patch lands, we can make the
  doppelganger window be a different class, which will help to
  de-confuse things.

Update NativeViewHostMac::GetViewsFactoryHostId to return the same
sentinel value for "use the local process" as is used in content (this
had been causing LOG errors).

Bug: 859152
Change-Id: Ic0222351a54b20387c019263ee1a04d03461c063
Reviewed-on: https://chromium-review.googlesource.com/c/1278294Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599295}

Changing the Display's work area is not allowed while overview
mode is active, but the docked magnifier need to update the
display's work area. As a result we should exit the overview
mode before toggling the docked magnifier.

BUG=894256
TEST=Added new ash_unittests

Change-Id: Id1776bb814aa6dc7cbdc338575b9c8fdc02ab69d
Reviewed-on: https://chromium-review.googlesource.com/c/1278473
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599294}

GpuProcessHost installs a filter on ServiceManagerConnection. It should
be removed when GpuProcessHost is destroyed to avoid memory leak.

BUG=885393

Change-Id: I7621b52b6110f1e1671f0ec966477f1302fbc585
Reviewed-on: https://chromium-review.googlesource.com/c/1277945Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599293}

Bug: 894301
Change-Id: I7b137db2f75a32c871c882346295c4b8770b3237
Reviewed-on: https://chromium-review.googlesource.com/c/1277813Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599292}

Bug: 894350
Change-Id: Ic5cde2aef449e745e1301ee0c09b6e9ad50308e3
Reviewed-on: https://chromium-review.googlesource.com/c/1278534Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599291}

https://chromium.googlesource.com/angle/angle.git/+log/671809e62e80..c97e3f6684c7


git log 671809e62e80..c97e3f6684c7 --date=short --no-merges --format='%ad %ae %s'
2018-10-12 jmadill@chromium.org Revert "ES31: Add vector and matrix support in SSBO for D3D"


Created with:
  gclient setdep -r src/third_party/angle@c97e3f6684c7

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: I871d9042ed0b44cf93537b418a19e94092f6faae
Reviewed-on: https://chromium-review.googlesource.com/c/1278945Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599290}

These may be causing the WindowServer to die on 10.13.

Tbr: ellyjones@chromium.org
Bug: 828031
Change-Id: I5ed668eb5fbb9c70d06ea607bdabe74964d71498
Reviewed-on: https://chromium-review.googlesource.com/c/1277576Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599289}

The new test runner is named WprProxySimulatorTestRunner, and descends from SimulatorTestRunner,
mostly diverging in two ways:
* It performs additional set up and tear down to specifically set up the Web Page Replay proxy.
* It runs the suite under test multiple times, assuming the suite takes in one replay+recipe
pair per run, corresponding to testing one webpage. Each webpage will have separate results in the
final results report.

This test runner is triggered if a new flag, replay_path, is set for a iOS test.
This flag represents the path containing saved web page replay and recipe files for use with
WprProxySimulatorTestRunner.

Key files (such as the certificate needed to proxy traffic on simulator) are passed in
to the test runner from api.py (see https://chromium-review.googlesource.com/c/chromium/tools/build/+/1272236)
through a CIPD package installed and passed in through the wpr-tools-path flag.
Thanks Sergey for the tip!

For comments on WIP versions of this which can provide more insight, see here:
https://chromium-review.googlesource.com/c/chromium/src/+/1243565

Thanks!

Bug: 881096
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id2174a535ffc8a9941fc68062b0c7f69a75d80ab
Reviewed-on: https://chromium-review.googlesource.com/c/1263557
Commit-Queue: ericale <ericale@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599288}

Use TextViewWithClickableSpan for the subtitle text so that it responds
to accessibility events when the learn more link is appended to the end.
Also update the XML to make the root view focusable instead of the
scroll view, which fixes an issue where focus was previously going to a
child of the ScrollView instead of the container.

BUG=894844,757017

Change-Id: I737d3aa8cbe03064caa95065a6ce07ba41e6194e
Reviewed-on: https://chromium-review.googlesource.com/c/1278797
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599287}

This reverts commit d306c779.

Reason for revert: speculative revert, suspected of causing flakiness in ErrorPageAutoReloadTest tests. (see https://chromium-review.googlesource.com/c/chromium/src/+/1260491)

Original change's description:
> [CrOS MultiDevice] Enable multi-device features during OOBE.
> 
> This CL enables several multi-device flags by default. This resulted in
> lots of broken tests, so this CL also fixes those broken tests.
> 
> Instant Tethering is enabled via Finch flags; however, Finch does not
> immediately enable/disable features. Instead, when a user logs in, a
> Finch configuration is downloaded and is applied the next time the user
> logs in. Thus, to ensure that these features are available during OOBE,
> this CL overrides multi-device feature experiments during the first
> run. On subsequent logins, the Finch feature list will be applied.
> 
> Bug: 884066
> Change-Id: Ie12f3c62e766457456fd8a35e13168e6b35331ec
> Reviewed-on: https://chromium-review.googlesource.com/c/1260491
> Commit-Queue: Jeremy Klein <jlklein@chromium.org>
> Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
> Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
> Reviewed-by: Ben Wells <benwells@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Jeremy Klein <jlklein@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599223}

TBR=xiyuan@chromium.org,skuhne@chromium.org,khorimoto@chromium.org,benwells@chromium.org,asvitkine@chromium.org,jlklein@chromium.org,takumif@chromium.org

Change-Id: Icd73d0f4f859ab9ea6c0b4a0761d77a32a9bee15
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 884066
Reviewed-on: https://chromium-review.googlesource.com/c/1277577Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599286}

It is only called from RenderViewImpl, and just forwards to
RenderView::ApplyWebPreferences. We can just call that directly.

R=avi@chromium.org

Bug: 361761
Change-Id: Ifaf2d586b314d49506029fb9426d6d1cb1d63d67
Reviewed-on: https://chromium-review.googlesource.com/c/1278857Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599285}

This could be used to make consistent builds of Cronet before official builders are available.

Bug: 786559
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Change-Id: I5154f9e4461cdae1cbe07dc7e4309978d98d8508
Reviewed-on: https://chromium-review.googlesource.com/c/1273824Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599284}

Depending on which process the MediaCodec is running in, there may
already be a non-default looper and handler which results in stale
input/output indexes being delivered to the bridge after start().

To prevent this, we now call start() immediately after flush(),
but post the clearing of mPendingStart through the handler/looper.

A sequence counter is added so that rapid flush()/stop() calls
don't prematurely use invalid indices.

BUG=892591
TEST=Run chrome with --in-process-gpu and seek a bunch on any video.

Change-Id: I8c60a73b8c00c85a7ab3d253bc8df2397c1fa00d
Reviewed-on: https://chromium-review.googlesource.com/c/1278293Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599283}

The author of https://crrev.com/588577 did not realize the HUD layer
could be used for non-full-viewport rect debug information such as the
FPS meter. This patch restores the non-rect size logic from
https://crrev.com/588577 and adds a test of the FPS meter size.

Bug: 894717
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ied6d6c80e396ab59dbc201994db5214ed1db09a0
Reviewed-on: https://chromium-review.googlesource.com/c/1277658Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599282}

Bug: 721403
Change-Id: I266cafc445813b0305b00bbae8698542505cfcfc
Reviewed-on: https://chromium-review.googlesource.com/c/1274613Reviewed-by: Ben Greenstein <bengr@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599281}

Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I58cf3cdd266a2df589e28645888728a6333c7a6b
Reviewed-on: https://chromium-review.googlesource.com/c/1239900Reviewed-by: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599280}

Setting the virtual URL means that all UI surfaces will use the
"original" URL, that is, the origin URL where the content came from.
This should not affect any security features of Chrome, which should
be using the loaded URL, not the virtual one. Security-related UI that
are impacted are addressed as follows:
* Site Settings - explicitly disabled when a preview is shown
* Permissions Dialog - explicitly denied in r1260082

Adds virtual URL testing to HTTPS Previews browser tests and one
additional test for navigation actions.

Bug: 881938
Change-Id: I6e6f2e2a3ef267d61c18295f019d307adc9756bb
Reviewed-on: https://chromium-review.googlesource.com/c/1217351
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599279}

Note that these new histograms will help us understand more about the update
check error codes of the unified extension updater Finch experiment currently
running in Beta.


Bug: 722942
Change-Id: Ie20083437c8a06b7649c5ed01e91ac68357d84ca
Reviewed-on: https://chromium-review.googlesource.com/c/1271790
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599278}

Using wpt-import in Chromium 79df1ff1.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25976

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mkwst@chromium.org:
  external/wpt/trusted-types

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: I69e6efafb3ac195e0db73834a882c48e0270fddb
Reviewed-on: https://chromium-review.googlesource.com/c/1278929
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599277}

Demo mode enrollment flow.

Bug: 854101
Change-Id: I87111b78ee89c5acd242ce4808a23162dee038e0
Reviewed-on: https://chromium-review.googlesource.com/c/1252481Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599276}

This link was added following an old pattern in the Print Preview code,
which was originally for opening a new tab just before closing Print
Preview for a feature that has now been deleted. A standard link works
for the current use case and is simpler.

Bug: None
Change-Id: I63955ded5a6d7c67edfaee5d7dbb6dec4e6b9dbe
Reviewed-on: https://chromium-review.googlesource.com/c/1274837Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599275}

Creates a new entry in chrome://flags for the Ephemeral Tab
experiment which will present a "sneak peek" of a linked page in an Overlay.

Also remove the ModernFullRoll from chrome://flags.

BUG=894619, 856792

Change-Id: I9f9ea48d405eddd158e083231f4e88b0a5800dae
Reviewed-on: https://chromium-review.googlesource.com/c/1277681Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599274}

This no longer needs to be an action-link, since it is not opening
native dialogs or going through the C++ handler to correctly open cloud
print URLs with the correct user information. Instead, it is always
opening the chrome://settings printing page. This can be handled more
simply by using a normal link.

Bug: None
Change-Id: I9375ae0ac0c936aec379270f79f6130d054c1dcf
Reviewed-on: https://chromium-review.googlesource.com/c/1278527Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599273}

The only callers pass |this| for the view argument, so CHECK that it
isn't null and remove some dead code.

This simplifies an upcoming refactor in AXRemoteHost for mash.

TBR=msw@chromium.org

Bug: 888147
Test: existing unit tests
Change-Id: I93c9bb9ea5a9e55cbca5f51340625ffe60fe64d8
Reviewed-on: https://chromium-review.googlesource.com/c/1273991Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599272}

permission with devtools.

This was suggested a previous review:
https://chromium-review.googlesource.com/c/chromium/src/+/1233714/18/content/browser/devtools/protocol/browser_handler.cc#140

Bug: 886896
Change-Id: I41e850811da4c8d11f091b2fb0b49320af6cd0e4
Reviewed-on: https://chromium-review.googlesource.com/c/1278926Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599271}

https://webrtc.googlesource.com/src.git/+log/62b1345c850d..f7fee39547d8


git log 62b1345c850d..f7fee39547d8 --date=short --no-merges --format='%ad %ae %s'
2018-10-12 mbonadei@webrtc.org Remove rtc_base:rtc_base_generic.
2018-10-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d47784f2..c12ec9ee (599082:599188)
2018-10-12 sprang@webrtc.org Add mock_video_encoder.h to api/test
2018-10-12 danilchap@webrtc.org Mitigate miscalculation of rtp packet size
2018-10-12 artit@webrtc.org Restore "device type" for iOS internal.client.webrtc


Created with:
  gclient setdep -r src/third_party/webrtc@f7fee39547d8

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I4cc5d63780b7f3905730d1aa7d9a0793c7700cd2
Reviewed-on: https://chromium-review.googlesource.com/c/1278724Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599270}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/03ec3c699be2..3ae38f99451d


git log 03ec3c699be2..3ae38f99451d --date=short --no-merges --format='%ad %ae %s'
2018-10-12 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@3ae38f99451d

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I7d46734d85dc65bea29172fa9f9851581806de7f
Reviewed-on: https://chromium-review.googlesource.com/c/1278946Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599269}

https://helpx.adobe.com/security/products/flash-player/apsb18-35.html

BUG=412078
TBR=jschuh@chromium.org

Change-Id: I3cb6654ba0c45ef3f2ed8cfcece43638d6c5582e
Reviewed-on: https://chromium-review.googlesource.com/c/1278930Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599268}

BUG=893317

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8920fd240a55a32ee5dd27e049cc528193644dcf
Reviewed-on: https://chromium-review.googlesource.com/c/1273809
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599267}

This was created to allow scrollbars to be disabled in "browser action
popups". However the IPC is never actually used anymore.

In RenderViewImpl scrollbars are disabled when the size goes below a
limit and send_preferred_size_changes_ is true. Since the limit is
always 0, the size is always >= the limit, and so scrollbars are always
set to be shown.

The comments imply that we use this to /disable/ scrollbars when
send_preferred_size_changes_ is true, but now it would actually
enable them always when send_preferred_size_changes_ is true. Other
code does disable scrollbars on the LocalFrameView, so this would
override that code which seems like a bug that we must just not hit.

Instead of focusing scrollbars on for send_preferred_size_changes_,
we can just remove the code that changes scrollbar showing at all
from RenderViewImpl.

Found this while trying to detangle DisplayMode and VisualProperties.

R=ajwong@chromium.org, avi@chromium.org

Change-Id: Ifa34cbe7aa880c1787873f622967aea25d62d720
Bug: 419087
Reviewed-on: https://chromium-review.googlesource.com/c/1278164
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599266}

NSUserActivityTypeBrowsingWeb indicates to the system that the user is browsing a website. This allows iOS to suggest native apps that have claimed the domain in their associated domains rather than always suggesting Safari.

Change-Id: Ia08abb20f258f8dad474c081cfd59ff0d1666a9f
Reviewed-on: https://chromium-review.googlesource.com/c/1270882Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Sawyer Vaughan <sawyervaughan@google.com>
Cr-Commit-Position: refs/heads/master@{#599265}

Bug: 884075
Change-Id: I85829ee1e898296013c4ead98d4b9b39121a49d6
Reviewed-on: https://chromium-review.googlesource.com/c/1265121Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599264}

Change-Id: Iee1b81a1ff7eb256f7c12ddbff672337d59b964b
Reviewed-on: https://chromium-review.googlesource.com/c/1277926
Commit-Queue: Mike Reed <reed@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599263}

Change-Id: I5671d95901a93f227d14f24eb89d5cbfe588727b
Reviewed-on: https://chromium-review.googlesource.com/c/1277271Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599262}

This change updates Chromium to use CryptoOptions::Srtp fields to configure the
command line switches for WebRTC crypto instead of the old deprecated fields.

This API was changed in: https://webrtc-review.googlesource.com/c/src/+/105180

Once this change lands the top level fields:
  absl::optional<bool> enable_gcm_crypto_suites and
  absl::optional<bool> enable_encrypted_rtp_header_extensions

Will be removed and their replacements will be under the Srtp sub struct.

Bug: webrtc:9859
Change-Id: I3f140097b870da8a6dd6a691f05298775a468230
Reviewed-on: https://chromium-review.googlesource.com/c/1275025Reviewed-by: Florent Castelli <orphis@chromium.org>
Commit-Queue: Ben Wright <benwright@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599261}

Also change the default value of the "mainThreadTaskLoadLowThreshold"
param to 25 as it's the value we've used in all our Finch experiments.

Bug: 829933
Change-Id: If26ad7c87e97b325ba254ce5346e6becfb353899
Reviewed-on: https://chromium-review.googlesource.com/c/1277270Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599260}

and use it in TWAs to avoid toolbar flickering.

When TWA is opened, the toolbar shows for a fraction of a second before
disappearing. It happens because before finishNativeInitialization() is
called we either don't have a tab, or have one from a warmup that is not
yet attached anywhere. Thus the Tab#canShowBrowserControls() mechanism,
which would use TrustedWebActivityUi#mInTwaVisibilityDelegate as part of
ComposedBrowserControlsVisibilityDelegate doesn't allow to reliably hide
the toolbar in TWAs.

The alternative mechanism is ChromeFullscreenManager#setHideBrowserControlsAndroidView.
Using it as-is would be dangerous, though, because several clients would
now manipulate the same boolean. It needs a token mechanism like the one
implemented in BrowserStateBrowserControlsVisibilityDelegate.

I move the setHideBrowserControlsAndroidView into BrowserStateBrowserControlsVisibilityDelegate
and introduce tokens for persistent hiding. Persistent hiding has a
priority over persistent showing. Then I use persistent hiding in TWA
instead of an additional BrowserControlsVisibilityDelegate.

Bug: 891214
Change-Id: I0a1c2ee50f4dba5f07fb1d8f0fd1b8a9dd1cc6cf
Reviewed-on: https://chromium-review.googlesource.com/c/1256965Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599259}

Writes a snippet-hash and doc-id to UKM iff a command-line flag is
set that allows this development-only data to be logged. Disabled
on Beta and Stable channels.

See go/ukm-cs-5, go/ukm-dev-data, go/cs-sanitized for details.

Unfortunately our ContextualSearchDelegate cannot decode a JSON 64bit value
so we now expect to receive these new data in string format.

Also fix a bug in the existing Ranker code: the native logger cannot log
64-bit values, so we rename some misleading methods.  Also, we need to break
these new data up into high/low 32-bit values when we log to Ranker.

BUG=894568, 872902

Change-Id: Id0dd3ac218bafeb23396f010c340e5e5531799f0
Reviewed-on: https://chromium-review.googlesource.com/c/1264591Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599258}

No functional changes.

Bug: 876115
Change-Id: Id4a4008c6aff53ff4718b04d5c4186b97c769580
Reviewed-on: https://chromium-review.googlesource.com/c/1277987
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599257}

This is for the convenience of testing rlz ping. The normal waiting
time is 24 hours and it's unrealistic for testing team.

Bug: 894331
Change-Id: Ia5d6d38bc05221672d4ae4a0b6da4e221aaa0607
Reviewed-on: https://chromium-review.googlesource.com/c/1270012Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599256}