GitLab

BUG=708175
TBR=pwnall@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2893513002
Cr-Commit-Position: refs/heads/master@{#472278}

Add tests for certificates that pass X509CertificateBytes parsing, but fail in CertVerifyProc. Fix iOS.

BUG=711077,671420

Review-Url: https://codereview.chromium.org/2889813002
Cr-Commit-Position: refs/heads/master@{#472277}

This CL removes both android_webview_apk and android_webview_test_apk
build targets as we are deprecating those two names.

Please refer the crbug for more info, and the new target names are
webview_instrumentation_apk and webview_instrumentation_test_apk
correspondingly.

New build names are WebViewInstrumentation.apk and
WebViewInstrumentationTest.apk

BUG=701938

Review-Url: https://codereview.chromium.org/2879723002
Cr-Commit-Position: refs/heads/master@{#472276}

BUG=722320,722307

Review-Url: https://codereview.chromium.org/2883983005
Cr-Commit-Position: refs/heads/master@{#472275}

BUG=596760

Review-Url: https://codereview.chromium.org/2885003003
Cr-Commit-Position: refs/heads/master@{#472274}

The code related to update-webgl-conformance-tests hasn't been
touched in a long time, so I suspect it's unused.

BUG=677561

Review-Url: https://codereview.chromium.org/2890663002
Cr-Commit-Position: refs/heads/master@{#472273}

Setting the "WindowsTargetPlatformVersion" XML element seems to
be necessary in VS2017. Single-file compilations do not work
without it. It does not cause any problems in older VS versions.

R=brettw@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2858273002
Cr-Commit-Position: refs/heads/master@{#472272}

V8 CL rolled into V8 few days ago.

BUG=chromium:719008
TBR=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2885993002
Cr-Commit-Position: refs/heads/master@{#472271}

BUG=582836
TBR=kojii@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2885993003
Cr-Commit-Position: refs/heads/master@{#472270}

BUG=705115

Review-Url: https://codereview.chromium.org/2882213003
Cr-Commit-Position: refs/heads/master@{#472269}

1- TransferBufferManager is the only implementation. Devirtualize.
2- Refcounting is not needed, move to single-ownership.
3- Separating Initialize from the constructor is not needed, so merge.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I06eff971424c8400e48fdd75068614086c56a1c3
Reviewed-on: https://chromium-review.googlesource.com/506607Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#472268}

Currently, the default behavior when resizing ElementsPanel will switch from
vertical to horizontal mode when it's width is < 680px. At super small widths,
this makes the `Styles` and `Computed` views both tall and cramped for space.

This CL adds another rule when the width is < 415px, giving the `Computed` view
its own separate tab. A screenshot of DevTools at this width is in the crbug.

BUG=619064

Review-Url: https://codereview.chromium.org/2870163002
Cr-Commit-Position: refs/heads/master@{#472267}

Port https://sites.google.com/a/chromium.org/dev/developers/design-documents/threading/suble-threading-bugs-and-patterns-to-avoid-them to in-repo documentation.  This is a straight port is almost no content editing.

BUG=

Review-Url: https://codereview.chromium.org/2883903004
Cr-Commit-Position: refs/heads/master@{#472266}

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/693016

https://chromium.googlesource.com/chromium/src/+/79799bced99fd

BUG=719535
TBR=robertphillips@google.com

Review-Url: https://codereview.chromium.org/2887983004 .
Cr-Commit-Position: refs/heads/master@{#472265}

audio-testing.js no longer exists so remove references to this file.
These files weren't using anything from audio-testing.js anyway.

BUG=704967
TEST=none

Review-Url: https://codereview.chromium.org/2882783002
Cr-Commit-Position: refs/heads/master@{#472264}

Change-Id: I76afae213d8dfbaa61c76b33384b083cd5d3c4bc
Reviewed-on: https://chromium-review.googlesource.com/506464Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#472263}

Review-Url: https://codereview.chromium.org/2874233003
Cr-Commit-Position: refs/heads/master@{#472262}

Previously InterfaceFactoryImpl instances are using SrongBinding such
that they will only be destroyed on connection error. However, we could
hit an issue when MediaService is being destructed, the MojoMediaClient
is already destroyed, and an InterfaceFactoryImpl still tries to access
the MojoMediaClient.

This CL ensures that when MediaService is being destructed, all
InterfaceFactoryImpl will also be destroyed to avoid the issue.

BUG=721965

Review-Url: https://codereview.chromium.org/2884163002
Cr-Commit-Position: refs/heads/master@{#472261}

This patch makes sure the following names follows the JavaScript naming rules in the use_new_js_bindings mode:
- method names;
- parameter names;
- struct/union field names;
- namespaces.

BUG=718614

Review-Url: https://codereview.chromium.org/2889723002
Cr-Commit-Position: refs/heads/master@{#472260}

This patch changes the names of functions as follows:
PaintOpBuffer::approximateBytesUsed -> bytes_used
PaintOpBuffer::approximateOpCount -> size

Also changes related functions in other classes where appropriate.
Also changes the return type of new size function to be size_t.

R=enne@chromium.org, danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2884563004
Cr-Commit-Position: refs/heads/master@{#472259}

R=thakis@chromium.org
TBR=mseaborn@chromium.org
BUG=607968

Review-Url: https://codereview.chromium.org/2891513002
Cr-Commit-Position: refs/heads/master@{#472258}

This fixes an issue where extraneous flags were being set on some
devices and causing the flag check to fail.

BUG=719013

Review-Url: https://codereview.chromium.org/2881403003
Cr-Commit-Position: refs/heads/master@{#472257}

Revert of Temporarily remove unit tests which use real git and real filesystem. (patchset #1 id:1 of https://codereview.chromium.org/2892463002/ )

Reason for revert:
Should be OK to run these tests again (https://bugs.chromium.org/p/chromium/issues/detail?id=722975#c10)

Original issue's description:
> Temporarily remove unit tests which use real git and real filesystem.
>
> BUG=722975
> TBR=dpranke
> NOTRY=true
>
> Review-Url: https://codereview.chromium.org/2892463002
> Cr-Commit-Position: refs/heads/master@{#472223}
> Committed: https://chromium.googlesource.com/chromium/src/+/02e0ec9c924364de9287e06255649674a75493d1

TBR=dmazzoni@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=722975

Review-Url: https://codereview.chromium.org/2891443003
Cr-Commit-Position: refs/heads/master@{#472256}

Added some utility functions for cached offline pages:
Get sizes of all cached offline pages;
Delete all cached offline pages.
Also added the usage of cached offline pages to the number shown at:
Chrome Settings -> Privacy -> Clear Browsing Data -> Cache

BUG=716142

Review-Url: https://codereview.chromium.org/2860573004
Cr-Commit-Position: refs/heads/master@{#472255}

NOTRY=true

Review-Url: https://codereview.chromium.org/2885183002
Cr-Commit-Position: refs/heads/master@{#472254}

Reflects current team structure.

BUG=None
TBR=blundell

Review-Url: https://codereview.chromium.org/2888573002
Cr-Commit-Position: refs/heads/master@{#472253}

We track if the transform is 2d axis aligned since the last render target
during property tree building but it is not updated when we create an
effect node but not a render surface. This CL fixes that.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2885953002
Cr-Commit-Position: refs/heads/master@{#472252}

This CL is separate from the others because I want to have a discussion
about possible performance regressions before committing.

BUG=596760

Review-Url: https://codereview.chromium.org/2887883002
Cr-Commit-Position: refs/heads/master@{#472251}

There was an incorrect assumption about how ThreadChecker worked which lead
to several classes not having the d'tor guarantees they expected.  The
assumption was that a ThreadChecker would DCHECK if it was not destroyed on
the same thread it was bound to.  This is not correct so I am adding DCHECKs
to the d'tors of the remoting classes which were missed.

BUG=715633

Review-Url: https://codereview.chromium.org/2888733002
Cr-Commit-Position: refs/heads/master@{#472250}

BUG=723086
NOTRY=true
TBR=horo@chromium.org

Review-Url: https://codereview.chromium.org/2885173003
Cr-Commit-Position: refs/heads/master@{#472249}

Now that we've addressed all of the known causes of crashes, it's time to
reenable.

BUG=708570

Review-Url: https://codereview.chromium.org/2887773003
Cr-Commit-Position: refs/heads/master@{#472248}

Since most "isAttribDirty()" methods were already const, require it
in the docs and via casting in the generated code to ensure that the
check is idempotent. Mostly for consistency, but this prevents us
from triggering unexpected side effects in future optimizations.

Update the one place (navigator.languages) where a non-const method
was being used.

Review-Url: https://codereview.chromium.org/2884493002
Cr-Commit-Position: refs/heads/master@{#472247}

Before this CL, ModuleTreeLinker::Instantiate assumed that it is only called for
modulator with a valid context. However, asynchronous module graph node load
completion may be triggered after the context was destroyed.

This CL fixes the issue by making ModuleTreeLinker::Instantiate fail without crashing
if the context is invalid.

BUG=594639,716935

Review-Url: https://codereview.chromium.org/2886593002
Cr-Commit-Position: refs/heads/master@{#472246}

Just a first pass, more to come later.

BUG=722551
TEST=No Chrome OS shelf changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2888623005
Cr-Commit-Position: refs/heads/master@{#472245}

They should no longer be needed after https://codereview.chromium.org/2851523002
and https://chromium-review.googlesource.com/497271

BUG=716117

Review-Url: https://codereview.chromium.org/2884303002
Cr-Commit-Position: refs/heads/master@{#472244}

This removes the last UsbService*::Create() method taking a
SequencedTaskRunner, allowing us to start cleaning up DeviceClient as
well.

BUG=None

Review-Url: https://codereview.chromium.org/2885143002
Cr-Commit-Position: refs/heads/master@{#472243}

Revert of Enable DCHECKs by default in non-official builds. (patchset #3 id:40001 of https://codereview.chromium.org/2886803002/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 472195 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzg3NWEyZmE0M2NhYWIwZWU4MmVmZTY4ZmI1YWRiMzU3MzkyNDM0YWQM

Original issue's description:
> Enable DCHECKs by default in non-official builds.
>
> BUG=722827
> TBR=sdefresne@chromium.org for ios/
>
> Review-Url: https://codereview.chromium.org/2886803002
> Cr-Commit-Position: refs/heads/master@{#472195}
> Committed: https://chromium.googlesource.com/chromium/src/+/875a2fa43caab0ee82efe68fb5adb357392434ad

TBR=brettw@chromium.org,thakis@chromium.org,sdefresne@chromium.org,gab@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=722827,723090,723049

Review-Url: https://codereview.chromium.org/2892473002
Cr-Commit-Position: refs/heads/master@{#472242}

The method was removed in https://codereview.chromium.org/193663003 but
not the declaration. Also make P2PSocketClient's constructor protected
like the destructor as there is no way to create it without subclassing
anyway.

BUG=none

Review-Url: https://codereview.chromium.org/2865303003
Cr-Commit-Position: refs/heads/master@{#472241}

https://codereview.chromium.org/2882383002 introduced this virtual
test suite, breaking expectations for a couple of tests that need to be
excluded for --site-per-process.

BUG=477150
NOTRY=true

Review-Url: https://codereview.chromium.org/2888733003
Cr-Commit-Position: refs/heads/master@{#472240}

Came up in https://codereview.chromium.org/2878133002/
(calling the wrong function ate up 1hr+ debugging)
(this cl also depends on that one)

BUG=NONE
TEST=NONE
R=sky@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2889443002
Cr-Commit-Position: refs/heads/master@{#472239}