- 01 Nov, 2019 40 commits
-
-
John Budorick authored
Bug: 1001171 Change-Id: Ic27ad2d1291061bc17fb9499ba3e142e81d53a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895168 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#711860}
-
Kevin McNee authored
The win7 bots do not seem to recognize the MANUAL_ prefix, so we explicitly disable these tests as they are being run and are flaking. Tbr: jamiewalch@chromium.org Bug: 1020591 Change-Id: Ia54d48b9424c0cc048d442bf47fd3bccf8b2e907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895867Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#711859}
-
Ted Meyer authored
This happens synchronously with the destruction of WebMediaPlayerImpl so that the devtools backend for MediaLog knows it shouldn't be sending events since the page may have been destroyed. Events that happen after WEBMEDIAPLAYER_DESTROYED get dropped from _only_ the devtools version. This should fix the nullptr deref bug caused by the destruction order of the blink objects and the WebMediaPlayerImpl::DestructionHelper. Bug: 794255 Bug: 1014433 Change-Id: I25e2110a31561367baf7104c77a8e5301b5afb0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891078 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#711858}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c93813be129d..9dd3e34fd3c3 git log c93813be129d..9dd3e34fd3c3 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 skyostil@google.com Merge "TrackEvent: Add support for arguments" Created with: gclient setdep -r src/third_party/perfetto@9dd3e34fd3c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Idcccd7adc663194217ef7cb0ada6f9edc5f3618d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895792Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711857}
-
Nic Champagne Williamson authored
This change adds support for the Windows system high contrast (HC) colors to themes, native themes, and typography. These platform-provided colors will take precendence and override normal colors when HC mode is enabled on Windows. This change will be followed up by further commits to enable HC colors to be used for interactive elements and the ink drop, and better specific implementations for various controls. The NativeTheme::ColorScheme has been updated to include a value for when the platform is providing the HC colors. This is currently only used on Windows when HC mode is enabled and a specific theme isn't requested. When in HC mode, the Windows native theme will return specific system colors for the color IDs. ThemeService has been updated to work in a similar manner, checking for HC mode on Windows and returning specific system colors as needed. Additionally, the IncreasedContrastThemeSupplier has been turned off for Windows HC. The typography provider has been updated to provided better style/context to color ID mappings. The title bar is now always custom drawn on Windows 10 even in HC mode. Bug: 956295 Change-Id: Ibc92dfcab5f94c06cc628b7338b8d9cfac905332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887931 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#711856}
-
Lei Zhang authored
- Don't use ntp_tiles:: inside namespace ntp_tiles. - Consistently drop curly braces for 1 line if-statements. Change-Id: I67706595e1ccd13c0a059e6297c854a838d12f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895790Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#711855}
-
Megan Jablonski authored
Bug: 976352 Change-Id: Ia17703673ddbeac77c3ce458dfc431db351c13e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877148Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#711854}
-
Andrew Xu authored
When the hidden icon of the scrollable shelf receives the a11y focus, scrollable shelf should show the icon by translating the shelf view. Bug: 1016028 Change-Id: I90013aa4fc07ed296cffdb6f02809e15f5377fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891111Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711853}
-
Lucas Furukawa Gadani authored
This CL adds a parser for parsing report endpoints on the network service. This will allow the browser enforced frame-ancestors CSP to report CSP violations using the reporting API. Bug: 759184 Change-Id: I015829a93eb30b52d77bcc34ced535ddf40621f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838159 Commit-Queue: Lucas Gadani <lfg@chromium.org> Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#711852}
-
Jeremy Apthorp authored
fixes this build error in MSSTL: ../../ui/events/blink/prediction/linear_resampling.cc(82,12): error: no member named 'min' in namespace 'std' std::min(kResampleMaxPrediction, events_dt_ / 2.0); ~~~~~^ ../../ui/events/blink/prediction/linear_resampling.cc(85,12): error: no member named 'min' in namespace 'std' std::min(sample_time, events_queue_[0].time_stamp + max_prediction); ~~~~~^ 2 errors generated. Change-Id: I412007ebe847afaa667bb606c01e2d5453123089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893754Reviewed-by:David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: Jeremy Apthorp <jeremya@chromium.org> Cr-Commit-Position: refs/heads/master@{#711851}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/27bd02bf2385..840ecb38c04e git log 27bd02bf2385..840ecb38c04e --date=short --no-merges --format='%ad %ae %s' 2019-11-01 perezju@chromium.org [Telemetry] Move DummyStory and friends to test_stories Created with: gclient setdep -r src/third_party/catapult@840ecb38c04e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:1008852 Change-Id: I243b6775e2d872c0cebaf8a67c4855b0e302099d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895815Reviewed-by:
-
Robert Ogden authored
see bug for more details Bug: 1020612 Change-Id: I1e43f21c65630b12e6d35b96cef6120d4f49d8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895781Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#711849}
-
Greg Thompson authored
R=sky@chromium.org Bug: 546640 Change-Id: I597edb708f20b74b54769dee7eaf813606154e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895656 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Eugene But authored
GetLocationBarSecurityIconTypeForSecurityState is called in downstream test without passing should_downgrade flag. This is the follow up change for crrev.com/c/1884428 which broke that test compilation. Bug: 1020670 Change-Id: If70880dad334f9485f54911d2bd46cf2e0eb2f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895866Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#711847}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/23e856f36982..6751f171c662 git log 23e856f36982..6751f171c662 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 borenet@google.com [recipes] Assert that Git is obtained from CIPD 2019-11-01 borenet@google.com [infra] Make CheckGeneratedFiles use git from CIPD 2019-11-01 mtklein@google.com opaque shaders and srcover -> src 2019-11-01 mtklein@google.com get rid of Uniforms 2019-11-01 michaelludwig@google.com Refactor tessellation metadata to move towards independent inset/outset calculations 2019-11-01 mtklein@google.com paint color -> shader 2019-11-01 mtklein@google.com paint alpha scaling as its own effect 2019-11-01 senorblanco@chromium.org Dawn: fix RTHeight adjustment. 2019-11-01 robertphillips@google.com Reduce max # of AA Quads that can be merged or chained into a single GrTextureOp 2019-11-01 halcanary@google.com tools/git-sync-deps: enforce commit hash in DEPS, not tags or branches 2019-11-01 egdaniel@google.com Use GrSurfaceProxyView for dst proxies. 2019-11-01 mtklein@google.com add --quick to fm 2019-11-01 michaelludwig@google.com Remove extraneous semicolons Created with: gclient setdep -r src/third_party/skia@6751f171c662 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: chromium:b/143572065 Change-Id: I2758547dbcbd8fa0e9af7632f6ceedf7fc6efb80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894690Reviewed-by:
-
Ben Pastene authored
Format all the things! Change-Id: I33f02e6e21c4388f381b35e06394fb916bfddddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891735 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#711845}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/540178c7543f..ab7bec343496 git log 540178c7543f..ab7bec343496 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 danakj@chromium.org Make find_owners_test.py pass consistently. Created with: gclient setdep -r src/third_party/depot_tools@ab7bec343496 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I8182099a591eb07f6dd01b62ec2870da575f6d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895777Reviewed-by:
-
Daniel Hosseinian authored
That is the only GN file in the pdf/ subdirectory. Bug: 1020676 Change-Id: I2495ab9b5976957270298b8aed703f4d4c858844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895865Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#711843}
-
Dana Fried authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1880531, we fixed the case where a separator would not properly fill its bounds. However that broke functionality where a spacer was being used as e.g. a vertical separator in a text flow with insets on either side (see attached bug). This solution does both: - when there is no inset on a particular side of the separator, the separator is guaranteed to draw flush with the edge of the view - when there is an inset, the inset is guaranteed to be preserved, with the old behavior of the separator being adjusted to draw only on whole pixels in DPI-scaled environments (minimum of 1px in either dimension) Fixes: 1019503 Bug: 1019503 Change-Id: I97dd487ba2374000dcef76e43665ef44eb93acd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894253 Commit-Queue: Dana Fried <dfried@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
-
Dave Tapuska authored
Move FrameMsg_DispatchLoad to a RemoteFrame mojo interface. BUG=1008432 Change-Id: I295fbd94a719b84ade286d3a19b9422a7d5296a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874204 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#711841}
-
gogerald authored
Bug: 1020223 Change-Id: I974a7d8bea365b62134f28ce947c9b2c090bb712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894294 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711840}
-
Anastasia Helfinstein authored
Bug: 897365 Change-Id: I5bec4d7ac57d2873b04f9d7db24b6efd088b9c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880370 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#711839}
-
Kevin McNee authored
This reverts commit 91d5b592. Reason for revert: Suspect for fuchsia compile failure https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-cast/58519 Original change's description: > Add ESNI response-processing glue > > This CL adds logic processing ESNI DNS responses and surfacing the > results via ResolveHostRequest. It contains some nontrivial > functionality and some boilerplate. > > The nontrivial functionality (host_resolver_manager.cc and unittests): > - adds the addresses from ESNI records to the > *address list* contained in the HostCache entry, so that existing > TCP connection logic will be able to connect to ESNI-accompanied addresses > in the same manner as addresses without ESNI keys. Before sorting the > addresses, partition them on whether or not they have accompanying ESNI > keys, so that the stable sort in AddressSorter implicitly breaks ties > in favor of addresses associated with ESNI keys. > > The boilerplate (all changes except HostResolverManager): > - extends all "expect only one field is present" logic in prior > host_resolver_manager unittests to reflect that there's now another > field > - extends all switches on DnsQueryType to accommodate DnsQueryType::ESNI > - extends all subclasses of ResolveHostRequest to implement > GetEsniContent() > > Testing: > - Adds a new group of HostResolverManager unittests for ESNI queries. > > R=ericorth > > Bug: 1003494 > Change-Id: I49a18dd4937737c2d22d0fc0357b9e6a3a40e7d4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874248 > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Eric Orth <ericorth@chromium.org> > Commit-Queue: David Van Cleve <davidvc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711827} TBR=palmer@chromium.org,ericorth@chromium.org,davidvc@chromium.org Change-Id: I96ab805e0bcb3a75311652452a6d7d54ab7778d7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1003494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895965Reviewed-by:
-
Aaron Leventhal authored
For now, the best decision on pure CSS tables is to keep doing what we're doing, which is to expose them as tables, and provide the possibility to navigate the layout like a table. Enough screen reader users, and the developers of ChromeVox and JAWS, want to keep it the way we have it, even though Firefox no longer exposes CSS tables as tables. Potentially, screen readers may wish to provide less verbose announcements on layout tables. This is already possible. Some useful object attributes for this are display, tag, xml-roles and layout-guess. Bug: 1020180 Change-Id: I2b1e2cbe1d3d7c7443dce1cd30d83bfce905052a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894039 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#711837}
-
Greg Thompson authored
During service teardown, tasks are posted to the TestMockTimeTaskRunner to close open files. These must be run during TearDown so that files can be closed, thereby allowing the ScopedTempDir to clean itself. Bug: 546640 Change-Id: Ibdfa0cc63f79f27237040765777fed344f7ad7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895337 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#711836}
-
Daniel Murphy authored
This CL should remove all of the remaining dependencies of the LevelDBScopes system on content/ and the parent indexed_db/ directory. Bug: 1015212 Change-Id: I3983ced78a5d0c312d3fa443fdf3ab7d06644b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890963 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#711835}
-
Dave Tapuska authored
We don't want to receive messages after we are detached so ensure we reset the receiver on detach. BUG=1020551 Change-Id: Iddc8a8a9e1e8f9e998845c876e544c0b770cdfe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894918 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This CL moves all headers from t_p/blink/public/platform/modules/peerconnection to t_p/blink/renderer/platform/peerconnection. This is part of phase 10 as per the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I61d588c2645d30476925a5b13cda9671472ea8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881189 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#711833}
-
Lei Zhang authored
Change-Id: I5c0d2fef2be40763babc8bd604df7e160551f645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895318Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#711832}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/26452ff7db33..8846c8af8511 git log 26452ff7db33..8846c8af8511 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 alessiob@webrtc.org RNN VAD: cast and scale quantized weights at init Created with: gclient setdep -r src/third_party/webrtc@8846c8af8511 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ic885978c1dec1dd4d2cf1c60972a0dae2c07787f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895776Reviewed-by:
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=cmp@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I16d494598742895af2f080160a5c9a711e4bb79e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894881 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#711830}
-
Ken Rockot authored
On Android we can somehow observe utility process crashes without observing process launches. This is a simple fix to avoid memory bugs in that case. Also fixes a related leak in the internal ServiceProcessTracker, where we were never cleaning up ServiceProcessInfo entries after process termination. Bug: 1016027 Change-Id: Ia5a8df891547cb7a2f01c869d16b014a8b249423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894627Reviewed-by:
-
Rodney Ding authored
- New doc explaining how to initialize blink features in content layer - Update feature flag guides to point to the new doc Bug: 832393 Change-Id: Id0cd47a2b926c55e15516242cbf6382e199b1537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873991Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Rodney Ding <rodneyding@google.com> Cr-Commit-Position: refs/heads/master@{#711828}
-
David Van Cleve authored
This CL adds logic processing ESNI DNS responses and surfacing the results via ResolveHostRequest. It contains some nontrivial functionality and some boilerplate. The nontrivial functionality (host_resolver_manager.cc and unittests): - adds the addresses from ESNI records to the *address list* contained in the HostCache entry, so that existing TCP connection logic will be able to connect to ESNI-accompanied addresses in the same manner as addresses without ESNI keys. Before sorting the addresses, partition them on whether or not they have accompanying ESNI keys, so that the stable sort in AddressSorter implicitly breaks ties in favor of addresses associated with ESNI keys. The boilerplate (all changes except HostResolverManager): - extends all "expect only one field is present" logic in prior host_resolver_manager unittests to reflect that there's now another field - extends all switches on DnsQueryType to accommodate DnsQueryType::ESNI - extends all subclasses of ResolveHostRequest to implement GetEsniContent() Testing: - Adds a new group of HostResolverManager unittests for ESNI queries. R=ericorth Bug: 1003494 Change-Id: I49a18dd4937737c2d22d0fc0357b9e6a3a40e7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874248Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#711827}
-
Ryan Daum authored
rounded_window_corners_default.cc was missing from the build target. Bug: internal b/141369549 Test: unit test Change-Id: Ib25fd665e630f2c115f420bc4f6d5b7e3dfe3a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895868Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#711826}
-
Alexander Timin authored
Use a weak ptr factory instead of a base::Unretained to ensure that we don't get a UAF after deleting BackgroundTaskUpdateScheduler or cancelling a task. R=agrieve@chromium.org,tiborg@chromium.org BUG=880565 Change-Id: Ib6ce448625b3bbb99776dec75d3e8110ab987a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895659Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
Henrique Nakashima authored
Use this to add verifications that the expected calls are made to BackgroundTaskSchedulerExternalUma. Bug: 1017130 Change-Id: Ica99e12df6d1d655f1d2fdba8ad20b5065a2170a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884821Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#711824}
-
Kevin McNee authored
The win7 bots do not seem to recognize the MANUAL_ prefix, so we explicitly disable this test as it is being run and is flaking. Tbr: reillyg@chromium.org Bug: 1020591 Change-Id: I8dea9bc8f0e3ef23bb733c9912e0011c5ac4253e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895798Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#711823}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b1ae70fb..5689bf7c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5d82f1cd93488c34cdb5c5a6f3888edfb9210e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895394Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711822}
-
Yue Zhang authored
This CL adds TabGroupsContinuation feature flag and hide tab group naming and selection-mode in dialog behind this flag. Also, unit tests are added to make sure the flag setup is properly reflected. Bug: 1018841 Change-Id: I88737144e710b694f3cccf4a1b7a5f0763916a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885016Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#711821}
-
