- 13 Sep, 2018 40 commits
-
-
Chris Palmer authored
It's not safe, so call that out. Bug: 880974 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I9c2e4eb8116c12270aa776fd17db893b46b473d7 Reviewed-on: https://chromium-review.googlesource.com/1222284Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#591207}
-
David Black authored
Sometimes, but not always, we receive an empty speech recognition result when an interaction is resolving due to mic timeout. When the mic times out we discard the interaction, so we shouldn't commit the pending query. Bug: b:115513980 Change-Id: I0122c3b6a21d2df0cd79a87410dc15396178cf4c Reviewed-on: https://chromium-review.googlesource.com/1222250Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#591206}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d7d11650ca37..71ddeb9859d4 git log d7d11650ca37..71ddeb9859d4 --date=short --no-merges --format='%ad %ae %s' 2018-09-13 bhthompson@google.com Adjust release branch timing Created with: gclient setdep -r src/third_party/chromite@71ddeb9859d4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If4428c75f6bc7bfeff5f611c70267f2ab6c06a23 Reviewed-on: https://chromium-review.googlesource.com/1225311Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591205}
-
Ryan Sturm authored
This reflects changes in https://chromium-review.googlesource.com/c/chromium/src/+/1225095 that added Bloom filter to the blacklist component. Change-Id: Icfb9e266a54c88c5306811feec07d30df0a63680 Reviewed-on: https://chromium-review.googlesource.com/1225491 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#591204}
-
Istiaque Ahmed authored
The root cause is fixed by https://crrev.com/b8e24bdbf6bbe43bc32fd684f2a0aad914e804d2 and the test doesn't flake locally or on trybots anymore. Bug: 834200 Change-Id: I0bca3a12374cb70554c73063d7913dfbeec78e07 Reviewed-on: https://chromium-review.googlesource.com/1225700Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#591203}
-
Sean Topping authored
This is necessary for content apps which obscured by an opaque overlay (such as the remote control overlay), but still want to be treated as fully visible. Bug: internal b/113950519 Test: None Change-Id: Ifc2923e91900845e33a90bb832d05586ea711990 Reviewed-on: https://chromium-review.googlesource.com/1226261Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#591202}
-
Darren Shen authored
Bug: 882340 Change-Id: I0897afd6e048816630c22a3e714829f3c685a0e4 Reviewed-on: https://chromium-review.googlesource.com/1215460 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#591201}
-
Weilun Shi authored
Now, the browser will not load the rest of the tile images until the first N tile images finished loading. Now the N set to 9 which is the default number of tiles will show in the custom background dialog. Screencast on fast network: https://screencast.googleplex.com/cast/NDc0OTAyNTE5MDM0Njc1Mnw1OTJjZmIyNy1kOA Screencast on slow network: https://screencast.googleplex.com/cast/NjY0MDQ4NzU4MjY2MjY1Nnw3ZmZkNGY5Ni00Zg Bug: 876814 Change-Id: Id7f9e3e9538399f7fb64a68b7723ca39d6f19d65 Reviewed-on: https://chromium-review.googlesource.com/1220183 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#591200}
-
Kevin Strohbehn authored
This reverts commit b08f82e9. Reason for revert: Causing issues with framerate and keyboard while folder is open Original change's description: > Folder Should no longer travel with users between pages > > Bug: 880975 > Change-Id: I4a4a41833e4312c8a78ff6b74897e539bf456d1f > Reviewed-on: https://chromium-review.googlesource.com/1220057 > Reviewed-by: Weidong Guo <weidongg@chromium.org> > Commit-Queue: Kevin Strohbehn <ginko@google.com> > Cr-Commit-Position: refs/heads/master@{#590751} TBR=weidongg@chromium.org,ginko@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 880975 Change-Id: I107c456e6654b9808316314d5f53ded082041fc3 Reviewed-on: https://chromium-review.googlesource.com/1226197Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#591199}
-
Ehsan Karamad authored
This reverts commit d3358a99. Reason for revert: The test seems to be very flaky. Bug: 883965 Original change's description: > Make 'web_view_browsertest.cc' BrowserPlugin-free > > This CL removes and converts the last remaining BrowserPlugin-based test > to chrome_mime_handler_view_browsertest.cc (the new test uses a > MimeHandlerViewGuest). > > Bug: 553069, 330264 > Change-Id: I487fbd47ca0c989e746d087c72fe396f9e9ac867 > Reviewed-on: https://chromium-review.googlesource.com/1221693 > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591115} TBR=ekaramad@chromium.org,wjmaclean@chromium.org Change-Id: I60e4bc6872645cb1be4de70d19f41c1c4e6e51b6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 553069, 330264 Reviewed-on: https://chromium-review.googlesource.com/1226202Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#591198}
-
Takumi Fujimoto authored
Put the Cast toolbar icon in pressed state while showing the Media Remoting dialog. Bug: 854374 Change-Id: Ie75f7905e7c796375ec85075a56bbdf15c73d36c Reviewed-on: https://chromium-review.googlesource.com/1191063Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#591197}
-
Taylor Bergquist authored
Sets the DPI awareness context on the UI thread to per monitor v2 at startup, and on file dialog threads immediately after creation. Bug: 624992 Change-Id: I86ae30e7deeedc207159c5a0672ad727d55ff388 Reviewed-on: https://chromium-review.googlesource.com/1212184Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#591196}
-
Christian Biesinger authored
Many users of constraint space never use it. This is accomplished by introducing a wrapper class (thanks Ian for the suggestion) which internally manages the actual exclusion space pointer (now called NGExclusionSpaceInternal). It has the same interface as the old NGExclusionSpace but does not require memory allocation until you add an exclusion (comparatively rare). As a minor cleanup, this also changes two NGLayoutResult constructor arguments to use rvalue references, which they effectively already were. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I2c83ba64443bc45f7e328f8d5663d5a4867885a5 Reviewed-on: https://chromium-review.googlesource.com/1222270 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#591195}
-
Aga Wronska authored
The subtitle text is not suitable for demo mode setup as there is no data restoration performed in demo mode. Bug: 883530 Test: Manually verified network screen in OOBE and in demo mode setup. Change-Id: I3e70b4a963f336e59547b64b7a710c99a57ce0f6 Reviewed-on: https://chromium-review.googlesource.com/1222448Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#591194}
-
Jamie Madill authored
This affects a few EGL enums ANGLE was using via exposed extensions. We were incorrectly using enums from an unallocated block instead of the ones allocated to ANGLE. Reported by dan.glastonbury@gmail.com. Bug: angleproject:2806 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4e96fa81faf4092ec9ea4d17e0ee24ad172fb042 Tbr: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1225863Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#591193}
-
Raymond Toy authored
Speculative fix similar to the fix for issue 882734. Bug: 882669 Change-Id: I128ed1b1d9af368237cc35ad30daaeba1fae5583 Reviewed-on: https://chromium-review.googlesource.com/1220688Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#591192}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/77ed83d5a5e4..d42dfd429be3 git log 77ed83d5a5e4..d42dfd429be3 --date=short --no-merges --format='%ad %ae %s' 2018-09-13 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-09-13 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@d42dfd429be3 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If80ae0dc26a36ed142c1819f1111ca596214db99 Reviewed-on: https://chromium-review.googlesource.com/1226011Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591191}
-
David Black authored
Locale needed to display proper I18N strings. Bug: b:115667092 Change-Id: Id5f19ba545d488695a4142b7210b386ddb56af1b Reviewed-on: https://chromium-review.googlesource.com/1225932Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#591190}
-
Christian Fremerey authored
This fixes a deadlock issue in test-only code fake_v4l2_impl.cc. Bug: 883941 Change-Id: Ie6de0e026d79cd3559852e255e464e1abbf4a564 Reviewed-on: https://chromium-review.googlesource.com/1225973Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#591189}
-
Istiaque Ahmed authored
The root cause is fixed by https://crrev.com/b8e24bdbf6bbe43bc32fd684f2a0aad914e804d2 and the test doesn't flake locally or on trybots anymore. Bug: 855800 Change-Id: I316b876de5e993f1d41bb12cc040ac9e1dccd0e0 Reviewed-on: https://chromium-review.googlesource.com/1226071Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#591188}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bc6b9cb6ac40..9548ea9d6ce1 git log bc6b9cb6ac40..9548ea9d6ce1 --date=short --no-merges --format='%ad %ae %s' 2018-09-13 caryclark@skia.org fix bookmaker 2018-09-13 caryclark@skia.org update generated includes 2018-09-13 mtklein@google.com pin in Sk4f_toL32() 2018-09-13 michaelludwig@google.com Implement sweep gradient layout 2018-09-13 stani@google.com Add GrSurfaceOrigin to MakeFromAHardwareBuffer Created with: gclient setdep -r src/third_party/skia@9548ea9d6ce1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/115610873 TBR=caryclark@chromium.org Change-Id: Ic34aa7a6b9c022c7a68c8b4f0ed7820714dc7605 Reviewed-on: https://chromium-review.googlesource.com/1225314Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591187}
-
James Cook authored
It isn't used. It was added when the app list code wasn't in ash. Also remove some comments mentioning "bubble" mode, which I don't think we support any more. Bug: none Change-Id: I4f3bf461dfe3dca00399290274f6a7be2520f224 Reviewed-on: https://chromium-review.googlesource.com/1225870Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#591186}
-
James Cook authored
It was the only subclass of WorkspaceEventHandler, so fold it into the superclass. This is left over from pre-WS2 mustash, when we had a separate ash config for mash. Bug: 842365, 866528 Test: ash_unittests, double-click window borders to resize windows Change-Id: I5de319afb6e8e00b51130a9099fc7c3e9ef70cfc Reviewed-on: https://chromium-review.googlesource.com/1225596Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#591185}
-
Shakti Sahu authored
Added ability to add observers interested in only a single OfflineItem. Bug: 881499 Change-Id: I0b221071a0d7e258778fd37f668c8e0c5a8c2c26 Reviewed-on: https://chromium-review.googlesource.com/1213963Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591184}
-
Yiming Zhou authored
In the first attempt to add a DidCommitAndDrawCompositorFrame event to Chrome, I used the wrong message mechanism and inadvertently caused a massive performance regression (Change Ic1d349fd80cc1f877a3a8a604ec4266452a8186d). A subsequent fix (change I20e6fa6dbe1fd30f1529d6dda20e6208ae719bd1) removed the faulty queue message call, but also silenced the event. This fix reintroduces the event so that WebContentsObserver can monitor Chrome paint events. Bug: 854828 Change-Id: I65b31f3328a8882fa96a544a737f5213dac9a680 Reviewed-on: https://chromium-review.googlesource.com/1154139Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Yiming Zhou <uwyiming@google.com> Cr-Commit-Position: refs/heads/master@{#591183}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1eb6866c..6d775183 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If7b183949ef876eab578dc2e53fb538be89043cb Reviewed-on: https://chromium-review.googlesource.com/1225305Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591182}
-
Eric Karl authored
This reverts commit 0dd63a33. Reason for revert: Causes flakiness for a large number of tests. See crbug.com/882951 Original change's description: > Canvas/WebGL: Defer commits to limit queued frames. > > This change adds more backpressure to Canvas/WebGL rendering in GPU > bound situations. > > Before, the renderer could have three or four frames of drawing commands > queued and waiting for execution by the GPU process. The GPU process > does not know which drawing commands are associated with which display > frame. Sometimes it would run multiple frames of queued drawing commands > in one display frame, causing frame rate hiccups. > > Now when the TextureLayer has more than one buffer in flight, it calls > DeferCommits to block the next requestAnimationFrame callback from > running until one of the buffers is returned, indicating that the GPU > process has executed the commands for that frame. The shorter pipeline > reduces latency and prevents the GPU process from trying to execute > multiple Canvas/WebGL frames in one display frame. > > Bug: 835353, 879658 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I7e5484add5fbd79757b205b1124ed7c2c5836dbb > Reviewed-on: https://chromium-review.googlesource.com/1199699 > Commit-Queue: Eric Karl <ericrk@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589784} TBR=chrishtr@chromium.org,sunnyps@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 835353, 879658, 882951, 883364, 883358, 883057, 882618 Change-Id: I3bee10c8f43c2868966cedb638afbb4b0d9babab Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1224456 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#591181}
-
Doug Arnett authored
Change-Id: I65631f9beb7afc7973c0dcd6bd7b14e158a82c00 Reviewed-on: https://chromium-review.googlesource.com/1224639 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#591180}
-
xlou authored
Currently N-up conversion uses physical page size to fit N pages onto one sheet. So we need to fit the N-upped document into printable area before sending to the UI or a printer. In printing, 2-up, 3-up, or more generally N-up refers to a page layout strategy in which multiple pages are composited onto a single page. Bug: 775999 Change-Id: Ie5a80aa89979fecb08b9acc16c2aae47b7ce914e Reviewed-on: https://chromium-review.googlesource.com/1204854 Commit-Queue: Shirleen Lou <xlou@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#591179}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dc899dce9e2e..c0af56b9fb65 git log dc899dce9e2e..c0af56b9fb65 --date=short --no-merges --format='%ad %ae %s' 2018-09-13 srte@webrtc.org Cleanup in congestion controller. 2018-09-13 srte@webrtc.org Print filename on open failure in FrameGenerator. 2018-09-13 srte@webrtc.org Cleanup in rate controller. 2018-09-13 ssilkin@webrtc.org Revert "Remove APM internal usage of EchoCancellation" 2018-09-13 buildbot@webrtc.org Roll chromium_revision aa7696e4..e3170c4f (590812:590991) 2018-09-13 ivoc@webrtc.org Implement new stats interface on NetEq to monitor the operations and internal state. 2018-09-13 ilnik@webrtc.org Calculate NtpCaptureStartMs using clock, not the frame rtp timestamp 2018-09-13 mbonadei@webrtc.org Fix no_{global_constructors,exit_time_destructors} in audio device alsa. 2018-09-13 saza@webrtc.org Remove APM internal usage of EchoCancellation 2018-09-13 henrika@webrtc.org Removes flaky thread checker in AudioDeviceBuffer. 2018-09-13 philipel@webrtc.org Added is_last_packet_in_frame to match is_first_packet_in_frame. Created with: gclient setdep -r src/third_party/webrtc@c0af56b9fb65 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:b/115385789 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I45c85df703ceceebbf8eef7dc6ceb61d11bc1434 Reviewed-on: https://chromium-review.googlesource.com/1225312Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591178}
-
Min Qin authored
This CL splits OfflineItemModel into OfflineItemModelData and OfflineItemModel. OfflineItemModelData is equivalent to DownloadItemModelData, which stores the long lasting states that need to be accessed by UI code. OfflineItemModel is a short lived object constructed from OfflineItem, which simply provides all information for UI to display. BUG=881499 Change-Id: I18cf8585ba679b0314c0662ef40d33cdbe669156 Reviewed-on: https://chromium-review.googlesource.com/1222163Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#591177}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/29e180342e18..a2fc263db880 git log 29e180342e18..a2fc263db880 --date=short --no-merges --format='%ad %ae %s' 2018-09-13 tsepez@chromium.org Reland "Make things more const-y" Created with: gclient setdep -r src/third_party/pdfium@a2fc263db880 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:881678 TBR=dsinclair@chromium.org Change-Id: Idc45cbb4f07100eb520120a5043c73ea2291172e Reviewed-on: https://chromium-review.googlesource.com/1225316Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591176}
-
Manu Cornet authored
This makes sure that in the new UI, the spacing between panels, between panels and the tray, and between the tray and the screen edge, are all the same. See before/after screenshots at: https://bugs.chromium.org/p/chromium/issues/detail?id=880589#c8 Bug: 880589,880601 Change-Id: I7d63238d2d2511bd28d93b50cb01bc82d9f0158d Reviewed-on: https://chromium-review.googlesource.com/1224691 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#591175}
-
Xiaohan Wang authored
Bug: 759710 Test: Simplify tests. No functionality change. Change-Id: Ic419f2e87841bc93679497449bcf5bb79d6011c7 Reviewed-on: https://chromium-review.googlesource.com/1225833Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#591174}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dfce68bcddba..77ed83d5a5e4 git log dfce68bcddba..77ed83d5a5e4 --date=short --no-merges --format='%ad %ae %s' 2018-09-13 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-09-13 skobes@chromium.org Increase gerrit_util retry count and delay. Created with: gclient setdep -r src/third_party/depot_tools@77ed83d5a5e4 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:881860 TBR=agable@chromium.org Change-Id: Id177c38d74b6b83794f4a20a527f5d7ab8a40586 Reviewed-on: https://chromium-review.googlesource.com/1225301Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591173}
-
Jeremy Klein authored
This change adds a new flag which, if true, points Android Messages ChromeOS integration to the prod Messages for Web endpoint rather than the sandbox URL which is being used for staging. This flag is off by default to continue to allow dogfood until all our web experiments have rolled out to production. Bug: 881664 Change-Id: I4e84a19d2a9fb84972889e42644f6fe8d4464389 Reviewed-on: https://chromium-review.googlesource.com/1222880 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#591172}
-
Xiaohui Chen authored
Bug: 878996 Test: locally compile Change-Id: I5c8a35244777d14d3e1dbe36a9925f4d1424f696 Reviewed-on: https://chromium-review.googlesource.com/1220170 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#591171}
-
Xida Chen authored
When running SitePerProcessBrowserTouchActionTest, I found that when the effective touch action is Pan, the white listed touch action is Auto. This is clearly wrong because the white listed touch action is set from the effective touch action. This CL fixes the problem by propagating the effective touch action to document's layout view in style adjuster. It also changes the test to get the whitelisted touch action. In PS#2, we comment out the fix in style_adjuster.cc, and we can see that these 3 browser tests failed. The tests pass in PS#3 when putting the fix back. Bug: 881392 Change-Id: I86589baec9d0fc222e43268166b808971f03798b Reviewed-on: https://chromium-review.googlesource.com/1210963 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#591170}
-
Ken Rockot authored
Adds a missing synchronization step to the end of some multiprocess tests to ensure that client process termination does not race with IPC events. Bug: 883624 Change-Id: I91f4dd0d8b28469ff8da60714367d423e1e308fb Reviewed-on: https://chromium-review.googlesource.com/1225604Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#591169}
-
Sarah Hu authored
Bug: 881430 Change-Id: Ib8488e23e388d15c006b66d38e9084cfc93c6c70 Reviewed-on: https://chromium-review.googlesource.com/1222198Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#591168}
-