- 11 May, 2018 40 commits
-
-
Gauthier Ambard authored
Followup for the image of the activity service. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I71a5c8679d2734fbc0ca942105d7478eef1dbc8d Reviewed-on: https://chromium-review.googlesource.com/1055492Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#557863}
-
Ryan Hamilton authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I50de51120163cf0244b22c6e7cfca45327618cb3 Reviewed-on: https://chromium-review.googlesource.com/1045614 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#557862}
-
Marc Treib authored
Before this CL, TryStart and TryStartImmediately returned a bool. However, nobody actually consumed it, and IMO its meaning was unclear and more confusing than helpful. This CL removes the return values. Bug: none Change-Id: Ib9ff4786bd888d0fbefad7d89fc26be1e681238f Reviewed-on: https://chromium-review.googlesource.com/1054876Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#557861}
-
Eric Seckler authored
thread_time was previously overriding the wall time, but should actually be reported in a separate UKM field. Bug: 842112 Change-Id: If772b5276c0629a4184006bb5382939d9281d3d7 Reviewed-on: https://chromium-review.googlesource.com/1054011Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#557860}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/98ce1809..e5661887 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I41375018f5acb805ae540ffed10ad1dc44e94c6d Reviewed-on: https://chromium-review.googlesource.com/1054512Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#557859}
-
vitaliii authored
1) Exclude deprecated model types (e.g. DEPRECATED_SUPERVISED_USERS and DEPRECATED_SUPERVISED_USER_SHARED_SETTINGS) from kModelTypeInfoMap presubmit check. 2) Improve a couple of comments in model_type.cc. Change-Id: I68fd166396804c69ca567686b671ee9d19c624ac Reviewed-on: https://chromium-review.googlesource.com/1054875Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557858}
-
Leonard Grey authored
This reverts commit e3d54350. Reason for revert: Broke detached bookmark bar Original change's description: > Implement |GetChildrenInZOrder| in browser and top container views > > Currently, we ensure that the bookmark bar view is always the first > child view of its parent to ensure that toolbar inkdrops are drawn on > top of it. Unfortunately, this breaks keyboard traversal order. > > This change implements |GetChildrenInZOrder| on the two views that > host the bookmark bar: browser view and top container view. This > ensures that the bookmark bar is painted first, removing the need > to manipulate child view order. > > Bug: 712347 > Change-Id: If8f2aabe816a86b7ec29ff41779783c0f05a6393 > Reviewed-on: https://chromium-review.googlesource.com/1052854 > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557537} TBR=ellyjones@chromium.org,lgrey@chromium.org Change-Id: I43286f3f1a771a8835f72d28c2333f67c9ef6b7b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 712347 Reviewed-on: https://chromium-review.googlesource.com/1054594Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#557857}
-
https://webrtc.googlesource.com/src.git/+log/73b36b582fcf..e72ea24d884b $ git log 73b36b582..e72ea24d8 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8aa19aef3d7aede779021c77968de738a57ee254 Reviewed-on: https://chromium-review.googlesource.com/1055467Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557856}
-
Charlie Harrison authored
This allows telemetry to have access to an indexed ruleset, without having to specify one in the source tree (which would need to be updated every time the format version changes). Follow-ups will copy this into telemetry's user-data-dir. Bug: 823982 Change-Id: Iba551b1cd6137d73bed8dfbb0bc69d00f32be7ab Reviewed-on: https://chromium-review.googlesource.com/1052860Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#557855}
-
Gauthier Ambard authored
This CL changes the style of the PopupMenu associated with the tab grid button. If the action is destructive (closing the/all tabs), the action is tinted in red. Also it adds the same icon for closing all incognito tabs as the one for opening a new incognito tab. Bug: 831152 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I84617985d0811d431e38ee58391dd22df1cfb8f0 Reviewed-on: https://chromium-review.googlesource.com/1051709Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#557854}
-
Yuki Shiino authored
|optional| in Web IDL must only accept |undefined| in ECMAScript, and must not accept |null| unless the argument type is nullable. void foo(optional CallbackType foo_arg); void bar(optional CallbackType? bar_arg); In this case, |null| should cause a TypeError for |foo_arg|. (|bar_arg| is okay with |null| because the type is nullable.) Blink supports this rule for non-callback argument types, but not for callback function and callback interface. This patch applies this strict rule to callback function/interface, too. Since historically Blink implementation has accepted |null| for callback types, this patch also changes all existing argument types to nullable types in order to keep the backward compatibility. Change-Id: I3212ddb1388f8a4facb6b846de1347263556632e Reviewed-on: https://chromium-review.googlesource.com/1018320 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#557853}
-
Ned Nguyen authored
NOTRY=true # Test covered by PRESUBMIT TBR=eyaich@chromium.org Bug: 841492 Change-Id: Id93784c4f9e91e665c8f251349cacd846560ef75 Reviewed-on: https://chromium-review.googlesource.com/1055469Reviewed-by:
-
Noel Gordon authored
Bare NONE is not great: scope resolve it SharedOption::NONE to make it somewhat more obvious. Tbr: fukino Bug: 836254 Change-Id: If7b2ed65129ab8c6d0ce729037fac90fee3a3999 Reviewed-on: https://chromium-review.googlesource.com/1055352 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#557851}
-
gogerald authored
1, Added a progress bar to indicate page loading progress. The progress bar is hidden when progress is 1.0. 2, Moved payment handler icon from left to right. 3, Replaced the info icon with the gear icon. Bug: 840803 Change-Id: I0386d268b54585c54836229ca7fece76fea5a4fd Reviewed-on: https://chromium-review.googlesource.com/1053791Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#557850}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0cc01b753ac6..244f754cdd6b $ git log 0cc01b753..244f754cd --date=short --no-merges --format='%ad %ae %s' 2018-05-11 angle-skia-autoroll Roll third_party/externals/angle2/ 2fc0806f5..8073a9511 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: Idd3964c1b57aa90fc664ceaa170dae5bdfba90f0 Reviewed-on: https://chromium-review.googlesource.com/1055206 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557849}
-
Gauthier Ambard authored
This CL re-enable the EG tests for the promo when UI Refresh flag is enabled. Bug: 832661 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4102d6c61cd774387817d5dc30d4794d02f42ac2 Reviewed-on: https://chromium-review.googlesource.com/1052112 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#557848}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 98d8ce92. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17287 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes meade@chromium.org: external/wpt/web-animations TBR=markdittmer No-Export: true Change-Id: Iac177b40f401cbc07dbd34989d2d3b1ed23d17b1 Reviewed-on: https://chromium-review.googlesource.com/1054510 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557847}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=sammiequon@google.com Change-Id: I6c42039958ab12ff7a2c3633bfdbf6fc0053bfe2 Reviewed-on: https://chromium-review.googlesource.com/1054513Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#557846}
-
Gauthier Ambard authored
This CL disables the QR code tests that are failing consistently. Bug: 842072 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I29acaf666d0f21a6dcbea1780fe56eb0f3ac4d5e Reviewed-on: https://chromium-review.googlesource.com/1054231Reviewed-by:
-
Marc Treib authored
This isn't C++98 :) Bug: none Change-Id: I71a616498a7233ad932fa3f273ab87677eb346e8 Reviewed-on: https://chromium-review.googlesource.com/1052467 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#557844}
-
Takashi SAKAMOTO authored
This is [1/2] of the patch: https://chromium-review.googlesource.com/c/chromium/src/+/925987 to add Memory_Experimental UKM 1, 5, 10 and 15 minutes after page loaded. ProcessMemoryMetricsEmitter is used to record Memory_Experimental UKM and emits the all processes' memory metrics. Since we would like to use the same code to record the UKM, we modify ProcessMemoryMetricsEmitter to record the specified page's Memory_Experimental UKM, i.e. the specified renderer's Memory_Experimental UKM. Change-Id: I99242123529a53c97e91153545a40e0f7aa21f26 Bug: 837498 Change-Id: I99242123529a53c97e91153545a40e0f7aa21f26 Reviewed-on: https://chromium-review.googlesource.com/1032150 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Noel Gordon authored
Add a note about the need to reply to a chrome.test.sendMessage: it is imprecise to say that we "just ignore it", we must reply. And an empty std::string() is a sufficient reply. Tbr: fukino Bug: 836254 Change-Id: I969cf4659e415fcd004f0619d9de04a2b2f10c7e Reviewed-on: https://chromium-review.googlesource.com/1055034 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a8050d3d8618..ec4bbb378159 $ git log a8050d3d8..ec4bbb378 --date=short --no-merges --format='%ad %ae %s' 2018-05-09 yunlian binhost: stop filter CFLAGS -clang-syntax Created with: roll-dep src/third_party/chromite BUG=chromium:None The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I579ebca1089747a89e45fc6d9a5705a4ab44b542 Reviewed-on: https://chromium-review.googlesource.com/1055205 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557841}
-
Koji Ishii authored
This patch tests re-using NGInlineItems for all tests in NGInlineItemsBuilderTest that use |TestAppend| function. Also converts two tests to use |TestAppend| to increase the coverage. TBR=eae@chromium.org Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iab588f9aa5a2c6137c50f3444e2372b182f74b3c Reviewed-on: https://chromium-review.googlesource.com/1055033Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557840}
-
Noel Gordon authored
Tbr: slangley Bug: 841659 Change-Id: Ie9c79c80a3105ced7d97636ad8cb519e66d99244 Reviewed-on: https://chromium-review.googlesource.com/1055409Reviewed-by:
-
Findit authored
This reverts commit 539d243b. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 557832 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNTM5ZDI0M2IwODdlNmUzMTI4MWMzMjI5OTI5ZjVhMWZjOTdjZDgyZgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Linux/None Sample Failed Step: content_unittests Sample Failed test: RenderFrameAudioInputStreamFactoryTest.CreateOpenedStream_ForwardsCall Original change's description: > Add a new RenderFrameAudioInputStreamFactory > > It checks that the stream is allowed and forwards the request to the > relevant ForwardingAudioStreamFactory if so. This will cause > the stream to be served by the audio service. > The old RenderFrameAudioInputStreamFactory which creates streams > living in content/ is renamed to > OldRenderFrameAudioInputStreamFactory. Since the class was renamed, > the files were moved (by adding "old_" to the beginning). No need to > review those files. Also note that replacement is diffed against > the previous implementation. It's probably best to just ignore the diff > and review render_frame_audio_input_stream_factory{.cc,.h,_unittest.cc} > as new files. > > The same flag as for output is used to switch between the old factory > and the new one. > > Approximate diagram of stuff: > https://docs.google.com/drawings/d/1_ZIKj6lihGKRjq4Mflduitmkn_REqpHFeqVNelBGHHk/edit > > Bug: 830493, 836226 > Change-Id: Ib0f58a52d849a48ba79405f0d499444c66029b58 > Reviewed-on: https://chromium-review.googlesource.com/1050245 > Commit-Queue: Max Morin <maxmorin@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557832} No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 830493, 836226, 842115 Flaky step name: content_unittests Flaky test name: RenderFrameAudioInputStreamFactoryTest.CreateOpenedStream_ForwardsCall Change-Id: If1683461af7fcbe0a9be633db62087dafe66235b Reviewed-on: https://chromium-review.googlesource.com/1054162 Cr-Commit-Position: refs/heads/master@{#557838}
-
Max Morin authored
It's flaky on all platforms. Tbr: smcgruer@chromium.org No-Try: true Bug: 829740 Change-Id: Ibcbf34bf2a999c0814cf2d5546109561093030be Reviewed-on: https://chromium-review.googlesource.com/1054012 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557837}
-
Bernhard Bauer authored
This follows the best practice outlined in the whitepaper at https://youtu.be/lrHJhKEtQEI. Bug: 839648 Change-Id: Ic578859515ae2e1fdd13bf7966c544fe2490ffcf Reviewed-on: https://chromium-review.googlesource.com/1051244 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#557836}
-
Roman Sorokin authored
Now it loads owner key to identify the owner. This does not work for Active Directory devices which does not contain the key. BUG=chromium:709416 TEST=manual Change-Id: I44469a2f0b68910490ffa45cef14be6e53ff1cae Reviewed-on: https://chromium-review.googlesource.com/1046602Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557835}
-
Max Morin authored
This reverts commit 05267e5e. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "Cancel parallel download request if server doesn't send partial response" > > This reverts commit 13077433. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Revert "Cancel parallel download request if server doesn't send partial response" > > > > This reverts commit 189d1033. > > > > Reason for revert: "ParallelDownloadTest.NoPartialResponse" is flaky. See https://crbug.com/841666. > > > > Original change's description: > > > Cancel parallel download request if server doesn't send partial response > > > > > > If the server doesn't support partial responses, Chrome should cancel > > > parallel download requests. > > > These requests result in the wrong write offset and makes the file larger > > > than the original > > > > > > BUG=838627 > > > > > > Change-Id: I1fa878854579a1572e6e2f90f3bb932b59b333ba > > > Reviewed-on: https://chromium-review.googlesource.com/1048130 > > > Commit-Queue: Min Qin <qinmin@chromium.org> > > > Reviewed-by: Xing Liu <xingliu@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#557252} > > > > TBR=qinmin@chromium.org,xingliu@chromium.org > > > > Change-Id: I995c3c48fe39c535275a353130b10204009c5e30 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 838627, 841666 > > Reviewed-on: https://chromium-review.googlesource.com/1053470 > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#557489} > > TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org > > Change-Id: I47a2d4131efa8b863d9868eeca74e99d7beeaa8e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 838627, 841666 > Reviewed-on: https://chromium-review.googlesource.com/1054887 > Reviewed-by: Min Qin <qinmin@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557734} TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org Change-Id: I7a618b9533229ea1bb97ff65470e9c60fe580a49 No-Try: true Bug: 838627, 841666 Reviewed-on: https://chromium-review.googlesource.com/1053729Reviewed-by:
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/394f1c63d58a..a8050d3d8618 $ git log 394f1c63d..a8050d3d8 --date=short --no-merges --format='%ad %ae %s' 2018-05-08 bpastene cros_run_vm_test: Pass board and cache dir args down to deploy_chrome. Created with: roll-dep src/third_party/chromite BUG=chromium:823996 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I1fb09689cbf824cf46c5332a473261f6c6ca55b8 Reviewed-on: https://chromium-review.googlesource.com/1055193Reviewed-by:
-
Max Morin authored
It checks that the stream is allowed and forwards the request to the relevant ForwardingAudioStreamFactory if so. This will cause the stream to be served by the audio service. The old RenderFrameAudioInputStreamFactory which creates streams living in content/ is renamed to OldRenderFrameAudioInputStreamFactory. Since the class was renamed, the files were moved (by adding "old_" to the beginning). No need to review those files. Also note that replacement is diffed against the previous implementation. It's probably best to just ignore the diff and review render_frame_audio_input_stream_factory{.cc,.h,_unittest.cc} as new files. The same flag as for output is used to switch between the old factory and the new one. Approximate diagram of stuff: https://docs.google.com/drawings/d/1_ZIKj6lihGKRjq4Mflduitmkn_REqpHFeqVNelBGHHk/edit Bug: 830493, 836226 Change-Id: Ib0f58a52d849a48ba79405f0d499444c66029b58 Reviewed-on: https://chromium-review.googlesource.com/1050245 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:Nasko Oskov <nasko@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#557832}
-
Noel Gordon authored
These extensions are not used by the Files.app browser tests and cause ASAN flakes due to an unrelated NaCl bug 788671. Skirt around that bug here by not loading these NaCl-using extensions. Side-effect: these browser tests hopefully run a little faster. Bug: 788671,836254 Change-Id: Ie528cad328d76f2ff0ee97c994f2bc539de86a98 Reviewed-on: https://chromium-review.googlesource.com/1055351 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#557831}
-
vitaliii authored
Add a static_assert, which fails wen a new protocol type is added, to EntitySpecifics visitor, so that people don't forget to update this visitor. That's precisely what I did when I was adding a new type and it took me couple of hours of debugging to understood what was wrong. Change-Id: Idd35e143b1fcbda089de3552ac07b9754e344235 Reviewed-on: https://chromium-review.googlesource.com/1054010 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
In UnifiedSystemTray, information that was shown in TraySupervisedUser default view will be shown at the right bottom of the system tray. The style is same as one for enterprise managed devices. TEST=UnifiedSystemInfoViewNoSessionTest BUG=none Change-Id: I7cb1512a41894a2005a4d4a76a2a667c231ea0ad Reviewed-on: https://chromium-review.googlesource.com/1051927 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#557829}
-
Max Morin authored
Tbr: cbiesinger No-Try: true Bug: 833215 Change-Id: I3807d48df11e6b4416357896b7af4564b0ef7c6e Reviewed-on: https://chromium-review.googlesource.com/1055448Reviewed-by:
-
Donna Wu authored
Implementation of MTPManagerClientChromeOS is mostly copied from media_transfer_protocol_device_observer_chromeos.h/cc files which will be replaced in subsequent CLs. This is a preparation CL for the conversion of MTP mojo interfaces' usage in the client side without any functional changes for the notifications to upper level clients have been blocked. BUG=769630 Change-Id: I28076cc4a4e30783426c6ccb5af1805ef913d7ae Reviewed-on: https://chromium-review.googlesource.com/1046376 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#557827}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a75468d15a3e..6ccd021839d2 $ git log a75468d15..6ccd02183 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 perezju [soundwave] Create timeseries table if needed Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I48240234d07696b2b0a5459ce91b1a0ff080fd29 Reviewed-on: https://chromium-review.googlesource.com/1055199Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557826}
-
Manuel Rego Casasnovas authored
Change-Id: I3c085d43bc1fa2b3ebe3d90c50b3d1e269de58a0 Reviewed-on: https://chromium-review.googlesource.com/1054289Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#557825}
-
Patrik Höglund authored
This reverts commit ee35ff8f. Reason for revert: New USB card in place, let's see if still flaky Original change's description: > Reland "Disable flaky capture unittests on Linux." > > This reverts commit a99efe4b. > > Reason for revert: Still flaky. > > Original change's description: > > Revert "Disable flaky capture unittests on Linux." > > > > This reverts commit 46bf6346. > > > > Reason for revert: New webcam plugged in; let's see if they're still flaky. > > > > Original change's description: > > > Disable flaky capture unittests on Linux. > > > > > > The tests went flaky when we replaced the bot and get VIDIOC_STREAMON > > > errors about 25% of the builds. I have no idea to fix that; we tried > > > replacing the webcam and moving it around in the USB ports and that > > > didn't help. See http://crbug.com/828568 for discussion. > > > > > > Bug: chromium:831514 > > > Change-Id: Ic55c09a16a22dd0402c3360b710e310c733ec5f9 > > > Reviewed-on: https://chromium-review.googlesource.com/1016301 > > > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > > > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#552165} > > > > TBR=phoglund@chromium.org,chfremer@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: chromium:831514, chromium:828568 > > Change-Id: I01b21c5073e79e004c74430cc6eeb3422b602745 > > Reviewed-on: https://chromium-review.googlesource.com/1039425 > > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#555342} > > TBR=phoglund@chromium.org,chfremer@chromium.org > > Change-Id: I9c976f8bb2e0812029d13ae020896bebadf4ef1c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:831514, chromium:828568 > Reviewed-on: https://chromium-review.googlesource.com/1041945 > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555996} TBR=phoglund@chromium.org,chfremer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:831514, chromium:828568 Change-Id: I253b9c60032543f55533b8f53442dcabbebffbf6 Reviewed-on: https://chromium-review.googlesource.com/1054669Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#557824}
-
