GitLab

This CL adds code to collect contents layers as foreign layers for
BlinkGenPropertyTrees mode. Most layout tests involving canvas /
composited images / video / plugins should now pass. Composited
scrollbars should also draw, though the thumb position may not be
synchronized.

BUG=840037

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I905b4b30136fcbc30133fc50f0133a46d3f922ee
Reviewed-on: https://chromium-review.googlesource.com/1048841
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557053}

This CL adds UMA to mute button on the left side of volume slider in
SystemTray. It applies to both old SystemTray and UnifiedSystemTray.

This CL also fixes volume slider UMA in UnifiedSystemTray.

TEST=manual(chrome://user-actions)
BUG=b/79256317

Change-Id: Ic0da732c360e72578d099a82db5ae9fbde05013a
Reviewed-on: https://chromium-review.googlesource.com/1049408Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557052}

changes:
In the past, ash::HighlightController calls
mojom::HighlightControllerClient with events like enable state,
selection rect.
For native assistant, introduce HighlighterController::Observer to let
AshAssistantController to observe Highlighter status.

This CL makes highlighter enabled state control interaction state and
its input modality.

This cl also:
- Some changes in ash::AssistantBubble, don't need to close bubble
  widget and recreate every time, we just need to hide it.
- In ash::AssistantBubble, remove widget observer just needs to happen
  in either OnWidgetClosing or OnWidgetDestroying.
- Add AshAssistantControllerTest class and add this CL's tests.

      unittest: AshAssistantControllerTest.HighlighterEnabledStatus

Bug: b/78193960
Test: enable assistant fully and then manual test.
Change-Id: If8847b2258103f581653cfec83493324217ee3bd
Reviewed-on: https://chromium-review.googlesource.com/1048866Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#557051}

This reverts commit fd312950.

Reason for revert: tools/metrics/actions/actions.xml presubmit check fails on another CL.
Please run tools/metrics/actions/extract_actions.py and add the description. Sorry for inconvenience.


Original change's description:
> Add UMA event for entering Android tab switcher by toolbar swipe
> 
> We currently don't have any UMA events for entering the Android tab switcher by
> swiping down on the toolbar. In
> https://chromium-review.googlesource.com/c/chromium/src/+/1048042, I am updating
> the MobileToolbarShowStackView logging to include this case. In this CL, I am
> adding a new MobileToolbarSwipeOpenStackView event specifically for this case so
> we can measure how many people are entering the tab switcher by swiping on the
> toolbar.
> 
> Bug: 828224
> Change-Id: I2b2f7e4dafd08192355618273d7069a03b4d9e4e
> Reviewed-on: https://chromium-review.googlesource.com/1048308
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Commit-Queue: Ryan Landay <rlanday@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556954}

TBR=dtrainor@chromium.org,rlanday@chromium.org

Change-Id: I1f26c5b544e759b76b68db6478ae147b5475c40a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 828224
Reviewed-on: https://chromium-review.googlesource.com/1051065Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557050}

This removes some features from UI.Fragment:
    x-shadow
    states
    inline styles

It adds a simple helper method, UI.html which returns an element.

As a driveby, also fixes the jsdoc validator to parse spread operators.

Change-Id: I569f697bbe29530b7a494c75727dcf37769f8f05
Reviewed-on: https://chromium-review.googlesource.com/1050617Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557049}

This reverts commit dc92f9db.

Reason for revert: Tests consistently fail on 
https://ci.chromium.org/buildbot/chromium.android/Marshmallow%20Tablet%20Tester/12646

Original change's description:
> Reactivate deflaked keyboard accessory tests
> 
> After having landed https://crrev.com/c/1028230, the problems of the
> linked bug seem to have gone (as assumed).
> 
> I removed the Disabling and RetryOnFailure annotations to test on 3
> devices (one physical, two emulator with different screen sizes and OS)
> and couldn't find a single broken test.
> Edit: I changed the font size recently (not finally) which seems to
> bother some bots - unrelated from the filed bug. Changed that back.
> 
> This CL now reenables all the tests but keeps the RetryOnFailure
> annotation. That way, I can test whether the tests start failing on
> some bots again without making the sheriffs life harder.
> If the bots don't notice any flakiness, I will remove the
> RetryOnFailure annotation as well and mark the linked bug fixed.
> 
> Bug: 838922
> Change-Id: I9781e6d820ac39e43435ad1529da817601967ed4
> Reviewed-on: https://chromium-review.googlesource.com/1044371
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556798}

TBR=bauerb@chromium.org,fhorschig@chromium.org

Change-Id: I60198d2fbcd36c4687b379d07995e1b873112d51
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 838922
Reviewed-on: https://chromium-review.googlesource.com/1051026Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557048}

It replaces prettifier written in Ruby.

This CL moves the remaining content of prettypatch.py to tools/
commands/pretty_diff.py because it's very small and there are
no other callsites.

Bug: 672651
Change-Id: I91e94356a5cfd73cf714b09f3b47bb4cab738454
Reviewed-on: https://chromium-review.googlesource.com/1039121
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557047}

Adds skeleton implementation of a mediator and consumer interface for
the BookmarksHomeViewController. Business logic will be added in a
future CL.

The ChromeTableViewConsumer protocol is added to serve as a base
protocol for all tableview-based mediators. Individual subclasses can
extend this protocol and add feature-specific methods.

BUG=840381

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I42ff91edfaa6c85a3e534ce515bb9fc82ae1e1fc
Reviewed-on: https://chromium-review.googlesource.com/1050196Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557046}

BUG=827639
R=chrishtr@chromium.org

Change-Id: I21f63aed1e3bac1cae3e5ec0f9253371508579f4
Reviewed-on: https://chromium-review.googlesource.com/1050695
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557045}

Make the map that contains collected metrics data leaky. This
fixes the issue when the static objects are deallocated by
the main thread while the network thread is still active.
This can happen when the app that uses Cronet is terminated.

BUG=840488

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5d8a3f06ead10071d5598fee0ae0203490a0a412
Reviewed-on: https://chromium-review.googlesource.com/1050766
Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557044}

RenderedPosition is no longer a general purpose class, and is being
deprecated.

This patch removes unused member functions and cleans up comments for it.

Bug: 811502
Change-Id: Ifc49e2c1dd554b0fc51126a692c7873591f61dca
Reviewed-on: https://chromium-review.googlesource.com/1050928Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557043}

When clicking on a tab in the VR tabs overview (tabs switcher) select that tab
and go to the main browser environment after the tab has been selected.

Bug: 840511
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: If373166215b2a1dae10bd714dec084fc90087e9d
Reviewed-on: https://chromium-review.googlesource.com/1048269Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557042}

The Text element is now the only handler of text in the VR UI.

BUG=

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I16501feb6274aebad33426c53798eec21bb6d832
Reviewed-on: https://chromium-review.googlesource.com/1048400
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557041}

This reverts commit c8d6aa16.

Reason for revert: crbug.com/841085 (this is blocking CQ)

Bug: 841085

Original change's description:
> [autofill] Suppress the use of invalid profile data.
> 
> This CL adds feature flags that causes Chrome to suppress suggestions,
> votes and quality metrics based on profile data which has been flagged
> as likely invalid.
> 
> This will allow Chrome Team to evaluate the utility of attempting to
> filter out this data.
> 
> Bug: 835984
> Change-Id: I63f51ac893d2bf657af9eb136d920cb0b7f2bddd
> Reviewed-on: https://chromium-review.googlesource.com/998132
> Commit-Queue: Roger McFarlane <rogerm@chromium.org>
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556900}

TBR=rogerm@chromium.org,jwd@chromium.org,sebsg@chromium.org

Change-Id: I549b1fa0af8f367a62e8afa57fcda43ee592fa12
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 835984
Reviewed-on: https://chromium-review.googlesource.com/1051025Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557040}

Bug: 825740
Change-Id: I669a1cfaaf6600d6eaf4d6f5fbcb06a6f1f1ef50
Reviewed-on: https://chromium-review.googlesource.com/1009348Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557039}

This change implements SetupKerberos on SmbProviderClient. This
allows SmbService to call SetupKerberos over D-Bus.

BUG: chromium:757625
TEST: compiles
Change-Id: I538d503ac8462ff145d956553890b9e1f06a74e8
Reviewed-on: https://chromium-review.googlesource.com/1045129
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557038}

The code that depended on this was removed in
https://codereview.chromium.org/1989163002/.

Change-Id: Ia4d72409159d42b65cea15c24c2f6002baabfffd
Reviewed-on: https://chromium-review.googlesource.com/1049725Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557037}

https://pdfium.googlesource.com/pdfium.git/+log/b7c41498ac1f..df1298a228ab

$ git log b7c41498a..df1298a22 --date=short --no-merges --format='%ad %ae %s'
2018-05-08 npm Add several FPDFPageObj_* APIs
2018-05-08 hnakashima Revert "Ensure that XFA Pages always have a corresponding PDF page"
2018-05-08 thestig Mark CPDF_Object pointers as const in CPDF_ViewerPreferences.
2018-05-08 thestig Add APIs to work with a FPDF_PAGERANGE.
2018-05-08 npm Remove almost all usages of CFX_FixedBufGrow with std::vector
2018-05-08 thestig Remove PDFTRANS_KNOCKOUT.
2018-05-08 thestig Add constants for PDF 1.7 spec, table 7.2 and 7.3.

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:840922


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I0d8227d226a1a75bcba66dcfa03f908112897016
Reviewed-on: https://chromium-review.googlesource.com/1050626Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557036}

An application id of notification surfaces is needed to
distinguish notification surfaces from ARC++ apps from surfaces from
other exo clients.
IsArcNotificationWindow() in arc_ime_service.cc will be updated after
client side code is updated.

Bug: 829383, 834027
Test: Build pass & Inline reply on ARC++ notifications works corretly.
Change-Id: I471d8f6be2fdd40e02178cdeb1a27b4e71b03842
Reviewed-on: https://chromium-review.googlesource.com/1039505
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557035}

- originally landed as 5d480c70
- reverted as e14e1aed
- test failures fixed as 22800d9f

Original change description:
1. Move BrowserFrameHeaderAsh to //ash/frame and rename to
   CustomFrameHeader.
2. Use CustomFrameHeader for browser windows (in HeaderView).
   Continue to use DefaultFrameHeader for other windows.
   Possible TODO: share more code between the two FrameHeader classes.
3. Transport frame images over mojo so Mash can apply them
   via CustomFrameHeader.

For now, only the active frame image is propagated (as a POC).
The inactive image, overlay images, and frame colors are TODO.
Ideally, there should be no behavioral changes in classic Ash.

BUG=704942,836992
TBR=sky@chromium.org

Change-Id: Ic0763d3cebfe2a6f354d1345ed84ed02631e8210
Reviewed-on: https://chromium-review.googlesource.com/1050799
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557034}

This change restores the new prompt background to be inert, and adds a
test to ensure this.

It also extends the test framework to more reliably similate element
clicks.  We now can use a controller position and click to fire at the
element, rather than poking directly at an element's click handlers.
This overcomes the problem of invoking a handler that otherwise would
not be triggered by the input manager, if the element is non-hittable
or obstructed by other elements.

BUG=
R=vollick

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: Ia4b8a80ff7908dc3dbfbde878b0d32c815b1b513
Reviewed-on: https://chromium-review.googlesource.com/1050410
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557033}

Adds some Log statements to try to help isolate a crash on older
versions of android that happen when we use a text view with
ellipsis=start.

BUG=834959

Change-Id: I66656eea53cc9f36a09bed26705c010e02be0112
Reviewed-on: https://chromium-review.googlesource.com/1044540
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557032}

This CL replaces a bunch of CHECKs with error handling that propagates
errors up the stack. Also adds DCHECKs where error handling is missing,
but the calls aren't expected to fail.

R=zmo
BUG=837378

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I1c52ea5fd1355b2ce3bb8e9a18bba232ec37f397
Reviewed-on: https://chromium-review.googlesource.com/1031203
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557031}

https://i.imgur.com/Y3OlPM2.png

Change-Id: Ic1d9ef1d47ff93ce77bfc3ae7173689bccf0cb2c
Reviewed-on: https://chromium-review.googlesource.com/1031096Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557030}

Change-Id: Ic9b10334114f075a5222248b2a00a2b6d2ce0f98
Reviewed-on: https://chromium-review.googlesource.com/1036604
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557029}

This CL adds fast_out_slow_in_interpolator.xml and specifies it as
interpolator for objectAnimators in signin_header_animation.xml.
fast_out_slow_in interpolator from Android resources can't be used here
as it was added in API level 21.

Bug: 814728
Change-Id: If3a7fc8835628f2c0d373b0e0765531dafa8a993
Reviewed-on: https://chromium-review.googlesource.com/1047670Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557028}

Starting in Windows 10 RS4 (Spring Update), the key combination
Win+'.' brings up the emoji panel. This adds a context menu item
for convenience.

Brings the code to the cross-platform context menu by creating a
helper file in ui/base/emoji

Bug: 827404

Change-Id: I941b2e7035d80bc751db0fd9f943928afeb51bb6
Reviewed-on: https://chromium-review.googlesource.com/1045990Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557027}

Bug: 828811
Change-Id: I575834b95ff2c5587933601e1f46f53221f65fe0
Reviewed-on: https://chromium-review.googlesource.com/1047956Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557026}

Bug: 731986,790619
Change-Id: Iedc8e26b6d5c5be947c36bd66e9bc9d60df607b5
Reviewed-on: https://chromium-review.googlesource.com/1045890Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557025}

Move the ExtensionBrowserTest class into the extensions namespace, and
updated affected sites.

This CL should have no functional change.

Bug: 117261
TBR: sky@chromium.org (c/b/ui, c/b/autocomplete, c/b/global_keyboard_shortcuts_mac_browsertest.mm, c/b/renderer_host)
TBR: alexmos@chromium.org (chrome_security_exploit_browsertest.cc)
TBR: stevenjb@chromium.org (c/b/chromeos)
TBR: gayane@chromium.org (c/b/metrics)
TBR: pastarmovj@chromium.org (c/b/policy)
TBR: battre@chromium.org (c/b/prefs)
TBR: thestig@chromium.org (c/b/printing)
TBR: jialiul@chromium.org (c/b/safe_browsing)
TBR: creis@chromium.org (c/b/site_details_browsertest.cc)
TBR: afakhry@chromium.org (c/b/task_manager)
TBR: pkotwicz@chromium.org (c/b/themes)
TBR: apacible@chromium.org (c/test/media_router)
TBR: raymes@chromium.org (c/test/ppapi)

Change-Id: I1fdbb6fc5bb94d87f40f1f02db5a91262c83c79a
Reviewed-on: https://chromium-review.googlesource.com/1050384Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557024}

Again, PulseAudio layer is unsupported in a target_os="chromeos" build
and VideoPlayerBrowserTest produce LOG errors about that. Again, use a
fake audio layer to eliminate it, cargo cult crrev.com/556704.

Good enough until a future CL provides a more general fix, but step #1
is to kick the VideoPlayerBrowserTest's tyres on the bots.

Bug: 835626,835742,835642
Change-Id: I58cc1c188e95d39f8e75230a761e7b69ff99cabb
Reviewed-on: https://chromium-review.googlesource.com/1049768Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557023}

Bug: 836892
Change-Id: Iad5856428bc60cbb410a8c97076078f8adbbea5d
Reviewed-on: https://chromium-review.googlesource.com/1048060Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557022}

Bug: 836887
Change-Id: Id13521c9f15f0f3a3e5c1fd4047b40b8883dcbcf
Reviewed-on: https://chromium-review.googlesource.com/1048045Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557021}

Change-Id: Icdbad110266ba00386486355ec996c45d8660869
Reviewed-on: https://chromium-review.googlesource.com/1050792Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557020}

Currently we use an extra menu with two items to show download location
settings and show/hide disk space info.

This CL removes the extra menu and uses a new menu item to only show
download location setting. The icon uses a setting icon, which will be
replaced later for correct color.

Bug: 838738,792775
Change-Id: Ic2f65df05ea9a46d8d49885b15d5fa6a9273ba07
Reviewed-on: https://chromium-review.googlesource.com/1043362
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557019}

Cross-Origin Read Blocking (CORB) tries to protect certain resource
types (e.g. text/html).  To be resilient against HTTP responses
mislabeled with an incorrect Content-Type, CORB sniffs the response body
to confirm if it truly is the protected type.

Before this CL the confirmation sniffing logic blocked resources that
are both a valid html and a valid javascript.  Blocking of such
resources is undesirable, because it is disruptive to existing websites
that use such polyglot responses in <script> tags.

After this CL, CORB sniffer takes into account the
https://www.ecma-international.org/ecma-262/8.0/index.html#prod-annexB-SingleLineHTMLCloseComment
rule which means that the sniffing doesn't resume immediately after
"-->" characters, but instead also consumes all the characters until the
first line terminator.

Bug: 839945
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I7c8221acc2013adffe8095d188ae22e1c6a2fdab
Reviewed-on: https://chromium-review.googlesource.com/1047851
Commit-Queue: Charlie Reis <creis@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557018}

Using wpt-import in Chromium 494ded10.
With Chromium commits locally applied on WPT:
9180e0b3 "Move AudioContext tests to WPT"
a1bc6550 "Fix resource-timing.https.html test"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17163

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
alexander.shalamov@intel.com, mikhail.pozdnyakov@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org:
  external/wpt/generic-sensor
jsbell@chromium.org:
  external/wpt/resources

TBR=danyao

No-Export: true
Change-Id: I6d529ae1d2dbd5bb3a62eaaad2105efbe610ff9b
Reviewed-on: https://chromium-review.googlesource.com/1050826
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557017}

After successfully creating a CastSession via the presentation service,
we do not switch to using the FlingingRenderer.

This CL adds the signals to switch to/from using the FlingingRenderer.
This is done by asking WMPI to pick a new media::Renderer, by going
through a suspend/resume cycle. The RendererFactorySelector should
automatically choose the FlingingRendererClientFactory, based on the
fact that the RemotePlaybackClientWrapper has a valid presentation ID.

Bug: 790766
Change-Id: Ibab887c8a1791620ad1dcd92406c7ee618eec36d
Reviewed-on: https://chromium-review.googlesource.com/1043279Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557016}

Variations' EntropyProvider requires a random but stable seed value.
WebView uses the metrics client ID for this. In the WebView-variations
prototype, variations read the client ID synchronously on the main
thread. This wasn't terrible, because the client ID file was very small.
But it's better to do it in the background.

Add AwMetricsServiceClient.preloadClientId to load the client ID in
Java, before native init. Call this in VariationsSeedLoader's background
task. Then use the preloaded value in native variations and metrics code.
If preloading fails (either because there was no client ID file, or
because the background task took too long), then variations will be
disabled, while metrics will load or create the client ID as normal.

The client ID file will never exist the first time an app uses WebView;
this implies variations will always be disabled on the first run. But
this was already the case, since no variations seed will be present on
first run either.

BUG=678288

Change-Id: Ied9b4a73fe4cface9911e825bc5a3f282a4d1eff
Reviewed-on: https://chromium-review.googlesource.com/1043063
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557015}

In guest session, we use two different profiles for "Suggested App" and
apps in Launcher. The later uses the profile of AppListSyncableService
which alwasy uses the original profile. However, the original profile is
not allowed in guest session.

This cl fixes this bug by returning guest profile in
AppListSyncableService in guest mode.

Bug: 840293
Test: manual.
Change-Id: I30d9464597eaacba9a08560ca03e0679a9e906bf
Reviewed-on: https://chromium-review.googlesource.com/1049005
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557014}