- 31 Oct, 2019 40 commits
-
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ied490c4b890ab553c91deaf28b9c952b22eb3d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892999Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711449}
-
Yue Zhang authored
Bug: 983170 Change-Id: Ie165a27c52a5524ce1c41f8ec4661be45b945674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891117 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#711448}
-
Robert Ogden authored
TBR=ryansturm@chromium.org Change-Id: Id22af52d89c0d880ce0df0c55fba0440193a3bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894186Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#711447}
-
Avery Musbach authored
Merge IndicatorState::kCannotSnap{Xxx} to IndicatorState::kDragArea{Xxx} as the distinction is whether the dragged window can be snapped in split view, which can be determined in SplitViewDragIndicatorsView now that the parent CL [1] has added dragged_window_ thereto. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1880201 Bug: None Change-Id: Ic3fc184e29b8ccf30647016f57dd89a1f055909e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881331 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#711446}
-
Henrik Boström authored
Intent to Implement and Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OqPfCpC5RYU For background, motivation, requirements and implementation notes, see https://docs.google.com/document/d/1XLwNN2kUIGGTwz9LQ0NwJNkcybi9oKnynUEZB1jGA14/edit?usp=sharing Parameterless setLocalDescription() implicitly creates an offer or answer as appropriate based on the current signaling state. This is already implemented in third_party/webrtc using an operations chain. This CL reuses existing plumbing (used by SLD/SRD already) to surface state changes when invoking the new SetLocalDescription variety. The PeerConnectionTracker is updated to track parameterless SLD so that it shows up in chrome://webrtc-internals/. The old SLD and SRD showed up as events as follow: - When SLD(sdp) is called, a "setLocalDescription" event shows up with the SDP as the event's value. - When SLD(sdp) resolves, a "setLocalDescriptionOnSuccess" event shows up without a value. The parameterless setLocalDescription() instead shows up in chrome://webrtc-internals/ as: - When SLD() is called, a "setLocalDescriptionImplicitCreateOfferOrAnswer" event shows up without a value. - When SLD() resolves, a "setLocalDescriptionImplicitCreateOfferOrAnswerOnComplete" event shows up with the resulting SDP as the event's value. As such, chrome://webrtc-internals/ remains useful for debugging even if parameterless SLD is used. Bug: chromium:980885 Change-Id: I469f63cdaab83991749d5a0d47fe751666304fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890420Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#711445}
-
Jasper Chapman-Black authored
Bug: 1011921 Change-Id: I50ddf9493080432a1797ee2deec7517f77b42d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893360Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Cr-Commit-Position: refs/heads/master@{#711444}
-
Min Qin authored
DownloadPathReseavationTracker::CheckDownloadPathForExistingDownload() is called on UI thread. However, the g_reservation_map should only be used DPRT's own task runner. As a result, there are race conditions that cause the method to hit a null pointer. This CL fixes the issue by posting a task on to DPRT's own task runner. And also remove the feature flag that is already enabled. BUG=1019627 Change-Id: Ibff4468f5a1fbaea4479481a115c835220089653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891734 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711443}
-
kylechar authored
Have SkiaOutputSurfaceImplOnGpu check that the SharedContextState isn't null before using it. It will return null if MakeCurrent fails. Bug: 1019690 Change-Id: I812f805413f57d0063a1c7c66dfdd556026db70e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893988Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#711442}
-
Eric Stevenson authored
The method references prevent the generated JNI wrapper classes from being fully inlined. Bug: 993421 Change-Id: Id4771b73cd28ba462d8cdf950573575ab215f1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893990Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#711441}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6524ae660745..0fa7fef72b53 git log 6524ae660745..0fa7fef72b53 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 tsepez@chromium.org Make CFDE_TextOut::CalcLogicSize() take a WideStringView 2019-10-31 thestig@chromium.org Make CPDFXFA_WidgetHandler::NewAnnotForXFA() return a std::unique_ptr. 2019-10-31 thestig@chromium.org Refactor some common code in CPDF_DIBBase. 2019-10-31 tsepez@chromium.org Avoid c_str() then strlen() in view constructor in CFWL_ComboList. Created with: gclient setdep -r src/third_party/pdfium@0fa7fef72b53 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I87aacf6221cd562fb61b7158ba6552ab3be42bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894231Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711440}
-
Brandon Wylie authored
Bug: 998233 Change-Id: I16030e0984e8bab91c50078805642aa956dddcf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775263 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#711439}
-
dpapad authored
- SetZoomLevelForView() was not used anywhere. - GetZoomLevelForView() was only used in a test. Replaced with GetZoomLevel(). Bug: None Change-Id: If481d2477e924a4119d49ba586679c63d0320fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877647 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#711438}
-
Eric Orth authored
DnsConfigChangeManagerClient::OnSystemDnsConfigChanged -> DnsConfigChangeManagerClient::OnDnsConfigChanged because, as of crrev.com/c/1783280, such notifications can now include non-system changes added by the Chrome net stack to the effective config. TBR=jam@chromium.org Bug: 971411 Change-Id: If46b175497a5995442e52f66152d065b0ec9b61d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787999 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#711437}
-
Yue Zhang authored
Bug: 1019727 Change-Id: I4a07764eb71c4ff7f843602795e35d7262120c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890393Reviewed-by:
-
Eric Stevenson authored
Same version, but the local patch now updates the max depth for a cycle detection search in R8. This allows -checkdiscard to work for generated JNI wrapper classes. Bug: 993421 Change-Id: Ib98d3ee31698788d0b0296335ff334dd2c46128f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893987 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#711435}
-
Jesse Schettler authored
Add a std::map to store a PrintRenderFrame with the RenderFrameHost used to bind it. When calling GetPrintRenderFrame(), use the provided RenderFrameHost to fetch the correct PrintRenderFrame associated remote or create a new one. Bug: 1019847, 1019960, 1020108 Test: https://clusterfuzz.com/testcase-detail/4896664890245120 Change-Id: I5ebf26b1dcdcd045bac1d1c5b204c8517fdb5ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892055Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#711434}
-
Yuly Novikov authored
conformance/textures/misc/texture-complete.html flaky on Win7 NVIDIA passthrough Vulkan. TBR=kbr Bug: 1020295 Change-Id: Ib4e0a8437e0238291eb1ca4ea97d59e1d013a4aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894176Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#711433}
-
Joshua Bell authored
None of the AllowIndexedDB/AllowCacheStorage overrides use the "origin" params, so remove them. The renderer shouldn't be trusted anyway. Bug: 1019772 Change-Id: Ibc29455d9631b2eb36743dc5e389d0661f71219e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893678 Auto-Submit: Joshua Bell <jsbell@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#711432}
-
Nico Weber authored
They are only needed for ownership, so no need to give them names and concrete types. Removes some forward declarations from the header and serendipitously happens to remove GOOGLE_CHROME_BUILD from the header as well. No intended behavior change. Bug: 961769 Change-Id: Ibaaf3375bd9d367b4cc83b9a8ec3e64193750a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894032 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#711431}
-
Matt Menke authored
Also correctly populate log entry fields that were not being correctly populated, and rename one that now has a different meaning. Bug: 997049 Change-Id: I646a8e837b2aca6631c701fba261d1ea149b19f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893733Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#711430}
-
Greg Thompson authored
ScopedPathOverride instances must be cleaned up after TaskEnvironment so that residual tasks have a chance to close all open file handles. BUG=546640 R=joedow@chromium.org Change-Id: I4c3b26e1176ec851625e2d8041ed91c9ce56b9ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889976 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#711429}
-
Etienne Pierre-doray authored
This will be used in follow up to compute agent interference metric. https://chromium-review.googlesource.com/c/chromium/src/+/1888091 Bug: 1019856 Change-Id: I493a253a4370cc24455efb0290a13f1579d7773e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881726Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#711428}
-
Arnaud Mandy authored
Adding more appropriate wording. WAITING->UNKNOWN EXISTED->SUPPORTED ABSENT->NOT_SUPPORTED renaming also EcLidAngleDriverPath to ECLidAngleDriverPath Bug: 1018705 Change-Id: Ife204169ff99c4f0c6de10f55b3e39dd17bc8d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883574 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#711427}
-
Long Cheng authored
Bug: 1019519 Change-Id: Iea88af5abfba789cc0c02fd734d1e0954c33911c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890723Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#711426}
-
Tommy Steimel authored
This CL makes MediaNotificationView notify its container when the header is clicked. This allows GMC's MediaNotificationContainerImplView to handle header clicks as if the container itself was clicked (which is fine since clicking the header on GMC has no effect since we hide the expand button). This fixes an issue where if the user clicked on the header (which is visually indistinguishable from the rest of the notification) then we would not go back to tab. Bug: 1020300 Change-Id: I7640b4d268871f2fe49c87c3b174f4a49e716500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894190Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jazz Xu <jazzhsu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#711425}
-
Kevin McNee authored
Tbr: wjmaclean@chromium.org Bug: 1020313 Change-Id: I6acb083812d8d5c91bba57bc7b4fc367798c2624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894256Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#711424}
-
Omer Katz authored
Incremental marking queries the background_marking_time statistic when it evaluates progress. The concurrent marker can update the statistic at the same time. Querying the statistic needs to be atomic. Bug: 986235 Change-Id: If69dca913f9ba2dba2d03a27801443248ce8f272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893266 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#711423}
-
Daniel Rubery authored
This reverts commit 9015f1fd, relanding 1a90cb5c. The TestBinaryUploadService did not initialize saved_result_ or saved_response_, leading to MSAN failures. Original change's description: > Preserve original Safe Browsing verdict for download deep scanning. > > In cases where deep scanning fails, we currently supply a SAFE verdict. > If the original verdict from Safe Browsing was UNCOMMON, we will > therefore downgrade the warning. This CL preserves the original verdict > and returns it in cases where deep scanning fails. It also adds a test > implementation of the BinaryUploadService, for easier testing of code > using uploads. > > Fixed: 1017921 > Change-Id: I444b301c3fe75ebbe0561bc6b201945242f09dc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887736 > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Reviewed-by: Bettina Dea <bdea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711049} Bug: 1017921 Change-Id: Ia9dfc92f1e67b9d0bffc011c6ddbaa71467f41d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893743Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#711422}
-
Omer Katz authored
Incremental marking goes in and out of AtomicPauseScope during marking. Checking InAtomicPause while concurrent marking can race with the incremental marker exiting AtomicPauseScope. Checking InAtomicMarkingPause only if !IsInIncrementalMarking checks the same condition overall but concurrent markers won't need to check InAtomicMarkingPause because IsInIncrementalMarking will always be true while concurrent marking is active. Bug: 986235 Change-Id: I6d21843b25db553dfcd0ae0e95ec3c43eaa99d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893851Reviewed-by:
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/fe37af11a69c88ae5c63c5eb846552237a4fc8e9..6be491b7bb57c3950d4fbb97fdd4a141e3fa4d63 The following commits have Chromium bugs associated: 6be491b7b Work around more C language bugs with empty spans. Bug: 1019588, 1019644 Change-Id: Ic0329ae6c6e76ea0bedc1830f3a36abc7c3e2d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891011 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#711420}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3bc571a527f4..7aa214a27bca git log 3bc571a527f4..7aa214a27bca --date=short --no-merges --format='%ad %ae %s' 2019-10-31 lalitm@google.com Merge "trace_processor: make table rowmaps ranges by default" 2019-10-31 lalitm@google.com Merge "trace_processor: make filtering more efficient by filtering on type" Created with: gclient setdep -r src/third_party/perfetto@7aa214a27bca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Idc7faf065900cd535f8683fa96878cbe00a45858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893323Reviewed-by:
-
Bill Budge authored
- Adds a histogram to report WebAssembly startup time for the streaming compile path, to compare baseline compilation speed with deserialization from the code cache. - Removes the obsolete metric for deserialization alone. Bug: chromium:719172 Change-Id: I1811a9d51d12dd65857ef73a2fe415b53374d1f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893972Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#711418}
-
Elly Fong-Jones authored
This change will be merged to the M79 branch in keeping with the flag deprecation rollout strategy: * M78 expires flags set for 76 & earlier * M79 expires flags set for 78 & earlier * M80 expires flags set for 80 & earlier * MXX expires flags set for XX & earlier onward Bug: 1019714 Change-Id: Ic789610160f1de11715ed41d6ff153a71487a08d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890814Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#711417}
-
Jared Saul authored
Change-Id: Idf15b3f9a1f4f6cb4558859325de266cf5f3ff77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892131 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#711416}
-
Jared Saul authored
Tests relating to the [No thanks] button or the StrikeDatabase should now be enableable on Chrome OS. Change-Id: Iba760339f852b9faa7db787614fcd806782caea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891853Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#711415}
-
Tarun Bansal authored
The crash only happens on certain devices in certain countries. The crash trace seems to indicate that the context could be null in some cases. Change-Id: I0ad8bdd4c79e66f7eebaf269154b9852e48e787f Bug: 1019974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892062Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#711414}
-
Alex Moshchuk authored
When the user closes a tab (or browser), we first determine whether we can take a "fast shutdown" path and simply shut down the main frame process. That can be done if nothing in the current tab (or all tabs if closing the browser) needs to run beforeunload/unload handlers. Otherwise, we take the slow path, actually try to run those handlers in all the frames, and wait for the results (including beforeunload dialog dismissals) before proceeding with the close. Historically, this was done by checking SuddenTerminationAllowed() on the main frame's process, which would be set to true when *any* frame in that process adds a beforeunload or unload handler. When site isolation shipped, we also added code to consult beforeunload handlers in cross-site iframes (see issue https://crbug.com/853021) in M68. But SuddenTerminationAllowed() is actually too coarse-grained for this: it not only becomes false due to (before)unload handlers, but other things as well (such as BlobBytesProvider). So https://chromium-review.googlesource.com/c/chromium/src/+/1504130 changed things to explicitly consult the main frame's beforeunload/unload handler status, as tracked by RFH::GetSuddenTerminationDisablerState(), instead of SuddenTerminationAllowed(). Unfortunately, it seems that in that CL we forgot about the process-wide nature of SuddenTerminationAllowed(), specifically that it also covered handlers from any subframes in the same process. And/or, we missed that the call in WebContentsImpl::NeedToFireBeforeUnload() to check subframes via GetMainFrame()->ShouldDispatchBeforeUnload( true /* check_subframes_only */); was in fact only checking cross-site iframes, skipping not only the main frame but also its same-site descendants. That means we would incorrectly fast-close the tab (or browser) even if a same-site iframe had a beforeunload handler. This CL fixes this by walking the full frame tree to check for these handlers and adds two regression tests for the tab close and browser close cases. Along the way, the CL also fixes a TODO to check not only beforeunload but also unload handlers in subframes. This is a bit more correct and will also make it easier to fix issue 1014550, though note that subframe unload handlers weren't broken before -- they actually still ran due to the subframe unload process timeout that we still have in RenderProcessHostImpl::DelayProcessShutdownForUnload(). Bug: 1010456, 1014550 Change-Id: I2b2c3e2ee546a766e5838e14f293266def4aeeed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881948 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#711413}
-
Leonard Grey authored
- Removes restriction that live region changed events need to be fired from nodes with the live region role, since we don't actually do this in UI code. - Announces the node's name as the live region text, falling back to inner text if name isn't set. Again, this tracks how we actually use the notifications. - Debounces multiple notifications from the same node to one per 20ms Bug: 1015002 Change-Id: Id564c85cd0ab0888877d4cf4b12fb872d1306284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871830 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#711412}
-
Peter Boström authored
This is a simple change for animating the thumbstrip in/out. If this is performant enough for now we might not have to interact with the top-chrome slide controller. Bug: chromium:992972 Change-Id: I2ed765cd61591c5941fcc851edb85b7e04089a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894035 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#711411}
-
David Van Cleve authored
This CL adds logic to HostCache to prioritize and deduplicate addresses from address lists during merging. The merge step now deduplicates addresses (across the two lists) and then performs a stable sort by, first, whether addresses have associated ESNI keys and, second, whether they are IPv6 or IPv4. Changes by location: - HostCache: new merging logic - dns_util: new utility function to deduplicate an address list in a stable manner (uses a flat_map for low overhead) - HostResolverManager: 1. deduplicate addresses when parsing A and AAAA responses 2. modify logic around the AddressSorter::Sort callsite to account for the fact that the first address in a combined address list may not be IPv6 Test: 1. HostCache unittests to test merging 2. dns_util unittest to test the deduplication routine 3. HostResolverManager unittest to test that the addresses HostResolverManager surfaces are sorted and deduplicated R=ericorth Bug: 1003494 Change-Id: I322d6342902c634f55d24a1a8074e52817e6e6a9 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887372 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
-
