GitLab

R=felt@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/656523002

Cr-Commit-Position: refs/heads/master@{#299407}

Currently, the lint warns at:
AccountsAdapter.java:29 Unconditional layout inflation from view adapter:
    Should use View Holder pattern (use recycled view passed into this method
    as the second parameter) for smoother scrolling: ViewHolder [warning]

This CL fixes the above lint error.

BUG=327768

Review URL: https://codereview.chromium.org/628133003

Cr-Commit-Position: refs/heads/master@{#299406}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ef3851c..4c8283b

TBR=caseq@chromium.org,apavlov@chromium.org,cbiesinger@chromium.org

Review URL: https://codereview.chromium.org/653783002

Cr-Commit-Position: refs/heads/master@{#299405}

BUG=357204

Review URL: https://codereview.chromium.org/641043003

Cr-Commit-Position: refs/heads/master@{#299404}

Now we only try to calculate application_energy_consumption when we
actually have a known quiescent power draw. This means we'll still
output it on tab_switching, but not on page cycler. That should fix
errors like this:
http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf/builds/2187/steps/page_cycler.morejs/logs/stdio

BUG=

Review URL: https://codereview.chromium.org/649903003

Cr-Commit-Position: refs/heads/master@{#299403}

R=agl@chromium.org
BUG=

Review URL: https://codereview.chromium.org/652953002

Cr-Commit-Position: refs/heads/master@{#299402}

BUG=395172
NOTRY=true
TBR=bruening@chromium.org

Review URL: https://codereview.chromium.org/652083002

Cr-Commit-Position: refs/heads/master@{#299401}

an explicit "!= 0".

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/650303003

Cr-Commit-Position: refs/heads/master@{#299400}

BUG=421695
TEST=gpu_unittests, webgl_conformance_tests
R=bajones@chromium.org

Review URL: https://codereview.chromium.org/656613002

Cr-Commit-Position: refs/heads/master@{#299399}

+ Formatting/indentation changes.

R=rch@chromium.org

Review URL: https://codereview.chromium.org/651993003

Cr-Commit-Position: refs/heads/master@{#299398}

Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after.
A number of similar CLs were landed, and none of them caused issues. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers.
Landing as TBR since this is a mechanical, safe and temporary change.

This CL instruments callbacks invoked from the last "PostOrRunCallback" call in "SSLClientSocketNSS::Core::DoReadCallback".

BUG=418183
TBR=asanka@chromium.org, zea@chromium.org

Review URL: https://codereview.chromium.org/646273003

Cr-Commit-Position: refs/heads/master@{#299397}

Revert of Enable the Rightware Browsermark benchmark (patchset #1 id:1 of https://codereview.chromium.org/649283002/)

Reason for revert:
Temporarily disable the Rightware Browsermark benchmark

Original issue's description:
> Enable the Rightware Browsermark benchmark
>
> This patch un-disables the rightware browsermark benchmark. Manually
> testing shows this finishes in under 5m on a Nexus 5.
>
> BUG=423018
>
> Committed: https://crrev.com/6c816144b656046b41cd0cc3bce167e9a3a9febc
> Cr-Commit-Position: refs/heads/master@{#299369}

TBR=qyearsley@chromium.org,wangxianzhu@chromium.org,tonyg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=423018

Review URL: https://codereview.chromium.org/649353003

Cr-Commit-Position: refs/heads/master@{#299396}

WGL needs to create a window and should pump its message loop, so use a UI message loop.

BUG=273220

Review URL: https://codereview.chromium.org/643373002

Cr-Commit-Position: refs/heads/master@{#299395}

The audio_client.js content script is copied from the existing hotword_helper
extesion, with the only change being the hotword extension ID to point to this
new extension.

BUG=397019

Review URL: https://codereview.chromium.org/600523004

Cr-Commit-Position: refs/heads/master@{#299394}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/6c07907..07894c4

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/656553002

Cr-Commit-Position: refs/heads/master@{#299393}

TransformPathForFeature in child_process_host_impl.cc expects to find
`Chromium Helper XX` inside the .app bundle, but
views_examples_with_content_exe is a standalone executable. The example
app doesn't need plugins so this CL disables plugin discovery to avoid:

Check failed: kMacOSName == macos_path.BaseName().value() (MacOS vs.
Debug)

This occurs when particular pages are loaded in the WebView example,
triggered via content::PluginLoaderPosix::LoadPluginsInternal().

The change is made in views_content_client, which affects app_list_demo
and views_examples_with_content_exe.

BUG=395507

Review URL: https://codereview.chromium.org/655433002

Cr-Commit-Position: refs/heads/master@{#299392}

Revert of Mac: Update sheet position when bookmark bar is shown or hidden. (patchset #1 id:1 of https://codereview.chromium.org/502413004/)

Reason for revert:
Broke certificate info positioning when switching tabs (http://crbug.com/419371).
I will need to come up with a better fix for this, but it looks complicated and that bug is a M39 stable blocker so reverting this first.

Original issue's description:
> Mac: Update sheet position when bookmark bar is shown or hidden.
>
> In r272421, I changed sheet repositioning on window resize to be based on
> NSWindowDidResizeNotification instead of NSViewFrameDidChangeNotification
> because it tracks window resizing much more smoothly.
>
> That caused this problem where if the browser window is vertically maximized
> (or is in fullscreen), the window size does not change when the bookmark bar
> is shown or hidden.
>
> The old code has a different bug however. If the browser window is not
> vertically maximized, showing or hiding the bookmark bar does not change the
> browser content view's frame. It moves up or down to follow the window resize
> but its frame relative to its superview remains the same.
>
> I settled for adding code to explicitly update the sheet's position when the
> bookmark bar is shown or hidden.
>
> BUG=407509
>
> Committed: https://crrev.com/5648b809d1c50e3de754b96abe7cf2b60150ff4d
> Cr-Commit-Position: refs/heads/master@{#292421}

TBR=avi@chromium.org
BUG=407509

Review URL: https://codereview.chromium.org/653733002

Cr-Commit-Position: refs/heads/master@{#299391}

Also use a new method for callback chaining, which is slightly less
flexible but much less "callback hell".

BUG=377232
R=armansito@chromium.org

Review URL: https://codereview.chromium.org/628983003

Cr-Commit-Position: refs/heads/master@{#299390}

Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after.
A number of similar CLs were landed, and none of them caused issues. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers.
Landing as TBR since this is a mechanical, safe and temporary change.

This CL specifically instruments some presumably most popular callbacks invoked by “callback.Run(result);” line in TCPClientSocket::DidCompleteReadWrite.

BUG=418183
TBR=asanka@chromium.org

Review URL: https://codereview.chromium.org/652853002

Cr-Commit-Position: refs/heads/master@{#299389}

This causes a deadlock, so it's not usable. Getting rid of the window at least allows --in-process-gpu to work.

BUG=273220

Review URL: https://codereview.chromium.org/649863002

Cr-Commit-Position: refs/heads/master@{#299388}

BUG=415688
TEST=gpu_unittests, webgl_conformance_tests
R=kbr@chromium.org,bajones@chromium.org

Review URL: https://codereview.chromium.org/651543003

Cr-Commit-Position: refs/heads/master@{#299387}

In smoothness takes priority mode, we should ensure to return tiles
that are required for activation sooner than eventually bin. The reason
for this is that we don't want to starve activation and the prepainting
required for smoothness should already be covered by the soon bin.

Additionally, we have to ensure not to mark these tiles as violating
memory policy, since required for activation tiles need special
treatment (unfortunately). The reason for this is that activation is
currently tied to updating our recordings and smoothness mode would
otherwise starve activation even if we're past the recording region.

BUG=422819
R=reveman

Review URL: https://codereview.chromium.org/651503004

Cr-Commit-Position: refs/heads/master@{#299386}

Motivation:
* chromecast/service/ directory had interplay with chromecast/shell/browser
  code, since the service is all run in the browser process and mildly
  coupled (involves starting WebContents instances, etc,). Made more sense
  for chromecast/service to live in chromecast/shell/browser.
* chromecast/shell/ directory is needless hierarchy, since the entire
  chromecast/ directory represents the Chromecast content-embedder.

Highlights:
* chromecast/shell/{app,browser,common,renderer} --> chromecast/*
* chromecast/shell/browser/resources --> chromecast/app/resources
* chromecast/shell/settings --> chromecast/app/resources
* chromecast/shell/android --> chromecast/browser/android
* chromecast/metrics --> chromecast/browser/metrics
* chromecast/service --> chromecast/browser/service

R=lcwu@chromium.org,gusfernandez@chromium.org,byungchul@chromium.org
TBR=xhwang@chromium.org,asvitkine@chromium.org,thestig@chromium.org,jam@chromium.org,yfriedman@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/638803002

Cr-Commit-Position: refs/heads/master@{#299385}

This change adjusts the scroll bubbling logic in LayerTreeHostImpl so
that outer viewport layer scrolls affect the top controls. Additionally,
the outer viewport's size is adjusted to match the inner viewport's
aspect ratio until a resize occurs.

Blink side: https://codereview.chromium.org/643473002
BUG=364109

Review URL: https://codereview.chromium.org/641873003

Cr-Commit-Position: refs/heads/master@{#299384}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c5733ed..ef3851c

TBR=caseq@chromium.org,apavlov@chromium.org,cbiesinger@chromium.org

Review URL: https://codereview.chromium.org/656543004

Cr-Commit-Position: refs/heads/master@{#299383}

This prevents an assert when running in debug mode.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/648763003

Cr-Commit-Position: refs/heads/master@{#299382}

This mostly just adds the chrome_shell_apk build definition and those of
a whole bunch of targets.

Adds a simple check that when DEPRECATED_java_in_dir is used, it
actually includes the "src" at the end (GYP just assumes that you really
meant that java files are in <(java_in_dir)/src).

Makes the call to process_resources only generate R.java for extra
packages when being run as part of the apk step (otherwise, for
example, both chrome resources and content resources would contain
an R.java for net resources and compilation would fail).

Depends on https://codereview.chromium.org/581273004/

Adds the following targets -- and enables ~300 more (550 counting
template-generated inner targets):

//chrome:chrome_android_core
//chrome/android:chrome_strings_grd
//chrome/android:chrome_java
//chrome/android:activity_type_ids_javagen
//chrome/android:app_banner_metrics_ids_javagen
//chrome/android:resource_id_javagen
//chrome/android:profile_account_management_metrics_javagen
//chrome/android:profile_sync_service_model_type_selection_javagen
//chrome/android:toolbar_model_security_levels_javagen
//chrome/android:tab_load_status_javagen
//chrome/android:chrome_shell_base
//chrome/android:chrome_shell
//chrome/android:chrome_sync_shell
//chrome/android:chrome_shell_resources
//chrome/android:chrome_shell_java
//chrome/android:chrome_shell_assets
//chrome/android:chrome_shell_apk
//chrome/android:chrome_sync_shell_apk
//components/bookmarks:bookmarks_java
//components/bookmarks:bookmarks_jni_headers
//components/bookmarks:bookmark_type_javagen
//components/dom_distiller/android:dom_distiller_core_java
//components/dom_distiller/android:dom_distiller_core_font_family_javagen
//components/dom_distiller/android:dom_distiller_core_theme_javagen
//components/enhanced_bookmarks:jni_headers
//components/enhanced_bookmarks/android:enhanced_bookmarks_java
//components/gcm_driver:gcm_driver_java
//components/gcm_driver:jni_headers
//components/navigation_interception/android:navigation_interception_java
//components/variations:variations_java
//components/web_contents_delegate_android:web_contents_delegate_android
//components/web_contents_delegate_android:web_contents_delegate_android_java
//components/web_contents_delegate_android:web_contents_delegate_android_jni_headers
//printing:printing_java
//sync:fake_server_jni
//sync:sync_java_test_support
//sync:test_support_sync_fake_server_android
//sync:sync_unit_tests_apk
//sync/android:sync_java
//sync/android:sync_javatests

BUG=359249
TBR=ben

Review URL: https://codereview.chromium.org/570203002

Cr-Commit-Position: refs/heads/master@{#299381}

Add more information to LOG(DFATAL) in QUIC's tcp_loss_algorithm.

Merge internal change: 77370712
https://codereview.chromium.org/644123003/

Fix a bug where packet received times aren't sent if the approximate now
time is less than the packet's actual receive time.

Merge internal change: 77056400
https://codereview.chromium.org/643313003/

Change the pacing sender to always pacing the initial burst, even when
an RTT sample hasn't been taken.

Merge internal change: 77004656
https://codereview.chromium.org/644233002/

Set the server's idle timeout to 2s longer than the negotiated value(30s
by default) instead of 1s, in order to prevent failed requests.

Merge internal change: 76821863
https://codereview.chromium.org/651463004/

Call SetDefaults from the QuicConfig constructor instead of requiring
all callers to do so.

Merge internal change: 76709273
https://codereview.chromium.org/647933002

Allow the number of undecryptable QUIC packets buffered before the
CHLO/SHLO to be configured in QuicConfig.

Merge internal change: 76707156

On chromium side: set max undecryptable packets to the initial
congestion window size in QuicStreamFactory.

https://codereview.chromium.org/647923002/

QUIC - Minor formatting changes to keep in sync with internal source.

Found these changes while merging changes from chromium CLs:
  605733006, 605163004

  Chromium code review URL:
      https://codereview.chromium.org/605733006/
      https://codereview.chromium.org/605163004/

Merge internal change: 76636673
https://codereview.chromium.org/651513002/

Remove QuicSentPacketManager::DebugVisitor's OnSentPacket, since it's
redundant to QuicConnection::DebugVisitor's OnPacketSent.

Refactored QuicConnection::DebugVisitor's OnPacketSent in order to add
necessary fields for the trace... visitor.

Merge internal change: 76595983
https://codereview.chromium.org/627583002/

QUIC: if client provides an STK which includes CachedNetworkParams, then
store these and echo them back in future STKs if we have no newer
estimate to send. Flag protected behind disabled
FLAGS_quic_store_cached_network_params_from_chlo.

This is the followup to adding timestamp to the SourceAddressToken proto.
This allowed us to copy a previously provided CachedNetworkParams into
new STKs without losing timestamp data.

It also paves the way for recording BW estimate accuracy in the server:
we now have the client's provided BW estimate stored per connection, so
we can compare against BW that we see on the new connection (this will
be in a future CL).

Merge internal change: 76455340

chromium: this code doesn't impact client side code because we don't
parse SourceAddressToken (we keep it as a string). For QUIC server,
we are not parsing optional cached_network_params. Added a TODO
to convert SourcAddressToken and CachedNetworkParams to protobuf.

https://codereview.chromium.org/623003002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/648933003

Cr-Commit-Position: refs/heads/master@{#299380}

Previously, it only detected ports that were bound to *, localhost or
127.0.0.1. This detects ports bound to any interface. I noticed this
while investigating 294878, and it could certainly be a source of
flake, but I don't think it's the main one.

BUG=294878

Review URL: https://codereview.chromium.org/634803002

Cr-Commit-Position: refs/heads/master@{#299379}

- app_list_syncable_service is unnecessary at all
- browser_navigator is not necessary, we've introduced OpenURL

BUG=None
R=xiyuan@chromium.org
TEST=build succeeds

Review URL: https://codereview.chromium.org/650473002

Cr-Commit-Position: refs/heads/master@{#299378}

R=jshin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/627083003

Cr-Commit-Position: refs/heads/master@{#299377}

BUG=159234
NOTRY=true

Review URL: https://codereview.chromium.org/639903003

Cr-Commit-Position: refs/heads/master@{#299376}

(But don't use it yet.)

Also change the terminology slightly, and just use the all-around
confusing term "remote ID" (since what we really mean is
"remotely-allocated local ID" or "locally-allocated remote ID", both of
which mean the same thing but are used in different contexts ... and
both of which are very long phrases).

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/649303002

Cr-Commit-Position: refs/heads/master@{#299375}

This removes the "malloc" implementation of discardable memory.
This implementation exists for test and debugging purproses but
we currently don't have any tests that depend on it so it can be
removed to reduce code size.

This implementation can still be very useful to manually track
down bugs and performance issues in discardable memory clients
but can be maintained separately to reduce code size.

BUG=422953
TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/651913003

Cr-Commit-Position: refs/heads/master@{#299374}

BUG=422688

Review URL: https://codereview.chromium.org/650963002

Cr-Commit-Position: refs/heads/master@{#299373}

BUG=418577

Review URL: https://codereview.chromium.org/647443003

Cr-Commit-Position: refs/heads/master@{#299372}

BUG=386048

Review URL: https://codereview.chromium.org/638143003

Cr-Commit-Position: refs/heads/master@{#299371}

avformat/os_support: Add _DEFAULT_SOURCE to hide warning about _SVID_SOURCE depreciation

BUG=420149
NOTRY=true

Review URL: https://codereview.chromium.org/652433003

Cr-Commit-Position: refs/heads/master@{#299370}

This patch un-disables the rightware browsermark benchmark. Manually
testing shows this finishes in under 5m on a Nexus 5.

BUG=423018

Review URL: https://codereview.chromium.org/649283002

Cr-Commit-Position: refs/heads/master@{#299369}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/36ba250..c5733ed

TBR=caseq@chromium.org,apavlov@chromium.org,cbiesinger@chromium.org

Review URL: https://codereview.chromium.org/649233003

Cr-Commit-Position: refs/heads/master@{#299368}