GitLab

This change removes the stale kGooglePasswordManager base::Feature
from both Desktop and Android code. In addition, it also removes the
corresponding chrome://flag and associated navigation to settings logic.

Bug: 903249, 904821, 1126051
Change-Id: I8a77293fc61b4a721b2bae3c197dcade2cc5ea14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401338Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805394}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/168986591cc1..d281ff186273

2020-09-09 vyshu@google.com paygen: Stop adding unused attributes to update payload
2020-09-09 chrome-bot@chromium.org Update config settings by config-updater.
2020-09-09 chrome-bot@chromium.org Update config settings by config-updater.
2020-09-09 vapier@chromium.org cros_portage_upgrade: rename blacklist->ignore
2020-09-09 ahassani@chromium.org Reland "cros_update: Delete it."
2020-09-09 saklein@chromium.org commandline: Remove build-target type.
2020-09-09 vapier@chromium.org git: trim unused project methods
2020-09-09 bpastene@chromium.org cache: Handle trailing garbage when untarring via pbzip2.
2020-09-08 tcwang@google.com afdo: Only check milestone and timestamp for CWP profiles.
2020-09-08 chrome-bot@chromium.org Update config settings by config-updater.
2020-09-08 manojgupta@chromium.org cbuildbot: Enable goma even with latest toolchain
2020-09-08 chrome-bot@chromium.org Update config settings by config-updater.
2020-09-04 vapier@chromium.org gs_unittest: simplify stub tarball creation
2020-09-04 vapier@chromium.org gs: rm: add -- before path
2020-09-04 vapier@chromium.org image_test: ban tcl & update java packages
2020-09-04 saklein@chromium.org sysroot_controller: Ignore package versions in InstallPackages.
2020-09-03 moragues@google.com trogdor: add factory builder for factory-trogdor-13443.B
2020-09-03 vyshu@google.com remote_access: fix style
2020-09-03 chrome-bot@chromium.org Update config settings by config-updater.
2020-09-03 morg@google.com Skip unit tests for grunt-arc-r board builders
2020-09-03 seanabraham@chromium.org config_lib: borealis is a special suffix to remove for HW testing
2020-09-02 mmortensen@google.com BuildAPI: Use optional packages in Packages.GetTargetVersions.
2020-09-02 gredelston@google.com test_that: Rename whitelist-chrome-crashes
2020-09-02 chrome-bot@chromium.org Update config settings by config-updater.
2020-09-02 bpastene@chromium.org cache: Use 'pixz' when extracting .xz tarballs if it's installed.
2020-09-02 yichengli@chromium.org artifacts: Exclude private fingerprint libraries

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: I9e2c4dd0273665b09311bd32cc43a1ce6c3f5b39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401606Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#805393}

With this patch, PartitionAlloc holds the reference count (i.e. the
number of associated CheckedPtrs) for every non-direct-mapped
allocation. On free(), if the count doesn't equal zero, the allocation
is poisoned and quarantined until there are no references left;
therefore, use-after-free issues affecting CheckedPtr-protected
pointers become unexploitable.

This is a highly experimental feature, which is disabled by default.

Bug: 1073933
Change-Id: Icda4b6e0c303e472df4222e1418bf0fdfe9aeef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385456
Commit-Queue: Sergei Glazunov <glazunov@google.com>
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805392}

This CL batches AccountManagerFacadeTest.

Bug: 1120258
Change-Id: I8dd38caa05b3d689b022d2e1f14ac959b346f51a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398479Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805391}

crrev.com/c/2364049 fixed changed "GetChildCount" to return 0 for any
node that is a leaf, and portals are considered leaf nodes (with prune
tree enabled on Android) [1].

[1] https://source.chromium.org/chromium/chromium/src/+/master:content/browser/accessibility/browser_accessibility_android.cc;l=450;drc=6e8b402a6231405b753919029c9027404325ea00

Bug: 1120210
Change-Id: I021197d1f06ce92a1752f43c0aff85e9e66665f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391641
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805390}

Bug: 1124366
Change-Id: Ib4e8309bf5e248623af7577fb74d3451d6c39bf8
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396620
Commit-Queue: Alexander Surkov <asurkov@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805389}

This reverts commit e7896817.

Reason for revert: The fix for the most substantial issue
crbug.com/1121885 was fixed, and the Google Keep issue
crbug.com/1124446 was fixed too.

This patch sets EditingNG to "experimental" for M87. Note,
M86 is still "test".

Original change's description:
> Change EditingNG from experimental to test
>
> EditingNG has some instabilities such as <crbug.com/1121885>.
> In order to help users who turn on "Experimental Web Platform
> features" from hitting these issues, this patch changes
> EditingNG back from "experimental" to "test".
>
> Once ourstanding issues were resolved, we will change it back
> to "experimental".
>
> This is a revert of r791809 <crrev.com/c/2319947>. Some
> rebaselines are needed because these tests do not seem to
> honor "test" status.
>
> Bug: 707656, 1125477
> Change-Id: I433200cb7fb450036a631ee8ed578ab395413540
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390936
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Commit-Queue: Koji Ishii <kojii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#804839}

TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org


Bug: 707656
Bug: 1125477
Change-Id: I3e95b3630f2510378e39434bf52756b581647333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398359Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805388}

Fixed: b/166115080, 1106369
Change-Id: Iee1d5c90fd6c9d8e1ad38462f9611654275c0bec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381734
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#805387}

Bug: 1124000
Change-Id: I9df9d450e7e1cd053407b24e83421a7d1242a19f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389241Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805386}

This reverts commit 849b3b5d.

Reason for revert: The assumption that the progress signal comes after
status signal was wrong, so this change causes a bug when re-running the
check.

Since this was meant to be merged, reverting + fix is easier than fixing
in a follow-up CL.

Original change's description:
> [PwdCheckAndroid] Add delay between check status header updates
>
> This CL adds a delay to status updates whenever multiple updates are
> notified to the mediator in a short time window.
> The minimum time interval between updates is set to 1 second.
>
> Bug: 1122026, 1092444
> Change-Id: I64d9c95a11a5ed9b9d6fcf8941c260bf8b3a64ac
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390642
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
> Commit-Queue: Ioana Pandele <ioanap@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#805236}

TBR=tedchoc@chromium.org,fhorschig@chromium.org,ioanap@chromium.org,erocchi@google.com

Change-Id: I737eee5e355033542dc9ba8393eedc3390baf5de
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1122026
Bug: 1092444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401620
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805385}

Bug: 1123907
Change-Id: Iff61b2298aecfa7f06f0755886896817613a50aa
Tbr: davidvc@chromium.org
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401326Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805384}

A cheap way of saving a kilobyte of binary size by simply making some
fields narrower. This decreases the size of this from 20 bytes to
12 bytes per entry. 8 bytes could be done with some more intrusive
repacking, but there are diminishing returns.

Change-Id: If89d2025b6b374766d602cd7caafac5e675d4c7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243252
Commit-Queue: Owen Min <zmin@chromium.org>
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805383}

This is spin-off from https://crrev.com/c/2381050 and addressess the same re-entrancy problem for arcvm

ConciergeClient::Observer is implemented by arc_vm_client_adapter.cc and crostini_stability_monitor.cc
arc_vm_client_adapter.cc has the same issue as the container so the TEST below ensures that the change is same
crostini_stability_monitor.cc is only firing metric

ConciergeClient::VmObserver is implemented by arc_vm_client_adapter.cc, lock_to_single_user_manager.cc, crostini_manager.cc, cros_usb_detector.cc and arc_session_manager.cc
I checked all the consumers and I don't see anything registering another observer in the event handler

ConciergeClient::ContainerObserver is implemented by CrostiniManager
when CrostiniManager gets OnContainerStartupFailed, it fires a callback as well
The callback is ultimately StartLxdContainerFinished which then fires OnContainerStarted (in case of failure) on its own observer
Which is implemented by CrostiniInstaller in which it fires its own callback that comes from Install method which seems to be only used in unit tests.

ConciergeClient::DiskImageObserver is implemented by CrostiniDisk and PluginVMInstaller

CrostiniDisk registers callback in OnResize which is a callback of ResizeDiskImage
ResizeDiskImage is called in OnVMRunning which is a callback for ResizeCrostiniDisk which is called by CrostiniHandler::HandleResizeCrostiniDisk and ResolveResizeCrostiniDiskCallback is the callback that ultimately gets fired
which invokes a javascript function

PluginVMInstaller registers itself in OnConceirgeAvailable
In the event handler, the PluginVMInstaller fires its own observer which is implmeented by PluginVmInstallerView which only updates the labels on UI.

I don't see any place where we're adding another observer during these callbacks which would need to receive the same event that is currently being observed therefore the change is safe.

BUG=b:164816080
TEST=deploy to dut, disable playstore, re-enable playstore, successfully finish the authorization flow
TEST=deploy to dut, turn on crostini, successfully launch terminal, turn off crostini

Change-Id: Ida55a24b04f87053bcfb7c958b63cc0ea883fa33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389060
Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805382}

Bug: 625562
Change-Id: I77bc4e7761e81254f73971f026d5e74a0a2d2d8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394755
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805381}

Bug: 1124366
Change-Id: I2dccf90e0de2ef06969630c0d6b890f5e619cf39
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392848
Commit-Queue: Alexander Surkov <asurkov@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805380}

Using wpt-import in Chromium da5bb9a6.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=smcgruer@google.com

No-Export: true
Change-Id: Ib1415a7612717e7582a9869965035a26971390dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401059Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#805379}

SkiaOutputSurfaceImplOnGpu now creates a SharedImageFactory with a
reference to its member SharedContextState, but due to C++ ordering
of destructors, ImplOnGpu's destructor will actually decrement the
refcount of (and potentially destroy) its SharedContextState before
invoking SharedImageFactory's destructor.

Unfortunately, ExternalVkImageFactory's destructor performs
nontrivial work using the SharedContextState which may now be freed.
This CL fixes this bug by explicitly deleting the SharedImageFactory
before ImplOnGpu releases its members.

Bug: 1125210
Change-Id: I5b625284622df537fd20ad58384cabbe7c46cf83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399600
Commit-Queue: Brian Ho <hob@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805378}

This reverts commit 55327727.

Reason for revert: closes tree due to compile failure

Original change's description:
> Roll Catapult from dc9083e4831f to 6acdaf066c12 (1 revision)
> 
> https://chromium.googlesource.com/catapult.git/+log/dc9083e4831f..6acdaf066c12
> 
> 2020-09-09 mheikal@chromium.org Improve AdbWrapper#is_emulator to use device codename vs serial
> 
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/catapult-autoroll
> Please CC rmhasan@google.com on the revert to ensure that a human
> is aware of the problem.
> 
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Bug: chromium:11249650
> Tbr: rmhasan@google.com
> Change-Id: I54ff4cc762cc377c12d3a6a7a73d506dffb50304
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401598
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#805359}

TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,rmhasan@google.com

Change-Id: Idb9a153ae3986b1ff1df4e74a9bb0d7b32369810
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:11249650
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401306Reviewed-by: David Van Cleve <davidvc@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805377}

Bug: 1021566

Change-Id: I5cde1174d6715c3d81dc0bf9f446bde6f567b7f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391261Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805376}

https://skia.googlesource.com/skia.git/+log/1313d1aa7a18..21bebc68fda6

2020-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 880013579381 to 0a1061da0c7f (14 revisions)
2020-09-09 johnstiles@google.com Return a 'made-changes' flag from control-flow optimization.
2020-09-09 reed@google.com remove unused (and bit-rotting) Lua support
2020-09-09 nifong@google.com Add a short description for concat and setmatrix saying whether it's a translate or something else
2020-09-09 cwallez@chromium.org Roll third_party/externals/spirv-cross/ 7778792ae..bdbef7b1f (19 commits)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: reed@google.com
Change-Id: Ibe82846287a44ba3bd38516afdda043f84045fba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401602Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#805375}

Invalidate send and receive surfaces to make sure we start or stop
advertising based on changes to Bluetooth "powered" or "present" state.

Bug: b:166174379
Change-Id: I252c65d9f27594e0e6e83ad233d9f051bb25700e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391586
Commit-Queue: Michael Hansen <hansenmichael@google.com>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805374}

This change removes two unneeded binaries from the source tree. The
files were created by tests and inadvertantly committed.

A "Cached Theme.pak" file is an optimized version of a browser theme,
cached to speed up loading of the theme. By default, it is created in
the extension's directory.

The "chrome/test/data" directory contains seed data used by tests.
This includes folders containing sample themes. Certain tests install
these sample themes, leaving behind the cached-theme files.

Bug: 852623
Change-Id: I563fe9a12e51d3f3507f2a4a00b16bc4e5368598
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399575Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#805373}

This restriction comes from ReadingListModel's implementation.

Bug: 1117023
Change-Id: Ibc3f05b7d9523e1dde3661a9559936adb12c52f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399015
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805372}

Mutability of the animation timeline is behind the feature flag for
ScrollTimeline. The feature is marked as web-exposed, but with a no-op
implementation if the feature flag is not set. The rationale for this
setup is that we don't support conditionally readonly attributes in IDL.

With the patch, a number of the failing tests are now failing for
different reasons:
* Replaceable animations should consider all timelines when determining
  if an animation can be removed. Our current implementation only
  considers other animations on the same timeline when making the
  decision. Fixing these failures requires some refactoring, which is
  deferred to a followup CL.
* Resetting the timeline cancels a running CSS animation or transition.
  Some refactoring is required to ensure that we properly compute the
  cancel time as it depends on the old timeline. Again, deferring to
  a followup CL.

https://github.com/w3c/csswg-drafts/issues/5159
https://github.com/w3c/csswg-drafts/issues/5422
https://drafts.csswg.org/scroll-animations-1
https://www.chromestatus.com/feature/6752840701706240

Bug: 827626
Change-Id: I1fea09a80e8730694455c06b192cb9e068eb0c55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324101Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805371}

Dark Mode single line: https://drive.google.com/file/d/1_sK8UZ3bXhQjsvpFEWGfzB1d4A105M3t/view
Light Mode multi-line: https://drive.google.com/file/d/16uwoOIRa7jAv08KTMNKcmE4qbDoH79NE/view

There are still a few bugs which will need to be fixed in a follow up:
1. Multiline text hides the close button and doesn't have correct alignment/padding
2. Dark color mode should match context menu color (adaptive color needs to be added for this case).


Change-Id: Id9196815d4e9539a53c0e01aa52e104be28b9b99
Bug: 1099982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340007
Commit-Queue: Ben Goldberger <benwgold@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#805370}

Add a temporary DumpWithoutCrashing for when an invalid header key is
set. This is to debug crbug.com/1028189 where a header key fails to
deserialize correctly.

Bug: 1028189
Change-Id: I8848f1b4b78363b56babd787d73f24f8c11dec3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401278Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805369}

This reverts commit 1f06da32.

Reason for revert: breaks mac and mac is on dogfood. horizontal and
vertical scrollbars appear on mac.

Original change's description:
> [Tab Scrolling] Workaround to hide horizontal scroll bars.
>
> Horizontal Scroll bar visibility is currently coupled with its
> functionality.
>
> Bug: 1122214
> Change-Id: I9a0c3ffb0e7128c4444b175631b7cbaf2411f7af
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393257
> Commit-Queue: Charlene Yan <cyan@chromium.org>
> Reviewed-by: Peter Boström <pbos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#804506}

TBR=pbos@chromium.org,cyan@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1122214
Change-Id: I54532dccb5109c3f921b37beb987b22de776be3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399513Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Charlene Yan <cyan@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805368}

This reverts commit 659b4301.

Reason for revert: Likely caused compile failure in android x86 builders since:
* https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2148
* https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1252

Tracking bug: crbug.com/1126519

Original change's description:
> Android: Add support for tracing sampling profiler on arm64
> 
> Support stack unwinding for tracing sampling profiler, in arm64
> builds. The builds always enable frame pointers, so stack unwinding can
> be done using frame pointers.
> 
> 
> Future work: Support module cache for arm 64.
> 
> BUG=1110044
> 
> Change-Id: If98bcc5582edc75b61c5a385cd29535f4a6ee195
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321230
> Commit-Queue: ssid <ssid@chromium.org>
> Reviewed-by: Mike Wittman <wittman@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: oysteine <oysteine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#805274}

TBR=thakis@chromium.org,wittman@chromium.org,oysteine@chromium.org,ssid@chromium.org

Change-Id: Ib9b2d1563951937e22b4299b44bdeec21e2c014f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1110044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401799Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#805367}

Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009090800_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/AsR6b9xlxrEC7Kxx3tzZ2Pn1DDftdw15hFUg0Q8B6ZoC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/159755952,b/161418185,b/161558109,b/162294373,b/162696369
Tbr: media-app@grotations.appspotmail.com
Change-Id: Ib2111bef5533a84c7ed83c1213bccb53d6f203c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401599Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#805366}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/88a5d76f5f62..214971471446

2020-09-09 jacktfranklin@chromium.org Expose the live directive from LitHtml
2020-09-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ie7af2d4c541d054337a72daa4e11c9530b120927
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401299Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#805365}

The preview photo is fetched and shown async, the img element on the
settings page is broken for a while before the image is downloaded.

This patch hides the img and shows it when the url is not empty.

Bug: b/166816130
Test: added new js test
Change-Id: I5ccc563dcc3f22c836a2fc35e7fa0e007ace846f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383262
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805364}

An SVG foreignObject element currently always forces legacy layout [1].
Additionally, when such an element has visible overflow,
DefinitelyNewFormattingContext returns a false negative, causing all
the siblings of the SVG root to also fallback to legacy layout.
However, SVG foreignObject elements always establish a new formatting
context since they are treated as absolutely-positioned [2]. This CL
fixes the bug by making DefinitelyNewFormattingContext always return
true for an SVG foreignObject element.

The fix is verified using a MathML test copied from integration-4.html,
the one used for MathML-in-foreignObject support [1], with the
assumption that MathML will never be implemented for legacy layout.

Bug: 989920, 6606

[1] crbug.com/989916
[2] https://svgwg.org/svg2-draft/embedded.html#Placement

Change-Id: I7f7cde90da728f1b1959728d39fed2e2070888f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400378Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#805363}

TBR=govind@chromium.org

Change-Id: I34fb393ae9dd8b9baaa19ebd5078be90521e9d85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401401Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805362}

This reverts commit 33cd6ce1.

Reason: Obtained crash reports from wild so no longer needed.

Original description:
> Add a DumpWithoutCrashing to header sender
>
> Add a DumpWithoutCrashing to the sender side of
> URLLoaderFactory.CreateLoaderAndStart.
>
> Bug: 1028189
> Change-Id: I05fcf83ebe3248b4b67c60d0ecb5c176173ad976
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358478
> Commit-Queue: Bo <boliu@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798660}

Bug: 1028189
Bug: 1125081
Change-Id: I8729d0f68c9e7ede31e00e2a7ef9c0ac07dbd877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401218Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805361}

This change consolidates the storage related methods in the
WebContentSettingsClient interface into two new methods to prevent
use of repeated logic in implementations.

Implementations and usage sites have also been updated to use the new
methods, RequestStorageAccess and RequestStorageAccessSync.

Change-Id: If46b3d0ca7555b8db212b014580f0b5513bbe508
Bug: 1019415
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353552
Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805360}

https://chromium.googlesource.com/catapult.git/+log/dc9083e4831f..6acdaf066c12

2020-09-09 mheikal@chromium.org Improve AdbWrapper#is_emulator to use device codename vs serial

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC rmhasan@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:11249650
Tbr: rmhasan@google.com
Change-Id: I54ff4cc762cc377c12d3a6a7a73d506dffb50304
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401598Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#805359}

Bug: None
Change-Id: I889d9ebbe9d8e5b33750bb1c12ae6121b14899bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398970Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805358}

Instead of relying on SceneState order calls, which cannot be
guaranteed, a new AppState shouldShowDefaultBrowserPromo property is
added to keep track of when a resumption of session is due to a cold
start.

A new DefaultBrowserSceneAgent class will listen to SceneActivationLevel
and check the shouldShowDefaultBrowserPromo property to determine
when to show the promo.

Also, an iOS14 check is added to IsLikelyInterestedDefaultBrowserUser to
ensure that only users on iOS14 see this promo.

Bug: 1107489
Change-Id: I71c77a98e20644c620f4c4d3c60cb0b253931cc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378710
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805357}

This patch removes the viewport type check for the TopToolbarOverlay
in place of checking specific layouts. The format in this patch is
much closer to what we want longer-term, especially with the
deprecation of the ViewportMode concept.

Bug: 1100332
Change-Id: Ief878a1c3b5b499cd411ab979d748cfd1477297a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350391
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805356}

The time has come.

Bug: None
Change-Id: Ied2bb8875c2451f72704a121c5cfcea601b85d3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399433Reviewed-by: Haiyang Pan <hypan@google.com>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805355}