- 19 Jul, 2018 40 commits
-
-
Dominic Mazzoni authored
The flakiness was all due to the main browser window not being consistently 800 x 600. This was affecting any accessibility test that was asserting anything about the clipped bounding box of a node with a y-coordinate greater than 600, for example. The solution is to make the dimensions of things a bit smaller so tests aren't more than 600 pixels tall, and to tighten up the expectations so we aren't relying on anything that might flake. TBR=katie@chromium.org Bug: 856566 Change-Id: I391a880c476d3570a97aef1732cd5f2c6de422e4 Reviewed-on: https://chromium-review.googlesource.com/1142532Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#576397}
-
Koji Ishii authored
Currently, there is no active plans to enable this runtime flag. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9c1744cb5bcf14709f0f3228739e58439367b7ac Reviewed-on: https://chromium-review.googlesource.com/1143091 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576396}
-
Timothy Loh authored
Bug: 822464 Change-Id: I61fa85818c016f1839e1f6875367da4f8fc25d06 Reviewed-on: https://chromium-review.googlesource.com/1143084Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#576395}
-
sczs authored
As per UX request, this is being moved to a tableView footer instead of the cell itself. Screenshot: https://drive.google.com/open?id=1zK2X9e-__l3CurjcB7Z3zgUIxTgSxXuJ Bug: 843827 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I977a625d10c108efa4f0794a2aafd77a32b8e495 Reviewed-on: https://chromium-review.googlesource.com/1142527Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576394}
-
Karan Bhatia authored
This CL updates the UI for extension icons in the browser toolbar that have had actions blocked on a page. For such extension icons, a white circular badge is shown behind the extension icon with surrounding shadows. This removes the ToolbarActionButtonState enum added in r558481 and the associated plumbing. This is an artifact of the fact that the the extension icon UI does not depend on the button state now. BUG=834494, 859108 Change-Id: I9da8963451ad4f7e09e539d57b96d9d3591d0ba5 Reviewed-on: https://chromium-review.googlesource.com/1141352 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576393}
-
Yutaka Hirano authored
This CL adds --disable-web-security support to CORSURLLoader. This CL also removes layout tests because with out-of-blink CORS it's not testable. Instead, this CL adds some browser tests to verify the behavior. Bug: 736308 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I609f08e2613f0d4a3c9dc5cc87c236ba15189968 Reviewed-on: https://chromium-review.googlesource.com/1131045 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#576392}
-
Matt Falkenhagen authored
The mojom only has the ServiceWorkerDispatcherHost interface now, which is about service worker providers. Preparation for moving service_worker_event_dispatcher.mojom to service_worker.mojom. This might make the git history more sensible. Bug: 629701 Change-Id: I89693e40ad0d4c259233fb2b805519f432b483ec Reviewed-on: https://chromium-review.googlesource.com/1142860Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#576391}
-
Kenichi Ishibashi authored
As a comment in ServiceWorkerMetrics::RecordActivatedWorkerPreparationForMainFrame() says[1], we don't record .Time histograms. Skip checks for these histograms when S13nServiceWorker is enabled. [1] https://cs.chromium.org/chromium/src/content/browser/service_worker/service_worker_metrics.cc?l=508&rcl=c796dbc93b6490e94e9b843b1e0ecee3e115d2a3 Bug: 860361 Change-Id: Id0d153eab1e7c7a7102c01bf1945f4b8536b2d9f Reviewed-on: https://chromium-review.googlesource.com/1143047Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576390}
-
Kenichi Ishibashi authored
We should just do early return when S13nServiceWorker is on because we want to make the flag on by default in the future. Bug: 860361 Change-Id: I241b491f7f49e47b7cbfa5bfaeb1fab1978442db Reviewed-on: https://chromium-review.googlesource.com/1143050Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576389}
-
Yutaka Hirano authored
TBR=sky@chromium.org Bug: 865316 Change-Id: I4bca244d7af328583d05a3bb9190bd727ab3d7a8 Reviewed-on: https://chromium-review.googlesource.com/1143054 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#576388}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f9afc77f283e..2c984a03caff git log f9afc77f283e..2c984a03caff --date=short --no-merges --format='%ad %ae %s' 2018-07-18 jbudorick@chromium.org Revert "Reland "gclient_scm: Use cherry-picking instead of rebasing."" Created with: gclient setdep -r src/third_party/depot_tools@2c984a03caff The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:850812 TBR=agable@chromium.org Change-Id: Iacf78e5c12e463e78c44876e6e8a98c41a362b96 Reviewed-on: https://chromium-review.googlesource.com/1142174Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576387}
-
George Burgess IV authored
We have an old profile hanging out in Android checkouts from before the days of autorolling them directly into Chromium. It's not breaking anything, but since it shows up in git status and is otherwise unused... Bug: 864893 Test: rm chrome-profile-3309-text.prof && gclient sync. Profile's gone. Change-Id: Iff487de8a9710ca9c87099df6bdebb1076db8429 Reviewed-on: https://chromium-review.googlesource.com/1142505Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#576386}
-
Timothy Loh authored
This patch adds support for app icons when used as file handlers in the file manager. As there is no place to store the CrostiniAppIcon objects, a IconLoadWaiter is added which manually manages it's lifetime and deletes itself after an icon is loaded (or fails to load). BUG=822513 Change-Id: Ia31b32806e399df8902ffbf5c953e39dbc414774 Reviewed-on: https://chromium-review.googlesource.com/1127204Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#576385}
-
Oksana Zhuravlova authored
Since platform_event_observers_ is unused, this change removes it and related code. Bug: 855308 Change-Id: I717d8d3676dd4788e2dc27cc2f8d757fac591648 Reviewed-on: https://chromium-review.googlesource.com/1137151 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#576384}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2c1fd401..6014ce84 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7ea4eab0d59e59a5f13ba0fa04f9c1784de13092 Reviewed-on: https://chromium-review.googlesource.com/1142688Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576383}
-
Tatsuhisa Yamaguchi authored
Before this change the bubble was shown above the system tray icons even when the shelf position was left or right. Bug: 864929 Test: manual Change-Id: I8258705be68a85af32aa7d46943ef32a46ee8c9a Reviewed-on: https://chromium-review.googlesource.com/1141750Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576382}
-
Yutaka Hirano authored
This CL consists of several parts: - Move mojo::Binding from network::URLLoaderFactory to network::CORSURLLoaderFactory: Now CORSURLLoaderFactory is the implementation of network::URLLoaderFactory returned from NetworkContext::CreateURLLoaderFactory, so this CL moves the binding logic to CORSURLLoader. - Loosen the redirect mode check in CORSURLLoader: Some requests with kNavigate mode and kManual redirect mode calls FollowRedirect. It seems a reasonable usage, so CORSURLLoader now allows that. - Add virtual/outofblink-cors-ns: From some infrastructure issues we cannot test out-of-blink CORS with Network Service, with virtual/outofblink-cors on linux-mojo. This CL explicitly adds one more virtual test suite instead. Bug: 736308, 862184 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: If5db2725b2c5af83a2f1c1481c612bcb4ea75567 Reviewed-on: https://chromium-review.googlesource.com/1134926 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#576381}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/26d6aff1b57b..c3318d5f367c git log 26d6aff1b57b..c3318d5f367c --date=short --no-merges --format='%ad %ae %s' 2018-07-19 dtu@chromium.org [pinpoint] Fix WebView for reals. Created with: gclient setdep -r src/third_party/catapult@c3318d5f367c The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9ed416b06375a3327b3e0b5c875bb57f72853eda Reviewed-on: https://chromium-review.googlesource.com/1142804Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576380}
-
Koji Ishii authored
Images match, and text dumps match after normalizations: svg/as-border-image/svg-as-border-image-2.html svg/as-border-image/svg-as-border-image.html Images match, and text dump diffs are intentional: fast/box-shadow/basic-shadows.html fast/forms/form-hides-table.html fast/forms/search/search-appearance-basic.html fast/forms/select/select-initial-position.html fast/frames/iframe-with-frameborder.html fast/parser/001.html From manual review of build 8093. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If0df956ec2508d4c710247c8caaff20e898a86bf Reviewed-on: https://chromium-review.googlesource.com/1143045 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576379}
-
Thomas Guilbert authored
HLS manifests can request segments from a different origin than the original manifest's origin. We do not inspect HLS manifests within Chromium, and instead delegate to Android's MediaPlayer. This means we need to be conservative, and always assume segments might come from a different origin. HasSingleSecurityOrigin should always return false when decoding HLS. Bug: 864283 Change-Id: Ie16849ac6f29ae7eaa9caf342ad0509a226228ef Reviewed-on: https://chromium-review.googlesource.com/1142691Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#576378}
-
Tatsuhisa Yamaguchi authored
Test: ash_unittests --gtest_filter=TrayInfoLabelTest* Bug: 862116 Change-Id: Ifbedc4d656b1e5421f8a2b546d528378e56c6fc6 Reviewed-on: https://chromium-review.googlesource.com/1140019Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576377}
-
Jochen Eisinger authored
BUG=831073 R=qinmin@chromium.org,clamy@chromium.org Change-Id: I1c07cd89e06a8b15272ff862d237da5527288b7a Reviewed-on: https://chromium-review.googlesource.com/1138081Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576376}
-
Ramin Halavati authored
Clear browsing data preferences (browsing_data::prefs::*) are removed from incognito whitelist for persistent storage. The browsing_data preferences are used by Clear Browsing Data, which is only available in regular mode. Bug: 861722 Change-Id: I7835f8b1ad2a8b4a8b7bb72b99401b281823f313 Reviewed-on: https://chromium-review.googlesource.com/1141565 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#576375}
-
Livvie Lin authored
This deletes code that references kRevertCertificateErrorDecisionsFieldTrialName, the experiment for clearing certificate exception decisions at the end of a session. This includes deleting all code for FORGET_SSL_EXCEPTION_DECISIONS_AT_SESSION_END since we decided to launch REMEMBER_SSL_EXCEPTION_DECISIONS_FOR_DELTA. Bug: 840045 Change-Id: I6ea2606a64c907e52215e20dc820b481ef28c114 Reviewed-on: https://chromium-review.googlesource.com/1142567 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Cr-Commit-Position: refs/heads/master@{#576374}
-
Tetsui Ohkubo authored
This CL stops showing slider bubble when main bubble is shown on any display. TEST=manual BUG=852866 Change-Id: I18e80b9ba480e88dd08bb10fe1b92adbeace7582 Reviewed-on: https://chromium-review.googlesource.com/1141556 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#576373}
-
John Z Wu authored
//ios/web_view does not need to mirror accounts. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I100f3005dd3d02dd03c5f8e730e4ce3daa492d62 Reviewed-on: https://chromium-review.googlesource.com/1142543Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#576372}
-
Kunihiko Sakamoto authored
Spec side change: https://github.com/WICG/webpackage/pull/261 Bug: 803774 Change-Id: I0d0aa289b6f991b3cb09b2f53f6b1fbf752d2bbd Reviewed-on: https://chromium-review.googlesource.com/1142846Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#576371}
-
CJ DiMeglio authored
These calls were accidently misordered. |compositor_frame_sink_| needs to stick around for the completion of resource_provider_->OnContextLost(), as it uses the |compositor_frame_sink_| for DidDeleteSharedBitmap. TBR=junov@chromium.org Bug: 864657 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I24ace6f8766a2c4d9c77b359d61c4c4531b9b14e Reviewed-on: https://chromium-review.googlesource.com/1142827Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#576370}
-
sawtelle authored
This change addresses crbug 856251 and allows for strings to be passed through the call stack when a custom control is clicked. Currently this is not being used, but in the future this plumbing will be connected to developer-defined custom controls that have unique ids. Bug: 856251 Change-Id: Ie8305104d677afcccf3223a1fabb94a9f376710e Reviewed-on: https://chromium-review.googlesource.com/1119082 Commit-Queue: Steven Sawtelle <sawtelle@google.com> Reviewed-by:
apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Chrome Cunningham (In Paris) <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#576369}
-
Christopher Lam authored
See go/closure-compile-gn for details. This CL removes all remaining traces of GYP Closure Compilation. This includes: - all compiled_resources2.gyp files from ui/webui - all PRESUBMITs that add the closure_compilation bot - the closure_compilation bot in all build systems - some GYP tooling that is only used for closure compilation builders TBR=sashab@chromium.org Bug: 632206 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ief58c91d43ed859d5b4022dd30e7d5507dd7909b Reviewed-on: https://chromium-review.googlesource.com/1051144 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#576368}
-
Jialiu Lin authored
When Chrome gets password protection verdicts from Safe Browsing, we'd like to log the referrer chain size by verdict type. Bug: 864608 Change-Id: If11cd732c6c45865a64bfbbccf71af4615b148f9 Reviewed-on: https://chromium-review.googlesource.com/1141179 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#576367}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8364706c02c6..b423247bc239 git log 8364706c02c6..b423247bc239 --date=short --no-merges --format='%ad %ae %s' 2018-07-18 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-18 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-07-18 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-18 bungeman@google.com Revert "Reland "Add some optimizations to PolyUtils"" 2018-07-18 bungeman@google.com Revert "Add kAAHairline to GpuPathRenderers" 2018-07-18 herb@google.com Redo drawTextRSXForm for glyph runs Created with: gclient setdep -r src/third_party/skia@b423247bc239 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Icb0154d88fbbf49e2a373da2a1328276c4b344dc Reviewed-on: https://chromium-review.googlesource.com/1142904Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576366}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/664261cb3f4d..bb5cc39baf68 Created with: gclient setdep -r src-internal@bb5cc39baf68 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:859120 TBR=mmoss@chromium.org Change-Id: Ie91bd8caf414aa42df3c8e99c72e3926da3af62f Reviewed-on: https://chromium-review.googlesource.com/1142017Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576365}
-
Timothy Loh authored
This CL adds basic support for installing .deb files from within the file manager. An "Install with Linux (Beta)" task is added for .deb files, which will open a confirmation dialog when selected. A future CL will expand this dialog to retrieve and display detailed information about the package, such as name, version, and a description. For successfully started installations, progress will be displayed in a notification (similar to e.g. file downloads). This patch only adds the file handler to .deb files that are selected individually and already in the container. In a subsequent patch, we should expand this so we can show an appropriate error message when selecting multiple .deb files, or files outside the container. TBR=benwells Bug: 822464 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1cfb84491134e0911ad53a488a02a7479d78d299 Reviewed-on: https://chromium-review.googlesource.com/1126812 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#576364}
-
Takayoshi Kochi authored
Remove myself from script WATCHLISTS. TBR=kouhei@chromium.org NOTRY=true Change-Id: I64ce436981cbf3c3882dc4207d286b27d00534f1 Reviewed-on: https://chromium-review.googlesource.com/1142859Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576363}
-
Sasha Morrissey authored
Hide the modified date for Team Drives, since it's always set to 1st Jan 1970. In a later patch, we will update it to the correct date. Bug: 861622 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7be57d16fedf62c07cb0eb7bf3e2e32cf01ccaf6 Reviewed-on: https://chromium-review.googlesource.com/1141459 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#576362}
-
Yutaka Hirano authored
Tbr: mlamouri@chromium.org No-Try: true Bug: 865262 Change-Id: I8b4e49744783c45c84a80fe1560e4e21133f4d0e Reviewed-on: https://chromium-review.googlesource.com/1142858Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#576361}
-
Sergey Ulanov authored
Previously headless ozone platform was used on Fuchsia. Switched it to scenic. content_unittests fail with scenic, so this change also adds --ozone-platforms=headless flag in the unittests, until this issue is resolved. Bug: 829980, 865172 Change-Id: I8a0b282953cf90554dc78ed1575d927b53374c58 Reviewed-on: https://chromium-review.googlesource.com/1142492Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#576360}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bf7e4982. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21542 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy TBR=foolip No-Export: true Change-Id: I1ca56fbb3904ee198c0b969f1187ddbcc145cb8b Reviewed-on: https://chromium-review.googlesource.com/1142744 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#576359}
-
Peter Boström authored
Instantly hides or shows the IconLabelBubbleView separator when focus rings are available to prevent showing the separator when a focus ring overlaps it. Bug: chromium:865029 Change-Id: I21a4c296c1da06b81dc91d66101d46e8ad52ad99 Reviewed-on: https://chromium-review.googlesource.com/1142442 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#576358}
-