- 17 Aug, 2020 40 commits
-
-
Andre Le authored
Screenshots: https://screenshot.googleplex.com/3eeab29d-1b19-4345-a222-42703cee174b https://screenshot.googleplex.com/567b0132-f7a6-4a59-8c61-3a9a7d6cbba1 https://screenshot.googleplex.com/dfb161aa-99c4-4ac4-9fbd-b06c4d01e50e https://screenshot.googleplex.com/95a48208-ffc9-4f43-8993-1f0425b884bb BUG=1114949 Change-Id: I326e13b202b315ca8548bda03acb4a9ff53577de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353174Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#798885}
-
Brian Malcolm authored
BUG=chromium:1105185 Change-Id: Ia6a7d87f4151b259552e609bc5c4c46f4470037e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355001Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#798884}
-
Aaron Colwell authored
Adding more logging information to make it easier to determine why the RenderProcessHostImpl is still alive. All the new values are related to the various early return paths in RPHI::Cleanup() that cause destruction to get deferred. Bug: 1113159 Change-Id: I6dbf6966ca91681aed0c853605f1be9d736b80a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360473 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#798883}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/22e7f7a0d7d7..f926b0866fe4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5d81573e79447a05bd05b0236741a712f85bef01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360337Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798882}
-
Michael Bai authored
- This will give the consumer the ability to discard the old content ASAP. - Also change the test to make it pass on BFCache feature. Bug: 1115234 Change-Id: Ib41f5642018e6e11c919100b29bf7fb10e2f91b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350126Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#798881}
-
Nigel Tao authored
Change-Id: Ibcb2d27f41d129fafaeec8509a7c53d44180c1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359653Reviewed-by:
Leon Scroggins <scroggo@google.com> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#798880}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/699711c7e3cd..f926b0866fe4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idb41e200c262b4ddcc84dddd83871597853206e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358601Reviewed-by:
-
Fred Mello authored
https://docs.google.com/document/d/1gpfB_4Ars3BflCquzXQ3eYL8UEShTPTw4CJ6DNEgGoI Bug: 1112872 Change-Id: I6db23b082c05b83b43a7b9b47ed2f98dabc76200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359563 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#798878}
-
Mehrdad Hessar authored
Bug: 1116626 Change-Id: I3b0542f0b9a670c797e6e61329864f2fb9a8abff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358059Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Mehrdad Hessar <mehrdadh@google.com> Cr-Commit-Position: refs/heads/master@{#798877}
-
Liquan (Max) Gu authored
Change: * Add null-check for PRImpl's "WebContentsStatics.fromRenderFrameHost(renderFrameHost)". And move it to CPRImpl. * JourneyLogger's instantiation is moved from PRImpl's construction to before CPRImpl's construction. Moving it earlier is because JourneyLogger's role includes logging the error before CPRImpl's construction. * BrowserPaymentRequest's creation is no longer done in CPRImpl's construction. This is because BrowserPaymentRequest's constructor calls CPRImpl which is still partially initiated. * The null-checks of client, methodData, details are moved from CPRImpl#initAndValidate() to CPRImpl#createIfParamsValid(), because we don't bother to create CPRImpl if render data is invalid. Acronym: CPRImpl = ComponentPaymentRequestImpl PRImpl = PaymentRequestImpl Bug: 1102522 Change-Id: I0faf70fe6a73b13858b30d1dadb30cf25857eda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357090 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#798876}
-
Dominic Farolino authored
R=asvitkine@chromium.org, jbroman@chromium.org Bug: 1053702 Change-Id: Ibe268bd3930582fa1a366419806e71bf87ef9cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360550 Commit-Queue: Dominic Farolino <dom@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Dominic Farolino <dom@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#798875}
-
Dana Fried authored
Chrome now has a visible caption bar in tablet mode above the toolbar/ tabstrip that behaves like most other Windows apps (explorer, console, etc.) When maximized in non-split-screen mode: - Caption bar is thin. - Restore caption button is present but disabled (greyed out, won't highlight). Note that this is an improvement on Windows apps which display a non-disabled button that doesn't do anything. - User can pull down on the caption bar to move the window and go into split-screen mode. When in split-screen mode: - Caption bar and buttons are default size. - Maximize caption button is present but disabled (see note above). - User can pull down on the caption bar to move the window in and out of split-screen mode, etc. This change also makes it much easier for users to generate touch gestures that clearly show intent to either move the window or open the tabstrip shade, by dragging on the caption bar vs. the toolbar. The general accuracy of drag/swipe gestures on the toolbar seems to be very much improved by this change. Known issue: when in split-screen Windows sometimes (but not always) cuts off the top few pixels of a window. This happens to native/first- party Windows apps the same as Chrome, so is not a Chrome bug, and because it is intermittent we can't compensate for it except to use a taller caption bar in this mode (which is also consistent with other Windows first-party applications). Note: the ability of the caption button container to be torn out and moved to the tabstrip container, which was previously required in order for us to hide the caption buttons and show them when the tabstrip tray was opened, will be removed in a follow-up CL. Bug: 1116651 Change-Id: I09ca9381f2add1198a680d9ef6f45cedd7916bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358249Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#798874}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3f714d9026a2..03f545114e8e 2020-08-17 wenbinzhang@google.com [benchmarking] Fit GetPcSystemType for win platform backend If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1114681,chromium:1115156 Tbr: rmhasan@google.com Change-Id: I2938f283fce864de2969b51394cc38d874060c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360226Reviewed-by:
-
Andrew Comminos authored
To prevent attributing events to subframes with |pointer-events: none|, avoid setting this on layers generated from the subframe. Replaces frame_element_id with visible_frame_element_id. Bug: 910421 Change-Id: If0f709b210781c13444b71937d2b6225b3494d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353545 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#798872}
-
Dan Harrington authored
Scroll restore didn't work when: - the feed is being restored in async, so scrolling must happen later, - And the item at the top of the NTP was a header, present before the feed is loaded. This CL stores the last visible item index in the scroll state, and waits until the right number of items are added to the recycler adapter. Bug: 1115488 Change-Id: Iac489572da73659261231a002e2c2a66591234af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360311Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Auto-Submit: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#798871}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c8ac35879c9d..2549f174b533 2020-08-17 danilchap@webrtc.org Remove RTPFragmentationHeader creation and propagation through webrtc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ieac912a0f4401836f2118735f0879e2dff7d5dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359286Reviewed-by:
-
Jinsuk Kim authored
This CL lets RootUiCoordinator create and provide BrowserControlsManager to other classes. Chrome*Activity still has #getBrowserControlsManager which now just defers the call to RootUiCoordinator. This makes |createComponent| and |createRootUiCoordinator| in ChromeActivity#performPreInflationStartup form dependencies on each other for CCT/Webapp. This was broken by creating RootUiCoordinator first and having some components be passed to it as a supplier instead. Bug: 966272 Change-Id: Ic89fdb77d0886d448033599c9e20128c96f071c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327351 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#798869}
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1045266 Change-Id: Ie8faf5986af1f0564f20cf5aa5b8cc6beea9a135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358597Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#798868}
-
Thomas Anderson authored
This reverts commit 065ade05. Reason for revert: Suspected cause of All/OobeInteractiveUITest.SimpleEndToEnd/9 failure on Builder linux-chromeos-rel Build 40523: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/40523 Original change's description: > Reland "LoginScreen: Show TPM lock status." > > This is a reland of 67a4df6f > CL was reverted cause of failing > chromeos-betty-pi-arc-cfi-thin-lto-chrome due to reaching deadline > on one of the tests. This is gonna be fixed by increasing time limit. > See details here: https://crbug.com/1116379 > > Original change's description: > > LoginScreen: Show TPM lock status. > > > > If TPM is locked show banner with steps on how to fix this issue. > > > > Bug: 1114656 > > Change-Id: I85dab0f4ce003ac3dad61c318efb3333457993ac > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346266 > > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > > Cr-Commit-Position: refs/heads/master@{#797992} > > Bug: 1114656 > Change-Id: Iba50daf1d1b892539e00d9be04fc2b8c0a5a279e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359992 > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > Cr-Commit-Position: refs/heads/master@{#798698} TBR=tbarzic@chromium.org,antrim@chromium.org,raleksandrov@google.com Change-Id: I55fca0fb2f7fdbdacf1de9d7122571a888b89d11 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358906 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#798867}
-
Thomas Anderson authored
This reverts commit 5e960b15. Reason for revert: Nothing actually wrong with this CL! But we need to revert a separate CL (https://chromium-review.googlesource.com/c/chromium/src/+/2358906) and this CL introduced merge conflicts. Sorry for creating extra work for the reland :( Original change's description: > CrOS - Login Screen - Minor cleanup > > Rename AnimationState to UiState and use it to determine the > visibility of elements. Remove multiple variables in favor of > UiState. > > Bug: 1075994 > Change-Id: I0d7413fb173dadbff22cde0eb3af6f43586bdee2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352883 > Commit-Queue: Renato Silva <rrsilva@google.com> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798780} TBR=antrim@chromium.org,raleksandrov@google.com,tellier@google.com,rrsilva@google.com Change-Id: Id0637f3c2491612b22a7630194a1377d9e4b7b34 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1075994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360699Reviewed-by:
-
Hui Yingst authored
Add message handler HandleSaveAttachmentMessage() for downloading PDF attachments. As the caller of PDFiumEngine::GetAttachmentData(), HandleSaveAttachmentMessage() validates the attachment's index, readability and whether the size is non-zero before calling, and checks whether the returned attachment's size matches the stored attachment size in |doc_attachment_info_list_|. After calling GetAttachmentData() to fetch the attachment's data, HandleSaveAttachmentMessage() posts a reply to save the data to disk. Bug: 177188 Change-Id: I34ad386447cdcb4025d0f545e4ff8b9d3b818659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295998 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798865}
-
Josh Simmons authored
Two unit tests were still calling the (removed) set_uri() method instead of the (new) SetUri() method. Updated the tests. Bug: 1113983 Test: autoninja -C out_${BOARD}/Release unit_tests builds without errors Change-Id: Ibd45ff3729d3b5a076913ccd7408402154785d7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342424Reviewed-by:Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Piotr Pawliczek <pawliczek@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#798864}
-
Becca Hughes authored
Adds a dedicated KaleidoscopeNTPDataProvider that provides the methods that are needed by the NTP. BUG=1114862 Change-Id: I29c182f5c032f8dc0553bbe14b405f228942d3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357521Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#798863}
-
Michael Thiessen authored
Introduce CriteriaHelper#pollUiThreadNested This change adds an assertion that pollUiThread is not called from the UI thread, which is equivalent to calling sleep(), and won't actually run any UI thread tasks. In the few cases where polling the UI Thread from the UI thread is necessary, I introduce CriteriaHelper#pollUiThreadNested, which nests the looper in order to continue running UI tasks. Bug: 1115220 Change-Id: I9338a607590e8ee0a22bc32477f02867c6e37271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357289Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#798862}
-
John Williams authored
Bug: b/161367720 Change-Id: If21e72031c20b6e5da11fc477cf108145776a5d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346970Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#798861}
-
Sahel Sharify authored
Attempting to show an error message in payment request dialog view after PaymentRequestDialogView::OnDialogClosed() call causes a crash. This is because PaymentRequestDialogView::ShowErrorMessage() creates an error view and adds it to the view stack[1] while the stack view gets destroyed upon PaymentRequestDialogView::OnDialogClosed() call. [1]https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/views/payments/payment_request_dialog_view.cc;l=123 This cl fixes the crash by early-returning from PaymentRequestDialogView::ShowErrorMessage() when the dialog is getting closed (i.e after PaymentRequestDialogView::OnDialogClosed() has been called.) The screencast of the fix is already attached to the bug. Bug: 1114556 Change-Id: I10d9478a83913a167e52ed558a6a09cf18fcd6e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359562Reviewed-by:
-
rbpotter authored
Add document outline view by porting the bookmarks list to the sidenav from the viewer toolbar. Bug: 1116574 Change-Id: I571dc8e6f6f7288debff5a9abcdc4e2f93877366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357673 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#798859}
-
Vikas Soni authored
Add about:flags to enable/disable AImageReader. This will help in debug on production builds. Bug: 1114874 Change-Id: Ib6216e4b594f59a46890f43640a25154711da351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360113 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#798858}
-
Mark Mentovai authored
New packages are provided for both Xcode 11.2.1 11B53 and 12b4 12A8179i, identical to the old packages with the inclusion of atos after 955c73fb. Bug: 1113466 Change-Id: If8c18cc0881526d006cad35a6f45f2aa2af2d611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360324 Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#798857}
-
Owen Min authored
The CommandLinePolicyProvider will be addded on Android device for Canary, Dev amd trunk channel. Unless the CommandLineOnNonRooted feature is enabled. Test locally with following command: out/Release/bin/chrome_apk run --args='--policy="{\"BrowserSignin\":0}"' And here is the screenshot of chrome://policy page: https://drive.google.com/file/d/1wp2nlPpgbMrOWFXigqYjgshjH5E7ZrrT/view?usp=sharing Bug: 1113792 Change-Id: I11f5d00a68a2f2a852eff1dc02ed6d1e653ff506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357459 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#798856}
-
Eric Robinson authored
We had previously found it beneficial to record CPU metrics for a frame only when it was in the foreground because we were concerned with the percent of CPU usage by the frame at it's more impactful time (frames in the background have their task queues slowed/stopped). However, we now instead use a metric that measures the peak windowed usage rather than the percentage of usage overall, so it's no longer critical to distinguish between foreground/background times. In addition, not measuring while in the background leads to us missing potential spiking CPU usage of frames there. This CL removes the foreground/background distinction, ensuring our metrics are recorded for the total time of the frame independent of its background status. Note: This change will affect heavy ad intervention behavior. This is desirable, as ignoring work that an ad does in the background is a potential way to circumvent this intervention, and most frames, while backgrounded, should be doing less anyway. Bug: 1103699 Change-Id: If34be823bb5501574df0f4142db284e6499151e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310130 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
-
Sven Zheng authored
In order to get interactive_ui_tests run on CI/CQ, we need to disable failing tests first, then run them. Bug: 1111979 Change-Id: If90cf564f5647189b2154ebfbdc2ad6ff570e473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360321Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798854}
-
Thomas Anderson authored
This reverts commit 30d9990c. Reason for revert: Suspected cause of build failure on ilder Deterministic Linux (dbg) Build 18293: https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux%20%28dbg%29/18293?blamelist=1#blamelist-tab Checking libblink_common.so difference: (10672 deps) obj/third_party/blink/common/common/document_policy_features.o Original change's description: > Add bool constructor with type for PolicyValue > > Previously, boolean PolicyValue is missing a constructor with type > specification on PolicyValue class. It caused some inconvenience > on code generation and testing. With the introduction of enum > PolicyValue, this becomes more obvious because enum type's constructor > also comes with a type parameter. > > In order to simplify the codegen and testing logic, this CL adds a dummy > constructor for boolean type PolicyValue. > > Note: the constructor with type parameter aims to distinguish policy > values that have same C++ type representation but different policy value > type, e.g. IncDouble and DecDouble, Enum and Int. > > Change-Id: I11ba793c73a770d7211e21c6a94d29f5557ac284 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347365 > Commit-Queue: Charlie Hu <chenleihu@google.com> > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798714} TBR=iclelland@chromium.org,foolip@chromium.org,chenleihu@google.com Change-Id: I79f53710b14f22a7c81b4c757cbee03160c6addb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360796Reviewed-by:
-
Yuheng Huang authored
Since WebContentsImpl::DidStartLoading/DidStopLoading is already sending NotifyNavigationStateChanged(INVALIDATE_TYPE_LOAD) by way of LoadingStateChanged, it's no longer necessary to send this out in WebContentsImpl::LoadStateChanged. This change can reduce the number of call of TabStripModelObserver.TabChangedAt with TabChangeType.kAll a lot to increase performance throughout the browser Bug: 1112496 Change-Id: I96d8942d7e1ebd5ffc8b3f3389497936f62848c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357960 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#798852}
-
Mohamed Heikal authored
These should be the only remaining instances of R.java generated by an android_resources target instead of the android_library target (in src/ there are others in other repos). TBR=What should just be a mechanical change. Bug: 1073476 Change-Id: Ia61ff2985a7db20f11a546bb76194bd796aec00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357636 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#798851}
-
Owen Min authored
Create the provider and link it to the PolicyConnector. Also make few changes in the Loader class: 1) It no longer inherits from ASyncPolicyLoader as the loader process is sync. 2) Add few debug information in case the JSON input is not valid. The provider is not disabled globally. There will be one last CL to enable the provider on Android. Bug: 1113792 Change-Id: Id32ec74ebfa259777f718bf06b7a4cb307498f2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355134Reviewed-by:
Yann Dago <ydago@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#798850}
-
Fred Mello authored
https://docs.google.com/document/d/108ekdmEDMwpGDQLRnWGZBcq1cxsyPQLXuFl4oj6OIfw Bug: 1112872 Change-Id: Ic92d02154f4a01c5f72a65e1585f4558b84436ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360569 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#798849}
-
Maks Orlovich authored
Eviction.*: kept as lower traffic, and we just fixed a major issue with eviction heuristics metrics DiskOpenStream2TinyLatency, DiskOpenStream2NonTinyLatency: removed, not interestng with CodeCache being a thing other Disk*Latency: kept, important performance metrics. pretty heavy, though. (Why is there a regression in July?) indicates unusual case HeaderSize: kept as there are deep assumptions on magnitude of this EntryOpenedAndStream2Removed: removed, not very interesting EntryCreationTime: kept, really important for performance EntryCreationResult: removed, can use comparable Disk*Result CreationToIndex: kept, highly relevant for CacheStorage. CheckCRCResult: stream reading state is interesting FileDescriptorLimiterAction: keep, low traffic and Fixed: 1089899, 1089898, 1089897 Fixed: 1089908, 1089907, 1089906 Fixed: 1089911, 1089910, 1089909 Fixed: 1089920, 1089919, 1089918 Fixed: 1089917, 1089916, 1089915 Fixed: 1089519 Change-Id: I6bf6c3a0d037a85afd8ee7cbc7810f1f4f00b615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359556Reviewed-by:Ben Kelly <wanderview@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#798848}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a866c351. With Chromium commits locally applied on WPT: 22d98b41 "Make canvas-createImageBitmap-e_srgb.html run cross-browser" 07bc7b3c "[WPT] Refactor WebBluetooth tests to use test-only-api.js" d2294de0 "Do not create a stacking context for CSS clip" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I9bfd8e8bce32f8a8ab6cec32e9b40e7f8038cfbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358588Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798847}
-
Justin DeWitt authored
This contains information required for new Java 8 desugaring features. The reland was fixed in patchset 2: adding a special case not to check bytecode for this new jar. Tbr: wnwen@chromium.org, agrieve@chromium.org, yfriedman@chromium.org Bug: 105675 Change-Id: Idd381efe4fc017944d3be33a01d5ec9c47b72420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359153 Auto-Submit: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
-
