- 15 Jan, 2021 40 commits
-
-
Sami Kyostila authored
Chrome is about to switch to the TRACE_EVENT macro implementation provided by Perfetto. The new implementation requires trace event statements to be terminated by semicolons, so this patch modifies the codebase to add semicolons where they were previously left out. No functional changes. Bug: 1006541 Change-Id: If9e1397a58ef93f8dfe6f9302a87420837758e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628300 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#844210}
-
Gordon Seto authored
Update 'Forward' button to have a dynamic label. Remove 'Done' and 'Skip Discovery' buttons and replace instances with 'Forward' button. Bug: 1093185 Change-Id: I08259968c5d9ea16e8bad17be12c8cc4be88c198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631226 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#844209}
-
Chrome Cunningham authored
This reverts commit 79de0d4b. Reason for revert: We expect another CL may be the correct fix. https://chromium-review.googlesource.com/c/chromium/src/+/2626920 Original change's description: > Defensive fix for crash in MediaWebContentsobserver > > This defensive fix until MediaSession owners return from vacation. > Reverting is challenging given the long string of CLs. > > GetMediaPlayerRemote(player_id) is crashing for failing to find the > remote with that ID. The stack shows the call coming from > MediaSessionController, which should have the same lifetime as its > associated mojo::Remote<media::mojom::MediaPlayer>. So far, I have not > found how those lifetimes are getting out of sync. > > Ownership looks like this (read -> as "owns", MWCO as MediaWebContentsObserver): > MWCO -> MediaSessionControllersManager -> map<MediaPlayerId, MediaSessionController(s)> > MWCO -> map<MediaPlayerId, mojo::Remote<media::mojom::MediaPlayer>> > > I've combed through all the places where MWCO removes from its map of > MediaPlayer remotes, and looked for a failure to call > MediaSessionControllersManger::OnEnd(Id) to remove the associated > MediaSessionController. There are 3 cases where we remove from the > map... > 1. MediaWebContentsObserver::RenderFrameDeleted() > 2. MediaWebContentsObserver::WebContentsDestroyed() > 3. media_player_remotes_[player_id].set_disconnect_handler(base::BindOnce(... > > The only case where I don't see a call to > MediaSessionControllersManager is #2. But that shouldn't matter since > MWCO's destructor is called shortly (synchronously) after > WebContentsDestroyed(). Its destructor will tear down the > MediaSessionControllersManager. > > The defensive fix does not address the root lifetime issue. It is > probably the case that the MediaSessionControllers are being leaked. > > Bug: 1161551, 1039252 > Change-Id: I85337eae106d8b56b7d48fc9759702dc579855ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607579 > Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> > Commit-Queue: Frank Liberato <liberato@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> > Cr-Commit-Position: refs/heads/master@{#839818} TBR=dcheng@chromium.org,mlamouri@chromium.org,chcunningham@chromium.org,liberato@chromium.org,beccahughes@chromium.org,mario@igalia.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1161551 Bug: 1039252 Change-Id: Id12ba170758a4479342c0eb3b2c64bb1243f34b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632919Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#844208}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/428143ee24c5..071c3b1b313a 2021-01-15 ehmaldonado@google.com owners: Support '*' when checking approval status. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1166467 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I1526069a2addedc8df032652c5fa454ad68e8cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633449Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844207}
-
Jeroen Dhollander authored
This CL migrates the implementation of |AudioInputProviderImpl| and |AudioInputImpl| to the new Libassistant mojom service. To reduce the size of the CL this migration has been split in 3 CLs: 1. The mojom APIs 2. The implementation on the Libassistant mojom service (this CL). 3. Changing the Browser side to use the new mojom service. This does mean that this CL has to copy |AudioInputImpl|, |AudioInputProviderImpl| and |AudioInputStream|, rather than move them. In a follow up CL these classes will be removed from //chromeos/services/assistant, when they are unused there. These classes are mostly unchanged, except: - Renamed |AudioStream| to |AudioInputStream|. - Replaced |AudioStreamFactoryDelegate| with |mojom::AudioStreamFactoryDelegate|. - Stripped support for the gn flag `enable_fake_assistant_microphone`, as that would have required some extra files to be moved (and this CL is big enough as-is). I will re-add this in a follow up CL. Note that the fake microphone still works, as this new version is not used anyway. - An extra VLOG in UpdateRecordingState(). Bug: b/171748795 Test: chromeos_unittests --gtest_filter="Audio*" Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I80965e5de31ea48c19363966bae384414b16bcc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605706 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#844206}
-
Yaron Friedman authored
BUG=783819 Change-Id: Ib3c902569d57b0849d4ac2eb8ad049317db6946a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626422 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#844205}
-
Cammie Smith Barnes authored
This CL is part of the Code Health Rotation, and converts base::Bind, base::Callback, and base::Closure to Once/Repeating as the code context dictates. It also replaces 'typedef' with 'using' in several places adjacent to other changes. Bug: 1007635 Change-Id: Id5cb1bf95d408dfb67cc92ea2cc636598d0b5262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626767Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#844204}
-
danakj authored
Extensions code wants to run scripts on the initial empty document, so instead of adding a duplicate call to all ContentRendererClients (both RenderFrameCreated and RunScriptsAtDocumentStart) we can have the extensions code do the right thing with the RenderFrameCreated signal. R=dcheng@chromium.org, reillyg@chromium.org Bug: 1158869 Change-Id: I11a969e8b84933f13a5ceadb6e6d3943a5fb5d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627690Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#844203}
-
Yi Gu authored
The test is flaky on all platforms: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=LoadTimingBrowserTest.HTTPS&testType=browser_tests TBR=ryansturm@chromium.org Bug: 1128033 Change-Id: I5de88f598d93ff43f06a617a9713d95375698775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633684 Commit-Queue: Yi Gu <yigu@chromium.org> Auto-Submit: Yi Gu <yigu@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#844202}
-
Peter Wen authored
Based on Søren's sample code in http://b/176818423. D8's java API allows us to determine the exact set of dependencies that a class in the current target depends on to desugar correctly (generally its superclass(es) and interface(s) it implements). The class would only need to be re-desugared with D8 if one of these dependencies changes. This CL makes use of this information in a less granular way. If any jar containing one of these dependencies is changed, then we re-dex all the classes. Even so, this limited reduction in dependencies from using D8 for desugaring reduced the previous regression from +50% to +10% for the base_java_sig benchmark. Follow-up CLs will attempt to make use of the more granular desugar dependency information to further improve the timing of D8 desugar. For the time being, we are continuing to use bazel desugar. Bug: 1015559 Change-Id: If507a4013af7bed0820758629a4b9db69942727b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621928 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#844201}
-
Fabrice de Gans-Riberi authored
The test is flaky. TBR=kmarshall@chromium.org Bug: 1167266 Change-Id: I1a788509d7bb69439549358f6a8ef651a38526d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633841Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#844200}
-
Yuke Liao authored
This CL starts running lacros tast tests on the builder: chromeos-amd64-generic-lacros-chrome. Bug: 1158590 Change-Id: I2336084746548f8db6d2596ced7768c9c1088cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622344Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#844199}
-
Hui Yingst authored
This CL changes `scroll_offset_at_last_raster_`, `scroll_offset_`, and BoundScrollOffsetToDocument() from pp::FloatPoint/pp::Point to gfx::PointF/gfx::Point, so that they can be migrated to PdfViewPluginBase later. Bug: 1101101 Change-Id: Iaa845e45b7d6a1d735fb44de3f7194df43b0f32f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626926 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#844198}
-
Fredrik Söderqvist authored
The existing name is somewhat peculiar - the new name better describes the CSS syntax being parsed. Change-Id: Ief212daa9e910b9a148f9946206e25f18cc2c81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632690 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#844197}
-
Andrey Kosyakov authored
Bug: 1164469 Change-Id: I0fab507f0a58676abd0143e5bb8ea562bfb113f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628083 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#844196}
-
Yi Gu authored
See linked bug for details. TBR=ellyjones@chromium.org Bug: 1167249 Change-Id: I97c11cc0eab2c1eba5ed38182befb1bc22d0d7e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633350 Commit-Queue: Yi Gu <yigu@chromium.org> Auto-Submit: Yi Gu <yigu@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
Bug: 1075649 Change-Id: Ia308f0fdd33e274921b1519c5f1aa539da775360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627777Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#844194}
-
Brandon Wylie authored
Bug: 1147581 Change-Id: I291f529cbb1686c6135791b99268f3cb310d4c98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587562Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#844193}
-
Shuran Huang authored
Bug: 1136102 Change-Id: I6fe26dbf5f0c83672136aebe8f4a50846b4cc559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633347Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Shuran Huang <shuuran@chromium.org> Cr-Commit-Position: refs/heads/master@{#844192}
-
David Tseng authored
In ChromeVox background page on startup via console: Error: Failed to load resource: net::ERR_FAILED From chrome-extension://invalid/ (repeated 43 times). The underlying sre_browser.js packed js script is making failed XMLHttpRequest calls, blocked by CORS policy. R=akihiroota@chromium.org Bug: none Change-Id: Id2d46ab3976dfc5b85d993403d587e85d4c66600 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632869Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#844191}
-
Matt Giuca authored
Adds people who are now responsible for Desktop PWAs as the rightful owners, and a few other changes. Change-Id: I7e76fb4d5902ded0a2d422ede66f440c4db48a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409894 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Auto-Submit: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#844190}
-
Alison Maher authored
Update the stored type of inner multicols with pending OOFs added in CL:2612392 from NGBlockNode to LayoutBox*. This was requested as it makes converting NGBlockNode to a GarbageCollected class easier. Bug: 1079031 Change-Id: If2bf19de5774b7f003650b2c8f923cba4adfbe3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630730 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#844189}
-
Basia Zimirska authored
This CL fixes an issue with the UI not being updated after the profile loads and the policy becomes available. Now after a callback about profile creation is called, updating mic visibility is requested. Testing this change: I didn't test it end to end with my own policy server, I did it in a somewhat hacky way with a bool variable that was flipped in the callback to make sure that UI is updated. Bug: 1161022 Change-Id: I4fc8ab9067044b9198efaba0b94acf0199504492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623164Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Josh Simmons <jds@google.com> Commit-Queue: Basia Zimirska <basiaz@google.com> Cr-Commit-Position: refs/heads/master@{#844188}
-
Olivier Robin authored
Unittests rely on ScopedFeatureList which does not work because of these static values. Bug: 1166714 Change-Id: Ie3b0ff8beac1efa2398c68e77725ff69fce9cc2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627405 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#844187}
-
David Black authored
Child bubbles have padding and child spacing such that there are gaps between holding space sections and child bubble edges as well as gaps between holding space sections within the same child bubble. Moving selection clearing to child bubbles instead of section views eliminates what the user might otherwise perceive as dead spots. Bug: 1167248 Change-Id: I561f2862258189fa9960d6c25de7bd6da124771a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632808Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#844186}
-
Yue Zhang authored
TBR: yusufo@chromium.org Bug: 1157892 Change-Id: I6199dacb72f3e9e9133d28115a7a621a8c0297fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613954Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#844185}
-
Jonathan Wright authored
BoringSSL recently added Neon and hardware crypto optimization support for the Windows on Arm (WoA) platform. Enable use of these optimized functions in the Chromium BoringSSL BUILD.gn file. Change-Id: Ic5229f73f3a52bdb291f68819f4cb6862e1c4798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632753Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#844184}
-
Renjie Tang authored
Change-Id: I5fbffa18e477d5e24fe3a772f1ed97f92d9b985e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573678 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844183}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I445ae1f4b5cb389bb1280fda96dd53400aa53633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633444Reviewed-by:
-
Toby Huang authored
This CL removes dead code related to legacy supervised users and renames TODO(crbug/866790) to TODO(crbug/1155729), which is the main bug for tracking legacy supervised user code removal. Bug: 866790 Change-Id: I7ece1ef3e9f4dd548d8f3387d98082f490030d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626194Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Auto-Submit: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844181}
-
Yuke Liao authored
This reverts commit e2f3b551. Reason for revert: Breaks local user flow when entering chrome_sdk ERROR at //build/config/chromeos/rules.gni:180:11: Undefined identifier. _symlink_targets[2], ^----------------- See //chromeos/BUILD.gn:239:3: whence it was called. generate_runner_script("cros_test_wrapper") { ^-------------------------------------------- See //BUILD.gn:442:7: which caused the file to be included. "//chromeos:chromeos_unittests", Original change's description: > Lacros: create lacros tast test targets > > This CL creates gn targets for lacros tast tests, and the main > motivation is to run lacros tast tests on Chromium CI. > > Bug: 1158590 > Change-Id: I783779c3386a39743b8227367189b0b87832b9dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606188 > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#844127} TBR=dpranke@google.com,liaoyuke@chromium.org,bpastene@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I1e51bf2e6aa97bfc40beba7d2693b68361cab2bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1158590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633782Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#844180}
-
Yue Zhang authored
Instead of using one boolean value in profile pref to record dismiss/restore state of cart module, this CL introduces two boolean values to record whether the module is temporarily hidden or permanently removed. Bug: 1157892 Change-Id: I01d95a62fca6466ab893c7be8afbc20b5065ddf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625816Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
Victor Costan authored
Moving features to the Storage Service requires the ability to talk to the Quota system via mojo. storage::QuotaClient is one of the interfaces that needs to be mojofied. Migrating all QuotaClient usage to mojo in one CL is risky, because this CL would introduce timing changes to 7 storage systems (AppCache, Cache Storage, File System, IndexedDB, NativeIO, Service Workers, WebSQL). Therefore, QuotaClient will be migrated piece by piece. This CL introduces the storage::mojom::QuotaClient interface, and integrates it with QuotaManager. To facilitate a gradual migration, QuotaManager will support both mojofied and non-mojofied QuotaClients. QuotaManager tests will cover both types of clients, to ensure correct operation throughout the migration. Other tests that integrate with QuotaManager will use mojofied clients, because this reduces future churn. To maximize test coverage, QuotaManager's support for mojofied QuotaClients is written on top of the support for non-mojofied QuotaClients. This CL also adds TODOs documenting the cleanup that will be required once all QuotaClients are mojofied. Bug: 1016065 Change-Id: I6df5a97763447e41eb3b523e180a6c13dfa3199c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610633 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#844178}
-
Dave Tapuska authored
Move GetPluginInfo to be a method on the PepperHost mojom object. This code path is used for content layer (content shell is one example) to load plugins. (chrome embedders use a ContentClient override). Remove the now useless RenderFrameMessageFilter. BUG=1157519 Change-Id: I0c1e4c74b86351169637b72c4224c9000ca70945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630545 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#844177}
-
Etienne Bergeron authored
These histograms are no longer used. The timing and count information is already available into RenderText for every platforms. There is no need to have a windows specific histograms. R=robliao@chromium.org Bug: 1151976 Change-Id: I0c90c44ace8f6607a55112a117a75cdd5b4eb20f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611585Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#844176}
-
Moe Ahmadi authored
This is a useful metric to monitor the adoption of the promo browser commands. Fixed: 1165094 Change-Id: I2df2e242cc072eb5ee74716a029eae111373584b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632065Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844175}
-
Mike Dougherty authored
Bug: 1164846 Change-Id: I975c02ac34bb4e37a06ae7759eaffb7984f95065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628024Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#844174}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Icc88c13289498fcfcc2c39167d5c81552bb2c8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633171Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3100aca993ac..1502a9ec072f 2021-01-15 vidorteg@microsoft.com [Loc] Migrate event_listener pane to Localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id2a9e3e8dfd61dd665a51c036a2f1ed4dae1f602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633134Reviewed-by:
-
Andy Paicu authored
Bug: 1138595 Change-Id: I7b5ab3739842122e5b71f208b4e0bb237636ee3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624608 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#844171}
-
