- 27 Aug, 2019 40 commits
-
-
Vasiliy Telezhnikov authored
This CL add waiting for default icon image to be loaded in the BrowserActionApiTest.BrowserActionWithRectangularIcon tests. It adds TestIconImageObserver for this purpose (instead of local WaitForIconLoaded in MultiActionAPICanvasTest) Bug: 997820 Change-Id: I447d7563cd0bde20f8787f9eb412978addaecab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772128 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#690887}
-
Rakina Zata Amni authored
Move the tests & change them to use rendersubtree attribute. Removed some tests around containment, inline, timeout, duplicate from lock-after-append move etc. Note the acquire-clone.html tests failed, will file bug. Bug: 991095 Change-Id: Ia6606706bae235c07bbb78d34f4a6c91afda32ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772816Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#690886}
-
Gavin Williams authored
-New sort order is printers with automatic configuration sorted alphabetically first then printers that need manual configuration sorted alphabetically next -Added new test case to confirm nearby printers sorted correctly Bug: 993820 Change-Id: Idf730c8111bc6e835b659e899e3a478d719e04a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767604 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#690885}
-
Owen Min authored
Plugin belongs to browser instance. We don't need browser context to get plugin lists. Hence move plugin from ChromeUserProfileInfo to BrwoserReport. 1) Remove Plugin related code from ProfileReportGenerator 2) Because of 1), ProfileReportGenerator does not need to be async. 3) ReportGenerator remains async as Plugin information will be get here. Getting plugin info in ReportGenerator will be added in the following CL. Bug: 956237 Change-Id: I04c5ac519bc5c03e5436e10e98eebcf9a27b11fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764278 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Marc-André Decoste <mad@chromium.org> Cr-Commit-Position: refs/heads/master@{#690884}
-
Stephen Nusko authored
This reverts commit 94d22097. Reason for revert: Tests on the pixel 2 GPU are now fixed. See gpu-fyi-try-android-p-pixel-2-skv-32 trybot. Changes: 1) We now call OnDisconnect if we were already connected when calling SetNewSocketForTesting() this fixes gpu-fyi-try-android-p-pixel-2-skv-32 2) GetDefaultTraceConfig() is now in a unnamed namespace in the .cc file rather then a member function. This was needed for ubsan_vptr as described in crbug/997318 Original change's description: > Revert "Enable a new SYSTEM background tracing mode." > > This reverts commit 9c5df46a. > > Reason for revert: timing out tests > > Original change's description: > > Enable a new SYSTEM background tracing mode. > > > > This mode will allow us to set up a background scenario and deliver > > triggers to the system when something interesting is happening. Which > > will allow us to only upload traces that are of interest. > > > > Bug: 979583 > > Change-Id: Ic48ea08e3f9fafccaf045847cc0ddfa76d11611c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760736 > > Commit-Queue: Avi Drissman <avi@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: oysteine <oysteine@chromium.org> > > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#689563} > > TBR=avi@chromium.org,oysteine@chromium.org,eseckler@chromium.org,nuskos@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 979583,997206 > Change-Id: I51889cecfdc1ac392fb199b1a190b14880801e6d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768981 > Reviewed-by: enne <enne@chromium.org> > Commit-Queue: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690047} TBR=avi@chromium.org,enne@chromium.org,oysteine@chromium.org,eseckler@chromium.org,nuskos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 979583, 997206, 997318 Change-Id: Ib7052fbb7f2b67d85657494ab59d111a58213cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768768Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#690883}
-
Karen Qian authored
Bug: 922150 Change-Id: I6df27b4f41583f5231cca5a10277d6ce3bddaa3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769347Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Karen Qian <karenqian@google.com> Cr-Commit-Position: refs/heads/master@{#690882}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73c58302fc9e..daddc3da9672 Created with: gclient setdep -r src-internal@daddc3da9672 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:913074 Change-Id: I01d4c30c9429bd9b844803c6cd7d8a8225b0aa10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773189Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690881}
-
Tao Bai authored
This patch moves chrome/common/page_load_metrics to components/page_load_metrics/common, and is mostly moving the file, no change to feature. README and OWNER file haven't been updated, will do when moving them to components. Bug: 995880 Change-Id: I5f8eb1cdbc9a631fea2fdd6158ea93b35da74271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761729Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#690880}
-
Eric Willigers authored
Blink previously used 'auto' as the initial value, but did not accept 'auto' as a specified value. https://drafts.csswg.org/css-scroll-snap-1/#padding-longhands-physical https://drafts.csswg.org/css-scroll-snap-1/#padding-longhands-logical Bug: 921319 Change-Id: Ice01fd6e52ad3abb726fee352488c2423d001f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772716Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#690879}
-
Zhongyi Shi authored
http://crbug.com/c/1769725 forces check the caller does not set options to handle ip address change and connection migration simultaneously. iOS however enables "goaway_sessions_on_ip_change" be default, which caused the migration option setting test fails. Bug: 998156 Change-Id: I8968a257c555b165ecca3aa60138366960c00b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773343 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#690878}
-
Dana Fried authored
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1764942 which restricted vertical alignment of labels to multiline only. It relaxes the restriction, allowing all render text to be top or bottom aligned, though at the expense of the ability to guarantee baseline alignment when mixed fonts are required to render a line (still a feature of the default ALIGN_MIDDLE; a note has been put on the new Label::SetVerticalAlignment() method to this effect). Bug: 996905 Change-Id: I46d60902e91ea202f48ae2952b4c0cb118d80650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772449Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#690877}
-
Khushal authored
Only use wide color gamut color spaces with SurfaceControl if enabled for the GLSurface, which is gated on support from the platform queried using Display.isWideColorGamut(). R=ericrk@chromium.org Bug: 997592 Change-Id: If9d09d04c341c86c414c514e9c069b08f6a9c87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772276 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#690876}
-
Ian Kilpatrick authored
This relaxes a constraint we had previously that we'd never re-use a layout-result if our "forced" BFC block-offset was different. For self-collapsing blocks we can somewhat ignore this rule for the following cases: 1. If the self-collapsing block has no adjoining-objects, it can be placed anywhere. 2. If the self-collapsing block has adjoining-objects, it can be placed anywhere if its old and new expected position doesn't intersect with any floats. Change-Id: Ib2a85455955ed5b207aed64c2d691584437eaa6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769158 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#690875}
-
Steven Bingler authored
Add all members to chrome_browser_net namespace. Change IsValidDohTemplate() name to be DoH specific. Change-Id: I68cf5d2ce3a987b2e0f000ebd125a4ef490d7237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764899 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#690874}
-
Alex Ilin authored
ashmem_get_funcs() returns a pointer to a static local variable s_ashmem_funcs that is initialized in a non thread-safe way. It is possible that one thread starts the initialization of s_ashmem_funcs and sets s_ashmem_funcs->create. s_ashmem_funcs->setProt is not initialized yet. Then another thread calls ashmem_get_funcs() and since s_ashmem_funcs->create != NULL, ashmem_get_funcs() returns a pointer to a partially initialized struct. An attempt to call s_ashmem_funcs->setProt fails on the null pointer. This CL fixes the data race by using pthread_once(). pthread_once() guarantees that the initialization function will be called exactly once ans that on return from pthread_once() the initialization has completed. Bug: 985870 Change-Id: I182c3edd43eb2cb58ec9e70d8e03f82742004138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769452Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
-
Hesen Zhang authored
- Changed AddIcons with a map of IconType and UUID as input. - Complete ScheduleNotification logic. - Added unit tests for adding icons. Bug: 963290 Change-Id: Ie51437b08314712707f3b12c857dbfc18182adf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771076 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#690872}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fce3bd0cb0a5..51ed66b5cadd git log fce3bd0cb0a5..51ed66b5cadd --date=short --no-merges --format='%ad %ae %s' 2019-08-27 dhaddock@chromium.org Improve logging of AU test failures. Created with: gclient setdep -r src/third_party/chromite@51ed66b5cadd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1b438d1c3b998b408e141c891ca03a62fedf4bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773187Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690871}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/be14352b8322..c5a91bb269fc git log be14352b8322..c5a91bb269fc --date=short --no-merges --format='%ad %ae %s' 2019-08-27 zoddicus@users.noreply.github.com Add ToVulkan API methods (#792) Created with: gclient setdep -r src/third_party/shaderc/src@c5a91bb269fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I926d2bc9623f8f4f48f3cd18a40e2ed3957204f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773326Reviewed-by:
-
Min Qin authored
If a navigation is triggered by a cross-origin download initiated by renderer, the navigation should carry the renderer initiated flag. BUG=979443 Change-Id: I0716193768a5473f70e909b7efbb5fc74933d89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768825Reviewed-by:
-
Mike Wasserman authored
The text was incorrectly using a secondary (lighter gray) style. Use the primary (darker gray) style like similar UI surfaces. Bug: 997886 Change-Id: I1bdcf33efce266612c58c80ce564bb2449972915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772447 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#690868}
-
Majid Valipour authored
There test were marked as flaky as part of a mojo change landing. The tests no longer seem to be flaky based on local test! While it is not clear why but this patch changes expectation so they are no longer skipped. Once we confirm they are not flaky we can enable them back. [1] https://crbug.com/922951 Bug: 991565, 986018, 922951 Change-Id: I7fd50531bf23a102bf20d332d40af81953a697ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768668 Auto-Submit: Majid Valipour <majidvp@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#690867}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d7cac7cb..0cd38a17 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I47020d173ca16923b2a4467575db2c21d898831c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772089Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690866}
-
Jacques Chen authored
-Change protocol.json to be Brotli compressed by grit -Have protocol.json be decompressed by GetDataResourceBytes -Remove brotli.gni that is no longer used Bug: 826858 Change-Id: I2c49715f85508f494a57d65b09ada446c2efefec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728183 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#690865}
-
Maggie Chen authored
Some of the functions are allowed to run only on the watchdog thread or the watched GPU thread. DCHECKs are added to these functions to make sure multi-threading is running correctly. For those functions that can run on any threads, no DCHECK is added. Bug: 949839 Change-Id: If451934db201d8544a427c007995900361663768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773436Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690864}
-
Wei Li authored
Since we fetch survey content from a remote server, we have to handle situations such as no internet or slow connections etc. To work around all such problems, this CL creates the web dialog and preload the survey content before showing user the bubble banner. We only show the bubble banner after we already retrieve the survey content. The pros of this approach include 1) avoid handling offline and slow loading scenarios; 2) fast UI -- the dialog will immediately show up once user consents. BUG=979530,996542 Change-Id: I7163c1fd06a479460d4705458c880f5e17ce1b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745710 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5c81d94fa362..14a9be448e01 git log 5c81d94fa362..14a9be448e01 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 ianelliott@google.com Vulkan: Enable the official GLES1 conformance tests 2019-08-27 geofflang@chromium.org GL: Check for errors around GL calls. Created with: gclient setdep -r src/third_party/angle@14a9be448e01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: Ifda512ef345a5fa008d2bc83cf834b0971dec55a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773186Reviewed-by:
-
Caleb Rouleau authored
R=charliea@chromium.org, hypan@google.com, perezju@chromium.org, rmhasan@google.com Change-Id: I24aef52de209c1c482c7bfb16f86f2d1b0facd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769541 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#690861}
-
Kurt Catti-Schmidt authored
The crash for this bug is in ui::AXPlatformNodeBase::GetData, however the actual issue is that the node is nullptr due to it being out of range from the parent nodes children array. I traced this back to the parent's cached unignored child count being incorrect. This happens when node_id_to_clear is set - the node is cleared, but the parent's unignored cached values are not cleared. This change simply adds logic to add the parent node to the list of nodes to update their unignored cache. This logic is identical to what happens when the ignored state changes a few lines below. Bug: 974435 Change-Id: I5392eff3cd31900739bff1f40a31edf7d84e9882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769109 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#690860}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/44bd29a3b068..70768f4a8e10 git log 44bd29a3b068..70768f4a8e10 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 sprang@webrtc.org Remove usage of StorageType enum Created with: gclient setdep -r src/third_party/webrtc@70768f4a8e10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: If4447a9addb65ade6398738d72babe5b0c99b62e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773445Reviewed-by:
-
Kevin Ellis authored
This memory leak should have been caught by WPT tests for getAnimations but these tests are currently broken. Next step, fix getAnimations tests or add equivalent tests to ensure that this memory leak does not reappear. Bug: 997076, 996640 Change-Id: I0ed5e7c4ceea8d8629c16ecf72d80c3ee598742b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773536Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#690858}
-
Adam Langley authored
By using vector/span<uint8_t> APIs (rather than std::string-based APIs) for encryption and decryption, we can save some copies when processing caBLE messages. Change-Id: Ib4cff22b0825ed1658d870474b9a02e9603ca69f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756950 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#690857}
-
Eric Orth authored
Various cleanups to simplify things in preparation to convert config-change listening to SystemDnsConfigChangeNotifier: *Now that we always have a DnsClient from the start, as long as defined(ENABLE_BUILT_IN_DNS), moved a bunch of DnsClient-specific properties including ownership of the DnsConfig and overrides into DnsClient itself. Figure anything we can move out of the overcomplicated HostResolverManager is an improvement. *Removed assumptions that NetworkChangeNotifier would hold a base config, mostly only reading from NCN on change notifications or on init (essentially the times SystemDnsConfigChangeNotifier will give the manager a config). *Removed a bunch of unnecessary abstractions for updating and reading configuration and secondary state based on the configuration. Most of these have become less necessary and more overcomplicated in all the recent code churn. More code now more directly updates or reads config as necessary. *Removed some test methods for reading/modifying config now that testing code can always interact with a mocked DnsClient or soon SystemDnsConfigChangeNotifier. Bug: 971411 Change-Id: Ia74580c40c6b399da2ab848a4b05854f5f232e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742305 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#690856}
-
enne authored
This reverts commit 3cd3ad22. Reason for revert: causes black squares on ui layers that lie about opaqueness Original change's description: > cc: don't allow transparent quads for opaque layers > > This is a DCHECK + workaround for issue 988590. > > https://chromium-review.googlesource.com/c/chromium/src/+/1749703 > solves root of the problem, and will avoid this DCHECK for > this particular content. > > Bug: 988590 > Change-Id: I0e66ba388c11bbc3805ead42343d7fe7af7a79da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752873 > Commit-Queue: enne <enne@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689250} TBR=enne@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 988590,997583 Change-Id: Id5cb90d22b3b5bf070a8223d90a5fa30f958f12c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773207Reviewed-by:
enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#690855}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c445c7d5c87b..674ee74e88d7 git log c445c7d5c87b..674ee74e88d7 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 egdaniel@google.com Make sure we use clear load op on GrOpsTask as often as possible. 2019-08-27 michaelludwig@google.com Fix subset errors in blur, matrix, and morphology filters 2019-08-27 senorblanco@chromium.org Dawn: use Skia's copy of vulkan headers. 2019-08-27 senorblanco@chromium.org Add spirv-cross to DEPS. Created with: gclient setdep -r src/third_party/skia@674ee74e88d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: I60516dbc444f7e86d1f0ab4812af671bdb54567b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771663Reviewed-by:
-
Morten Stenshorne authored
This switches the column balancing pass over to being block fragmented, so that we get the contents split into content runs, separated by forced breaks only. Previously we pretended that we weren't fragmented. This CL shouldn't affect correctness, but it will improve performance when there are forced breaks, as a taller initial balanced block-size will result in fewer layout passes. Added another unit test anyway, just to improve coverage (it also passed without this CL). The new perf test changes from 7 runs per second to 240 runs per second with this CL (when LayoutNGBlockFragmentation is enabled). The logic is mostly taken from ColumnBalancer in the legacy layout engine. Because of this change, we'll now detect when we're in a nested fragmentation context also when balancing, and therefore bail and fail another nested column balancing tests. We don't support column balancing in a nested fragmentation context yet. Bug: 829028 Change-Id: Ibc65feb6da01d8d99de5b38eaf787633a5153cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771957 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#690853}
-
Marijn Kruisselbrink authored
The test often times out on the waterfall. Tbr: chcunningham@chromium.org Change-Id: I47cc2c795f0ff4163e952d1cce971388b7a67760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773524Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#690852}
-
Sophie Yang authored
This change replaces all of the text navigation actions on the main menu with the ‘Move cursor’ action. When ‘Move cursor’ is selected, a submenu is opened with all of the text navigation actions. Test: With emulated Chrome OS on Linux and both the Switch Access and improved text input command line flags enabled (--enable-experimental-accessibility-switch-access and --enable-experimental-accessibility-switch-access-text), manually verified that when the ‘Move cursor’ action is selected in the main menu for an editable text node, the main menu is replaced in the panel by the text navigation submenu. When the back button is selected while in the text navigation submenu, the submenu is replaced in the panel by the main menu, and when the back button is selected while in the main menu, the menu exits and the panel disappears. See go/cros-switch-menu-redesign for more information. Bug: 994256 Change-Id: I4e0a4f45c082d40b164f13ca56ca5de0067181ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772301Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Sophie Yang <sophyang@google.com> Cr-Commit-Position: refs/heads/master@{#690851}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a1c6c1a6. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." d3b97055 "Update simulateUserActivation to match webxr-test-api spec" 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iecad6b387f7942ab92371625a9e80533e2f5e3e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772087Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690850}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7ad424d601e2..db16ee85fb52 git log 7ad424d601e2..db16ee85fb52 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 malets@yandex-team.ru Wrap results.output_dir in os.path.realpath() in json_3_output_formatter.ResultsAsDict. Created with: gclient setdep -r src/third_party/catapult@db16ee85fb52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:996105 Change-Id: I07ee94eb281e13f5f30c2fb5c477a747f278e7e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773443Reviewed-by:
-
Thomas Guilbert authored
This CL allows the Renderer process to request a LearningTaskController from the Browser process. The MediaMetricsProvider is used as a bridge between the Renderer and the Browser process. It binds the incoming mojo request to a MojoLearningTaskControllerService. The service in turn forwards calls to a LTC owned by the appropriate BrowserContext's LearningSession. Bug: 994831 Change-Id: Ib2e3e35500da858688de0d49f3989968730b86ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764791Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#690848}
-
