GitLab

Fix traffic annotation auditor bug, when no path filter was provided and
--no-filtering switch was passed, no file was processed.

Bug: 690323
Change-Id: I0235a4c30cf985cf68d7f05080c64bc26f4a29d8
Reviewed-on: https://chromium-review.googlesource.com/958503Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548679}

- Remove InitializeRenderer_InvalidConfig, which causes
  deserialization error and test timeout.
- Reenable tests now that http://crbug.com/594977 is fixed.
- Disable InitializeCdm* tests on Android. See Bug.

Bug: 829233
Test: Various test fixes.
Change-Id: Iaa4ac72a8e60a88559fa198e9f3c1da16aa0beb4
Reviewed-on: https://chromium-review.googlesource.com/996959
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548678}

This shows the CT compliance status in the Certificate Transparency section of
the Security Panel origin details view. Showing the SCTs themselves isn't
sufficient because a site could have e.g. not enough SCTs or SCTs from an
insufficent set of logs, and thus might not be CT-compliance even though it has
SCTs.

I also added a message about when a resource was loaded from cache to the origin
details view. This is useful beacuse not all security details are stored in the
cache, so it can explain why some security details (including SCTs and CT
compliance status) can be missing in this view sometimes.

Bug: 695610
Change-Id: Ib9c8b0af5a08dbc5eefcf778fc030c045622505e
Reviewed-on: https://chromium-review.googlesource.com/998445
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548677}

Bug: 828940
Test: Manually tested. See Bug for repro steps.
Change-Id: Id138ebc26ed5dc0b075cc18a67c651b3832077a9
Reviewed-on: https://chromium-review.googlesource.com/999122Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548676}

This is a reland of a776bce4

This updates the utils filepath so the new test passes.

Original change's description:
> [Picture in Picture] Add modern media control.
>
> Currently, there is only a PiP button for the legacy / non-modern
> set of media controls. This adds and enables the modern version.
>
> BUG: 726619 823109
> Change-Id: Iddb2d8393d5cf519bb6e32639d5f640bc341fc6f
> Reviewed-on: https://chromium-review.googlesource.com/966980
> Commit-Queue: apacible <apacible@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548358}

TBR=mlamouri@chromium.org,steimel@chromium.org

BUG: 726619 823109
Change-Id: I311c137f70b8e5f2ee2681ac8ffd022f2a272d8a
Reviewed-on: https://chromium-review.googlesource.com/998078Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548675}

This should be called after native library has been loaded.
Also, using a sparse histogram to avoid having to provide a max value.

In doing so, histogram name 'WebView' is replaced by 'Android.WebView'
to be consistent.

BUG=827653

Change-Id: I5a03415c342e50ff900e0c4e47f5dd8c17e8a2bc
Reviewed-on: https://chromium-review.googlesource.com/987193Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548674}

This is a reland of r548137 which now includes a whitelist to allow
print preview WebUI to fetch cloud print device information directly
from the network. See https://crbug.com/829218 for additional context.
Original CL description follows.

==

Re-enables this test with the Network Service enabled.


This test did some things which the Network Service does not support and
does not need to support, or which otherwise made testing with the
Network Service more complex than necessary. The following changes have
been made:

  * We no longer attempt to load a network resource from a WebUI
    renderer. This will not be supported with Network Service and is no
    longer desirable to have working in production anyway. There should
    no longer be any WebUI pages making network requests.

  * Use http instead of https for the clients1.google.com requests. This
    allows such requests to be handled by the EmbeddedTestServer which
    already exists in BrowserTestBase, which is itself not configured to
    handle HTTPS requests. Since these requests are filtered by
    hostname, the scheme doesn't matter.

  * Switch the test to use a SimpleURLLoader instead of a
    FakeURLFetcher. This allows the test code to exercise the same
    behavior with or without the Network Service enabled.

TBR=karandeepb@chromium.org

Bug: 721414
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I57bf66dfd7e7e0726ac98c9571f7fa031243e328
Reviewed-on: https://chromium-review.googlesource.com/998449Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548673}

- Only initialize global state (e.g. AtExitManager) in non-Debug builds, so that our component-
  build Debug bots can run cronet_tests.
- Fix memory leaks in a number of unit-tests.
- Disable some StaleHostResolver tests under ASAN, since they have leaks
  that need resolving.

Bug: 812268, 816705, 829097
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5084dd578682b2a8c128487c62de12e437e646f3
Reviewed-on: https://chromium-review.googlesource.com/981787
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548672}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2a5f70cc060a..1118a2193b8f

$ git log 2a5f70cc0..1118a2193 --date=short --no-merges --format='%ad %ae %s'
2018-04-05 ehmaldonado gclient_eval: Support unpinned dependencies in SetRevision.
2018-04-05 ehmaldonado gclient_eval: Add more support when adding new variables.
2018-04-05 ehmaldonado gclient setdep: Command line interface nits.
2018-04-05 ehmaldonado presubmit_unittest: Remove redundant tests.
2018-04-05 sergeyberezin Roll mac_toolchain to 496a91484
2018-04-05 borenet roll-dep: Fix behavior for relative DEPS

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:760633,chromium:760633,chromium:760633,chromium:829134,chromium:797051


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ibc387b556140307f5ed87c799cb5318c8c59e631
Reviewed-on: https://chromium-review.googlesource.com/999308Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548671}

* Refactor of the browser test code to make it easier
to add new client hints without repetitve code
* Move the effective connection type names to a common
folder so they can also be accessed from
chrome/browser. This is necessary since we need
to add ECT client hint in the next CL on navigation
requests in chrome/browser.

This CL does not make any functional changes.

Bug: 826950
Change-Id: I7c854fae84738b8d0edece6c6ffd27abcc43bfbc
Reviewed-on: https://chromium-review.googlesource.com/996925
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548670}

The current chrome.management.uninstall api shows the programmatic
uninstall dialog for extensions uninstalling other extensions. Web Store
is treated as a hosted app. Thus in order not to show "Web store wants
to uninstall this extension" I added a check to make sure the uninstall
is not coming from the Web Store. I also added an uninstall source for
web store so we can track which uninstall pings come from the store.

Bug: 823155
Change-Id: I73c1e53ffaadcddd930e34032db2acda6cb9867f
Reviewed-on: https://chromium-review.googlesource.com/966485Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548669}

Currently, we run the PipSurfaceInfoCB callback in WMPI with an empty
viz::SurfaceId, which is not allowed. This change adds a new mojo call
to explicitly exit from Picture-in-Picture mode from the WMPI side.

BUG: 823172
Change-Id: I81bb71a3853325bcf31a56f8929d4aba17f66248
Reviewed-on: https://chromium-review.googlesource.com/996468
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548668}

The state of which buffers (color, depth, stencil) were modified was
not being tracked properly with the introduction of the ES 3.0 / WebGL
2.0 APIs. Generalize DrawingBuffer's tracking, and make these APIs
update the state properly.

Tested with new WebGL conformance test in
https://github.com/KhronosGroup/WebGL/pull/2628 .

Bug: 828262
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8d87b1940a73c689c2107d969139ad8c9c265ce5
Reviewed-on: https://chromium-review.googlesource.com/994463
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548667}

Change-Id: Id6c781b5f3d113d6575f314b301f923c4221b83d
Reviewed-on: https://chromium-review.googlesource.com/998675
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548666}

There's been a bunch of crashes where it appears no video frame was returned
even though status = success. This change adds additional logging and converts
some of the DCHECKs to CHECK so that the problem is caught earlier.

BUG=828148
TEST=encrypted media browser_tests pass

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib15465179f4931860b6b6fb4192c320e09a30d7e
Reviewed-on: https://chromium-review.googlesource.com/993711Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548665}

Feed Sizing:
Monochrome.apk_Dex
        +2 entries fields
        +5 entries methods
        +1 entries types
        +1 entries strings
Monochrome.apk_Breakdown (+1,524 bytes)
      -273 bytes Zip Overhead
       -17 bytes Non-compiled Android resources size
       -28 bytes Package metadata size
      +266 bytes Java code size
    +1,576 bytes Compiled Android resources size
Monochrome.apk_Specifics
    +1,908 bytes normalized apk size
      +384 bytes main dex size

(The sizing looks very similar to the last DEPS roll which is to be
expected given that the delta is small)

Change-Id: I5207c2a038034007a4e9353709c607468eb27b44
Reviewed-on: https://chromium-review.googlesource.com/999261Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548664}

NOTRY=true  # CQ flake

Change-Id: I6b85e7836cf0a4921396f7d7066d38f04f1b5598
Reviewed-on: https://chromium-review.googlesource.com/998061
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548663}

Previews in android should not be presented without the full chrome
browser user treatment (eg, PWA launched from homescreen in standalone
mode). This CL blocks previews for navigations that do not originate
from an android Tab in kWebDisplayModeBrowser.

Bug: 818031
Change-Id: I88bbae7954daf503e49720adce094a9111790003
Reviewed-on: https://chromium-review.googlesource.com/953882Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548662}

This splits out purely code health changes from the master patch at
https://chromium-review.googlesource.com/c/chromium/src/+/981845

Change-Id: I0a36ea4a69c38fdbf22b514f1ebc43f3ed70f827
Reviewed-on: https://chromium-review.googlesource.com/999215Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548661}

This was flaking because of crashes in Oilpan. Since then, the WebGL
context's object graph has been redesigned. This test should no longer
be flaky.

TBR=kainino@chromium.org, jdarpinian@chromium.org

Bug: 603168
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ibafa9168250094c4b070342a8a08a6bb92002174
Reviewed-on: https://chromium-review.googlesource.com/996965
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548660}

The download button only shows up in the overflow menu so the logic is
now to show the UI anchor to the overflow menu button to suggest the
user to use it to find the download action.

Bug: 781725
Change-Id: Ifce219924ac55c7858ffb1ba8a099cbc96a24e6d
Reviewed-on: https://chromium-review.googlesource.com/998913Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548659}

In order to break-away from the legacy threading model and eliminate the
need for future circular dependencies on src/media/(audio|base), this
change forks AudioOutputController and AudioSyncReader into
src/services/audio.

In addition to the namespace and class naming changes, the following
modifications have been made on the forked code:

1. Removed the ref-counting of audio::OutputController, eliminated the
Create() factory methods, and changed a few heap-allocated objects into
proper class data members (i.e., composition instead of indirection).

2. Removed the XYZ()→DoXYZ() thread-trampoline methods.

3. Updated comments that became misleading or are not otherwise accurate
to how things work in the new Audio Service.

4. Changed the audio::OutputStream to use the forked OutputController
and SyncReader.

5. Updated unit tests.

Further clean-ups and code deletions/refactorings are intentionally
being left TODO in future patches.

Bug: 824019, 803102
Change-Id: If479c63909c252c8fca135c9a51dcac76feeec8c
Reviewed-on: https://chromium-review.googlesource.com/982904
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548658}

This reverts crrev.com/c/952666. That commit was a workaround for a
bug which was fixed in Clang r327557, so the workaround is no longer
needed.

R=depranke,brucedawson

Bug: 818086
Change-Id: I98ba3cea051734da2eef81fe1986c9f9b5d9b617
Reviewed-on: https://chromium-review.googlesource.com/998513Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Bob Haarman <inglorion@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548657}

After [1], ThreadableLoadingContext::Create() takes ExecutionContext&, so we
don't have to call ToDocument() / ToWorkerGlobalScope() for the function.

[1] https://chromium.googlesource.com/chromium/src/+/87c0b54398ec0f1d48fd4ace777691f4b756c880

Bug: n/a
Change-Id: I253e2d43274fa78014386176e1358716c67c7c2e
Reviewed-on: https://chromium-review.googlesource.com/996836Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548656}

Bug: 754986
Change-Id: I66fafcea2b851e371473893bd23fe36b17354069
Reviewed-on: https://chromium-review.googlesource.com/999041Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548655}

The histogram values for an extension function are used to report
API call activity and related metrics for extension functions. Each
extension function should have a unique histogram value, but some of
them were erroneously copy-pasted. This leads to incorrect metrics, both
with not reporting one function and over-reporting another.

Fix the instances where the histogram values were duplicated, and add a
browser test that ensures each function has a unique histogram value.

Bug: 827601

Change-Id: Ic44519ca83fe0cf4b3a1896a16232f6400b6c79d
Reviewed-on: https://chromium-review.googlesource.com/988227
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548654}

I found the reason that SPv175 has 10% less paint_op_count but about
1% more paint_op_memory_usage: we didn't count ops in sub-records.

Add cc::DisplayItemList::TotalOpCount() to count all ops.

Bug: 803867
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0526ace84cc16775d5691e87b502544e64f5932e
Reviewed-on: https://chromium-review.googlesource.com/996316Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548653}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=anantha@chromium.org

Change-Id: I10ab13cc1eba5f515d163fe10ea24e3bcbc88416
Reviewed-on: https://chromium-review.googlesource.com/999314Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548652}

BUG=aomedia:1672
R=dalecurtis@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I36df0607d647ba7cc4d9c46e70f1a34aaedcc54c
Reviewed-on: https://chromium-review.googlesource.com/999007Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#548651}

getSSID on Android may return a special pre-defined string if the app
does not have permissions to get the SSID.

In that case, the method returns an empty string.

Change-Id: I58c99301b4d611124c8434e93fd787edbec32da3
Bug: 827212
Reviewed-on: https://chromium-review.googlesource.com/987306Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548650}

The scrubbing message has lots of child DOM elements. This
creates/prunes them when the visiblity of the scrubbing message changes.

BUG=821961,821414

Change-Id: I4f0b2dc2c276387be1867ff6459d594dc97d3545
Reviewed-on: https://chromium-review.googlesource.com/990480
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548649}

This patch unifies the duplicate code in the function for better code
health.

Bug: 828719
Change-Id: I5c75a6345b345633bebd37c556b780cfaad24d1d
Reviewed-on: https://chromium-review.googlesource.com/996569Reviewed-by: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548648}

MediaStreamTrack's clone should have same constraints.
This CL ensures that MediaStreamTrack.clone().getConstraints()
returns the same value as MediaStreamTrack.getConstraints().

Bug: 669212
Change-Id: I305a3e3e831d8355576201dada5f1ef81072bab5
Reviewed-on: https://chromium-review.googlesource.com/997319Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#548647}

This dependence is unnecessary so remove it.

Bug: 734095
Change-Id: Ibadaab346553f3d842ecc371328bf624583f25ec
Reviewed-on: https://chromium-review.googlesource.com/999039
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548646}

make SiteIsolationPolicy public.

The problem was that --site-per-process disabled extension
process sharing, but the site-per-process base::Feature (which
we've been field trialing) did not. This was due to the
extensions code checking only for the flag, and not considering
the field trial state as well.

components/printing actually got the logic right, but only by
reproducing a lot of business logic. Thus, it seems
appropriate to move SiteIsolationPolicy to content/public,
so that we can centralize the "what kind of oopifs are there"
logic. For printing, this change adds a new getter function
specific to oopif compositor, since that's basically a
derived policy of the process model.

For extensions, we've decided to disable LockToOrigin in
--site-per-process (rather than to enable it in the feature),
since origin-locking extensions doesn't help with the spectre
threat, and --site-per-process is about spectre these days.
[Charlie suggests we develop some kind of "extension isolation v2"
proposal, maybe reviving the --isolate-extension flag for that
purpose!]

Bug: 824966, 766267

Change-Id: Ibf7592c9d522fd0c99057358bcc34b5881780db8
Reviewed-on: https://chromium-review.googlesource.com/949966
Commit-Queue: Nick Carter <nick@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548645}

When Steady State elisions is on, and the user focuses the Omnibox,
and then presses the Home key, we should unelide and place the caret
at the very beginning of the full URL.

Also, when the user gesture taps the Omnibox twice to place a cursor,
we should also unelide and display the full URL.

This CL adds a unit test for each of the above two behaviors.

It also updates the TextField class to add a missing nullptr check for
GetInputMethod(). This method returns nullptr in tests, and is checked
in the other places it's used in the file.

Bug: 797354
Change-Id: I9537028b8cb0abfdb5316efd5bae5518055f5ecf
Reviewed-on: https://chromium-review.googlesource.com/998835
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548644}

This change updates CloudPrintProxyService methods to take base::Value
instead of base::DictionaryValue pointers/references and call base::BindOnce()
instead of base::Bind(). ServiceProcessControl implementation was updated to
use base::OnceClosure accordingly.

Bug: 646113
Change-Id: Id4ff1b0ffd96ec27969bd489ab64503d85c7d6c6
Reviewed-on: https://chromium-review.googlesource.com/998522Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548643}

BUG=chromium:800120
TEST=comment only change.

Change-Id: Ie3a5d99186419c6a11d3efac4e7b50ec459cf772
Reviewed-on: https://chromium-review.googlesource.com/999118Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548642}

Add {Lock,Unlock}ForExternalUse to replace
GetResourceMetadataForExternalUse. It is because the sync_token for
GetResourceMetadataForExternalUse should be considered as unverified sync
token due to the task (which will release the token) is not scheduled
when calling GetResourceMetadataForExternalUse. It will cause
problems, if the we return resources with the token to child before
calling the SwapBuffers(which will schedule a GPU task to SwapBuffers
and release the sync token). This case will not happen right now, but it
is better to not assume it will not happen in future.

Bug: 824382
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I59de9191d3405ca64704b00bedd71564812394a4
Reviewed-on: https://chromium-review.googlesource.com/986505Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548641}

_basename_re and _checked_in_header_re were too large to work on Windows
Python. Split them into small chunks.

Bug: 767672
Change-Id: Ic283face324253a6d3104067237e1f41244375cf
Reviewed-on: https://chromium-review.googlesource.com/997198Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548640}