- 17 Dec, 2020 40 commits
-
-
Aaron Colwell authored
This patch updates test expectations so that they pass when the ProcessSharingWithStrictSiteInstances process model is enabled instead of ProcessSharingWithDefaultSiteInstances. Most of the changes just rearrange the existing expectations to make it clearer which ones apply to the default SiteInstance mode and which ones apply to "strict SiteInstance" modes where we don't allow multiple sites to be assigned to a single SiteInstance. Several helper functions were added to make it easier to update expectations as the process model changes in future CLs. - Added AreStrictSiteInstancesEnabled(),and IsIsolatedOriginRequiredToGuaranteeDedicatedProcess() helper functions to make it easier to express differences in test expectations. - Updated TestWebContents::CrossProcessNavigationPending() to actually verify that the navigation is cross process instead of just verifying whether a speculative RenderFrameHost was created. This is needed for ProcessSharingWithDefaultSiteInstances because this mode can trigger speculative RenderFrameHosts creation for a navigation that will stay in the same process. - Updated many test expectations that compare SiteInstance pointers. Many cases only should expect pointers to match when the default SiteInstance mode is enabled. Logic related to these comparisons were reorganized to make this more clear. - Updated several tests to explicitly isolate origins when ProcessSharingWithStrictSiteInstances is enabled, just like they are for ProcessSharingWithDefaultSiteInstances. This is needed because these two modes might allow sites to share a process when the tests explicitly want them to have dedicated processes. Bug: 1158650 Change-Id: I4cb361e1105ebab800ebc94b51aeda416e37f40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551275Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#838182}
-
sczs authored
-Adds methods to record the un/succsessful network duration of articles fetch, more articles fetch and actions upload. -Creates a new Histogram for un/succsessful actions upload Bug: 1159119 Change-Id: Id83b824be73d7340876a968016426187eebd1001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593743 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#838181}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cc9b7694ce3d..0d23e521cc40 2020-12-17 dsrbecky@google.com Merge "Reuse libunwindstack buffers between consecutive unwinds." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7e76bac499791e2e466229fe8e881c917b5f6719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597620Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838180}
-
Cammie Smith Barnes authored
The overall project aims to expose CNAME aliases to the SubresourceFilter to aid in ad tagging and blocking. A previous CL stored CNAME aliases in net::AddressList during DNS resolution. This CL's parent added an accessor to net::ResolveHostRequest/net::HostResolverManager::RequestImpl. This change continues the plumbing by adding a base::Optional parameter to net::ConnectJob::SetSocket. net::Socket, on the other hand, gains both a getter and a setter for the aliases, which need to be stored in the sockets in case of socket reuse. But only three derived classes get a nontrivial implementation with an actual field to store the aliases: net::TCPClientSocket, net::SSLClientSocketImpl, and net::WebSocketStreamSocket. Relevant tests: net:net_unittests out/Default/net_unittests --gtest_filter=*Dns*Alias* Bug: 1151047 Change-Id: Ib1d8f6d8358aa445fad9051218336ec9953ff9b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563439 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#838179}
-
Michael Bai authored
Send the server and computed types to autofill service when the response arrives after the autofill starts. Add test to cover this case. Bug: 1151542 Change-Id: I91ffab1f0bd3ce62fb768ed690e90e2094c4d86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595792 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#838178}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ie939ae9c326a22934ddd26454b6d5cbb3dd7ed86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595460Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838177}
-
Adam Langley authored
In [1], handshake error information was provided via an |OnFailure| call. But the failure message is still provided via the pipe's reset reason. This change removes that duplication. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2527889 Change-Id: I767cc75504ed305252713db0ef6683d3ebe9544f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538203Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#838176}
-
Roman Sorokin authored
To cleanup OobeDialogHostBehavior Bug: none Change-Id: Icfcb9722da2ed8d98e44147a741466bb28f698e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595407Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#838175}
-
Hiroshige Hayashizaki authored
This is a reland of 3d519f44 Original change's description: > Move CanExecuteScripts() to V8ScriptRunner::CompileAndRunScript() > > To unify how CanExecuteScripts() is checked across > classic script evaluation code paths. > > This CL doesn't change the behavior. > > Bug: 1111134 > Change-Id: If95a32043c52767eda05f16f9630edee26c5e75f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544938 > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832649} The original CL was reverted due to build time increase (crbug.com/1155843) by https://chromium-review.googlesource.com/c/chromium/src/+/2576236. This reland CL moves ScriptController::ExecuteScriptPolicy out of ScriptController, to avoid an extra #include of script_controller.h that caused the build time increase. Bug: 1111134, 1155843 Change-Id: I02119f1e522d6446904dd87a8ff0d507aa246793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594209 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#838174}
-
Regan Hsu authored
* Dialog now stays the same height at each step of flow. * Change font family of title to Google Sans from default Roboto. Screenshots: https://drive.google.com/drive/folders/1HFqo9TJfPttAzsPkJGjWizUYgoDQk67q?usp=sharing Fixed: 1158507, 1155684 Bug: 1106937 Change-Id: Ic1e03dd010aef2613659274afffa5520405a1971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596244 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#838173}
-
Ben Kelly authored
Kenneth Christiansen ran into a few interop issues while trying to get his polyfill implementation to pass the WPT tests. In particular, it seems browsers and nodejs do not agree on hostnames with characters like '|', '^', etc. This CL removes these test cases for now. Solving URL interop issues is outside of the scope of URLPattern. It simply builds on top of the platforms existing URL canonicalization behavior. Kenneth also suggested testing a protocol with a dash in it. Bug: 1141510 Change-Id: I5bdf75b93545dd59592d6be9c7870f4367f7b0dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596113Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#838172}
-
Ben Kelly authored
This CL updates the url_pattern and liburlpattern DIR_METADATA to point to the new Blink>URLPattern component. It also updates the liburlpattern OWNERS file to simply refer to the blink url_pattern OWNERS instead of duplicating content. Bug: 1141510 Change-Id: I312eef95812038cd8acbe186d657cb0a586c33ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596011Reviewed-by:
-
Wei Lee authored
For tablet mode, we should better use the regular way to launch CCA, which means opening CCA in a Browser, rather than using CameraDialog so that the size of the CCA can be fullscreen as well. Bug: b/175322338, b/175326967, b/174891007 Test: tast run [DUT] camera.CCAUIIntent* Change-Id: I39cecffb36e4d104253d74ffd9e44c6740a648b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596282 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#838170}
-
Yue Li authored
- Remove `kAssistantQuickAnswersEnabled` pref - Clean up its ref in assistant and quick answers code - Clean up its settings bindings and settings ui - Clean up its policy bindings Bug: b/159670857 Test: Run existing tests Change-Id: I4cbd620c1aa80a34a81b9316abaf4e649fa6eeab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582804 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#838169}
-
Yuheng Huang authored
Schedule tab search benchmark on Windows 10 since most of the failures are fixed. Bug: 1099917 Change-Id: I806ac094647f54b0b1bbf4c45b686dd39fa77ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595983Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#838168}
-
Joey Arhar authored
When the option element is rendered, neither spaces nor line breaks are preserved in the text, so nowrap makes more sense than pre. Firefox currently has nowrap, whereas safari has pre. Bug: 561071 Change-Id: I5293453192b379761649de76eeb29130086747a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587607 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#838167}
-
Mohamed Amir Yosef authored
This is regarding the move single or multiple passwords to the Google Account triggered from chrome://settings. Since the move bubbles in settings are shown upon explicit user action, the cancel button should have the text "Cancel" instead of "No thanks" This is different from the native move bubble shown automatically upon successful signin which correctly has the text "No thanks" in the cancel button. TBR=cpu@chromium.org Bug: 1139263 Change-Id: I76961128d0c0c6f78ec3a5f1bb6b8ae33b47b132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597438Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#838166}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/92c77100518e..5039608d3366 2020-12-17 yuhengh@chromium.org Log trace collect time in TracingBackend. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1152598 Tbr: wenbinzhang@google.com Change-Id: I6a4f977a8484c23a72d1524075e7460139a99bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597408Reviewed-by:
-
Songtao Xia authored
Frontend CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2409192 Bug: 1159502 Change-Id: I3f3c479504f2d71c09bb73441b89ccdaa495edc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596217Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Commit-Queue: Songtao Xia <soxia@microsoft.com> Cr-Commit-Position: refs/heads/master@{#838164}
-
Francois Doray authored
Fixed: 1129157 Change-Id: Ifc31c71ad0810df279fb1e9ca3869654f882cab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593935Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
-
Jarryd authored
* Implement |install_create_shortcut_tabbed| * Implement |set_open_in_window_internal| * Implement |assert_window_created| * Add a testing journey Bug: 1156363, 1156733, 1156379 Change-Id: I70293d6b4fd06773e6e01d9d4806ef8367794a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595977 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#838162}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8ca67ef2d09..fdd70108b562 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kmilka@google.com,gayane@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kmilka@google.com,gayane@google.com Change-Id: I16ebd808502803bd7c2a71f1ae77a0410f99b792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597616Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838161}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/25c49a45ff39..7df55c21d64b 2020-12-17 wolfi@chromium.org Show service workers in the Application Panel's frame tree 2020-12-17 sigurds@chromium.org Show an issue if a SAB is passed to postMessage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1051466,chromium:1122507 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id43d6be9ab6373c6a095f40f175c9ead2a186a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597413Reviewed-by:
-
Eugene Zemtsov authored
Bug: 1155724 Change-Id: Icf0a258854ca518596c4b48a9b67bcfec9ec0928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596834 Auto-Submit: Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#838159}
-
Steven Bennetts authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/460536ec43e3..efa6d9547c85 $ git log 460536ec4..efa6d9547 --date=short --no-merges --format='%ad %ae %s' 2020-12-16 stevenjb shill: Rename kInhibited -> kInhibitedProperty 2020-12-11 vpalatin cellular: add a property to enable/disable passing the attach APN Created with: roll-dep src/third_party/cros_system_api Bug: b:172077101 Change-Id: Icb1b980c7abee9476d252f9b46ffe2ca2c1e4235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596958 Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#838158}
-
Pavel Feldman authored
RenderFrameDevToolsAgentHost was listening to the page scale factor changes, but it did not obtain the current value upon creation. As a result, RFDAH had page scale factor =1 if it was not emulating it itself. Change-Id: Icf4af5527d4819ff17c3801344dbb7bd50cf80a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597185Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#838157}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/181d8baf8f01..d1469c60c1ab 2020-12-17 dneto@google.com spirv-reader: fix arity for depth texture builtins 2020-12-16 dsinclair@chromium.org Add Symbol to Variable. 2020-12-16 dsinclair@chromium.org Cleanup code using RegisterSymbol 2020-12-16 dneto@google.com spirv-reader: ignore storing 1.0 to PointSize builtin 2020-12-16 dneto@google.com spirv-reader: generalize skip reasons 2020-12-16 dneto@google.com spirv-writer: sampled type must be f32,i32,or u32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I710f3b2e230a194a201d15e1f8069f2340f1f94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597412Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608173994-6a2e9c3f805f7667eca640b2b557f764d57c9690.profdata to chrome-win64-master-1608195565-bd827a491b21adb0b88af96833fe918adc2826b3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I66a0dffadfadedd0a9aec2d10fe728b5102ca408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596861Reviewed-by:
-
Mason Freed authored
These were previously linked to a closed bug, but we should track this specifically. TBR=schenney@chromium.org Bug: 1045510,1043488 Change-Id: I1217bd85c556bff6944906ef8f51a031103769bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595684Reviewed-by:
-
Rafael Cintron authored
Add xrGetViewConfigurationProperties to fake_openxr_impl_api.cc so we can use it in tests. Bug: 1131616 Change-Id: I9f367b428398c07aca73785ae00060971daff9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597036Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#838153}
-
Mohamed Amir Yosef authored
Screenshot: https://screenshot.googleplex.com/6Ki84UvdP69rMEX.png Bug: 1139263 Change-Id: Icdaa25f0abc98affcfffb2e4e717db9bc887cf46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595278 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#838152}
-
Stepan Khapugin authored
Reason: I wrote all of this code. Bug: none Change-Id: I91d5df3b88c8f1845bd89f3b1fbbeb6c4d8d2bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595048Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#838151}
-
Yuheng Huang authored
On windows 10 perf bots, it takes significant longer time to run the tab_search:top100:2020 story, which ofter leads to buffer overrun failure. This CL increases the buffer size to reduce the chance of the failure. Bug: 1152598 Change-Id: I4a15c0e6164661ea344df2461d79ece11e9e6eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596827 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ibb4f28b8b1ff22834f2ef6ba1386c6826d134f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597409Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838149}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0da7da798b33..cc9b7694ce3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ided7734dbdc74632060c8a06a98eb8ad41db1c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597061Reviewed-by:
-
Daniel Murphy authored
This change creates the basic WebAppMover class, but the functionality is currently a NOOP. However it is hooked in correctly, and the implementation would start where marked. Unittests are included to test the initial sanity checking of the source and destination URLs. Follow up patches will include the implementation and thorough browsertests. Bug: 1158066 Change-Id: I04b0a3971932f30c4bbb3b8605f84dc0ea64be99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587825 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#838147}
-
Stepan Khapugin authored
Disables the side swipes in BVC when the blocking UI is displayed. Bug: none Change-Id: Iff04be46bc078b2f523406770b757702732b8ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592798 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Al Muthanna Athamina authored
Bug: chromium:1158374 Change-Id: Idf64a3fc636f4250ad9bb3ea6008676ec9c2d905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597437 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202012170600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/Lhu0LG_M8M2Pn2h_RBp-1HjjF6xbNUOUOu6DedtsKlQC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/174321021,b/174789628,b/174791266,b/175636382,b/175636948 Tbr: help-app@grotations.appspotmail.com Change-Id: I4b281a609780f3c293c1a3f94519c0f5f89e7d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595982Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4342.0-1607944823-benchmark-89.0.4351.0-r1 to 89-4342.0-1607944823-benchmark-89.0.4357.3-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I6c478891c4b21da4e4a4b289c5031c3b07fdf90e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597618Reviewed-by:
-
