GitLab

Previously the -webkit-line-clamp implementation didn't use the bottom
edge of the line-box, instead using the bottom of any content inside
it.

While simple in the old layout engine, this adds complexity for the
Firefox compat implementation, as well as an implementation on
LayoutNG.

Additionally Google front-end engineers are requesting we try and fix
this issue.
(see bug).

The added test relies on the implementation of text-overflow to behave
the same.

Bug: 937931
Change-Id: I3cac20dc79e2487da59cd28ac453f900d4898f21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495439
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638018}

The flag still had the old "HTTPBadPhase3" trial name, which was causing
a DCHECK failure due to the conflict between the old field trial name
and the new "HTTPReallyBadFinal" field trial name.

Change-Id: I563ec74b1005aa360168d3ee918fdd3be5252d56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500024Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638017}

Currently, when the uninstall dialog is opened from the Launcher, the Launcher
is dismissed, which is confusing to the user. By parenting the dialog to the
Launcher, the UX is much better.

Because we cannot directly access Ash windows anymore, this fix requires us to
explicitly set the dialog's parent window via MUS properties.

TEST=manually verified + new browser tests
BUG=814619

Change-Id: Ic25cb376191aaba8048f95fa5d0032b0328b8bc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496447Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638016}

If activity control consent has not been accepted, launch the Assistant
opt-in flow instead of voice enrollment flow.

Bug: None
Test: Manual Test
Change-Id: I3960715e17422b11c073942575c96557c2747112
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500849Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638015}

Some devices could not reach 30 FPS for 2160p (4K, UHD) h264/vp8
encoding. Since we want to gather FPS performance data from devices
which have 4k encoding capability, we disable the check of FPS larger
than kMinPerfFPS, and just a warning log instead.

BUG=chromium:927277
TEST=video_encode_accelerator_unittest on Eve and Caroline

Change-Id: I3ff3fac117a6423d5e5949e49920ec6f3428410e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503178
Commit-Queue: Pin-chih Lin <johnylin@chromium.org>
Auto-Submit: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638014}

Quickview used an icon for the 'Open' action which is different
to the 'Open' action in the main File Manager view.

This CL changes the icon to the internationalized label for
consistency.

Bug: 762628
Change-Id: I059014dcead85028227b10a86ff75e2289d8046d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504596Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638013}

Disabling:

QuartcEndpointTest.ServerAcceptsOldVersion
QuartcEndpointTest.ServerNegotiatesForOldVersion

Culprit CL could not be reverted due to merge conflict, so disabling
tests instead.

TBR=vasilvv@chromium.org,rch@chromium.org
NOTRY=true

Bug: 938773
Change-Id: Id0c78e8d88519de1cfe62e2e5822e5b7db236f9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504598Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638012}

Selecting a file and then dragging the splitter to the left
as far as possible causes the 'Cancel Selection' text to be
cropped and the end replaced by an ellipsis.

This change adds a tooltip so that hovering over the button
will show it.

Bug: 814273
Tests: Added test for this tooltip.
Change-Id: I22465b933f562261c661add50bf336cf244fab81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502256Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638011}

Apply new review comments to the original CL more. This CL makes to use alternative ones
instead of LocalFrame in the first argument of UseCounter::Count.

Bug: 936187
Change-Id: I432a68708af7280c997fb5e2d61a7774eb8d2a99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498735
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638010}

As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates
some classes of //third_party/blink/renderer/platform/network with the macros of
Allocator.

After some analyzes, it was concluded that for the case of ServerTimingHeader,
EncodedFormData classes, they make sense to use USING_FAST_MALLOC because they have
been used as a member variable with new() or smart pointers.

Lastly, the rest of classes this CL annotates make sense to use STACK_ALLOCATED.

Bug: 919389
Change-Id: I01489ed3ccc1f4e2b61850d3ebfc930431c59290
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504476Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#638009}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb71e01e26d0..f5f6e3c40e44


Created with:
  gclient setdep -r src-internal@f5f6e3c40e44

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org

Change-Id: I01022ddbfc8972d3f7353f6760b0a8b12a03bdbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504973Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638008}

Add counters to investigate
 - if 'textarea' and 'searchfield-cancel-button' can be unexposed
 - if 'textfield' can be limit to textfield input types and temporal
   input types.

Also, improve Menulist*ForOthersRendered counters. They should exclude
input[type=color][list] and temporal input types on Android.

Bug: 892586
Change-Id: Ic209f1d64be21a28f0f059ec8928e733368c8fa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503173Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638007}

The primary motivation is that the function argument is not following
the snake_case naming convention. As per current implementation
function argument names in *probes_inl.h follow |paramFoo| naming
convention. This CL modify build_param_name() in
make_instrumenting_probes.py to rename function argument names to adopt
|param_foo| naming convention.

Bug: 936684
Change-Id: Idb63f1e6b78c98bb1830e74165b6cc69a8515a94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503179Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#638006}

BookmarkAppHelper supports concurrent installs:
many instances of BookmarkAppHelper can be created at call sites.

Example: You can open 3 browser windows, initiate an install in each of them.
And you see 3 modal dialogs to accept/dismiss.

Bug: 915043
Change-Id: Ib7c1422bf341a43f4b45a82aa3204eb29c572369
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498795Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638005}

In the chrome://management page, the "Safe browsing" text that appears
in the browser reporting section is now a link to the safe browsing
page.

Bug: 936558
Change-Id: I88cc056e19b1cde29ae62cbd7e450cfb5fc8c6a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492731
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638004}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I142d4e8a8d2a79e9236b0d3aaca73675b8be0b2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504843Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638003}

This CL fixes permission toggling which had an erroneous assert, and
adds a regression test.

Bug: 906508
Change-Id: Ie026ac246c48b19290da5784199c6a8d75c71e89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502259
Auto-Submit: calamity <calamity@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638002}

Before this patch, encodedBodySize [1] and decodedBodySize [2] fields of
navigation / resource timing entry for Signed Exchanges were not
populated.

After this patch, these fields will have the sizes of Signed Exchange's
inner response body, before and after decoding mi-sha256 encoding.

[1] https://www.w3.org/TR/resource-timing-2/#dom-performanceresourcetiming-encodedbodysize
[2] https://www.w3.org/TR/resource-timing-2/#dom-performanceresourcetiming-decodedbodysize

Bug: 928589
Change-Id: I6b7800497e411822172dea4769ab8fc9d4955b53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496261
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638001}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=abdulsyed@chromiue.org

Change-Id: I7227a29e99627145b19288ab8e0615570a53a9bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505114Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638000}

It turns out PrepareForDrag calls into CaptureController via
ScopedWindowResizer which inspects the gesture state. Transferring the
events earlier avoids us from receiving gesture cancelled events.

	not moving anywhere.

Bug: b/124026845
Test: Drag-to-move via touch of an Android PIP window works instead of
Change-Id: Ib1a4bb5c09bff6d9529805e0a778c10f5dcaf852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498803
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637999}

Refactor QuicFramer connection ID read code

This CL refactors how we read connection IDs to allow future changes
that will use different default lengths based on what is configured for
this connection.

Merge internal change: 236935043

https://chromium-review.googlesource.com/c/1504509/

Make a test involving connection IDs more future-proof

Merge internal change: 236924820

https://chromium-review.googlesource.com/c/1504508/

Remove some fixed packet lengths.

This CL moves us yet another step closer to being connection ID length
agnostic in the lower layers such as the QuicFramer. More specifically,
it replaces instances of PACKET_8BYTE_CONNECTION_ID with
connection_id.length(). This is safe to use without flag protection
because we have code in all connection ID entry points to ensure that
their length is 8.

Merge internal change: 236894613

https://chromium-review.googlesource.com/c/1504506/

R=rch@chromium.org

Change-Id: I488160120ad125ff342e5983cba22946dc437183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504510
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637998}

This reverts commit 108146f8.

Reason for revert: See https://bugs.chromium.org/p/chromium/issues/detail?id=938020#c6

Original change's description:
> Fix flatbuffers_unittests failure-mode
> 
> This is failing on Win7 Tests (dbg)(1):
> https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29?limit=200
> 
> Failures are causing python errors because the "failures" element must be a list.
> The actual cause of the failure is not yet known.
> 
> Bug: 938020
> Change-Id: I53742dbf49f97a8828af5675a0360e431ed376c8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503614
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Charlie Harrison <csharrison@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#637839}

TBR=dpranke@chromium.org,csharrison@chromium.org

Change-Id: Iebb35ee8e42272f742497b25713d0927fb00ff14
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 938020
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504597Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637997}

This makes the blacklist behave identically to the |BlockedSPKIs|
member of the CRLSet.

Formerly, the blacklist had been applied after path building, which
meant that the path builder did not have the opportunity to favor
paths that did not include blacklisted certificates.

If any such cases exist, this change might cause them to be newly
accepted.  It should not cause any certificate chains to be newly
rejected.

TBR=mmenke

Change-Id: Idd6c4d5b5725497f951e749159cd58fd0413b444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497387
Commit-Queue: Matt Braithwaite <mab@google.com>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637996}

This CL makes the PWA install plus icon animate in with an "Install" label
once installability checks pass for a site.
The frequency of this animation is not yet decided by UX and is subject to
change.

Screencast of animation: https://bugs.chromium.org/p/chromium/issues/attachment?aid=382575&signed_aid=0ZIH354P-QQs-3Fnl4CVEg==&inline=1

This icon is hidden behind the --enable-features=DesktopPWAsOmniboxInstall
flag.

Bug: 907351
Change-Id: Ie74b037533a67f2c00ddd5689df4dbd98ece83cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502313
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637995}

TBR=droger@chromium.org,lwchkg@chromium.org,msarda@chromium.org
NOTRY=true

Bug: 938707
Change-Id: I3b421e177f303135d633987d5429eaada474243a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504656Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637994}

TabFavicon is Tab userdata that provides API for the active
web contents' favicon. This was a part of Tab class but
factored out into its own class.

Bug: 877878, 925242
Change-Id: I49eba08918a2a86985f2b8aea5d4c7e15d666108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482434
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637993}

Update EmbeddedWorkerInstanceHost to use the
blink::mojom::ConsoleMessageLevel enum, rather than an int32. This also
percolates out to the ServiceWorkerVersion, ServiceWorkerContextCore,
and ServiceWorkerContext observer classes, and the
content::ConsoleMessage struct.

Bug: None
Change-Id: I1e392ae7ab5ca2ff679c30057d45817358d3bbf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501498
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637992}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8f4140a12eb..bb71e01e26d0


Created with:
  gclient setdep -r src-internal@bb71e01e26d0

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org

Change-Id: I4c8a00702f7f54f824a1ffb549b6ac81a1aa4a94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504933Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#637991}

Currently, Roselle trains on app IDs as-is. However apps clicked from the
launcher chips or search box have the format "[scheme]://[id]/" while apps
clicked from the grid have the format "[id]". This adds a normalisation
step so Roselle always trains on apps with IDs of the form "[id]".

Code adapted from: https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/app_launch_event_logger.cc?sq=package:chromium&g=0&l=171

Bug: 938706
Change-Id: I6af4366dc70538f909b467bdf12948d3db0d8db3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501774
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637990}

Now that the implementation is mojofied, there is no need for this class
to keep track of running workers.

Bug: 931084
Change-Id: Ie8b21af1561f7939453e8f95793da4152076ec06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504653
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637989}

 - Modify js_externs_generator_test.py to add "@typedef {Object}"
 - Mark optional parameter as optional in bookmarks_manager_private.json
 - Move incorrectly placed annotation in c/b/r/bookmarks/store.js
 - Re-generate bookmark_manager_private.js and add a note at the top of
   that file, about manual edits required.

Bug: 717828,717827
Change-Id: I69639a800d7aabb1bbe5e8885efce487f9414409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499778Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637988}

This can return null per issue 817691. We only recently started getting crashes for
it being null for navigation preloads. It's possible this is due to
r636598 which allowed extensions to intercept nav preload requests.

Bug: 938639
Change-Id: I03149fa3c61234714611c272e4fa783948f2bf5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504594
Auto-Submit: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637987}

Bug: 803584
Change-Id: I189c280a19e9c6a591af6b6ee0e8a37e2abb020d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490497
Auto-Submit: Ian Wells <iwells@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637986}

Part of an effort to remove EmbeddedWorkerRegistry which shouldn't be
needed since mojofication. Shutdown() sent a Stop IPC on each worker
when the registry is destructed, which happens only during browser
shutdown or a fatal error with the service worker system. The Stop IPC
is not needed since ServiceWorkerContext is also destroyed in this
case, which means all hosts are destroyed and the Mojo connection to the
workers are destroyed. The workers in the renderer processes
detect the destroyed connection and terminate.

I thought this might affect the ServiceWorker.WorkerStopped UMA,
but it shouldn't because the registry is refcounted and owned by
EmbeddedWorkerInstances, so it doesn't destruct until those are
already destructed, so no host is alive to record the UMA.

Bug: 931084
Change-Id: Id8c92f59e6602e7d95bf876858f4b771bed19636
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504472Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637985}

Bug: 933791
Change-Id: I987b1e0732d208c54bcfd0434408f1f0c4bad6a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497334Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637984}

App lauches are already being logged from the launcher grid
and launcher suggestion chip. Launches from launcher
recommendations are being missed in the UKM logging.
This will fix that.

Bug: 889123
Change-Id: Icbd6a966011b9cc5e50cef692cac7822d5501cf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498260Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Paul Dyson <pdyson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637983}

This change lets Chrome talk to the production image annotation server.

It also includes a bugfix: the experiment feature is changed from
constexpr to const, as suggested here:
https://cs.chromium.org/chromium/src/base/feature_list.h?l=33&rcl=9d2ac606c7193521bef66585a5209fa562d209c4

Bug: 916420
Change-Id: I5fe8f87d4b8b7b8101931476d19e1aecd0d0c8a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504655
Commit-Queue: Michael Martis <martis@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637982}

WebConsoleMessage::LogWebConsoleMessage() and
WebLocalFrameImpl::AddMessageToConsole() used a fair amount of the same
code, as both were mutating a WebConsoleMessage into a ConsoleMessage,
and then logging it.

Restructure this by adding a ConsoleMessage::FromWebConsoleMessage()
method that can be used by both WebConsoleMessage and WebLocalFrameImpl.

Bug: None
Change-Id: I7a0ff42411f5e950452c86ecde7e58bb4976d7ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501497
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637981}

This CL updates hosted app menu buttons to be a circle instead of a
squircle. This matches the main browser app menu button highlight shape.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=382151&signed_aid=8nMn1jvoQMiuwbo9hYOZnw==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=382152&signed_aid=dqni06i4dkv3UxZYxCF6FA==&inline=1

Bug: 918093
Change-Id: I9137331b23047570a1a7becd97ee6be6a04d0abe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496399
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Jay Harris <harrisjay@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637980}

We’ve added Finch flags for Arc App Shortcuts. This CL adds unit tests to ensure the behaviour of the ranker with Finch flags:
1. Doesn’t change the scores when the flag is disabled.
2. Improves the scores when the flag is enabled.

Bug: 931149
Change-Id: I4368bfbae0b1b2862f354469028c028f74cefabf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501892Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Thanh Nguyen <thanhdng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637979}