- 17 Mar, 2020 40 commits
-
-
dpapad authored
The latter is a better name for the contents of that file, as it is no longer a Polymer behavior. Also re-running clang-format. Bug: None Change-Id: I1e638271b5d973c426d392ee3fc9dbd7e0114bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107055 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#751160}
-
Sahir Vellani authored
In order to correctly snap box sizes to pixels using SnapSizeToPixel, the function FragmentData::PaintOffset() needs to be used. This function provides an accurate location/offset of the box in question. However, this the paint offset is determined in the PrePaint lifecycle phase. To accommodate this, LocalFrameView::NotifyResizeObservers is moved to LocalFrameView::UpdateLifecyclePhasesInternal. In addition, UpdateLifecyclePhasesInternal is refactored so that all lifecycle steps prior to paint are run in a loop. The loop is broken when one of the following 3 conditions are met: 1) the target state < kPaintClean 2) No changes to layout are pending 3) Resize observer loop limit is reached Resize Observer can now observe changes to the device pixel content box. ResizeObserverEntry now reports the dimensions of the pixel snapped content box. Bug: 1055579 Change-Id: Ibc7b2e4e0a8468f9af74c8cfaadd02e4f0bcfc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071575Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751159}
-
yilkal authored
This cl adds a space after "set for Chrome." in the per app time limit interstitial error page. Bug: 1061620 Change-Id: Ib84175aeb057ae31b7b45259d1cb81e984477821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107813Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#751158}
-
mark a. foltz authored
This patch closes a Cast virtual connection between a client and a session in two cases: 1. The corresponding PresentationConnection is closed by the renderer. 2. The client sends a "leave session" message. Case #2 could be implemented by #1, but for now, they are both supported for backwards compatibility. Bug: 1059053 Change-Id: I4bfaf5fd4a49adc16980f9ef12b2502c308c1770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099606Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#751157}
-
Mary Ruthven authored
BUG=b:151657331 TEST=None Signed-off-by:
Mary Ruthven <mruthven@chromium.org> Change-Id: Ibf54fae72625c2e769bf518ba221c298ac74eaf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107804Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#751156}
-
Eugene Zemtsov authored
1. Testing that VideoRendererAlgorithm sets frame duration metadata 2. Testing VideoFrameSubmitter correctly calls VideoPlaybackRoughnessReporter This is a follow-up CL for the 2 previous CLs related to the same bug. Bug: 1042111 Change-Id: I47bb5804549dacb9e613ab40f0859cc618e489c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107174Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#751155}
-
Chong Gu authored
Bug: 1058255 Change-Id: I0a8063778458788eceaea0ef036453d42a83aeb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107606Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#751154}
-
Antonio Gomes authored
The target interface is the newly added blink.mojom.FrameWidget (//third_party/blink/public/mojom/page/widget.mojom), chosen after analyzing the call stack of RenderViewHostImpl::SetBackgroundOpaque(). BUG=1047469 R=dtapuska@chromium.org Change-Id: I0ed21a4da2d2d28734ae98990840578098683613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102510 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#751153}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/beefcb9d38c0..56015e01150e git log beefcb9d38c0..56015e01150e --date=short --first-parent --format='%ad %ae %s' 2020-03-17 fmalita@chromium.org SkStrikeCache: only validate post-purge 2020-03-17 csmartdalton@google.com Remove DynamicStateArrays from GrProgramInfo and GrPipeline 2020-03-17 csmartdalton@google.com Migrate GrFillRectOp and GrTextureOp to the new bind/draw API 2020-03-17 kjlubick@google.com Add fiddle demonstrating alpha when used on saveLayer Created with: gclient setdep -r src/third_party/skia@56015e01150e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: I36f6124e0e56fe3f34c25b10f0dd34bd20871ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107788Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751152}
-
Vasilii Sukhanov authored
Mocks: https://docs.google.com/presentation/d/1yWuZO-fjXhdRp64nWRbnHEyzpFd1KOMS3u1_1XMdGuA/edit#slide=id.g76725620de_2_26 Bug: 1049200 Change-Id: I6383aca4cf0e7abc8552d0f83072440f7384e43b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106054Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#751151}
-
Danyao Wang authored
The feature was landed a while ago. This CL adds missing browsertests. Bug: 922683 Change-Id: I798bcea5acee34c55c887464509684827a05b6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103442Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#751150}
-
Rainhard Findling authored
Replaces all instances of |#| as the numeric placeholder in pluralization strings with the new |{NUM_...}| format, as outlined in go/icu-message-migration. Change-Id: I2c5fb78cc93369b0e7f6e0365d7edef8eea32368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106171 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Auto-Submit: Rainhard Findling <rainhard@chromium.org> Reviewed-by:dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#751149}
-
Kevin Marshall authored
Implements the class which reads changes from base::Histograms and serializes the differences as FIDL data (fuchsia::legacymetrics::Histogram). Bug: 1060768 Change-Id: I961e5dc3d05b898426c5159512de8c90f155a653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100938 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751148}
-
Robbie McElrath authored
This is a reland of b2882c21 with changes so Clank doesn't break. Original change's description: > [WebLayer] Move browserservices.Origin to //components/embedder_support > > browserservices.Origin is used by Chrome's site settings page, which > is being componentized so it can be used by WebLayer. This CL moves > the class to //components/embedder_support. > > Bug: 1058597 > Change-Id: Ic47da47f372d1c27238efd2fee8d7bdcba6eb63d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090875 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750294} TBR: twellington@chromium.org, jdoerrie@chromium.org Bug: 1058597 Change-Id: If7a301e851d8f8eca963532cada83dadbc6622e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105398 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#751147}
-
Yue Zhang authored
This reverts commit fb08e564. Reason for revert: Workaround introduced didn't fix the crash. Original change's description: > Fix a crash in pop-up tab strip > > In the popup TabStrip used by Duet-TabStrip integration, there is a > crash in RecycleView when user very intensively clicks on the TabStrip > favicon to close multiple tabs. The stack indicates that the > recyclerView is trying to remove the same ViewHolder in two consecutive > remove operations, and the second call would crash. The fix introduced > in this CL is to early end the animation if we know for sure that this > item is going to be removed. This should help with better identifying > the ViewHolder to remove. > > This fix is inspired by the discussion here: > https://b.corp.google.com/issues/34184109 > and the CL here: > https://critique.corp.google.com/#review/188055979/depot/google3/java/com/google/android/apps/play/music/app/ui/common/MediaListRecyclerFragment.java > Even though we early end the animation, there should be no visible > animation change from the UI perspective. > > Bug: 1045944 > Change-Id: I0d8a7b098e17cdc86c4ae3227cd9dc1ba37b2adc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036874 > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738392} TBR=yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1045944 Change-Id: I733bc7729f9118808999e59695ae01b7194ef0e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107120Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#751146}
-
rbpotter authored
- Add lazy_load.js for Polymer 3 settings and an ensure_lazy_loaded.js file to perform the import. - Update build rules to generate multiple modules - Update tests to import lazy_load.js as appropriate - Add rewrites to BUILD rules to import correctly, and add a dummy ensure_lazy_loaded.html so that the import can be generated by the autogenerator. Bug: 1026426 Change-Id: I6ed01d9a414f8a464d88a5d88aa8f63f7233899d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102082Reviewed-by:
-
Tricia Crichton authored
When getting cookies, Convert cookie expiration to int64 for compatibility with SetCookie, which rejects an expiration set as a double. Bug: chromedriver:3331 Change-Id: I911ff6169ec9ed5efaaa01ff76f7a846733d7f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106736Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#751144}
-
Rouslan Solomakhin authored
Before this patch, "Lollipop Phone Tester" bot running on Nexus 5 timed out while firing the "paymentrequest" event as seen in the error log attached to the https://crbug.com/1061574. This patch disables the minimal UI confirm test on Android L. After this patch, the minimal UI confirm test passes on Android P and K bots, Android Q Pixel 3 local physical device, and Android K emulator. The test also passes on desktop, but that's because Chrome on desktop triggers a skip-UI flow and the payment handler returns the response without showing its own UI. Bug: 1061574 Change-Id: I7be60e761061285170efdcdb30a3f562133e6530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105774Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
-
Jonah Ryan-Davis authored
Chrome expects libvulkan to be statically linked within ANGLE, so these tests were failing. Wait until we update the build to statically link before we re-enable these tests. Bug: angleproject:4477 Change-Id: Ia5f5f3ac6dd0f210b7770be2863b4d1174143cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106566 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#751142}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/639a4bf5ff46..5efb965c1b4d $ git log 639a4bf5f..5efb965c1 --date=short --no-merges --format='%ad %ae %s' 2020-03-17 dschinazi Do not use iterators in ParsedQuicVersionIsValid 2020-03-17 dschinazi Improve QUIC TLS error logging 2020-03-17 bnc Add test for default return value of QuicSpdySession::server_push_enabled(). 2020-03-16 bnc gfe-relnote: Switch from closing the connection to QUIC_BUG in two ShouldCreateIncomingStream() overrides when called with locally initiated stream ID. Protected by gfe2_reloadable_flag_quic_create_incoming_stream_bug. 2020-03-16 wub gfe-relnote: In QuicBandwidth::FromBytesAndTimeDelta,do multiplication before division to make rounding error less likely. Not protected. 2020-03-16 dschinazi Have ParsedQuicVersionIsValid also validate transport versions 2020-03-16 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_batch_writer_flush_after_mtu_probe. 2020-03-16 dschinazi Prevent crash when trying to serialize packet with missing encryption key 2020-03-16 bnc gfe-relnote: Disable server push. Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-03-16 quiche-dev gfe-relnote: reset has_non_app_limited_sample in QuicConnectionStats to false once handshake is complete. Logging only change, not protected. 2020-03-16 dschinazi Fix QuicVersion MSVC compilation for Envoy 2020-03-16 wub gfe-relnote: (n/a) Add 2 connection options for BBRv2 to disable 1) adding ack height in queueing threshold, and 2) avoiding unnecessary PROBE_RTTs. Not protected, just more switches for already existing behaviors. 2020-03-16 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_check_handshake_timeout_before_idle_timeout. 2020-03-16 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_set_send_algorithm_noop_if_cc_type_unchanged. 2020-03-16 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_no_window_update_if_disconnected. 2020-03-16 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_neuter_unencrypted_control_frames. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src add/delete flags R=zhongyi@chromium.org Change-Id: I990459757848577d6f839306a8fec48d389fb6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106555Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#751141}
-
Jarryd Goodman authored
Screenshots attached on crbug. Bug: 1062306 Change-Id: I9a086a09e3d6b1a738bfa6f8bff5b0a075f930b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106492Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#751140}
-
Manu Cornet authored
This is now superseded by documentation in ash/shelf/README.md Change-Id: I86bac092939cb87d7a9659a2b5775d45fa5f57b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106803Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#751139}
-
John Budorick authored
This reverts commit d8c37dee. Reason for revert: spec revert for https://bugs.chromium.org/p/chromium/issues/detail?id=1062423 Original change's description: > Add CertProvisioningWorker class > > CertProvisioningWorker class implements core logic for building > a CSR with DM server and importing corresponding certificate. > > Bug: 1045895 > Test: CertProvisioningWorkerTest.* > Change-Id: Ida540f2b330d0dac9e86f53568f29287559a1ad8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078582 > Commit-Queue: Michael Ershov <miersh@google.com> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750986} TBR=achuith@chromium.org,pmarko@chromium.org,miersh@google.com Change-Id: I06d5c2889f05563980a20b42ff00c635da5677db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107394Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#751138}
-
Istiaque Ahmed authored
This CL makes FrameTracker within ExtensionMessagePort observe worker shutdown, and remove FrameTracker's entry to that worker. Without this CL, FrameTracker would hold onto stale workers that was shut down and trying to send IPC to it (ExtensionMessagePort::SendToIPCTarget) would cause browser crash, because of nullptr RenderProcessHost. This CL adds a test for the regression fix. Bug: 1033783 Test: Repro in the bug does not crash anymore. Change-Id: I6906f84077834980568f4227121ae449b6e6ce0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106743 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#751137}
-
dpapad authored
There is no need for this functionality to reside within a Polymer behavior, and it is already being used a simple class in all call sites. This is in preparation of migrating c/b/r/settings/people_page/ to Polymer3. Bug: 1026426 Change-Id: I9dfbb7bbd2d496f4dcdb6c79df9291d238cae487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106916 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
-
Kurt Horimoto authored
Bug: none Change-Id: Iaf328b22a6fba65a1d9a6deb837f379cd9405b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088187 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#751135}
-
John Budorick authored
Follow-up to crrev.com/c/2107309 Bug: 1062289 Change-Id: Ibc8de590610fc36c6e7c4a9263c1ce0be9e79949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107707 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#751134}
-
Xida Chen authored
This CL removes code that is related to an un-necessary main frame no-damage notification. Bug: 1048164 Change-Id: I84e33cc0d3a8bb5ed1d1cf7aed95f3fd7f621932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096761 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#751133}
-
Jacques Newman authored
NearestTextIndexToPoint should not be called on anything other than leaf nodes, as it checks against each character in the inner text of the node, causing hangs if called far up the tree. To remedy this, a new API was created: "NearestLeafToPoint" This gets the nearest node to a given point, utilizing HitTestSync to scope the search. Bug: 1057680 Change-Id: I1c167bc28c6666ba79a02dc802d6ba089cd7425c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080788 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#751132}
-
Will Harris authored
This matches behavior on macOS. BUG=1050905 Change-Id: I29ce0f7e7f02377a25ad0fb9b15f7a6373410fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106478Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#751131}
-
Jack Lynch authored
This CL disables command-menu.js so that this CL can land: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2101972 Bug: 174309 Change-Id: I896f2aaba9b9d52f821a627537e690a1947173c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107812Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751130}
-
Sasha McIntosh authored
This partially reverts commit 8af6f946. Relands PIXEL_FORMAT_UYVY and resets the optimal pixel format in AVFoundation to UYVY. This fixes the link bug in which camera capture with resolution lower than 720p appears to have a dropped framerate on Mac. Verified fix by visiting https://webrtc.github.io/samples/src/content/devices/input-output/ and selecting an attached usb camera. Bug: 1035077,1027325 Change-Id: I7c3810c3382b4f4f8290210eec3ca5f8c9c4343a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068819Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#751129}
-
Jan Wilken Dörrie authored
This change implements updating the Password Check UI after each credential was checked. It makes sure to account for duplicates with regard to canonicalization of usernames and passwords and updates the progress accordingly. Bug: 1061500 Change-Id: I46d13e7e007f31596b6c67f9f3e56535cbc5e8a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106580 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#751128}
-
Daniel Rubery authored
Due to product decisions, this field should not be included. Bug: 1062298 Change-Id: I46986aec184f61b9af18a6debabd356cbebb9719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107713Reviewed-by:
-
Nate Chapin authored
While migrating ExecutionContext to LocalDOMWindow, several helpers were introduced on Document (From(), DynamicFrom(), ToExecutionContext()). This CL removes usage of these types from this directory. From() and DynamicFrom() are replaced with the standard downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(), or Document::GetExecutionContext(), whichever is most direct from the callsite. Also, ExecutionContextLifecycleObserver has a temporary constructor that takes a Document*. Switch users of that constructor to the standard ExecutionContext* constructor. Bug: 1029822 Change-Id: Id806fd4ba2b0565c9a4865e2293115c7249e1fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101537Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#751126}
-
Yue Zhang authored
This reverts commit f8d430ce. Reason for revert: This fix didn't eliminate the crash. Original change's description: > Skip popup Tabstrip update when opening tabs from background > > Currently, we use AnchoredPopupWindow#onRectChanged to force update > popup strip layout when new tabs are added. This could lead to a race > condition where RecyclerView tries to recycle a view that has been > temporarily detached due to the re-layouting process. This is only > reproducible when there is recycling happening, and when tab is added > from background. > > This CL bypasses this crash by disabling the force update for adding > tabs from background. Note that it is already a known issue that strip > is not properly updated when tab is added from background, so this > CL doesn't introduce any UI difference before/after. > > Bug: 1045944, 1050401 > Change-Id: I4d7ba97f53d41042867bea9562ce2e76aade118b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048988 > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741526} TBR=yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1045944, 1050401 Change-Id: I52434502ea7661361fcac3077869f45e485955be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075224Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#751125}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/1aa882626c3d..e43a73b009bd git log 1aa882626c3d..e43a73b009bd --date=short --first-parent --format='%ad %ae %s' 2020-03-17 thakis@chromium.org Fix two -Wunreachable-code warnings. Created with: gclient setdep -r src/third_party/openscreen/src@e43a73b009bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:346399 Tbr: jophba@chromium.org Change-Id: I8628d27e3bf5b60aabefc58d00f117c16bce017e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107784Reviewed-by:
-
Nicolás Peña Moreno authored
This CL replaces base::Bind() with BindOnce or BindRepeating in the chrome/renderer/net folder. Two occurrences are in parameters for AddInterface(), which receives a repeating callback and it makes sense to have repeating callbacks there. The other one is for a timer where BindOnce suffices. Bug: 1007641 Change-Id: Id2d3df19c699b881c492a1a3402bb60dcaa7dd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107803 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#751123}
-
Dave Tapuska authored
In preparation for moving compositing into blink move UpdateVisualState into WidgetBase. This callback will eventually be called directly from the LayerTreeView inside blink. Change-Id: I32b6bdc74b778d6a5b60a20f44f6e51036020079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103507Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#751122}
-
Guido Urdaneta authored
This CL moves the command-line switch from CaptureStreamRenderProcessHostTest to its parent, RenderProcessHostTest. Some RenderProcessHostTests use audio and are still flaking. Bug: 986021 Change-Id: Ic1327890183433ef9dd737d7c8d649560e5a981f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107540 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
