- 19 Jan, 2018 40 commits
-
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: Ie46fec9026e797b25f4f1d0784f71df561f36e15 Reviewed-on: https://chromium-review.googlesource.com/874851Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#530421}
-
dpapad authored
Before this CL 1) for each user interaction there were 2 JS->C++ messages, instead of just 1. 2) the C++ call was made only after the drawer animation finished, which created a race condition between the inDevMode boolean and the toggle's state. Now it happens as soon as the user clicks. 3) The height of the cards was snapping after the toolbar animation finished. No longer the case. The height of the cards animates at the same time with the toolbar. This simplifies the logic a bit, and unblocks porting the PolicyTest.DeveloperToolsDisabledExtensionsDevMode to the new UI. Bug: 803326 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4f2995bc322f619fbc8fad812dd03344e895391c Reviewed-on: https://chromium-review.googlesource.com/874775 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#530420}
-
Jinsuk Kim authored
This fix a potential bug that can happen, based on the crash report https://crbug.com/803244. It was not taken into account when landing https://crrev.com/c/867177. Bug: 803244 Change-Id: I99c4d927cc69567efae619622ce8baf434cc332b Reviewed-on: https://chromium-review.googlesource.com/874976 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#530419}
-
Yaron Friedman authored
As a follow-on to https://chromium-review.googlesource.com/776162 since we need a copy of the runtime library for fallback behaviour in the ShellApk, we should just expand this once and check it in. This avoids the problem where any change to the aidl for the runtime library requires the shell apk to also be updated. Bug: 700228 Change-Id: Ib2a2db8980f27813a552a8d8a9783cadbdb1be39 Reviewed-on: https://chromium-review.googlesource.com/797292 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#530418}
-
Miguel Casas-Sanchez authored
This CL extends gl_image_io_surface_unittest.cc to try a few more formats and addresses the strange situation of RGBA_8888 being handled as an BGRA by writing a significant comment. Also: better logging and comments in gl_image_io_surface.mm and gl_image_test_support.cc. Bug: 803473 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I630a4bee5cd1003d4b10da8dece4dadcced63bed Reviewed-on: https://chromium-review.googlesource.com/874898 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#530417}
-
Javier Fernandez authored
There were several discussions to avoid ambiguities with the complex values, specially when it comes to define the place-xxx shorthands. One of the sources of problems is the 'overflow-position' keyword. The CSS WG has decided to change the syntax of all the CSS Box Alignment properties so that the 'overflow-position' keyword always precede the 'self-position' or the 'content-position' keywords. https://github.com/w3c/csswg-drafts/issues/1446#event-1125715434 In order to apply this change to the Content Distribution properties' (align-content and justify-content) syntax I had to completely re-implement their parsing function. Thanks to this I addressed also the issue with the content-distribution fallback, which cannot be specified explicitly now. https://github.com/w3c/csswg-drafts/issues/1002#ref-commit-c38cac4 Bug: 802098, 802247 Change-Id: I57315a475940c00d0c0dafbb4f1b32a2c6c1ff68 Reviewed-on: https://chromium-review.googlesource.com/868531 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
meade_UTC10 <meade@chromium.org> Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#530416}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0e7a30e1. With Chromium commits locally applied on WPT: e8a79119 "Fixed wpt csp reporting tests and moved over chrome internal ones" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/10313 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kpaulhamus@chromium.org: external/wpt/webauthn TBR=kereliuk No-Export: true Change-Id: I29fa2d57b9501f8bbe77eb13a18dd8c7864db988 Reviewed-on: https://chromium-review.googlesource.com/875350 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#530415}
-
Peter Kasting authored
The Harmony spec removes periods when a control has only one phrase or sentence. This applies even when there is a trailing button, e.g. "Do something [OK]". BUG=686285 TEST=none Change-Id: I9de4da4cdf94c1e19d86e2c18877e51dc1344e0e Reviewed-on: https://chromium-review.googlesource.com/875171 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#530414}
-
Alan Cutter authored
Change-Id: I8616c8b57f7cd04475bd720760d5f71a1ba3b849 Reviewed-on: https://chromium-review.googlesource.com/874973Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#530413}
-
Bill Budge authored
This reverts commit 348c758d. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland [partition_alloc] Allow 2 GiB direct mapped allocations. > > - Raises the limit of direct mapped allocations. WASM needs > to be able to allocate 2GiB regions. > > Bug: chromium:801604 > Change-Id: I77e905ff4ae6f5ca66de9daf30f19bb6f7b54089 > Reviewed-on: https://chromium-review.googlesource.com/875301 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530380} TBR=bbudge@chromium.org,haraken@chromium.org Change-Id: I4462f890182dcb523f15cb8289ca416b5d266578 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:801604 Reviewed-on: https://chromium-review.googlesource.com/875169Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#530412}
-
Evan Stade authored
Use NotificationDisplayService instead of MessageCenter in tests. Bug: 783018 Change-Id: I2bc849e90f5f899144d015c83755f8eade62e185 Reviewed-on: https://chromium-review.googlesource.com/867291 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#530411}
-
Devlin Cronin authored
ExtensionScopedPrefs is an object that provides a more limited set of methods than ExtensionPrefs. However, it is only used in a small handful of places, only has a single implementation (ExtensionPrefs), and has no way of retrieving itself as a KeyedService (ExtensionPrefs::Get returns an ExtensionPrefs*), which means that it also doesn't reduce any set of required dependencies. Remove the class, and make the few callers that knew about it use ExtensionPrefs. TBR=benwells@chromium.org (c/b/ui/app_list) Bug: None Change-Id: Ifcfc8e657a698e16bb44e898913246ee452e0894 Reviewed-on: https://chromium-review.googlesource.com/857839 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#530410}
-
Xu Xing authored
TODO(crbug.com/803286): npot texture always return false on ubuntu desktop. The npot texture check is probably failing on desktop GL. BUG=802924, 803286 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I8f2dc179f065f1fa59650184c59d6184e293fbfd Reviewed-on: https://chromium-review.googlesource.com/869952Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#530409}
-
Devlin Cronin authored
Extension APIs and API objects can potentially be accessed after the context is invalidated (e.g., if a parent frame stores a reference to a child frame's API object, then removes the child frame, then tries to use the API object). We don't support this because we require a valid ScriptContext. Expand the checks we have in place for this to include all the custom API types (StorageArea was previously handled, but expand to ContentSetting, ChromeSetting, and EasyUnlockPrivate), and add a common method to check context validity and throw an error if the context is invalid. Update the checks in APIBinding when we are accessing an API method or retrieving an event as well. Add tests for all of these instances - custom chrome API objects, API methods, and API events. Bug: 653596 Change-Id: Ifca7694fbd6c78260a015231f19fc241e5a39b8a Reviewed-on: https://chromium-review.googlesource.com/869375Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#530408}
-
Marijn Kruisselbrink authored
These callbacks are only called once, so should really be OnceCallback rather than Callback. Bug: none Change-Id: Ia8b15a328db8f7949402bd7b6a737a578fba01dd Reviewed-on: https://chromium-review.googlesource.com/874953 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#530407}
-
agrieve authored
This reverts commit e23729f3. Reason for revert: Probably causing other crashing (see bug) Original change's description: > Fix crash when switching back from Samsung DeX to Phone mode. > > Regressed in d875cacb > > Bug: 780593 > Change-Id: Ifee7a93ada73f5b757a35ece75b0bef61ea767c2 > Reviewed-on: https://chromium-review.googlesource.com/820531 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Ted Choc (back but slow, ping me) <tedchoc@chromium.org> > Commit-Queue: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#527117} TBR=tedchoc@chromium.org,twellington@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 780593, 794551 Change-Id: Ia91f278b1dff52af4f4fc1bbd33743168dfb5e4a Reviewed-on: https://chromium-review.googlesource.com/874803Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#530406}
-
Fabio Tirelo authored
"Try Again" can be context-dependent in some languages, so this is to help translators, so it's important to indicate that it should have the same translation as in the button. Change-Id: I6a80d5b1dd444dba9bd05f052059e5f3caf76a00 Reviewed-on: https://chromium-review.googlesource.com/875112Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#530405}
-
David Valleau authored
https://chromium-review.googlesource.com/c/chromium/src/+/861956 Fixing link error caused by the free ParseUri function in printer_configuration.h not being exported properly. This reverts commit 68d7f4c6. Bug: 769893 Change-Id: I02a482272bf97e7166c221448dd2444bece00d03 Reviewed-on: https://chromium-review.googlesource.com/872265 Commit-Queue: David Valleau <valleau@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#530404}
-
Peter Kasting authored
BUG=none TEST=none Change-Id: I0b106db267d30d0ab083b107258f0964165917d2 Reviewed-on: https://chromium-review.googlesource.com/855823 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Buck Krasic <ckrasic@chromium.org> Cr-Commit-Position: refs/heads/master@{#530403}
-
Miguel Casas authored
This CL adds a FeatureInfo::FeatureFlags.chromium_image_xr30 to indicate that XR30 (aka BGRX_2101010) is supported, and propagates it to the context's gpu::Capabilities.chromium_image_ar30, and teaches a few other context-related classes about this format. Bug: 797347,776093 Test: unit tests and crrev.com/c/862326. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8794aa2a45eb47f4809eeee18a1fc3a3bfcce5ed Reviewed-on: https://chromium-review.googlesource.com/868172 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#530402}
-
Robert Flack authored
Add the initial documentation from our docathon effort. Bug: None Change-Id: I3f187565906bf696ba612cd1aa3fe7722fd44065 Reviewed-on: https://chromium-review.googlesource.com/874899 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#530401}
-
xdai authored
Bug: b/71640964 Change-Id: I4bc2f9809b187ff1eef2eea8c3ba168fc96cd6ba Reviewed-on: https://chromium-review.googlesource.com/875236 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#530400}
-
Alex Newcomer authored
In CrOS, we don't always want to use harmony settings by default. This is a quick fix that makes textfield use the set placeholder text if it is set, otherwise we use the default or harmony aligned placeholder texts. TEST=manual Bug: 779717 Change-Id: I85e5ab2aed2786e54086706e76ec50e7e0ac3c14 Reviewed-on: https://chromium-review.googlesource.com/871175 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#530399}
-
Xu Xing authored
batched_returning_resources_, wants_promotion_hints_set_ to Display. IsLost, LoseResourceForTesting, EnableReadLockFencesForTesting to LayerTree. BUG=738190 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I01fce2d63aee57eccaced8a596869fa380f69bf7 Reviewed-on: https://chromium-review.googlesource.com/870173 Commit-Queue: Xing Xu <xing.xu@intel.com> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#530398}
-
Sean Kau authored
We use constexpr now. Bug: None Change-Id: I305ac8ef63c4a5a0d7b789b9e5ec8dd58c860a4f Reviewed-on: https://chromium-review.googlesource.com/875254Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#530397}
-
Kenneth Russell authored
BUG=801578 TBR=nednguyen@google.com, perezju@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2087aef497af6211d0445fa7bc4a20fff73d5f80 Reviewed-on: https://chromium-review.googlesource.com/875329 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#530396}
-
Jinsuk Kim authored
Delegates almost all a11y-related tasks in CVC to WebContentsAccessibility, with a view to decoupling the two classes. The overall changes that moves APIS, backs WCAX up with WebContentsUserData is https://crrev.com/c/858985. Overview of the changes made for the move: - WCAX was created lazily, only when View#getAccessibilityNodeProvider() is requested from Android. Until then CVC used several flags such as |mNativeAccessibilityAllowed|, |mIsObscuredByAnotherView| to manage the state and condition under which WCAX gets created. This CL attempts to have WCAX encapsulate all these variables so it takes full control over all the a11y-related variables. For that, WCAX is now eagerly created in |CVC.initialize()|. What's being initialized lazily is its actual native accessibility activated by calling |nativeInit| in |WCAX.getAccessibilityNodeProvider()|. Before that, the instance keeps track of various internal states only. |WCAX.isNativeInit| can be used to tell the current state about native initialization. - |WCAX.onNativeInit()| was introduced to perform what had been done in WCAX ctor to enable full-fledged native a11y. Locale change receiver registration, for instance, was moved to |LollipopWCAX.onNativeInit|. - on{AttachedTo,onDetacheFrom}Window in WCAX now takes over what was done in CVC to update internal state such as adding/removing state change listener. - |mWebContents| referenced now in WCAX should be in sync with that in CVC. |CVC.mWebContents| stays valid until its |destroy| is called. Added a new method |WCAX.resetWebContents| for that. This is to keep the condition used in |WCAX.getAccessibilityNodeProvider| same as before, where null check against mWebContents is done. Bug: 598880 Change-Id: I101592b7b35042032007b4dae928f9fc06938961 Reviewed-on: https://chromium-review.googlesource.com/863082 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#530395}
-
Allen Vicencio authored
Implements ReadFile for SmbFileSystem. This will allow files to be read from the files app. Bug: chromium:757625 Change-Id: I3bae2b3c631ef78941a3f403f31c45c98afdf33a Reviewed-on: https://chromium-review.googlesource.com/848413Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Allen Vicencio <allenvic@chromium.org> Cr-Commit-Position: refs/heads/master@{#530394}
-
Vadim Tryshev authored
There are some possible cleanups around StartPageService and SearchResourceManager that I plan for a separate CL. Bug: 781407 Change-Id: I9c9042e46d792bf5cf06fb0dc1c29cd8f6edb560 Reviewed-on: https://chromium-review.googlesource.com/874812 Commit-Queue: Vadim Tryshev <vadimt@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#530393}
-
Hayato Ito authored
See the discussion at https://github.com/whatwg/dom/pull/336 for details. Blink implemented it at https://codereview.chromium.org/2384403002, however, it turned out that both the web platform test and the implementation were wrong. This CL fixed the implementation, as well as the web platform test. Compatibility risk is almost none about this change. Bug: 655494 Change-Id: I084cd6b748c304f5f2b395f0b62ba02025385a98 Reviewed-on: https://chromium-review.googlesource.com/869693Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#530392}
-
Xing Liu authored
Currently Mojo Android bot can successfully build but will yields NoDevicesError. The cause might be the builder targets arm64 where default device list is arm32. This CL adds the correct device dimension. Bug: 783374 Change-Id: Id5edc08a62d6c1b8a08dde179ae849f4c6511fd7 Reviewed-on: https://chromium-review.googlesource.com/875250Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#530391}
-
Eric Lawrence authored
Update the HSTS preload list with manually-requested entries. TBR=palmer@chromium.org Change-Id: I7aadcbc4da452dc918226112b3085afa70892a20 Reviewed-on: https://chromium-review.googlesource.com/875255Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#530390}
-
rbpotter authored
Bug: 792093 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I440a159be2cb7b1d393b041c3446349dfe8289fe Reviewed-on: https://chromium-review.googlesource.com/871511 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#530389}
-
Robert Ma authored
Importer is now trying to remove baselines for test with query strings in the names, e.g. https://chromium-review.googlesource.com/c/chromium/src/+/874798/1 We were lucky as the CL above didn't cause any actual damage (the rebaseline step added all removed baselines back), but it's too risky. Temporarily disable this feature before I fix it. TBR=qyearsley Bug: 800570 Change-Id: Id1f4b484badb7e2a651dbf6e37ccffe3d25fe7eb Reviewed-on: https://chromium-review.googlesource.com/874726Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#530388}
-
Jia authored
Bug: 784232 Change-Id: I72a9f20cbacba3a9dfc6b914094da573d61c6153 Reviewed-on: https://chromium-review.googlesource.com/874975Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#530387}
-
Karan Bhatia authored
This CL removes a duplicated dependency in a BUILD.gn file defined for DNR. BUG=696822 Change-Id: I29772cbd07a09bf630644c11ac977871896ca376 Reviewed-on: https://chromium-review.googlesource.com/875129Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#530386}
-
Simon authored
This way of sending try jobs is deprecated. Print an error message and redirect users to the docs on using Pinpoint. Running with trybot will produce this message: ERROR: This command has been removed. Please visit https://chromium.googlesource.com/chromium/src/+/master/docs/speed/perf_trybots.md for up-to-date information on running perf try jobs. Bug: 770009 Change-Id: I6c22aff02d76d56fad40b6fdaf167b16d22c3489 Reviewed-on: https://chromium-review.googlesource.com/874814 Commit-Queue: Simon Hatch <simonhatch@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#530385}
-
MinChen authored
[Reland]cros: Manual revert rename TabletPowerButtonController to ConvertiblePowerButtonController and create PowerButtonUtil. changes in this cl, Since we will put the logic of power button menu in TabletPowerButtonController instead of creating a new controller. Reverting related previous cls, 1. Revert rename TabletPowerButtonController to ConvertiblePowerButtonController. Related cl, https://chromium-review.googlesource.com/c/chromium/src/+/852518 2. Revert the creating of PowerButtonUtil. Related cl, https://chromium-review.googlesource.com/c/chromium/src/+/852905 Bug: 799524 Change-Id: I70eabc0436873149598c53c3caf3851958427a88 Reviewed-on: https://chromium-review.googlesource.com/875324Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#530384}
-
Alex Moshchuk authored
This is a followup to address https://chromium-review.googlesource.com/c/chromium/src/+/871523/3/content/browser/frame_host/render_frame_host_manager.cc#2036 Bug: 802156 Change-Id: I1f261f4e0ca26e8c700a13ad15a76027d681d39c Reviewed-on: https://chromium-review.googlesource.com/875243Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#530383}
-
Giovanni Ortuño Urquidi authored
This reverts commit 304ec7f2. Reason for revert: The original patch enabled the back button on all Hosted App windows. This included Desktop PWA Hosted Apps that had a manifest with display:standalone which explicitly requests for no browser controls. Reverting this change for now until we can disable the back button for Desktop PWA Hosted Apps. Original change's description: > Enable V1app backbutton by default > > Added about flag in case for troubleshooting. > > BUG=749713 > TEST=manual > > Change-Id: I2f74535282bb8dccca38a4d8ad6f10af88140c62 > Reviewed-on: https://chromium-review.googlesource.com/860522 > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#529074} TBR=msw@chromium.org,oshima@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 749713 Change-Id: I9d405002dc9061d42f4acb7575b4e7c08e8ce925 Reviewed-on: https://chromium-review.googlesource.com/874491Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#530382}
-