- 19 Dec, 2019 40 commits
-
-
Yuzu Saijo authored
This CL intends to fix crash happening in ServiceWorkerVersion:: RestoreControlleeFromBackForwardCacheMap. The crash hit the check !base::Contains(controllee_map_, client_uuid), so it seems that the client exists in controlle_map_ when it is supposed to be in bfcached_controllee_map_. This could happen when a controllee was not controlled by a version and started to be controlled in bfcache. This change adds code to make sure that UpdateController checks bfcache status of the client. Bug: 1021718, 1034141 Change-Id: I1e054cfb43b4ce0e6df33fbbf0e1ec239faf1803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959238 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#726265}
-
James Cook authored
This subpage only exists in OS settings under apps, so move it into //chrome/browser/resources/settings/chromeos/os_apps_page/ Browser settings still needs to use AndroidAppsBrowserProxy for the protocol handlers page. Fixed: 1034722 Change-Id: Ia67bbb61ac847f0124ee5170c5c0ec2facae0b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974532 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#726264}
-
Miyoung Shin authored
This CL converts crostini_upgrader::mojom::PageHandlerFactory mojom interface clients for chrome os in chrome to use BrowserInterfaceBroker. Bug: 936482, 1002647 Change-Id: I9ccea33e088a8496f548a464e20bf2a29cde9cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969128 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#726263}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5c3e409cc4f9..104d95744f44 git log 5c3e409cc4f9..104d95744f44 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 dberris@chromium.org Fix graph refinement logic 2019-12-19 fancl@chromium.org Scale sheriff-config Created with: gclient setdep -r src/third_party/catapult@104d95744f44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1034393,chromium:953181 Tbr: sadrul@google.com Change-Id: If4a26e883441d1e53a4823056eaa99f59cdd5c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974708Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726262}
-
Dana Fried authored
Want to not have to specifically stuff icons into a custom view. Splitting controller and container means we can use a default container implementation where we've been using it before, but also allow us to un-nest page action icons in the avatar button toolbar view to improve the quality of slide-out animations (which will be addressed in a follow-up CL). Follow-ups: - Flatten nested view structure in avatar toolbar button - Switch default container to use animating layout Bug: 1023528 Change-Id: Ia7259b6065b139fcb35ac154b81c3456a48838bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974650 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#726261}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/20432bf38dfe..6423b7fc7ded git log 20432bf38dfe..6423b7fc7ded --date=short --first-parent --format='%ad %ae %s' 2019-12-19 timvp@google.com Return the correct location count for Matrices Created with: gclient setdep -r src/third_party/angle@6423b7fc7ded If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I7e3f367f18a423f88d65ae9e2a6598eb5502f529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975166Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726260}
-
Chih-Yu Huang authored
The Chromium smart pointer guidelines [1] says "don't pass or return a smart pointer by reference". This CL remove "const scoped_refptr<T>&" at DecodeSurfaceHandler. [1] https://www.chromium.org/developers/smart-pointer-guidelines Bug: 1020668 Test: run vda_tests on kevin and octopus Change-Id: I7fb98618147a1f9bceb0203b41faaa9ba58fa38c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974717Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#726259}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1f0469da. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." fadf6027 "[css-pseudo] Recalculate viewport units in ::marker" 044ad8ad "[OT-PW] Make it work with OOP-R" 9899425d "[css-layout-api] IntrinsicSizes Implementation" 7d838af7 "[scroll-to-text-fragment] Apply :target CSS pseudo-class to match." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools kojii@chromium.org: external/wpt/css/css-writing-modes NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia9dc843c29362a892544f509dc58636eb508fe7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975230Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726258}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Ieb26af4ed83ef1a33e084f08746289fc0595f90c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975057Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726257}
-
John Lee authored
https://i.imgur.com/B5vHorB.png Bug: 1035675 Change-Id: I4c337f27077f9b01a6a4c23afa315b35f4ea2dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966693Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#726256}
-
Dominic Battre authored
We have added input::-internal-input-suggested, textarea::-internal-input-suggested { font: -webkit-small-control !important; } to html.css to prevent that the scrollWidth/scrollHeight attributes of an input element disclose information about autofill content that is in suggest (preview) state. This CL mocks out the scrollWidth/scrollHeight values in preview state and may allow us to disable the font overriding again. Bug: 1035058 Change-Id: I36a4a3498c240e15c7d72de1746f9697bb875e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972849 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#726255}
-
Rafael Cintron authored
"sanboxing" should be spelled "sandboxing". Change-Id: Iaa82f4bae962456b072268028fd1a578591b7f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975298Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#726254}
-
Leon Han authored
Trigger NDEFReader#onerror on all active readers when we found that the nfc tag coming nearby is not NDEF compatible or some IO errors happened when trying to read the tag, etc. BUG=520391 Change-Id: I1cb0de0474942c9912cba465cb9d14c035e948c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960479Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#726253}
-
Owen Min authored
Using a google doc link instead. Bug: 1022143 Tbr: pastarmovj@chromium.org Change-Id: I8b9f0faa9814fd25a700c0270d9c9421084c7b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975055 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#726252}
-
Jaeyong Bae authored
This adds histograms to count how passwords are shown in settings. Having PasswordManager.AccessPasswordInSettings on Android in addition to the current histograms is beneficial. Bug: 885245 Change-Id: Ia231316ac476135c6eb4dcecc3f070f7a0e585c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966961Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#726251}
-
Hirokazu Honda authored
V4L2ImageProcessor (V4L2IP) needs to be able to buffers with offsets. For example, a processed video frame has a non-pixel area between planes in encoding scenario if zero-copy is enabled. To test in image processor test, test it, V4L2ImageProcessor needs to be configured with multi-planar format. However, there is no smart way to find if V4L2ImageProcessor will be used. This makes a configured format always multi-planar format on ARM. ConvertOneTime_GmbToGmb on kukui Bug: 1033799 Test: IP test --gtest_filter=NV12DownScaling/ImageProcessorParamTest. Change-Id: I800c561b5312a4551cb73dc3913e961685b94ed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966806 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#726250}
-
chrome://devicesDaniel Hosseinian authored
The pref controls the local discovery UI (chrome://devices) which shows discoverable devices near the user as well as cloud devices registered to them. The page also allows for the adding of printers/devices, a capability that administrators may want to restrict. The pref defaults to true. A future CL will add the policy configurations. Bug: 1011582 Change-Id: I84a7ca5d22893b0a5cb0bf7948375ad8ef426288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975292Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#726249}
-
Kunihiko Sakamoto authored
This reverts commit f5a23de3. Reason for revert: SpellCheckProviderTest.ShouldUseBrowserSpellCheck consistently fails on Win7 bots: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/80740 https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/62540 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/98097 Original change's description: > [Spellcheck] Add tests for Windows hybrid spell checking > > Adds tests for the Hunspell fallback logic (Windows hybrid spell checking) > submitted here: > https://chromium-review.googlesource.com/c/chromium/src/+/1918277 > > - Adds browser tests for SpellCheckHostChromeImpl > - Adds component tests for the new SpellcheckHostMetrics > - Adds component test coverage for the new SpellcheckPlatform methods in the > Windows platform test > - Created a bug to track splitting the single test into multiple ones > - Adds component tests for SpellcheckProvider > - Creates a new FakeSpellCheck class to fake the count of enabled spell > check locales, which is needed to control when to call into the > browser spell checker > > Bug: 463364, 1035450 > Change-Id: Ie3e692c0d5d5970ed2ab7612018198bf42049139 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972573 > Auto-Submit: Guillaume Jenkins <gujen@google.com> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726150} TBR=rouslan@chromium.org,gujen@google.com Change-Id: I95a76a62a57a520699c01aa207c9046edbc4592a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 463364, 1035450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975370Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726248}
-
yjliu authored
This is because set_name calls cc::Layer::SetDebugName() hence is no longer trivial. Bug: None Change-Id: I264972480405a0fd56217d350551d5dce7c222f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974317 Commit-Queue: Jun Liu <yjliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Auto-Submit: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#726247}
-
Eric Karl authored
In cases where a SharedImage is not exclusively used with ANGLE (interop types), we don't have a way to ensure that ANGLE has the correct intiialization status for the texture. To work around these infrequent cases, we now pre-clear interop textures on import into the passthrough command decoder. Bug: 1003686 Change-Id: I1b2f46fcc6949ae94117d460d17127da644301a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968753 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#726246}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/979775099f35..04858b5b5e1f Created with: gclient setdep -r src-internal@04858b5b5e1f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1034829 Tbr: jbudorick@google.com Change-Id: I7c397821dd585ef460169c9cbed1b22ed022c778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975164Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726245}
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: I1cff8c1913e5bdc2d3f0b3c4c036e38166d4d61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967018Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#726244}
-
Austin Tankiang authored
Bug: 988586 Change-Id: I122c3a16cdd21d594a8fc7f4205cc8d6655aeed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966799Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#726243}
-
Andrew Luo authored
Bug: 1021665 Change-Id: I4bb27606a3e52ec08341332f1844c6b0073994b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970082 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#726242}
-
Azeem Arshad authored
This CL fixes issue with "Mobile Data" toggle animating to the on position when opening the menu instead of appearing in the on state immediately. The issue was caused because the mobile data header view always initializes with the toggle off. The correct value is updated immediately after initialization. But this code path uses the toggle's AnimateIsOn method that starts an animation. Fixed this by setting correct initial state for mobile header view. Fixed: 1020722 Change-Id: I8c17ce28b09b2506221fcbcbf472f80d44f67006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975111 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726241}
-
Jon Mann authored
This reverts commit ede86024. Reason for revert: Breaks network selection in OOBE Original change's description: > Maintain focus when items in a network-list are updated. > > Previously, focus would jump to the first element when > the underlying network list was updated. This fix > attempts to maintain focus on a particular network if it > is still present, otherwise it tries to stay on the same > index, and finally falls back to the first element. > > Fixed: 1005934 > Change-Id: I9a7e2307bc604f8ba08b659e22f80ba88ad66156 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920188 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Jon Mann <jonmann@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721367} TBR=khorimoto@chromium.org,jonmann@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1031994, 1032265 Change-Id: I31a30d106b61cb917f4a489abf17097476db40e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975162 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#726240}
-
Alex Cooper authored
This change begins implementing the infrastructure for AR and VR permissions so that WebXr can switch to using Permissions instead of a custom consent flow. Note that neither permission is intended to be exposed to blink at this time, and neither permission is expected to be called, therefore all calls to these permissions are currently blocked while development is occurring. Bug: 1033592 Change-Id: Ia51f9df7f66c42d2b5fad17ef9e9206b7bedd799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965974 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#726239}
-
Demetrios Papadopoulos authored
Those resources are only used by the browser settings and seem to have been erronously added in os_settings_resources.grd. Bug: 1026455 Change-Id: I2a0d00207c0f3e11a4b8b66689bfb86010e631f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974760 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#726238}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/aa39e6f58369..5c3e409cc4f9 git log aa39e6f58369..5c3e409cc4f9 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 chonggu@google.com [Telemetry] Fix fuchsia_forwarder Created with: gclient setdep -r src/third_party/catapult@5c3e409cc4f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1014642 Tbr: sadrul@google.com Change-Id: I2cd6d71f664e299ae4b747e803a7e16b655c38cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975157Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726237}
-
John Budorick authored
both from https://ci.chromium.org/p/chromium/builders/ci/android-avd-packager/23 Bug: 922145 Change-Id: I9ffff6bcd6126b53501cf1f6cb9e71294f21b323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974396 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#726236}
-
Fredrik Söderquist authored
Less open-coding means less to cargo-cult. Change-Id: I1d1e7210e28cbb117b1bfaeb5e009f40ad0e1e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974231 Commit-Queue: Florin Malita <fmalita@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#726235}
-
Andrew Luo authored
This will avoid wasting test re-run time on the bots. Bug: 1021665 Change-Id: I42dfcfa848e3c07c0fb5e8de4524a864e497f70d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968238Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#726234}
-
sczs authored
- Adds verifyExistenceOfBookmarkWithURL and verifyAbsenceOfBookmarkWithURL to BookmarkEarlGrey and its AppInterface. - Moves verifyOrderOfTabsWithCurrentTabIndex to bookmark_entries_egtest since its only used by this test and its not using any App code. Change-Id: I64d2191da55ff6c8e60131f8e7f56b726443ae2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974819 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#726233}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3567a9a85896..e020cf38f429 git log 3567a9a85896..e020cf38f429 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 tsepez@chromium.org Fix some whitespace in public header formatting 2019-12-18 thestig@chromium.org Do slightly fewer casts with FPDFBitmap_GetBuffer() result. 2019-12-18 tsepez@chromium.org Tidy interface comments in public/fpdf_formfill.h. Created with: gclient setdep -r src/third_party/pdfium@e020cf38f429 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I8f134974d4fb9523c014592d0da72108046b01f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975154Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726232}
-
Miyoung Shin authored
This CL migrates code to the new BrowserInterfaceBroker class. This allows retrieving the remote implementation in the browser process without relying on the InterfaceProvider API. Bug: 936482, 1002647 Change-Id: I273a91f6b0dfd34e4994ef8987396295ce8436f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969127 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#726231}
-
Raymond Toy authored
NewExpectedClosure returns a base::OnceClosure now and NewExpectedBoolCB returns a base::OnceCallback. Bug: 1007799 Change-Id: Ic0fbcbd1b70c1e81920efdf095ba89d6f905c37f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972816Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#726230}
-
bttk authored
This is a reland of e401fb7e Original change's description: > Replace org.chromium.base.Promise.Function with Function > > Bug: 1034012 > Change-Id: I9dd122eca2169955f2ccf006dc039158be232d14 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965440 > Commit-Queue: bttk <bttk@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Ender <ender@google.com> > Cr-Commit-Position: refs/heads/master@{#724788} Bug: 1034012 Change-Id: I897913251141fe181992e7e9bf6723bc752a7afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967765 Auto-Submit: bttk <bttk@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#726229}
-
Yue Li authored
For testing purposes, check the ShouldArcAlwaysStart flag for the play store state. The flag will only turned on by a command line flag for testing purposes. Background: https://chrome-internal-review.googlesource.com/c/chromeos/platform/tast-tests-private/+/1948653 Bug: 982538 Test: Run existing tests Change-Id: I7c8c3c97df5b696b9fcc467e7abc7e980305f05a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962598 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#726228}
-
Gyuyoung Kim authored
The original CL missed cleaning up MediaStreamTrack::Create(). So, this CL removes the Create() and makes all callers use MakeGarbageCollected<MediaStreamTack> instead. Bug: 939691 Change-Id: I9fa14e15f57f367bad1ff62c9b8cafbc4acaa0ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971303Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#726227}
-
Yusuke Sato authored
ARCVM already does this with SchedulerConfigurationManager's observer, and this is Crostini port of the feature. BUG=1011559 TEST=try, lscpu in guest returns 2 on eve Change-Id: Ie94497ed803c2e10f17def26855107e0f1c336e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972883Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#726226}
-