GitLab

Fixes DCHECK.

Bug: b:136113743
Change-Id: I10cb6587b1017d8c734e91399b8792ab7dbd9fdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679063Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#672726}

These were both only used by tests, and can be replaced by observing view
focus changes.

Bug: 268984
Change-Id: I7472bc3f3eb5b9f807851e0c30af9386b9920d85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673082
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672725}

Currently, the pattern to obtain XRPoses in WebXR is to invoke
`XRFrame.getPose(space_to, space_from)` method - XRPlanes were
not following the pattern and returning XRPoses directly from
`XRPlane.getPose(space)`. This CL fixes that inconsistency -
planes will now return instances of XRSpace that can be used
to obtain the poses from a frame.

Change-Id: Ie656bcca50fe7118d5e2ffeb94e86e101b6e7f82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678440Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672724}

Code and comments say opposite things about which color space info
to prefer. Unify on the config only after checking with hubbe@ and
confirming that webm vp9.2 encodes do need to use the config color
space instead of bitstream.

BUG=none
TEST=hubbe@ && vp9.2 playback.

Change-Id: If990c79481eab3e6925c39b1457d182a7d1cbdbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670122
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672723}

Right now when we initialize the paint canvas for paint worklet with a
scale factor or browser zoom, we do not record the zoom factor in the
canvas transform. As a result, when computing the clip bound we will
apply the wrong transformation matrix and thus sometimes the contents
can be completely clipped out while it should not.

This CL fixes the problem and adds a layout test.

Bug: 970783
Change-Id: Ie3709ea5845ca2b405245d4b36f9fe8f99052bad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678287Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672722}

Bug: 972150
Change-Id: Iaceb58f88fa48baedda753c0520a552edeaff556
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649306Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Kristyn Hamasaki <khamasaki@google.com>
Cr-Commit-Position: refs/heads/master@{#672721}

https://chromium.googlesource.com/angle/angle.git/+log/cc82c3f0f1e0..d43eee649664


git log cc82c3f0f1e0..d43eee649664 --date=short --no-merges --format='%ad %ae %s'
2019-06-26 jmadill@chromium.org Vulkan: Increase size of driver uniforms buffer.
2019-06-26 syoussefi@chromium.org Allow wildcards freely in deqp expectations files
2019-06-26 jmadill@chromium.org Vulkan: Recycle dynamic buffer storage.


Created with:
  gclient setdep -r src/third_party/angle@d43eee649664

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=syoussefi@google.com

Change-Id: Ic7f33291f88d79e84d919386ed644bd90775026c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678951Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672720}

Bug: 977838
Change-Id: I39144a5ab8855231dd14aa3c6bc661c24ba6a866
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677845Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Joey Scarr <jsca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672719}

Previously this only happened if the old display was custom layout,
but not when changing from a standard display to a custom one.
This was a typo, the same condition was checked twice for old_style,
but the second occurrence should check new_style instead.
The change matters when there are inline children that should be
blockified by the custom layout, without the patch they would remain
inline.

BUG=978990
TEST=external/wpt/css/css-layout-api/layout-child-inlines-dynamic.https.html

Change-Id: I73bcf679209dd4bc4a0d7a49f4345ee699bbf37e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678484Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#672718}

Bug: 974910
Change-Id: I953e55aa4ef55d2d4bf0d74848e9354eddd15531
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672233
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672717}

Disable remoting on devices whose model names aren't "Chromecast*" or
"Eureka Dongle*" because remoting doesn't work on many other devices,
even if they support GET_CAPABILITIES.

Also fix the receiver info parsing code to parse into the right types.

Bug: 977773
Change-Id: I27190e5cf06b82d5ef806a4a9f10ed1d2da3be50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679350
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672716}

This change stores the last time a hints fetch was attempted in the
pref service to persist between application restarts. This will limit
the HintsFetcher from sending requests too frequently to the remote
optimization guide if a failure or crash occurs.


Bug: 932707
Change-Id: Iea5fde783f51758ba7e4491d7cbda12991455c37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678227Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672715}

This CL enables the interstitial by default for lookalike domains in
user's navigation history (i.e. site engagement). Matching with top
domains is controlled by the topsites parameter.

Change-Id: Ib636fb4256de88b037549d964e9da551a1ddf592
Bug: 933520
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674253Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672714}

Based on review comments in crrev.com/c/1670424.

Bug: 961564
Change-Id: I377242ec7db98aa0ed0dd1e8efcf8a7b18d315be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677806Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Nic Hollingum <hollingum@google.com>
Cr-Commit-Position: refs/heads/master@{#672713}

Change-Id: Ie37a6821890db0b8e252ed064642857f4a94ab0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677844
Auto-Submit: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672712}

This reverts commit e8718723.

Reason for revert: Testing whether this change was responsible for
the latency regression seen in crbug.com/959048. It isn't, so re-landing.

Original change's description:
> Revert "Disable browser latency recovery for Viz on Android"
> 
> This reverts commit 75cd895e.
> 
> Reason for revert: Testing whether this change was responsible for
> the latency regression seen in crbug.com/959048.
> 
> Original change's description:
> > Disable browser latency recovery for Viz on Android
> > 
> > We disabled this for the renderer in M73/M74. We missed the browser
> > component. Making these uniform.
> > 
> > Bug: 943186, 933846
> > Change-Id: I5098aca0189a66c3ce05df6c108af39cd2ca3fc1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528915
> > Reviewed-by: Jonathan Ross <jonross@chromium.org>
> > Commit-Queue: Eric Karl <ericrk@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#642187}
> 
> TBR=sadrul@chromium.org,jonross@chromium.org,ericrk@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 959048
> Change-Id: If1619c4015479e0acb0030701c98e8bd8e492c1f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653576
> Reviewed-by: Eric Karl <ericrk@chromium.org>
> Commit-Queue: Eric Karl <ericrk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#668212}

TBR=sadrul@chromium.org,jonross@chromium.org,ericrk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 959048
Change-Id: I8c2966bb6dbbd963075eb89a740456ab1c8bb17f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678950Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672711}

App calls made by this test class are moved into ChromeEarlGrey and made
to compile with EG2, so that ScopedBlockPopupsPref can continue to work
when moved into test-side code.

ChromeBrowserState was removed from ScopedBlockPopupsPref as I was not
sure if it would be passable over EDO safely, and all callsites of this
class use GetOriginalBrowserState(). Therefore, I moved getting the
ChromeBrowserState using GetOriginalBrowserState() to app-side in
CEGAppInterface.

Bug: 922813
Change-Id: I954d28309360b8b805a9943c7fde77df69f7df95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668512
Commit-Queue: ericale <ericale@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672710}

BUG=none
TEST=none
R=sandersd

Change-Id: I1f85e8ce594e4b0cf26d8d699d668fad3cf82796
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679474
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672709}

MobileStartup.IntentToCreationTime.* can be useful for root-causing
regressions in startup time.

Bug: 975175
Change-Id: Ida4d241e7a6b9357fbb1062907642aedfceeaf5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669292
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672708}

Timeouts count as a failed attempt. I'm not using the SimpleURLLoader
timeout because I can't set it's TickClock for testing without calling
SetTickClockForTesting in the production code.

Bug: 977603
Change-Id: I6c4c6d0ebbc10f95942ca0e83011270735216c6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679222
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672707}

Allow Chrome users on platform that do not have system caption
styling to provide a default styling for WebVTT captions displayed
by Blink. This should affect Chrome OS and Linux as Windows, macOS
and Android have system settings.

Design doc: https://docs.google.com/document/d/1wgKMbvP8nJkUKXkwnh5iEajSa4GHxDURL8kHIyHEO4s/edit?hl=en#

Bug: 976966
Change-Id: I41282753305b81f76e6b3f565516160cd63d69f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656714Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/master@{#672706}

Add the |enable_remote_debugging_on_port| build flag for Fuchsia
builds. When set to a non-zero value, the WebRunner and CastRunner
packages publish a DevTools service listening on this port.

Bug: 973268
Change-Id: If9d78bdde06c25f59063afb62b204e76d3ad8853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677593Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672705}

Bug: b/129715312
Test: Manual Test
Change-Id: I15bee4721a8133913fffa73f28ac53566005368e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679057Reviewed-by: Yue Li <updowndota@chromium.org>
Commit-Queue: Li Lin <llin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672704}

Bug: None
Change-Id: I56a7735ce113d7988d2e20f07d83efc3a602ad9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670876
Auto-Submit: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672703}

depot_tools seems to have gsutil.py but no gsutil.

BUG=978360

Change-Id: Ib17e3b86e4cf0592a34dcb89224e6ab4d6ecdf2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678322Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#672702}

A previous CL [1] used a newly-added string as part of the
<network-proxy-exclusions> element. This element is shared between both
the settings page and the Internet detail dialog.

However, the newly-added string was only added to the WebUIDataSource
belonging to settings and was not added to the dialog's. This CL fixes
this crash by adding the string to the shared
chromeos::network_element::AddDetailsLocalizedStrings() function
instead.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1669183

Bug: 978762
Change-Id: Ibc5f06d6f3db71b06e55c8c96e717fb08c4d42ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679099
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672701}

Bug: 969252
Change-Id: Ia54129af9dbcb727aab1d3289be997a31143e004
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649186
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672700}

This patch fills in the 'desc' tag for each <message> in the
changes tab with auto-generated descriptions.

Regarding the quality of these descriptions. Our plan is to fix
descriptions that result in poor translations as reported by our
translation team and end users.

Follow-up patches will be made to add descriptions to other grdp files.

Bug: 941561
Change-Id: I838baac8eb55f79a53e0f1e251713bc5a7237da1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678842Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#672699}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/2b2367291125..54e38e370156


git log 2b2367291125..54e38e370156 --date=short --no-merges --format='%ad %ae %s'
2019-06-26 saklein@chromium.org Build API: Added method discovery service.


Created with:
  gclient setdep -r src/third_party/chromite@54e38e370156

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Change-Id: I90bf0cccc743016588139e9feb385f9231a0c795
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678295Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672698}

This was added to collect data about how often the compositor rasterizes
downscaled images and the data is not required anymore.

R=ericrk@chromium.org,holte@chromium.org

Bug: 975326,976133
Change-Id: Id8224e1cb9653439dd93eb11126d19c6c44e547b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670276
Auto-Submit: Khushal <khushalsagar@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672697}

Bug: 978888
Change-Id: Ib16b2e35c2f88e7f554611b21bda48857127c77c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678937Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672696}

The |StatusAreaWidget| class implements this observer interface and
gets registered as an observer but it never does anything with it.

Bug: 973443
Change-Id: I060cc3477587edfec2d9ecd9f79496a517d9c774
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679432Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672695}

For smart boards, the devices are receiving some touch move events when
there is no finger touching on the screen, like hovering. For those
touch move events, we do not release their ids. We should check if the
touch pointer are in contact with the screen, if not, release the ids
for these touch move events as well.

Bug: 874948
Change-Id: I61f7cb75f92eb600b0dbbbd8f9fb7184c6c0bda1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670159
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672694}

If a test expectations non glob pattern is shorter than any test name then the presubmit
check should raise an exception because the test expectation is for a non existing test.
This CL will update CheckTestExpectationsAreForExistingTests so that it raises an exception
when it finds one of these test expectations.

Bug: chromium:978712
Change-Id: Ic80efccca659b7f35a345ebb187fb7dab08c423f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677510
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672693}

This histogram is already scheduled to expire in M77 due to nobody
looking at it.

Bug: 970008
Change-Id: I746704ffc678233635e751af09d4a52261710865
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649686
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Auto-Submit: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672692}

The timestamp captured at onload does not seem to always be smaller than
the render timestamp. This CL changes the lower bound so the test is no
longer flaky.

Bug: 978587
Change-Id: I48c058ac0abb684cb4406617500356d0aae019e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678836
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672691}

- Billing
- Look alike URLs
- Supervised users

Screenshots can be see in:
https://bugs.chromium.org/p/chromium/issues/detail?id=947840#c29

Bug: 947840,978833
Change-Id: I02ee5364bbf5747158090568b6959caead36265a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676130Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672690}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/11cf0a3029ed..cff2a5619b04


git log 11cf0a3029ed..cff2a5619b04 --date=short --no-merges --format='%ad %ae %s'
2019-06-26 zoddicus@users.noreply.github.com Catch low level exceptions instead of crash (#744)


Created with:
  gclient setdep -r src/third_party/shaderc/src@cff2a5619b04

The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=radial-bots+chrome-roll@google.com

Change-Id: Iad56a981d9550fcecf74ca4323d5040ae72dddf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678853Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672689}

Previously, the Page Info bubble maintained a single variable to
identify all reasons that a page might have a non-standard status. This
lead to the display logic making assumptions about, for instance, the
validity of a certificate when the page was flagged by Safe Browsing.

This CL separates out the Safe Browsing status from the site identity
status so that the page info bubble can inform the user that the site's
certificate is invalid, even if it's also flagged by Safe Browsing.

This reland includes fixes to prevent use of uninitialized memory.

Bug: 869925
TBR: meacer@chromium.org
TBR: bsep@chromium.org
Change-Id: I237da104427002cce6972b3fdc30656c682b5e6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678818
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672688}

Allowed a new type of media block that blocks cast_renderer
initialization instead of webmediaplayer loading.

Test: Manual test blocking is happening at the renderer by inspecting
device logs
Bug: b/134961542

Change-Id: I97b0e59a6752c43d14b8e96327079aa8669b1c00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673829Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Auto-Submit: Andres Medina <medinaandres@chromium.org>
Commit-Queue: Andres Medina <medinaandres@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672687}