1. 14 Jan, 2007 3 commits
    • hyatt's avatar
      Add layout test for replaced breaking. · 6040e066
      hyatt authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18839 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6040e066
    • hyatt's avatar
      Fix for 10145, regression where line breaks are not being honored... · 7597f8f4
      hyatt authored
              Fix for 10145, regression where line breaks are not being honored between adjacent replaced elements.
              When checking for break opportunities where replaced elements are involved, we ignore their white-space
              values and use their parents' instead.  The assumption/idea behind this change is that because the element
              is replaced, its white-space value is irrelevant except as a means of applying style to its interior.
      
              The CSS spec does not cover this situation, so we're implementing this based off what other browsers seem to
              do.
      
              Reviewed by aroben
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * css/CSSValueKeywords.in:
              * css/cssparser.cpp:
              (WebCore::CSSParser::parseValue):
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::EventHandler):
              (WebCore::EventHandler::clear):
              (WebCore::EventHandler::handleWheelEvent):
              * page/EventHandler.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calcHeight):
              * rendering/RenderLayer.cpp:
              (WebCore::Marquee::Marquee):
              (WebCore::Marquee::start):
              (WebCore::Marquee::updateMarqueePosition):
              (WebCore::Marquee::updateMarqueeStyle):
              (WebCore::Marquee::timerFired):
              * rendering/RenderLayer.h:
              * rendering/RenderPartObject.cpp:
              (WebCore::RenderPartObject::viewCleared):
              * rendering/RenderStyle.h:
              (WebCore::):
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::findNextLineBreak):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18838 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7597f8f4
    • bdash's avatar
      2007-01-14 Mark Rowe <mrowe@apple.com> · 559993f2
      bdash authored
              Reviewed by Mitz.
      
              Minor fixes to JavaScript pretty-printing.
      
              * JavaScriptCore.exp:
              * kjs/Parser.cpp:
              (KJS::Parser::prettyPrint): Return line number and error message if parsing fails.
              * kjs/Parser.h:
              * kjs/nodes2string.cpp:
              (ElementNode::streamTo): Include comma delimiters in array literals.
              (PropertyNameNode::streamTo): Quote property names in object literals to handle the case when the property name is not a valid identifier.
              * kjs/testkjs.cpp:
              (doIt): Print any errors encountered while pretty-printing.
      
      2007-01-14  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by Mitz.
      
              Layout tests for fixes to JavaScript pretty-printing.
      
              * fast/js/pretty-print-expected.txt:
              * fast/js/resources/pretty-print.js: Test handling of object literal with non-identifier property name, and of array literals.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18837 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      559993f2
  2. 13 Jan, 2007 16 commits
    • hyatt's avatar
      While optimizing form controls and fixing their clipping, I caused... · c9cf6677
      hyatt authored
              While optimizing form controls and fixing their clipping, I caused this text zoom regression.  The layout
              of text is necessary because it needs to recalc minmaxwidth.  This is still a really unfortunate
              bit of code... since a lot of properties don't apply to text (e.g., borders), we're marking text renderers
              as dirty when we don't have to.
      
              Reviewed by mitz
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::setStyle):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18836 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c9cf6677
    • lars's avatar
      Reviewed by Alexey · 2ba297f8
      lars authored
              String::format() was relying on undefined behaviour, which
              happened to work on lots of systems (Mac and 32bit Linux at least)
              but broke badly on 64bit Linux.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18835 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2ba297f8
    • lars's avatar
      Fix for bug 11924: WebCore would crash on any HTML content · 16d32864
      lars authored
              with a non-empty <table> tag in it on a 64-bit machine. The
              size_t (64bit) vs int (32bit) cast is now fixed in ensureRows,
              and the clients of this function have been updated to check
              for a false return code.
      
              Reviewed by Darin
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18834 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      16d32864
    • ap's avatar
      Reviewed by Darin. · 7a650a7e
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=12165
              REGRESSION: text encoding problem at jn.sapo.pt
      
              Test: fast/encoding/script-in-head.html
      
              * loader/TextResourceDecoder.cpp:
              (WebCore::TextResourceDecoder::checkForHeadCharset):
              Ignore tags within <script> elements in head, just like we do for <title>.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18833 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7a650a7e
    • lars's avatar
      Reviewed by Maciej · 5079de61
      lars authored
              Don't crash when constructing a GraphicsContext with a 0
              PlatformGraphicsContext and don't do anything if painting
              is disabled.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18832 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5079de61
    • lars's avatar
      Make the Qt port compile again. · beff4db2
      lars authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18831 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      beff4db2
    • eseidel's avatar
      2007-01-13 Eric Seidel <eric@eseidel.com> · 56b73483
      eseidel authored
              Reviewed by hyatt.
      
              RichDraw demo does not live-update in Safari
              (SVG elements should ignore CSS position)
              http://bugs.webkit.org/show_bug.cgi?id=10364
      
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::adjustRenderStyle): ignore position for everything but <svg>
              * ksvg2/svg/SVGStyledElement.cpp:
              (WebCore::SVGStyledElement::rebuildRenderer): move path generation into layout()
              * rendering/RenderContainer.cpp:
              (WebCore::RenderContainer::layout): ASSERT kids marked as having completed layout
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::layout): move path generation into layout()
              * rendering/RenderSVGContainer.cpp:
              (WebCore::RenderSVGContainer::layout): ASSERT kids marked as having completed layout
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18830 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      56b73483
    • hyatt's avatar
      Fix leak of column vector. · 24cebcc9
      hyatt authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18829 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      24cebcc9
    • hyatt's avatar
      Add layout test for column rules. · d73d0ff9
      hyatt authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18828 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d73d0ff9
    • hyatt's avatar
      Add support for column rules. · e6f60343
      hyatt authored
              Reviewed by bdash
      
              fast/multicol/column-rules.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintColumns):
              * rendering/RenderStyle.h:
              (WebCore::RenderStyle::columnRuleIsTransparent):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18827 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e6f60343
    • hyatt's avatar
      Make multicolumn layout work with floats. · 99d85a2d
      hyatt authored
              Reviewed by andersca
      
              Added fast/multicol/float-multicol.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::layoutBlock):
              (WebCore::RenderBlock::paintColumns):
              (WebCore::RenderBlock::paintObject):
              * rendering/RenderBlock.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18826 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      99d85a2d
    • hyatt's avatar
      New fancy float multicol test (thanks Mozilla!) · af3691c0
      hyatt authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18825 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      af3691c0
    • ddkilzer's avatar
      LayoutTests: · 9ec4dc5d
      ddkilzer authored
              Reviewed by Maciej.
      
              - test for fast/css/line-height.html
                REGRESSION (r18816-r18818): Assertion failure in
                WebCore::Length::Length[in-charge](int, WebCore::LengthType, bool)
      
              * fast/css/line-height-expected.checksum: Added.
              * fast/css/line-height-expected.png: Added.
              * fast/css/line-height-expected.txt: Added.
              * fast/css/line-height.html: Added.
      
      WebCore:
      
              Reviewed by Maciej.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12239
                REGRESSION (r18816-r18818): Assertion failure in 
                WebCore::Length::Length[in-charge](int, WebCore::LengthType, bool)
      
              Test: fast/css/line-height.html
      
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::createInnerTextStyle): Use a float to create a percent Length.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18824 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9ec4dc5d
    • andersca's avatar
      Forgot to save. · f748def0
      andersca authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18823 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f748def0
    • andersca's avatar
      JavaScriptCore: · 7835a675
      andersca authored
              Reviewed by Darin.
      
              * wtf/HashTraits.h:
              Add hash traits for unsigned long and unsigned long long.
      
      WebCore:
      
              Reviewed by Darin.
      
              Use unsigned long for identifiers instead of Objective-C objects.
              
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::loadResourceSynchronously):
              (WebCore::FrameLoader::startLoadingMainResource):
              (WebCore::FrameLoader::startLoading):
              (WebCore::FrameLoader::assignIdentifierToInitialRequest):
              (WebCore::FrameLoader::opened):
              (WebCore::FrameLoader::sendRemainingDelegateMessages):
              (WebCore::FrameLoader::requestFromDelegate):
              (WebCore::FrameLoader::loadedResourceFromMemoryCache):
              * loader/FrameLoader.h:
              * loader/FrameLoaderClient.h:
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::ResourceLoader):
              (WebCore::ResourceLoader::willSendRequest):
              * loader/ResourceLoader.h:
              (WebCore::ResourceLoader::setIdentifier):
              (WebCore::ResourceLoader::identifier):
              * page/Page.cpp:
              (WebCore::Page::Page):
              (WebCore::Page::createUniqueIdentifier):
              * page/Page.h:
              * platform/graphics/svg/SVGImageEmptyClients.h:
              (WebCore::SVGEmptyFrameLoaderClient::assignIdentifierToInitialRequest):
              (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest):
              (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
              (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
              (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse):
              (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveContentLength):
              (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoading):
              (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoading):
              (WebCore::SVGEmptyFrameLoaderClient::incrementProgress):
              (WebCore::SVGEmptyFrameLoaderClient::completeProgress):
      
      WebKit:
      
              Reviewed by Darin.
      
              Add a HashMap between unsigned longs and Objective-C objects and use it for
              the resource load delegate.
              
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::assignIdentifierToInitialRequest):
              (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
              (WebFrameLoaderClient::dispatchWillSendRequest):
              (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
              (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
              (WebFrameLoaderClient::dispatchDidReceiveResponse):
              (WebFrameLoaderClient::dispatchDidReceiveContentLength):
              (WebFrameLoaderClient::dispatchDidFinishLoading):
              (WebFrameLoaderClient::dispatchDidFailLoading):
              (WebFrameLoaderClient::incrementProgress):
              (WebFrameLoaderClient::completeProgress):
              * WebView/WebView.mm:
              (-[WebViewPrivate init]):
              (-[WebViewPrivate dealloc]):
              (-[WebView _addObject:forIdentifier:]):
              (-[WebView _objectForIdentifier:]):
              (-[WebView _removeObjectForIdentifier:]):
              * WebView/WebViewInternal.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18822 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7835a675
    • bdash's avatar
      2007-01-12 Mitz Pettel <mitz@webkit.org> · 7e23375f
      bdash authored
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12235
                REGRESSION (r18815): Marquees do not scroll
      
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::applyProperty): Apply the '-webkit-marquee' value
              of 'overflow-x' and 'overflow-y'.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18821 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7e23375f
  3. 12 Jan, 2007 21 commits
    • justing's avatar
      LayoutTests: · 00c85c11
      justing authored
              Reviewed by hyatt
      
              <rdar://problem/4875425>
              EBay, GMail, and GoogleDocs RTEs font size popups don't work
      
              Added to test changes:
              * editing/style/fontsize-1-expected.checksum: Added.
              * editing/style/fontsize-1-expected.png: Added.
              * editing/style/fontsize-1-expected.txt: Added.
              * editing/style/fontsize-1.html: Added.
      
              Removed use of "px" and "pt" values passed to
              execCommand("FontSize", ...) (other browsers don't
              support them): 
              * editing/input/attributed-substring-from-range-lines.html-disabled:
              * editing/style/block-style-004-expected.checksum:
              * editing/style/block-style-004-expected.png:
              * editing/style/block-style-004-expected.txt:
              * editing/style/block-style-004.html:
              * editing/style/block-style-005-expected.checksum:
              * editing/style/block-style-005-expected.png:
              * editing/style/block-style-005-expected.txt:
              * editing/style/block-style-005.html:
              * editing/style/block-style-006-expected.checksum:
              * editing/style/block-style-006-expected.png:
              * editing/style/block-style-006-expected.txt:
              * editing/style/block-style-006.html:
      
      WebCore:
      
              Reviewed by hyatt
              
              <rdar://problem/4875425>
              EBay, GMail, and GoogleDocs RTEs font size popups don't work
      
              Changed execCommand("FontSize", ...) to match the spec 
              and the behavior of other browsers.  It expects a number, 
              n, which, the spec says can be 1 through 7.  Other browsers 
              perform the font size change by creating a font element 
              wrapper with size="n".  We convert n into one of the absolute 
              size CSS keywords (x-small, medium, etc.).
      
              * editing/JSEditor.cpp: Call cssValueFromFontSizeNumber.  If
              successful, perform the style change.
              * html/HTMLFontElement.cpp:
              (WebCore::HTMLFontElement::cssValueFromFontSizeNumber):  Added.
              Moved this code from parsedMappedAttribute so that it could be
              called from the Editor.
              (WebCore::HTMLFontElement::parseMappedAttribute): Moved code into
              cssValueFromFontSizeNumber.
              * html/HTMLFontElement.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18820 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      00c85c11
    • hyatt's avatar
      Fix for bug 11598, implement lightweight control clipping mechanism for · b8349ce7
      hyatt authored
              buttons, list boxes, and dropdown lists.  Make sure list box respects
              scrollLeft/Top/Width/Height as well as clientWidth/Height.
      
              Fix bugs in RenderStyle::diff.  CursorData was not being compared properly.
              vertical-align had a non-inline display check that was wrong (preventing
              dynamic changes to keyword-based vertical-align from working).
      
              Reviewed by mitz
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::selectClosestWordFromMouseEvent):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::layout):
              (WebCore::RenderBlock::layoutBlock):
              (WebCore::RenderBlock::determineHorizontalPosition):
              (WebCore::RenderBlock::layoutBlockChildren):
              (WebCore::RenderBlock::paint):
              (WebCore::RenderBlock::fillHorizontalSelectionGap):
              (WebCore::RenderBlock::nodeAtPoint):
              (WebCore::RenderBlock::layoutColumns):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::computeAbsoluteRepaintRect):
              * rendering/RenderBox.h:
              * rendering/RenderButton.cpp:
              (WebCore::RenderButton::setStyle):
              (WebCore::RenderButton::controlClipRect):
              * rendering/RenderButton.h:
              (WebCore::RenderButton::hasControlClip):
              * rendering/RenderFlexibleBox.cpp:
              (WebCore::RenderFlexibleBox::layoutBlock):
              (WebCore::RenderFlexibleBox::layoutHorizontalBox):
              (WebCore::RenderFlexibleBox::layoutVerticalBox):
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::addFocusRingRects):
              * rendering/RenderListBox.cpp:
              (WebCore::RenderListBox::itemBoundingBoxRect):
              (WebCore::RenderListBox::paintObject):
              (WebCore::RenderListBox::itemHeight):
              (WebCore::RenderListBox::verticalScrollbarWidth):
              (WebCore::RenderListBox::scrollWidth):
              (WebCore::RenderListBox::scrollHeight):
              (WebCore::RenderListBox::scrollLeft):
              (WebCore::RenderListBox::setScrollLeft):
              (WebCore::RenderListBox::scrollTop):
              (WebCore::RenderListBox::setScrollTop):
              (WebCore::RenderListBox::controlClipRect):
              * rendering/RenderListBox.h:
              (WebCore::RenderListBox::hasControlClip):
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::setStyle):
              (WebCore::RenderMenuList::controlClipRect):
              * rendering/RenderMenuList.h:
              (WebCore::RenderMenuList::hasControlClip):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::verticalScrollbarWidth):
              (WebCore::RenderObject::horizontalScrollbarHeight):
              (WebCore::RenderObject::clientWidth):
              (WebCore::RenderObject::clientHeight):
              (WebCore::RenderObject::setStyle):
              * rendering/RenderObject.h:
              (WebCore::RenderObject::hasControlClip):
              (WebCore::RenderObject::controlClipRect):
              (WebCore::RenderObject::contentWidth):
              (WebCore::RenderObject::contentHeight):
              * rendering/RenderStyle.cpp:
              (WebCore::StyleVisualData::StyleVisualData):
              (WebCore::cursorDataEqvuialent):
              (WebCore::StyleInheritedData::operator==):
              (WebCore::CursorList::operator==):
              (WebCore::RenderStyle::diff):
              * rendering/RenderStyle.h:
              (WebCore::LengthBox::operator!=):
              (WebCore::StyleVisualData::operator==):
              (WebCore::CursorData::operator==):
              (WebCore::CursorData::operator!=):
              (WebCore::CursorList::operator!=):
              (WebCore::RenderStyle::setTableLayout):
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::layoutInlineChildren):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18819 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b8349ce7
    • hyatt's avatar
      Ooops left off paren. · 7d64ad24
      hyatt authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18818 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7d64ad24
    • hyatt's avatar
      Fix for bug 9934, smaller line heights should not be allowed on · 19115c8b
      hyatt authored
              text fields.
      
              Reviewed by darin
      
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::createInnerTextStyle):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18816 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      19115c8b
    • ddkilzer's avatar
      LayoutTests: · 16fbf381
      ddkilzer authored
              Reviewed by Hyatt.  Patch by Mitz.
      
              - test updated for http://bugs.webkit.org/show_bug.cgi?id=12215
                Treat 'overflow' and '-webkit-border-radius' as shorthands when parsing and
                when removing.
      
              * fast/css/remove-shorthand-expected.txt:
              * fast/css/remove-shorthand.html:
      
      WebCore:
      
              Reviewed by Hyatt.  Patch by Mitz.
      
              - http://bugs.webkit.org/show_bug.cgi?id=12215
                Treat 'overflow' and '-webkit-border-radius' as shorthands when parsing and
                when removing.
      
              Test: fast/css/remove-shorthand.html (updated)
      
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::initShorthandMap):
              * css/cssparser.cpp:
              (WebCore::CSSParser::parseValue):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18815 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      16fbf381
    • rwlbuis's avatar
      Reviewed by Mitz. · 4ebeb8bf
      rwlbuis authored
              Do not mix up JSSVGPolygonElement and JSSVGPolylineElement.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18814 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4ebeb8bf
    • kdecker's avatar
      · 0bc2431e
      kdecker authored
              Reviewed by andersca.
      
              Fixed: <rdar://problem/4701326>21.2 ms launch time regression spent in +[WebPluginDatabase installedPlugins]
      
              * dom/DOMImplementation.cpp:
              (WebCore::DOMImplementation::createDocument): Added a guard clause for text/html which used to be in WebKit before a lot of the 
              loader plumbing was moved to WebCore.  Pinging the plug-in database to ask it if it supports a given mime type has the side 
              effect of reading from disk on first call, therefore such a check should be a last resort.  
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18813 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0bc2431e
    • ggaren's avatar
      RS by Brady Eidson. · c652a6b4
      ggaren authored
              
              Rolling back in r18786 with leaks fixed, and these renames slightly reworked:
      
              Because they can return 0:
              rootObjectForImp => findRootObject (overloaded for JSObject* and Interpreter*)
              rootObjectForInterpreter => findRootObject (ditto)
              findReferenceSet => findProtectCountSet
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18811 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c652a6b4
    • ddkilzer's avatar
      WebCore: · 0ae841b5
      ddkilzer authored
              Reviewed by Darin.  Patch by Mitz.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12223
                REGRESSION: Leaks under CSSStyleSelector::applyProperty
      
              No test possible (no change to functionality).
      
              * rendering/RenderObject.h: Removed unused forward declaration.
              * rendering/RenderStyle.cpp:
              (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData):
              Delete shadow data.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18810 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0ae841b5
    • andersca's avatar
      Build fix. · e4a9489f
      andersca authored
              
              * WebCore.xcodeproj/project.pbxproj:
              Remove SubresourceLoaderMac.mm.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18806 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e4a9489f
    • andersca's avatar
      Reviewed by Darin and Anders. · bb958eff
      andersca authored
              Make some more of the loader code platform independent.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::clear):
              (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
              (WebCore::FrameLoader::urlSelected):
              (WebCore::FrameLoader::createEmptyDocument):
              (WebCore::FrameLoader::setTitle):
              (WebCore::FrameLoader::originalRequestURL):
              (WebCore::FrameLoader::referrer):
              * loader/SubresourceLoader.cpp:
              (WebCore::SubresourceLoader::SubresourceLoader):
              (WebCore::SubresourceLoader::load):
              (WebCore::SubresourceLoader::create):
              (WebCore::SubresourceLoader::willSendRequest):
              (WebCore::SubresourceLoader::didReceiveResponse):
              (WebCore::SubresourceLoader::didReceiveData):
              (WebCore::SubresourceLoader::didFinishLoading):
              (WebCore::SubresourceLoader::didFail):
              (WebCore::SubresourceLoader::didCancel):
              (WebCore::SubresourceLoader::stopLoading):
              * loader/SubresourceLoader.h:
              * loader/mac/FrameLoaderMac.mm:
              * loader/mac/SubresourceLoaderMac.mm: Removed.
              * loader/qt/FrameLoaderQt.cpp:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18805 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bb958eff
    • lars's avatar
      Reviewed by Zack · 2c0cce38
      lars authored
              Get DumpRenderTree to work again for the Qt build.
      
              Make run-webkit-tests a little less verbose when testing
              Qt, and add an option to run DumpRenderTree inside valgrind
              (useful for debugging)
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18804 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2c0cce38
    • lars's avatar
      Reviewed by Zack · 86f5ebbd
      lars authored
              Valgrind reported uninitialized variable.
      
              * platform/network/qt/ResourceHandleManagerQt.cpp:
              (WebCore::FileLoader::request):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18803 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      86f5ebbd
    • rwlbuis's avatar
      Reviewed by rwlbuis. · 9756cff4
      rwlbuis authored
              - add missing null check in new fixed table layout code
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18802 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9756cff4
    • zack's avatar
      Add WEBKIT_FULLBUILD to the qmake relevant build part to force · f79ce404
      zack authored
      make clean before make as they fix stale dependencies (for buildbot mainly)
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18801 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f79ce404
    • lars's avatar
      Fix the Qt build after the Authentication changes. · 7516e4aa
      lars authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18800 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7516e4aa
    • hyatt's avatar
      Fix for bug 9569. Make sure the selection offset for selection roots... · 3c22afc3
      hyatt authored
              Fix for bug 9569.  Make sure the selection offset for selection roots excludes border and padding.
      
              Reviewed by Eric
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::leftSelectionOffset):
              (WebCore::RenderBlock::rightSelectionOffset):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18799 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3c22afc3
    • hyatt's avatar
      Fix for bug 8705, readonly text fields should not get focus rings. ... · 85c21c11
      hyatt authored
              Fix for bug 8705, readonly text fields should not get focus rings.  Add a rule to that effect to
              html4.css and then also add readonly as a special case for style sharing so that we can retain the
              performance boost from sharing styles on inputs.
      
              Reviewed by bdash
      
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::canShareStyleWithElement):
              (WebCore::CSSStyleSelector::checkOneSelector):
              * css/html4.css:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18798 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      85c21c11
    • hyatt's avatar
      Update overflow layout test results after autoscroll fix. · f40f272b
      hyatt authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18797 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f40f272b
    • hyatt's avatar
      Fix for bug 11595. Autoscrolling of layers didn't really work at all... · 0278dd62
      hyatt authored
              Fix for bug 11595.  Autoscrolling of layers didn't really work at all unless the layer was coincidentally
              in the root layer's coordinate space.  The event point was an absolute position within the document, but
              the layer's rect was only local coords.  This patch makes sure to use absolute bounds for the layer
              when comparing it with the point.
      
              This is covered by the scrollRevealButton test case already in the tree... the results change to be more
              correct.
      
              Reviewed by ggaren
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::scrollRectToVisible):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18796 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0278dd62
    • ggaren's avatar
      RS by Brady Eidson. · 078aa111
      ggaren authored
              
              Rolling out r18786 because it caused leaks.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18795 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      078aa111