GitLab

As discussed on chromium-os-dev [1], if there is no fsync() after writing to the
temp file, atomicity is not guaranteed.  Thus, to be able to guarantee
atomicity, we must check the return value of Flush() and bail in case Flush()
wasn't successful.

I'll update the UMA histogram enum in a separate CL.

[1] https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/chromium-os-dev/Eef8gNIRwjc

BUG=none

Review URL: https://codereview.chromium.org/663463002

Cr-Commit-Position: refs/heads/master@{#300230}

This CL fixes an issue causing the app list to render without any apps
when shown in an RTL language.

BUG=422604

Review URL: https://codereview.chromium.org/656343003

Cr-Commit-Position: refs/heads/master@{#300229}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e862ddb..833fa84

TBR=

Review URL: https://codereview.chromium.org/662303002

Cr-Commit-Position: refs/heads/master@{#300228}

TBR=grt@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/666713002

Cr-Commit-Position: refs/heads/master@{#300227}

Revert of Support modal windows (patchset #4 id:80001 of https://codereview.chromium.org/662763002/)

Reason for revert:
Reverting because this CL because WithOrWithoutTargeter.* introduced a memory leak and made all of the Athena Asan tests fail http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)

Based on tools/lsan/suppressions.txt reverting is now preferred over adding a suppression

Original issue's description:
> Support modal windows
>
> * New ContainerParams
>  -  default_parent to specify the default parent when no
>     transient parent is specified.
>  - modal_container_priority now controls the modal container
>    used for a modal window created for the given container.
>  - if not specified, it will fallback downwards to find one.
>  - if window is specified as always_on_top, it will use top
>    most modal container.
>
> * Changed network selector/shutdown dialog to use the new API.
>
> * Other change:
>  Separated test windows to athena/test/base/test_windows.h
>
> BUG=410499
> TBR=sky@chromium.org,reed@chromium.org
> TEST=coverd by unit tests
>
> Committed: https://crrev.com/4903fd36b2b36f00efeb1b7bba81b7de6e9457a3
> Cr-Commit-Position: refs/heads/master@{#300192}

TBR=mukai@chromium.org,sky@chromium.org,reed@chromium.org,oshima@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=410499

Review URL: https://codereview.chromium.org/665803003

Cr-Commit-Position: refs/heads/master@{#300226}

Revert of Revert of [Telemetry] Set the number of attempts to retry a test if browser or tab crash to 1 (patchset #1 id:1 of https://codereview.chromium.org/661303002/)

Reason for revert:
The removal of Telemetry's retry logic wasn't the cause of the intermittent crashes on the GPU bots.

Original issue's description:
> Revert of [Telemetry] Set the number of attempts to retry a test if browser or tab crash to 1 (patchset #2 id:20001 of https://codereview.chromium.org/659753003/)
>
> Reason for revert:
> Possible cause of gpu telemetry bot flake
>
> Original issue's description:
> > [Telemetry] Set the number of attempts to retry a test to 1
> >
> > **SHERIFFS: if telemetry perf tests on waterfall become more flaky, this patch can be safely reverted.
> >
> > BUG=422339
> >
> > Committed: https://crrev.com/f5b75f261be7779ccca14d09ddaabb3e4ee5ee03
> > Cr-Commit-Position: refs/heads/master@{#299716}
>
> TBR=tonyg@chromium.org,dtu@chromium.org,nednguyen@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=422339
>
> Committed: https://crrev.com/1c141bedc45cdef1ac7b7264ea1288c33e33d106
> Cr-Commit-Position: refs/heads/master@{#300218}

TBR=tonyg@chromium.org,dtu@chromium.org,nednguyen@google.com,hendrikw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=422339

Review URL: https://codereview.chromium.org/662963002

Cr-Commit-Position: refs/heads/master@{#300225}

Revert of [ServiceWorkerCache] Implement storage::QuotaClient (patchset #12 id:320001 of https://codereview.chromium.org/651983002/)

Reason for revert:
bug 424923, top crash in canary.

Original issue's description:
> [ServiceWorkerCache] Implement storage::QuotaClient
>
> Adds a QuotaClient for the ServiceWorkerCache system.
>
> * Calls to the QuotaManagerProxy like (NotifyStorageAccessed/StorageModified/OriginInUse/etc..) will be in an upcoming CL.
>
> * The ServiceWorkerCacheQuotaClient is registered by the ServiceWorkerCacheStorageManager.  The QuotaClient holds a WeakPtr to the ServiceWorkerCacheStorageManager since the manager is destroyed before the QuotaClient.
>
> * Added a number of unittests.  They fit better into the StorageManager tests file than in their own file as they rely on a lot of the StorageManager infrastructure.
>
> * In order to support QuotaClient the ServiceWorkerCacheStorageManager needs to be able to list the origins it supports. This data is not currently stored so an "origin" member has been added to the CacheStorage index protobuf.  We won't report the origins of existing caches (if any even exist at this point) until their index is next written.
>
> BUG=420159
>
> Committed: https://crrev.com/22fcbd3c898136dfe839de3ca5cb0633c17bb163
> Cr-Commit-Position: refs/heads/master@{#300187}

TBR=michaeln@chromium.org,falken@chromium.org,jkarlin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=420159

Review URL: https://codereview.chromium.org/651433005

Cr-Commit-Position: refs/heads/master@{#300224}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bc9a196..e862ddb

TBR=

Review URL: https://codereview.chromium.org/667583002

Cr-Commit-Position: refs/heads/master@{#300223}

This patch ensures that the eviction tiles cache becomes invalid
when a tile is removed from it. Without this patch, it is possible
that the eviction cache holds on to a tile pointer that would end
up pointing to a deleted tile (and thus when it gets evicted,
we'll access an invalid tile).

BUG=424487
R=reveman

Review URL: https://codereview.chromium.org/669433002

Cr-Commit-Position: refs/heads/master@{#300222}

This patch adds an iterator similar to spiral difference iterator,
except that it iterates the indecies in reverse order. This is needed
for a fast eviction iterator.

R=danakj, enne

Review URL: https://codereview.chromium.org/645173004

Cr-Commit-Position: refs/heads/master@{#300221}

BUG=
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/657143004

Cr-Commit-Position: refs/heads/master@{#300220}

This allows the removal of the IsAlgorithmAsymmetric() helper.

BUG=407846

Review URL: https://codereview.chromium.org/512023002

Cr-Commit-Position: refs/heads/master@{#300219}

Revert of [Telemetry] Set the number of attempts to retry a test if browser or tab crash to 1 (patchset #2 id:20001 of https://codereview.chromium.org/659753003/)

Reason for revert:
Possible cause of gpu telemetry bot flake

Original issue's description:
> [Telemetry] Set the number of attempts to retry a test to 1
>
> **SHERIFFS: if telemetry perf tests on waterfall become more flaky, this patch can be safely reverted.
>
> BUG=422339
>
> Committed: https://crrev.com/f5b75f261be7779ccca14d09ddaabb3e4ee5ee03
> Cr-Commit-Position: refs/heads/master@{#299716}

TBR=tonyg@chromium.org,dtu@chromium.org,nednguyen@google.com
NOTREECHECKS=true
NOTRY=true
BUG=422339

Review URL: https://codereview.chromium.org/661303002

Cr-Commit-Position: refs/heads/master@{#300218}

And stop mis-using user metrics action.

BUG=424689

Review URL: https://codereview.chromium.org/659333003

Cr-Commit-Position: refs/heads/master@{#300217}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0a8c931..bc9a196

TBR=

Review URL: https://codereview.chromium.org/656793003

Cr-Commit-Position: refs/heads/master@{#300216}

Cr-Commit-Position: refs/heads/master@{#300215}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d1f9de7..0a8c931

TBR=

Review URL: https://codereview.chromium.org/668503002

Cr-Commit-Position: refs/heads/master@{#300214}

BUG=424216,420994
NOTRY=true

Review URL: https://codereview.chromium.org/661943002

Cr-Commit-Position: refs/heads/master@{#300213}

To allow the chromium WebView to build unbundled, we need to stop
linking to system libraries and instead link to the prebuilt libraries
in the NDK.

This change rolls gyp to include the required makefile generation
changes, and adjusts the chromium side to match:

1) Stop setting use_system_stlport and instead use the NDK stlport by
   specifying LOCAL_NDK_STL_VARIANT := stlport_static

2) Remove support for the use_system_stlport flag entirely as WebView
   was the only user.

3) Don't try to link standard libraries like -lc -lm as the NDK does
   this automatically.

4) Don't include the OpenAL headers from frameworks/wilhelm; these are
   already part of the NDK with no special include path needed.

BUG=409851

Review URL: https://codereview.chromium.org/571953002

Cr-Commit-Position: refs/heads/master@{#300212}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0a93e49..d1f9de7

TBR=

Review URL: https://codereview.chromium.org/644203003

Cr-Commit-Position: refs/heads/master@{#300211}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/38b0e5f..0a93e49

TBR=

Review URL: https://codereview.chromium.org/664823002

Cr-Commit-Position: refs/heads/master@{#300210}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c8c9c60..38b0e5f

TBR=

Review URL: https://codereview.chromium.org/665723002

Cr-Commit-Position: refs/heads/master@{#300209}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2b06b87..c8c9c60

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/663943002

Cr-Commit-Position: refs/heads/master@{#300208}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c6d24c6..2b06b87

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/659793006

Cr-Commit-Position: refs/heads/master@{#300207}

The real changes are in mojo_url_resolver*.

The rest are renames that were generated with the following commands:

git grep -l 'mojo:mojo_' | xargs perl -pi -e 's|mojo:mojo_|mojo:|g'
git grep -l 'mojo://mojo_' | xargs perl -pi -e 's|mojo://mojo_|mojo://|g'
git cl format

Review URL: https://codereview.chromium.org/668483002

Cr-Commit-Position: refs/heads/master@{#300206}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c7265cd..c6d24c6

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/662933002

Cr-Commit-Position: refs/heads/master@{#300205}

REJ or an SHLO to count. This should mean that anytime confirmation is
required, the handshake should be at most 1 effective RTT whereas
currently they can be 2 RTT.

Review URL: https://codereview.chromium.org/656303004

Cr-Commit-Position: refs/heads/master@{#300204}

BUG=angle:799

Reenables OES_texture_npot on AMD Windows7+ in D3D9.

Review URL: https://codereview.chromium.org/665543003

Cr-Commit-Position: refs/heads/master@{#300203}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8bd25a0..c7265cd

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/662823003

Cr-Commit-Position: refs/heads/master@{#300202}

GetShortData() and IOHIDElementGetUsage() both return uint32s, so raise the size
of various containing types to uint32.

I tried to look in the USB HID spec to see if any of the affected fields here
were limited to e.g. <2^16, meaning that it'd be safe to just cast down to the
existing uint16s instead, but I couldn't find any limits.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/656583003

Cr-Commit-Position: refs/heads/master@{#300201}

TestingAutomationProvider is dead, Jim.

BUG=154997
TBR=jam,sky

Review URL: https://codereview.chromium.org/660353002

Cr-Commit-Position: refs/heads/master@{#300200}

Previously, the logic for history swiping depended on the relative Y distance
of the gesture's current location from the gesture's start location. Gestures
which consisted of a large up motion, followed by a large down motion, followed
by a horizontal motion could still cause history swiping. The new logic depends
on the total Y distance of the gesture, which fixes this problem.

This CL also includes a change to allowed the gesture recognizer state machine
to enter the state kCancelled directly from the state kPending. Previously, it
was possible for the history overlay to show for a very brief period of time
even if the gesture was about to be cancelled.

This CL also includes a minor refactor:
 - Renamed several methods to better reflect their intended purpose.
 - Removed lastProcessedGestureId_ and currentGestureId_, which did not cause a
 functional change.

BUG=421629

Review URL: https://codereview.chromium.org/657323003

Cr-Commit-Position: refs/heads/master@{#300199}

The python wrapper CL just landed. I'd like to see it work as expected for some iterations on Linux, before starting to use it on Windows as well. So for now, just fixing the path to the file used on Windows.

BUG=

Review URL: https://codereview.chromium.org/661193003

Cr-Commit-Position: refs/heads/master@{#300198}

BUG=

Review URL: https://codereview.chromium.org/667523002

Cr-Commit-Position: refs/heads/master@{#300197}

BUG=422727

Review URL: https://codereview.chromium.org/644323002

Cr-Commit-Position: refs/heads/master@{#300196}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/49386a6..8bd25a0

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/653763003

Cr-Commit-Position: refs/heads/master@{#300195}

This extracts the signing/verification functions, so the subsequent RSA-PSS changelist is easier to follow.

BUG=399090

Review URL: https://codereview.chromium.org/662533002

Cr-Commit-Position: refs/heads/master@{#300194}

BUG=424680

Review URL: https://codereview.chromium.org/661073003

Cr-Commit-Position: refs/heads/master@{#300193}

* New ContainerParams
 -  default_parent to specify the default parent when no
    transient parent is specified.
 - modal_container_priority now controls the modal container
   used for a modal window created for the given container.
 - if not specified, it will fallback downwards to find one.
 - if window is specified as always_on_top, it will use top
   most modal container.

* Changed network selector/shutdown dialog to use the new API.

* Other change:
 Separated test windows to athena/test/base/test_windows.h

BUG=410499
TBR=sky@chromium.org,reed@chromium.org
TEST=coverd by unit tests

Review URL: https://codereview.chromium.org/662763002

Cr-Commit-Position: refs/heads/master@{#300192}

Using this option causes the tests to fail immediately with an
exception, so this option has been removed in order to fix the tests.

BUG=423916

Review URL: https://codereview.chromium.org/667463003

Cr-Commit-Position: refs/heads/master@{#300191}