GitLab

This reverts commit 9d6a01ba.

Reason for revert: Breaking GPU tests on GPU FYI waterfall and on ANGLE's CQ.
Bug: 1014659

Original change's description:
> Add field trial testing config for BoostThreadPriorityOnLibraryLoadingAndBackgroundMode.
> 
> This experiment enables:
> - Use THREAD_MODE_BACKGROUND_BEGIN/END to set the priority of
>   background threads. This affects memory and IO priority in addition
>   to CPU priority.
> - Increase thread priority to "normal" in scopes where background
>   threads load modules.
> 
> The expectation is that this will improve responsiveness of Chrome
> (input delay, first contentful paint), without regressing jank.
> 
> We are adding the testing config in preparation for enabling this
> via Finch in M79.
> 
> Bug: 973868
> Change-Id: I467cae12503e3ad724b665f3aebdaeb94e1325c9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835023
> Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Auto-Submit: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#705960}

TBR=fdoray@chromium.org,rkaplow@chromium.org

Change-Id: I509cbe39c2d4f91859f5e8614d7d8f8d819d3a7d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 973868
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862858Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706145}

TBR=croleau@chromium.org
NOTRY=true

Bug: 1014655
Change-Id: Ibf5e367a218502b2d46f8d4dac838355344c6f52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862853
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706144}

Bug: b:141606892
Change-Id: Ia67acf9d6218f5da33649561da4fed8a60298081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845234
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706143}

Update ExtensionsClient to use that constant.
Also, fix tests using channel overrides to use the more specific
channel: canary instead of trunk. This is done by providing an
override channel class called
ScopedExtensionAPIEnabledInServiceWorkersChannel.

Bug: None
Change-Id: I890a738c66522d4541e24c61761b82aa1bff1ad6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841932Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706142}

Fetch shared library file data from the implementation package to
construct the correct asset path when using a Trichrome APK.

Change-Id: Id7bd259e5be182d6b13828235636d41b812ffdbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829867
Auto-Submit: Richard Coles <torne@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706141}

Before r705637, these images were inlined with Grit's flattenhtml attribute.
After that CL, flattenhtml was removed, but the images were not registered
with the corresponding WebUIDataSource, resulting in a broken URL request
for chrome://sync-confirmation/images/sync_confirmation_illustration.svg

Fixing by individually registering those images with the WebUIDataSource.

Fixes: 1014447
Change-Id: I198b99030f46fccc7dc38ad6d80a7a89da2a9ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863350
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706140}

Today if a parallel request is interrupted, the download will get
immediately interrupted if the request's slice is not recoverable.
This is causing issues that a failed parallel request may block
the download from auto resuming due to its interrupt reasons.
And for poor networks, each request can contribute to download
interruption, and causing the http handshake to start over and over
again.
This CL addresses the above issue by letting non-failed request
to keep going until they finish their slice. Once a slice is
completed, it will interrupt the download with a CONTENT_LENGTH_MISMATCH
error if all other parallel requests have terminated, so that the
download can be automatically resumed afterwards.

BUG=1011427

Change-Id: Iee1a02e7b45f79b4e8383942405e9f09d29f6e92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850773
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706139}

https://skia.googlesource.com/skia.git/+log/fb6a1abe4567..c594e6269813

git log fb6a1abe4567..c594e6269813 --date=short --no-merges --format='%ad %ae %s'
2019-10-15 egdaniel@google.com Plumb GrColorType through all ops/processors that sample textures.
2019-10-15 brianosman@google.com Add interactive demo to particle gallery

Created with:
  gclient setdep -r src/third_party/skia@c594e6269813

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=csmartdalton@google.com

Bug: None
Change-Id: Ia6c904246ab5898b0fd2c9f57948f0b0eb838a7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863566Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706138}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/14df22429d27..43253cb0a391


Created with:
  gclient setdep -r src-internal@43253cb0a391

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:140584925
Change-Id: I2b4d525a3901463decfb843d5717bbf7e8da8f16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863565Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706137}

Pages like web_tests/compositing/overflow/nested-render-surfaces-with-rotation.html
create RenderPasses (and SharedQuadStates) that have layer rects offset from
(0, 0). This seems connected to the border width of the owning DOM element.
Regardless, these edges are not clipped and DrawQuads should be anti-aliased if
they line up with the non-zero edges.

Bug: 1013735
Change-Id: Ib97e6f9a0f7f56f4926d1a209365d3c3f11a6e38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860098Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Cr-Commit-Position: refs/heads/master@{#706136}

This patch saves the unconstrained intrinsic box size during the
block layout algorithm in order to use it for overflow calculation
in the node. Since we can override the intrinsic size with css-content-size,
we may cause scrollbars to appear. By using unconstrained size, we retain
correct behavior in which scrollbars only depend on the child content,
and not on content-size override.

R=chrishtr@chromium.org, ikilpatrick@chromium.org

Bug: 991096
Change-Id: I0d9cb270ee710b759f93202497f69bf72544f81a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833074Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706135}

https://quiche.googlesource.com/quiche.git/+log/f76cf2ae5e7a..abb67699b6e2

$ git log f76cf2ae5..abb67699b --date=short --no-merges --format='%ad %ae %s'
2019-10-15 fkastenholz Remove unneeded "#ifdef undefined" code.
2019-10-15 wub Add quic_framer_process_data_packet_fuzzer, a fuzz test for QuicFramer::ProcessPacket where the packet has a valid public header, is decryptable, and contains random QUIC payload.
2019-10-14 dschinazi Verify receipt of connection_close in quic_client_interop
2019-10-14 renjietang Remove virtual keyword for unoverridden QuicSession::IsCryptoHandshakeConfirmed().
2019-10-14 dschinazi Refactor interop result D in quic_client_interop_test
2019-10-14 dschinazi Add retry support to quic_client_interop_test
2019-10-14 dschinazi Allow passing URL to quic_client_interop_test
2019-10-14 renjietang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_active_streams_never_negative

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: Idd25c7192f33c94da9b67a04f03b39706b9530b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862657
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706134}

Bug: 830786
Change-Id: I6f8318f871bbded0a7bc4787e921b6b190a5da77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847793
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706133}

- This CL is in anticipation of the Show More feature to be implemented
  for Saved printers.
- The behavior of CupsPrintersEntryList will soon have customized
  features for saved printers.
- CupsSavedPrinters and CupsNearbyPrinters will now have their own list
  to manage.

Bug: 993822
Test: end to end manual, browsertest
Change-Id: I58d9f4a9920decbb5f4eab23505be52d962e90a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835703Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706132}

Some CORB tests run in parallel, because they use `async_test`.  See
https://web-platform-tests.org/writing-tests/testharness-api.html#asynchronous-tests:
"Keep in mind that other tests could start executing before an
Asynchronous Test is finished."

This CL fixes such tests, to make sure that they either migrate to
`promise_test` [1] or avoid using shared/global state.

[1] https://web-platform-tests.org/writing-tests/testharness-api.html#promise-tests
says "Unlike Asynchronous Tests, Promise Tests don’t start running until
after the previous Promise Test finishes. Under rare circumstances, the
next test may begin to execute before the returned promise has settled.
Use add_cleanup to register any necessary cleanup actions such as
resetting global state that need to happen consistently before the next
test starts."

Bug: 1011410
Change-Id: Ib369e6cd07aed2daaf6347ae5d6f777a2c0835db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841898
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706131}

These tests have been stable and run for quite a long time.
So, it's safe to remove the experiment now.

Bug: 700309
Change-Id: Ic9138013913dfd841cbb9ffa23fc27d3e790bf84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862462Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#706130}

The cookies used in the test don't explicitly specify SameSite
attribute, so eventually they'll be interpreted as 1st-party only.

Adjust the code in tests that queries them to delcare itself as 1st
party so it can actually see them.

Bug: 1006816
Change-Id: Ied26333b46fa76142580fbb0dabdcb0df25a08e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856887Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706129}

Change-Id: Ib6a0f9829dfe781c9d66c9d62fb950f92b9a1c42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860497Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Chris Dalton <csmartdalton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706128}

Bug: 989978
Change-Id: I8b943250012cdc6e1a253905aa5dc8e65690ece6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856920Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706127}

Only one ScopedFeatureList::InitXXX function should be called on
a particular ScopedFeatureList instance. If any Init functions are
called more than once, it will hit DCHECK(!init_called_) in
ScopedFeatureList::InitWithFeaturesImpl.

Refactor feature enabling so that the desired features are sent as
a vector of features in one call to ScopedFeatureList::InitWithFeatures

TEST=video_encode_accelerator_unittest does not hit DCHECK
BUG=none

Change-Id: I445ea51740b93361c771450e47cd31300ae13c69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862257Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Drew Davenport <ddavenport@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706126}

It may be the wrong year to do this, but fixing 22 tests with such a
tiny effort still seems worth it. :)

Bug: 829028
Change-Id: I5e34fc18edcb063d125933aac9174ff08a5acc40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860421
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706125}

This change updates the position of the slider ticks to be below the
slider (overlapping the thumb by 1 pixel) and shortens the ticks by 2 pixels
(from 6 to 4)

Bug: 1014373
Change-Id: I498e8f76259f677378f6ec5af4780e74653c8a12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860513
Commit-Queue: Alex Keng <shihken@microsoft.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706124}

This CL adds four new danger types to correspond to new UX for the result
of download deep scanning. BLOCKED_TOO_LARGE will be generated for downloads
that are supposed to be scanned (per the policy), but is not due to the
file size. SENSITIVE_CONTENT_WARNING is generated for downloads that contain
sensitive content violations, and the recommended behavior is warnings.
SENSITIVE_CONTENT_BLOCK is generated when the recommended behavior is blocking.
DEEP_SCANNED_SAFE is generated when the scan completed successfully, and
no danger was identified.

Bug: 980777
Change-Id: I2cce35c256b1095172fcc23bab946503d77a1536
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845675Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706123}

https://android.googlesource.com/platform/external/perfetto.git/+log/12dc10e0278c..3dbb965bdf76

git log 12dc10e0278c..3dbb965bdf76 --date=short --no-merges --format='%ad %ae %s'
2019-10-15 oysteine@google.com Merge "Moved the StackProfileTracker to the ProtoIncrementalState"
2019-10-15 fmayer@google.com Merge "Set incremental_state_cleared on first packet."

Created with:
  gclient setdep -r src/third_party/perfetto@3dbb965bdf76

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: Ie53a1de9585c0ce3497c47a756430b9addaa0677
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863112Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706122}

Also re-enable QUIC end-to-end test since a fix for it has landed.

R=rch@chromium.org

Bug: 1010206
Change-Id: I76fb982e82fd9b5b4d1ed6f2f72aea14e12d6272
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860595Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706121}

Disabled due to failure on win10, but test passes now on win10.

Bug: 1009016
Change-Id: I9c530d8fe33e0f06bf2a810fa6958545e195487b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863569Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#706120}

We used to check that bridge fails on receiving NigoriSpecifics with
default passphrase type. It's wrong, because default passphrase type
is IMPLICIT_PASSPHRASE, which should be supported.

The purpose of this test is to check that bridge fails on receiving
specifics with some new passphrase type, which is not supported on
current client. With NigoriSpecifics::passphrase_type being converted
to int, it means value out of PassphraseType enum.

Bug: 922900
Change-Id: Ia5bbb39afb17c0a31ba7847d9a1e233cdee4c5dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862674
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706119}

This test was disabled a while ago for issues with site isolation. At
this time the test passes 100 iterations locally, so I'll enable it for
now and hopefully the underlying flakiness is fixed.

Bug: 648406
Change-Id: I32ccea18e684a112753e90ea63c1daa80b8a2be8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863591Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706118}

As outlined in design sketches
https://docs.google.com/document/d/1ChpbGA1M6aYxH9wqQYXQcvXZiVikeLI3JJP-fkezKP8/edit
and
https://docs.google.com/document/d/1QO99UstlPTY8eK4Lnc9qcNq3wQYTBDBsRZu6nGC4XG4/edit

introduce a FrameHost interface in blink so that blink can talk directly
to the RenderFrameHostImpl and not go through a public blink API.  ie.
the API becomes a mojo interface.

BUG=1008432

Change-Id: I98ef40c08b93f4a1fbc2e3ecad92a88bbbdcfc59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826988Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706117}

sqlite 3.30.1 update changes:
https://www.sqlite.org/releaselog/3_30_1.html

Bug: 1013400
Change-Id: Ifad0ab8d46541d2ef8119d9b8065173ec94cdfe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860937Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706116}

Looks like it was switched to use installationSettingsDialog in
oobe_eula.html

Bug: none
Change-Id: I409ed0b6c468af51ada1902e9fc8266519b737e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862461Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706115}

Collapse block margins between sibling spanners and add inline margins,
including auto margins.

We now position spanners correctly.

Bug: 829028
Change-Id: I07b5c1af92852d385cf558db6c20de61e88d87d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860419
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706114}

* Rename the "NotifyXYZ" methods into "OnXYZ" which is more idiomatic
  for callbacks, and makes things more consistent across the app list
  classes (instead of having both, depending on the class).
* Change the notion of "target visibility changed" to "visibility
  will change".
* Remove "AppList" from within the method names when "AppList" is
  already part of the class name (i.e. except for observers outside
  of app_list).

This is purely a name change and has no user-visible effects.

Change-Id: I37dfe742d50e516bd70d78b037b867486230a8eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861018Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706113}

Bug: 876601
Change-Id: I49c8f9730adf76a6612cb108785145465c3b640f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861112
Auto-Submit: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706112}

There was only one caller in system_fonts_win.cc and it is better
served with a direct call to SystemParametersInfo.

BUG=

Change-Id: Icd3f4e6e27d50d8569e602cb0eeace2c6dd530a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861109
Auto-Submit: Robert Liao <robliao@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706111}

Because kEvaluateScriptMovedBetweenElementDocuments UMA
has been 0 for a week on canary,
it seems also safe to stop executing such scripts.

We still keep the use counter to confirm that
such cases are really rare on stable channel.

Bug: 721914
Change-Id: I2b4963321f6e81284b9baac22ee5d5f9e3df7484
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854643Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706110}

Now we only use valid UTF8 strings. Also, the session_id string must
begin with "{", end with "}", and be nonempty, according to DCHECKs in
MakeProtocolRequest.

Bug: 1014625
Change-Id: If30c9b21f63c7cab7a01f456ec0593971ef1bc37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863669Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706109}

They will need to be marked explicitly and secure, so adjust some tests to
be over SSL and mark those cookies appropriately

Bug: 1006816
Change-Id: I6da53ea64a7c03530335913fadb9099992e8ca33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863389Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706108}

SCHEMA_ALLOW_INVALID strategy is used only for ManagedBookmarks policy
and is considered for deprecation.
Adding UMA metrics to check how ofter this strategy is useful in reality

Bug: 969706
Change-Id: I0dee14588d48ce30e83cbd14cacc0375e3fa1a0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841031Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Auto-Submit: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706107}

Due to some recent changes in how the fragment works, the browser tests
were crashing on Android.

Change-Id: I5302c63f1f02eccdac3d5e95fe711a9d24048cb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863592Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706106}