- 27 Sep, 2019 40 commits
-
-
Kent Tamura authored
The test added by crrev.com/700572 and crrev.com/700584 collided. This CL fixes the autofocus test path in state-restore-dynamic-controls.html. TBR=masonfreed@chromium.org Bug: 1000926 Change-Id: I3e3fcbbbb280991cf5907250d3e72663682c0911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828769 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#700705}
-
David Bokan authored
The TRACE event in GestureEventQueue::PassToFlingController was inappropriately named. This CL moves it to FlingController and renames it to be accurate. Also added some instant events for when the event is filtered to aid debugging. Change-Id: I96d96e9cc3c758e822d3756df2139296a017b7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828110 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#700704}
-
Boris Sazonov authored
This is a follow-up to https://crrev.com/c/1821784 that removes ChromeBrowserSyncAdapterService from AndroidManifest. Please note that chrome/android/java/res_template/xml/syncadapter.xml is kept in the repo for the time being, as it is being used downstream. This file will be removed in subsequent CLs. Bug: 1002894, 1008314 Change-Id: I7aa5fd7e2b5c982192aa07970d7400945f95116f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827413Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#700703}
-
Rune Lillesveen authored
Shorthand properties containing var() references are represented as CSSPendingSubstitutionValues. The style value factory had casts ignoring this fact which caused crashes. Bug: 1007866 Change-Id: I8d83ba03ce6e4d3a8ce7d2ced949a4bd5ab1072e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827016Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#700702}
-
Findit authored
This reverts commit 551bbdf8. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 700645 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNTUxYmJkZjhjN2UyNWJhN2E1ODdjMmFkOTJkMmQ0ZDUyNTI2MzY4ZQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/82259 Sample Failed Step: browser_tests Sample Flaky Test: ProfileMenuClickTest_SyncError.SetupAndRunTest/5 Original change's description: > [profile-menu] Implement sync states > > Sync-is-on and sync-error states are added > to the profile menu. > > Bug: 995720 > Change-Id: I8e1b385298464dc57990cb75cec397851197cb30 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827423 > Commit-Queue: Thomas Tangl <tangltom@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700645} Change-Id: I1abe2790f5bd1d2311189b98a6386eaf7ed8e081 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 995720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829025 Cr-Commit-Position: refs/heads/master@{#700701}
-
Omer Katz authored
During clearing of weak member, IntersectionObserver's disconnect method can be called. Disconnecting IntersectionObserver also removes tracked elements from the Document's IntersectionObserverController. If the controller was not yet allocated, it will be allocated during the call. This results in an allocation during atomic pause (when allocation is not allowed). In practice removing an element from a newly allocated controller doesn't do anything. Thus the fix is to only remove the element if we already have a controller. Bug: 1005208 Change-Id: I46b3e2657d72ac52d71f76382c8481c99ae8fdb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829097Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#700700}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f8bb908702bd..a0159c03485b git log f8bb908702bd..a0159c03485b --date=short --no-merges --format='%ad %ae %s' 2019-09-27 jaedon1.lee@samsung.com Vulkan: Implement basic geometry shader feature Created with: gclient setdep -r src/third_party/angle@a0159c03485b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I06fce4da000a5a3bb8acadae0aafb28229d6cc8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828852Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700699}
-
Dominic Battre authored
This CL replaces the traing for form elements via WebSelectElement/WebInputElement by using unique renderer IDs. It does not fix all leaks by Autofill, yet. TBR=jochen@chromium.org Bug: 949587 Change-Id: I824c186fe0ef5c72d3df594e1218a61b6893a6d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827014 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#700698}
-
Khushal Sagar authored
Its common for snapshots to be used on the same context where canvas is rendered. Generating a sync token in this case unnecessarily issues an ordering barrier. R=fserb@chromium.org Bug: 1005074 Change-Id: Id10ec4d4f9f2736234130ad2a30d5ed743bdc9ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827948 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#700697}
-
Francois Doray authored
With this CL, we store the render_process_id and render_frame_id (if any) associated with each receiver in LockManager. This is a prerequisite to build a Web Lock observer interface, through which code outside of //content can know which frames hold lock and avoid freezing them. Bug: 980533 Change-Id: Id72c23e0ebd4d30f1efe68b8115b7e63f3af31c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756766Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#700696}
-
Vadym Doroshenko authored
Bug: 999871 Change-Id: Icb6c3852009130d3486f94f80d21e3d6425785cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829079 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#700695}
-
Mikhail Khokhlov authored
This CL allows to run a standalone Results Processor with any output format that has a formatter defined in processor.py. This is useful for external clients which do not need to wait until Telemetry is fully switched over to results_processor formatters. Bug: 981349 Change-Id: I4c7850a7c044d3926d9359769ab23e780ab31910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823864 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#700694}
-
Luca Hunkeler authored
Bug: b/141610802 Change-Id: I1d6b16883a89d2f398657530ada42018e1963818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827410Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#700693}
-
Boris Sazonov authored
Change-Id: I40b60b41d8050d52ebed4c16e70ee69618f2ddcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829078 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#700692}
-
Mikhail Khokhlov authored
Histograms output format requires tracing module, so we need to add it to path. Bug: 981349 Change-Id: Id4980fbdb6e1baa27328dc5710c3021e63910dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828901Reviewed-by:
-
Lily Chen authored
This change makes the ThirdPartyMetricsObserver browsertests work under the new SameSite cookie changes (SameSiteByDefaultCookies and CookiesWithoutSameSiteMustBeSecure). Also makes a drive-by change to the behavior of the ThirdPartyMetricsObserver on URLs without a registrable domain, e.g. IP addresses, "localhost", TLDs. In these cases, the hostname is used instead of returning early from OnCookiesAccess(), i.e. this causes a third party access to be logged instead of not logging. This is consistent with cookie parsing behavior, for which the domain is assumed to be the hostname and the cookie is still accepted, if no registrable domain is found. Bug: 1006816 Change-Id: I4f8bef6656849de05911e30522c36858d8ed5f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815915Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#700690}
-
Jan Scheffler authored
This cl changes the coverage graph in the timeline to show the coverage relative to the currently loaded size instead of the total size at the end of the timeline. Screenshot: https://imgur.com/a/rm8TmDQ Bug: chromium:1004203 Change-Id: Ie405c1be365aea8f0847f431a85e6d5feccc814e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824105Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#700689}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dcf01fe4d418..097e2c1cf9b4 Created with: gclient setdep -r src-internal@097e2c1cf9b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I04a15ee6821d0a83fe322fe6636a7d292432360a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828245Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700688}
-
Marc Treib authored
These two types are deprecated and can be removed. Note that SUPERVISER_USER_SETTINGS and SUPERVISED_USER_WHITELISTS are *not* deprecated. This includes removing the ModelType enum entries, removing the fields in the EntitySpecifics proto, and deleting the specifics proto files. Bug: 965503 Change-Id: I53038fdc28ed8518cd99d4a4769b5f1f52d3e94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824882 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#700687}
-
Vasiliy Telezhnikov authored
This CL re-enables ETC1 thumbnails for vulkan as we have ETC1 support in |WrappedSkImage|. Bug: 906794 Change-Id: I3da64071970b36bd0e5c17eacc62ef46d0a85d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822023Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#700686}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/711cccd3a162..f13084ded0d6 git log 711cccd3a162..f13084ded0d6 --date=short --no-merges --format='%ad %ae %s' 2019-09-27 lalitm@google.com Merge "trace_processor: add tracks for Chrome legacy instants" Created with: gclient setdep -r src/third_party/perfetto@f13084ded0d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ic651c4a76ec492612408e90c2201bbac7d81cbdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828248Reviewed-by:
-
Miyoung Shin authored
This change converts SmsReceiver mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I8836c05492638350bc53e2bb1c4a4ede9cc2285f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824734 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#700684}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1903a35e00e8..bc8049ef0bc6 git log 1903a35e00e8..bc8049ef0bc6 --date=short --no-merges --format='%ad %ae %s' 2019-09-27 ilnik@webrtc.org Reland "VP9 encoder: handle disabled layers correctly" 2019-09-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 42b9d99d..e76bf0b8 (700503:700610) Created with: gclient setdep -r src/third_party/webrtc@bc8049ef0bc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I20f369bb07ebd87e221ef192d3179de890e1cfae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828619Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/377dc2ac..791dddd6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie968ecb156900273e7704adb65ea7055406d2e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828601Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700682}
-
Mohamed Amir Yosef authored
TBR=mkwst@chromium.org Changge-Id: I766da46a59f69b4ced092bbc03763c4827727bf5 Bug: 949519 Change-Id: I65243fae667d5ca348871b00e14bab179cc54e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828903 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
arthursonzogni authored
TBR=nasko@chromium.org Bug: 995428, 968529 Change-Id: I830ffc2acab8e9b52d06a89f6fb101a237d79d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807309Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#700680}
-
Justin Cohen authored
This appears to have been fixed by iOS within the past year. Disabling this flag so we can test various configurations. Bug: 887497 Test: Test bug on various iOS versions. Change-Id: I70957e4bddfa42e58c28a1445faa2dd71a8c74b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827409 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#700679}
-
Mikel Astiz authored
This information is already sent to other servers such as the one used for omnibox personalization, hence the patch doesn't upload additional information but allows measuring the impact variations have on the sync server and debug errors caused by client-side experiments. Bug: 887521 Change-Id: I3358956639bf96260bb5010279012195086eec37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827368Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Justin Cohen authored
It's possible for there to be pending navigations for a session that is going to be restored (such as for the -ForwardHistoryClobber workaround). In this case, the pending navigation will start while the navigation manager is in restore mode. There are other edges cases where a restore session finishes without trigger it's start, such as when restoring some with some app specific or blocked URLs, or when WKWebView's backForwardList state is out of sync. Bug: 1008026 Change-Id: I2d4d41321a21f8dad8acf72c8e8529ac73ea7d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826890Reviewed-by:
-
Mark Cogan authored
Currently, TabModels create and own their WebStateLists. A Browser creates a TabModel, and then exposes its WebStateList. There are two problems with this. First, TabModel is being actively refactored away. Second, because TabModel is an Objective-C object, this makes it hard to reason about when the WebStateList will be destroyed, which makes things like dangling observers hard to catch (see crbog.com/1001960, for example). This CL changes this ownership. Now, BrowserImpl creates and owns the WebStateList, and it passes a (weak) pointer into TabModel. TabModel's existing -browserStateDestroyed method is called when the Browser destructs, and the contract of that method is that the TabModel should tear down its interactions with the Browser and BrowserState, and it (the TabModel) should be removed soon thereafter. BrowserImpl now also creates and owns the web state list delegate; its current role is just to attach tab helpers each time a web state is added to the list. This used to be named TabModelWebStateListDelegate, but this CL renames and moves it to be BrowserWebStateListDelegate. Various tests need to now create web state lists (and, thus, web state list delegates) to inject into tab models. -browserStateDestroyed is renamed to -disconnect to match other code. Because a test in ios_internal/ uses the existing TabModel initializer, it needs to be kept functional (which involves it creating an internal web state list). This will go away as soon as possible, once this CL lands and the internal test can be cleaned up. Bug: 1001960 Change-Id: I8d8886bbbedc4c701ae0956d0f5e0984812b725b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796358 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#700676}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1a233ab5. With Chromium commits locally applied on WPT: 561a338c "Convert SensorProvider client to use BrowserInterfaceBroker" b5630d76 "Convert NFC client to use BrowserInterfaceBroker" 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie5e9f7fbee44ec6650c2c0105b762abc07bd4656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828600Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700675}
-
Lily Chen authored
This test was previously setting a CanonicalCookie that had SameSite set to NO_RESTRICTION (i.e. SameSite=None), but which was not secure. Under CookiesWithoutSameSiteMustBeSecure, this causes the cookie to be rejected. (crbug.com/1002052) This change fixes that test to use a Secure cookie, so that it will still work when CookiesWithoutSameSiteMustBeSecure is enabled. Bug: 1006816 Change-Id: I9eb3942d0af09740c42a41c5e4c8f3ce0fef7959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827748Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#700674}
-
Mohamed Amir Yosef authored
Those varialbes are used from the old parser which isn't used anymore. Change-Id: I00c936090d432572d8bdee70c5312444a37fd3c0 Bug: 949519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828958 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Matthias Körber authored
Change-Id: Ib09a8ab819e2160c20c4424173d1e92fb1efc18f Bug: 875768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823843 Commit-Queue: Matthias Körber <koerber@google.com> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Matthias Körber <koerber@google.com> Reviewed-by:
-
Sergey Poromov authored
http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html is failing: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/19952 TBR=szager@chromium.org Bug: 1008826 Change-Id: I81121e049b08a21d70d4126d5b5839302c79998b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827375Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#700671}
-
Kuo Jen Wei authored
Consider shelf on left/right or top/bottom side, either width or height of window outer bound equal screen size should be fullscreen. Bug: 1008347 Test: Cases of shelf on left/right or bottom, window resizing related function works as expected. Change-Id: Id381bac95c9287e3febfdebb6ac74333283f7071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828784 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#700670}
-
Robbie Gibson authored
The root cause here was that the image wasn't a template image, so it wasn't being tinted. Bug: 1008381 Change-Id: Ie6f53e08cf3375a5c47f9bac453bf3a8239c11f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827408Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#700669}
-
Mohamed Amir Yosef authored
Change-Id: I5f731f453c85d8575d488316a0ff7137a5c34422 Bug: 949519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814832 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Amr Aboelkher authored
A device policy which controls the mono audio accessibility feature on the login screen.The policy can be applied as a recommended or mandatory policy. Test: 1. Set the login_screen_mono_audio_enabled policy to True, open System Tray => "Accessibility", check that "Mono audio" is displayed with a green check in the login screen. 2. Set the policy to False, open System Tray, check that "Mono audio" is not displayed in the login screen. Bug: 552439 Change-Id: I3ac0d02fc6dfe31874981fd5b8867ed4b19fb912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815124 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#700667}
-
Maksim Moskvitin authored
Both client tag and its hashed version were represented by std::string. Given it makes some confusion and leads to API misuse, hashed version is now represented by dedicated class. Bug: 973409 Change-Id: I08a0a43fc699435d5f9f850b26c0771a267aaa55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824090 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
-
