- 03 Apr, 2020 40 commits
-
-
Owen Min authored
Disable the test on other platforms because the test is also timeout on them. Bug: 403325 Change-Id: I5e544c8392f69c251a9da6c327d6eadce9b53e76 Tbr: wjmaclean@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136030Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756420}
-
Anders Hartvoll Ruud authored
The properties defined by css-logical (and more generally surrogates) pose a hard problem for 'revert' in the StyleCascade, because declarations such as 'margin-bottom:revert' may actually need to revert to a different property in the previous origin (e.g. margin-block-end). An example is the h1 element, which is styled by html.css using css-logical properties. When the author then reverts using a corresponding physical property, we can't simply look up the cascaded value for that same physical property in the UA origin: we must be aware that the css-logical property won the cascade _at that level_. So when we we're applying an author declaration 'margin-bottom:revert', we have to find the *target property* for the revert, which is either margin-bottom (if that property won the cascade at the target origin), or the corresponding css-logical property. However, to find the target property, we need to know during the application of margin-bottom that a corresponding logical property (surrogate) needs to be taken into account. AutoSurrogateScope was created for this purpose, which sets (and resets) a "current surrogate" field on CascadeResolver. This current surrogate is used when resolving reverts, in order to find the correct target property. Also, we don't control the order in which physical/logical properties are applied. This means we could be applying the physical property first, which is unaware of any logical properties that should have been taken into account for revert. In other words, if we apply 'margin-bottom:revert' without the context of a "current surrogate" set, we'll fall back to unconditionally using margin-bottom as the target property, which may be incorrect if there also exists a logical property we'll get to later. This is why the force-reapply code exists: when both the physical and logical property exists in the cascade, the physical property must be applied (or re-applied) during AutoSurrogateScope, otherwise revert will not behave correctly. Bug: 579788 Change-Id: I864a4c9afdd94f130c42635d28d45c843d5fb617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130850 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#756419}
-
Mustafa Emre Acer authored
This CL introduces the ability to observe mouse clicks when a page with a delayed SafeBrowsing warning is loaded. If the feature parameter "mouse" is enabled, the warning is immediately shown on mouse click. Otherwise, a metric is recorded the first time user interacts with the page. Bug: 1057157 Change-Id: If81e9c5867b7e72703a284b8226e2987f5edf3d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120428 Auto-Submit: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#756418}
-
Lukasz Anforowicz authored
This CL is a step toward |request_initiator_site_lock| enforcement. This CL adds a call to mojo::ReportBadMessage when |request_initiator_site_lock| doesn't match |request_initiator|. OTOH, for now such request is not rejected as |!IsSane|. Hopefully the extra DwoC reports will help us make progress on https://crbug.com/1056949 (especially in presence of other mojo::ReportBadMessage fixes like https://crbug.com/987986). Bug: 920634 Change-Id: I454b67f2ad486c7cf65f4df1c9fa18bb3e5376eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112751Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#756417}
-
Gang Wu authored
TBR=tedchoc@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1067719 Change-Id: Iececd4ad6ed0c016f12391148dd571623705e00b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136088Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Auto-Submit: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756416}
-
Mansi Awasthi authored
Bug: 1030242 Change-Id: I84a837b95eb48f05c144bf47d557bbcf303fa78c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135101 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#756415}
-
Michael Thiessen authored
This is just a precautionary change, as most launchFlags are not useful for launching apps from Chrome, and present an attack surface by allowing app launches to do interesting things like manipulate task stacks, prevent transition animations, etc. Bug: 1054826 Change-Id: I744e48476f7d2a88f7802cefc553b5c12748a470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128232Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#756414}
-
Xianzhu Wang authored
This fixes a regression caused by crrev.com/710881. The reason is that before that CL, we had an extra level in GraphicsLayer tree (which was the root GraphicsLayer created by VisualViewport), and the frame overlays were added in that level after the root layer of the contents. With the CL, frame overlays and the top-level contents GraphicsLayers started to have the same parent, so the frame overlays may be behind the contents layers after later compositing updates. The problem affected "persistent" frame overlays such as the DevTools overlay which lives when DevTools is running. Now in FrameOverlay::UpdatePrePaint(), always keep the GraphicsLayer the last child of the root layer to ensure it's the topmost. This will slightly impact performance when there are multiple frame overlays which is rare. The next step will be to refactor FrameOverlay not to create GraphicsLayers, and to combine code paths for pre-CompositeAfterPaint and CompositeAfterPaint. Bug: 1057071 Change-Id: I0fed6e69d4a90b38b7a636712f4349e0985ff100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135891Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756413}
-
Wenyu Fu authored
NightMode is not default enabled (supported) for Kitkat testers. Set static test Boolean for NightModeUtil to avoid test errors on Kitkat. Bug: 1067575 Change-Id: I4062b97279904e08b61c568c89a421308542485e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135887 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#756412}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c89ca0ba09ed..b6e7ef1092b7 git log c89ca0ba09ed..b6e7ef1092b7 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 reed@google.com Use skvm infix in gradients 2020-04-03 csmartdalton@google.com Revert "Reland "Reland "Use glDraw.*BaseInstance calls to avoid deferred buffer binding""" 2020-04-03 csmartdalton@google.com Revert "Disable baseInstance on SwiftShader" 2020-04-03 csmartdalton@google.com Add an option to GrMeshTest to save to png 2020-04-03 mtklein@google.com remove little-used bit_clear() and bytes() 2020-04-03 csmartdalton@google.com Disable baseInstance on SwiftShader 2020-04-03 brianosman@google.com Switch back to stack-based SkSL interpreter 2020-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms bd0abcd0646a..60d5d65325e6 (1 commits) 2020-04-03 mtklein@google.com harmonize rewrite-includes and gn-format checks 2020-04-03 hcm@google.com Update release schedule, notes 2020-04-03 reed@google.com refactor colorspacexform for skvm infix 2020-04-03 csmartdalton@google.com Merge GrVkVertexBuffer and GrVkIndexBuffer into GrVkMeshBuffer 2020-04-03 csmartdalton@google.com gn format gn/gpu.gni 2020-04-03 westont@google.com Include fetch-gn in SKQP build recipe. 2020-04-03 bsalomon@google.com Don't require color type to make proxy copies. 2020-04-03 mtklein@google.com schedule() in place 2020-04-03 bsalomon@google.com Incorporate sample count into RTC fallback color type. 2020-04-03 brianosman@google.com In 3D sample, fix the matrix used for normal transformation 2020-04-03 mtklein@google.com eliminate use of Usage in finalize 2020-04-03 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 745e071241ab..1cc49bb2e230 (9 commits) 2020-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src deeb0d54..d086f1bd (467 commits) 2020-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader cb58662302c8..f99302c4efe6 (7 commits) 2020-04-02 bsalomon@google.com image_from_yuv_textures GM recreates YUVA image before each draw. 2020-04-02 csmartdalton@google.com Reland "Reland "Use glDraw.*BaseInstance calls to avoid deferred buffer binding"" Created with: gclient setdep -r src/third_party/skia@b6e7ef1092b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: I849b0b88602b09e409ed5705928b5788012d56b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135979Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756411}
-
Karandeep Bhatia authored
In certain specific and rare edge cases, we might end up setting ruleset prefs for an uninstalled extension. This can happen in: - RulesMonitorService::OnRulesetLoaded: This is dispatched when the extension rulesets are loaded. We reset the ruleset checksums if the extension was re-indexed due to a schema change. - RulesMonitorService::OnDynamicRulesUpdated: This is dispatched when the dynamic rules for an extension are updated on disk. Return early in both these cases to ensure we don't incorrectly modify extension prefs for an uninstalled extension. BUG=1067441 Change-Id: Ib2d1a94265ab73871b8ae791481fe0ec25234d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131222 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756410}
-
Matt Jones authored
This patch attempts to deflake more TabsTest tests by using the new TouchCommon infra and loading new tabs via the test rule. The test was run 100 times locally without flaking. Bug: 799728 Change-Id: Ic26b9fb5c25d911d13a0a6280357c91eef32985a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134652Reviewed-by:
-
Lukasz Anforowicz authored
This CL fixes a NetworkService DCHECK failure/crash that is behind the layout test flakiness under wpt/fetch/cross-origin-resource-policy as pointed out in https://crbug.com/1067445#c17. Bug: 1067445 Change-Id: I3c516a09f68a722f6dad555f6467379e7d8fe2d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136028Reviewed-by:
-
Danan S authored
Also improved some comments and renamed the following to clarify their purposes: section_container -> install_permissions_section_container ParentPermissionSecton -> ParentPermissionInputSection Finally, moved install_permissions_section_container and its enclosing scroll view into the scope of the code that adds extension permissions view. This removed dead space created by the scroll view in the case there were no permissions to display. Bug: 1052097 Change-Id: I1393d732504c82d586705257f1c1b125640db5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134911 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#756407}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2ce5fda2fea8..e06125cb520f git log 2ce5fda2fea8..e06125cb520f --date=short --first-parent --format='%ad %ae %s' 2020-04-03 amaiorano@google.com Fix Chromium and Android build 2020-04-03 bclayton@google.com Debug: Add missing include. 2020-04-03 bclayton@google.com Vulkan/Debug: Create a PhysicalFile if DebugSource has no content 2020-04-03 bclayton@google.com Vulkan/Debug: Always provide the dap::Source::path 2020-04-03 bclayton@google.com CMake: Don't always regenerate OpenCLDebugInfo100.h 2020-04-03 amaiorano@google.com CMake: use gtest and gmock targets 2020-04-03 amaiorano@google.com CMake: split out atsc-encoder into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: clean up cppdap usage 2020-04-03 amaiorano@google.com CMake: split out Reactor into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: split out boost into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: split out libbacktrace into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: split out subzero and llvm-subzero into their own CMakeLists Created with: gclient setdep -r src/third_party/swiftshader@e06125cb520f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I289bb442d8d930675c4e13f885935a416ded319f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135421Reviewed-by:
-
Mario Bianucci authored
Currently, if you select a text on the page, hold down middle mouse button and start scrolling in either direction and leave the button, it deselects the text. This is due to incorrect position in widget information on an event. This CL fixes the bug by correctly populating the position in widget information on an event. As a side effect of populating the correct position, clicking in an OOPIF to end autoscrolling would result in the cursor not changing back to a pointer until the mouse was moved. This is because when auto- scrolling ends, a cursor update is scheduled, but the cursor update timer is tied to user interaction, and if user interaction doesn't occur after the click, the timer doesn't fire. This used to work because the cached value previously populated in the widget resulted in hit testing not reporting a remote frame, so the cursor was updated in EventHandler::HandleMouseMoveOrLeaveEvent. With this change, hit testing reports a remote frame, so it no longer updates in the same place. Therefore, in order to ensure that the cursor is correctly updated immediately after autoscrolling, CursorUpdate is called rather than just scheduling an update. Regressing change: crrev.com/c/1773540 Bug: 1054854 Change-Id: I6b5353529ab0b73c85c1dd0e0237d3e06c848a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116134Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#756405}
-
Theresa Wellington authored
BUG=980567 Change-Id: I45dfeb4ef93b1d73d3ada19f11f524baec40334a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135502 Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#756404}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2af328044cf7..2d6db0b9fdd5 git log 2af328044cf7..2d6db0b9fdd5 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 michael.liao@microsoft.com [Applications - Clear Storage]: Fix pie chart focus 2020-04-03 leese@chromium.org Reland "Show unbound breakpoints as disabled" Created with: gclient setdep -r src/third_party/devtools-frontend/src@2d6db0b9fdd5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1066374 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icf1cd31097affc4a0cdae74022b0e5497fe685ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135419Reviewed-by:
-
Alexander Surkov authored
AccessibilityTreeFormatterMac as any other platform accessibility tree formatter should operate with platform tree, not platform-independent tree which AccessibilityTreeFormatterBrowser is responsible for. Adjust mac accessibility treedump tests to reflect mac accessibility tree, i.e. include indirected children and remove unknown children Bug: 1066578 Change-Id: I61d2429dbe6d899a018b4761ab5923086f0bf56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133419 Commit-Queue: Alexander Surkkov <asurkov@igalia.com> Reviewed-by:
-
Jordan Bayles authored
This patch reverts a previous patch that added diagnostics for a tricky SnooperNode::Render() bug. Most of the files had merge conflicts that required manual resolution. Bug: crbug.com/888478 Change-Id: I7ff4ff07df9cf845ebc500facbbc3487d20891c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128845Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#756401}
-
Brandon Wylie authored
Did some refactoring to allow for better test support. TBR=arbesser@google.com Bug: 1067714 Change-Id: Id18a0e1973c18c1ed9422748d6671cb012ce0f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133174 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#756400}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f687d90f4219..d9c51142bd01 git log f687d90f4219..d9c51142bd01 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 peah@webrtc.org AEC3: Add additional transparency-related killswitches Created with: gclient setdep -r src/third_party/webrtc@d9c51142bd01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1067597 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5ed8c32dfe63365dde8f495adf6edf3680484fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135981Reviewed-by:
-
Michael Thiessen authored
Change-Id: Iac30106a597ade4a6a7826bf5ed9890c94a1514f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135423Reviewed-by:
-
Henrique Nakashima authored
Change-Id: Ib0a5f6073de3d47120591dcd68707d1876e152ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129899 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/79679990ff54..7803f6a504e3 git log 79679990ff54..7803f6a504e3 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 treehugger-gerrit@google.com Merge "Move Frame Events to a separate table and add frame stats table" Created with: gclient setdep -r src/third_party/perfetto@7803f6a504e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Idf3e21e386fb2cc88b8cbd80a5bc3ecd762feedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135977Reviewed-by:
-
Jon Mann authored
This adds support for customizing seperate values for HTTP, secure HTTP, and SOCKS proxy hosts and ports. Bug: 966270 Change-Id: I88e83f2ca7f764e6eb32cd2ed214b392b289a95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135310Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#756395}
-
Henry Jian authored
This CL removes the use of callback for feature highlight. Because the callback is no longer needed, we're removing its use now. Bug: 1057234 Change-Id: I5ce9ba270851397da926f8c33a4e8c3cbc5d8fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122619Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Jon Mann authored
This change refactors last_modified_timestamp to last_connected_timestamp in order to more accurately represent what is stored. Bug: 966270 Change-Id: Id2ff3ee12604a0d93ed9c4ddf2d66d8cf6be9247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133548Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#756393}
-
Peng Huang authored
vkGetSemaphoreWin32HandleKHR, vkImportSemaphoreWin32HandleKHR, vkGetMemoryWin32HandleKHR and vkGetMemoryWin32HandlePropertiesKHR are added. They will be used for Vulkan and GL interop on Windows. Bug: 1067709 Change-Id: Ie735a25c31d41ac5af1d8734c5ba830b1f340465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135974 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#756392}
-
danakj authored
It depends on content_shell_lib, which no longer needs to depend on anything in renderer/web_test. R=avi@chromium.org Bug: 866140 Change-Id: I62b472b8ac3d22176ef6a55609b5ada80d50a540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134487 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#756391}
-
Andy Paicu authored
Bug: 875521 Change-Id: I4d5a0930e090b6720646352d8e537e90faedc004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132413 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#756390}
-
Lei Zhang authored
- IDS_NTP_CUSTOM* were added in https://crrev.com/569519 and may have never been used. - IDS_NTP_DOWNLOAD* went unused as of https://crrev.com/647035. Change-Id: I1aa26d46c3d903d604bee218d5b2bf5da2afb14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135530Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#756389}
-
Lei Zhang authored
- PrintPreview.RegeneratePreviewRequest.BeforeFirstData: The UMA is not interesting. - PrintPreview.ManagePrinters: https://crrev.com/518333 botched the data collection code, and https://crrev.com/613267 removed the method that should have collected the data. Along the way, initialize more PrintPreviewHandler member variables in the header. Bug: 1041532 Change-Id: I319d87c17d11ee9191e9feba6351fe93f5aa44fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135534Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#756388}
-
Reilly Grant authored
The Wake Lock feature was supposed to be in Origin Trial from Chrome 79 to 82 however Chrome 82 has been canceled due to COVID-19 and so we are extending the OT through Chrome 83 to give us time to integrate recent specification changes that missed the branch point. Bug: 257511 Change-Id: I3df4ad65029b042eb8c9eada9bf7cae5f7cad4f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134400Reviewed-by:
Alex Russell <slightlyoff@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#756387}
-
Peng Huang authored
This CL git rid of Posix suffix from ImportVkSemaphoreHandlePosix and GetVkSemaphoreHandlePosix, and rename gpu/vulkan/vulkan_posix_util.cc to gpu/vulkan/vulkan_util_posix.cc. gpu/vulkan/vulkan_util_posix.h is removed. Bug: 1067709 Change-Id: I49551052e2c20b4a7435f020c3f9ae0ec99e7821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135815 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#756386}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/31665eb818aa..52ecbf88d69c git log 31665eb818aa..52ecbf88d69c --date=short --first-parent --format='%ad %ae %s' 2020-04-03 btolsch@chromium.org Fix tsan race in discovery e2e tests Created with: gclient setdep -r src/third_party/openscreen/src@52ecbf88d69c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ib1affb5821473b7573dafa0552fc201990ca9b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135973Reviewed-by:
-
spdonghao authored
Bug: 1061906 Change-Id: I798d592945cadcb5b375ee508369738224d78caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132330Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#756384}
-
Junbo Ke authored
Casting content from a local server is broken because the request is auto upgraded to HTTPS. Bug: b/153100172 Test: CQ Change-Id: Ib3cb140df74cbc9336b245069c050163bac120ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135889Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#756383}
-
Samuel Huang authored
This CL adds more tests for FileUtils: * batchDeleteFiles() (not testing content URL deletion). * copyStream(). * copyStreamToFile(). * readStream(). * getUriForFile(). Bug: 1066730 Change-Id: I7ac4d2f1c5eecd82aebf931a797c9bac8a96d635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135814Reviewed-by:
-
Ryan Hansberry authored
These logs were previously incorrect making it slightly confusing to read debug logs after the fact. This CL makes it clear when advertisements are received and a connection is beginning to be created. Change-Id: I93ff8b8b415878c499844ae8b3b99d99f9f2a481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134770 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#756381}
-
