- 05 Feb, 2015 40 commits
-
-
jrummell authored
BUG=351501 TEST=existing EME tests pass Review URL: https://codereview.chromium.org/875073004 Cr-Commit-Position: refs/heads/master@{#314727}
-
calamity authored
This CL makes StartPageView subclass View instead of SearchResultContainerView. A new SearchResultContainerView has been added as a child of StartPageView instead. This change will facilitate further refactoring. BUG=455059 Review URL: https://codereview.chromium.org/896063002 Cr-Commit-Position: refs/heads/master@{#314726}
-
heejin.r.chung authored
Added max_transform_feedback_separate_attribs, max_uniform_buffer_bindings, and uniform_buffer_offset_alignment to Capabilities. These were introducted in GLES 3.0. BUG=429053 TEST=gpu_unittests Review URL: https://codereview.chromium.org/885013002 Cr-Commit-Position: refs/heads/master@{#314725}
-
tommycli authored
This patch enables the following flow for throttled plugins: 1. Place real plugin on page, preroll for a few seconds until a keyframe is extracted. 2. On throttle, replace the plugin with a PluginPlaceholder. Set the extracted keyframe as the poster. Meanwhile, the real plugin is hidden, throttled, but still alive. 3. On clicking the placeholder, replace the placeholder with the original throttled plugin. BUG=443810,403800 Review URL: https://codereview.chromium.org/866173002 Cr-Commit-Position: refs/heads/master@{#314724}
-
dcheng authored
Revert of Set defaultPageScaleLimits before setIgnoreViewportTagScaleLimits (patchset #2 id:20001 of https://codereview.chromium.org/860283005/) Reason for revert: Speculatively reverting to try to fix broken layout tests in Blink: compositing/iframes/iframe-composited-scrolling-hide-and-show.html compositing/iframes/overlapped-iframe-iframe.html svg/as-border-image/svg-as-border-image-2.html and more. Original issue's description: > Set defaultPageScaleLimits before setIgnoreViewportTagScaleLimits > > setIgnoreViewportTagScaleLimits copies the default limits into the UA > constraints. This was happening before the defualt limits were set during > initialization so it was clamping page scale at [1,1]. > > BUG=453377 > > Committed: https://crrev.com/ebbcc53e21fbfe15a76fa7fbf6d14c84095880ee > Cr-Commit-Position: refs/heads/master@{#314668} TBR=aelias@chromium.org,sievers@chromium.org,bokan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=453377 Review URL: https://codereview.chromium.org/897173003 Cr-Commit-Position: refs/heads/master@{#314723}
-
mtomasz authored
In case of an abort, a memory corruption was occuring because of a call to Queue::Complete() after an operation is aborted, which is invalid according to both documentation and a DCHECK. This CL fixes the issue by avoiding calling Queue::Complete() for aborted tasks. TEST=Tested manually. Try to copy files from a ZIP archive with thousands of files, and abort during the operation. BUG=454310 Review URL: https://codereview.chromium.org/882153006 Cr-Commit-Position: refs/heads/master@{#314722}
-
pkasting authored
This is effectively a revert of http://crrev.com/136205 , switching back to searchdomaincheck "format=domain" from "format=url", but this time using HTTPS instead of HTTP. Note that in general this should have no visible effect, since for Chrome 25+ searchdomaincheck is supposed to be sending "https..." URLs anyway. The only difference is that, if searchdomaincheck is never accessed, the "out of the box" default value for the Google homepage switches from "http://www.google.com/" to "https://www.google.com/". This shouldn't cause any additional bustage to existing users, since Google search over HTTP will just redirect to HTTPS anyway, so anyone whose network doesn't support HTTPS accesses is already seeing broken behavior. (For the same reason, this means even the "out of the box default" change noted above shouldn't really be visible to end users.) It's still possible for users to "downgrade" Google searches to HTTP using the nosslsearch mechanism, but that's not in scope for Chrome to address. BUG=364183 TEST=none TBR=isherman Review URL: https://codereview.chromium.org/263023002 Cr-Commit-Position: refs/heads/master@{#314721}
-
benwells authored
Prior to this change bookmark apps were created as soon as the user started the process. If the user quit the process the app was then removed. This made the flow feel strange, and also caused any matching app that previously existed to be deleted if the user quit the process. BUG=438019 Review URL: https://codereview.chromium.org/899443002 Cr-Commit-Position: refs/heads/master@{#314720}
-
halton.huo authored
linux and android should share same yasm defines and include_dirs, just as src/third_party/libjpeg_turbo/libjpeg.gyp does. BUG=455151 Review URL: https://codereview.chromium.org/893413002 Cr-Commit-Position: refs/heads/master@{#314719}
-
chrome://downloadschrome://historyhcarmona authored
Changes in https://codereview.chromium.org/807593005/ broke Closure Compilation. BUG=427670, 452870 Review URL: https://codereview.chromium.org/895283002 Cr-Commit-Position: refs/heads/master@{#314718}
-
mbarbella authored
BUG=450268 R=inferno@chromium.org,tsepez@chromium.org Review URL: https://codereview.chromium.org/900483002 Cr-Commit-Position: refs/heads/master@{#314717}
-
divya.bansal authored
Added code to open autofill settings page. If "Chromium Autofill Settings" option" is selected from autofill menu autofill forms settings page should be opened. Please enter the commit message for your changes. Lines starting BUG=454779 Review URL: https://codereview.chromium.org/896653007 Cr-Commit-Position: refs/heads/master@{#314716}
-
danakj authored
This will help in tracking down window resize bugs. R=enne, vmpstr BUG=454333 Review URL: https://codereview.chromium.org/864713004 Cr-Commit-Position: refs/heads/master@{#314715}
-
heejin.r.chung authored
To match the recent change in MathUtil::AddToTracedValue, pass name as parameter and Begin/End internally. R=danakj Review URL: https://codereview.chromium.org/898663003 Cr-Commit-Position: refs/heads/master@{#314714}
-
michaeln authored
[DOMStorage] (recommitting) Offset the session storage namespace ids generated by different contexts to help identify when an id from one is mistakenly used in another. >> Committed: https://crrev.com/36dcef3da5317365ab95e50a5f6b7fa98ada1d5e >> Cr-Commit-Position: refs/heads/master@{#314256} > > Reverted: https://crrev.com/7bdc4a49e605261b60ee1339f93e835d853bf645 > Cr-Commit-Position: refs/heads/master@{#314274} Review URL: https://codereview.chromium.org/881253004 Cr-Commit-Position: refs/heads/master@{#314713}
-
joedow authored
Initial checkin for the app remoting test driver tool. The external pieces of the test driver will consist of a common library which will build the dependencies and core helper classes and a minimal version of the tool which will include a minimal number of tests. An internal version of the tool will include the common library and pull in additional tests from src-internal. The tool uses the GTest framework and this CL is to set up the foundation so I can start adding functionality. I am not hooking it into the public gyp files yet, that will come in a future change as more changes to the remoting GYP files are expected. BUG= Review URL: https://codereview.chromium.org/900973002 Cr-Commit-Position: refs/heads/master@{#314712}
-
tapted authored
Currently keystrokes while a menu is open are sent to the window hosting the menu, since it remains `key`. Menus are a different window, so this causes all the Menu* interactive_ui_tests to fail since they simulate pressing ESC to dismiss the menu in the tests. Other platforms insert an event dispatcher into the message pump for the nested run loop that shows a menu, and redirect KeyDown events to the MenuController. On Mac, events need to be mapped to "Action" messages by an NSResponder to obey platform behaviour and user customizations (e.g. a "Home" keypress should be interpreted as beginning of document, not beginning of line). The approach in this CL is to check in BridgedContentView, an NSResponder, for an active menu that should be receiving events instead. Action messages are mapped to the KeyCode that toolkit-views expects for that action, and the MenuController is given an opportunity to swallow the event or have it sent on to the key window. Gets the following interactive_ui_tests passing: MenuControllerMnemonicTest*{NoMatch,TitleMatch,MnemonicMatch} MenuItemViewTestRemoveWithSubmenu{0,1}* (and all Menu interactive UI tests pass after this). BUG=403679 Review URL: https://codereview.chromium.org/866983006 Cr-Commit-Position: refs/heads/master@{#314711}
-
pstew authored
BUG=450601 R=kalman@chromium.org Review URL: https://codereview.chromium.org/901583003 Cr-Commit-Position: refs/heads/master@{#314710}
-
jam authored
BUG=454834 TBR=ppi@chromium.org Review URL: https://codereview.chromium.org/897173002 Cr-Commit-Position: refs/heads/master@{#314709}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/d2a6f4e..12753cc CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=stephana@google.com Review URL: https://codereview.chromium.org/903503003 Cr-Commit-Position: refs/heads/master@{#314708}
-
kkimlabs authored
There are some UMA strings, enum constants in iOS repository that can be shared with Android, so moved to components. BUG=452254 Review URL: https://codereview.chromium.org/891493003 Cr-Commit-Position: refs/heads/master@{#314707}
-
jam authored
It looks like the GetFontData patch for PDFium is only used on XP/Vista now. Previously PDFium was in a separate binary so we were just calling the real GetFontData from chrome_child.dll. That doesn't work anymore, so use the original function pointer. BUG=455399 Review URL: https://codereview.chromium.org/903583002 Cr-Commit-Position: refs/heads/master@{#314706}
-
boliu authored
Use TexSubImage2D instead of TexImage2D to avoid orphaning EGLImage Create the renderer compositor context on the gpu thread. BUG=448168, 259924 Committed: https://crrev.com/a4baed454be2bb165cb12eb7df432e9138e746e6 Cr-Commit-Position: refs/heads/master@{#313846} Review URL: https://codereview.chromium.org/769703005 Cr-Commit-Position: refs/heads/master@{#314705}
-
oysteine authored
The threaded data receiver will now receive notifications about received data packets on the main thread (needed for the progress indicator to work properly), and can optionally specify that it wants to receive a full copy of the data (needed when the Inspector is attached). If a threaded data receiver is attached to a resource request, we also now make sure the resource completed message is bounced via the background thread, to make sure all data is received on the main thread first. Blink side patch: https://codereview.chromium.org/690793003 BUG=398076 Review URL: https://codereview.chromium.org/689713004 Cr-Commit-Position: refs/heads/master@{#314704}
-
mgiuca authored
Previously, this class would fail gracefully if given a nullptr. Now it has undefined behaviour. Dealing with null isn't necessary as no caller passes nullptr here, and in general, pass-by-result style functions do not expect null pointers. Dealing with nullptr makes my follow-up work messy, so I am just removing it. Also, moved constructor implementation to .cc file, and properly documented the lifetime constraints on |json_string|. BUG=455068 Review URL: https://codereview.chromium.org/889303004 Cr-Commit-Position: refs/heads/master@{#314703}
-
xdai authored
Add UMA stats to record the memory pressure level periodically (once per second) in ChromeOS. This is used to show the relative frequency of the system being in a critical vs relaxed memory pressure state BUG=442829 Review URL: https://codereview.chromium.org/874483008 Cr-Commit-Position: refs/heads/master@{#314702}
-
bauerb authored
Before this CL, component installers were leaked in almost all cases. If we allow uninstalling components (see https://codereview.chromium.org/879993005/), we need to fix those leaks. BUG=436459 Review URL: https://codereview.chromium.org/897873002 Cr-Commit-Position: refs/heads/master@{#314701}
-
mseaborn authored
This pulls in the following Native Client changes: ab93269: (phosek@chromium.org) Removes the now-unused kernel service from the service runtime 9e3dac8: (sbc@chromium.org) Implement pthread_rwlock functions for NaCl newlib. BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build Review URL: https://codereview.chromium.org/896533005 Cr-Commit-Position: refs/heads/master@{#314700}
-
qinmin authored
This change allows MediaSourcePlayer to skip browser seek if a key frame is found in cache. Key frames can be identified by an empty data buffer, a config change or is_key_frame field. BUG=304234 Review URL: https://codereview.chromium.org/898843002 Cr-Commit-Position: refs/heads/master@{#314699}
-
brucedawson authored
The ipc_perftests and mojo_message_pipe_perftests results appeared designed to be compared against each other, and the ipc_perftests appear to be designed to take about a second each. Therefore it is presumably a bug that the final ipc_perftests test executes only 100 times (versus 1,000 times for mojo_message_pipe_perftests) and that it executes in ~50 ms. This change increases the iteration count from 100 to 1,000. Review URL: https://codereview.chromium.org/903513002 Cr-Commit-Position: refs/heads/master@{#314698}
-
mlamouri authored
It is sending the request from the render process to the browser process which then opens the URL using ContentBrowserClient::OpenURL(). This is going to be used by sw.client.openWindow(), see Blink CL: https://codereview.chromium.org/850413002 BUG=437151 Review URL: https://codereview.chromium.org/843583005 Cr-Commit-Position: refs/heads/master@{#314697}
-
bbudge authored
BUG=455409 Review URL: https://codereview.chromium.org/901733002 Cr-Commit-Position: refs/heads/master@{#314696}
-
jianli authored
This is not longer needed after we have a generic gcm channel state. BUG=447016 TEST=none TBR=kalman@chromium.org Review URL: https://codereview.chromium.org/897793002 Cr-Commit-Position: refs/heads/master@{#314695}
-
mdempsky authored
BUG=449357 Review URL: https://codereview.chromium.org/888093005 Cr-Commit-Position: refs/heads/master@{#314694}
-
alexandrec authored
Review URL: https://codereview.chromium.org/896463005 Cr-Commit-Position: refs/heads/master@{#314693}
-
jonross authored
This reverts commit cc6a8bfe. From review: https://codereview.chromium.org/899973002/ Original issue's description: > Device Orientation API on Chrome OS > > Implement DataFetcherSharedMemory on Chrome OS to provide Device Orientation support. Create SensorManagerChromeOS to observe accelerometer events, and to generate updates to the Device Orientation API. > > This is a follow up to: https://codereview.chromium.org/680383007/ > > With the accelerometer on Chrome OS now exposed to content/ from chromeos/accelerometer, no ash/ implementation is required. No public api in content/public/browser is needed either. > > TEST=SensorManagerTest.OrientationBuffer, SensorManagerTest.NeutralOrientation, SensorManagerTest.UpsideDown, SensorManagerTest.BeforeUpsideDownBoundary, SensorManagerTest.LeftEdge, SensorManagerTest.RightEdge, SensorManagerTest.BeforeRightEdgeBoundary > BUG=342908 TBR=timvolodine@chromium.org,jam@chromium.org BUG=342908 Review URL: https://codereview.chromium.org/880083005 Cr-Commit-Position: refs/heads/master@{#314692}
-
afakhry authored
Instead of parsing the whole proc stats just to extract two values, we skim through it just to extract the two values we're interested in. BUG=453871 TEST=base_unittests --gtest_filter=ProcessMetricsTest.* Review URL: https://codereview.chromium.org/888193002 Cr-Commit-Position: refs/heads/master@{#314691}
-
mitchelljones authored
There is a bug where the "Close Window" shortcut for hosted/packaged apps would disappear after focusing the File menu in a Chrome browser. This is because the shortcuts had the same key equivalent, and OS X was choosing to only display one of them. This CL fixes this by keeping a reference to the conflicting menu items and enabling/disabling the shortcuts on focus. BUG=455067 Review URL: https://codereview.chromium.org/898543008 Cr-Commit-Position: refs/heads/master@{#314690}
-
zhenw authored
testGetUpdatedInspectableContexts should only run when tab control is supported. BUG=452277 Review URL: https://codereview.chromium.org/893233003 Cr-Commit-Position: refs/heads/master@{#314689}
-
dtseng authored
- ! allowed by a tts property will annotate the output with that property - $descendants(args...) where args... is a comma delimited list of roles, will compute output for the node's descendants that are in the set of roles. - apply these two new functions to compute utterances for alerts. TEST=navigate to a page with an alert like html5demos.com/geo. BUG=382650 Review URL: https://codereview.chromium.org/816093002 Cr-Commit-Position: refs/heads/master@{#314688}
-