- 19 Feb, 2020 40 commits
-
-
Tanmoy Mollik authored
SyncTestRule doesn't provide a way to override the instance of ProfileSyncService it holds. For this reason some tests might override the ProfileSyncService with a subclass but SyncTestRule will hold a copy of the old ProfileSyncService instance. This cl adds a method in SyncTestRule to override ProfileSyncService and refactors some tests that need to use it. Bug: 1030725 Change-Id: I9fc1b770df4c153e726a4e071e432fc585561889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012380 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#742596}
-
Wez authored
Bug: 1050703, fuchsia:46115 Change-Id: I3e8c795e616bc803513efd33cff64ca95a625875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058968 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#742595}
-
Sami Kyostila authored
When posting tasks with base::PostDelayedTask(), explicitly specify whether the tasks should run on the thread pool on a specific named thread. This is in preparation for making it always mandatory to specify the destination for posted tasks. This patch has no functional changes. This CL was uploaded by git cl split. Bug: 968047 Change-Id: I7647e425e2d58b5b23df3cc7bb391665f1c87902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063010 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#742594}
-
Felipe Andrade authored
Seventh batch of KerberosCredentialsManager unit tests. This time, adding tests for the UpdateAccountsFromPrefConfig method. Bug: 952251 Change-Id: Ie651af8ea53b32458a0bc25e8d000b5e4b3b6363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054108Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/master@{#742593}
-
Antonio Gomes authored
Messages will live in LocalMainFrame mojom interface. BUG=1051165 Change-Id: Ib68be561dc38cf8a8cabd894a56cc6d036728041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063069 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#742592}
-
Nick Harper authored
https://quiche.googlesource.com/quiche.git/+log/4e083db26373..4f95c4097fa1 $ git log 4e083db26..4f95c4097 --date=short --no-merges --format='%ad %ae %s' 2020-02-18 dschinazi Deprecate quic_fix_handling_of_bad_prox_packet 2020-02-18 dschinazi Parameterize QuicDispatcherTest by version 2020-02-18 renjietang gfe-relnote: deprecate gfe2_reloadable_flag_quic_log_coalesce_stream_frame_frequency 2020-02-18 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_enable_rr_write_scheduler. 2020-02-18 quiche-dev Surface receive_timestamp to QuicStream::OnStreamFrameAcked. 2020-02-18 fayang Remove unreachable statement and unused variable from general_loss_algorithm. 2020-02-18 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_use_http2_priority_write_scheduler. 2020-02-14 nharper Change number of connection attempts in QuicClientBase::Connect 2020-02-14 nharper Internal QUICHE change 2020-02-14 wub gfe-relnote: (n/a) Deprecate --quic_sanitize_ack_delay. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ia3919e9cc5f387f2ad94a4d8f313a7cfeb7aa5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063259 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#742591}
-
Wez authored
renderer_fuzzer often takes longer than the default action_timeout() set by TaskEnvironment as the Run() timeout. Bug: 1053401, 1053479, 1053634 Change-Id: Ia4f58bf3a480c89875fe4ddce2f80e4d81818ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062350 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#742590}
-
Julian Pastarmov authored
Replace .cache with .config. BUG=none Change-Id: Ie801e3980adebcfd0514e60b42a82b06a30a1cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051125Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Gustavo Sacomoto <sacomoto@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#742589}
-
Kent Tamura authored
This CL has no user-visible behavior changes. Change-Id: I80da7333d3a8a91fd37b460a2f2582b6182ae9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062845Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#742588}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ed0da37dd994..c008fcb8cc0f git log ed0da37dd994..c008fcb8cc0f --date=short --first-parent --format='%ad %ae %s' 2020-02-19 johnkslang@users.noreply.github.com Merge pull request #2089 from Roy-AMD/Fix-iomapper-issue Created with: gclient setdep -r src/third_party/glslang/src@c008fcb8cc0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: If52e7f18a788b33ce0f56f67197d02ee16ffcf97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064060Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742587}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53bc9c82f33f..f25db531203d Created with: gclient setdep -r src-internal@f25db531203d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0da559844d9fe6d979259e3b75a1d3cdc46e7721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064057Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742586}
-
Kent Tamura authored
This makes text-overflow:ellipsis workable. * MenuListInnerElement switches to margin-left/right from padding-left/ right. Overflowed text is painted on padding area. * LayoutMenuList::ComputeIntrinsicLogicalWidths refers to LayoutTheme. InnerBlock's margin values are zero in this function. Bug: 436654, 1040828 Change-Id: I5167cf5ae5ad2e823f8e688ad39db7ea833b9079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061769 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#742585}
-
Sergey Poromov authored
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome Sample run: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3317 Logs: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8888037310866866032/+/steps/browser_tests/0/logs/Deterministic_failure:_KioskAppManagerTest.UpdateAndRemoveApp__status_FAILURE_/0 Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=KioskAppManagerTest.UpdateAndRemoveApp TBR=apotapchuk@chromium.org Bug: 1044417 Change-Id: I8d028974d8451f0f37a5445c5cda193d43559976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062343 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#742584}
-
Wei Lee authored
Bug: 980846 Test: Launch CCA with no error shows Change-Id: I41ac276f5c04705893a9c42d97bc3a4bfb9b9151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056508Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#742583}
-
Wez authored
We now have a memory pressure signals implemented for Fuchsia, and even when those are unavailable the lower 64MB discardable memory limit can be set via --enable-low-end-device-mode=true. Bug: 996030, 1020698 Change-Id: I24a76324f4fd8a6ec6c907a5437983c34d9f9908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056477 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#742582}
-
Josh Simmons authored
Extend this UMA expiry date until feature freeze of Chromium M90. Tbr: dats@ Bug: 1053241 Change-Id: I3265bf75e6ab71670894a474811eb4d39e96010d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063616Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#742581}
-
Sergey Poromov authored
TBR=zmo@chromium.org Bug: 1053892 Change-Id: Id0fd2c696d1982101b849490bc899e3393dd84dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063014Reviewed-by:
-
Michael Ershov authored
These policies will control what certificates will be provisioned on a device via DM server. Bug: 1045895 Change-Id: I094c1346d6ed657991e628fb076c1781ee0c8ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050497 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#742579}
-
Anders Hartvoll Ruud authored
This CL implements a new feature which allows authors to query for selector support. Our selector parsing code is a little bit weird, hence we have to check for no less than *three* fail conditions when parsing the selector (failed_parsing_, AtEnd() and a nullptr-check). Unknown -webkit- pseudo elements are never supported by spec. This CL re-uses existing code for detecting support for these pseudo elements, although that code was originally intended for use-counting. Spec: https://drafts.csswg.org/css-conditional-4/#at-supports-ext Bug: 979041 Change-Id: I9dfcce27ee00bbdf1932a6761b68eb82b110ca06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059408Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#742578}
-
Johannes Kron authored
A recent WebRTC CL makes two more tests pass. Re-enable WPT for RTCPeerConnection-mandatory-getStats with updated expectations. Bug: webrtc:7061 Change-Id: Id2891963e19b0cbfa90db6a35b9a7dcfe853434c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056466 Commit-Queue: Johannes Kron <kron@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#742577}
-
Fredrik Söderquist authored
Since we always create a new Vector<float> when creating a FEColorMatrix, by moving |values| we can avoid unnecessary copying. Also remove some unused static function declarations on FEColorMatrix. Change-Id: I6d26635a5da514128ad42de932cc3f75333a94bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062397Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#742576}
-
Sami Kyostila authored
When posting tasks with base::PostDelayedTask(), explicitly specify whether the tasks should run on the thread pool on a specific named thread. This is in preparation for making it always mandatory to specify the destination for posted tasks. This patch has no functional changes. This CL was uploaded by git cl split. Bug: 968047 Change-Id: I25230a83101d68c44929f19434d38e0620ee0b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063009 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#742575}
-
Jose Lopes authored
In the following call chain, a periodic timer invokes the callback, therefore, it must be a repeating callback: * https://cs.chromium.org/chromium/src/media/blink/video_decode_stats_reporter.cc?rcl=26a281f509fa5217972a45cae8fff0a32e5a1f44&l=289 * https://cs.chromium.org/chromium/src/media/blink/video_decode_stats_reporter.cc?rcl=26a281f509fa5217972a45cae8fff0a32e5a1f44&l=286 * https://cs.chromium.org/chromium/src/media/blink/video_decode_stats_reporter.cc?rcl=26a281f509fa5217972a45cae8fff0a32e5a1f44&l=126 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I234f6bdf2144e9b25665356873f606693563c996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035956Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#742574}
-
Sergey Poromov authored
This reverts commit ace0df39. Reason for revert: [sheriff]: Consistent failures on MSan builds: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests First failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17840 Original change's description: > Fix default page break for Krane devices. > > Adding default page break too early will cause the default page break > gets deleted immediately. > > Now move the installation of default page break after ChromeOS settings > app is installed. > > Bug: 1031410 > Test: Manual > > Change-Id: If8d6522993518ccc109ac0bf368cdd077a97f301 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056578 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Long Cheng <lgcheng@google.com> > Cr-Commit-Position: refs/heads/master@{#742304} TBR=xiyuan@chromium.org,lgcheng@google.com Change-Id: I056ec39290ce8cdf889d3ad8ad017e787e29d4ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064210Reviewed-by:
-
Sergey Silkin authored
- Ensure that call actually uses H264 by checking codec type in video track stats. - Enable CanSetupH264VideoCallOnSupportedDevice test. Bug: webrtc:11244, 1047994 Change-Id: I5ba241828500de9e465d5200e651640394d2ce6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033511Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Sergey Silkin <ssilkin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742572}
-
Colin Blundell authored
This class will shortly be shared by WebLayer's SSL interstitial embedding so that the logic on when to allow users bypass SSL interstitials is shared between WebLayer and Chrome. As part of the componentization, also componentizes a pref that is used by this class. Bug: 1030692 Change-Id: I0d4e8a84b8b14637ad6380a99c7fec94310c01c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062433Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#742571}
-
Sergey Poromov authored
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3306 TBR=rsorokin@chromium.org Bug: 1052603 Change-Id: I7a6c3542fac98c27814f016a3b65ddefac3d42bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063171Reviewed-by:
-
Alan Cutter authored
This CL removes the hard dependency WebAppAudioFocusBrowserTest had on Extensions in favour of using WebAppControllerBrowserTest to switch between Extensions/BMO backends via parameterisation. This ensures the functionality is still testing when BMO is enabled. Bug: 876576 Change-Id: Id1756b35568c50b4b0b5087e4d60b65a2f4cefb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063189 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#742569}
-
Milica Selakovic authored
Bug: 1053522 Change-Id: Ie1c851e25d323f0252ec7503ecd02aba5c5daba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062268 Commit-Queue: Milica Selakovic <selakovic@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#742568}
-
Henrique Ferreiro authored
This will make it easier to check for new issues when running `git cl lint`. Bug: 1053888 Change-Id: I782fba51ca915f31eb47f82f245967570bfc0dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062992Reviewed-by:
-
Oleg Davydov authored
This is a reland of bf17bc25 Original change's description: > [Extensions] Enable content verification for new policy non-webstore installs > > After this commit: > * For non-webstore policy force-installed extensions, write > computed_hashes.json on installation. > * If (according to computed_hashes.json) extension's resource is > detected corrupted, this extension will be disabled and reinstalled. > This applies only for policy force-installed extensions, and for > webstore extensions it worked before this commit. > > This commit will NOT change behavior for already-installed extension. > So, if some (non-webstore) extension was already corrupted, it will not > be detected. The reason for this is that there is no source of truth for > resources of already-installed non-webstore extension. It's possible to > reinstall all previously-installed non-webstore extensions, but it's out > of scope of this commit. See the bug for more details. > > Bug: 958794 > Change-Id: Ie9c014e7fd998f4eae6e852a59bd692d57ff7d8c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012964 > Commit-Queue: Oleg Davydov <burunduk@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737034} This CL was reverted for the second time in https://crrev.com/c/2050686. After investigation we've found two problems, which are not problems of the original one CL itself, but imperfections revealed by it. These imperfections were fixed in https://crrev.com/c/2051931 and https://crrev.com/c/2049855. More info in https://crbug.com/1051513. Bug: 958794, 1051513 Change-Id: I8e64a1023dee8f7a7e8f9781fb22434799de12e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061154 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
sreejakshetty@chromium.org authored
This CL adds a test to check whether ChromePasswordManagerClient::HideFillingUI was called on navigating away. Here https://chromium-review.googlesource.com/c/chromium/src/+/1995173 we added the functionality. Change-Id: I8b99f879ab73fe63280c276b3db682eddfb9fa89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056547 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Eric Seckler authored
A couple of smaller changes that shouldn't affect the runtime behavior of these classes. Primarily: 1) PerfettoProducer no longer inherits from ProducerEndpoint. There's no need for this anymore, since all TraceWriters now talk directly to a SharedMemoryArbiter. 2) ProducerClient continues to inherit from ProducerEndpoint, because it acts as a ProducerEndpoint to its SharedMemoryArbiter. 3) "Abuse" of methods in the ProducerEndpoint interface in ways that wasn't intended by the interface have been removed. For example, data sources no longer call ProducerEndpoint's NotifyFlushComplete(), and instead use a separate helper (similarly, tests now use ProducerClient::shared_memory_for_testing()). 4) Method order in XXX.cc is updated to reflect the order in the corresponding XXX.h. 5) Adds a lock around off-sequence access & modifications to PosixSystemProducer's |services_| list. Change-Id: Ie3c8892fab52dc9a65bdb337621ceb1ce196518f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059019 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#742564}
-
Hirokazu Honda authored
This is a reland of 139567ba Original change's description: > content/renderer/media: Query GPU process HW encoder capabilities > > Originally GpuVideoAcceleratorFactoriesImpl get HW encoder > capabilities by referencing values stored GpuInfo instance. > However, the values are not updated after GPU process boots up. > Even if a new hw encoder is available after GPU process is > initialized, the hw encoder is not detected. > > This fixes the problem by querying GPU process the hw encoder > capabilities when a render process is created. e.g. open the > page. > > Bug: b:147404923 > Test: HW encoder is used at appr.tc > Test: tast run webrtc.* on krane > Change-Id: Ibca82b6e54e9b5d585037c8e63f4c663d085db0e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994849 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735339} Bug: b:147404923 Change-Id: Ia5535e0d316c0418f15e1139d475af67f226ed14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035481 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#742563}
-
Fredrik Söderquist authored
Change the structure of these pair of functions such that the former handles the cache lookup and calls the latter to mint a new PatternData. Remove the redundant check for an empty 'viewBox'. LayoutSVGResourcePattern::PatternForClient is removed, because the issue mentioned in the FIXME should no longer be present. Bug: 109212 Change-Id: I5514dce39c20e07adbf45ea46c2dd472a4c71303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061752 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#742562}
-
Sergey Poromov authored
This reverts commit b51be283. Reason for revert: Breaks builds. Original change's description: > Revert "Allow mixed-security content in promoted PWA windows" > > This reverts commit ef364481. > > Reason for revert: [sheriff]: > Consistent failures on linux-chromeos-chrome > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome > First failed run: > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3315 > > Original change's description: > > Allow mixed-security content in promoted PWA windows > > > > Prior to this CL, mixed-security content was blocked entirely in > > standalone PWA windows with scopes. This CL allows those PWAs to display > > mixed-security content, but when this happens, the window will show the > > CustomTabBarView with the URL and a "Not Secure" indicator to indicate > > the presence of mixed content. > > > > Screenshot: > > https://bugs.chromium.org/p/chromium/issues/attachment?aid=432401&signed_aid=JeW6cXlVCQ3bSebdZ-FoJg==&inline=1 > > > > This removes a behavioural difference between promoted PWAs and "create > > shortcut" apps without manifest scopes. > > > > > > Bug: 910016 > > Change-Id: Ic9b3bbdba14218bb1ad8fd4f2ca8cf47cd4e3a37 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041380 > > Commit-Queue: Alan Cutter <alancutter@chromium.org> > > Reviewed-by: Evan Stade <estade@chromium.org> > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Reviewed-by: Peter Boström <pbos@chromium.org> > > Reviewed-by: Glen Robertson <glenrob@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#742515} > > TBR=alancutter@chromium.org,estade@chromium.org,pbos@chromium.org,dominickn@chromium.org,glenrob@chromium.org > > Change-Id: Ibb71d71f13f3fea753b5cb80a4a98c733a093c12 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 910016 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063015 > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Commit-Queue: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742557} TBR=alancutter@chromium.org,estade@chromium.org,pbos@chromium.org,poromov@chromium.org,dominickn@chromium.org,glenrob@chromium.org Change-Id: Ifef5a3c6a34563999506f4c5946273533ad0063d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063016Reviewed-by:
-
Sergey Poromov authored
https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/31990 TBR=alcooper@chromium.org Bug: 1053903 Change-Id: Idbd00ecfe63d58649969714912fffa8d083fefe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062275 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
-
Greg Thompson authored
- Push expiration of some cleanup histograms out by a few milestones since the related cleanup code is still being used. - Remove the legacy multi-install Chrome Frame cleanup and its related histogram since it is now very rarely used. - Remove the legacy app_host.exe cleanup and its related histogram since it is nearly never used. - Mark Setup.Install.StrandedChromeIsUsed as obsolete since it was removed from the codebase years ago (oops). - Mark Setup.Install.Result as never expiring since it is a fundamental metric. BUG=1053134,1053138 R=bcwhite@chromium.org Change-Id: Icc89877e442abc5953ba3a2deb9788487da60569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060951 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#742559}
-
Clemens Arbesser authored
I only recently realized that the generic ui framework is actually much more simple if we remove this requirement. Now, callbacks have to be fully specified in proto, which is easier to read and understand (and also less code). This is a refactoring and does not contain user-facing changes. Bug: b/145043394 Change-Id: I96b66af316a4b4c205c0d0234f841075e96f8be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038653 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#742558}
-
Sergey Poromov authored
This reverts commit ef364481. Reason for revert: [sheriff]: Consistent failures on linux-chromeos-chrome https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome First failed run: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3315 Original change's description: > Allow mixed-security content in promoted PWA windows > > Prior to this CL, mixed-security content was blocked entirely in > standalone PWA windows with scopes. This CL allows those PWAs to display > mixed-security content, but when this happens, the window will show the > CustomTabBarView with the URL and a "Not Secure" indicator to indicate > the presence of mixed content. > > Screenshot: > https://bugs.chromium.org/p/chromium/issues/attachment?aid=432401&signed_aid=JeW6cXlVCQ3bSebdZ-FoJg==&inline=1 > > This removes a behavioural difference between promoted PWAs and "create > shortcut" apps without manifest scopes. > > > Bug: 910016 > Change-Id: Ic9b3bbdba14218bb1ad8fd4f2ca8cf47cd4e3a37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041380 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742515} TBR=alancutter@chromium.org,estade@chromium.org,pbos@chromium.org,dominickn@chromium.org,glenrob@chromium.org Change-Id: Ibb71d71f13f3fea753b5cb80a4a98c733a093c12 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063015Reviewed-by:
-
