- 10 Mar, 2020 40 commits
-
-
Yoshifumi Inoue authored
This patch changes |LayoutInline::IsEmpty()| to handle |NGFragmentItem| to make |LayoutBox::ContainingBlockLogicalHeightForPositioned()| to return valid value for "top" property of |ComputedStyle|. Before this patch, |ContainingBlockLogicalHeightForPositioned()| always return zero for |LayoutInline| even if it has inline children. Note: This patch makes computed-style-percentage-top-with-position-inline.html to pass. Bug: 982194 Change-Id: Ic3a83d6b745966a38b86ceb5c899ea2d523b06a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094382 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#748580}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1234c8aa625f..da7205379701 git log 1234c8aa625f..da7205379701 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 treehugger-gerrit@google.com Merge "record_page: include two missing Android log buffer options" 2020-03-09 treehugger-gerrit@google.com Merge "traced_perf: allow slow proc-fd lookups to recover from expired state" 2020-03-09 treehugger-gerrit@google.com Merge changes I3010621d,I4f59d1b4 2020-03-09 treehugger-gerrit@google.com Merge "traced_perf: unwind queue type" 2020-03-09 taylori@google.com Merge "perfetto-ui: Handle resolution is Infinity" 2020-03-09 ilkos@google.com Merge "Fix joining at the boundary" 2020-03-09 ilkos@google.com Merge "Add task names metric" 2020-03-09 hjd@google.com Merge "trace_processor: Pass track_id constraint to generator" Created with: gclient setdep -r src/third_party/perfetto@da7205379701 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9f2f1bfc87aac80430c1fb3e78c18be836352eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095663Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748579}
-
Anand K. Mistry authored
activate() is inconsistently called when a TreeItem is clicked, but is always called when the user navigates using the keyboard. Since activate() is meant to be called when the user activates an item, regardless of method, ensure this happens. Bug: 1060061 Change-Id: I3151576f380be6a370962710724c183e1b6f160d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094907Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#748578}
-
Takuto Ikuta authored
This is reland of crrev.com/c/1989300 But use dev instance of buildbucket/milo Bug: b/144318226 Change-Id: I6472fbb66ecbd882c62c523d803b7de66c7aad20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094434 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#748577}
-
Mike Dougherty authored
This metric is used on one of our dashboards, so extending the date to close to the end of the year to match other Stability.* metrics. Change-Id: Ic8bd51d401e95022678a0b30fc67a9f5ae439416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093162Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#748576}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f333272eb504..343d4f6f1870 git log f333272eb504..343d4f6f1870 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 johnkslang@users.noreply.github.com Merge pull request #2109 from jeffbolznv/disable_escape Created with: gclient setdep -r src/third_party/glslang/src@343d4f6f1870 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: Id9440846339995828111e3d6d021f4b175ae1e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095792Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a1ac244222a5..137991396d03 git log a1ac244222a5..137991396d03 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 hta@webrtc.org Make a switch to disable DTLS 1.0, TLS 1.0 and TLS 1.1 downgrade in WebRTC. 2020-03-09 srte@webrtc.org Fix for out-of-bounds write in square test frame generator. Created with: gclient setdep -r src/third_party/webrtc@137991396d03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I576c16b4a468787ffdd216e224b517e541231fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095162Reviewed-by:
-
Maksim Ivanov authored
Fix the a11y regression introduced in https://crrev.com/c/2030411, which was that the focus was lost after the wrong PIN is entered. The problem was caused by the fact that the whole PIN dialog, including the input field, gets hidden while showing the "progress bar" animation during PIN verification. The focus on the input field becomes lost when it's hidden, and it's not restored automatically when it's re-shown again. The fix is to programmatically set the focus every time the PIN dialog is updated, so that this happens after the PIN verification completes too. Note that this is done unconditionally, so that entering a wrong PIN is guaranteed to trigger the a11y event with the error message for the user. Bug: 1016839 Test: start smart card SAML login, enter wrong PIN, check that the focus stays on PIN input after the progress bar animation stops Change-Id: I6a712c79eedc961f7da26dacfbb6f3df5db01396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087920Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#748573}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/abdb603cd140..9e5db26faa43 git log abdb603cd140..9e5db26faa43 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 chonggu@google.com Remove bitmaptools.cc from Fuchsia builds. Created with: gclient setdep -r src/third_party/catapult@9e5db26faa43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058255 Tbr: nuskos@google.com Change-Id: I03c7544e6dedd8da84f6d50dcb3b8c6c6bcd1939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095661Reviewed-by:
-
Kunihiko Sakamoto authored
This CL adds a histogram to track occurrence of ERR_TOO_MANY_REDIRECTS error caused by Signed Exchange's fallback redirects. Bug: 1058314 Change-Id: I56fa7b2e0ef824152e3b0d2dbfec49f21ea725c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086367Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#748571}
-
Rakina Zata Amni authored
Currently we are using idle tasks for find-in-page tasks, which might lead to a very long wait for find-in-page matches when the page is rarely/never idle. This CL changes find-in-page to use non-idle tasks and also added FindInPageBudgetPoolController to help calculate budgets for find-in-page tasks, changing the priority when the budget is exhausted/replenished. See https://groups.google.com/a/chromium.org/d/msg/blink-dev/lqIezO-_ifg/vu7sF9eiBAAJ for context. Bug: 1045517 Change-Id: I32af393d0727006802a09882cc5a485793908c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041711 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748570}
-
Ken Rockot authored
This is a reland of aa7438aa Unmodified from the original CL, as breakage was from a precursor that has since been fixed and relanded. Original change's description: > Convert some mojo_base typemaps to GN targets > > Uses new GN-based typemap definitions to replace some typemap files in > mojo/public/cpp/base. > > Bug: 1059389 > Change-Id: If1389c9ceec8ae90df753895af0abd9f72c704a0 > Tbr: dtapuska@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090723 > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#748056} Bug: 1059389 Change-Id: I5bbe5afff09493b3394f8922c3fe190e731305b7 Tbr: dcheng@chromium.org Tbr: tsepez@chromium.org Tbr: oksamyt@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095929Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#748569}
-
Mitsuru Oshima authored
This is a speculative fix for crbug.com/1041932 Bug: 1041932 Change-Id: I0dfe7479967729dc242f32eba4772107fcc3f7ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093073 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#748568}
-
Abhijeet Singh authored
Add a user-consent view informing the users about the Quick-Answers functionality. The quick-answers will only be enabled if the user grants her consent by acknowledging this view. The view will be shown to the users a maximum of 3 times or until an accumulated of 8 seconds it is impressed. Bug: b:148956341 Test: Tested locally on atlas device Change-Id: I46d0cfd5d82ced03ef610ab8624b909fa1403223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077589 Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#748567}
-
Hirokazu Honda authored
Unless this is specified, pre-submit checks warns the test-only code is used in product code. Bug: None Test: Build tests Change-Id: I9dac62a4a5079a46a12e9e8e716bd33449f17610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094521 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#748566}
-
Sven Zheng authored
This should reduce the flakiness. Deactivated dialog pixel outputs should be more predictable than activated dialog. https://chrome-gold.skia.org/detail?test=BrowserUiDialog_TabGroupEditorBubbleViewDialogBrowserTest_InvokeUi_default&digest=45c8d0767462989beefdc816a729c3ad https://chrome-gold.skia.org/detail?test=BrowserUiDialog_TabGroupEditorBubbleViewDialogBrowserTest_InvokeUi_default&digest=f0f4b37daa5fc41c5481163af8fc079e Bug: 1059469 Change-Id: I1f7ebe20b4c58d4ba7481e4bcba9b177b205b91b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095769 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#748565}
-
sczs authored
Bug: 1029067 Change-Id: I4fdd0da6e1294bd8057e4f47afa446caa05d9a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093133 Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#748564}
-
Jeremy Roman authored
Bug: 794320 Change-Id: If5776962746a12481fd89426f5e13a3ab6b79214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095779Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#748563}
-
Bo Liu authored
Currently WebContents visibility is only dependent on whether it is the active tab in a browser. This means the active tab will always be marked visible, even if the fragment or activity is hidden. Instead compute visibility has being the active tab in a visible (ie onStart-ed) fragment. Override Fragment.onStart/onStop, and keep the state in BrowserImpl. Keep the active state in TabImpl. When either changes, recompute visibility for the tab's WebContents. Bug: 1058510 Change-Id: I726144afee2a28f97cf0d9d2ecf6f1d028973c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094455Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#748562}
-
Toni Barzic authored
Oobe dialog elements have show() method that focuses the default element in the dialog, and updates the dialog scroll. Use it in gesture navigation dialog to show pages (which are oobe dialogs). This fixes the issue where the scroll background is show on the intro page (as the scroll is calculated using obsolete bounds). Upadating scroll also made the animation pages scrollable, so this tweaks the animation positioning in the screen. While here, mark next buttons with focus-on-show class, so they get focused when a screen page is shown. BUG=1058885 Change-Id: I23c44cb03afd713c35aa0a83f9fc59081a8a7b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092948 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#748561}
-
Olivier Yiptong authored
Implements the enumeration of system fonts on Mac. This change calls the CoreText APIs to enumerate the list of fonts installed on a system. It has been implemented in FontCache so that it is accessible in the renderer process due to concerns about expensive I/O if implemented browser-side. Caching code will come in a subsequent CL. Bug: 1043306 Change-Id: Iae9ce6c08174d8b4ced80eda07c795444998c746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091597 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#748560}
-
Xinghui Lu authored
The flags were used for launches on Android in M79. They were set to enable by default in M81. They will be removed in this CL in M82. Bug: 995926 Change-Id: I8035064bafd38e3eb239c345e5cde0c5074a6402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095703Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#748559}
-
Sophie Chang authored
Bug: 1056843 Change-Id: Ic8667c5ae2921a2b0743fa2a2f31109fce444b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079859 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#748558}
-
Pavel Yatsuk authored
InfoBar provides an accessor method to get to SnackbarManager. TranslateCompactInfoBar is the only infobar that uses this method. Having this method means that InfoBar needs to know how to get to SnackbarManager instance. Modularized InfoBar shouldn't have access to ChromeActivity. This CL removes InfoBar dependency on SnackbarManager and makes obtaining reference to SnackbarManager a responsibility of the calling component (in this case TranslateCompactInfoBar). BUG=1056346 R=mdjones@chromium.org Change-Id: I33f366ed49dfd6ad51c406a7a6d0e8ffea056d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095708Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#748557}
-
Keita Suzuki authored
This commit updates blink web_tests to use pywebsocket3. It updates blinkpy/server/pywebsocket to import pywebsocket3 for its path. This commit also fixes the websocket handlers in web_tests. It update the handlers to use pywebsocket3 functions instead of old ones, and also updates the websocket handlers that use chr() to generate bytes string, to use util.pack_byte(), since chr() does not generate bytes in python 3. Change-Id: I2fbc365571b2ca0ee947355a2f95700350675fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059705Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Keita Suzuki <suzukikeita@google.com> Cr-Commit-Position: refs/heads/master@{#748556}
-
Anand K. Mistry authored
Call with super.handleClick() instead to follow the class prototype chain. Bug: 1060061 Change-Id: Ib63980978124b62a7a6201f7737b8eda27b1e925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094851Reviewed-by:
-
Peng Huang authored
With this CL, SkiaOutputSurfaceImpl will create SkSurfaceCharazation on viz thread directlly instead of ask gpu thread to create it for us. But for WebView, we still need to ask GPU thread to get necessary info, so we can create SkSurfaceCharazation on viz thread. Bug: 1041949 Change-Id: Id6bb23e63d5191b67b446a8f843ca06c1e63b18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088343 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
-
Theresa Wellington authored
Patchset 1 of 3 to introduce new target and switch upstream dependencies. Patchset 2 will update downstream build targets. Patchset 3 will remove the old //chrome/lib/ directory. BUG=1052382 Change-Id: Ia17859f630003eded43ee1b928e8ddc2ab22814e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095444Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#748553}
-
Jared Saul authored
This CL cleans up AutofillUpstreamEditableCardholderName and AutofillUpstreamAlwaysRequestCardholderName now that the cardholder name fix flow is fully launched to all platforms, including iOS. Bug: 907355 Change-Id: I201c9a29104b369b90fcc25cf9fcaa5f0f45e265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095921Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#748552}
-
Domenic Denicola authored
This plumbs the origin policy IDs from the net-side OriginPolicyContents through to the renderer, where they get exposed on Window. This does not yet tackle WorkerGlobalScope, but it does add idlharness tests for it, which fail for now. This is a re-land of https://chromium-review.googlesource.com/c/chromium/src/+/2089994 which was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/2093453. The re-land adds MSAN test expectations per https://crbug.com/856601. Bug: 1057123 Change-Id: I30053986f3dfc634399c8e0f3fc1578e062c67f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095706 Auto-Submit: Domenic Denicola <domenic@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Nicolás Peña Moreno authored
This CL allows LCP to use the first input or scroll on the page to invalidate LCP values from any frame. Doc describing the logic: https://docs.google.com/document/d/1uOLW-uAZwvBLrH5ST0OgdAJMmqY37MqBJEZRzTBKgp4/edit Bug: 1050727 Change-Id: Id9ad7c06750af110d6b7f3eec8637a9615f270b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083861Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#748550}
-
Tal Pressman authored
1. Introduce HeapMojoUniqueReceiverSet and unit test (based on HeapMojoReceiverSet). 2. Change usages of mojo::{Remote, UniqueReceiverSet} to HeapMojo{Remote, UniqueReceiverSet}. Bug: 1049056 Change-Id: I821aebfb6bd48082543dce0e2d224ebc6e31bb5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079721 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#748549}
-
Will Harris authored
BUG=767906 Change-Id: If0c7c542cb19c5997be1d417a9e4df24c170ba46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095964Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#748548}
-
Kent Tamura authored
Add two functions for the beginning and the end of TruncateLine(). These functions will be used by 'middle-ellipsis' feature. This CL has no behavior changes. Bug: 1060022 Change-Id: I87146ccad6637f18f297066cfb67e49abfccdfbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094919Reviewed-by:
-
John Lee authored
Bug: 1027373 Change-Id: I68f544db08731ec3c02213258dc0709589c27292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095559Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#748546}
-
Jeevan Shikaram authored
This reverts commit b5046a36. Reason for revert: system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/browse:tech:discourse_infinite_scroll:2018 is failing. Original change's description: > Changed infinite iterations's representation from -1 to infinity(). > > In blink we use -1 to represent infinite iterations for historical > reasons. Rather, we should use std::numeric_limits<double>::infinity() > to be more specification-complaint. > > CL based on crrev.com/c/1373409. > > Bug: 913662 > Change-Id: I3b2ff0c44d36c03654d77784c3867555603b0576 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071100 > Reviewed-by: Ian Vollick <vollick@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Yi Gu <yigu@chromium.org> > Reviewed-by: Daniel Libby <dlibby@microsoft.com> > Commit-Queue: Annie Liu <t-hunliu@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#748383} TBR=vollick@chromium.org,majidvp@chromium.org,yigu@chromium.org,dlibby@microsoft.com,t-hunliu@microsoft.com Change-Id: Ic85093b6bb9f0d15a45cf65dbefa410e66b43346 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 913662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094489Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#748545}
-
Martin Kreichgauer authored
The IsUserVerifyingPlatformAuthenticator() WebAuthn API call needlessly required the content embedder to provide their own implementation in an AuthenticatorRequestClientDelegate specialization. This change moves the ChromeAuthenticatorRequestDelegate implementation into the content layer (AuthenticatorCommon). The implementation is general enough to be useful for other embedders and it doesn't depend on any state internal to the delegate. Concretly, IsUVPAA() - on Windows returns the corresponding value from the native WebAuthn API; - on macOS reflects TouchIdAuthenticator availability as long as the embedder provides an implementation of GetTouchIdAuthenticatorConfig. Also collapse methods in AuthenticatorCommon that determine which transports to instantiate discoveries for, and also add a safeguard against instantiating platform discoveries in contexts where IsUVPAA() returns false. Change-Id: I8eb68ca6f8cd17fae61d9d0294b872ef0cfb3465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083936 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#748544}
-
David Munro authored
Test: None Bug: None Change-Id: Ia7cd6efe90968e06c0a4a96f7e2104e05ee9e961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091091 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#748543}
-
Victor Costan authored
Replacing includes with forward declarations helps reduce compilation time. To be clear, I doubt that the CQ time burnt by this CL will ever be recovered by the tiny savings in compilation time over all future Chromium builds. However, I point folks building new APIs to the Cookie Store API as an example of reasonably modern code, so I think there's value in getting the details right. Change-Id: I00ff2885b331bdd23fac392372e127c2e3817896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093398 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#748542}
-
Shakti Sahu authored
Bug: 1054552 Change-Id: I7fc3d29498aec9a429e792145f865f0e6898d542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090606 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
